)]}'
{"ironic/drivers/modules/virtual_media_base.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"4d3d9c21365d029693018006e9e584739c2ca576","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    `bootloader` if it\u0027s UEFI boot), then push built image up to Swift and"},{"line_number":44,"context_line":"    return a temporary URL."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    If `configdrive` is specified it will be eventually written onto"},{"line_number":47,"context_line":"    the boot ISO image."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    :param task: a TaskManager instance containing the node to act on."}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4c43b2_decd1332","line":46,"range":{"start_line":46,"start_character":45,"end_line":46,"end_character":56},"updated":"2020-04-20 12:48:42.000000000","message":"nit: s/eventually//","commit_id":"716eb5829e198c347358887b3c8e00e4381e8202"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"5ec5294bcd07be2efad60814c2bf09fa81e58ff6","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    `bootloader` if it\u0027s UEFI boot), then push built image up to Swift and"},{"line_number":44,"context_line":"    return a temporary URL."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    If `configdrive` is specified it will be eventually written onto"},{"line_number":47,"context_line":"    the boot ISO image."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    :param task: a TaskManager instance containing the node to act on."}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4c43b2_04972cee","line":46,"range":{"start_line":46,"start_character":45,"end_line":46,"end_character":56},"in_reply_to":"3f4c43b2_decd1332","updated":"2020-04-20 14:26:12.000000000","message":"Done","commit_id":"716eb5829e198c347358887b3c8e00e4381e8202"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"4d3d9c21365d029693018006e9e584739c2ca576","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    :param kernel_href: URL or Glance UUID of the kernel to use"},{"line_number":51,"context_line":"    :param ramdisk_href: URL or Glance UUID of the ramdisk to use"},{"line_number":52,"context_line":"    :param deploy_iso_href: URL or glance UUID of the deploy ISO image"},{"line_number":53,"context_line":"        to extract EFI system partition image. If not specified,"},{"line_number":54,"context_line":"        the `esp_image_href` option must be present if UEFI-bootable"},{"line_number":55,"context_line":"        ISO is desired."},{"line_number":56,"context_line":"    :param bootloader_href: URL or Glance UUID of the EFI bootloader"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4c43b2_1ed49bbc","line":53,"updated":"2020-04-20 12:48:42.000000000","message":"nit: ... from.","commit_id":"716eb5829e198c347358887b3c8e00e4381e8202"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"5ec5294bcd07be2efad60814c2bf09fa81e58ff6","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    :param kernel_href: URL or Glance UUID of the kernel to use"},{"line_number":51,"context_line":"    :param ramdisk_href: URL or Glance UUID of the ramdisk to use"},{"line_number":52,"context_line":"    :param deploy_iso_href: URL or glance UUID of the deploy ISO image"},{"line_number":53,"context_line":"        to extract EFI system partition image. If not specified,"},{"line_number":54,"context_line":"        the `esp_image_href` option must be present if UEFI-bootable"},{"line_number":55,"context_line":"        ISO is desired."},{"line_number":56,"context_line":"    :param bootloader_href: URL or Glance UUID of the EFI bootloader"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4c43b2_648710b7","line":53,"in_reply_to":"3f4c43b2_1ed49bbc","updated":"2020-04-20 14:26:12.000000000","message":"Done","commit_id":"716eb5829e198c347358887b3c8e00e4381e8202"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"4d3d9c21365d029693018006e9e584739c2ca576","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    :param ramdisk_href: URL or Glance UUID of the ramdisk to use"},{"line_number":52,"context_line":"    :param deploy_iso_href: URL or glance UUID of the deploy ISO image"},{"line_number":53,"context_line":"        to extract EFI system partition image. If not specified,"},{"line_number":54,"context_line":"        the `esp_image_href` option must be present if UEFI-bootable"},{"line_number":55,"context_line":"        ISO is desired."},{"line_number":56,"context_line":"    :param bootloader_href: URL or Glance UUID of the EFI bootloader"},{"line_number":57,"context_line":"        image to use when creating UEFI bootbable ISO"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4c43b2_fef1ef6c","line":54,"updated":"2020-04-20 12:48:42.000000000","message":"nit: present where? it doesn\u0027t seem to be an argument here.","commit_id":"716eb5829e198c347358887b3c8e00e4381e8202"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"5ec5294bcd07be2efad60814c2bf09fa81e58ff6","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    :param ramdisk_href: URL or Glance UUID of the ramdisk to use"},{"line_number":52,"context_line":"    :param deploy_iso_href: URL or glance UUID of the deploy ISO image"},{"line_number":53,"context_line":"        to extract EFI system partition image. If not specified,"},{"line_number":54,"context_line":"        the `esp_image_href` option must be present if UEFI-bootable"},{"line_number":55,"context_line":"        ISO is desired."},{"line_number":56,"context_line":"    :param bootloader_href: URL or Glance UUID of the EFI bootloader"},{"line_number":57,"context_line":"        image to use when creating UEFI bootbable ISO"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4c43b2_44b6548c","line":54,"in_reply_to":"3f4c43b2_fef1ef6c","updated":"2020-04-20 14:26:12.000000000","message":"Done","commit_id":"716eb5829e198c347358887b3c8e00e4381e8202"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"4d3d9c21365d029693018006e9e584739c2ca576","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    :param root_uuid: optional uuid of the root partition."},{"line_number":59,"context_line":"    :param kernel_params: a string containing whitespace separated values"},{"line_number":60,"context_line":"        kernel cmdline arguments of the form K\u003dV or K (optional)."},{"line_number":61,"context_line":"    :param timeout: for how long should Swift hold  boot image if the"},{"line_number":62,"context_line":"        underlying hardware type is `redfish`. Default is no timeout."},{"line_number":63,"context_line":"    :param use_web_server: if `True`, upload boot image to ironic HTTP"},{"line_number":64,"context_line":"        server rather than to Swift. Default is `False`."}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4c43b2_5e02a33e","line":61,"updated":"2020-04-20 12:48:42.000000000","message":"nit: in seconds?\n\nalso s/hold/keep/ I think","commit_id":"716eb5829e198c347358887b3c8e00e4381e8202"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"5ec5294bcd07be2efad60814c2bf09fa81e58ff6","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    :param root_uuid: optional uuid of the root partition."},{"line_number":59,"context_line":"    :param kernel_params: a string containing whitespace separated values"},{"line_number":60,"context_line":"        kernel cmdline arguments of the form K\u003dV or K (optional)."},{"line_number":61,"context_line":"    :param timeout: for how long should Swift hold  boot image if the"},{"line_number":62,"context_line":"        underlying hardware type is `redfish`. Default is no timeout."},{"line_number":63,"context_line":"    :param use_web_server: if `True`, upload boot image to ironic HTTP"},{"line_number":64,"context_line":"        server rather than to Swift. Default is `False`."}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4c43b2_647550cb","line":61,"in_reply_to":"3f4c43b2_5e02a33e","updated":"2020-04-20 14:26:12.000000000","message":"Done","commit_id":"716eb5829e198c347358887b3c8e00e4381e8202"}]}
