)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"df62f158fd838b18f3547778ea868b80262a5e58","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This reverts commit c4d9984c51b15680ab4bfe38764942278ece5e1f."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"As per upstream/IRC discussion to address the problems documented here [1]."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Besides minor hiccups (documented in the story), the proposal is to avoid building a swiss-army-knife function, but to either decompose the code onto smaller functional pieces and call them as appropriate or to introduce some overridable methods/properties for the vendor drivers to define/override."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1f493fa4_9eccb962","line":11,"updated":"2020-04-20 17:01:38.000000000","message":"Please wrap this. line.","commit_id":"6981403ebea973927aafa38c67a888ab46a89314"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"a2879e5bfa67aeb91acf923139331d69cce0494d","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This reverts commit c4d9984c51b15680ab4bfe38764942278ece5e1f."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"As per upstream/IRC discussion to address the problems documented here [1]."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Besides minor hiccups (documented in the story), the proposal is to avoid building a swiss-army-knife function, but to either decompose the code onto smaller functional pieces and call them as appropriate or to introduce some overridable methods/properties for the vendor drivers to define/override."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1f493fa4_fee33da3","line":11,"in_reply_to":"1f493fa4_9eccb962","updated":"2020-04-20 17:09:27.000000000","message":"Done","commit_id":"6981403ebea973927aafa38c67a888ab46a89314"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"df62f158fd838b18f3547778ea868b80262a5e58","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"As per upstream/IRC discussion to address the problems documented here [1]."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Besides minor hiccups (documented in the story), the proposal is to avoid building a swiss-army-knife function, but to either decompose the code onto smaller functional pieces and call them as appropriate or to introduce some overridable methods/properties for the vendor drivers to define/override."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"1. https://storyboard.openstack.org/#!/story/2007576"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1f493fa4_7e344d4b","line":13,"range":{"start_line":13,"start_character":49,"end_line":13,"end_character":265},"updated":"2020-04-20 17:01:38.000000000","message":"This should be wrapped, and reads as if this is overall review feedback to the original change set. I agree some of the changes could haven smaller and more specific, but some of the changes also sought to move things in a better direction.","commit_id":"6981403ebea973927aafa38c67a888ab46a89314"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"78e31c4b244bc89f40abadf81abd755d628964fc","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"As per upstream/IRC discussion to address the problems documented here [1]."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Besides minor hiccups (documented in the story), the proposal is to avoid building a swiss-army-knife function, but to either decompose the code onto smaller functional pieces and call them as appropriate or to introduce some overridable methods/properties for the vendor drivers to define/override."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"1. https://storyboard.openstack.org/#!/story/2007576"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1f493fa4_5f97af91","line":13,"range":{"start_line":13,"start_character":49,"end_line":13,"end_character":265},"in_reply_to":"1f493fa4_3e62c517","updated":"2020-04-21 22:37:10.000000000","message":"Thanks,\n\nThe key is not everything IS redfish based a number of the methods are functionally duplicate behavior, so there is a fine line we need to walk, and we need to be willing to kind of take an intermediate path which is kind of how I viewed the patch to begin with.","commit_id":"6981403ebea973927aafa38c67a888ab46a89314"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"a2879e5bfa67aeb91acf923139331d69cce0494d","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"As per upstream/IRC discussion to address the problems documented here [1]."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Besides minor hiccups (documented in the story), the proposal is to avoid building a swiss-army-knife function, but to either decompose the code onto smaller functional pieces and call them as appropriate or to introduce some overridable methods/properties for the vendor drivers to define/override."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"1. https://storyboard.openstack.org/#!/story/2007576"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1f493fa4_3e62c517","line":13,"range":{"start_line":13,"start_character":49,"end_line":13,"end_character":265},"in_reply_to":"1f493fa4_7e344d4b","updated":"2020-04-20 17:09:27.000000000","message":"Done.\n\nI think it would be best with this patch to pave the path for the vendors to rebase their vmedia implementation (as well as other redfishy things) on top of our base/standard Redfish code.\n\nThe monster function way might not be the best possible approach considering the open-ended nature of those vendor-specific features.","commit_id":"6981403ebea973927aafa38c67a888ab46a89314"}]}