)]}'
{"ironic/drivers/modules/agent_client.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"0dc9dfac1203802696f85e77f305ff7222402418","unresolved":false,"context_lines":[{"line_number":150,"context_line":"                      {\u0027method\u0027: method, \u0027node\u0027: node.uuid,"},{"line_number":151,"context_line":"                       \u0027code\u0027: response.status_code})"},{"line_number":152,"context_line":"            raise exception.AgentAPIError(node\u003dnode.uuid,"},{"line_number":153,"context_line":"                                          status\u003dresponse.status_code,"},{"line_number":154,"context_line":"                                          error\u003dresult.get(\u0027faultstring\u0027))"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"        return result"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_7a00a768","line":153,"updated":"2020-04-22 16:21:11.000000000","message":"probably error_code here?","commit_id":"d9fdfd0b6833804ef6acab11dc378e22f62b2d74"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"022f738410c39c1911854e3764a76997ad286e76","unresolved":false,"context_lines":[{"line_number":146,"context_line":"            LOG.error(\u0027Agent command %(method)s for node %(node)s failed. \u0027"},{"line_number":147,"context_line":"                      \u0027Expected 2xx HTTP status code, got %(code)d.\u0027,"},{"line_number":148,"context_line":"                      {\u0027method\u0027: method, \u0027node\u0027: node.uuid,"},{"line_number":149,"context_line":"                       \u0027code\u0027: response.status_code})"},{"line_number":150,"context_line":"            raise exception.AgentAPIError(node\u003dnode.uuid,"},{"line_number":151,"context_line":"                                          status\u003dresponse.status_code,"},{"line_number":152,"context_line":"                                          error\u003dresult.get(\u0027faultstring\u0027))"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f493fa4_df9f1601","line":149,"updated":"2020-04-23 13:29:53.000000000","message":"Maybe update this to also output the value of exc_type. Also, will exc_type be TypeError with status_code \u003c BAD_REQUEST? If so, maybe have two diff log strings, or eg \u0027Expected 2xx HTTP status code and no command error. Got status (code)d and exc type (exc)s\u0027.\n\nIf exc_type, would it be useful to also log the value of \u0027error\u0027 here?","commit_id":"bae6cc33936f50fcad50a013f469ea2329738bff"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"aa0bf0e448b8348882d2c1cbd0b3d08a125d8a90","unresolved":false,"context_lines":[{"line_number":156,"context_line":"                       \u0027exc_type\u0027: exc_type, \u0027error\u0027: error})"},{"line_number":157,"context_line":"            raise exception.AgentAPIError(node\u003dnode.uuid,"},{"line_number":158,"context_line":"                                          status\u003derror.get(\u0027code\u0027),"},{"line_number":159,"context_line":"                                          error\u003dresult.get(\u0027faultstring\u0027))"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"        return result"},{"line_number":162,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1f493fa4_4c233d06","line":159,"updated":"2020-04-24 21:32:54.000000000","message":"I don\u0027t know what this value has, vs the error variable, or which might be more useful. I didn\u0027t verify this, but I\u0027ll assume it is good :)","commit_id":"bfeef067aac7572bb914396db4553da5c013403f"}]}