)]}'
{"ironic/tests/unit/db/sqlalchemy/test_migrations.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a278d154acba77d414906729114393041b4c89f1","unresolved":false,"context_lines":[{"line_number":161,"context_line":""},{"line_number":162,"context_line":"        self.migration_api.version.assert_called_with(self.config)"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"        upgraded \u003d [mock.call(self.engine, self.config, v.revision,"},{"line_number":165,"context_line":"                    with_data\u003dTrue) for v in reversed(self.versions)]"},{"line_number":166,"context_line":"        self.assertEqual(self._migrate_up.call_args_list, upgraded)"},{"line_number":167,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1f493fa4_f851ecda","line":164,"updated":"2020-04-28 13:15:27.000000000","message":"In a similar patch to inspector I had to add the implicit \"self\" argument. I wonder if it\u0027s the case here..","commit_id":"4d6583264f5b9ef4095a01fdf958e9f6675f8bad"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"f38702dffc10df878f1f6f160d85f2f3ee9a5d37","unresolved":false,"context_lines":[{"line_number":161,"context_line":""},{"line_number":162,"context_line":"        self.migration_api.version.assert_called_with(self.config)"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"        upgraded \u003d [mock.call(self.engine, self.config, v.revision,"},{"line_number":165,"context_line":"                    with_data\u003dTrue) for v in reversed(self.versions)]"},{"line_number":166,"context_line":"        self.assertEqual(self._migrate_up.call_args_list, upgraded)"},{"line_number":167,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1f493fa4_9b7422d1","line":164,"in_reply_to":"1f493fa4_f851ecda","updated":"2020-04-28 14:26:07.000000000","message":"you\u0027re right, I ran the tests locally and it was failing because of that and the missing config in L156, I will add them","commit_id":"4d6583264f5b9ef4095a01fdf958e9f6675f8bad"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"d01d4ebf8ec3a99affbc0d8abc8254bafaa23b88","unresolved":false,"context_lines":[{"line_number":153,"context_line":"    @mock.patch.object(script, \u0027ScriptDirectory\u0027, autospec\u003dTrue)"},{"line_number":154,"context_line":"    @mock.patch.object(WalkVersionsMixin, \u0027_migrate_up\u0027, autospec\u003dTrue)"},{"line_number":155,"context_line":"    def test_walk_versions_all_default(self, _migrate_up, script_directory):"},{"line_number":156,"context_line":"        fc \u003d script_directory.from_config(self.config)"},{"line_number":157,"context_line":"        fc.walk_revisions.return_value \u003d self.versions"},{"line_number":158,"context_line":"        self.migration_api.version.return_value \u003d None"},{"line_number":159,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1f493fa4_7db3060b","line":156,"range":{"start_line":156,"start_character":41,"end_line":156,"end_character":54},"updated":"2020-04-28 16:34:48.000000000","message":"This works, but is actually redundant. It\u0027s a mock, we shouldn\u0027t try to call it, just take return_value (see my inspector patch)","commit_id":"cf25eca8b85d9e06ee4ecdb7fa1cfb2c4f9ffb96"}],"tox.ini":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"fb7328c97af9277d2d1e4efe8caaee375781d841","unresolved":false,"context_lines":[{"line_number":123,"context_line":"# [H210] Require ‘autospec’, ‘spec’, or ‘spec_set’ in mock.patch/mock.patch.object calls"},{"line_number":124,"context_line":"# [H904] Delay string interpolations at logging calls."},{"line_number":125,"context_line":"enable-extensions\u003dH106,H203,H204,H205,H210,H904"},{"line_number":126,"context_line":"per-file-ignores \u003d"},{"line_number":127,"context_line":"    ironic/tests/unit/api/*:H210"},{"line_number":128,"context_line":"    ironic/tests/unit/conductor/*:H210"},{"line_number":129,"context_line":"    ironic/tests/unit/common/*:H210"}],"source_content_type":"text/x-properties","patch_set":3,"id":"1f493fa4_c4d890f0","line":126,"updated":"2020-04-28 12:57:48.000000000","message":"Let\u0027s leave a TODO to remove these all","commit_id":"73d16bae6bd8c20ced9bfa043ea378375485505d"}]}