)]}'
{"ironic/conductor/manager.py":[{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"4b93b33d63da41f3885004c121834d81228cfbbd","unresolved":false,"context_lines":[{"line_number":89,"context_line":"                   default\u003d60,"},{"line_number":90,"context_line":"                   help\u003d\u0027Interval between checks of provision timeouts, \u0027"},{"line_number":91,"context_line":"                        \u0027in seconds.\u0027),"},{"line_number":92,"context_line":"        cfg.IntOpt(\u0027callback_timeout\u0027,"},{"line_number":93,"context_line":"                   default\u003d0,"},{"line_number":94,"context_line":"                   help\u003d\u0027Timeout (seconds) for waiting callback from deploy \u0027"},{"line_number":95,"context_line":"                        \u0027ramdisk. Default 0 (unlimited).\u0027),"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAVX%2F%2F%2FYY%3D","line":92,"updated":"2014-02-27 00:01:44.000000000","message":"please make the name more clear:\n\n  s/callback_timeout/deploy_callback_timeout/","commit_id":"929ed0dabe058165c144ae8973787192fab6d862"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"00f2674a31e522950d0d16f70a95131f8798cd02","unresolved":false,"context_lines":[{"line_number":89,"context_line":"                   default\u003d60,"},{"line_number":90,"context_line":"                   help\u003d\u0027Interval between checks of provision timeouts, \u0027"},{"line_number":91,"context_line":"                        \u0027in seconds.\u0027),"},{"line_number":92,"context_line":"        cfg.IntOpt(\u0027callback_timeout\u0027,"},{"line_number":93,"context_line":"                   default\u003d0,"},{"line_number":94,"context_line":"                   help\u003d\u0027Timeout (seconds) for waiting callback from deploy \u0027"},{"line_number":95,"context_line":"                        \u0027ramdisk. Default 0 (unlimited).\u0027),"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAVX%2F%2F5fE%3D","line":92,"in_reply_to":"AAAAVX%2F%2F%2FYY%3D","updated":"2014-02-27 14:26:48.000000000","message":"Done","commit_id":"929ed0dabe058165c144ae8973787192fab6d862"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"4b93b33d63da41f3885004c121834d81228cfbbd","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        cfg.IntOpt(\u0027callback_timeout\u0027,"},{"line_number":93,"context_line":"                   default\u003d0,"},{"line_number":94,"context_line":"                   help\u003d\u0027Timeout (seconds) for waiting callback from deploy \u0027"},{"line_number":95,"context_line":"                        \u0027ramdisk. Default 0 (unlimited).\u0027),"},{"line_number":96,"context_line":"]"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAVX%2F%2F%2FXw%3D","line":95,"updated":"2014-02-27 00:01:44.000000000","message":"This should default to something reasonable but non-zero. Let\u0027s set it to 1800 seconds.\n\nThere is an open bug in nova-baremetal about this, https://bugs.launchpad.net/nova/+bug/1195073. Let\u0027s not recreate it after I already said that it doesn\u0027t affect Ironic :)","commit_id":"929ed0dabe058165c144ae8973787192fab6d862"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"00f2674a31e522950d0d16f70a95131f8798cd02","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        cfg.IntOpt(\u0027callback_timeout\u0027,"},{"line_number":93,"context_line":"                   default\u003d0,"},{"line_number":94,"context_line":"                   help\u003d\u0027Timeout (seconds) for waiting callback from deploy \u0027"},{"line_number":95,"context_line":"                        \u0027ramdisk. Default 0 (unlimited).\u0027),"},{"line_number":96,"context_line":"]"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAVX%2F%2F5e4%3D","line":95,"in_reply_to":"AAAAVX%2F%2F%2FXw%3D","updated":"2014-02-27 14:26:48.000000000","message":"Done","commit_id":"929ed0dabe058165c144ae8973787192fab6d862"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"4b93b33d63da41f3885004c121834d81228cfbbd","unresolved":false,"context_lines":[{"line_number":457,"context_line":"                         seconds\u003dCONF.conductor.callback_timeout))"},{"line_number":458,"context_line":"                if timeutils.normalize_time(update_time) \u003c\u003d limit:"},{"line_number":459,"context_line":"                    try:"},{"line_number":460,"context_line":"                        with task_manager.acquire(context, node_uuid) as task:"},{"line_number":461,"context_line":"                            node \u003d task.node"},{"line_number":462,"context_line":"                            node.provision_state \u003d states.DEPLOYFAIL"},{"line_number":463,"context_line":"                            node.target_provision_state \u003d states.NOSTATE"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAVX%2F%2F%2FZ8%3D","line":460,"updated":"2014-02-27 00:01:44.000000000","message":"This needs to also start a background thread to call the driver.clean_up() method, or else we will leave danging files and network configuration.","commit_id":"929ed0dabe058165c144ae8973787192fab6d862"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"00f2674a31e522950d0d16f70a95131f8798cd02","unresolved":false,"context_lines":[{"line_number":457,"context_line":"                         seconds\u003dCONF.conductor.callback_timeout))"},{"line_number":458,"context_line":"                if timeutils.normalize_time(update_time) \u003c\u003d limit:"},{"line_number":459,"context_line":"                    try:"},{"line_number":460,"context_line":"                        with task_manager.acquire(context, node_uuid) as task:"},{"line_number":461,"context_line":"                            node \u003d task.node"},{"line_number":462,"context_line":"                            node.provision_state \u003d states.DEPLOYFAIL"},{"line_number":463,"context_line":"                            node.target_provision_state \u003d states.NOSTATE"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAVX%2F%2F5ew%3D","line":460,"in_reply_to":"AAAAVX%2F%2F%2FZ8%3D","updated":"2014-02-27 14:26:48.000000000","message":"Done","commit_id":"929ed0dabe058165c144ae8973787192fab6d862"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"e96a40d176179b48416c799b1e23fd9195709cad","unresolved":false,"context_lines":[{"line_number":85,"context_line":"                   default\u003d60,"},{"line_number":86,"context_line":"                   help\u003d\u0027Interval between syncing the node power state to the \u0027"},{"line_number":87,"context_line":"                        \u0027database, in seconds.\u0027),"},{"line_number":88,"context_line":"        cfg.IntOpt(\u0027provision_state_check_interval\u0027,"},{"line_number":89,"context_line":"                   default\u003d60,"},{"line_number":90,"context_line":"                   help\u003d\u0027Interval between checks of provision timeouts, \u0027"},{"line_number":91,"context_line":"                        \u0027in seconds.\u0027),"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAVX%2F%2F4l4%3D","line":88,"updated":"2014-02-27 15:58:11.000000000","message":"to be more consistent with sync_power_state_interval, \u0027check_provision_state_interval\u0027 might be better.","commit_id":"c6428dd14275fd18dea134c0ca99e2847e02f428"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"42659def313a3888460c568022aa272623053d0a","unresolved":false,"context_lines":[{"line_number":85,"context_line":"                   default\u003d60,"},{"line_number":86,"context_line":"                   help\u003d\u0027Interval between syncing the node power state to the \u0027"},{"line_number":87,"context_line":"                        \u0027database, in seconds.\u0027),"},{"line_number":88,"context_line":"        cfg.IntOpt(\u0027provision_state_check_interval\u0027,"},{"line_number":89,"context_line":"                   default\u003d60,"},{"line_number":90,"context_line":"                   help\u003d\u0027Interval between checks of provision timeouts, \u0027"},{"line_number":91,"context_line":"                        \u0027in seconds.\u0027),"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAVX%2F%2F4Is%3D","line":88,"in_reply_to":"AAAAVX%2F%2F4l4%3D","updated":"2014-02-27 16:36:36.000000000","message":"Done","commit_id":"c6428dd14275fd18dea134c0ca99e2847e02f428"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"9e2b5ad4f48127605d57d43e5e9e02dcb915375c","unresolved":false,"context_lines":[{"line_number":460,"context_line":"            if state \u003d\u003d states.DEPLOYWAIT:"},{"line_number":461,"context_line":"                limit \u003d (timeutils.utcnow() - datetime.timedelta("},{"line_number":462,"context_line":"                         seconds\u003dCONF.conductor.deploy_callback_timeout))"},{"line_number":463,"context_line":"                if timeutils.normalize_time(update_time) \u003c\u003d limit:"},{"line_number":464,"context_line":"                    try:"},{"line_number":465,"context_line":"                        task \u003d task_manager.TaskManager(context, node_uuid)"},{"line_number":466,"context_line":"                    except (exception.NodeLocked, exception.NodeNotFound):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAVX%2F%2F5a4%3D","line":463,"updated":"2014-02-27 14:52:53.000000000","message":"If there are a lot of nodes in DEPLOYWAIT, this query will return all of them, and then this loop will try to spawn workers for all of them. This will cause a bunch of errors to be logged if there are more results than available worker threads.\n\nSo, we can easily optimize this by adding a query filter for provision_updated_at, sort oldest first, and use a reasonably small LIMIT (eg, smaller than rpc_thread_count). \n\nLet\u0027s file a bug, link it here, and keep going.","commit_id":"c6428dd14275fd18dea134c0ca99e2847e02f428"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"9e2b5ad4f48127605d57d43e5e9e02dcb915375c","unresolved":false,"context_lines":[{"line_number":479,"context_line":"                        cleanup \u003d task.driver.deploy.clean_up"},{"line_number":480,"context_line":"                        thread \u003d self._spawn_worker(cleanup, task, node)"},{"line_number":481,"context_line":"                        thread.link(lambda t: task.release_resources())"},{"line_number":482,"context_line":"                    except Exception as e:"},{"line_number":483,"context_line":"                        msg \u003d (_(\u0027Cleanup task not started for node %(node)s \u0027"},{"line_number":484,"context_line":"                                 \u0027after callback timeout: %(error)s\u0027) %"},{"line_number":485,"context_line":"                                  {\u0027node\u0027: node_uuid, \u0027error\u0027: e})"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAVX%2F%2F5WE%3D","line":482,"updated":"2014-02-27 14:52:53.000000000","message":"this should catch NoFreeWorker separately and not update node.last_error for that exception.","commit_id":"c6428dd14275fd18dea134c0ca99e2847e02f428"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"42659def313a3888460c568022aa272623053d0a","unresolved":false,"context_lines":[{"line_number":479,"context_line":"                        cleanup \u003d task.driver.deploy.clean_up"},{"line_number":480,"context_line":"                        thread \u003d self._spawn_worker(cleanup, task, node)"},{"line_number":481,"context_line":"                        thread.link(lambda t: task.release_resources())"},{"line_number":482,"context_line":"                    except Exception as e:"},{"line_number":483,"context_line":"                        msg \u003d (_(\u0027Cleanup task not started for node %(node)s \u0027"},{"line_number":484,"context_line":"                                 \u0027after callback timeout: %(error)s\u0027) %"},{"line_number":485,"context_line":"                                  {\u0027node\u0027: node_uuid, \u0027error\u0027: e})"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAVX%2F%2F4Ig%3D","line":482,"in_reply_to":"AAAAVX%2F%2F5WE%3D","updated":"2014-02-27 16:36:36.000000000","message":"Done","commit_id":"c6428dd14275fd18dea134c0ca99e2847e02f428"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"9e2b5ad4f48127605d57d43e5e9e02dcb915375c","unresolved":false,"context_lines":[{"line_number":483,"context_line":"                        msg \u003d (_(\u0027Cleanup task not started for node %(node)s \u0027"},{"line_number":484,"context_line":"                                 \u0027after callback timeout: %(error)s\u0027) %"},{"line_number":485,"context_line":"                                  {\u0027node\u0027: node_uuid, \u0027error\u0027: e})"},{"line_number":486,"context_line":"                        node.last_error \u003d msg"},{"line_number":487,"context_line":"                        LOG.error(msg)"},{"line_number":488,"context_line":"                        node.save(task.context)"},{"line_number":489,"context_line":"                        task.release_resources()"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAVX%2F%2F5TE%3D","line":486,"updated":"2014-02-27 14:52:53.000000000","message":"We should not put an unedited driver exception into node.last_error as this may expose driver details to the users. Drivers /should/ be trapping lower level exceptions and raising clean ones, but we shouldn\u0027t assume that. I\u0027d prefer to just fix this one, rather than file a bug and come back to it.\n\nIt is fine to log \"e\", however, so I would recommend something like this:\n\n  except exception.NoFreeConductorWorker:\n    task.release_resources()\n  except exception.IronicException as e:\n    msg \u003d (..., e)\n    LOG.error(msg)\n    node.last_error \u003d msg\n    node.save\n    task.release_resources()\n  except Exception as e:\n    msg \u003d (..., e)\n    LOG.error(msg)\n    node.last_error \u003d _(\"Deploy timed out, but an unhandled exception was \"\n      \"encountered while aborting. More info may be found in the log file.\")\n    node.save\n    task.release_resources()","commit_id":"c6428dd14275fd18dea134c0ca99e2847e02f428"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"42659def313a3888460c568022aa272623053d0a","unresolved":false,"context_lines":[{"line_number":483,"context_line":"                        msg \u003d (_(\u0027Cleanup task not started for node %(node)s \u0027"},{"line_number":484,"context_line":"                                 \u0027after callback timeout: %(error)s\u0027) %"},{"line_number":485,"context_line":"                                  {\u0027node\u0027: node_uuid, \u0027error\u0027: e})"},{"line_number":486,"context_line":"                        node.last_error \u003d msg"},{"line_number":487,"context_line":"                        LOG.error(msg)"},{"line_number":488,"context_line":"                        node.save(task.context)"},{"line_number":489,"context_line":"                        task.release_resources()"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAVX%2F%2F4IY%3D","line":486,"in_reply_to":"AAAAVX%2F%2F5TE%3D","updated":"2014-02-27 16:36:36.000000000","message":"Done","commit_id":"c6428dd14275fd18dea134c0ca99e2847e02f428"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"248a79ac516957c64f149b6dbf451f2fde95b656","unresolved":false,"context_lines":[{"line_number":483,"context_line":"                        msg \u003d (_(\u0027Cleanup task not started for node %(node)s \u0027"},{"line_number":484,"context_line":"                                 \u0027after callback timeout: %(error)s\u0027) %"},{"line_number":485,"context_line":"                                  {\u0027node\u0027: node_uuid, \u0027error\u0027: e})"},{"line_number":486,"context_line":"                        node.last_error \u003d msg"},{"line_number":487,"context_line":"                        LOG.error(msg)"},{"line_number":488,"context_line":"                        node.save(task.context)"},{"line_number":489,"context_line":"                        task.release_resources()"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAVX%2F%2F3%2BM%3D","line":486,"in_reply_to":"AAAAVX%2F%2F5TE%3D","updated":"2014-02-27 16:52:48.000000000","message":"_spawn_worker() return control immediately, therefore we cannot handling exceptions from driver here.","commit_id":"c6428dd14275fd18dea134c0ca99e2847e02f428"}],"ironic/drivers/modules/pxe.py":[{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"43f7497fa4d42a8b5ab34ddd61b27f12f44bf359","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    cfg.IntOpt(\u0027pxe_callback_timeout\u0027,"},{"line_number":74,"context_line":"                default\u003d0,"},{"line_number":75,"context_line":"                help\u003d\u0027Timeout for waiting callback from deploy ramdisk. \u0027"},{"line_number":76,"context_line":"                     \u0027Default 0 (unlimited).\u0027),"},{"line_number":77,"context_line":"    ]"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUX%2F%2FuOk%3D","line":76,"updated":"2014-02-11 08:24:07.000000000","message":"What is the unit, in seconds or minutes? We should be clearly for it.","commit_id":"62e8ce2934c4beed9ff41f877b358df4e22ca9e9"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"930c758043bb92b07f543ea7681e7e4a088993e9","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    cfg.IntOpt(\u0027pxe_callback_timeout\u0027,"},{"line_number":74,"context_line":"                default\u003d0,"},{"line_number":75,"context_line":"                help\u003d\u0027Timeout for waiting callback from deploy ramdisk. \u0027"},{"line_number":76,"context_line":"                     \u0027Default 0 (unlimited).\u0027),"},{"line_number":77,"context_line":"    ]"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUX%2F%2FsTY%3D","line":76,"in_reply_to":"AAAAUX%2F%2FuOk%3D","updated":"2014-02-11 13:28:44.000000000","message":"Done","commit_id":"62e8ce2934c4beed9ff41f877b358df4e22ca9e9"},{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"f933c5085a286c8105232ee5468bce3bfbf0267d","unresolved":false,"context_lines":[{"line_number":435,"context_line":"                node.last_error \u003d msg"},{"line_number":436,"context_line":"                LOG.error(msg)"},{"line_number":437,"context_line":"                node.save(task.context)"},{"line_number":438,"context_line":"    except (exception.NodeLocked, exception.NodeNotFound):"},{"line_number":439,"context_line":"        pass"},{"line_number":440,"context_line":""},{"line_number":441,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUX%2F%2F0gU%3D","line":438,"updated":"2014-02-10 16:15:32.000000000","message":"If node is locked at this moment then timeout is failed? Maybe it should to try again later?","commit_id":"62e8ce2934c4beed9ff41f877b358df4e22ca9e9"},{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"91bcd1a23863a918c161f502044126da0029a795","unresolved":false,"context_lines":[{"line_number":435,"context_line":"                node.last_error \u003d msg"},{"line_number":436,"context_line":"                LOG.error(msg)"},{"line_number":437,"context_line":"                node.save(task.context)"},{"line_number":438,"context_line":"    except (exception.NodeLocked, exception.NodeNotFound):"},{"line_number":439,"context_line":"        pass"},{"line_number":440,"context_line":""},{"line_number":441,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUX%2F%2Fz38%3D","line":438,"in_reply_to":"AAAAUX%2F%2F0KU%3D","updated":"2014-02-10 17:20:51.000000000","message":"Oh, I see, thanks.\n\nBut what about exception.NodeNotFound?","commit_id":"62e8ce2934c4beed9ff41f877b358df4e22ca9e9"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"e12670cad1520e14bc7e329f416313f4e711726f","unresolved":false,"context_lines":[{"line_number":435,"context_line":"                node.last_error \u003d msg"},{"line_number":436,"context_line":"                LOG.error(msg)"},{"line_number":437,"context_line":"                node.save(task.context)"},{"line_number":438,"context_line":"    except (exception.NodeLocked, exception.NodeNotFound):"},{"line_number":439,"context_line":"        pass"},{"line_number":440,"context_line":""},{"line_number":441,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUX%2F%2F0KU%3D","line":438,"in_reply_to":"AAAAUX%2F%2F0gU%3D","updated":"2014-02-10 16:50:40.000000000","message":"If node locked at this moment it means deploy process is going on and we already left DEPLOYWAIT state. Also this code works only if node.provision_state \u003d\u003d states.DEPLOYWAIT, therefore timer.cancel() not needed.","commit_id":"62e8ce2934c4beed9ff41f877b358df4e22ca9e9"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"930c758043bb92b07f543ea7681e7e4a088993e9","unresolved":false,"context_lines":[{"line_number":435,"context_line":"                node.last_error \u003d msg"},{"line_number":436,"context_line":"                LOG.error(msg)"},{"line_number":437,"context_line":"                node.save(task.context)"},{"line_number":438,"context_line":"    except (exception.NodeLocked, exception.NodeNotFound):"},{"line_number":439,"context_line":"        pass"},{"line_number":440,"context_line":""},{"line_number":441,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUX%2F%2FsbM%3D","line":438,"in_reply_to":"AAAAUX%2F%2Fz38%3D","updated":"2014-02-11 13:28:44.000000000","message":"Node can be undeployed and deleted in DEPLOYWAIT state, https://review.openstack.org/#/c/71297/2/ironic/conductor/manager.py","commit_id":"62e8ce2934c4beed9ff41f877b358df4e22ca9e9"},{"author":{"_account_id":8968,"name":"Max Lobur","email":"max_lobur@outlook.com","username":"max_lobur"},"change_message_id":"91534fdd24f539dbdf10455ad74bd266f258a19b","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    cfg.StrOpt(\u0027pxe_bootfile_name\u0027,"},{"line_number":71,"context_line":"               default\u003d\u0027pxelinux.0\u0027,"},{"line_number":72,"context_line":"               help\u003d\u0027Neutron bootfile DHCP parameter.\u0027),"},{"line_number":73,"context_line":"    cfg.IntOpt(\u0027pxe_callback_timeout\u0027,"},{"line_number":74,"context_line":"                default\u003d0,"},{"line_number":75,"context_line":"                help\u003d\u0027Timeout (seconds) for waiting callback from deploy \u0027"},{"line_number":76,"context_line":"                     \u0027ramdisk. Default 0 (unlimited).\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUX%2F%2FidM%3D","line":73,"updated":"2014-02-12 14:45:44.000000000","message":"how about pxe_deploy_ramdisk_callback_timeout? makes sense?","commit_id":"9c57d41c40c50d0d200a153d92e0f6dad170938d"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"6223ebce7432951081deb922f30d058077daa184","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    cfg.StrOpt(\u0027pxe_bootfile_name\u0027,"},{"line_number":71,"context_line":"               default\u003d\u0027pxelinux.0\u0027,"},{"line_number":72,"context_line":"               help\u003d\u0027Neutron bootfile DHCP parameter.\u0027),"},{"line_number":73,"context_line":"    cfg.IntOpt(\u0027pxe_callback_timeout\u0027,"},{"line_number":74,"context_line":"                default\u003d0,"},{"line_number":75,"context_line":"                help\u003d\u0027Timeout (seconds) for waiting callback from deploy \u0027"},{"line_number":76,"context_line":"                     \u0027ramdisk. Default 0 (unlimited).\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUX%2F%2FYwQ%3D","line":73,"in_reply_to":"AAAAUX%2F%2Fblg%3D","updated":"2014-02-13 15:37:05.000000000","message":"Done","commit_id":"9c57d41c40c50d0d200a153d92e0f6dad170938d"},{"author":{"_account_id":8968,"name":"Max Lobur","email":"max_lobur@outlook.com","username":"max_lobur"},"change_message_id":"db4f7757f05517ac7b2300b72a284bf3f17a0822","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    cfg.StrOpt(\u0027pxe_bootfile_name\u0027,"},{"line_number":71,"context_line":"               default\u003d\u0027pxelinux.0\u0027,"},{"line_number":72,"context_line":"               help\u003d\u0027Neutron bootfile DHCP parameter.\u0027),"},{"line_number":73,"context_line":"    cfg.IntOpt(\u0027pxe_callback_timeout\u0027,"},{"line_number":74,"context_line":"                default\u003d0,"},{"line_number":75,"context_line":"                help\u003d\u0027Timeout (seconds) for waiting callback from deploy \u0027"},{"line_number":76,"context_line":"                     \u0027ramdisk. Default 0 (unlimited).\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUX%2F%2Faxw%3D","line":73,"in_reply_to":"AAAAUX%2F%2Fblg%3D","updated":"2014-02-13 10:55:03.000000000","message":"Informative too, I like","commit_id":"9c57d41c40c50d0d200a153d92e0f6dad170938d"},{"author":{"_account_id":1726,"name":"Ghe Rivero","email":"ghe.rivero@gmail.com","username":"ghe.rivero"},"change_message_id":"a61ca3a521c84db811ae3ef26b1e1b3ac67f9df4","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    cfg.StrOpt(\u0027pxe_bootfile_name\u0027,"},{"line_number":71,"context_line":"               default\u003d\u0027pxelinux.0\u0027,"},{"line_number":72,"context_line":"               help\u003d\u0027Neutron bootfile DHCP parameter.\u0027),"},{"line_number":73,"context_line":"    cfg.IntOpt(\u0027pxe_callback_timeout\u0027,"},{"line_number":74,"context_line":"                default\u003d0,"},{"line_number":75,"context_line":"                help\u003d\u0027Timeout (seconds) for waiting callback from deploy \u0027"},{"line_number":76,"context_line":"                     \u0027ramdisk. Default 0 (unlimited).\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUX%2F%2Fblg%3D","line":73,"in_reply_to":"AAAAUX%2F%2FidM%3D","updated":"2014-02-13 09:06:51.000000000","message":"Agree that the original name is not the best one, that your proposal looks tooo long. What about, ramdisk_callback_timeout? pxe is incuded in the CONF group.","commit_id":"9c57d41c40c50d0d200a153d92e0f6dad170938d"},{"author":{"_account_id":8968,"name":"Max Lobur","email":"max_lobur@outlook.com","username":"max_lobur"},"change_message_id":"91534fdd24f539dbdf10455ad74bd266f258a19b","unresolved":false,"context_lines":[{"line_number":435,"context_line":"                node.last_error \u003d msg"},{"line_number":436,"context_line":"                LOG.error(msg)"},{"line_number":437,"context_line":"                node.save(task.context)"},{"line_number":438,"context_line":"    except (exception.NodeLocked, exception.NodeNotFound):"},{"line_number":439,"context_line":"        pass"},{"line_number":440,"context_line":""},{"line_number":441,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUX%2F%2Fiek%3D","line":438,"updated":"2014-02-12 14:45:44.000000000","message":"why we check NodeNotFound here? how could it happen? you mean node has been deleted from db during the deployment","commit_id":"9c57d41c40c50d0d200a153d92e0f6dad170938d"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"6223ebce7432951081deb922f30d058077daa184","unresolved":false,"context_lines":[{"line_number":435,"context_line":"                node.last_error \u003d msg"},{"line_number":436,"context_line":"                LOG.error(msg)"},{"line_number":437,"context_line":"                node.save(task.context)"},{"line_number":438,"context_line":"    except (exception.NodeLocked, exception.NodeNotFound):"},{"line_number":439,"context_line":"        pass"},{"line_number":440,"context_line":""},{"line_number":441,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUX%2F%2FYv8%3D","line":438,"in_reply_to":"AAAAUX%2F%2Fiek%3D","updated":"2014-02-13 15:37:05.000000000","message":"Node can be undeployed and deleted in DEPLOYWAIT state, https://review.openstack.org/#/c/71297/2/ironic/conductor/manager.py","commit_id":"9c57d41c40c50d0d200a153d92e0f6dad170938d"}],"ironic/tests/drivers/test_pxe.py":[{"author":{"_account_id":8968,"name":"Max Lobur","email":"max_lobur@outlook.com","username":"max_lobur"},"change_message_id":"91534fdd24f539dbdf10455ad74bd266f258a19b","unresolved":false,"context_lines":[{"line_number":789,"context_line":"        self.node.refresh(self.context)"},{"line_number":790,"context_line":"        self.assertEqual(states.DEPLOYFAIL, self.node.provision_state)"},{"line_number":791,"context_line":"        self.assertEqual(states.NOSTATE, self.node.target_provision_state)"},{"line_number":792,"context_line":"        self.assertIn(\u0027Timeout\u0027, self.node.last_error)"},{"line_number":793,"context_line":""},{"line_number":794,"context_line":"    def test_callback_timeout_deploying(self):"},{"line_number":795,"context_line":"        self.node.provision_state \u003d states.DEPLOYING"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUX%2F%2FiSA%3D","line":792,"updated":"2014-02-12 14:45:44.000000000","message":"Also needs testcase to check that callback is not fired with zero conf timeout\n\nNodeNotFound path is not tested as well, but I\u0027m not sure if we need those exception.","commit_id":"9c57d41c40c50d0d200a153d92e0f6dad170938d"},{"author":{"_account_id":8968,"name":"Max Lobur","email":"max_lobur@outlook.com","username":"max_lobur"},"change_message_id":"91534fdd24f539dbdf10455ad74bd266f258a19b","unresolved":false,"context_lines":[{"line_number":799,"context_line":"        self.node.refresh(self.context)"},{"line_number":800,"context_line":"        self.assertEqual(states.DEPLOYING, self.node.provision_state)"},{"line_number":801,"context_line":"        self.assertEqual(states.DEPLOYDONE, self.node.target_provision_state)"},{"line_number":802,"context_line":"        self.assertNotIn(\u0027Timeout\u0027, self.node.last_error)"},{"line_number":803,"context_line":""},{"line_number":804,"context_line":"    def test_callback_timeout_node_locked(self):"},{"line_number":805,"context_line":"        self.node.provision_state \u003d states.DEPLOYWAIT"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUX%2F%2FiTc%3D","line":802,"updated":"2014-02-12 14:45:44.000000000","message":"Last error should be empty here, right?\n\nself.assertEqual(\u0027\u0027, self.node.last_error)","commit_id":"9c57d41c40c50d0d200a153d92e0f6dad170938d"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"6223ebce7432951081deb922f30d058077daa184","unresolved":false,"context_lines":[{"line_number":799,"context_line":"        self.node.refresh(self.context)"},{"line_number":800,"context_line":"        self.assertEqual(states.DEPLOYING, self.node.provision_state)"},{"line_number":801,"context_line":"        self.assertEqual(states.DEPLOYDONE, self.node.target_provision_state)"},{"line_number":802,"context_line":"        self.assertNotIn(\u0027Timeout\u0027, self.node.last_error)"},{"line_number":803,"context_line":""},{"line_number":804,"context_line":"    def test_callback_timeout_node_locked(self):"},{"line_number":805,"context_line":"        self.node.provision_state \u003d states.DEPLOYWAIT"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUX%2F%2FYvw%3D","line":802,"in_reply_to":"AAAAUX%2F%2FiTc%3D","updated":"2014-02-13 15:37:05.000000000","message":"Done","commit_id":"9c57d41c40c50d0d200a153d92e0f6dad170938d"},{"author":{"_account_id":8968,"name":"Max Lobur","email":"max_lobur@outlook.com","username":"max_lobur"},"change_message_id":"91534fdd24f539dbdf10455ad74bd266f258a19b","unresolved":false,"context_lines":[{"line_number":806,"context_line":"        self.node.target_provision_state \u003d states.DEPLOYDONE"},{"line_number":807,"context_line":"        self.node.save(self.context)"},{"line_number":808,"context_line":"        with task_manager.acquire(self.context, self.node.uuid):"},{"line_number":809,"context_line":"            pxe._callback_timeout_handler(self.context, self.node.uuid)"},{"line_number":810,"context_line":"        self.node.refresh(self.context)"},{"line_number":811,"context_line":"        self.assertEqual(states.DEPLOYWAIT, self.node.provision_state)"},{"line_number":812,"context_line":"        self.assertEqual(states.DEPLOYDONE, self.node.target_provision_state)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUX%2F%2FiSs%3D","line":809,"updated":"2014-02-12 14:45:44.000000000","message":"Let\u0027s change node reservation above, instead of using task_manager","commit_id":"9c57d41c40c50d0d200a153d92e0f6dad170938d"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"6223ebce7432951081deb922f30d058077daa184","unresolved":false,"context_lines":[{"line_number":806,"context_line":"        self.node.target_provision_state \u003d states.DEPLOYDONE"},{"line_number":807,"context_line":"        self.node.save(self.context)"},{"line_number":808,"context_line":"        with task_manager.acquire(self.context, self.node.uuid):"},{"line_number":809,"context_line":"            pxe._callback_timeout_handler(self.context, self.node.uuid)"},{"line_number":810,"context_line":"        self.node.refresh(self.context)"},{"line_number":811,"context_line":"        self.assertEqual(states.DEPLOYWAIT, self.node.provision_state)"},{"line_number":812,"context_line":"        self.assertEqual(states.DEPLOYDONE, self.node.target_provision_state)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUX%2F%2FYvs%3D","line":809,"in_reply_to":"AAAAUX%2F%2FiSs%3D","updated":"2014-02-13 15:37:05.000000000","message":"Done","commit_id":"9c57d41c40c50d0d200a153d92e0f6dad170938d"},{"author":{"_account_id":8968,"name":"Max Lobur","email":"max_lobur@outlook.com","username":"max_lobur"},"change_message_id":"91534fdd24f539dbdf10455ad74bd266f258a19b","unresolved":false,"context_lines":[{"line_number":810,"context_line":"        self.node.refresh(self.context)"},{"line_number":811,"context_line":"        self.assertEqual(states.DEPLOYWAIT, self.node.provision_state)"},{"line_number":812,"context_line":"        self.assertEqual(states.DEPLOYDONE, self.node.target_provision_state)"},{"line_number":813,"context_line":"        self.assertNotIn(\u0027Timeout\u0027, self.node.last_error)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUX%2F%2FiSc%3D","line":813,"updated":"2014-02-12 14:45:44.000000000","message":"ditto","commit_id":"9c57d41c40c50d0d200a153d92e0f6dad170938d"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"6223ebce7432951081deb922f30d058077daa184","unresolved":false,"context_lines":[{"line_number":810,"context_line":"        self.node.refresh(self.context)"},{"line_number":811,"context_line":"        self.assertEqual(states.DEPLOYWAIT, self.node.provision_state)"},{"line_number":812,"context_line":"        self.assertEqual(states.DEPLOYDONE, self.node.target_provision_state)"},{"line_number":813,"context_line":"        self.assertNotIn(\u0027Timeout\u0027, self.node.last_error)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUX%2F%2FYvo%3D","line":813,"in_reply_to":"AAAAUX%2F%2FiSc%3D","updated":"2014-02-13 15:37:05.000000000","message":"Done","commit_id":"9c57d41c40c50d0d200a153d92e0f6dad170938d"},{"author":{"_account_id":8968,"name":"Max Lobur","email":"max_lobur@outlook.com","username":"max_lobur"},"change_message_id":"9c59eb38e9ab241c95e5b12b45f0f9ddf121797a","unresolved":false,"context_lines":[{"line_number":780,"context_line":""},{"line_number":781,"context_line":"        self.assertTrue(os.path.exists(master_d_kernel_path))"},{"line_number":782,"context_line":"        self.assertTrue(os.path.exists(master_instance_path))"},{"line_number":783,"context_line":""},{"line_number":784,"context_line":"    def test_callback_timeout(self):"},{"line_number":785,"context_line":"        self.node.provision_state \u003d states.DEPLOYWAIT"},{"line_number":786,"context_line":"        self.node.target_provision_state \u003d states.DEPLOYDONE"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUX%2F%2FApM%3D","line":783,"updated":"2014-02-17 17:03:35.000000000","message":"So, how about the testcase to check that callback is not fired with zero conf timeout?","commit_id":"c79d80940e6b3d5a6f47dd1efb1907237d2a9c99"}]}
