)]}'
{"ironic/tests/unit/drivers/modules/irmc/test_boot.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5cd4d6f1d3d24e4a6a4bc923cc60319df2c78b74","unresolved":false,"context_lines":[{"line_number":888,"context_line":"    boot_interface \u003d \u0027irmc-virtual-media\u0027"},{"line_number":889,"context_line":""},{"line_number":890,"context_line":"    def setUp(self):"},{"line_number":891,"context_line":"        self.check_share_fs_mounted_mock \u003d ("},{"line_number":892,"context_line":"            irmc_boot.check_share_fs_mounted_patcher.start())"},{"line_number":893,"context_line":"        self.addCleanup(irmc_boot.check_share_fs_mounted_patcher.stop)"},{"line_number":894,"context_line":"        super(IRMCVirtualMediaBootTestCase, self).setUp()"},{"line_number":895,"context_line":""},{"line_number":896,"context_line":"    @mock.patch.object(deploy_utils, \u0027validate_image_properties\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_dd985a76","line":893,"range":{"start_line":891,"start_character":0,"end_line":893,"end_character":70},"updated":"2020-04-28 16:37:18.000000000","message":"Let\u0027s do it the other way around: remove this and keep the function level mocks","commit_id":"e6e6a33a0125f9ec25a0f52e6191497231ef9cd7"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"29c1d2eab656e2329c1a1c85f941786782507759","unresolved":false,"context_lines":[{"line_number":126,"context_line":"        self.node.driver_info["},{"line_number":127,"context_line":"            \u0027irmc_rescue_iso\u0027] \u003d \u0027bc784057-a140-4130-add3-ef890457e6b3\u0027"},{"line_number":128,"context_line":"        driver_info_expected \u003d {\u0027irmc_rescue_iso\u0027:"},{"line_number":129,"context_line":"                                    \u0027bc784057-a140-4130-add3-ef890457e6b3\u0027}"},{"line_number":130,"context_line":"        is_image_href_ordinary_file_name_mock.return_value \u003d False"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"        driver_info_actual \u003d irmc_boot._parse_driver_info(self.node,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f493fa4_525d4245","line":129,"updated":"2020-04-29 12:19:34.000000000","message":"pep8: E127 continuation line over-indented for visual indent","commit_id":"df6516f7d342d345f97dfa9a3f473dfb7d1393a9"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"29c1d2eab656e2329c1a1c85f941786782507759","unresolved":false,"context_lines":[{"line_number":192,"context_line":"        self.node.instance_info["},{"line_number":193,"context_line":"            \u0027irmc_boot_iso\u0027] \u003d \u0027bc784057-a140-4130-add3-ef890457e6b3\u0027"},{"line_number":194,"context_line":"        instance_info_expected \u003d {\u0027irmc_boot_iso\u0027:"},{"line_number":195,"context_line":"                                      \u0027bc784057-a140-4130-add3-ef890457e6b3\u0027}"},{"line_number":196,"context_line":"        instance_info_actual \u003d irmc_boot._parse_instance_info(self.node)"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"        self.assertEqual(instance_info_expected, instance_info_actual)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f493fa4_b2580656","line":195,"updated":"2020-04-29 12:19:34.000000000","message":"pep8: E127 continuation line over-indented for visual indent","commit_id":"df6516f7d342d345f97dfa9a3f473dfb7d1393a9"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"29c1d2eab656e2329c1a1c85f941786782507759","unresolved":false,"context_lines":[{"line_number":694,"context_line":"                                     _remove_share_file_mock,"},{"line_number":695,"context_line":"                                     _get_floppy_image_name_mock,"},{"line_number":696,"context_line":"                                     _get_iso_name_mock,"},{"line_number":697,"context_line":"                                    check_share_fs_mounted_mock):"},{"line_number":698,"context_line":"        with task_manager.acquire(self.context, self.node.uuid,"},{"line_number":699,"context_line":"                                  shared\u003dFalse) as task:"},{"line_number":700,"context_line":"            irmc_boot._cleanup_vmedia_boot(task)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f493fa4_92534a39","line":697,"updated":"2020-04-29 12:19:34.000000000","message":"pep8: E128 continuation line under-indented for visual indent","commit_id":"df6516f7d342d345f97dfa9a3f473dfb7d1393a9"}],"ironic/tests/unit/drivers/test_irmc.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"29c1d2eab656e2329c1a1c85f941786782507759","unresolved":false,"context_lines":[{"line_number":25,"context_line":"from ironic.drivers.modules import ipmitool"},{"line_number":26,"context_line":"from ironic.drivers.modules import ipxe"},{"line_number":27,"context_line":"from ironic.drivers.modules.irmc import boot as irmc_boot"},{"line_number":28,"context_line":"from ironic.drivers.modules.irmc import bios as irmc_bios"},{"line_number":29,"context_line":"from ironic.drivers.modules.irmc import raid"},{"line_number":30,"context_line":"from ironic.drivers.modules import iscsi_deploy"},{"line_number":31,"context_line":"from ironic.drivers.modules import noop"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f493fa4_7262fe0b","line":28,"updated":"2020-04-29 12:19:34.000000000","message":"pep8: H306: imports not in alphabetical order (ironic.drivers.modules.irmc.boot, ironic.drivers.modules.irmc.bios)","commit_id":"df6516f7d342d345f97dfa9a3f473dfb7d1393a9"}],"ironic/tests/unit/drivers/third_party_driver_mocks.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5cd4d6f1d3d24e4a6a4bc923cc60319df2c78b74","unresolved":false,"context_lines":[{"line_number":172,"context_line":"# checking whether NFS/CIFS share file system is mounted or not."},{"line_number":173,"context_line":"irmc_boot \u003d importutils.import_module("},{"line_number":174,"context_line":"    \u0027ironic.drivers.modules.irmc.boot\u0027)"},{"line_number":175,"context_line":"irmc_boot.check_share_fs_mounted_orig \u003d irmc_boot.check_share_fs_mounted"},{"line_number":176,"context_line":"irmc_boot.check_share_fs_mounted_patcher \u003d mock.patch("},{"line_number":177,"context_line":"    \u0027ironic.drivers.modules.irmc.boot.check_share_fs_mounted\u0027,"},{"line_number":178,"context_line":"    autospec\u003dTrue)"},{"line_number":179,"context_line":"irmc_boot.check_share_fs_mounted_patcher.return_value \u003d None"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_bda3ce9d","line":178,"range":{"start_line":175,"start_character":0,"end_line":178,"end_character":18},"updated":"2020-04-28 16:37:18.000000000","message":"I suggest removing this. It\u0027s a pretty weird approach to mocking that can cause subtle problems (like the one you\u0027ve discovered)","commit_id":"e6e6a33a0125f9ec25a0f52e6191497231ef9cd7"}]}