)]}'
{"ironic/conductor/deployments.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"d60a5a5c867a8e753cc90c4ca7ff29c2b65934f6","unresolved":false,"context_lines":[{"line_number":340,"context_line":""},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"    \"\"\""},{"line_number":343,"context_line":"    #try:"},{"line_number":344,"context_line":"    #    configdrive \u003d configdrive.decode()"},{"line_number":345,"context_line":"    #except AttributeError:"},{"line_number":346,"context_line":"    #    pass"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_79b535ee","line":343,"updated":"2020-05-07 01:45:37.000000000","message":"pep8: E265 block comment should start with \u0027# \u0027","commit_id":"c46ef0b5a44cdd932a0132aac9b5a63afca488a2"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"d60a5a5c867a8e753cc90c4ca7ff29c2b65934f6","unresolved":false,"context_lines":[{"line_number":342,"context_line":"    \"\"\""},{"line_number":343,"context_line":"    #try:"},{"line_number":344,"context_line":"    #    configdrive \u003d configdrive.decode()"},{"line_number":345,"context_line":"    #except AttributeError:"},{"line_number":346,"context_line":"    #    pass"},{"line_number":347,"context_line":"    #    #configdrive \u003d configdrive.encode(\"utf-8\")"},{"line_number":348,"context_line":"    print(configdrive)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_59b839e4","line":345,"updated":"2020-05-07 01:45:37.000000000","message":"pep8: E265 block comment should start with \u0027# \u0027","commit_id":"c46ef0b5a44cdd932a0132aac9b5a63afca488a2"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"1c7f7fd63f81b40efe76f3c8876aa0cf6c4e576e","unresolved":false,"context_lines":[{"line_number":345,"context_line":"    #except AttributeError:"},{"line_number":346,"context_line":"    #    pass"},{"line_number":347,"context_line":"    #    #configdrive \u003d configdrive.encode(\"utf-8\")"},{"line_number":348,"context_line":"    print(configdrive)"},{"line_number":349,"context_line":"    if CONF.deploy.configdrive_use_object_store:"},{"line_number":350,"context_line":"        # NOTE(lucasagomes): No reason to use a different timeout than"},{"line_number":351,"context_line":"        # the one used for deploying the node"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_6ef56ded","line":348,"updated":"2020-05-06 23:45:46.000000000","message":"looks like a debug, we\u0027ll need to remove this.","commit_id":"c46ef0b5a44cdd932a0132aac9b5a63afca488a2"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a5443fb0dbc06edb5e7500785a5f344d72b93459","unresolved":false,"context_lines":[{"line_number":358,"context_line":""},{"line_number":359,"context_line":"        object_headers \u003d {\u0027X-Delete-After\u0027: str(timeout)}"},{"line_number":360,"context_line":""},{"line_number":361,"context_line":"        with tempfile.NamedTemporaryFile(dir\u003dCONF.tempdir) as fileobj:"},{"line_number":362,"context_line":"            try:"},{"line_number":363,"context_line":"                configdrive \u003d configdrive.encode(\u0027utf-8\u0027)"},{"line_number":364,"context_line":"            except AttributeError:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_6e19e886","line":361,"updated":"2020-05-07 09:23:32.000000000","message":"just mode \u003d \u0027wt\u0027?","commit_id":"c46ef0b5a44cdd932a0132aac9b5a63afca488a2"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"1c7f7fd63f81b40efe76f3c8876aa0cf6c4e576e","unresolved":false,"context_lines":[{"line_number":360,"context_line":""},{"line_number":361,"context_line":"        with tempfile.NamedTemporaryFile(dir\u003dCONF.tempdir) as fileobj:"},{"line_number":362,"context_line":"            try:"},{"line_number":363,"context_line":"                configdrive \u003d configdrive.encode(\u0027utf-8\u0027)"},{"line_number":364,"context_line":"            except AttributeError:"},{"line_number":365,"context_line":"                pass"},{"line_number":366,"context_line":"            fileobj.write(configdrive)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_cef761d4","line":363,"range":{"start_line":363,"start_character":16,"end_line":363,"end_character":27},"updated":"2020-05-06 23:45:46.000000000","message":"Maybe change a name so that we don\u0027t need to decode below?\nAlso I think the exception catching is not required, it should be base64 encoded string in this method, if it\u0027s wrong, we should raise instead of silently pass.","commit_id":"c46ef0b5a44cdd932a0132aac9b5a63afca488a2"}],"ironic/tests/unit/conductor/test_deployments.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"d60a5a5c867a8e753cc90c4ca7ff29c2b65934f6","unresolved":false,"context_lines":[{"line_number":765,"context_line":"        self.assertEqual(expected_instance_info, self.node.instance_info)"},{"line_number":766,"context_line":""},{"line_number":767,"context_line":""},{"line_number":768,"context_line":"    def test_store_configdrive_swift_no_deploy_timeout(self, mock_swift):"},{"line_number":769,"context_line":"        container_name \u003d \u0027foo_container\u0027"},{"line_number":770,"context_line":"        expected_obj_name \u003d \u0027configdrive-%s\u0027 % self.node.uuid"},{"line_number":771,"context_line":"        expected_obj_header \u003d {\u0027X-Delete-After\u0027: \u00271200\u0027}"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_19beb1d3","line":768,"updated":"2020-05-07 01:45:37.000000000","message":"pep8: E303 too many blank lines (2)","commit_id":"c46ef0b5a44cdd932a0132aac9b5a63afca488a2"}]}