)]}'
{"ironic/cmd/__init__.py":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"4425fa1bd72816a62c237ac3e67e301999f77566","unresolved":false,"context_lines":[{"line_number":19,"context_line":"# concurrency models can cause undefined behavior and potentially API timeouts."},{"line_number":20,"context_line":"import os"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"import eventlet"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"os.environ[\u0027EVENTLET_NO_GREENDNS\u0027] \u003d \u0027yes\u0027  # noqa E402"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ff570b3c_677e4e6c","line":22,"updated":"2020-05-12 12:40:23.000000000","message":"let\u0027s move this back in L24","commit_id":"2f86ea4939adbb06b6d99565b37a8a80215dba24"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"155896d7908fce56d58586db711b448ff233506c","unresolved":false,"context_lines":[{"line_number":27,"context_line":"# Monkey patch the original current_thread to use the up-to-date _active"},{"line_number":28,"context_line":"# global variable. See https://bugs.launchpad.net/bugs/1863021 and"},{"line_number":29,"context_line":"# https://github.com/eventlet/eventlet/issues/592"},{"line_number":30,"context_line":"# all the noqa bellow are for I202 due to \u0027import eventlet\u0027 above"},{"line_number":31,"context_line":"import __original_module_threading as orig_threading  # noqa"},{"line_number":32,"context_line":"import threading # noqa"},{"line_number":33,"context_line":"orig_threading.current_thread.__globals__[\u0027_active\u0027] \u003d threading._active"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff570b3c_6a5a95f3","line":30,"range":{"start_line":30,"start_character":15,"end_line":30,"end_character":21},"updated":"2020-05-12 13:26:32.000000000","message":"nit: below","commit_id":"3d1d6617e5fc3ebf1fdb75565c1c971e95378fab"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"155896d7908fce56d58586db711b448ff233506c","unresolved":false,"context_lines":[{"line_number":29,"context_line":"# https://github.com/eventlet/eventlet/issues/592"},{"line_number":30,"context_line":"# all the noqa bellow are for I202 due to \u0027import eventlet\u0027 above"},{"line_number":31,"context_line":"import __original_module_threading as orig_threading  # noqa"},{"line_number":32,"context_line":"import threading # noqa"},{"line_number":33,"context_line":"orig_threading.current_thread.__globals__[\u0027_active\u0027] \u003d threading._active"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"from ironic.common import i18n  # noqa for I202 due to \u0027import eventlet\u0027 above"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff570b3c_4a46b125","line":32,"range":{"start_line":32,"start_character":16,"end_line":32,"end_character":17},"updated":"2020-05-12 13:26:32.000000000","message":"nit: missing blank space","commit_id":"3d1d6617e5fc3ebf1fdb75565c1c971e95378fab"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"155896d7908fce56d58586db711b448ff233506c","unresolved":false,"context_lines":[{"line_number":32,"context_line":"import threading # noqa"},{"line_number":33,"context_line":"orig_threading.current_thread.__globals__[\u0027_active\u0027] \u003d threading._active"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"from ironic.common import i18n  # noqa for I202 due to \u0027import eventlet\u0027 above"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"i18n.install(\u0027ironic\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff570b3c_ca5121db","line":35,"range":{"start_line":35,"start_character":38,"end_line":35,"end_character":78},"updated":"2020-05-12 13:26:32.000000000","message":"remove","commit_id":"3d1d6617e5fc3ebf1fdb75565c1c971e95378fab"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"8c6581bd18aaa0cc94e184b9c629b0cc80f799cf","unresolved":false,"context_lines":[{"line_number":27,"context_line":"# Monkey patch the original current_thread to use the up-to-date _active"},{"line_number":28,"context_line":"# global variable. See https://bugs.launchpad.net/bugs/1863021 and"},{"line_number":29,"context_line":"# https://github.com/eventlet/eventlet/issues/592"},{"line_number":30,"context_line":"# all the noqa below are for I202 due to \u0027import eventlet\u0027 above"},{"line_number":31,"context_line":"import __original_module_threading as orig_threading  # noqa"},{"line_number":32,"context_line":"import threading  # noqa"},{"line_number":33,"context_line":"orig_threading.current_thread.__globals__[\u0027_active\u0027] \u003d threading._active"}],"source_content_type":"text/x-python","patch_set":6,"id":"ff570b3c_333ad835","line":30,"updated":"2020-05-12 15:15:49.000000000","message":"not needed?","commit_id":"ead9ecfcbca02281cbb311c51575a41628d98b78"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"65f1ee70eeeb4d3bbb6c95e05dbd9ae54efeb18a","unresolved":false,"context_lines":[{"line_number":27,"context_line":"# Monkey patch the original current_thread to use the up-to-date _active"},{"line_number":28,"context_line":"# global variable. See https://bugs.launchpad.net/bugs/1863021 and"},{"line_number":29,"context_line":"# https://github.com/eventlet/eventlet/issues/592"},{"line_number":30,"context_line":"# all the noqa below are for I202 due to \u0027import eventlet\u0027 above"},{"line_number":31,"context_line":"import __original_module_threading as orig_threading  # noqa"},{"line_number":32,"context_line":"import threading  # noqa"},{"line_number":33,"context_line":"orig_threading.current_thread.__globals__[\u0027_active\u0027] \u003d threading._active"}],"source_content_type":"text/x-python","patch_set":6,"id":"ff570b3c_937644d8","line":30,"in_reply_to":"ff570b3c_333ad835","updated":"2020-05-12 15:34:00.000000000","message":"Riccardo asked to specify why we will have the others noqa \u003d), since we are ignoring only E402 in this file.","commit_id":"ead9ecfcbca02281cbb311c51575a41628d98b78"}],"ironic/common/pxe_utils.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"384469acb34ce13d8f9814104bdbe7e86e951a63","unresolved":false,"context_lines":[{"line_number":480,"context_line":"                LOG.warning(\u0027IPv6 is enabled and the DHCP driver appears set \u0027"},{"line_number":481,"context_line":"                            \u0027to a plugin aside from \"neutron\". Node %(name)s \u0027"},{"line_number":482,"context_line":"                            \u0027may not receive proper DHCPv6 provided \u0027"},{"line_number":483,"context_line":"                            \u0027boot parameters.\u0027, {\u0027name\u0027: task.node.uuid})"},{"line_number":484,"context_line":"            # NOTE(TheJulia): This was added for ISC DHCPd support, however it"},{"line_number":485,"context_line":"            # appears that isc support was never added to neutron and is likely"},{"line_number":486,"context_line":"            # a down stream driver."}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_e4541ccd","line":483,"updated":"2020-05-12 12:10:39.000000000","message":"a real issue, nice! we\u0027ll need to backport it to ussuri","commit_id":"70f3c43b5e050fe2da319d07e889ea8891ff711a"}],"ironic/tests/base.py":[{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"5b9df4624ff6658bb3a394451dbe25534e212229","unresolved":false,"context_lines":[{"line_number":48,"context_line":"from ironic.tests.unit import policy_fixture"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"eventlet.monkey_patch(os\u003dFalse)  # noqa E402"},{"line_number":52,"context_line":"logging.register_options(CONF)"},{"line_number":53,"context_line":"logging.setup(CONF, \u0027ironic\u0027)"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_a235f7f9","line":51,"range":{"start_line":51,"start_character":33,"end_line":51,"end_character":44},"updated":"2020-05-12 11:57:42.000000000","message":"Do we still need the noqa\u0027s now that this moved below imports?","commit_id":"8452c15f915f7c655b15c165a4db1b6beccbd040"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"95432b564fcb9d6f7e0a33c5e2be9fc93f58debd","unresolved":false,"context_lines":[{"line_number":48,"context_line":"from ironic.tests.unit import policy_fixture"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"eventlet.monkey_patch(os\u003dFalse)  # noqa E402"},{"line_number":52,"context_line":"logging.register_options(CONF)"},{"line_number":53,"context_line":"logging.setup(CONF, \u0027ironic\u0027)"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_a4aea4e4","line":51,"range":{"start_line":51,"start_character":33,"end_line":51,"end_character":44},"in_reply_to":"ff570b3c_0404b014","updated":"2020-05-12 12:07:40.000000000","message":"It works without \u003d) going to update","commit_id":"8452c15f915f7c655b15c165a4db1b6beccbd040"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"80ac7b4c0d96a8c96793ac1729ad8d98ba90a74e","unresolved":false,"context_lines":[{"line_number":48,"context_line":"from ironic.tests.unit import policy_fixture"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"eventlet.monkey_patch(os\u003dFalse)  # noqa E402"},{"line_number":52,"context_line":"logging.register_options(CONF)"},{"line_number":53,"context_line":"logging.setup(CONF, \u0027ironic\u0027)"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_0404b014","line":51,"range":{"start_line":51,"start_character":33,"end_line":51,"end_character":44},"in_reply_to":"ff570b3c_a235f7f9","updated":"2020-05-12 12:04:06.000000000","message":"Going to test locally \u003d)","commit_id":"8452c15f915f7c655b15c165a4db1b6beccbd040"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"384469acb34ce13d8f9814104bdbe7e86e951a63","unresolved":false,"context_lines":[{"line_number":48,"context_line":"from ironic.tests.unit import policy_fixture"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"eventlet.monkey_patch(os\u003dFalse)"},{"line_number":52,"context_line":"logging.register_options(CONF)"},{"line_number":53,"context_line":"logging.setup(CONF, \u0027ironic\u0027)"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_8447201e","line":51,"updated":"2020-05-12 12:10:39.000000000","message":"This is not correct :( monkey_patch must come as early as possible. we need to ignore the corresponding error for this file.","commit_id":"70f3c43b5e050fe2da319d07e889ea8891ff711a"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"fd6517a6f3d87e2c293ba2f54c531580f7d2a669","unresolved":false,"context_lines":[{"line_number":48,"context_line":"from ironic.tests.unit import policy_fixture"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"eventlet.monkey_patch(os\u003dFalse)"},{"line_number":52,"context_line":"logging.register_options(CONF)"},{"line_number":53,"context_line":"logging.setup(CONF, \u0027ironic\u0027)"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_c4a9187c","line":51,"in_reply_to":"ff570b3c_8447201e","updated":"2020-05-12 12:23:06.000000000","message":"Done","commit_id":"70f3c43b5e050fe2da319d07e889ea8891ff711a"}],"ironic/tests/unit/api/controllers/v1/test_allocation.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"384469acb34ce13d8f9814104bdbe7e86e951a63","unresolved":false,"context_lines":[{"line_number":185,"context_line":"        self.assertIn(\u0027links\u0027, data)"},{"line_number":186,"context_line":"        self.assertEqual(2, len(data[\u0027links\u0027]))"},{"line_number":187,"context_line":"        self.assertIn(uuid, data[\u0027links\u0027][0][\u0027href\u0027])"},{"line_number":188,"context_line":"        for link in data[\u0027links\u0027]:"},{"line_number":189,"context_line":"            bookmark \u003d link[\u0027rel\u0027] \u003d\u003d \u0027bookmark\u0027"},{"line_number":190,"context_line":"            self.assertTrue(self.validate_link(link[\u0027href\u0027], bookmark\u003dbookmark,"},{"line_number":191,"context_line":"                                               headers\u003dself.headers))"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_a44a2424","line":188,"updated":"2020-05-12 12:10:39.000000000","message":"I\u0027m okay with this fix (and similar ones), but please add E741 to ignore list","commit_id":"70f3c43b5e050fe2da319d07e889ea8891ff711a"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"fd6517a6f3d87e2c293ba2f54c531580f7d2a669","unresolved":false,"context_lines":[{"line_number":185,"context_line":"        self.assertIn(\u0027links\u0027, data)"},{"line_number":186,"context_line":"        self.assertEqual(2, len(data[\u0027links\u0027]))"},{"line_number":187,"context_line":"        self.assertIn(uuid, data[\u0027links\u0027][0][\u0027href\u0027])"},{"line_number":188,"context_line":"        for link in data[\u0027links\u0027]:"},{"line_number":189,"context_line":"            bookmark \u003d link[\u0027rel\u0027] \u003d\u003d \u0027bookmark\u0027"},{"line_number":190,"context_line":"            self.assertTrue(self.validate_link(link[\u0027href\u0027], bookmark\u003dbookmark,"},{"line_number":191,"context_line":"                                               headers\u003dself.headers))"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_e4c53c3e","line":188,"in_reply_to":"ff570b3c_a44a2424","updated":"2020-05-12 12:23:06.000000000","message":"Done","commit_id":"70f3c43b5e050fe2da319d07e889ea8891ff711a"}],"ironic/tests/unit/test_base.py":[{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"5b9df4624ff6658bb3a394451dbe25534e212229","unresolved":false,"context_lines":[{"line_number":29,"context_line":"                             subprocess.check_output, utils.execute)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"        for function_name in execute_functions:"},{"line_number":32,"context_line":"            exc \u003d self.assertRaises(Exception, function_name, [\"echo\", \"%s\" % function_name])  # noqa"},{"line_number":33,"context_line":"            # Have to use \u0027noqa\u0027 as we are raising plain Exception and we will"},{"line_number":34,"context_line":"            # get H202 error in \u0027pep8\u0027 check."},{"line_number":35,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_425fbb40","line":32,"range":{"start_line":32,"start_character":36,"end_line":32,"end_character":101},"updated":"2020-05-12 11:57:42.000000000","message":"Line too long? Or is it required to be long due to the noqa for raising plain Exception?","commit_id":"8452c15f915f7c655b15c165a4db1b6beccbd040"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"80ac7b4c0d96a8c96793ac1729ad8d98ba90a74e","unresolved":false,"context_lines":[{"line_number":29,"context_line":"                             subprocess.check_output, utils.execute)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"        for function_name in execute_functions:"},{"line_number":32,"context_line":"            exc \u003d self.assertRaises(Exception, function_name, [\"echo\", \"%s\" % function_name])  # noqa"},{"line_number":33,"context_line":"            # Have to use \u0027noqa\u0027 as we are raising plain Exception and we will"},{"line_number":34,"context_line":"            # get H202 error in \u0027pep8\u0027 check."},{"line_number":35,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_445ce824","line":32,"range":{"start_line":32,"start_character":36,"end_line":32,"end_character":101},"in_reply_to":"ff570b3c_425fbb40","updated":"2020-05-12 12:04:06.000000000","message":"either we have 1 line long because of the noqa or one noqa per line I think .-.\n\nwe did the same in https://review.opendev.org/#/c/727117/1/ironic_python_agent/tests/unit/test_base.py","commit_id":"8452c15f915f7c655b15c165a4db1b6beccbd040"}],"tox.ini":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"155896d7908fce56d58586db711b448ff233506c","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"[flake8]"},{"line_number":112,"context_line":"# [W503] Line break before binary operator."},{"line_number":113,"context_line":"ignore \u003d E129,W503,E741"},{"line_number":114,"context_line":"filename \u003d *.py,app.wsgi"},{"line_number":115,"context_line":"exclude \u003d  .venv,.git,.tox,dist,doc,*lib/python*,*egg,build"},{"line_number":116,"context_line":"import-order-style \u003d pep8"}],"source_content_type":"text/x-properties","patch_set":5,"id":"ff570b3c_4a14f1f5","line":113,"updated":"2020-05-12 13:26:32.000000000","message":"since we\u0027re here, let\u0027s add a description of the ignores as it\u0027s done for W503, and put them in order :)","commit_id":"3d1d6617e5fc3ebf1fdb75565c1c971e95378fab"}]}