)]}'
{"ironic/drivers/modules/redfish/management.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5b30016f3c518cc6bb4bcbb0164b1bfe8d2a8cb4","unresolved":false,"context_lines":[{"line_number":193,"context_line":"            try:"},{"line_number":194,"context_line":"                _set_boot_device(task, system, BOOT_DEVICE_MAP_REV[device],"},{"line_number":195,"context_line":"                                 enabled\u003denabled)"},{"line_number":196,"context_line":"            except AttributeError:"},{"line_number":197,"context_line":"                system.set_system_boot_source("},{"line_number":198,"context_line":"                    BOOT_DEVICE_MAP_REV[device],"},{"line_number":199,"context_line":"                    enabled\u003dBOOT_DEVICE_PERSISTENT_MAP_REV[persistent])"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff570b3c_c24c1da0","line":196,"updated":"2020-05-15 10:02:38.000000000","message":"This try-and-recover logic has to go inside _set_boot_device, otherwise you\u0027re not getting the fix with older sushy","commit_id":"741e722c5d0026713c30682a57486777261026e5"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"00bbde4979894aff40a5967102bff7fcbce97a6e","unresolved":false,"context_lines":[{"line_number":193,"context_line":"            try:"},{"line_number":194,"context_line":"                _set_boot_device(task, system, BOOT_DEVICE_MAP_REV[device],"},{"line_number":195,"context_line":"                                 enabled\u003denabled)"},{"line_number":196,"context_line":"            except AttributeError:"},{"line_number":197,"context_line":"                system.set_system_boot_source("},{"line_number":198,"context_line":"                    BOOT_DEVICE_MAP_REV[device],"},{"line_number":199,"context_line":"                    enabled\u003dBOOT_DEVICE_PERSISTENT_MAP_REV[persistent])"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff570b3c_d08504d1","line":196,"in_reply_to":"ff570b3c_c24c1da0","updated":"2020-05-15 13:59:52.000000000","message":"Done","commit_id":"741e722c5d0026713c30682a57486777261026e5"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"835ff23c32affd8e4def13115852516504d43674","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        except AttributeError:"},{"line_number":73,"context_line":"            system.set_system_boot_source("},{"line_number":74,"context_line":"                _DEVICE_MAP_REV[device],"},{"line_number":75,"context_line":"                enabled\u003dBOOT_DEVICE_PERSISTENT_MAP_REV[persistent])"},{"line_number":76,"context_line":"    except sushy.exceptions.SushyError as e:"},{"line_number":77,"context_line":"        if enabled \u003d\u003d sushy.BOOT_SOURCE_ENABLED_CONTINUOUS:"},{"line_number":78,"context_line":"            # NOTE(dtantsur): continuous boot device settings have been"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff570b3c_931a76c9","line":75,"range":{"start_line":75,"start_character":55,"end_line":75,"end_character":65},"updated":"2020-05-15 14:42:58.000000000","message":"persistent is not passed to this function","commit_id":"95c652afb9eff09057c32e8ccfc67a857c84ae75"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"51cc732f14bc3a752af6f9272e95429cb7bbc539","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        except AttributeError:"},{"line_number":73,"context_line":"            system.set_system_boot_source("},{"line_number":74,"context_line":"                _DEVICE_MAP_REV[device],"},{"line_number":75,"context_line":"                enabled\u003dBOOT_DEVICE_PERSISTENT_MAP_REV[persistent])"},{"line_number":76,"context_line":"    except sushy.exceptions.SushyError as e:"},{"line_number":77,"context_line":"        if enabled \u003d\u003d sushy.BOOT_SOURCE_ENABLED_CONTINUOUS:"},{"line_number":78,"context_line":"            # NOTE(dtantsur): continuous boot device settings have been"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff570b3c_e40b2621","line":75,"range":{"start_line":75,"start_character":55,"end_line":75,"end_character":65},"in_reply_to":"ff570b3c_931a76c9","updated":"2020-05-15 16:14:44.000000000","message":"Done","commit_id":"95c652afb9eff09057c32e8ccfc67a857c84ae75"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"835ff23c32affd8e4def13115852516504d43674","unresolved":false,"context_lines":[{"line_number":84,"context_line":"                      \u0027persistent boot device on node %(node)s, \u0027"},{"line_number":85,"context_line":"                      \u0027falling back to one-time boot settings\u0027,"},{"line_number":86,"context_line":"                      {\u0027error\u0027: e, \u0027node\u0027: task.node.uuid})"},{"line_number":87,"context_line":"            system.set_system_boot_options("},{"line_number":88,"context_line":"                device, enabled\u003dsushy.BOOT_SOURCE_ENABLED_ONCE)"},{"line_number":89,"context_line":"            LOG.warning(\u0027Could not set persistent boot device to \u0027"},{"line_number":90,"context_line":"                        \u0027%(dev)s for node %(node)s, using one-time \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff570b3c_f332d25d","line":87,"updated":"2020-05-15 14:42:58.000000000","message":"This needs the same try..except logic (or store a flag above which call to use)","commit_id":"95c652afb9eff09057c32e8ccfc67a857c84ae75"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"51cc732f14bc3a752af6f9272e95429cb7bbc539","unresolved":false,"context_lines":[{"line_number":84,"context_line":"                      \u0027persistent boot device on node %(node)s, \u0027"},{"line_number":85,"context_line":"                      \u0027falling back to one-time boot settings\u0027,"},{"line_number":86,"context_line":"                      {\u0027error\u0027: e, \u0027node\u0027: task.node.uuid})"},{"line_number":87,"context_line":"            system.set_system_boot_options("},{"line_number":88,"context_line":"                device, enabled\u003dsushy.BOOT_SOURCE_ENABLED_ONCE)"},{"line_number":89,"context_line":"            LOG.warning(\u0027Could not set persistent boot device to \u0027"},{"line_number":90,"context_line":"                        \u0027%(dev)s for node %(node)s, using one-time \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff570b3c_841a2a6c","line":87,"in_reply_to":"ff570b3c_f332d25d","updated":"2020-05-15 16:14:44.000000000","message":"Done","commit_id":"95c652afb9eff09057c32e8ccfc67a857c84ae75"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"6a92973af3cac2828515c67d84d9e3c715a064d9","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"def _set_boot_device(task, system, device,"},{"line_number":61,"context_line":"                     enabled\u003dsushy.BOOT_SOURCE_ENABLED_ONCE):"},{"line_number":62,"context_line":"    \"\"\"An internal routine to set the boot device."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    :param task: a task from TaskManager."}],"source_content_type":"text/x-python","patch_set":6,"id":"ff570b3c_1bb831e3","line":61,"range":{"start_line":61,"start_character":21,"end_line":61,"end_character":59},"updated":"2020-06-01 10:33:15.000000000","message":"this now explicitly requires sushy to be installed for drac drivers to work, even when one does not use the redfish interface\n\nIMO this is a breaking change as it will break some existing installations on update to latest Train","commit_id":"f2eac72e888595615bd0fd79648c538bb889be5f"}]}