)]}'
{"doc/source/install/standalone.rst":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1c686c775323e1416fa3ff85f6f2657fa3589f35","unresolved":false,"context_lines":[{"line_number":299,"context_line":"      desired by the operator, however depending on what your exact"},{"line_number":300,"context_line":"      configuration and driver usage is, you may wish to override this"},{"line_number":301,"context_line":"      setting. If using the ramdisk interface through the Compute API,"},{"line_number":302,"context_line":"      flavors should also assert this ``boot_option``."},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"#. Set a kernel and ramdisk to be utilized::"},{"line_number":305,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"bf51134e_48d39660","line":302,"updated":"2020-07-16 14:47:06.000000000","message":"This is a bit confusing, I\u0027d prefer we either require something or we don\u0027t","commit_id":"73254bd512b4043e9147a84fb979cec893b4b174"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"ca40d0081baf4f8db92327794aa720a1a6c27a7d","unresolved":false,"context_lines":[{"line_number":299,"context_line":"      desired by the operator, however depending on what your exact"},{"line_number":300,"context_line":"      configuration and driver usage is, you may wish to override this"},{"line_number":301,"context_line":"      setting. If using the ramdisk interface through the Compute API,"},{"line_number":302,"context_line":"      flavors should also assert this ``boot_option``."},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"#. Set a kernel and ramdisk to be utilized::"},{"line_number":305,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"bf51134e_2a645221","line":302,"in_reply_to":"bf51134e_48d39660","updated":"2020-07-16 22:13:55.000000000","message":"We automatically set it, I\u0027ll revise. Also  me using \"this\" doesn\u0027t help.","commit_id":"73254bd512b4043e9147a84fb979cec893b4b174"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1c686c775323e1416fa3ff85f6f2657fa3589f35","unresolved":false,"context_lines":[{"line_number":301,"context_line":"      setting. If using the ramdisk interface through the Compute API,"},{"line_number":302,"context_line":"      flavors should also assert this ``boot_option``."},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"#. Set a kernel and ramdisk to be utilized::"},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"       openstack baremetal node set $NODE_UUID \\"},{"line_number":307,"context_line":"               --instance-info kernel\u003d$KERNEL_URL \\"}],"source_content_type":"text/x-rst","patch_set":9,"id":"bf51134e_28d62250","line":304,"updated":"2020-07-16 14:47:06.000000000","message":"At some point in the future we should probably add an example of how to build such a ramdisk","commit_id":"73254bd512b4043e9147a84fb979cec893b4b174"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"ca40d0081baf4f8db92327794aa720a1a6c27a7d","unresolved":false,"context_lines":[{"line_number":301,"context_line":"      setting. If using the ramdisk interface through the Compute API,"},{"line_number":302,"context_line":"      flavors should also assert this ``boot_option``."},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"#. Set a kernel and ramdisk to be utilized::"},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"       openstack baremetal node set $NODE_UUID \\"},{"line_number":307,"context_line":"               --instance-info kernel\u003d$KERNEL_URL \\"}],"source_content_type":"text/x-rst","patch_set":9,"id":"bf51134e_ca7836c2","line":304,"in_reply_to":"bf51134e_28d62250","updated":"2020-07-16 22:13:55.000000000","message":"I suspect we might want to point to someone else\u0027s guide instead?","commit_id":"73254bd512b4043e9147a84fb979cec893b4b174"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1c686c775323e1416fa3ff85f6f2657fa3589f35","unresolved":false,"context_lines":[{"line_number":309,"context_line":""},{"line_number":310,"context_line":"#. Deploy the node::"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"       openstack baremetal node deploy $NODE_UUID"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"The node ramdisk components will then be assembled by the conductor,"},{"line_number":315,"context_line":"appropriate configuration put in place, and the node will then be powered"}],"source_content_type":"text/x-rst","patch_set":9,"id":"bf51134e_88c92ead","line":312,"updated":"2020-07-16 14:47:06.000000000","message":"maybe add a warning that configdrive is not supported?","commit_id":"73254bd512b4043e9147a84fb979cec893b4b174"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"ca40d0081baf4f8db92327794aa720a1a6c27a7d","unresolved":false,"context_lines":[{"line_number":309,"context_line":""},{"line_number":310,"context_line":"#. Deploy the node::"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"       openstack baremetal node deploy $NODE_UUID"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"The node ramdisk components will then be assembled by the conductor,"},{"line_number":315,"context_line":"appropriate configuration put in place, and the node will then be powered"}],"source_content_type":"text/x-rst","patch_set":9,"id":"bf51134e_ea56da29","line":312,"in_reply_to":"bf51134e_88c92ead","updated":"2020-07-16 22:13:55.000000000","message":"Done","commit_id":"73254bd512b4043e9147a84fb979cec893b4b174"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1c686c775323e1416fa3ff85f6f2657fa3589f35","unresolved":false,"context_lines":[{"line_number":323,"context_line":"and ``ipxe`` boot interfaces, an operator may request an explict ISO file to"},{"line_number":324,"context_line":"be booted."},{"line_number":325,"context_line":""},{"line_number":326,"context_line":"#. Store the URL or image UUID to the ``instance_info\\boot_iso`` setting::"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"       openstack barmetal node set $NODE_UUID \\"},{"line_number":329,"context_line":"               --instance-info boot_iso\u003d$BOOT_ISO_URL"}],"source_content_type":"text/x-rst","patch_set":9,"id":"bf51134e_68cc9aba","line":326,"updated":"2020-07-16 14:47:06.000000000","message":"nit 1: \"instead of kernel/ramdisk\"\n\nnit 2: we tend to use / not \\\n\nnit 3: no image UUID, it\u0027s the standalone guide","commit_id":"73254bd512b4043e9147a84fb979cec893b4b174"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1c686c775323e1416fa3ff85f6f2657fa3589f35","unresolved":false,"context_lines":[{"line_number":334,"context_line":""},{"line_number":335,"context_line":""},{"line_number":336,"context_line":".. warning::"},{"line_number":337,"context_line":"   This feature, when utilized with the ``ipxe`` boot_interface will only"},{"line_number":338,"context_line":"   allow a kernel and ramdisk to be booted from the supplied ISO file."},{"line_number":339,"context_line":"   Any additional contents, such as additional ramdisk contents or"},{"line_number":340,"context_line":"   installer package files will be unavailable after the boot of the"}],"source_content_type":"text/x-rst","patch_set":9,"id":"bf51134e_c8c6869a","line":337,"updated":"2020-07-16 14:47:06.000000000","message":"nit: missing comma after boot_interface? also either \"boot interface\" or \"``boot_interface``\"","commit_id":"73254bd512b4043e9147a84fb979cec893b4b174"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1c686c775323e1416fa3ff85f6f2657fa3589f35","unresolved":false,"context_lines":[{"line_number":340,"context_line":"   installer package files will be unavailable after the boot of the"},{"line_number":341,"context_line":"   machine. Operators wishing to leverage this functionality for actions"},{"line_number":342,"context_line":"   such as OS installation should explore use of the standard ``ramdisk``"},{"line_number":343,"context_line":"   deploy_interface along with the ``instance_info\\kernel_append_params``"},{"line_number":344,"context_line":"   setting to pass arbitrary settings such as a mirror URL for the initial"},{"line_number":345,"context_line":"   ramdisk to load data from."},{"line_number":346,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"bf51134e_a8c19282","line":343,"updated":"2020-07-16 14:47:06.000000000","message":"nit: /","commit_id":"73254bd512b4043e9147a84fb979cec893b4b174"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1c686c775323e1416fa3ff85f6f2657fa3589f35","unresolved":false,"context_lines":[{"line_number":348,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":349,"context_line":""},{"line_number":350,"context_line":"* Instances deployed using ramdisks cannot use configuration drives as"},{"line_number":351,"context_line":"  no disk image will be written to the remote node."},{"line_number":352,"context_line":""},{"line_number":353,"context_line":""},{"line_number":354,"context_line":"Other references"}],"source_content_type":"text/x-rst","patch_set":9,"id":"bf51134e_08bd1e01","line":351,"updated":"2020-07-16 14:47:06.000000000","message":"Ah, here it is. I\u0027d rather move it to after deploy (or move other limitations here, such as the warning just above)","commit_id":"73254bd512b4043e9147a84fb979cec893b4b174"}],"ironic/common/pxe_utils.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"193c3afb9c174ec132e66991b422c86a19cd0c32","unresolved":false,"context_lines":[{"line_number":731,"context_line":""},{"line_number":732,"context_line":""},{"line_number":733,"context_line":""},{"line_number":734,"context_line":"    return pxe_opts"},{"line_number":735,"context_line":""},{"line_number":736,"context_line":""},{"line_number":737,"context_line":"def build_extra_pxe_options(ramdisk_params\u003dNone):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_e969da24","line":734,"updated":"2020-05-21 01:36:03.000000000","message":"pep8: E303 too many blank lines (3)","commit_id":"53b5d2471ce3f68369b3d91d057d9e28ebcbf8e6"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"8b7ebd51a2f443eaced88581d4171941cd90c5d1","unresolved":false,"context_lines":[{"line_number":725,"context_line":"        if i_info[\u0027boot_iso\u0027]:"},{"line_number":726,"context_line":"            pxe_opts[\u0027boot_iso_url\u0027] \u003d \u0027/\u0027.join("},{"line_number":727,"context_line":"                [CONF.deploy.http_url, node.uuid, \u0027boot_iso\u0027])"},{"line_number":728,"context_line":"            pxe_opts[\u0027boot_from_iso\u0027] \u003d True"},{"line_number":729,"context_line":"    except KeyError:"},{"line_number":730,"context_line":"        pass"},{"line_number":731,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"bf51134e_4898521a","line":728,"range":{"start_line":728,"start_character":12,"end_line":728,"end_character":44},"updated":"2020-06-18 16:43:15.000000000","message":"we might not need this for the template parsing, we could likely check if the field is present.","commit_id":"4bb1181e9ef99444614f9dd486436f9893a2b0d3"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"bf18cc99a53c34fcd29acfd7b11b08da361dd0c9","unresolved":false,"context_lines":[{"line_number":725,"context_line":"        if i_info[\u0027boot_iso\u0027]:"},{"line_number":726,"context_line":"            pxe_opts[\u0027boot_iso_url\u0027] \u003d \u0027/\u0027.join("},{"line_number":727,"context_line":"                [CONF.deploy.http_url, node.uuid, \u0027boot_iso\u0027])"},{"line_number":728,"context_line":"            pxe_opts[\u0027boot_from_iso\u0027] \u003d True"},{"line_number":729,"context_line":"    except KeyError:"},{"line_number":730,"context_line":"        pass"},{"line_number":731,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"bf51134e_75f434d0","line":728,"range":{"start_line":728,"start_character":12,"end_line":728,"end_character":44},"in_reply_to":"bf51134e_4898521a","updated":"2020-07-02 21:20:04.000000000","message":"Done","commit_id":"4bb1181e9ef99444614f9dd486436f9893a2b0d3"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1c686c775323e1416fa3ff85f6f2657fa3589f35","unresolved":false,"context_lines":[{"line_number":633,"context_line":"            i_info[\u0027boot_iso\u0027],"},{"line_number":634,"context_line":"            os.path.join(root_dir, node.uuid, \u0027boot_iso\u0027))"},{"line_number":635,"context_line":"        return image_info"},{"line_number":636,"context_line":"    else:"},{"line_number":637,"context_line":"        labels \u003d (\u0027kernel\u0027, \u0027ramdisk\u0027)"},{"line_number":638,"context_line":"    d_info \u003d deploy_utils.get_image_instance_info(node)"},{"line_number":639,"context_line":"    if not (i_info.get(\u0027kernel\u0027) and i_info.get(\u0027ramdisk\u0027)):"}],"source_content_type":"text/x-python","patch_set":9,"id":"bf51134e_e8b70a20","line":636,"updated":"2020-07-16 14:47:06.000000000","message":"nit-nit: avoid \u0027else\u0027 to make the \u0027return\u0027 above more obvious (I\u0027ve nearly missed it)","commit_id":"73254bd512b4043e9147a84fb979cec893b4b174"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"ca40d0081baf4f8db92327794aa720a1a6c27a7d","unresolved":false,"context_lines":[{"line_number":633,"context_line":"            i_info[\u0027boot_iso\u0027],"},{"line_number":634,"context_line":"            os.path.join(root_dir, node.uuid, \u0027boot_iso\u0027))"},{"line_number":635,"context_line":"        return image_info"},{"line_number":636,"context_line":"    else:"},{"line_number":637,"context_line":"        labels \u003d (\u0027kernel\u0027, \u0027ramdisk\u0027)"},{"line_number":638,"context_line":"    d_info \u003d deploy_utils.get_image_instance_info(node)"},{"line_number":639,"context_line":"    if not (i_info.get(\u0027kernel\u0027) and i_info.get(\u0027ramdisk\u0027)):"}],"source_content_type":"text/x-python","patch_set":9,"id":"bf51134e_aa04e24a","line":636,"in_reply_to":"bf51134e_e8b70a20","updated":"2020-07-16 22:13:55.000000000","message":"Yeah, really don\u0027t need it right now...","commit_id":"73254bd512b4043e9147a84fb979cec893b4b174"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1c686c775323e1416fa3ff85f6f2657fa3589f35","unresolved":false,"context_lines":[{"line_number":734,"context_line":"    try:"},{"line_number":735,"context_line":"        # TODO(TheJulia): Boot iso should change at a later point"},{"line_number":736,"context_line":"        # if we serve more than just as a pass-through."},{"line_number":737,"context_line":"        if i_info[\u0027boot_iso\u0027]:"},{"line_number":738,"context_line":"            pxe_opts[\u0027boot_iso_url\u0027] \u003d \u0027/\u0027.join("},{"line_number":739,"context_line":"                [CONF.deploy.http_url, node.uuid, \u0027boot_iso\u0027])"},{"line_number":740,"context_line":"    except KeyError:"}],"source_content_type":"text/x-python","patch_set":9,"id":"bf51134e_4838b69e","line":737,"updated":"2020-07-16 14:47:06.000000000","message":"nit: use get() and avoid except KeyError","commit_id":"73254bd512b4043e9147a84fb979cec893b4b174"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e264259252bdf66f4350a5898cf696cb8623eaff","unresolved":false,"context_lines":[{"line_number":738,"context_line":"        if i_info.get(\u0027boot_iso\u0027):"},{"line_number":739,"context_line":"            pxe_opts[\u0027boot_iso_url\u0027] \u003d \u0027/\u0027.join("},{"line_number":740,"context_line":"                [CONF.deploy.http_url, node.uuid, \u0027boot_iso\u0027])"},{"line_number":741,"context_line":"    except KeyError:"},{"line_number":742,"context_line":"        pass"},{"line_number":743,"context_line":""},{"line_number":744,"context_line":"    return pxe_opts"}],"source_content_type":"text/x-python","patch_set":10,"id":"bf51134e_776d2398","line":741,"updated":"2020-07-23 14:11:27.000000000","message":"nit: KeyError is not possible","commit_id":"0cbb0397b15493152a2eba63a87d4ebf7d2308fe"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"21a2b7212cfc7028e632cf38a5b313bed7848c21","unresolved":false,"context_lines":[{"line_number":738,"context_line":"        if i_info.get(\u0027boot_iso\u0027):"},{"line_number":739,"context_line":"            pxe_opts[\u0027boot_iso_url\u0027] \u003d \u0027/\u0027.join("},{"line_number":740,"context_line":"                [CONF.deploy.http_url, node.uuid, \u0027boot_iso\u0027])"},{"line_number":741,"context_line":"    except KeyError:"},{"line_number":742,"context_line":"        pass"},{"line_number":743,"context_line":""},{"line_number":744,"context_line":"    return pxe_opts"}],"source_content_type":"text/x-python","patch_set":10,"id":"bf51134e_8826d815","line":741,"in_reply_to":"bf51134e_776d2398","updated":"2020-07-23 17:03:58.000000000","message":"doh, yup that is a leftover.","commit_id":"0cbb0397b15493152a2eba63a87d4ebf7d2308fe"}],"ironic/drivers/modules/deploy_utils.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"8b7ebd51a2f443eaced88581d4171941cd90c5d1","unresolved":false,"context_lines":[{"line_number":471,"context_line":"    except (exception.GlanceConnectionFailed,"},{"line_number":472,"context_line":"            exception.ImageNotAuthorized,"},{"line_number":473,"context_line":"            exception.Invalid):"},{"line_number":474,"context_line":"        raise exception.InvalidParameterValue(_("},{"line_number":475,"context_line":"            \"Failed to connect to Glance to get the properties \""},{"line_number":476,"context_line":"            \"of the image %s\") % image_href)"},{"line_number":477,"context_line":"    except exception.ImageNotFound:"}],"source_content_type":"text/x-python","patch_set":6,"id":"bf51134e_a8464e7b","line":474,"updated":"2020-06-18 16:43:15.000000000","message":"General for somewhere in this file: we should likely check if  non deploy_interface ramdisk is being mixed with boot_iso being present. If that is the case, we should fail validation.","commit_id":"4bb1181e9ef99444614f9dd486436f9893a2b0d3"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"bf18cc99a53c34fcd29acfd7b11b08da361dd0c9","unresolved":false,"context_lines":[{"line_number":471,"context_line":"    except (exception.GlanceConnectionFailed,"},{"line_number":472,"context_line":"            exception.ImageNotAuthorized,"},{"line_number":473,"context_line":"            exception.Invalid):"},{"line_number":474,"context_line":"        raise exception.InvalidParameterValue(_("},{"line_number":475,"context_line":"            \"Failed to connect to Glance to get the properties \""},{"line_number":476,"context_line":"            \"of the image %s\") % image_href)"},{"line_number":477,"context_line":"    except exception.ImageNotFound:"}],"source_content_type":"text/x-python","patch_set":6,"id":"bf51134e_b5feccab","line":474,"in_reply_to":"bf51134e_a8464e7b","updated":"2020-07-02 21:20:04.000000000","message":"Added general validation in the prior patch.","commit_id":"4bb1181e9ef99444614f9dd486436f9893a2b0d3"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1c686c775323e1416fa3ff85f6f2657fa3589f35","unresolved":false,"context_lines":[{"line_number":517,"context_line":"            \"An \u0027image_source\u0027 and \u0027boot_iso\u0027 parameter may not be \""},{"line_number":518,"context_line":"            \"specified at the same time.\"))"},{"line_number":519,"context_line":"    if not image_href:"},{"line_number":520,"context_line":"        image_href \u003d deploy_info.get(\u0027boot_iso\u0027)"},{"line_number":521,"context_line":"    try:"},{"line_number":522,"context_line":"        img_service \u003d image_service.get_image_service(image_href, context\u003dctx)"},{"line_number":523,"context_line":"        image_props \u003d img_service.show(image_href)[\u0027properties\u0027]"}],"source_content_type":"text/x-python","patch_set":9,"id":"bf51134e_283bc29b","line":520,"updated":"2020-07-16 14:47:06.000000000","message":"nit:\n\n image_href \u003d boot_iso","commit_id":"73254bd512b4043e9147a84fb979cec893b4b174"}],"ironic/drivers/modules/ipxe_config.template":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"8b7ebd51a2f443eaced88581d4171941cd90c5d1","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":":boot_ramdisk"},{"line_number":35,"context_line":"imgfree"},{"line_number":36,"context_line":"{%- if pxe_options.boot_from_iso %}"},{"line_number":37,"context_line":"sanboot {{ pxe_options.boot_iso_url }}"},{"line_number":38,"context_line":"{%- else %}"},{"line_number":39,"context_line":"kernel {% if pxe_options.ipxe_timeout \u003e 0 %}--timeout {{ pxe_options.ipxe_timeout }} {% endif %}{{ pxe_options.aki_path }} root\u003d/dev/ram0 text {{ pxe_options.pxe_append_params|default(\"\", true) }} {{ pxe_options.ramdisk_opts|default(\u0027\u0027, true) }} initrd\u003dramdisk || goto boot_ramdisk"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"bf51134e_4866922b","line":36,"range":{"start_line":36,"start_character":19,"end_line":36,"end_character":32},"updated":"2020-06-18 16:43:15.000000000","message":"We should likely use boot_iso_url","commit_id":"4bb1181e9ef99444614f9dd486436f9893a2b0d3"}],"ironic/drivers/modules/pxe_base.py":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"b7583889da0109b387663f7884142ff00297949d","unresolved":false,"context_lines":[{"line_number":378,"context_line":"        if (node.driver_internal_info.get(\u0027is_whole_disk_image\u0027)"},{"line_number":379,"context_line":"                or deploy_utils.get_boot_option(node) \u003d\u003d \u0027local\u0027):"},{"line_number":380,"context_line":"            props \u003d []"},{"line_number":381,"context_line":"        elif d_info.get(\u0027boot_iso\u0027):"},{"line_number":382,"context_line":"            props \u003d [\u0027boot_iso\u0027]"},{"line_number":383,"context_line":"        elif service_utils.is_glance_image(d_info[\u0027image_source\u0027]):"},{"line_number":384,"context_line":"            props \u003d [\u0027kernel_id\u0027, \u0027ramdisk_id\u0027]"},{"line_number":385,"context_line":"        else:"},{"line_number":386,"context_line":"            props \u003d [\u0027kernel\u0027, \u0027ramdisk\u0027]"}],"source_content_type":"text/x-python","patch_set":6,"id":"bf51134e_4fbfbccf","line":383,"range":{"start_line":381,"start_character":8,"end_line":383,"end_character":67},"updated":"2020-06-18 14:27:17.000000000","message":"Wont it be better to check that both \u0027boot_iso\u0027 and \u0027image_source\u0027 are not present simultaneously in instance_info.","commit_id":"4bb1181e9ef99444614f9dd486436f9893a2b0d3"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"bf18cc99a53c34fcd29acfd7b11b08da361dd0c9","unresolved":false,"context_lines":[{"line_number":378,"context_line":"        if (node.driver_internal_info.get(\u0027is_whole_disk_image\u0027)"},{"line_number":379,"context_line":"                or deploy_utils.get_boot_option(node) \u003d\u003d \u0027local\u0027):"},{"line_number":380,"context_line":"            props \u003d []"},{"line_number":381,"context_line":"        elif d_info.get(\u0027boot_iso\u0027):"},{"line_number":382,"context_line":"            props \u003d [\u0027boot_iso\u0027]"},{"line_number":383,"context_line":"        elif service_utils.is_glance_image(d_info[\u0027image_source\u0027]):"},{"line_number":384,"context_line":"            props \u003d [\u0027kernel_id\u0027, \u0027ramdisk_id\u0027]"},{"line_number":385,"context_line":"        else:"},{"line_number":386,"context_line":"            props \u003d [\u0027kernel\u0027, \u0027ramdisk\u0027]"}],"source_content_type":"text/x-python","patch_set":6,"id":"bf51134e_d51a6015","line":383,"range":{"start_line":381,"start_character":8,"end_line":383,"end_character":67},"in_reply_to":"bf51134e_4fbfbccf","updated":"2020-07-02 21:20:04.000000000","message":"The next method will validate if both, however this is just generating the list of expected properties.","commit_id":"4bb1181e9ef99444614f9dd486436f9893a2b0d3"}],"ironic/tests/unit/drivers/modules/test_ipxe.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"59b8feb84943b6a68d782a5dfcc2e884472c4506","unresolved":false,"context_lines":[{"line_number":132,"context_line":"                              task.driver.boot.validate, task)"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    @mock.patch.object(image_service.GlanceImageService, \u0027show\u0027, autospec\u003dTrue)"},{"line_number":135,"context_line":"    @mock.patch(\u0027ironic.drivers.modules.deploy_utils.get_boot_option\u0027,"},{"line_number":136,"context_line":"                return_value\u003d\u0027ramdisk\u0027)"},{"line_number":137,"context_line":"    def test_validate_with_boot_iso(self, mock_boot_option, mock_glance):"},{"line_number":138,"context_line":"        i_info \u003d self.node.driver_info"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_07d96b82","line":135,"updated":"2020-06-15 23:59:56.000000000","message":"pep8: H210 Missing \u0027autospec\u0027 or \u0027spec_set\u0027 keyword in mock.patch/mock.patch.object","commit_id":"40803106619b69c598a81aa1ca7ac3b57165e321"}]}