)]}'
{"ironic/api/controllers/v1/port.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a397e5e2b14fb5e277f012b41e064fb2b6915b2a","unresolved":false,"context_lines":[{"line_number":372,"context_line":"                                                      marker_obj,"},{"line_number":373,"context_line":"                                                      sort_key\u003dsort_key,"},{"line_number":374,"context_line":"                                                      sort_dir\u003dsort_dir,"},{"line_number":375,"context_line":"                                                      owner\u003downer,"},{"line_number":376,"context_line":"                                                      project\u003dproject)"},{"line_number":377,"context_line":"        elif node_ident:"},{"line_number":378,"context_line":"            # FIXME(comstud): Since all we need is the node ID, we can"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf51134e_e76bbeb3","line":375,"updated":"2020-06-29 08:21:44.000000000","message":"Let\u0027s replace usages of \u0027owner\u0027 with usages of \u0027project\u0027 so that we can remove the \u0027owner\u0027 argument from the RPC in the next release?","commit_id":"a7785a333a2ac0c0926004ea43423f5e96f71124"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"087162ae620dd56d870bb9e4468dc46f58656075","unresolved":false,"context_lines":[{"line_number":359,"context_line":"        :param fields: Optional, a list with a specified set of fields"},{"line_number":360,"context_line":"            of the resource to be returned."},{"line_number":361,"context_line":"        :param detail: Optional, show detailed list of ports"},{"line_number":362,"context_line":"        :param owner: DEPRECATED Optional, filter by owner"},{"line_number":363,"context_line":"        :param project: Optional, filter by project"},{"line_number":364,"context_line":"        :returns: a list of ports."},{"line_number":365,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_d7c4ef42","line":362,"updated":"2020-07-23 14:21:13.000000000","message":"This is an internal function, we could just remove the argument","commit_id":"0fd731bbfb118b9e1db16372121b159dc4c3e6ad"},{"author":{"_account_id":7386,"name":"Tzu-Mainn Chen","email":"tzumainn@redhat.com","username":"tzumainn"},"change_message_id":"9807f148e72db7a4d4fbbbba128af6f7746e41a3","unresolved":false,"context_lines":[{"line_number":359,"context_line":"        :param fields: Optional, a list with a specified set of fields"},{"line_number":360,"context_line":"            of the resource to be returned."},{"line_number":361,"context_line":"        :param detail: Optional, show detailed list of ports"},{"line_number":362,"context_line":"        :param owner: DEPRECATED Optional, filter by owner"},{"line_number":363,"context_line":"        :param project: Optional, filter by project"},{"line_number":364,"context_line":"        :returns: a list of ports."},{"line_number":365,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_124cb574","line":362,"in_reply_to":"bf51134e_d7c4ef42","updated":"2020-07-23 15:53:59.000000000","message":"Ah, I wasn\u0027t sure - thanks for the clarification! Fixed.","commit_id":"0fd731bbfb118b9e1db16372121b159dc4c3e6ad"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"087162ae620dd56d870bb9e4468dc46f58656075","unresolved":false,"context_lines":[{"line_number":433,"context_line":""},{"line_number":434,"context_line":"        :param address: MAC address of a port, to get the port which has"},{"line_number":435,"context_line":"                        this MAC address."},{"line_number":436,"context_line":"        :param owner: DEPRECATED Optional, filter by owner"},{"line_number":437,"context_line":"        :param project: Optional, filter by project"},{"line_number":438,"context_line":"        :returns: a list with the port, or an empty list if no port is found."},{"line_number":439,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_b7bfbba8","line":436,"updated":"2020-07-23 14:21:13.000000000","message":"ditto, it\u0027s an internal call, you can break it","commit_id":"0fd731bbfb118b9e1db16372121b159dc4c3e6ad"},{"author":{"_account_id":7386,"name":"Tzu-Mainn Chen","email":"tzumainn@redhat.com","username":"tzumainn"},"change_message_id":"9807f148e72db7a4d4fbbbba128af6f7746e41a3","unresolved":false,"context_lines":[{"line_number":433,"context_line":""},{"line_number":434,"context_line":"        :param address: MAC address of a port, to get the port which has"},{"line_number":435,"context_line":"                        this MAC address."},{"line_number":436,"context_line":"        :param owner: DEPRECATED Optional, filter by owner"},{"line_number":437,"context_line":"        :param project: Optional, filter by project"},{"line_number":438,"context_line":"        :returns: a list with the port, or an empty list if no port is found."},{"line_number":439,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_129af5c3","line":436,"in_reply_to":"bf51134e_b7bfbba8","updated":"2020-07-23 15:53:59.000000000","message":"Gotcha - fixed!","commit_id":"0fd731bbfb118b9e1db16372121b159dc4c3e6ad"}],"ironic/objects/port.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a397e5e2b14fb5e277f012b41e064fb2b6915b2a","unresolved":false,"context_lines":[{"line_number":203,"context_line":"    # Implications of calling new remote procedures should be thought through."},{"line_number":204,"context_line":"    # @object_base.remotable_classmethod"},{"line_number":205,"context_line":"    @classmethod"},{"line_number":206,"context_line":"    def get_by_address(cls, context, address, owner\u003dNone, project\u003dNone):"},{"line_number":207,"context_line":"        \"\"\"Find a port based on address and return a :class:`Port` object."},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"        :param cls: the :class:`Port`"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf51134e_a7a386ff","line":206,"updated":"2020-06-29 08:21:44.000000000","message":"Can we deprecate owner for removal in W now?","commit_id":"a7785a333a2ac0c0926004ea43423f5e96f71124"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"087162ae620dd56d870bb9e4468dc46f58656075","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    #              internal_info[\u0027tenant_vif_port_id\u0027] (not an explicit db"},{"line_number":43,"context_line":"    #              change)"},{"line_number":44,"context_line":"    # Version 1.9: Add support for Smart NIC port"},{"line_number":45,"context_line":"    VERSION \u003d \u00271.9\u0027"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    dbapi \u003d dbapi.get_instance()"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_17dca716","line":45,"updated":"2020-07-23 14:21:13.000000000","message":"I think the version has to be bumped. Ideally, we should use the negotiated version to decide which argument to use on the API side.","commit_id":"0fd731bbfb118b9e1db16372121b159dc4c3e6ad"},{"author":{"_account_id":7386,"name":"Tzu-Mainn Chen","email":"tzumainn@redhat.com","username":"tzumainn"},"change_message_id":"9807f148e72db7a4d4fbbbba128af6f7746e41a3","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    #              internal_info[\u0027tenant_vif_port_id\u0027] (not an explicit db"},{"line_number":43,"context_line":"    #              change)"},{"line_number":44,"context_line":"    # Version 1.9: Add support for Smart NIC port"},{"line_number":45,"context_line":"    VERSION \u003d \u00271.9\u0027"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    dbapi \u003d dbapi.get_instance()"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_92f725d5","line":45,"in_reply_to":"bf51134e_17dca716","updated":"2020-07-23 15:53:59.000000000","message":"Bumped; what would this negotiation look like? Would I check this port version in the REST API, and pass in owner instead of project if the version was 1.9 instead of 1.10? Or am I confusing things?","commit_id":"0fd731bbfb118b9e1db16372121b159dc4c3e6ad"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"d5d22e5bb23e338a27000bf53df421a92bcb078b","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    #              internal_info[\u0027tenant_vif_port_id\u0027] (not an explicit db"},{"line_number":43,"context_line":"    #              change)"},{"line_number":44,"context_line":"    # Version 1.9: Add support for Smart NIC port"},{"line_number":45,"context_line":"    VERSION \u003d \u00271.9\u0027"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    dbapi \u003d dbapi.get_instance()"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_4d9e9207","line":45,"in_reply_to":"bf51134e_92f725d5","updated":"2020-07-23 16:14:19.000000000","message":"Ugh, sorry, I think I might have mislead you totally. These get_by_* calls do not go through RPC, they\u0027re executed locally against the database. You can just delete the old argument and there is no need to modify the version. Sorry again.","commit_id":"0fd731bbfb118b9e1db16372121b159dc4c3e6ad"}],"releasenotes/notes/port-list-by-project-8cfaf3b2cf0dd627.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"087162ae620dd56d870bb9e4468dc46f58656075","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    project against the port\u0027s node\u0027s owner and lessee."},{"line_number":6,"context_line":"deprecations:"},{"line_number":7,"context_line":"  - |"},{"line_number":8,"context_line":"    The `owner` filter option for port lists is now deprecated. If specified"},{"line_number":9,"context_line":"    without `project`, the port list will use the `owner` value for `project`."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bf51134e_f7de530e","line":8,"updated":"2020-07-23 14:21:13.000000000","message":"This reads as if we had deprecated something in the API. I think we can skip the release note about the RPC changes since they are internal.","commit_id":"0fd731bbfb118b9e1db16372121b159dc4c3e6ad"},{"author":{"_account_id":7386,"name":"Tzu-Mainn Chen","email":"tzumainn@redhat.com","username":"tzumainn"},"change_message_id":"9807f148e72db7a4d4fbbbba128af6f7746e41a3","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    project against the port\u0027s node\u0027s owner and lessee."},{"line_number":6,"context_line":"deprecations:"},{"line_number":7,"context_line":"  - |"},{"line_number":8,"context_line":"    The `owner` filter option for port lists is now deprecated. If specified"},{"line_number":9,"context_line":"    without `project`, the port list will use the `owner` value for `project`."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bf51134e_f22f813b","line":8,"in_reply_to":"bf51134e_f7de530e","updated":"2020-07-23 15:53:59.000000000","message":"Removed!","commit_id":"0fd731bbfb118b9e1db16372121b159dc4c3e6ad"}]}