)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"eeffc7462050750f236387a12d61b609d35dba52","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sirushti Murugesan \u003csirushtim@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-04-25 01:33:39 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adds support for deploying Disk Images"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Certain operating systems do not support pxe booting via a certain"},{"line_number":10,"context_line":"kernel and ramdisk. Theres no choice but to boot whole disk images"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"AAAAXX%2F%2F6Xw%3D","line":7,"updated":"2014-04-25 11:16:53.000000000","message":"If you happen to create one more versions of this patch, better spell it like \"deploying whole disk images\" not to confuse the reader.","commit_id":"def7a44f977b103c645d6271da67489e18ac3ea9"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"23c985eaed448cd047a3bd2b1d736dcc3000a5cd","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sirushti Murugesan \u003csirushtim@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-04-25 01:33:39 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adds support for deploying Disk Images"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Certain operating systems do not support pxe booting via a certain"},{"line_number":10,"context_line":"kernel and ramdisk. Theres no choice but to boot whole disk images"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"AAAAXX%2F%2F6Jg%3D","line":7,"in_reply_to":"AAAAXX%2F%2F6Xw%3D","updated":"2014-04-28 04:59:55.000000000","message":"Done","commit_id":"def7a44f977b103c645d6271da67489e18ac3ea9"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"108599e260d94022f0ccfb75e8de83d5a3f27343","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Adds support for deploying whole disk images"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Certain operating systems do not support pxe booting via a certain"},{"line_number":10,"context_line":"kernel and ramdisk. Theres no choice but to boot whole disk images"},{"line_number":11,"context_line":"of these operating systems."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch extends the PXE Driver to deploy disk images."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"7adec928_119c655c","line":10,"updated":"2014-05-19 11:08:25.000000000","message":"typo s/theres/there is/","commit_id":"a89ddcb797795d94fd8cabdfeee698ced6f7ac62"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"108599e260d94022f0ccfb75e8de83d5a3f27343","unresolved":false,"context_lines":[{"line_number":16,"context_line":"named pxe_deploy_disk in driver_info."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Nova checks the image properties to determine the type of image being"},{"line_number":19,"context_line":"deployed. If the image has kernel/ramdisk, its considered a partition"},{"line_number":20,"context_line":"image, otherwise its considered a bootable disk image and thus sets"},{"line_number":21,"context_line":"Ironic\u0027s driver_info:pxe_deploy_disk accordingly."},{"line_number":22,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"7adec928_31a6c1ae","line":19,"updated":"2014-05-19 11:08:25.000000000","message":"No `its` please: either `it\u0027s` or `it is`","commit_id":"a89ddcb797795d94fd8cabdfeee698ced6f7ac62"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"108599e260d94022f0ccfb75e8de83d5a3f27343","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Nova checks the image properties to determine the type of image being"},{"line_number":19,"context_line":"deployed. If the image has kernel/ramdisk, its considered a partition"},{"line_number":20,"context_line":"image, otherwise its considered a bootable disk image and thus sets"},{"line_number":21,"context_line":"Ironic\u0027s driver_info:pxe_deploy_disk accordingly."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"For disk images, the image is only deployed via PXE but is then booted"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"7adec928_51a18d92","line":20,"updated":"2014-05-19 11:08:25.000000000","message":"ditto","commit_id":"a89ddcb797795d94fd8cabdfeee698ced6f7ac62"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"108599e260d94022f0ccfb75e8de83d5a3f27343","unresolved":false,"context_lines":[{"line_number":21,"context_line":"Ironic\u0027s driver_info:pxe_deploy_disk accordingly."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"For disk images, the image is only deployed via PXE but is then booted"},{"line_number":24,"context_line":"locally via a Power Manager call to change the boot order."},{"line_number":25,"context_line":"Furthermore, PXE Boot will also be disabled from Neutron."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Implements blueprint windows-disk-image-support"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"7adec928_d1bcbdbd","line":24,"updated":"2014-05-19 11:08:25.000000000","message":"Could you somehow change this sentence? While I guess I understand what you mean by \"booting via changing boot order\", it still somewhat vague.","commit_id":"a89ddcb797795d94fd8cabdfeee698ced6f7ac62"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"b2508f75781f7669cb786c9f3dd4bed25b298581","unresolved":false,"context_lines":[{"line_number":21,"context_line":"Ironic\u0027s driver_info:pxe_deploy_disk accordingly."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"For disk images, the image is only deployed via PXE but is then booted"},{"line_number":24,"context_line":"locally via a Power Manager call to change the boot order."},{"line_number":25,"context_line":"Furthermore, PXE Boot will also be disabled from Neutron."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Implements blueprint windows-disk-image-support"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"7adec928_d26ae218","line":24,"in_reply_to":"7adec928_d1bcbdbd","updated":"2014-05-21 11:13:06.000000000","message":"Done for all of the above.","commit_id":"a89ddcb797795d94fd8cabdfeee698ced6f7ac62"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"452770ab66d10492378e447def6eea5579c78b67","unresolved":false,"context_lines":[{"line_number":20,"context_line":"image, otherwise it\u0027s considered a bootable disk image and thus sets"},{"line_number":21,"context_line":"Ironic\u0027s driver_info:pxe_deploy_disk accordingly."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Disk images are only deployed via pxe but is then booted from"},{"line_number":24,"context_line":"hard disk(localboot) thereafter by changing the boot order via"},{"line_number":25,"context_line":"a Power Manager call."},{"line_number":26,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"7adec928_21f36b0b","line":23,"updated":"2014-05-22 11:46:54.000000000","message":"`are ... deployed ... is then booted`: s/is then/then are/","commit_id":"b261a16f645438c3f42843775a482c8254601f99"}],"etc/ironic/ironic.conf.sample":[{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"cd6a3cda00b594431e2bbae6036b85cf5f93ae9a","unresolved":false,"context_lines":[{"line_number":621,"context_line":""},{"line_number":622,"context_line":"# Template file for PXE configuration of Disk Images (string"},{"line_number":623,"context_line":"# value)"},{"line_number":624,"context_line":"#pxe_config_disk_template\u003d$pybasedir/drivers/modules/pxe_config_disk.template"},{"line_number":625,"context_line":""},{"line_number":626,"context_line":"# IP address of Ironic compute node\u0027s tftp server (string"},{"line_number":627,"context_line":"# value)"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"AAAAUX%2F%2B%2BlQ%3D","line":624,"updated":"2014-02-18 01:04:10.000000000","message":"This shouldn\u0027t be needed - we just want to not PXE boot that device. A single neutron call will arrange that.","commit_id":"5698e38ea1317466094226adc09b7ec983031e51"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"e4cfc6d6e08f5e723ab86dea607068b142d9efbe","unresolved":false,"context_lines":[{"line_number":621,"context_line":""},{"line_number":622,"context_line":"# Template file for PXE configuration of Disk Images (string"},{"line_number":623,"context_line":"# value)"},{"line_number":624,"context_line":"#pxe_config_disk_template\u003d$pybasedir/drivers/modules/pxe_config_disk.template"},{"line_number":625,"context_line":""},{"line_number":626,"context_line":"# IP address of Ironic compute node\u0027s tftp server (string"},{"line_number":627,"context_line":"# value)"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"AAAAUX%2F%2B7PM%3D","line":624,"in_reply_to":"AAAAUX%2F%2B%2BlQ%3D","updated":"2014-02-18 08:51:49.000000000","message":"Great idea, but I think there\u0027s a small catch here :) \n\nSo, I\u0027m assuming that you just want to ignore the baremetal node once its deployed. As in, When the Baremetal Node is going to try for PXE Boot on startup, it will fail and then fallback to localboot or whatever as set in the boot sequence or we could possibly change the boot sequence using the power manager which may or may not support this. Am i right? \n\nSo if that\u0027s the case, I\u0027ve heard that some folks would like to disable the Baremetal Node to fallback to localboot in the BIOS and force \u0027Only PXE Boot or reboot/retry\u0027. AFAIK, this is being done so that the node doesn\u0027t come up when either the network or the conductor are down but there could possibly be another reason too.\n\nA possible example - Say intentionally or unintentionally the node boots up somehow (Faulty IPMI, Rogue Magic Packet for WOL maybe?) and the end-user takes unmanaged control of it? That could be quite problematic or even worse, the baremetal node could wake up in another tenants network due to a network issue.\n\nSo i think it\u0027ll be better for the PXE Driver to decide when to boot a machine \nrather than letting a Baremetal Node itself decide.\n\nFurthermore, this PXE Config is just an example and is meant to work out of the box for disk images, but I assume that people might want to try a different PXE Configuration file for Disk Images using the flexibility that chain.c32[1] provides.\n\n[1] http://www.syslinux.org/wiki/index.php/Comboot/chain.c32\n\nLet me know if this sounds reasonable enough to continue with this approach.","commit_id":"5698e38ea1317466094226adc09b7ec983031e51"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"1c49f97f64aa9c80ad1783a8aa20478da7105e95","unresolved":false,"context_lines":[{"line_number":621,"context_line":""},{"line_number":622,"context_line":"# Template file for PXE configuration of Disk Images (string"},{"line_number":623,"context_line":"# value)"},{"line_number":624,"context_line":"#pxe_config_disk_template\u003d$pybasedir/drivers/modules/pxe_config_disk.template"},{"line_number":625,"context_line":""},{"line_number":626,"context_line":"# IP address of Ironic compute node\u0027s tftp server (string"},{"line_number":627,"context_line":"# value)"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"AAAAUX%2F%2Bxe4%3D","line":624,"in_reply_to":"AAAAUX%2F%2B7PM%3D","updated":"2014-02-19 06:10:17.000000000","message":"So we put a bunch of nodes in an etherpad attached to the spec after this review.\n\nThe tl;dr there is we want to switch the node to explicitly boot from the desired source rather than chain loading *or* PXE-fall-through. So we\u0027ll localboot for localboot scenarios, and PXE boot for PXE boot scenarios.","commit_id":"5698e38ea1317466094226adc09b7ec983031e51"}],"ironic/drivers/modules/deploy_utils.py":[{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"cd6a3cda00b594431e2bbae6036b85cf5f93ae9a","unresolved":false,"context_lines":[{"line_number":127,"context_line":"    return out.strip()"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"def switch_pxe_config(path, root_uuid\u003dNone):"},{"line_number":131,"context_line":"    \"\"\"Switch a pxe config from deployment mode to service mode.\"\"\""},{"line_number":132,"context_line":"    with open(path) as f:"},{"line_number":133,"context_line":"        lines \u003d f.readlines()"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUX%2F%2B%2Bk4%3D","line":130,"updated":"2014-02-18 01:04:10.000000000","message":"Not needed","commit_id":"5698e38ea1317466094226adc09b7ec983031e51"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"cd6a3cda00b594431e2bbae6036b85cf5f93ae9a","unresolved":false,"context_lines":[{"line_number":175,"context_line":""},{"line_number":176,"context_line":"    if deploy_disk:"},{"line_number":177,"context_line":"        dd(image_path, dev)"},{"line_number":178,"context_line":"        return"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"    root_part \u003d \"%s-part1\" % dev"},{"line_number":181,"context_line":"    swap_part \u003d \"%s-part2\" % dev"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUX%2F%2B%2BkU%3D","line":178,"updated":"2014-02-18 01:04:10.000000000","message":"Since this is a wholly different codepath, I think a new function is better rather than a parameter to control it.","commit_id":"5698e38ea1317466094226adc09b7ec983031e51"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"e4cfc6d6e08f5e723ab86dea607068b142d9efbe","unresolved":false,"context_lines":[{"line_number":175,"context_line":""},{"line_number":176,"context_line":"    if deploy_disk:"},{"line_number":177,"context_line":"        dd(image_path, dev)"},{"line_number":178,"context_line":"        return"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"    root_part \u003d \"%s-part1\" % dev"},{"line_number":181,"context_line":"    swap_part \u003d \"%s-part2\" % dev"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUX%2F%2B6eE%3D","line":178,"in_reply_to":"AAAAUX%2F%2B%2BkU%3D","updated":"2014-02-18 08:51:49.000000000","message":"Done.","commit_id":"5698e38ea1317466094226adc09b7ec983031e51"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"cd6a3cda00b594431e2bbae6036b85cf5f93ae9a","unresolved":false,"context_lines":[{"line_number":225,"context_line":"    finally:"},{"line_number":226,"context_line":"        logout_iscsi(address, port, iqn)"},{"line_number":227,"context_line":"        delete_iscsi(address, port, iqn)"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"    switch_pxe_config(pxe_config_path, root_uuid)"},{"line_number":230,"context_line":"    # Ensure the node started netcat on the port after POST the request."},{"line_number":231,"context_line":"    time.sleep(3)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUX%2F%2B%2Bjs%3D","line":228,"updated":"2014-02-18 01:04:10.000000000","message":"spurious whitespace - please submit as a separate patch if you want it :)","commit_id":"5698e38ea1317466094226adc09b7ec983031e51"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"e4cfc6d6e08f5e723ab86dea607068b142d9efbe","unresolved":false,"context_lines":[{"line_number":225,"context_line":"    finally:"},{"line_number":226,"context_line":"        logout_iscsi(address, port, iqn)"},{"line_number":227,"context_line":"        delete_iscsi(address, port, iqn)"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"    switch_pxe_config(pxe_config_path, root_uuid)"},{"line_number":230,"context_line":"    # Ensure the node started netcat on the port after POST the request."},{"line_number":231,"context_line":"    time.sleep(3)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUX%2F%2B7Es%3D","line":228,"in_reply_to":"AAAAUX%2F%2B%2Bjs%3D","updated":"2014-02-18 08:51:49.000000000","message":"Oops! Will remove :)","commit_id":"5698e38ea1317466094226adc09b7ec983031e51"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"361c7c9af2ec9ab2a0c859987912943f08326c83","unresolved":false,"context_lines":[{"line_number":167,"context_line":"    return image_mb"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"def write_to_disk(dev, image_path):"},{"line_number":171,"context_line":"    if not is_block_device(dev):"},{"line_number":172,"context_line":"        raise exception.InstanceDeployFailure(_(\"Parent device \u0027%s\u0027 not found\")"},{"line_number":173,"context_line":"                                              % dev)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAU3%2F%2Fb5I%3D","line":170,"updated":"2014-02-26 16:58:48.000000000","message":"Can you add a doc string for this function.","commit_id":"4ed74fbed60b27356e463e51eac6b8bb794d2178"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"d245a11080c8b924cbc07aefd6d08ec8ad73ca0e","unresolved":false,"context_lines":[{"line_number":167,"context_line":"    return image_mb"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"def write_to_disk(dev, image_path):"},{"line_number":171,"context_line":"    if not is_block_device(dev):"},{"line_number":172,"context_line":"        raise exception.InstanceDeployFailure(_(\"Parent device \u0027%s\u0027 not found\")"},{"line_number":173,"context_line":"                                              % dev)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAVn%2F%2FrQ4%3D","line":170,"in_reply_to":"AAAAU3%2F%2Fb5I%3D","updated":"2014-03-04 19:35:55.000000000","message":"+1","commit_id":"4ed74fbed60b27356e463e51eac6b8bb794d2178"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"370c5cd89d7b824af78cccb9f2613402ba2eaa0b","unresolved":false,"context_lines":[{"line_number":167,"context_line":"    return image_mb"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"def write_to_disk(dev, image_path):"},{"line_number":171,"context_line":"    if not is_block_device(dev):"},{"line_number":172,"context_line":"        raise exception.InstanceDeployFailure(_(\"Parent device \u0027%s\u0027 not found\")"},{"line_number":173,"context_line":"                                              % dev)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAVn%2F%2FoXA%3D","line":170,"in_reply_to":"AAAAVn%2F%2FrQ4%3D","updated":"2014-03-04 23:34:14.000000000","message":"Done","commit_id":"4ed74fbed60b27356e463e51eac6b8bb794d2178"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"d245a11080c8b924cbc07aefd6d08ec8ad73ca0e","unresolved":false,"context_lines":[{"line_number":170,"context_line":"def write_to_disk(dev, image_path):"},{"line_number":171,"context_line":"    if not is_block_device(dev):"},{"line_number":172,"context_line":"        raise exception.InstanceDeployFailure(_(\"Parent device \u0027%s\u0027 not found\")"},{"line_number":173,"context_line":"                                              % dev)"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"    dd(image_path, dev)"},{"line_number":176,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAVn%2F%2FrRE%3D","line":173,"updated":"2014-03-04 19:35:55.000000000","message":"This same check is being done by the work_on_disk() function, I think it would be better to do this check in the deploy() function then, so we can use the same check for both, write_to_disk() and work_on_disk()","commit_id":"4ed74fbed60b27356e463e51eac6b8bb794d2178"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"370c5cd89d7b824af78cccb9f2613402ba2eaa0b","unresolved":false,"context_lines":[{"line_number":170,"context_line":"def write_to_disk(dev, image_path):"},{"line_number":171,"context_line":"    if not is_block_device(dev):"},{"line_number":172,"context_line":"        raise exception.InstanceDeployFailure(_(\"Parent device \u0027%s\u0027 not found\")"},{"line_number":173,"context_line":"                                              % dev)"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"    dd(image_path, dev)"},{"line_number":176,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAVn%2F%2FoXQ%3D","line":173,"in_reply_to":"AAAAVn%2F%2FrRE%3D","updated":"2014-03-04 23:34:14.000000000","message":"Done","commit_id":"4ed74fbed60b27356e463e51eac6b8bb794d2178"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"f9d5e32f427a909d8f30dd02de88c5a40294790a","unresolved":false,"context_lines":[{"line_number":210,"context_line":"                                              % dev)"},{"line_number":211,"context_line":"    image_mb \u003d get_image_mb(image_path)"},{"line_number":212,"context_line":"    if image_mb \u003e root_mb:"},{"line_number":213,"context_line":"        root_mb \u003d image_mb"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"    make_partitions(dev, root_mb, swap_mb, ephemeral_mb)"},{"line_number":216,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAXH%2F%2F6ow%3D","line":213,"updated":"2014-04-16 14:43:02.000000000","message":"I have doubts about this code. If we have an images that just does NOT fit into the hard drive, increasing root_mb can make inevitable error more vague. What do you think?","commit_id":"e85eca6295d856a7c4d6c73c182e20442a8ca622"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"6b1b2689ea384795d4f78261cf0006218b808f4b","unresolved":false,"context_lines":[{"line_number":210,"context_line":"                                              % dev)"},{"line_number":211,"context_line":"    image_mb \u003d get_image_mb(image_path)"},{"line_number":212,"context_line":"    if image_mb \u003e root_mb:"},{"line_number":213,"context_line":"        root_mb \u003d image_mb"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"    make_partitions(dev, root_mb, swap_mb, ephemeral_mb)"},{"line_number":216,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAXH%2F%2Fsdc%3D","line":213,"in_reply_to":"AAAAXH%2F%2F6ow%3D","updated":"2014-04-18 06:39:40.000000000","message":"Hi, here\u0027s the bug addressing that. :-) https://bugs.launchpad.net/ironic/+bug/1288007","commit_id":"e85eca6295d856a7c4d6c73c182e20442a8ca622"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"fef4d7924e5a3be7e43dd70ddda8fa25656aa8ae","unresolved":false,"context_lines":[{"line_number":210,"context_line":"                                              % dev)"},{"line_number":211,"context_line":"    image_mb \u003d get_image_mb(image_path)"},{"line_number":212,"context_line":"    if image_mb \u003e root_mb:"},{"line_number":213,"context_line":"        root_mb \u003d image_mb"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"    make_partitions(dev, root_mb, swap_mb, ephemeral_mb)"},{"line_number":216,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAXH%2F%2Fqx4%3D","line":213,"in_reply_to":"AAAAXH%2F%2Fsdc%3D","updated":"2014-04-18 11:56:15.000000000","message":"Ack. Maybe consider rebasing on top of https://review.openstack.org/#/c/78001 ?","commit_id":"e85eca6295d856a7c4d6c73c182e20442a8ca622"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"eeffc7462050750f236387a12d61b609d35dba52","unresolved":false,"context_lines":[{"line_number":228,"context_line":""},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"def write_to_disk(dev, image_path):"},{"line_number":231,"context_line":"    \"\"\"Write an image directly to the disk.\"\"\""},{"line_number":232,"context_line":"    if not is_block_device(dev):"},{"line_number":233,"context_line":"        raise exception.InstanceDeployFailure(_(\"Parent device \u0027%s\u0027 not found\")"},{"line_number":234,"context_line":"                                              % dev)"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAXX%2F%2F6XY%3D","line":231,"updated":"2014-04-25 11:16:53.000000000","message":"I don\u0027t see point in having this a separate function, but if you do, you have to document all arguments with :param: tag (but better just inline into deploy).\nDidn\u0027t notice it last time, sorry.","commit_id":"def7a44f977b103c645d6271da67489e18ac3ea9"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"e9e1cf4b43a74c397d9ffc72486e41864eb4de46","unresolved":false,"context_lines":[{"line_number":228,"context_line":""},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"def write_to_disk(dev, image_path):"},{"line_number":231,"context_line":"    \"\"\"Write an image directly to the disk.\"\"\""},{"line_number":232,"context_line":"    if not is_block_device(dev):"},{"line_number":233,"context_line":"        raise exception.InstanceDeployFailure(_(\"Parent device \u0027%s\u0027 not found\")"},{"line_number":234,"context_line":"                                              % dev)"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAXX%2F%2FxKI%3D","line":231,"in_reply_to":"AAAAXX%2F%2F5nQ%3D","updated":"2014-04-28 05:09:44.000000000","message":"Ok, it was inline with work_on_disk, my bad. Still, I think it would be better off with a separate function which checks \u0027is_block_device\u0027 on dev which otherwise wouldn\u0027t be checked if it was inline with the deploy function.","commit_id":"def7a44f977b103c645d6271da67489e18ac3ea9"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"23c985eaed448cd047a3bd2b1d736dcc3000a5cd","unresolved":false,"context_lines":[{"line_number":228,"context_line":""},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"def write_to_disk(dev, image_path):"},{"line_number":231,"context_line":"    \"\"\"Write an image directly to the disk.\"\"\""},{"line_number":232,"context_line":"    if not is_block_device(dev):"},{"line_number":233,"context_line":"        raise exception.InstanceDeployFailure(_(\"Parent device \u0027%s\u0027 not found\")"},{"line_number":234,"context_line":"                                              % dev)"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAXX%2F%2F5nQ%3D","line":231,"in_reply_to":"AAAAXX%2F%2F6XY%3D","updated":"2014-04-28 04:59:55.000000000","message":"It was originally inline with deploy, but it was suggested in [1] that it be moved to a separate function since it was a different code path. I think it\u0027s okay to have a different function and i\u0027ll document all the arguments :-) \n\n[1] https://review.openstack.org/#/c/73054/4/ironic/drivers/modules/deploy_utils.py","commit_id":"def7a44f977b103c645d6271da67489e18ac3ea9"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2bc9d558d9376f3a45511be410cd14c22fbf813e","unresolved":false,"context_lines":[{"line_number":228,"context_line":""},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"def write_to_disk(dev, image_path):"},{"line_number":231,"context_line":"    \"\"\"Write an image directly to the disk.\"\"\""},{"line_number":232,"context_line":"    if not is_block_device(dev):"},{"line_number":233,"context_line":"        raise exception.InstanceDeployFailure(_(\"Parent device \u0027%s\u0027 not found\")"},{"line_number":234,"context_line":"                                              % dev)"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAXX%2F%2Fvpc%3D","line":231,"in_reply_to":"AAAAXX%2F%2FxKI%3D","updated":"2014-04-28 09:55:08.000000000","message":"I still think that these 3 lines of code (with check on is_block_device obviously) can be just included into deploy(), but I don\u0027t insist","commit_id":"def7a44f977b103c645d6271da67489e18ac3ea9"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"3fce156d36e30c74ed7816f27b722dedc0e825e7","unresolved":false,"context_lines":[{"line_number":199,"context_line":"                                              % dev)"},{"line_number":200,"context_line":"    image_mb \u003d get_image_mb(image_path)"},{"line_number":201,"context_line":"    if image_mb \u003e root_mb:"},{"line_number":202,"context_line":"        root_mb \u003d image_mb"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"    make_partitions(dev, root_mb, swap_mb, ephemeral_mb)"},{"line_number":205,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"facab960_a2dc1e76","line":202,"updated":"2014-04-28 20:54:12.000000000","message":"This shrinks the root partition to the size of the image. Thats a totally different change to what your commit message described (and its wrong). Flavor size should be honoured - cloud-init resizes the root to match the flavor.","commit_id":"7cd324f32376b6778a76d635161aaaa0239abf95"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"3bf97673907a027c67ef4d4ff42c20d439d7ad7d","unresolved":false,"context_lines":[{"line_number":199,"context_line":"                                              % dev)"},{"line_number":200,"context_line":"    image_mb \u003d get_image_mb(image_path)"},{"line_number":201,"context_line":"    if image_mb \u003e root_mb:"},{"line_number":202,"context_line":"        root_mb \u003d image_mb"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"    make_partitions(dev, root_mb, swap_mb, ephemeral_mb)"},{"line_number":205,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"bad4c104_8672cee3","line":202,"in_reply_to":"facab960_a2dc1e76","updated":"2014-04-29 14:12:57.000000000","message":"So, I\u0027m only refactoring this piece of code related to partition images out of deploy(), so that deploy() can be agnostic of disk/partition images. I don\u0027t know, should a refactoring be mentioned explicitly in the commit message? or am I missing something here?\n\nAlso, here is the bug addressing your concerns on this. https://bugs.launchpad.net/ironic/+bug/1288007","commit_id":"7cd324f32376b6778a76d635161aaaa0239abf95"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"3fce156d36e30c74ed7816f27b722dedc0e825e7","unresolved":false,"context_lines":[{"line_number":242,"context_line":""},{"line_number":243,"context_line":"def deploy(address, port, iqn, lun, image_path, deploy_disk,"},{"line_number":244,"context_line":"           pxe_config_path\u003dNone, root_mb\u003dNone, swap_mb\u003dNone,"},{"line_number":245,"context_line":"           ephemeral_mb\u003dNone, ephemeral_format\u003dNone,"},{"line_number":246,"context_line":"           preserve_ephemeral\u003dFalse):"},{"line_number":247,"context_line":"    \"\"\"All-in-one function to deploy a node."},{"line_number":248,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"facab960_c2c0427f","line":245,"updated":"2014-04-28 20:54:12.000000000","message":"rather than making all these options optional - making the api hard to use. Please make the framework code into a decorator, and then we can have two decorated functions that are single purpose.","commit_id":"7cd324f32376b6778a76d635161aaaa0239abf95"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"da6a4cb643019f0bb00210c559f23de84bb85059","unresolved":false,"context_lines":[{"line_number":242,"context_line":""},{"line_number":243,"context_line":"def deploy(address, port, iqn, lun, image_path, deploy_disk,"},{"line_number":244,"context_line":"           pxe_config_path\u003dNone, root_mb\u003dNone, swap_mb\u003dNone,"},{"line_number":245,"context_line":"           ephemeral_mb\u003dNone, ephemeral_format\u003dNone,"},{"line_number":246,"context_line":"           preserve_ephemeral\u003dFalse):"},{"line_number":247,"context_line":"    \"\"\"All-in-one function to deploy a node."},{"line_number":248,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"9ad9bd40_6be36305","line":245,"in_reply_to":"bad4c104_49045915","updated":"2014-05-06 06:31:10.000000000","message":"Sorry, Could you explain more on this, or give an example? How do decorators replace the way we use optional parameters? and What purpose will two decorated functions solve here?","commit_id":"7cd324f32376b6778a76d635161aaaa0239abf95"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"3bf97673907a027c67ef4d4ff42c20d439d7ad7d","unresolved":false,"context_lines":[{"line_number":242,"context_line":""},{"line_number":243,"context_line":"def deploy(address, port, iqn, lun, image_path, deploy_disk,"},{"line_number":244,"context_line":"           pxe_config_path\u003dNone, root_mb\u003dNone, swap_mb\u003dNone,"},{"line_number":245,"context_line":"           ephemeral_mb\u003dNone, ephemeral_format\u003dNone,"},{"line_number":246,"context_line":"           preserve_ephemeral\u003dFalse):"},{"line_number":247,"context_line":"    \"\"\"All-in-one function to deploy a node."},{"line_number":248,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"bad4c104_49045915","line":245,"in_reply_to":"facab960_c2c0427f","updated":"2014-04-29 14:12:57.000000000","message":"Agreed. This did seem very hacky!","commit_id":"7cd324f32376b6778a76d635161aaaa0239abf95"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"108599e260d94022f0ccfb75e8de83d5a3f27343","unresolved":false,"context_lines":[{"line_number":295,"context_line":"    return wrapper"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"@iscsi_deploy"},{"line_number":299,"context_line":"def deploy_partition_image(**kwargs):"},{"line_number":300,"context_line":"    \"\"\"Function to deploy partition images."},{"line_number":301,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"7adec928_b1e011ce","line":298,"updated":"2014-05-19 11:08:25.000000000","message":"I strictly object to this change - it\u0027s completely vague. Please check whether change is exactly what lifeless meant. If so, his vote overweights mine, otherwise please revert.\n\nAs an alternative I suggest just having 2 functions with different signatures, internally calling one private with general signature.","commit_id":"a89ddcb797795d94fd8cabdfeee698ced6f7ac62"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"b2508f75781f7669cb786c9f3dd4bed25b298581","unresolved":false,"context_lines":[{"line_number":295,"context_line":"    return wrapper"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"@iscsi_deploy"},{"line_number":299,"context_line":"def deploy_partition_image(**kwargs):"},{"line_number":300,"context_line":"    \"\"\"Function to deploy partition images."},{"line_number":301,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"7adec928_92ea1a72","line":298,"in_reply_to":"7adec928_b1e011ce","updated":"2014-05-21 11:13:06.000000000","message":"Done","commit_id":"a89ddcb797795d94fd8cabdfeee698ced6f7ac62"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"452770ab66d10492378e447def6eea5579c78b67","unresolved":false,"context_lines":[{"line_number":247,"context_line":"    \"\"\"Write an image directly to the disk."},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"    :param dev: Path for the device to work on."},{"line_number":250,"context_line":"    :param image_path: Path for the instance\u0027s disk image."},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"    \"\"\""},{"line_number":253,"context_line":"    if not is_block_device(dev):"}],"source_content_type":"text/x-python","patch_set":14,"id":"7adec928_018d8f31","line":250,"updated":"2014-05-22 11:46:54.000000000","message":"Please change the order of parameters as they are in a signature","commit_id":"b261a16f645438c3f42843775a482c8254601f99"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"452770ab66d10492378e447def6eea5579c78b67","unresolved":false,"context_lines":[{"line_number":295,"context_line":"    return wrapper"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"@iscsi_deploy"},{"line_number":299,"context_line":"def deploy_partition_image(**kwargs):"},{"line_number":300,"context_line":"    \"\"\"Function to deploy partition images."},{"line_number":301,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"7adec928_21b44bf1","line":298,"updated":"2014-05-22 11:46:54.000000000","message":"Please change to functions with meaningful signature:\n\n def _do_deploy(\u003call possible arguments here\u003e)\n\n def deploy_partition_image(\u003conly relevant arguments\u003e):\n   # call _do_deploy\n\n def deploy_disk_image(\u003conly relevant arguments\u003e):\n   # call _do_deploy\n\nI\u0027m sorry, but what you have now is crazy, particularly all docstrings are wrong, no support for checking required vs optional arguments etc. And definitely it\u0027s not what **kwargs syntax is for. It\u0027s also what lifeless was _against_: having undefined set of optional arguments, where some are actually mandatory.","commit_id":"b261a16f645438c3f42843775a482c8254601f99"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"04a1baf6a44b1437ca2f7e64dd4e6badb798c82a","unresolved":false,"context_lines":[{"line_number":247,"context_line":"    \"\"\"Write an image directly to the disk."},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"    :param dev: Path for the device to work on."},{"line_number":250,"context_line":"    :param image_path: Path for the instance\u0027s disk image."},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"    \"\"\""},{"line_number":253,"context_line":"    if not is_block_device(dev):"}],"source_content_type":"text/x-python","patch_set":15,"id":"7adec928_6e729bae","line":250,"updated":"2014-05-23 11:55:26.000000000","message":"Please reorder parameters here so that they match order of parameters in function signature","commit_id":"77422b3c793be936801ab3da012df3c9b9f72ba7"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"04a1baf6a44b1437ca2f7e64dd4e6badb798c82a","unresolved":false,"context_lines":[{"line_number":256,"context_line":"    dd(image_path, dev)"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"def iscsi_deploy(func):"},{"line_number":260,"context_line":"    def wrapper(**kwargs):"},{"line_number":261,"context_line":"        \"\"\"Wrapper Function to deploy via iSCSI."},{"line_number":262,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"7adec928_8e4b672a","line":259,"updated":"2014-05-23 11:55:26.000000000","message":"docstring here please","commit_id":"77422b3c793be936801ab3da012df3c9b9f72ba7"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"04a1baf6a44b1437ca2f7e64dd4e6badb798c82a","unresolved":false,"context_lines":[{"line_number":257,"context_line":""},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"def iscsi_deploy(func):"},{"line_number":260,"context_line":"    def wrapper(**kwargs):"},{"line_number":261,"context_line":"        \"\"\"Wrapper Function to deploy via iSCSI."},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"        Required Parameters"}],"source_content_type":"text/x-python","patch_set":15,"id":"7adec928_0ed11757","line":260,"updated":"2014-05-23 11:55:26.000000000","message":"as you do have required parameters, and they are the same for both wrapped functions, you can have:\n\n def wrapper(address, port, iqn, lun, *args, **kwargs):","commit_id":"77422b3c793be936801ab3da012df3c9b9f72ba7"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"04a1baf6a44b1437ca2f7e64dd4e6badb798c82a","unresolved":false,"context_lines":[{"line_number":270,"context_line":"        port \u003d kwargs.get(\u0027port\u0027)"},{"line_number":271,"context_line":"        iqn \u003d kwargs.get(\u0027iqn\u0027)"},{"line_number":272,"context_line":"        discovery(address, port)"},{"line_number":273,"context_line":"        login_iscsi(address, port, iqn)"},{"line_number":274,"context_line":"        try:"},{"line_number":275,"context_line":"            func(**kwargs)"},{"line_number":276,"context_line":"        except processutils.ProcessExecutionError as err:"}],"source_content_type":"text/x-python","patch_set":15,"id":"7adec928_aef4a3cf","line":273,"updated":"2014-05-23 11:55:26.000000000","message":"Also bring here:\n\n dev \u003d get_dev(address, port, iqn, lun)","commit_id":"77422b3c793be936801ab3da012df3c9b9f72ba7"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"04a1baf6a44b1437ca2f7e64dd4e6badb798c82a","unresolved":false,"context_lines":[{"line_number":272,"context_line":"        discovery(address, port)"},{"line_number":273,"context_line":"        login_iscsi(address, port, iqn)"},{"line_number":274,"context_line":"        try:"},{"line_number":275,"context_line":"            func(**kwargs)"},{"line_number":276,"context_line":"        except processutils.ProcessExecutionError as err:"},{"line_number":277,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":278,"context_line":"                LOG.error(_(\"Deploy to address %s failed.\") % address)"}],"source_content_type":"text/x-python","patch_set":15,"id":"7adec928_aebf43fb","line":275,"updated":"2014-05-23 11:55:26.000000000","message":"and than here:\n\n func(dev, *args, **kwargs)\n\nThis way you\u0027ll support both positional and keyword arguments, ensure that required parameters are required and won\u0027t need kwargs.get where you don\u0027t need it actually :) And you\u0027ll get rid of passing iSCSI parameters to functions that do not need it.","commit_id":"77422b3c793be936801ab3da012df3c9b9f72ba7"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"04a1baf6a44b1437ca2f7e64dd4e6badb798c82a","unresolved":false,"context_lines":[{"line_number":282,"context_line":"        except exception.InstanceDeployFailure as e:"},{"line_number":283,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":284,"context_line":"                LOG.error(_(\"Deploy to address %s failed.\") % address)"},{"line_number":285,"context_line":"                LOG.error(e)"},{"line_number":286,"context_line":"        finally:"},{"line_number":287,"context_line":"            logout_iscsi(address, port, iqn)"},{"line_number":288,"context_line":"            delete_iscsi(address, port, iqn)"}],"source_content_type":"text/x-python","patch_set":15,"id":"7adec928_2e3b339d","line":285,"updated":"2014-05-23 11:55:26.000000000","message":"I\u0027m a bit worried, that your function is called iscsi_deploy but you _also_ handle errors here. Could you come up with better name? Maybe _iscsi_deploy_and_handle_errors :)\n\nAlso not that it\u0027s private to this module, so it\u0027s name should start with underscore _","commit_id":"77422b3c793be936801ab3da012df3c9b9f72ba7"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"04a1baf6a44b1437ca2f7e64dd4e6badb798c82a","unresolved":false,"context_lines":[{"line_number":316,"context_line":"        partition table has not changed)."},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"    \"\"\""},{"line_number":319,"context_line":"    dev \u003d get_dev(address, port, iqn, lun)"},{"line_number":320,"context_line":"    root_uuid \u003d work_on_disk(dev, root_mb, swap_mb, ephemeral_mb,"},{"line_number":321,"context_line":"                             ephemeral_format, image_path,"},{"line_number":322,"context_line":"                             preserve_ephemeral)"}],"source_content_type":"text/x-python","patch_set":15,"id":"7adec928_6e2a9b2d","line":319,"updated":"2014-05-23 11:55:26.000000000","message":"should be moved to iscsi_deploy","commit_id":"77422b3c793be936801ab3da012df3c9b9f72ba7"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"04a1baf6a44b1437ca2f7e64dd4e6badb798c82a","unresolved":false,"context_lines":[{"line_number":325,"context_line":""},{"line_number":326,"context_line":"@iscsi_deploy"},{"line_number":327,"context_line":"def deploy_disk_image(address, port, iqn, lun, image_path):"},{"line_number":328,"context_line":"    \"\"\"Function to deploy a disk image."},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"    :param address: The iSCSI IP address."},{"line_number":331,"context_line":"    :param port: The iSCSI port number."}],"source_content_type":"text/x-python","patch_set":15,"id":"7adec928_0e0677ce","line":328,"updated":"2014-05-23 11:55:26.000000000","message":"\"a whole disk image\" - to be a bit more clear","commit_id":"77422b3c793be936801ab3da012df3c9b9f72ba7"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"04a1baf6a44b1437ca2f7e64dd4e6badb798c82a","unresolved":false,"context_lines":[{"line_number":334,"context_line":"    :param image_path: Path for the instance\u0027s disk image."},{"line_number":335,"context_line":""},{"line_number":336,"context_line":"    \"\"\""},{"line_number":337,"context_line":"    dev \u003d get_dev(address, port, iqn, lun)"},{"line_number":338,"context_line":"    write_to_disk(image_path, dev)"}],"source_content_type":"text/x-python","patch_set":15,"id":"7adec928_8e20c74a","line":337,"updated":"2014-05-23 11:55:26.000000000","message":"should be moved to iscsi_deploy","commit_id":"77422b3c793be936801ab3da012df3c9b9f72ba7"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"10783309b1c6d5cef314d57b3c6c80672d7b6de0","unresolved":false,"context_lines":[{"line_number":246,"context_line":"def write_to_disk(image_path, dev):"},{"line_number":247,"context_line":"    \"\"\"Write an image directly to the disk."},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"    :param image_path: Path for the instance\u0027s disk image.\\"},{"line_number":250,"context_line":"    :param dev: Path for the device to work on."},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":16,"id":"5adbc538_f467b0e8","line":249,"updated":"2014-05-26 09:14:42.000000000","message":"redundant \\","commit_id":"4fdf2f8b49ac8f090379c4d3e8ffba002b548a8f"}],"ironic/drivers/modules/pxe.py":[{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"f068ab38796cecd4152757dae1a3d6e782ff386b","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    cfg.StrOpt(\u0027pxe_config_disk_template\u0027,"},{"line_number":53,"context_line":"           default\u003dpaths.basedir_def("},{"line_number":54,"context_line":"                \u0027drivers/modules/pxe_config_disk.template\u0027),"},{"line_number":55,"context_line":"           help\u003d\u0027Template file for PXE configuration\u0027),"},{"line_number":56,"context_line":"    cfg.StrOpt(\u0027tftp_server\u0027,"},{"line_number":57,"context_line":"               default\u003d\u0027$my_ip\u0027,"},{"line_number":58,"context_line":"               help\u003d\u0027IP address of Ironic compute node\\\u0027s tftp server\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUX%2F%2Fa20%3D","line":55,"updated":"2014-02-13 10:51:55.000000000","message":"Please check in the latest ironic.conf.sample which can be auto-generated by the script:\n\ntools/config/generate_sample.sh","commit_id":"872ff56ceaf472343f9df1eab1a94dbd1cd61bdf"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"750b939734936e6f9248d893772586175696a0ba","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    cfg.StrOpt(\u0027pxe_config_disk_template\u0027,"},{"line_number":53,"context_line":"           default\u003dpaths.basedir_def("},{"line_number":54,"context_line":"                \u0027drivers/modules/pxe_config_disk.template\u0027),"},{"line_number":55,"context_line":"           help\u003d\u0027Template file for PXE configuration\u0027),"},{"line_number":56,"context_line":"    cfg.StrOpt(\u0027tftp_server\u0027,"},{"line_number":57,"context_line":"               default\u003d\u0027$my_ip\u0027,"},{"line_number":58,"context_line":"               help\u003d\u0027IP address of Ironic compute node\\\u0027s tftp server\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUX%2F%2FaD8%3D","line":55,"in_reply_to":"AAAAUX%2F%2Fa20%3D","updated":"2014-02-13 14:48:45.000000000","message":"Done","commit_id":"872ff56ceaf472343f9df1eab1a94dbd1cd61bdf"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"f068ab38796cecd4152757dae1a3d6e782ff386b","unresolved":false,"context_lines":[{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    # Delaying validation of this until we figure out the type of image being"},{"line_number":111,"context_line":"    # deployed i.e Partition or Disk."},{"line_number":112,"context_line":"    d_info[\u0027root_gb\u0027] \u003d info.get(\u0027pxe_root_gb\u0027, None)"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    # Internal use only"},{"line_number":115,"context_line":"    d_info[\u0027deploy_key\u0027] \u003d info.get(\u0027pxe_deploy_key\u0027, None)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUX%2F%2Fa1E%3D","line":112,"updated":"2014-02-13 10:51:55.000000000","message":"If the default value is \u0027None\u0027, no need to pass it, just call with below, we will get the same behavior.\n\ninfo.get(\u0027pxe_root_gb\u0027)","commit_id":"872ff56ceaf472343f9df1eab1a94dbd1cd61bdf"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"750b939734936e6f9248d893772586175696a0ba","unresolved":false,"context_lines":[{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    # Delaying validation of this until we figure out the type of image being"},{"line_number":111,"context_line":"    # deployed i.e Partition or Disk."},{"line_number":112,"context_line":"    d_info[\u0027root_gb\u0027] \u003d info.get(\u0027pxe_root_gb\u0027, None)"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    # Internal use only"},{"line_number":115,"context_line":"    d_info[\u0027deploy_key\u0027] \u003d info.get(\u0027pxe_deploy_key\u0027, None)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUX%2F%2FaCc%3D","line":112,"in_reply_to":"AAAAUX%2F%2Fa1E%3D","updated":"2014-02-13 14:48:45.000000000","message":"Done","commit_id":"872ff56ceaf472343f9df1eab1a94dbd1cd61bdf"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"f068ab38796cecd4152757dae1a3d6e782ff386b","unresolved":false,"context_lines":[{"line_number":112,"context_line":"    d_info[\u0027root_gb\u0027] \u003d info.get(\u0027pxe_root_gb\u0027, None)"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    # Internal use only"},{"line_number":115,"context_line":"    d_info[\u0027deploy_key\u0027] \u003d info.get(\u0027pxe_deploy_key\u0027, None)"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    #TODO(ghe): Should we get rid of swap partition?"},{"line_number":118,"context_line":"    d_info[\u0027swap_mb\u0027] \u003d info.get(\u0027pxe_swap_mb\u0027, 1)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUX%2F%2Fa08%3D","line":115,"updated":"2014-02-13 10:51:55.000000000","message":"ditto","commit_id":"872ff56ceaf472343f9df1eab1a94dbd1cd61bdf"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"750b939734936e6f9248d893772586175696a0ba","unresolved":false,"context_lines":[{"line_number":112,"context_line":"    d_info[\u0027root_gb\u0027] \u003d info.get(\u0027pxe_root_gb\u0027, None)"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    # Internal use only"},{"line_number":115,"context_line":"    d_info[\u0027deploy_key\u0027] \u003d info.get(\u0027pxe_deploy_key\u0027, None)"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    #TODO(ghe): Should we get rid of swap partition?"},{"line_number":118,"context_line":"    d_info[\u0027swap_mb\u0027] \u003d info.get(\u0027pxe_swap_mb\u0027, 1)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUX%2F%2FaCY%3D","line":115,"in_reply_to":"AAAAUX%2F%2Fa08%3D","updated":"2014-02-13 14:48:45.000000000","message":"Done","commit_id":"872ff56ceaf472343f9df1eab1a94dbd1cd61bdf"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"f068ab38796cecd4152757dae1a3d6e782ff386b","unresolved":false,"context_lines":[{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    #TODO(ghe): Should we get rid of swap partition?"},{"line_number":118,"context_line":"    d_info[\u0027swap_mb\u0027] \u003d info.get(\u0027pxe_swap_mb\u0027, 1)"},{"line_number":119,"context_line":"    d_info[\u0027key_data\u0027] \u003d info.get(\u0027pxe_key_data\u0027, None)"},{"line_number":120,"context_line":"    d_info[\u0027instance_name\u0027] \u003d info.get(\u0027pxe_instance_name\u0027, None)"},{"line_number":121,"context_line":"    d_info[\u0027deploy_disk\u0027] \u003d info.get(\u0027pxe_deploy_disk\u0027, False)"},{"line_number":122,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUX%2F%2Fa00%3D","line":119,"updated":"2014-02-13 10:51:55.000000000","message":"ditto","commit_id":"872ff56ceaf472343f9df1eab1a94dbd1cd61bdf"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"750b939734936e6f9248d893772586175696a0ba","unresolved":false,"context_lines":[{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    #TODO(ghe): Should we get rid of swap partition?"},{"line_number":118,"context_line":"    d_info[\u0027swap_mb\u0027] \u003d info.get(\u0027pxe_swap_mb\u0027, 1)"},{"line_number":119,"context_line":"    d_info[\u0027key_data\u0027] \u003d info.get(\u0027pxe_key_data\u0027, None)"},{"line_number":120,"context_line":"    d_info[\u0027instance_name\u0027] \u003d info.get(\u0027pxe_instance_name\u0027, None)"},{"line_number":121,"context_line":"    d_info[\u0027deploy_disk\u0027] \u003d info.get(\u0027pxe_deploy_disk\u0027, False)"},{"line_number":122,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUX%2F%2FaCQ%3D","line":119,"in_reply_to":"AAAAUX%2F%2Fa00%3D","updated":"2014-02-13 14:48:45.000000000","message":"Done","commit_id":"872ff56ceaf472343f9df1eab1a94dbd1cd61bdf"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"f068ab38796cecd4152757dae1a3d6e782ff386b","unresolved":false,"context_lines":[{"line_number":117,"context_line":"    #TODO(ghe): Should we get rid of swap partition?"},{"line_number":118,"context_line":"    d_info[\u0027swap_mb\u0027] \u003d info.get(\u0027pxe_swap_mb\u0027, 1)"},{"line_number":119,"context_line":"    d_info[\u0027key_data\u0027] \u003d info.get(\u0027pxe_key_data\u0027, None)"},{"line_number":120,"context_line":"    d_info[\u0027instance_name\u0027] \u003d info.get(\u0027pxe_instance_name\u0027, None)"},{"line_number":121,"context_line":"    d_info[\u0027deploy_disk\u0027] \u003d info.get(\u0027pxe_deploy_disk\u0027, False)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    return d_info"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUX%2F%2Fa0w%3D","line":120,"updated":"2014-02-13 10:51:55.000000000","message":"ditto","commit_id":"872ff56ceaf472343f9df1eab1a94dbd1cd61bdf"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"750b939734936e6f9248d893772586175696a0ba","unresolved":false,"context_lines":[{"line_number":117,"context_line":"    #TODO(ghe): Should we get rid of swap partition?"},{"line_number":118,"context_line":"    d_info[\u0027swap_mb\u0027] \u003d info.get(\u0027pxe_swap_mb\u0027, 1)"},{"line_number":119,"context_line":"    d_info[\u0027key_data\u0027] \u003d info.get(\u0027pxe_key_data\u0027, None)"},{"line_number":120,"context_line":"    d_info[\u0027instance_name\u0027] \u003d info.get(\u0027pxe_instance_name\u0027, None)"},{"line_number":121,"context_line":"    d_info[\u0027deploy_disk\u0027] \u003d info.get(\u0027pxe_deploy_disk\u0027, False)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    return d_info"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUX%2F%2FaCM%3D","line":120,"in_reply_to":"AAAAUX%2F%2Fa0w%3D","updated":"2014-02-13 14:48:45.000000000","message":"Done","commit_id":"872ff56ceaf472343f9df1eab1a94dbd1cd61bdf"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"2b662aeead7dbab24f1d3ae476c10f35d8d1e780","unresolved":false,"context_lines":[{"line_number":51,"context_line":"                    \u0027drivers/modules/pxe_config.template\u0027),"},{"line_number":52,"context_line":"               help\u003d\u0027Template file for PXE configuration\u0027),"},{"line_number":53,"context_line":"    cfg.StrOpt(\u0027pxe_config_disk_template\u0027,"},{"line_number":54,"context_line":"           default\u003dpaths.basedir_def("},{"line_number":55,"context_line":"                \u0027drivers/modules/pxe_config_disk.template\u0027),"},{"line_number":56,"context_line":"           help\u003d\u0027Template file for PXE configuration of Disk Images\u0027),"},{"line_number":57,"context_line":"    cfg.StrOpt(\u0027tftp_server\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUX%2F%2FGSw%3D","line":54,"updated":"2014-02-17 06:55:26.000000000","message":"please keep the same indentation with previous lines, eg the L47 or L50 and others.","commit_id":"5698e38ea1317466094226adc09b7ec983031e51"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"2847844983335ff754a565275e1c5cb9247e6f38","unresolved":false,"context_lines":[{"line_number":51,"context_line":"                    \u0027drivers/modules/pxe_config.template\u0027),"},{"line_number":52,"context_line":"               help\u003d\u0027Template file for PXE configuration\u0027),"},{"line_number":53,"context_line":"    cfg.StrOpt(\u0027pxe_config_disk_template\u0027,"},{"line_number":54,"context_line":"           default\u003dpaths.basedir_def("},{"line_number":55,"context_line":"                \u0027drivers/modules/pxe_config_disk.template\u0027),"},{"line_number":56,"context_line":"           help\u003d\u0027Template file for PXE configuration of Disk Images\u0027),"},{"line_number":57,"context_line":"    cfg.StrOpt(\u0027tftp_server\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUX%2F%2FFQA%3D","line":54,"in_reply_to":"AAAAUX%2F%2FGSw%3D","updated":"2014-02-17 12:10:22.000000000","message":"Oops, thanks! Will do.","commit_id":"5698e38ea1317466094226adc09b7ec983031e51"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"cd6a3cda00b594431e2bbae6036b85cf5f93ae9a","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    cfg.StrOpt(\u0027pxe_config_disk_template\u0027,"},{"line_number":54,"context_line":"           default\u003dpaths.basedir_def("},{"line_number":55,"context_line":"                \u0027drivers/modules/pxe_config_disk.template\u0027),"},{"line_number":56,"context_line":"           help\u003d\u0027Template file for PXE configuration of Disk Images\u0027),"},{"line_number":57,"context_line":"    cfg.StrOpt(\u0027tftp_server\u0027,"},{"line_number":58,"context_line":"               default\u003d\u0027$my_ip\u0027,"},{"line_number":59,"context_line":"               help\u003d\u0027IP address of Ironic compute node\\\u0027s tftp server\u0027),"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUX%2F%2B%2Bjc%3D","line":56,"updated":"2014-02-18 01:04:10.000000000","message":"Not needed at all.","commit_id":"5698e38ea1317466094226adc09b7ec983031e51"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"e3518dcd8c4b9762eca292672bd44c18e9e0fe8e","unresolved":false,"context_lines":[{"line_number":120,"context_line":"    d_info[\u0027key_data\u0027] \u003d info.get(\u0027pxe_key_data\u0027)"},{"line_number":121,"context_line":"    d_info[\u0027instance_name\u0027] \u003d info.get(\u0027pxe_instance_name\u0027)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    d_info[\u0027deploy_disk\u0027] \u003d info.get(\u0027pxe_deploy_disk\u0027, False)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    return d_info"},{"line_number":126,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUX%2F%2FCT8%3D","line":123,"updated":"2014-02-17 14:23:58.000000000","message":"pxe_deploy_disk looks like an internal value since it\u0027s going to be set according to the glance metadata (L422-L425), is that correct?\n\nIf so, please add a comment on top of it just like L115, or put both deploy_key and deploy_disk grouped and add one comment for both :)","commit_id":"5698e38ea1317466094226adc09b7ec983031e51"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"e4cfc6d6e08f5e723ab86dea607068b142d9efbe","unresolved":false,"context_lines":[{"line_number":120,"context_line":"    d_info[\u0027key_data\u0027] \u003d info.get(\u0027pxe_key_data\u0027)"},{"line_number":121,"context_line":"    d_info[\u0027instance_name\u0027] \u003d info.get(\u0027pxe_instance_name\u0027)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    d_info[\u0027deploy_disk\u0027] \u003d info.get(\u0027pxe_deploy_disk\u0027, False)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    return d_info"},{"line_number":126,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUX%2F%2B%2Bzc%3D","line":123,"in_reply_to":"AAAAUX%2F%2FCT8%3D","updated":"2014-02-18 08:51:49.000000000","message":"Yep, spot on. Will do.","commit_id":"5698e38ea1317466094226adc09b7ec983031e51"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"2b662aeead7dbab24f1d3ae476c10f35d8d1e780","unresolved":false,"context_lines":[{"line_number":390,"context_line":"        except Exception:"},{"line_number":391,"context_line":"            raise exception.InvalidParameterValue(_("},{"line_number":392,"context_line":"                \"Can not validate PXE bootloader. Invalid or missing\""},{"line_number":393,"context_line":"                \"parameter %s\") % param)"},{"line_number":394,"context_line":""},{"line_number":395,"context_line":""},{"line_number":396,"context_line":"def _get_tftp_image_info(node, ctx):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUX%2F%2FGRI%3D","line":393,"updated":"2014-02-17 06:55:26.000000000","message":"To make sure it is clear message with the driver_info parameter names, please add \"pxe_\" as the prefix:\n\n    \"parameter pxe_%s\") % param)","commit_id":"5698e38ea1317466094226adc09b7ec983031e51"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"2847844983335ff754a565275e1c5cb9247e6f38","unresolved":false,"context_lines":[{"line_number":390,"context_line":"        except Exception:"},{"line_number":391,"context_line":"            raise exception.InvalidParameterValue(_("},{"line_number":392,"context_line":"                \"Can not validate PXE bootloader. Invalid or missing\""},{"line_number":393,"context_line":"                \"parameter %s\") % param)"},{"line_number":394,"context_line":""},{"line_number":395,"context_line":""},{"line_number":396,"context_line":"def _get_tftp_image_info(node, ctx):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUX%2F%2FFP0%3D","line":393,"in_reply_to":"AAAAUX%2F%2FGRI%3D","updated":"2014-02-17 12:10:22.000000000","message":"Done","commit_id":"5698e38ea1317466094226adc09b7ec983031e51"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"e3518dcd8c4b9762eca292672bd44c18e9e0fe8e","unresolved":false,"context_lines":[{"line_number":422,"context_line":"    if deploy_disk \u003d\u003d \u00271\u0027:"},{"line_number":423,"context_line":"        driver_info[\u0027pxe_deploy_disk\u0027] \u003d True"},{"line_number":424,"context_line":"    else:"},{"line_number":425,"context_line":"        driver_info[\u0027pxe_deploy_disk\u0027] \u003d False"},{"line_number":426,"context_line":"        for label in (\u0027kernel\u0027, \u0027ramdisk\u0027):"},{"line_number":427,"context_line":"            image_info[label] \u003d [None, None]"},{"line_number":428,"context_line":"            image_info[label][0] \u003d str("}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUX%2F%2FCSY%3D","line":425,"updated":"2014-02-17 14:23:58.000000000","message":"As it\u0027s being set by the PXE driver, it would be nice to get it cleanup once the driver calls clean_up() as well, so the \u0027pxe_deploy_disk\u0027 parameter won\u0027t leak between one deployment and another.\n\nI left a snippet on L641 to do it.\n\nps*: You will notice that \u0027pxe_deploy_key\u0027 is not being removed at the clean_up(), it\u0027s a bug and is being addressed by https://review.openstack.org/#/c/71879","commit_id":"5698e38ea1317466094226adc09b7ec983031e51"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"e4cfc6d6e08f5e723ab86dea607068b142d9efbe","unresolved":false,"context_lines":[{"line_number":422,"context_line":"    if deploy_disk \u003d\u003d \u00271\u0027:"},{"line_number":423,"context_line":"        driver_info[\u0027pxe_deploy_disk\u0027] \u003d True"},{"line_number":424,"context_line":"    else:"},{"line_number":425,"context_line":"        driver_info[\u0027pxe_deploy_disk\u0027] \u003d False"},{"line_number":426,"context_line":"        for label in (\u0027kernel\u0027, \u0027ramdisk\u0027):"},{"line_number":427,"context_line":"            image_info[label] \u003d [None, None]"},{"line_number":428,"context_line":"            image_info[label][0] \u003d str("}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUX%2F%2B7Ec%3D","line":425,"in_reply_to":"AAAAUX%2F%2FCSY%3D","updated":"2014-02-18 08:51:49.000000000","message":"Done. Thanks for the snippet :)","commit_id":"5698e38ea1317466094226adc09b7ec983031e51"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"e3518dcd8c4b9762eca292672bd44c18e9e0fe8e","unresolved":false,"context_lines":[{"line_number":637,"context_line":"                os.path.join(CONF.pxe.tftp_root, node.uuid))"},{"line_number":638,"context_line":""},{"line_number":639,"context_line":"        _destroy_images(d_info, node.uuid)"},{"line_number":640,"context_line":"        _destroy_token_file(node)"},{"line_number":641,"context_line":""},{"line_number":642,"context_line":"    def take_over(self, task, node):"},{"line_number":643,"context_line":"        _update_neutron(task, node)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUX%2F%2FCWo%3D","line":640,"updated":"2014-02-17 14:23:58.000000000","message":"driver_info \u003d node.driver_info\nif driver_info.pop(\u0027pxe_deploy_disk, None):\n    node.driver_info \u003d driver_info\n    node.save(task.context)","commit_id":"5698e38ea1317466094226adc09b7ec983031e51"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"361c7c9af2ec9ab2a0c859987912943f08326c83","unresolved":false,"context_lines":[{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    # Delaying validation of this until we figure out the type of image being"},{"line_number":108,"context_line":"    # deployed i.e Partition or Disk."},{"line_number":109,"context_line":"    d_info[\u0027root_gb\u0027] \u003d info.get(\u0027pxe_root_gb\u0027)"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    # Internal use only"},{"line_number":112,"context_line":"    d_info[\u0027deploy_key\u0027] \u003d info.get(\u0027pxe_deploy_key\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAU3%2F%2Fb28%3D","line":109,"updated":"2014-02-26 16:58:48.000000000","message":"these will be changing to root_mb.","commit_id":"4ed74fbed60b27356e463e51eac6b8bb794d2178"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"d245a11080c8b924cbc07aefd6d08ec8ad73ca0e","unresolved":false,"context_lines":[{"line_number":112,"context_line":"    d_info[\u0027deploy_key\u0027] \u003d info.get(\u0027pxe_deploy_key\u0027)"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    # Internal use only"},{"line_number":115,"context_line":"    d_info[\u0027deploy_disk\u0027] \u003d info.get(\u0027pxe_deploy_disk\u0027, False)"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    #TODO(ghe): Should we get rid of swap partition?"},{"line_number":118,"context_line":"    d_info[\u0027swap_mb\u0027] \u003d info.get(\u0027pxe_swap_mb\u0027, 1)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAVn%2F%2FrKM%3D","line":115,"updated":"2014-03-04 19:35:55.000000000","message":"Even tho it\u0027s an internal value, people still could edit this value from outside, so I think it would worth to have a check for this. e.g:\n\ndeploy_disk \u003d info.get(\u0027pxe_deploy_disk\u0027, False)\ntry:\n    d_info[\u0027deploy_disk] \u003d strutils.bool_from_string(deploy_disk, strict\u003dTrue)\nexcept ValueError as e:\n    raise exception.InvalidParameterValue(...)","commit_id":"4ed74fbed60b27356e463e51eac6b8bb794d2178"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"370c5cd89d7b824af78cccb9f2613402ba2eaa0b","unresolved":false,"context_lines":[{"line_number":112,"context_line":"    d_info[\u0027deploy_key\u0027] \u003d info.get(\u0027pxe_deploy_key\u0027)"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    # Internal use only"},{"line_number":115,"context_line":"    d_info[\u0027deploy_disk\u0027] \u003d info.get(\u0027pxe_deploy_disk\u0027, False)"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    #TODO(ghe): Should we get rid of swap partition?"},{"line_number":118,"context_line":"    d_info[\u0027swap_mb\u0027] \u003d info.get(\u0027pxe_swap_mb\u0027, 1)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAVn%2F%2FoW0%3D","line":115,"in_reply_to":"AAAAVn%2F%2FrKM%3D","updated":"2014-03-04 23:34:14.000000000","message":"Done","commit_id":"4ed74fbed60b27356e463e51eac6b8bb794d2178"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"d245a11080c8b924cbc07aefd6d08ec8ad73ca0e","unresolved":false,"context_lines":[{"line_number":117,"context_line":"    #TODO(ghe): Should we get rid of swap partition?"},{"line_number":118,"context_line":"    d_info[\u0027swap_mb\u0027] \u003d info.get(\u0027pxe_swap_mb\u0027, 1)"},{"line_number":119,"context_line":"    d_info[\u0027key_data\u0027] \u003d info.get(\u0027pxe_key_data\u0027)"},{"line_number":120,"context_line":"    d_info[\u0027instance_name\u0027] \u003d info.get(\u0027pxe_instance_name\u0027)"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    return d_info"},{"line_number":123,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAVn%2F%2FqiU%3D","line":120,"updated":"2014-03-04 19:35:55.000000000","message":"I don\u0027t think we should to get rid of these validations here, why just don\u0027t skip it if pxe_deploy_disk \u003d\u003d False ?","commit_id":"4ed74fbed60b27356e463e51eac6b8bb794d2178"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"370c5cd89d7b824af78cccb9f2613402ba2eaa0b","unresolved":false,"context_lines":[{"line_number":117,"context_line":"    #TODO(ghe): Should we get rid of swap partition?"},{"line_number":118,"context_line":"    d_info[\u0027swap_mb\u0027] \u003d info.get(\u0027pxe_swap_mb\u0027, 1)"},{"line_number":119,"context_line":"    d_info[\u0027key_data\u0027] \u003d info.get(\u0027pxe_key_data\u0027)"},{"line_number":120,"context_line":"    d_info[\u0027instance_name\u0027] \u003d info.get(\u0027pxe_instance_name\u0027)"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    return d_info"},{"line_number":123,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAVn%2F%2Fofo%3D","line":120,"in_reply_to":"AAAAVn%2F%2Fpo4%3D","updated":"2014-03-04 23:34:14.000000000","message":"This is because the pxe_deploy_disk parameter is set after pxe.validate(). So, If suppose we deploy a disk image, this would raise an exception during pxe.validate() complaining it does not have the root/swap/ephemeral parameters since pxe_deploy_disk will still be false and will only be set in pxe.prepare(). Couple of alternatives would be to force the user to explicitly specify pxe_deploy_disk in the driver_info or query glance image properties here in pxe.validate()?","commit_id":"4ed74fbed60b27356e463e51eac6b8bb794d2178"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"47aa261c645eb328ed97bd364dcdfbe7273de1e7","unresolved":false,"context_lines":[{"line_number":117,"context_line":"    #TODO(ghe): Should we get rid of swap partition?"},{"line_number":118,"context_line":"    d_info[\u0027swap_mb\u0027] \u003d info.get(\u0027pxe_swap_mb\u0027, 1)"},{"line_number":119,"context_line":"    d_info[\u0027key_data\u0027] \u003d info.get(\u0027pxe_key_data\u0027)"},{"line_number":120,"context_line":"    d_info[\u0027instance_name\u0027] \u003d info.get(\u0027pxe_instance_name\u0027)"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    return d_info"},{"line_number":123,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAVn%2F%2Fpo4%3D","line":120,"in_reply_to":"AAAAVn%2F%2FqiU%3D","updated":"2014-03-04 21:01:12.000000000","message":"correcting... skip it if pxe_deploy_disk \u003d\u003d True","commit_id":"4ed74fbed60b27356e463e51eac6b8bb794d2178"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"361c7c9af2ec9ab2a0c859987912943f08326c83","unresolved":false,"context_lines":[{"line_number":383,"context_line":"    return (uuid, image_path)"},{"line_number":384,"context_line":""},{"line_number":385,"context_line":""},{"line_number":386,"context_line":"def _validate_root_swap(d_info):"},{"line_number":387,"context_line":"    for param in (\u0027root_gb\u0027, \u0027swap_mb\u0027):"},{"line_number":388,"context_line":"        try:"},{"line_number":389,"context_line":"            int(d_info[param])"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAU3%2F%2Fb2g%3D","line":386,"updated":"2014-02-26 16:58:48.000000000","message":"please add doc string here","commit_id":"4ed74fbed60b27356e463e51eac6b8bb794d2178"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"361c7c9af2ec9ab2a0c859987912943f08326c83","unresolved":false,"context_lines":[{"line_number":384,"context_line":""},{"line_number":385,"context_line":""},{"line_number":386,"context_line":"def _validate_root_swap(d_info):"},{"line_number":387,"context_line":"    for param in (\u0027root_gb\u0027, \u0027swap_mb\u0027):"},{"line_number":388,"context_line":"        try:"},{"line_number":389,"context_line":"            int(d_info[param])"},{"line_number":390,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAU3%2F%2Fb2U%3D","line":387,"updated":"2014-02-26 16:58:48.000000000","message":"root_gb will be changing to root_mb.","commit_id":"4ed74fbed60b27356e463e51eac6b8bb794d2178"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"d245a11080c8b924cbc07aefd6d08ec8ad73ca0e","unresolved":false,"context_lines":[{"line_number":425,"context_line":"                                iproperties[label + \u0027_id\u0027]).split(\u0027/\u0027)[-1]"},{"line_number":426,"context_line":"            image_info[label][1] \u003d os.path.join(CONF.pxe.tftp_root,"},{"line_number":427,"context_line":"                                                node.uuid, label)"},{"line_number":428,"context_line":"            _validate_root_swap(d_info)"},{"line_number":429,"context_line":"    else:"},{"line_number":430,"context_line":"        driver_info[\u0027pxe_deploy_disk\u0027] \u003d True"},{"line_number":431,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAVn%2F%2Fqqc%3D","line":428,"updated":"2014-03-04 19:35:55.000000000","message":"This validation feels out of the place here, as I would prefer to have these validation at _parse_driver_info() (see L120)","commit_id":"4ed74fbed60b27356e463e51eac6b8bb794d2178"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"370c5cd89d7b824af78cccb9f2613402ba2eaa0b","unresolved":false,"context_lines":[{"line_number":425,"context_line":"                                iproperties[label + \u0027_id\u0027]).split(\u0027/\u0027)[-1]"},{"line_number":426,"context_line":"            image_info[label][1] \u003d os.path.join(CONF.pxe.tftp_root,"},{"line_number":427,"context_line":"                                                node.uuid, label)"},{"line_number":428,"context_line":"            _validate_root_swap(d_info)"},{"line_number":429,"context_line":"    else:"},{"line_number":430,"context_line":"        driver_info[\u0027pxe_deploy_disk\u0027] \u003d True"},{"line_number":431,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAVn%2F%2FoeU%3D","line":428,"in_reply_to":"AAAAVn%2F%2Fqqc%3D","updated":"2014-03-04 23:34:14.000000000","message":"Agreed. It does feel odd to validate this here. Raised some concerns in L120 however.","commit_id":"4ed74fbed60b27356e463e51eac6b8bb794d2178"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"361c7c9af2ec9ab2a0c859987912943f08326c83","unresolved":false,"context_lines":[{"line_number":695,"context_line":"        if not d_info[\u0027deploy_disk\u0027]:"},{"line_number":696,"context_line":"            params.update({\u0027pxe_config_path\u0027: _get_pxe_config_file_path("},{"line_number":697,"context_line":"                                                              node.uuid),"},{"line_number":698,"context_line":"                           \u0027root_mb\u0027: 1024 * int(d_info[\u0027root_gb\u0027]),"},{"line_number":699,"context_line":"                           \u0027swap_mb\u0027: int(d_info[\u0027swap_mb\u0027])})"},{"line_number":700,"context_line":""},{"line_number":701,"context_line":"        missing \u003d [key for key in params.keys() if params[key] is None]"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAU3%2F%2Fb0c%3D","line":698,"updated":"2014-02-26 16:58:48.000000000","message":"root_gb will be changing to root_mb.","commit_id":"4ed74fbed60b27356e463e51eac6b8bb794d2178"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"eeffc7462050750f236387a12d61b609d35dba52","unresolved":false,"context_lines":[{"line_number":114,"context_line":"    d_info[\u0027deploy_disk\u0027] \u003d strutils.bool_from_string(deploy_disk,"},{"line_number":115,"context_line":"                                                      strict\u003dTrue)"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    if not d_info[\u0027deploy_disk\u0027]:"},{"line_number":118,"context_line":"        d_info[\u0027root_gb\u0027] \u003d info.get(\u0027pxe_root_gb\u0027)"},{"line_number":119,"context_line":"        # TODO(ghe): Should we get rid of swap partition?"},{"line_number":120,"context_line":"        d_info[\u0027swap_mb\u0027] \u003d info.get(\u0027pxe_swap_mb\u0027, 0)"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAXX%2F%2F6XE%3D","line":117,"updated":"2014-04-25 11:16:53.000000000","message":"Please reverse this `if` like \n\n if d_info[\u0027deploy_disk\u0027]:\n   return d_info","commit_id":"def7a44f977b103c645d6271da67489e18ac3ea9"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"23c985eaed448cd047a3bd2b1d736dcc3000a5cd","unresolved":false,"context_lines":[{"line_number":114,"context_line":"    d_info[\u0027deploy_disk\u0027] \u003d strutils.bool_from_string(deploy_disk,"},{"line_number":115,"context_line":"                                                      strict\u003dTrue)"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    if not d_info[\u0027deploy_disk\u0027]:"},{"line_number":118,"context_line":"        d_info[\u0027root_gb\u0027] \u003d info.get(\u0027pxe_root_gb\u0027)"},{"line_number":119,"context_line":"        # TODO(ghe): Should we get rid of swap partition?"},{"line_number":120,"context_line":"        d_info[\u0027swap_mb\u0027] \u003d info.get(\u0027pxe_swap_mb\u0027, 0)"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAXX%2F%2F5BE%3D","line":117,"in_reply_to":"AAAAXX%2F%2F6XE%3D","updated":"2014-04-28 04:59:55.000000000","message":"Done","commit_id":"def7a44f977b103c645d6271da67489e18ac3ea9"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"eeffc7462050750f236387a12d61b609d35dba52","unresolved":false,"context_lines":[{"line_number":201,"context_line":"                                \u0027ROOT\u0027: \u0027{{ ROOT }}\u0027})"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    if deploy_disk:"},{"line_number":204,"context_line":"        template \u003d template.split(\u0027label boot\u0027)[0]"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"    return template"},{"line_number":207,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAXX%2F%2F6WA%3D","line":204,"updated":"2014-04-25 11:16:53.000000000","message":"I am bit worried by this line. Will it work for every PXE template possible? If not, I suggest creating a separate template (new file and new option) for full-disk images.","commit_id":"def7a44f977b103c645d6271da67489e18ac3ea9"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2bc9d558d9376f3a45511be410cd14c22fbf813e","unresolved":false,"context_lines":[{"line_number":201,"context_line":"                                \u0027ROOT\u0027: \u0027{{ ROOT }}\u0027})"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    if deploy_disk:"},{"line_number":204,"context_line":"        template \u003d template.split(\u0027label boot\u0027)[0]"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"    return template"},{"line_number":207,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAXX%2F%2FvpA%3D","line":204,"in_reply_to":"AAAAXX%2F%2F5Sc%3D","updated":"2014-04-28 09:55:08.000000000","message":"Ok, leave as it is, but write a comment here please explaining what you told me.","commit_id":"def7a44f977b103c645d6271da67489e18ac3ea9"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"23c985eaed448cd047a3bd2b1d736dcc3000a5cd","unresolved":false,"context_lines":[{"line_number":201,"context_line":"                                \u0027ROOT\u0027: \u0027{{ ROOT }}\u0027})"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    if deploy_disk:"},{"line_number":204,"context_line":"        template \u003d template.split(\u0027label boot\u0027)[0]"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"    return template"},{"line_number":207,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAXX%2F%2F5Sc%3D","line":204,"in_reply_to":"AAAAXX%2F%2F6WA%3D","updated":"2014-04-28 04:59:55.000000000","message":"So the initial implementation[1] was to have a separate template for full-disk images. After some discussions, it was decided that it was better off to simply localboot the disk image rather than chainloading it using another pxe template.\n\nAbout the line, it should work so long as it remains this way in deploy_utils.py. Perhaps this should be made configurable?\n\n[1] https://review.openstack.org/#/c/73054/4/ironic/drivers/modules/pxe_config_disk.template","commit_id":"def7a44f977b103c645d6271da67489e18ac3ea9"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"eeffc7462050750f236387a12d61b609d35dba52","unresolved":false,"context_lines":[{"line_number":422,"context_line":"        image_info[label][1] \u003d os.path.join(CONF.pxe.tftp_root,"},{"line_number":423,"context_line":"                                            node.uuid, label)"},{"line_number":424,"context_line":""},{"line_number":425,"context_line":"    if not d_info[\u0027deploy_disk\u0027]:"},{"line_number":426,"context_line":"        driver_info \u003d node.driver_info"},{"line_number":427,"context_line":"        labels \u003d (\u0027kernel\u0027, \u0027ramdisk\u0027)"},{"line_number":428,"context_line":"        if not (driver_info.get(\u0027pxe_kernel\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAXX%2F%2F6Vw%3D","line":425,"updated":"2014-04-25 11:16:53.000000000","message":"Again, reverse `if` please","commit_id":"def7a44f977b103c645d6271da67489e18ac3ea9"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"eeffc7462050750f236387a12d61b609d35dba52","unresolved":false,"context_lines":[{"line_number":507,"context_line":"            ]"},{"line_number":508,"context_line":""},{"line_number":509,"context_line":""},{"line_number":510,"context_line":"def _disable_pxe_boot_options():"},{"line_number":511,"context_line":"    \"\"\"Options to tell neutron not to PXE Boot an instance.\"\"\""},{"line_number":512,"context_line":"    return [{\u0027opt_name\u0027: \u0027bootfile-name\u0027,"},{"line_number":513,"context_line":"             \u0027opt_value\u0027: None},"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAXX%2F%2F6U0%3D","line":510,"updated":"2014-04-25 11:16:53.000000000","message":"This is not a function actually, pleae either convert to a constant or just inline","commit_id":"def7a44f977b103c645d6271da67489e18ac3ea9"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"23c985eaed448cd047a3bd2b1d736dcc3000a5cd","unresolved":false,"context_lines":[{"line_number":507,"context_line":"            ]"},{"line_number":508,"context_line":""},{"line_number":509,"context_line":""},{"line_number":510,"context_line":"def _disable_pxe_boot_options():"},{"line_number":511,"context_line":"    \"\"\"Options to tell neutron not to PXE Boot an instance.\"\"\""},{"line_number":512,"context_line":"    return [{\u0027opt_name\u0027: \u0027bootfile-name\u0027,"},{"line_number":513,"context_line":"             \u0027opt_value\u0027: None},"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAXX%2F%2F5jk%3D","line":510,"in_reply_to":"AAAAXX%2F%2F6U0%3D","updated":"2014-04-28 04:59:55.000000000","message":"Done.","commit_id":"def7a44f977b103c645d6271da67489e18ac3ea9"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"eeffc7462050750f236387a12d61b609d35dba52","unresolved":false,"context_lines":[{"line_number":680,"context_line":"                os.path.join(CONF.pxe.tftp_root, node.uuid))"},{"line_number":681,"context_line":""},{"line_number":682,"context_line":"        driver_info \u003d node.driver_info"},{"line_number":683,"context_line":"        if driver_info.pop(\u0027pxe_deploy_disk\u0027, None):"},{"line_number":684,"context_line":"            node.driver_info \u003d driver_info"},{"line_number":685,"context_line":"            node.save(task.context)"},{"line_number":686,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAXX%2F%2F6VI%3D","line":683,"updated":"2014-04-25 11:16:53.000000000","message":"1. None is redundant here; 2. What if pxe_deploy_disk \u003d\u003d False, should it stay in driver_info?","commit_id":"def7a44f977b103c645d6271da67489e18ac3ea9"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"23c985eaed448cd047a3bd2b1d736dcc3000a5cd","unresolved":false,"context_lines":[{"line_number":680,"context_line":"                os.path.join(CONF.pxe.tftp_root, node.uuid))"},{"line_number":681,"context_line":""},{"line_number":682,"context_line":"        driver_info \u003d node.driver_info"},{"line_number":683,"context_line":"        if driver_info.pop(\u0027pxe_deploy_disk\u0027, None):"},{"line_number":684,"context_line":"            node.driver_info \u003d driver_info"},{"line_number":685,"context_line":"            node.save(task.context)"},{"line_number":686,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAXX%2F%2F5mw%3D","line":683,"in_reply_to":"AAAAXX%2F%2F6VI%3D","updated":"2014-04-28 04:59:55.000000000","message":"Oh! This should be removed. I missed it somehow during the merge from the previous patch where i decided to keep pxe_deploy_disk an internal variable and clean it up here. Now, it\u0027s not the case. Thanks.","commit_id":"def7a44f977b103c645d6271da67489e18ac3ea9"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"3fce156d36e30c74ed7816f27b722dedc0e825e7","unresolved":false,"context_lines":[{"line_number":132,"context_line":"    for param in (\u0027root_gb\u0027, \u0027swap_mb\u0027, \u0027ephemeral_gb\u0027):"},{"line_number":133,"context_line":"        try:"},{"line_number":134,"context_line":"            int(d_info[param])"},{"line_number":135,"context_line":"        except (ValueError, TypeError):"},{"line_number":136,"context_line":"            reason \u003d _(\"\u0027%s\u0027 is not an integer value.\") % d_info[param]"},{"line_number":137,"context_line":"            raise exception.InvalidParameterValue(err_msg_invalid %"},{"line_number":138,"context_line":"                                            {\u0027param\u0027: param, \u0027reason\u0027: reason})"}],"source_content_type":"text/x-python","patch_set":11,"id":"facab960_625856fb","line":135,"updated":"2014-04-28 20:54:12.000000000","message":"This patch should have no reason to change this exception - please split this into a targeted fix, for whatever the issue is.","commit_id":"7cd324f32376b6778a76d635161aaaa0239abf95"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"3bf97673907a027c67ef4d4ff42c20d439d7ad7d","unresolved":false,"context_lines":[{"line_number":132,"context_line":"    for param in (\u0027root_gb\u0027, \u0027swap_mb\u0027, \u0027ephemeral_gb\u0027):"},{"line_number":133,"context_line":"        try:"},{"line_number":134,"context_line":"            int(d_info[param])"},{"line_number":135,"context_line":"        except (ValueError, TypeError):"},{"line_number":136,"context_line":"            reason \u003d _(\"\u0027%s\u0027 is not an integer value.\") % d_info[param]"},{"line_number":137,"context_line":"            raise exception.InvalidParameterValue(err_msg_invalid %"},{"line_number":138,"context_line":"                                            {\u0027param\u0027: param, \u0027reason\u0027: reason})"}],"source_content_type":"text/x-python","patch_set":11,"id":"bad4c104_69091d2c","line":135,"in_reply_to":"facab960_625856fb","updated":"2014-04-29 14:12:57.000000000","message":"Done","commit_id":"7cd324f32376b6778a76d635161aaaa0239abf95"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"0ae69788baffbbe53182c27b4edba4f52ce4ff10","unresolved":false,"context_lines":[{"line_number":153,"context_line":"    except ValueError as e:"},{"line_number":154,"context_line":"        raise exception.InvalidParameterValue(err_msg_invalid %"},{"line_number":155,"context_line":"                                  {\u0027param\u0027: \u0027preserve_ephemeral\u0027, \u0027reason\u0027: e})"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    return d_info"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"3a1371a2_8408e62e","line":156,"updated":"2014-04-28 19:23:49.000000000","message":"Oops! Will remove!","commit_id":"7cd324f32376b6778a76d635161aaaa0239abf95"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"04a1baf6a44b1437ca2f7e64dd4e6badb798c82a","unresolved":false,"context_lines":[{"line_number":205,"context_line":"    template \u003d template.render({\u0027pxe_options\u0027: pxe_options,"},{"line_number":206,"context_line":"                                \u0027ROOT\u0027: \u0027{{ ROOT }}\u0027})"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"    # \u0027label boot\u0027 is hard-coded. This will break if the value"},{"line_number":209,"context_line":"    # is changed in deploy_utils/pxe_config.template"},{"line_number":210,"context_line":"    if deploy_disk:"},{"line_number":211,"context_line":"        template \u003d template.split(\u0027label boot\u0027)[0]"}],"source_content_type":"text/x-python","patch_set":15,"id":"7adec928_eeecebf5","line":208,"updated":"2014-05-23 11:55:26.000000000","message":"Comments should be like:\n\n #NOTE(nickname)\n\nwhere nickname is your nickname, obviously :)","commit_id":"77422b3c793be936801ab3da012df3c9b9f72ba7"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"10783309b1c6d5cef314d57b3c6c80672d7b6de0","unresolved":false,"context_lines":[{"line_number":126,"context_line":"                                                          strict\u003dTrue)"},{"line_number":127,"context_line":"    except ValueError as e:"},{"line_number":128,"context_line":"        raise exception.InvalidParameterValue(err_msg_invalid %"},{"line_number":129,"context_line":"                                    {\u0027param\u0027: \u0027deploy_disk\u0027, \u0027reason\u0027: e})"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    if d_info[\u0027deploy_disk\u0027]:"},{"line_number":132,"context_line":"        return d_info"}],"source_content_type":"text/x-python","patch_set":16,"id":"5adbc538_94874c61","line":129,"updated":"2014-05-26 09:14:42.000000000","message":"Please fix indentation, e.g.: \n\n raise exception.InvalidParameterValue(\n     err_msg_invalid % {\u0027param\u0027: \u0027deploy_disk\u0027, \u0027reason\u0027: e})\n\nI know it\u0027s a copy-paste, but anyway","commit_id":"4fdf2f8b49ac8f090379c4d3e8ffba002b548a8f"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"10783309b1c6d5cef314d57b3c6c80672d7b6de0","unresolved":false,"context_lines":[{"line_number":154,"context_line":"    except ValueError as e:"},{"line_number":155,"context_line":"        raise exception.InvalidParameterValue(err_msg_invalid %"},{"line_number":156,"context_line":"                                  {\u0027param\u0027: \u0027preserve_ephemeral\u0027, \u0027reason\u0027: e})"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"    return d_info"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"5adbc538_74e9e019","line":157,"updated":"2014-05-26 09:14:42.000000000","message":"Please don\u0027t insert newline, this may create unnecessary merge conflicts","commit_id":"4fdf2f8b49ac8f090379c4d3e8ffba002b548a8f"}],"ironic/drivers/modules/pxe_config_disk.template":[{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"cd6a3cda00b594431e2bbae6036b85cf5f93ae9a","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    COM32 chain.c32"},{"line_number":10,"context_line":"    APPEND hd0"},{"line_number":11,"context_line":"    TIMEOUT 80"},{"line_number":12,"context_line":"    TOTALTIMEOUT 600"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"AAAAUX%2F%2B%2BjI%3D","line":12,"updated":"2014-02-18 01:04:10.000000000","message":"This template isn\u0027t needed - all it does is local boot, which we can much more easily achieve by just disabling PXE boot in neutron for the nodes ports after deploying.","commit_id":"5698e38ea1317466094226adc09b7ec983031e51"}],"ironic/nova/virt/ironic/patcher.py":[{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"3fce156d36e30c74ed7816f27b722dedc0e825e7","unresolved":false,"context_lines":[{"line_number":99,"context_line":"            patch.append({\u0027path\u0027: \u0027/driver_info/pxe_swap_mb\u0027, \u0027op\u0027: \u0027add\u0027,"},{"line_number":100,"context_line":"                          \u0027value\u0027: str(flavor[\u0027swap\u0027])})"},{"line_number":101,"context_line":"            patch.append({\u0027path\u0027: \u0027/driver_info/pxe_deploy_disk\u0027, \u0027op\u0027: \u0027add\u0027,"},{"line_number":102,"context_line":"                          \u0027value\u0027: \u0027False\u0027})"},{"line_number":103,"context_line":"            if instance.get(\u0027ephemeral_gb\u0027):"},{"line_number":104,"context_line":"                patch.append({\u0027path\u0027: \u0027/driver_info/pxe_ephemeral_gb\u0027,"},{"line_number":105,"context_line":"                              \u0027op\u0027: \u0027add\u0027,"}],"source_content_type":"text/x-python","patch_set":11,"id":"facab960_a24a5e25","line":102,"updated":"2014-04-28 20:54:12.000000000","message":"This is not documented in your commit message; the message talks about a heuristic only, but this is an explicit value.","commit_id":"7cd324f32376b6778a76d635161aaaa0239abf95"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"3bf97673907a027c67ef4d4ff42c20d439d7ad7d","unresolved":false,"context_lines":[{"line_number":99,"context_line":"            patch.append({\u0027path\u0027: \u0027/driver_info/pxe_swap_mb\u0027, \u0027op\u0027: \u0027add\u0027,"},{"line_number":100,"context_line":"                          \u0027value\u0027: str(flavor[\u0027swap\u0027])})"},{"line_number":101,"context_line":"            patch.append({\u0027path\u0027: \u0027/driver_info/pxe_deploy_disk\u0027, \u0027op\u0027: \u0027add\u0027,"},{"line_number":102,"context_line":"                          \u0027value\u0027: \u0027False\u0027})"},{"line_number":103,"context_line":"            if instance.get(\u0027ephemeral_gb\u0027):"},{"line_number":104,"context_line":"                patch.append({\u0027path\u0027: \u0027/driver_info/pxe_ephemeral_gb\u0027,"},{"line_number":105,"context_line":"                              \u0027op\u0027: \u0027add\u0027,"}],"source_content_type":"text/x-python","patch_set":11,"id":"bad4c104_49529914","line":102,"in_reply_to":"facab960_a24a5e25","updated":"2014-04-29 14:12:57.000000000","message":"Agreed, my commit message has become stale and I should\u0027ve updated it and documented this. Sorry about that.","commit_id":"7cd324f32376b6778a76d635161aaaa0239abf95"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"10783309b1c6d5cef314d57b3c6c80672d7b6de0","unresolved":false,"context_lines":[{"line_number":93,"context_line":"                      \u0027value\u0027: image_meta[\u0027id\u0027]})"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        iproperties \u003d image_meta[\u0027properties\u0027]"},{"line_number":96,"context_line":"        if iproperties.get(\u0027kernel_id\u0027) and iproperties.get(\u0027ramdisk_id\u0027):"},{"line_number":97,"context_line":"            patch.append({\u0027path\u0027: \u0027/driver_info/pxe_root_gb\u0027, \u0027op\u0027: \u0027add\u0027,"},{"line_number":98,"context_line":"                          \u0027value\u0027: str(instance[\u0027root_gb\u0027])})"},{"line_number":99,"context_line":"            patch.append({\u0027path\u0027: \u0027/driver_info/pxe_swap_mb\u0027, \u0027op\u0027: \u0027add\u0027,"}],"source_content_type":"text/x-python","patch_set":16,"id":"5adbc538_14f6dcd7","line":96,"updated":"2014-05-26 09:14:42.000000000","message":"Isn\u0027t it better to check for deploy_disk attribute here? Both should work, but your intention will be more clear, if you write:\n\n if iproperties.get(\u0027deploy_disk\u0027):\n   # ...\n  else:\n   # ...\n\nEspecially since on line #133 you check in this way","commit_id":"4fdf2f8b49ac8f090379c4d3e8ffba002b548a8f"}],"ironic/tests/drivers/pxe_config_disk.template":[{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"67efc2ad76610cbd652ab8e885839634a2aa827e","unresolved":false,"context_lines":[{"line_number":6,"context_line":"ipappend 3"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"label boot"},{"line_number":9,"context_line":"    COM32 chain.c32"},{"line_number":10,"context_line":"    APPEND hd0"},{"line_number":11,"context_line":"    TIMEOUT 80"},{"line_number":12,"context_line":"    TOTALTIMEOUT 600"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"AAAAUX%2F%2FBNc%3D","line":9,"updated":"2014-02-17 16:13:48.000000000","message":"please comment about the need to have chain.c32 copied to tftp directory in the commit message for the review.","commit_id":"5698e38ea1317466094226adc09b7ec983031e51"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"e4cfc6d6e08f5e723ab86dea607068b142d9efbe","unresolved":false,"context_lines":[{"line_number":6,"context_line":"ipappend 3"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"label boot"},{"line_number":9,"context_line":"    COM32 chain.c32"},{"line_number":10,"context_line":"    APPEND hd0"},{"line_number":11,"context_line":"    TIMEOUT 80"},{"line_number":12,"context_line":"    TOTALTIMEOUT 600"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"AAAAUX%2F%2B7Ds%3D","line":9,"in_reply_to":"AAAAUX%2F%2FBNc%3D","updated":"2014-02-18 08:51:49.000000000","message":"Done","commit_id":"5698e38ea1317466094226adc09b7ec983031e51"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"cd6a3cda00b594431e2bbae6036b85cf5f93ae9a","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    COM32 chain.c32"},{"line_number":10,"context_line":"    APPEND hd0"},{"line_number":11,"context_line":"    TIMEOUT 80"},{"line_number":12,"context_line":"    TOTALTIMEOUT 600"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"AAAAUX%2F%2B%2Bio%3D","line":12,"updated":"2014-02-18 01:04:10.000000000","message":"This file isn\u0027t needed either.","commit_id":"5698e38ea1317466094226adc09b7ec983031e51"}],"ironic/tests/drivers/test_deploy_utils.py":[{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"cd6a3cda00b594431e2bbae6036b85cf5f93ae9a","unresolved":false,"context_lines":[{"line_number":80,"context_line":"    APPEND hd0"},{"line_number":81,"context_line":"    TIMEOUT 80"},{"line_number":82,"context_line":"    TOTALTIMEOUT 600"},{"line_number":83,"context_line":"\"\"\""},{"line_number":84,"context_line":""},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"class PhysicalWorkTestCase(tests_base.TestCase):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUX%2F%2B%2BiY%3D","line":83,"updated":"2014-02-18 01:04:10.000000000","message":"This isn\u0027t needed - should test that the Neutron port reconfiguration happened.","commit_id":"5698e38ea1317466094226adc09b7ec983031e51"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"2b662aeead7dbab24f1d3ae476c10f35d8d1e780","unresolved":false,"context_lines":[{"line_number":154,"context_line":"        port \u003d 3306"},{"line_number":155,"context_line":"        iqn \u003d \u0027iqn.xyz\u0027"},{"line_number":156,"context_line":"        lun \u003d 1"},{"line_number":157,"context_line":"        image_path \u003d \u0027/tmp/xyz/image\u0027"},{"line_number":158,"context_line":"        pxe_config_path \u003d \u0027/tmp/abc/pxeconfig\u0027"},{"line_number":159,"context_line":"        deploy_disk \u003d True"},{"line_number":160,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUX%2F%2FGKY%3D","line":157,"updated":"2014-02-17 06:55:26.000000000","message":"It is better we do not hard-code the path to avoid conflicting when these test scripts are run by parallel.\n\nimport fixtures\n\n    image_path \u003d fixtures.TempDir()","commit_id":"5698e38ea1317466094226adc09b7ec983031e51"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"2847844983335ff754a565275e1c5cb9247e6f38","unresolved":false,"context_lines":[{"line_number":154,"context_line":"        port \u003d 3306"},{"line_number":155,"context_line":"        iqn \u003d \u0027iqn.xyz\u0027"},{"line_number":156,"context_line":"        lun \u003d 1"},{"line_number":157,"context_line":"        image_path \u003d \u0027/tmp/xyz/image\u0027"},{"line_number":158,"context_line":"        pxe_config_path \u003d \u0027/tmp/abc/pxeconfig\u0027"},{"line_number":159,"context_line":"        deploy_disk \u003d True"},{"line_number":160,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUX%2F%2FFKI%3D","line":157,"in_reply_to":"AAAAUX%2F%2FGKY%3D","updated":"2014-02-17 12:10:22.000000000","message":"Good catch. Will do.","commit_id":"5698e38ea1317466094226adc09b7ec983031e51"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"2b662aeead7dbab24f1d3ae476c10f35d8d1e780","unresolved":false,"context_lines":[{"line_number":162,"context_line":""},{"line_number":163,"context_line":"        name_list \u003d [\u0027get_dev\u0027, \u0027discovery\u0027, \u0027login_iscsi\u0027, \u0027logout_iscsi\u0027,"},{"line_number":164,"context_line":"                     \u0027delete_iscsi\u0027, \u0027is_block_device\u0027, \u0027dd\u0027,"},{"line_number":165,"context_line":"                     \u0027switch_pxe_config\u0027, \u0027notify\u0027]"},{"line_number":166,"context_line":"        patch_list \u003d [mock.patch.object(utils, name) for name in name_list]"},{"line_number":167,"context_line":"        mock_list \u003d [patcher.start() for patcher in patch_list]"},{"line_number":168,"context_line":"        for patcher in patch_list:"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUX%2F%2FGK0%3D","line":165,"updated":"2014-02-17 06:55:26.000000000","message":"It is better that we alpha-sort the list of attribute names being checked.","commit_id":"5698e38ea1317466094226adc09b7ec983031e51"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"2847844983335ff754a565275e1c5cb9247e6f38","unresolved":false,"context_lines":[{"line_number":162,"context_line":""},{"line_number":163,"context_line":"        name_list \u003d [\u0027get_dev\u0027, \u0027discovery\u0027, \u0027login_iscsi\u0027, \u0027logout_iscsi\u0027,"},{"line_number":164,"context_line":"                     \u0027delete_iscsi\u0027, \u0027is_block_device\u0027, \u0027dd\u0027,"},{"line_number":165,"context_line":"                     \u0027switch_pxe_config\u0027, \u0027notify\u0027]"},{"line_number":166,"context_line":"        patch_list \u003d [mock.patch.object(utils, name) for name in name_list]"},{"line_number":167,"context_line":"        mock_list \u003d [patcher.start() for patcher in patch_list]"},{"line_number":168,"context_line":"        for patcher in patch_list:"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUX%2F%2FDm0%3D","line":165,"in_reply_to":"AAAAUX%2F%2FGK0%3D","updated":"2014-02-17 12:10:22.000000000","message":"I\u0027m not entirely sure why we need alpha sort here. Wouldn\u0027t modifying the names in the order they\u0027re called be sufficient as that would make it convenient if it is ever modified? Or is it about something else?","commit_id":"5698e38ea1317466094226adc09b7ec983031e51"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"2b662aeead7dbab24f1d3ae476c10f35d8d1e780","unresolved":false,"context_lines":[{"line_number":270,"context_line":"        utils.switch_pxe_config(self.fname)"},{"line_number":271,"context_line":"        with open(self.fname, \u0027r\u0027) as f:"},{"line_number":272,"context_line":"            pxeconf \u003d f.read()"},{"line_number":273,"context_line":"        self.assertEqual(pxeconf, _PXECONF_BOOT_DISKIMAGE)"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"class OtherFunctionTestCase(tests_base.TestCase):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUX%2F%2FGOk%3D","line":273,"updated":"2014-02-17 06:55:26.000000000","message":"assertEqual should put the expected parameter first. This will make it easier to read the error when it fails. ditto for all other assertEqual, too.","commit_id":"5698e38ea1317466094226adc09b7ec983031e51"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"2847844983335ff754a565275e1c5cb9247e6f38","unresolved":false,"context_lines":[{"line_number":270,"context_line":"        utils.switch_pxe_config(self.fname)"},{"line_number":271,"context_line":"        with open(self.fname, \u0027r\u0027) as f:"},{"line_number":272,"context_line":"            pxeconf \u003d f.read()"},{"line_number":273,"context_line":"        self.assertEqual(pxeconf, _PXECONF_BOOT_DISKIMAGE)"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"class OtherFunctionTestCase(tests_base.TestCase):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUX%2F%2FFSc%3D","line":273,"in_reply_to":"AAAAUX%2F%2FGOk%3D","updated":"2014-02-17 12:10:22.000000000","message":"Done","commit_id":"5698e38ea1317466094226adc09b7ec983031e51"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"eeffc7462050750f236387a12d61b609d35dba52","unresolved":false,"context_lines":[{"line_number":385,"context_line":"        self.mock_mp \u003d mock.patch.object(utils, \u0027make_partitions\u0027).start()"},{"line_number":386,"context_line":"        self.mock_gim \u003d mock.patch.object(utils, \u0027get_image_mb\u0027).start()"},{"line_number":387,"context_line":"        self.mock_gim.return_value \u003d 128"},{"line_number":388,"context_line":"        self.addCleanup(self.mock_gim.stop)"},{"line_number":389,"context_line":"        self.addCleanup(self.mock_ibd.stop)"},{"line_number":390,"context_line":"        self.addCleanup(self.mock_mp.stop)"},{"line_number":391,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAXX%2F%2F6Sc%3D","line":388,"updated":"2014-04-25 11:16:53.000000000","message":"Please don\u0027t add new mocks like this. Currently we use either decorators on methods or class itself or context managers. This particular should be converted to a class level decorator:\n\n @mock.patch.object(utils, \u0027get_image_mb\u0027, lambda *_: 128)\n class SwitchPxeConfigTestCase(tests_base.TestCase):","commit_id":"def7a44f977b103c645d6271da67489e18ac3ea9"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"23c985eaed448cd047a3bd2b1d736dcc3000a5cd","unresolved":false,"context_lines":[{"line_number":385,"context_line":"        self.mock_mp \u003d mock.patch.object(utils, \u0027make_partitions\u0027).start()"},{"line_number":386,"context_line":"        self.mock_gim \u003d mock.patch.object(utils, \u0027get_image_mb\u0027).start()"},{"line_number":387,"context_line":"        self.mock_gim.return_value \u003d 128"},{"line_number":388,"context_line":"        self.addCleanup(self.mock_gim.stop)"},{"line_number":389,"context_line":"        self.addCleanup(self.mock_ibd.stop)"},{"line_number":390,"context_line":"        self.addCleanup(self.mock_mp.stop)"},{"line_number":391,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAXX%2F%2F4Dg%3D","line":388,"in_reply_to":"AAAAXX%2F%2F6Sc%3D","updated":"2014-04-28 04:59:55.000000000","message":"Done","commit_id":"def7a44f977b103c645d6271da67489e18ac3ea9"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"eeffc7462050750f236387a12d61b609d35dba52","unresolved":false,"context_lines":[{"line_number":485,"context_line":"        self.image_path \u003d \u0027/tmp/xyz/image\u0027"},{"line_number":486,"context_line":"        self.dev \u003d \u0027/dev/fake\u0027"},{"line_number":487,"context_line":"        self.mock_ibd \u003d mock.patch.object(utils, \u0027is_block_device\u0027).start()"},{"line_number":488,"context_line":"        self.addCleanup(self.mock_ibd.stop)"},{"line_number":489,"context_line":""},{"line_number":490,"context_line":"    def test_no_parent_device(self):"},{"line_number":491,"context_line":"        self.mock_ibd.return_value \u003d False"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAXX%2F%2F6SA%3D","line":488,"updated":"2014-04-25 11:16:53.000000000","message":"ditto about mock. Also I\u0027m against having write_to_disk as it\u0027s just a wrapper around dd","commit_id":"def7a44f977b103c645d6271da67489e18ac3ea9"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"23c985eaed448cd047a3bd2b1d736dcc3000a5cd","unresolved":false,"context_lines":[{"line_number":485,"context_line":"        self.image_path \u003d \u0027/tmp/xyz/image\u0027"},{"line_number":486,"context_line":"        self.dev \u003d \u0027/dev/fake\u0027"},{"line_number":487,"context_line":"        self.mock_ibd \u003d mock.patch.object(utils, \u0027is_block_device\u0027).start()"},{"line_number":488,"context_line":"        self.addCleanup(self.mock_ibd.stop)"},{"line_number":489,"context_line":""},{"line_number":490,"context_line":"    def test_no_parent_device(self):"},{"line_number":491,"context_line":"        self.mock_ibd.return_value \u003d False"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAXX%2F%2F4Dc%3D","line":488,"in_reply_to":"AAAAXX%2F%2F6SA%3D","updated":"2014-04-28 04:59:55.000000000","message":"Done","commit_id":"def7a44f977b103c645d6271da67489e18ac3ea9"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"10783309b1c6d5cef314d57b3c6c80672d7b6de0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"5adbc538_74880023","updated":"2014-05-26 09:14:42.000000000","message":"Now that you have a separate function for all iSCSI-related stuff, please test it separately, and then mock only it, instead of mocking the whole bulk of functions (get_dev, discovery, ...)","commit_id":"4fdf2f8b49ac8f090379c4d3e8ffba002b548a8f"}],"ironic/tests/drivers/test_pxe.py":[{"author":{"_account_id":8412,"name":"Mike Durnosvistov","email":"glacierr.dev@gmail.com","username":"mdurnosvistov"},"change_message_id":"ce9946fcce087fa7cb813af5e0cd62b252b3578c","unresolved":false,"context_lines":[{"line_number":247,"context_line":"                                               method\u003d\u0027get\u0027)"},{"line_number":248,"context_line":"            self.assertEqual(expected_info, image_info)"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"    def test__get_tftp_image_info_disk_image(self):"},{"line_number":251,"context_line":"        properties \u003d {\u0027properties\u0027: {}}"},{"line_number":252,"context_line":"        expected_info \u003d {\u0027deploy_ramdisk\u0027:"},{"line_number":253,"context_line":"                         [\u0027deploy_ramdisk_uuid\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAVn%2F%2FsKs%3D","line":250,"updated":"2014-03-04 17:05:45.000000000","message":"Please use decorators, like:\n    \n    @mock.patch.object(base_image_service.BaseImageService, \u0027_show\u0027)\n    def test__get_tftp_image_info_disk_image(self, show_mock):\n         ...","commit_id":"4ed74fbed60b27356e463e51eac6b8bb794d2178"},{"author":{"_account_id":8412,"name":"Mike Durnosvistov","email":"glacierr.dev@gmail.com","username":"mdurnosvistov"},"change_message_id":"ce9946fcce087fa7cb813af5e0cd62b252b3578c","unresolved":false,"context_lines":[{"line_number":583,"context_line":"        open(token_path, \u0027w\u0027).close()"},{"line_number":584,"context_line":"        return token_path"},{"line_number":585,"context_line":""},{"line_number":586,"context_line":"    def test_vendorpassthru__get_deploy_info(self):"},{"line_number":587,"context_line":"        kwargs \u003d {\u0027address\u0027: \u0027127.0.0.1\u0027, \u0027port\u0027: \u00273306\u0027,"},{"line_number":588,"context_line":"                  \u0027iqn\u0027: \u0027iqn.xyz\u0027, \u0027key\u0027: \u0027fake-56789\u0027}"},{"line_number":589,"context_line":"        image_path \u003d \u0027/tmp/xyz/image\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAVn%2F%2FsIw%3D","line":586,"updated":"2014-03-04 17:05:45.000000000","message":"ditto\n\n    @mock.patch.object(pxe, \u0027_get_image_file_path\u0027)\n    @mock.patch.object(pxe, \u0027_get_pxe_config_file_path\u0027)\n    def test_vendorpassthru__get_deploy_info(self, get_pxe_config_path_mock,\n                                             get_image_path_mock):\n        ...\n        with task_manager.acquire(self.context, [self.node[\u0027uuid\u0027]],\n                                  shared\u003dTrue) as task:\n            get_image_path_mock.return_value \u003d image_path\n            get_pxe_config_path_mock.return_value \u003d pxe_config_path\n            params \u003d task.driver.vendor._get_deploy_info(self.node, **kwargs)\n        ...","commit_id":"4ed74fbed60b27356e463e51eac6b8bb794d2178"},{"author":{"_account_id":8412,"name":"Mike Durnosvistov","email":"glacierr.dev@gmail.com","username":"mdurnosvistov"},"change_message_id":"ce9946fcce087fa7cb813af5e0cd62b252b3578c","unresolved":false,"context_lines":[{"line_number":612,"context_line":""},{"line_number":613,"context_line":"        self.assertEqual(expected_params, params)"},{"line_number":614,"context_line":""},{"line_number":615,"context_line":"    def test_vendorpassthru__get_deploy_info_disk_image(self):"},{"line_number":616,"context_line":"        kwargs \u003d {\u0027address\u0027: \u0027127.0.0.1\u0027, \u0027port\u0027: \u00273306\u0027,"},{"line_number":617,"context_line":"                  \u0027iqn\u0027: \u0027iqn.xyz\u0027, \u0027key\u0027: \u0027fake-56789\u0027}"},{"line_number":618,"context_line":"        image_path \u003d \u0027/tmp/xyz/image\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAVn%2F%2FsFc%3D","line":615,"updated":"2014-03-04 17:05:45.000000000","message":"ditto:\n\n    @mock.patch.object(pxe, \u0027_get_image_file_path\u0027)\n    def test_vendorpassthru__get_deploy_info_disk_image(self, \n                                                        get_image_path_mock):","commit_id":"4ed74fbed60b27356e463e51eac6b8bb794d2178"},{"author":{"_account_id":8412,"name":"Mike Durnosvistov","email":"glacierr.dev@gmail.com","username":"mdurnosvistov"},"change_message_id":"700c956d8f2b5c879c1ecd580fa3d214950e8cae","unresolved":false,"context_lines":[{"line_number":308,"context_line":"                                               method\u003d\u0027get\u0027)"},{"line_number":309,"context_line":"            self.assertEqual(expected_info, image_info)"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"    def test__get_tftp_image_info_disk_image(self):"},{"line_number":312,"context_line":"        properties \u003d {\u0027properties\u0027: {}}"},{"line_number":313,"context_line":"        expected_info \u003d {\u0027deploy_ramdisk\u0027:"},{"line_number":314,"context_line":"                         [\u0027deploy_ramdisk_uuid\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAW3%2F%2FWjQ%3D","line":311,"updated":"2014-04-15 08:09:51.000000000","message":"Hi! :) I think anyway you should use mock-decorator :)","commit_id":"05c29d405cbebcd481761207dc88a8d44c44e2dc"},{"author":{"_account_id":8412,"name":"Mike Durnosvistov","email":"glacierr.dev@gmail.com","username":"mdurnosvistov"},"change_message_id":"700c956d8f2b5c879c1ecd580fa3d214950e8cae","unresolved":false,"context_lines":[{"line_number":644,"context_line":"        open(token_path, \u0027w\u0027).close()"},{"line_number":645,"context_line":"        return token_path"},{"line_number":646,"context_line":""},{"line_number":647,"context_line":"    def test_vendorpassthru__get_deploy_info(self):"},{"line_number":648,"context_line":"        kwargs \u003d {\u0027address\u0027: \u0027127.0.0.1\u0027, \u0027port\u0027: \u00273306\u0027,"},{"line_number":649,"context_line":"                  \u0027iqn\u0027: \u0027iqn.xyz\u0027, \u0027key\u0027: \u0027fake-56789\u0027}"},{"line_number":650,"context_line":"        image_path \u003d \u0027/tmp/xyz/image\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAW3%2F%2FWjM%3D","line":647,"updated":"2014-04-15 08:09:51.000000000","message":"ditto","commit_id":"05c29d405cbebcd481761207dc88a8d44c44e2dc"},{"author":{"_account_id":8412,"name":"Mike Durnosvistov","email":"glacierr.dev@gmail.com","username":"mdurnosvistov"},"change_message_id":"700c956d8f2b5c879c1ecd580fa3d214950e8cae","unresolved":false,"context_lines":[{"line_number":676,"context_line":""},{"line_number":677,"context_line":"        self.assertEqual(expected_params, params)"},{"line_number":678,"context_line":""},{"line_number":679,"context_line":"    def test_vendorpassthru__get_deploy_info_disk_image(self):"},{"line_number":680,"context_line":"        kwargs \u003d {\u0027address\u0027: \u0027127.0.0.1\u0027, \u0027port\u0027: \u00273306\u0027,"},{"line_number":681,"context_line":"                  \u0027iqn\u0027: \u0027iqn.xyz\u0027, \u0027key\u0027: \u0027fake-56789\u0027}"},{"line_number":682,"context_line":"        image_path \u003d \u0027/tmp/xyz/image\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAW3%2F%2FWjE%3D","line":679,"updated":"2014-04-15 08:09:51.000000000","message":"ditto","commit_id":"05c29d405cbebcd481761207dc88a8d44c44e2dc"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"f9d5e32f427a909d8f30dd02de88c5a40294790a","unresolved":false,"context_lines":[{"line_number":319,"context_line":"                                       self.node.uuid,"},{"line_number":320,"context_line":"                                       \u0027deploy_kernel\u0027)]}"},{"line_number":321,"context_line":"        with mock.patch.object(base_image_service.BaseImageService, \u0027_show\u0027) \\"},{"line_number":322,"context_line":"                as show_mock:"},{"line_number":323,"context_line":"            show_mock.return_value \u003d properties"},{"line_number":324,"context_line":"            image_info \u003d pxe._get_tftp_image_info(self.node, self.context)"},{"line_number":325,"context_line":"            show_mock.assert_called_once_with(\u0027glance://image_uuid\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAXH%2F%2F6fk%3D","line":322,"updated":"2014-04-16 14:43:02.000000000","message":"Please convert this to a decorator:\n\n @mock.patch.object(base_image_service.BaseImageService, \u0027_show\u0027)\n def test__get_tftp_image_info_disk_image(self, show_mock):","commit_id":"e85eca6295d856a7c4d6c73c182e20442a8ca622"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"6b1b2689ea384795d4f78261cf0006218b808f4b","unresolved":false,"context_lines":[{"line_number":319,"context_line":"                                       self.node.uuid,"},{"line_number":320,"context_line":"                                       \u0027deploy_kernel\u0027)]}"},{"line_number":321,"context_line":"        with mock.patch.object(base_image_service.BaseImageService, \u0027_show\u0027) \\"},{"line_number":322,"context_line":"                as show_mock:"},{"line_number":323,"context_line":"            show_mock.return_value \u003d properties"},{"line_number":324,"context_line":"            image_info \u003d pxe._get_tftp_image_info(self.node, self.context)"},{"line_number":325,"context_line":"            show_mock.assert_called_once_with(\u0027glance://image_uuid\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAXH%2F%2FsdU%3D","line":322,"in_reply_to":"AAAAXH%2F%2F6fk%3D","updated":"2014-04-18 06:39:40.000000000","message":"Done","commit_id":"e85eca6295d856a7c4d6c73c182e20442a8ca622"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"f9d5e32f427a909d8f30dd02de88c5a40294790a","unresolved":false,"context_lines":[{"line_number":638,"context_line":"            with mock.patch.object(pxe,"},{"line_number":639,"context_line":"            \u0027_get_image_file_path\u0027) as get_image_path_mock:"},{"line_number":640,"context_line":"                with mock.patch.object(pxe,"},{"line_number":641,"context_line":"                \u0027_get_pxe_config_file_path\u0027) as get_pxe_config_path_mock:"},{"line_number":642,"context_line":"                    get_image_path_mock.return_value \u003d image_path"},{"line_number":643,"context_line":"                    get_pxe_config_path_mock.return_value \u003d pxe_config_path"},{"line_number":644,"context_line":"                    params \u003d task.driver.vendor._get_deploy_info(self.node,"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAXH%2F%2F6fQ%3D","line":641,"updated":"2014-04-16 14:43:02.000000000","message":"These two should also be decarators","commit_id":"e85eca6295d856a7c4d6c73c182e20442a8ca622"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"6b1b2689ea384795d4f78261cf0006218b808f4b","unresolved":false,"context_lines":[{"line_number":638,"context_line":"            with mock.patch.object(pxe,"},{"line_number":639,"context_line":"            \u0027_get_image_file_path\u0027) as get_image_path_mock:"},{"line_number":640,"context_line":"                with mock.patch.object(pxe,"},{"line_number":641,"context_line":"                \u0027_get_pxe_config_file_path\u0027) as get_pxe_config_path_mock:"},{"line_number":642,"context_line":"                    get_image_path_mock.return_value \u003d image_path"},{"line_number":643,"context_line":"                    get_pxe_config_path_mock.return_value \u003d pxe_config_path"},{"line_number":644,"context_line":"                    params \u003d task.driver.vendor._get_deploy_info(self.node,"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAXH%2F%2FsdQ%3D","line":641,"in_reply_to":"AAAAXH%2F%2F6fQ%3D","updated":"2014-04-18 06:39:40.000000000","message":"Done","commit_id":"e85eca6295d856a7c4d6c73c182e20442a8ca622"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"f9d5e32f427a909d8f30dd02de88c5a40294790a","unresolved":false,"context_lines":[{"line_number":668,"context_line":"        with task_manager.acquire(self.context, [self.node[\u0027uuid\u0027]],"},{"line_number":669,"context_line":"                                  shared\u003dTrue) as task:"},{"line_number":670,"context_line":"            with mock.patch.object(pxe,"},{"line_number":671,"context_line":"            \u0027_get_image_file_path\u0027) as get_image_path_mock:"},{"line_number":672,"context_line":"                get_image_path_mock.return_value \u003d image_path"},{"line_number":673,"context_line":"                params \u003d task.driver.vendor._get_deploy_info(self.node,"},{"line_number":674,"context_line":"                                                             **kwargs)"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAXH%2F%2F6ew%3D","line":671,"updated":"2014-04-16 14:43:02.000000000","message":"The same","commit_id":"e85eca6295d856a7c4d6c73c182e20442a8ca622"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"10783309b1c6d5cef314d57b3c6c80672d7b6de0","unresolved":false,"context_lines":[{"line_number":97,"context_line":"                pxe._parse_driver_info,"},{"line_number":98,"context_line":"                node)"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def test__parse_driver_info_missing_root_gb(self):"},{"line_number":101,"context_line":"        # make sure error is raised when info is missing"},{"line_number":102,"context_line":"        info \u003d dict(INFO_DICT)"},{"line_number":103,"context_line":"        del info[\u0027pxe_root_gb\u0027]"}],"source_content_type":"text/x-python","patch_set":16,"id":"5adbc538_3476783f","side":"PARENT","line":100,"updated":"2014-05-26 09:14:42.000000000","message":"Seems like you deleted this test? If so, please get it back","commit_id":"d5afee9b3a72059b208e9396d2ec39cf2b8268ff"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"10783309b1c6d5cef314d57b3c6c80672d7b6de0","unresolved":false,"context_lines":[{"line_number":459,"context_line":"    def test_validate_fail(self):"},{"line_number":460,"context_line":"        info \u003d dict(INFO_DICT)"},{"line_number":461,"context_line":"        del info[\u0027pxe_image_source\u0027]"},{"line_number":462,"context_line":"        self.node[\u0027driver_info\u0027] \u003d json.dumps(info)"},{"line_number":463,"context_line":"        with task_manager.acquire(self.context, [self.node.uuid],"},{"line_number":464,"context_line":"                                  shared\u003dTrue) as task:"},{"line_number":465,"context_line":"            self.assertRaises(exception.InvalidParameterValue,"}],"source_content_type":"text/x-python","patch_set":16,"id":"5adbc538_54aa2471","side":"PARENT","line":462,"updated":"2014-05-26 09:14:42.000000000","message":"I don\u0027t get this change. Is it intended?","commit_id":"d5afee9b3a72059b208e9396d2ec39cf2b8268ff"}]}
