)]}'
{"ironic/drivers/modules/redfish/management.py":[{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"8359161d5c043596341b0a6702e49c892762fb2b","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    :param persistent: Boolean value. True if the boot device will"},{"line_number":79,"context_line":"                       persist to all future boots, False if not."},{"line_number":80,"context_line":"                       Default: False."},{"line_number":81,"context_line":"    :param enabled: Redfish boot device persistence value."},{"line_number":82,"context_line":"    :raises: SushyError on an error from the Sushy library"},{"line_number":83,"context_line":"    \"\"\""},{"line_number":84,"context_line":"    desired_enabled \u003d BOOT_DEVICE_PERSISTENT_MAP_REV[persistent]"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff570b3c_42bee6ad","line":81,"range":{"start_line":81,"start_character":0,"end_line":81,"end_character":58},"updated":"2020-06-04 22:02:03.000000000","message":"Is this parameter still makes sense?","commit_id":"3f3a13d248e51b7ae405b3b8d8d358d68a8f8ee9"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"23dbbec4865baa9321b7dcbebce47a3c8ffd644d","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    :param persistent: Boolean value. True if the boot device will"},{"line_number":79,"context_line":"                       persist to all future boots, False if not."},{"line_number":80,"context_line":"                       Default: False."},{"line_number":81,"context_line":"    :param enabled: Redfish boot device persistence value."},{"line_number":82,"context_line":"    :raises: SushyError on an error from the Sushy library"},{"line_number":83,"context_line":"    \"\"\""},{"line_number":84,"context_line":"    desired_enabled \u003d BOOT_DEVICE_PERSISTENT_MAP_REV[persistent]"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_4af08a91","line":81,"range":{"start_line":81,"start_character":0,"end_line":81,"end_character":58},"in_reply_to":"bf51134e_8d61273d","updated":"2020-06-16 03:04:01.000000000","message":"Done\n\nI do not know how I misunderstood this the first time it was identified. Thank you for motivating me to take a second, fresh look at it.\n\nPerhaps I was focusing on the need for a fourth formal parameter, instead of its changed name, subtly different semantics, and outdated docstring content. Thanks, again!","commit_id":"3f3a13d248e51b7ae405b3b8d8d358d68a8f8ee9"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"06d4f0d1da9991107f5b8755103da1c671f73b23","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    :param persistent: Boolean value. True if the boot device will"},{"line_number":79,"context_line":"                       persist to all future boots, False if not."},{"line_number":80,"context_line":"                       Default: False."},{"line_number":81,"context_line":"    :param enabled: Redfish boot device persistence value."},{"line_number":82,"context_line":"    :raises: SushyError on an error from the Sushy library"},{"line_number":83,"context_line":"    \"\"\""},{"line_number":84,"context_line":"    desired_enabled \u003d BOOT_DEVICE_PERSISTENT_MAP_REV[persistent]"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff570b3c_c23b16e7","line":81,"range":{"start_line":81,"start_character":0,"end_line":81,"end_character":58},"in_reply_to":"ff570b3c_42bee6ad","updated":"2020-06-04 22:31:58.000000000","message":"TL;DR, yes, I believe it does.\n\nThis private function is called by two methods defined in class RedfishManagement below, restore_boot_device and set_boot_device. The former unconditionally calls it with persistent equal to False, which is the default value. The latter can call it with either value, depending on how the external caller invokes that public API.","commit_id":"3f3a13d248e51b7ae405b3b8d8d358d68a8f8ee9"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"24bf7b57f958d2f8826ad47845a737a24807ccf0","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    :param persistent: Boolean value. True if the boot device will"},{"line_number":79,"context_line":"                       persist to all future boots, False if not."},{"line_number":80,"context_line":"                       Default: False."},{"line_number":81,"context_line":"    :param enabled: Redfish boot device persistence value."},{"line_number":82,"context_line":"    :raises: SushyError on an error from the Sushy library"},{"line_number":83,"context_line":"    \"\"\""},{"line_number":84,"context_line":"    desired_enabled \u003d BOOT_DEVICE_PERSISTENT_MAP_REV[persistent]"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_8d61273d","line":81,"range":{"start_line":81,"start_character":0,"end_line":81,"end_character":58},"in_reply_to":"ff570b3c_c23b16e7","updated":"2020-06-15 15:49:55.000000000","message":"the problem is that there\u0027s not parameter \u0027enabled\u0027 in the function definition anymore, so this should not be here.","commit_id":"3f3a13d248e51b7ae405b3b8d8d358d68a8f8ee9"}]}