)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f0afd47f7d91b9dd602b264dd6cb80a317abd38b","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Cleanup mock patch without `with` part 1"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Need to get rid of the `with` using mock.patch and mock.patch.object"},{"line_number":10,"context_line":"in favor decorators, where possible in the tests."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch only affects drivers."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"bad4c104_3cf57c83","line":9,"updated":"2014-04-29 18:38:46.000000000","message":"By the way, I don\u0027t understand why we \"need\" to do this since it works. Perhaps you could elaborate and explain why we want to do this. Is it a need, or a good idea because it makes the code easier to read, or what?","commit_id":"e40db3d8e6f1d02a1ebaca5b6c84066152af6809"},{"author":{"_account_id":8412,"name":"Mike Durnosvistov","email":"glacierr.dev@gmail.com","username":"mdurnosvistov"},"change_message_id":"cc8547d65f26c31250fc07668a76128ae122710c","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Cleanup mock patch without `with` part 1"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Need to get rid of the `with` using mock.patch and mock.patch.object"},{"line_number":10,"context_line":"in favor decorators, where possible in the tests."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch only affects drivers."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"bad4c104_c8268a68","line":9,"in_reply_to":"bad4c104_3cf57c83","updated":"2014-04-29 20:45:00.000000000","message":"Old commit message :) I didn\u0027t understand how to write them :)\nWill do!","commit_id":"e40db3d8e6f1d02a1ebaca5b6c84066152af6809"}],"ironic/tests/drivers/test_ipminative.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c8991b56375093ca0ddf0c5cbcd22abbbd7c845d","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        self.node \u003d self.dbapi.create_node(n)"},{"line_number":51,"context_line":"        self.info \u003d ipminative._parse_driver_info(self.node)"},{"line_number":52,"context_line":"        ipmi_patch \u003d mock.patch(\u0027pyghmi.ipmi.command.Command\u0027)"},{"line_number":53,"context_line":"        self.ipmi_mock \u003d ipmi_patch.start()"},{"line_number":54,"context_line":"        self.addCleanup(ipmi_patch.stop)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def test__parse_driver_info(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAW3%2F%2FzvI%3D","line":53,"updated":"2014-04-10 09:32:00.000000000","message":"Could you change this to class decorator as well?","commit_id":"215f416c4debc6d4973390b79c88e5f2db563558"},{"author":{"_account_id":8412,"name":"Mike Durnosvistov","email":"glacierr.dev@gmail.com","username":"mdurnosvistov"},"change_message_id":"e8c67c1e536e7abe27ae834c6b16694b61b14f4b","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        self.node \u003d self.dbapi.create_node(n)"},{"line_number":51,"context_line":"        self.info \u003d ipminative._parse_driver_info(self.node)"},{"line_number":52,"context_line":"        ipmi_patch \u003d mock.patch(\u0027pyghmi.ipmi.command.Command\u0027)"},{"line_number":53,"context_line":"        self.ipmi_mock \u003d ipmi_patch.start()"},{"line_number":54,"context_line":"        self.addCleanup(ipmi_patch.stop)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def test__parse_driver_info(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAW3%2F%2Fq4U%3D","line":53,"in_reply_to":"AAAAW3%2F%2FzvI%3D","updated":"2014-04-11 10:42:04.000000000","message":"Approach with decorator is not always justified. Currently will need to add `*args` in `test__parse_driver_info` after `self` because mock class-decorator require use this mock in all the test-cases. And if add a new test, also need to add `*args`.","commit_id":"215f416c4debc6d4973390b79c88e5f2db563558"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"038f4e0e228c381ec0fa4479b4104997cf5bd2d1","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        self.node \u003d self.dbapi.create_node(n)"},{"line_number":53,"context_line":"        self.info \u003d ipminative._parse_driver_info(self.node)"},{"line_number":54,"context_line":"        ipmi_patch \u003d mock.patch(\u0027pyghmi.ipmi.command.Command\u0027)"},{"line_number":55,"context_line":"        self.ipmi_mock \u003d ipmi_patch.start()"},{"line_number":56,"context_line":"        self.addCleanup(ipmi_patch.stop)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def test__parse_driver_info(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAW3%2F%2FUGs%3D","line":55,"updated":"2014-04-15 12:25:23.000000000","message":"Please convert this to a class-level decorator.","commit_id":"bf07bc6536346d006d5899f8871ef9d04882261d"},{"author":{"_account_id":8412,"name":"Mike Durnosvistov","email":"glacierr.dev@gmail.com","username":"mdurnosvistov"},"change_message_id":"2ba39731c5571d7f694c6e157bd23ccb8a3fbb5a","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        self.node \u003d self.dbapi.create_node(n)"},{"line_number":53,"context_line":"        self.info \u003d ipminative._parse_driver_info(self.node)"},{"line_number":54,"context_line":"        ipmi_patch \u003d mock.patch(\u0027pyghmi.ipmi.command.Command\u0027)"},{"line_number":55,"context_line":"        self.ipmi_mock \u003d ipmi_patch.start()"},{"line_number":56,"context_line":"        self.addCleanup(ipmi_patch.stop)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def test__parse_driver_info(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAXH%2F%2Fyow%3D","line":55,"in_reply_to":"AAAAW3%2F%2FUGs%3D","updated":"2014-04-17 15:46:01.000000000","message":"Done","commit_id":"bf07bc6536346d006d5899f8871ef9d04882261d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"85490169a607d0f8c333a93a25ded27f68ae339f","unresolved":false,"context_lines":[{"line_number":154,"context_line":"                         {\u0027powerstate\u0027: \u0027on\u0027},"},{"line_number":155,"context_line":"                         {\u0027powerstate\u0027: \u0027off\u0027}]"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"        get_power_mock.side_effect \u003d lambda: return_values.pop()"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"        pstate \u003d self.driver.power.get_power_state(None, self.node)"},{"line_number":160,"context_line":"        self.assertEqual(states.POWER_OFF, pstate)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAXX%2F%2F4fo%3D","line":157,"updated":"2014-04-25 15:29:47.000000000","message":"For the future: you can pass iterable directly to side_effect, it will yield one value at time","commit_id":"1e6905e511179b5ac1be5e823b5a3b5262dfc3fa"}],"ironic/tests/drivers/test_ipmitool.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c8991b56375093ca0ddf0c5cbcd22abbbd7c845d","unresolved":false,"context_lines":[{"line_number":271,"context_line":"        expected \u003d [mock.call(self.info, \"power status\"),"},{"line_number":272,"context_line":"                    mock.call(self.info, \"power status\"),"},{"line_number":273,"context_line":"                    mock.call(self.info, \"power status\")]"},{"line_number":274,"context_line":"        with mock.patch.object(ipmi, \u0027_exec_ipmitool\u0027, side_effect\u003dreturns,"},{"line_number":275,"context_line":"                               autospec\u003dTrue) as mock_exec:"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"            pstate \u003d self.driver.power.get_power_state(None, self.node)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAW3%2F%2Fzt0%3D","line":274,"updated":"2014-04-10 09:32:00.000000000","message":"This is the same pattern you changed below, please convert it as well.","commit_id":"215f416c4debc6d4973390b79c88e5f2db563558"},{"author":{"_account_id":8003,"name":"Aleksandr Gordeev","email":"agordeev@mirantis.com","username":"agordeev"},"change_message_id":"17e1f2e527fe8a677e44c396ba2e7e22e62e1e32","unresolved":false,"context_lines":[{"line_number":271,"context_line":"        expected \u003d [mock.call(self.info, \"power status\"),"},{"line_number":272,"context_line":"                    mock.call(self.info, \"power status\"),"},{"line_number":273,"context_line":"                    mock.call(self.info, \"power status\")]"},{"line_number":274,"context_line":"        with mock.patch.object(ipmi, \u0027_exec_ipmitool\u0027, side_effect\u003dreturns,"},{"line_number":275,"context_line":"                               autospec\u003dTrue) as mock_exec:"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"            pstate \u003d self.driver.power.get_power_state(None, self.node)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAW3%2F%2Fcug%3D","line":274,"in_reply_to":"AAAAW3%2F%2FqX8%3D","updated":"2014-04-14 14:47:46.000000000","message":"Mikhail, your code will work if `returns` will be Iterator instance. Just apply iter(), it should look like\n\nreturns \u003d iter([[\"Chassis Power is off\\n\", None],\n                [\"Chassis Power is on\\n\", None],\n                [\"\\n\", None]])\n\nAlso i\u0027d checked with pdb that isinstance(returns, collections.Iterator) always returns False. But inside of context manager (`with` block)  isinstance(mock_exec.side_effects, collections.Iterator) returns True.\n\nIf side_effect is not Iterator, the \u0027TypeError: list object is not an iterator\u0027 will be raised deper inside of mock library.","commit_id":"215f416c4debc6d4973390b79c88e5f2db563558"},{"author":{"_account_id":8412,"name":"Mike Durnosvistov","email":"glacierr.dev@gmail.com","username":"mdurnosvistov"},"change_message_id":"e8c67c1e536e7abe27ae834c6b16694b61b14f4b","unresolved":false,"context_lines":[{"line_number":271,"context_line":"        expected \u003d [mock.call(self.info, \"power status\"),"},{"line_number":272,"context_line":"                    mock.call(self.info, \"power status\"),"},{"line_number":273,"context_line":"                    mock.call(self.info, \"power status\")]"},{"line_number":274,"context_line":"        with mock.patch.object(ipmi, \u0027_exec_ipmitool\u0027, side_effect\u003dreturns,"},{"line_number":275,"context_line":"                               autospec\u003dTrue) as mock_exec:"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"            pstate \u003d self.driver.power.get_power_state(None, self.node)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAW3%2F%2FqX8%3D","line":274,"in_reply_to":"AAAAW3%2F%2Fzt0%3D","updated":"2014-04-11 10:42:04.000000000","message":"If use this test-case like:\n\n   @mock.patch.object(ipmi, \u0027_exec_ipmitool\u0027, autospec\u003dTrue)\n    def test_get_power_state(self, mock_exec):\n        returns \u003d [[\"Chassis Power is off\\n\", None],\n                   [\"Chassis Power is on\\n\", None],\n                   [\"\\n\", None]]\n        mock_exec.side_effect \u003d returns\n\nI get such Traceback[1]\n\n[1] http://paste.openstack.org/show/75546/","commit_id":"215f416c4debc6d4973390b79c88e5f2db563558"}],"ironic/tests/drivers/test_pxe.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c8991b56375093ca0ddf0c5cbcd22abbbd7c845d","unresolved":false,"context_lines":[{"line_number":491,"context_line":"        fileutils.ensure_tree(CONF.pxe.tftp_master_path)"},{"line_number":492,"context_line":"        fd, tmp_master_image \u003d tempfile.mkstemp(dir\u003dCONF.pxe.tftp_master_path)"},{"line_number":493,"context_line":""},{"line_number":494,"context_line":"        with mock.patch.object(tempfile, \u0027mkstemp\u0027) as mkstemp_mock:"},{"line_number":495,"context_line":"            fetch_to_raw_mock.return_value \u003d None"},{"line_number":496,"context_line":"            mkstemp_mock.return_value \u003d (fd, tmp_master_image)"},{"line_number":497,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAW3%2F%2Fzs0%3D","line":494,"updated":"2014-04-10 09:32:00.000000000","message":"Why not convert this to a decorator as well?","commit_id":"215f416c4debc6d4973390b79c88e5f2db563558"},{"author":{"_account_id":8412,"name":"Mike Durnosvistov","email":"glacierr.dev@gmail.com","username":"mdurnosvistov"},"change_message_id":"e8c67c1e536e7abe27ae834c6b16694b61b14f4b","unresolved":false,"context_lines":[{"line_number":491,"context_line":"        fileutils.ensure_tree(CONF.pxe.tftp_master_path)"},{"line_number":492,"context_line":"        fd, tmp_master_image \u003d tempfile.mkstemp(dir\u003dCONF.pxe.tftp_master_path)"},{"line_number":493,"context_line":""},{"line_number":494,"context_line":"        with mock.patch.object(tempfile, \u0027mkstemp\u0027) as mkstemp_mock:"},{"line_number":495,"context_line":"            fetch_to_raw_mock.return_value \u003d None"},{"line_number":496,"context_line":"            mkstemp_mock.return_value \u003d (fd, tmp_master_image)"},{"line_number":497,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAW3%2F%2FqT4%3D","line":494,"in_reply_to":"AAAAW3%2F%2Fzs0%3D","updated":"2014-04-11 10:42:04.000000000","message":"Because before mock.patch need real `tempfile.mkstemp` L492","commit_id":"215f416c4debc6d4973390b79c88e5f2db563558"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c8991b56375093ca0ddf0c5cbcd22abbbd7c845d","unresolved":false,"context_lines":[{"line_number":558,"context_line":"        fd, tmp_master_image \u003d tempfile.mkstemp("},{"line_number":559,"context_line":"            dir\u003dCONF.pxe.instance_master_path)"},{"line_number":560,"context_line":""},{"line_number":561,"context_line":"        with mock.patch.object(tempfile, \u0027mkstemp\u0027) as mkstemp_mock:"},{"line_number":562,"context_line":"            mkstemp_mock.return_value \u003d (fd, tmp_master_image)"},{"line_number":563,"context_line":"            fetch_to_raw_mock.return_value \u003d None"},{"line_number":564,"context_line":"            parse_image_ref_mock.return_value \u003d (\u0027image_uuid\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAW3%2F%2Fzr4%3D","line":561,"updated":"2014-04-10 09:32:00.000000000","message":"The same here","commit_id":"215f416c4debc6d4973390b79c88e5f2db563558"},{"author":{"_account_id":8412,"name":"Mike Durnosvistov","email":"glacierr.dev@gmail.com","username":"mdurnosvistov"},"change_message_id":"e8c67c1e536e7abe27ae834c6b16694b61b14f4b","unresolved":false,"context_lines":[{"line_number":558,"context_line":"        fd, tmp_master_image \u003d tempfile.mkstemp("},{"line_number":559,"context_line":"            dir\u003dCONF.pxe.instance_master_path)"},{"line_number":560,"context_line":""},{"line_number":561,"context_line":"        with mock.patch.object(tempfile, \u0027mkstemp\u0027) as mkstemp_mock:"},{"line_number":562,"context_line":"            mkstemp_mock.return_value \u003d (fd, tmp_master_image)"},{"line_number":563,"context_line":"            fetch_to_raw_mock.return_value \u003d None"},{"line_number":564,"context_line":"            parse_image_ref_mock.return_value \u003d (\u0027image_uuid\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAW3%2F%2FqTg%3D","line":561,"in_reply_to":"AAAAW3%2F%2Fzr4%3D","updated":"2014-04-11 10:42:04.000000000","message":"ditto","commit_id":"215f416c4debc6d4973390b79c88e5f2db563558"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"85490169a607d0f8c333a93a25ded27f68ae339f","unresolved":false,"context_lines":[{"line_number":485,"context_line":"        fileutils.ensure_tree(CONF.pxe.tftp_master_path)"},{"line_number":486,"context_line":"        fd, tmp_master_image \u003d tempfile.mkstemp(dir\u003dCONF.pxe.tftp_master_path)"},{"line_number":487,"context_line":""},{"line_number":488,"context_line":"        with mock.patch.object(tempfile, \u0027mkstemp\u0027) as mkstemp_mock:"},{"line_number":489,"context_line":"            fetch_to_raw_mock.return_value \u003d None"},{"line_number":490,"context_line":"            mkstemp_mock.return_value \u003d (fd, tmp_master_image)"},{"line_number":491,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAXX%2F%2F4eg%3D","line":488,"updated":"2014-04-25 15:29:47.000000000","message":"Why skipping this? Or is it from merge?","commit_id":"1e6905e511179b5ac1be5e823b5a3b5262dfc3fa"},{"author":{"_account_id":8412,"name":"Mike Durnosvistov","email":"glacierr.dev@gmail.com","username":"mdurnosvistov"},"change_message_id":"1bc969f3f88948f644fd7a2d2461cf533ab56180","unresolved":false,"context_lines":[{"line_number":485,"context_line":"        fileutils.ensure_tree(CONF.pxe.tftp_master_path)"},{"line_number":486,"context_line":"        fd, tmp_master_image \u003d tempfile.mkstemp(dir\u003dCONF.pxe.tftp_master_path)"},{"line_number":487,"context_line":""},{"line_number":488,"context_line":"        with mock.patch.object(tempfile, \u0027mkstemp\u0027) as mkstemp_mock:"},{"line_number":489,"context_line":"            fetch_to_raw_mock.return_value \u003d None"},{"line_number":490,"context_line":"            mkstemp_mock.return_value \u003d (fd, tmp_master_image)"},{"line_number":491,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAXX%2F%2F3jo%3D","line":488,"in_reply_to":"AAAAXX%2F%2F4eg%3D","updated":"2014-04-25 17:13:30.000000000","message":"I left comment about this point in 4th patch set [1]\n\n[1] https://review.openstack.org/#/c/73223/4/ironic/tests/drivers/test_pxe.py","commit_id":"1e6905e511179b5ac1be5e823b5a3b5262dfc3fa"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"85490169a607d0f8c333a93a25ded27f68ae339f","unresolved":false,"context_lines":[{"line_number":552,"context_line":"        fd, tmp_master_image \u003d tempfile.mkstemp("},{"line_number":553,"context_line":"            dir\u003dCONF.pxe.instance_master_path)"},{"line_number":554,"context_line":""},{"line_number":555,"context_line":"        with mock.patch.object(tempfile, \u0027mkstemp\u0027) as mkstemp_mock:"},{"line_number":556,"context_line":"            mkstemp_mock.return_value \u003d (fd, tmp_master_image)"},{"line_number":557,"context_line":"            fetch_to_raw_mock.return_value \u003d None"},{"line_number":558,"context_line":"            parse_image_ref_mock.return_value \u003d (\u0027image_uuid\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAXX%2F%2F4ec%3D","line":555,"updated":"2014-04-25 15:29:47.000000000","message":"ditto","commit_id":"1e6905e511179b5ac1be5e823b5a3b5262dfc3fa"}],"ironic/tests/drivers/test_ssh.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c8991b56375093ca0ddf0c5cbcd22abbbd7c845d","unresolved":false,"context_lines":[{"line_number":183,"context_line":"            if self.ssh_patcher:"},{"line_number":184,"context_line":"                self.ssh_patcher.stop()"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"        self.addCleanup(stop_patcher)"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    @mock.patch.object(utils, \u0027ssh_connect\u0027)"},{"line_number":189,"context_line":"    def test__get_connection_client(self, ssh_connect_mock):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAW3%2F%2Fzqo%3D","line":186,"updated":"2014-04-10 09:32:00.000000000","message":"This should be a class decorator as well","commit_id":"215f416c4debc6d4973390b79c88e5f2db563558"},{"author":{"_account_id":8412,"name":"Mike Durnosvistov","email":"glacierr.dev@gmail.com","username":"mdurnosvistov"},"change_message_id":"e8c67c1e536e7abe27ae834c6b16694b61b14f4b","unresolved":false,"context_lines":[{"line_number":183,"context_line":"            if self.ssh_patcher:"},{"line_number":184,"context_line":"                self.ssh_patcher.stop()"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"        self.addCleanup(stop_patcher)"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    @mock.patch.object(utils, \u0027ssh_connect\u0027)"},{"line_number":189,"context_line":"    def test__get_connection_client(self, ssh_connect_mock):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAW3%2F%2FqTQ%3D","line":186,"in_reply_to":"AAAAW3%2F%2Fzqo%3D","updated":"2014-04-11 10:42:04.000000000","message":"ditto about mock-decorators","commit_id":"215f416c4debc6d4973390b79c88e5f2db563558"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c8991b56375093ca0ddf0c5cbcd22abbbd7c845d","unresolved":false,"context_lines":[{"line_number":576,"context_line":"                self.get_mac_addr_patcher.stop()"},{"line_number":577,"context_line":"            if self.get_conn_mock:"},{"line_number":578,"context_line":"                self.get_conn_patcher.stop()"},{"line_number":579,"context_line":""},{"line_number":580,"context_line":"        self.addCleanup(stop_patchers)"},{"line_number":581,"context_line":""},{"line_number":582,"context_line":"    def test__get_nodes_mac_addresses(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAW3%2F%2FzqQ%3D","line":579,"updated":"2014-04-10 09:32:00.000000000","message":"Also consider converting these to class decorators","commit_id":"215f416c4debc6d4973390b79c88e5f2db563558"},{"author":{"_account_id":8412,"name":"Mike Durnosvistov","email":"glacierr.dev@gmail.com","username":"mdurnosvistov"},"change_message_id":"e8c67c1e536e7abe27ae834c6b16694b61b14f4b","unresolved":false,"context_lines":[{"line_number":576,"context_line":"                self.get_mac_addr_patcher.stop()"},{"line_number":577,"context_line":"            if self.get_conn_mock:"},{"line_number":578,"context_line":"                self.get_conn_patcher.stop()"},{"line_number":579,"context_line":""},{"line_number":580,"context_line":"        self.addCleanup(stop_patchers)"},{"line_number":581,"context_line":""},{"line_number":582,"context_line":"    def test__get_nodes_mac_addresses(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAW3%2F%2FqSk%3D","line":579,"in_reply_to":"AAAAW3%2F%2FzqQ%3D","updated":"2014-04-11 10:42:04.000000000","message":"ditto","commit_id":"215f416c4debc6d4973390b79c88e5f2db563558"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"038f4e0e228c381ec0fa4479b4104997cf5bd2d1","unresolved":false,"context_lines":[{"line_number":202,"context_line":"            if self.ssh_patcher:"},{"line_number":203,"context_line":"                self.ssh_patcher.stop()"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"        self.addCleanup(stop_patcher)"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    @mock.patch.object(utils, \u0027ssh_connect\u0027)"},{"line_number":208,"context_line":"    def test__get_connection_client(self, ssh_connect_mock):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAW3%2F%2FUJA%3D","line":205,"updated":"2014-04-15 12:25:23.000000000","message":"Please consider turning this to a class level decorator with lambda like\n\n @mock.patch.object(processutils, \u0027ssh_execute\u0027, lambda *_: (\u0027\u0027, \u0027\u0027))","commit_id":"bf07bc6536346d006d5899f8871ef9d04882261d"},{"author":{"_account_id":8412,"name":"Mike Durnosvistov","email":"glacierr.dev@gmail.com","username":"mdurnosvistov"},"change_message_id":"2ba39731c5571d7f694c6e157bd23ccb8a3fbb5a","unresolved":false,"context_lines":[{"line_number":202,"context_line":"            if self.ssh_patcher:"},{"line_number":203,"context_line":"                self.ssh_patcher.stop()"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"        self.addCleanup(stop_patcher)"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    @mock.patch.object(utils, \u0027ssh_connect\u0027)"},{"line_number":208,"context_line":"    def test__get_connection_client(self, ssh_connect_mock):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAXH%2F%2Fyok%3D","line":205,"in_reply_to":"AAAAW3%2F%2FUJA%3D","updated":"2014-04-17 15:46:01.000000000","message":"Done","commit_id":"bf07bc6536346d006d5899f8871ef9d04882261d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"038f4e0e228c381ec0fa4479b4104997cf5bd2d1","unresolved":false,"context_lines":[{"line_number":595,"context_line":"            if self.get_conn_mock:"},{"line_number":596,"context_line":"                self.get_conn_patcher.stop()"},{"line_number":597,"context_line":""},{"line_number":598,"context_line":"        self.addCleanup(stop_patchers)"},{"line_number":599,"context_line":""},{"line_number":600,"context_line":"    @mock.patch.object(utils, \u0027ssh_connect\u0027)"},{"line_number":601,"context_line":"    def test__validate_info_ssh_connect_failed(self, ssh_connect_mock):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAW3%2F%2FUJ0%3D","line":598,"updated":"2014-04-15 12:25:23.000000000","message":"Please consider turning these to class-level decorators","commit_id":"bf07bc6536346d006d5899f8871ef9d04882261d"},{"author":{"_account_id":8412,"name":"Mike Durnosvistov","email":"glacierr.dev@gmail.com","username":"mdurnosvistov"},"change_message_id":"2ba39731c5571d7f694c6e157bd23ccb8a3fbb5a","unresolved":false,"context_lines":[{"line_number":595,"context_line":"            if self.get_conn_mock:"},{"line_number":596,"context_line":"                self.get_conn_patcher.stop()"},{"line_number":597,"context_line":""},{"line_number":598,"context_line":"        self.addCleanup(stop_patchers)"},{"line_number":599,"context_line":""},{"line_number":600,"context_line":"    @mock.patch.object(utils, \u0027ssh_connect\u0027)"},{"line_number":601,"context_line":"    def test__validate_info_ssh_connect_failed(self, ssh_connect_mock):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAXH%2F%2FxLA%3D","line":598,"in_reply_to":"AAAAW3%2F%2FUJ0%3D","updated":"2014-04-17 15:46:01.000000000","message":"Done\n\nBut `parse_drv_info_mock` sometimes need `None` L63, if this mock use like decorator that `info` will `MagicMock` instead real `info`.","commit_id":"bf07bc6536346d006d5899f8871ef9d04882261d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"85490169a607d0f8c333a93a25ded27f68ae339f","unresolved":false,"context_lines":[{"line_number":192,"context_line":"                        driver_info\u003ddb_utils.get_test_ssh_info())"},{"line_number":193,"context_line":"        self.sshclient \u003d paramiko.SSHClient()"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"    # @mock.patch.object(processutils, \u0027ssh_execute\u0027, lambda *_: (\u0027\u0027, \u0027\u0027))"},{"line_number":196,"context_line":"    @mock.patch.object(utils, \u0027ssh_connect\u0027)"},{"line_number":197,"context_line":"    def test__get_connection_client(self, ssh_connect_mock):"},{"line_number":198,"context_line":"        ssh_connect_mock.return_value \u003d self.sshclient"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAXX%2F%2F4eI%3D","line":195,"updated":"2014-04-25 15:29:47.000000000","message":"Can we get rid of this comment?","commit_id":"1e6905e511179b5ac1be5e823b5a3b5262dfc3fa"},{"author":{"_account_id":8412,"name":"Mike Durnosvistov","email":"glacierr.dev@gmail.com","username":"mdurnosvistov"},"change_message_id":"1bc969f3f88948f644fd7a2d2461cf533ab56180","unresolved":false,"context_lines":[{"line_number":192,"context_line":"                        driver_info\u003ddb_utils.get_test_ssh_info())"},{"line_number":193,"context_line":"        self.sshclient \u003d paramiko.SSHClient()"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"    # @mock.patch.object(processutils, \u0027ssh_execute\u0027, lambda *_: (\u0027\u0027, \u0027\u0027))"},{"line_number":196,"context_line":"    @mock.patch.object(utils, \u0027ssh_connect\u0027)"},{"line_number":197,"context_line":"    def test__get_connection_client(self, ssh_connect_mock):"},{"line_number":198,"context_line":"        ssh_connect_mock.return_value \u003d self.sshclient"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAXX%2F%2F3dc%3D","line":195,"in_reply_to":"AAAAXX%2F%2F4eI%3D","updated":"2014-04-25 17:13:30.000000000","message":"Will do! :)","commit_id":"1e6905e511179b5ac1be5e823b5a3b5262dfc3fa"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"85490169a607d0f8c333a93a25ded27f68ae339f","unresolved":false,"context_lines":[{"line_number":577,"context_line":""},{"line_number":578,"context_line":"        def stop_patchers():"},{"line_number":579,"context_line":"            if self.parse_drv_info_mock:"},{"line_number":580,"context_line":"                self.parse_drv_info_patcher.stop()"},{"line_number":581,"context_line":""},{"line_number":582,"context_line":"        self.addCleanup(stop_patchers)"},{"line_number":583,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAXX%2F%2F4dg%3D","line":580,"updated":"2014-04-25 15:29:47.000000000","message":"Please try to convert this as well. I admit I didn\u0027t quite get your explanation why it is impossible. If you really insist it is - ok, but I do think it is possible by using either class-level or method-level decorator. Or even context manager - but what we have now seems to be misuse of mock library to me.","commit_id":"1e6905e511179b5ac1be5e823b5a3b5262dfc3fa"},{"author":{"_account_id":8412,"name":"Mike Durnosvistov","email":"glacierr.dev@gmail.com","username":"mdurnosvistov"},"change_message_id":"1bc969f3f88948f644fd7a2d2461cf533ab56180","unresolved":false,"context_lines":[{"line_number":577,"context_line":""},{"line_number":578,"context_line":"        def stop_patchers():"},{"line_number":579,"context_line":"            if self.parse_drv_info_mock:"},{"line_number":580,"context_line":"                self.parse_drv_info_patcher.stop()"},{"line_number":581,"context_line":""},{"line_number":582,"context_line":"        self.addCleanup(stop_patchers)"},{"line_number":583,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAXX%2F%2F3e8%3D","line":580,"in_reply_to":"AAAAXX%2F%2F4dg%3D","updated":"2014-04-25 17:13:30.000000000","message":"Ok. I\u0027ll try :)","commit_id":"1e6905e511179b5ac1be5e823b5a3b5262dfc3fa"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f5361877ac4c6d89688687acc8defbb77e1adb15","unresolved":false,"context_lines":[{"line_number":653,"context_line":"                driver_info \u003d ssh._parse_driver_info(self.node)"},{"line_number":654,"context_line":"                ssh_connect_mock.assert_called_once_with(driver_info)"},{"line_number":655,"context_line":""},{"line_number":656,"context_line":"    def test_validate_fail_no_port(self):"},{"line_number":657,"context_line":"        # stop the get_mac_addr mock, it\u0027s needed for this test"},{"line_number":658,"context_line":"        self.get_mac_addr_patcher.stop()"},{"line_number":659,"context_line":"        self.get_mac_addr_mock \u003d None"}],"source_content_type":"text/x-python","patch_set":8,"id":"bad4c104_39ce6e5b","side":"PARENT","line":656,"updated":"2014-04-29 18:17:36.000000000","message":"What happened here? Why did you combine this test with the one above? This doesn\u0027t need a mocked ssh_connect?","commit_id":"872aabbda5305cd0cec34b5f5eb72b2144ec0877"},{"author":{"_account_id":8412,"name":"Mike Durnosvistov","email":"glacierr.dev@gmail.com","username":"mdurnosvistov"},"change_message_id":"cc8547d65f26c31250fc07668a76128ae122710c","unresolved":false,"context_lines":[{"line_number":653,"context_line":"                driver_info \u003d ssh._parse_driver_info(self.node)"},{"line_number":654,"context_line":"                ssh_connect_mock.assert_called_once_with(driver_info)"},{"line_number":655,"context_line":""},{"line_number":656,"context_line":"    def test_validate_fail_no_port(self):"},{"line_number":657,"context_line":"        # stop the get_mac_addr mock, it\u0027s needed for this test"},{"line_number":658,"context_line":"        self.get_mac_addr_patcher.stop()"},{"line_number":659,"context_line":"        self.get_mac_addr_mock \u003d None"}],"source_content_type":"text/x-python","patch_set":8,"id":"bad4c104_2dce285b","side":"PARENT","line":656,"in_reply_to":"bad4c104_39ce6e5b","updated":"2014-04-29 20:45:00.000000000","message":"Oops... I did not notice it.","commit_id":"872aabbda5305cd0cec34b5f5eb72b2144ec0877"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f5361877ac4c6d89688687acc8defbb77e1adb15","unresolved":false,"context_lines":[{"line_number":639,"context_line":""},{"line_number":640,"context_line":"        with mock.patch.object(ssh,"},{"line_number":641,"context_line":"                               \u0027_parse_driver_info\u0027) as parse_drv_info_mock:"},{"line_number":642,"context_line":"            parse_drv_info_mock.return_value \u003d info"},{"line_number":643,"context_line":"            get_mac_addr_mock.return_value \u003d info[\u0027macs\u0027]"},{"line_number":644,"context_line":"            get_conn_mock.return_value \u003d self.sshclient"},{"line_number":645,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"bad4c104_b9f35e72","line":642,"updated":"2014-04-29 18:17:36.000000000","message":"There are a bunch of these tests where the indentation seems a bit odd. You set the return values here, but the check for .assert_called_once_with() is in an outer level.","commit_id":"e40db3d8e6f1d02a1ebaca5b6c84066152af6809"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"4f9ec874b69e6dde32b76782e9188aee17135723","unresolved":false,"context_lines":[{"line_number":639,"context_line":""},{"line_number":640,"context_line":"        with mock.patch.object(ssh,"},{"line_number":641,"context_line":"                               \u0027_parse_driver_info\u0027) as parse_drv_info_mock:"},{"line_number":642,"context_line":"            parse_drv_info_mock.return_value \u003d info"},{"line_number":643,"context_line":"            get_mac_addr_mock.return_value \u003d info[\u0027macs\u0027]"},{"line_number":644,"context_line":"            get_conn_mock.return_value \u003d self.sshclient"},{"line_number":645,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"bad4c104_88bc826e","line":642,"in_reply_to":"bad4c104_286536e1","updated":"2014-04-29 21:02:51.000000000","message":"Right, so it seems clearer/cleaner that both setting the return_value\u0027s (eg get_mac_addr_mock.return_value\u003d, etc) and making the .assert_called_once_with()\u0027s (eg get_mac_addr_mock.assert_called_once_with) are done at the same level, either inside or outside.\n\n(Yes, parse_drv_info_mock stuff has to be done in the block!)","commit_id":"e40db3d8e6f1d02a1ebaca5b6c84066152af6809"},{"author":{"_account_id":8412,"name":"Mike Durnosvistov","email":"glacierr.dev@gmail.com","username":"mdurnosvistov"},"change_message_id":"47bd11bf77a2608551ee51e677e336505925d523","unresolved":false,"context_lines":[{"line_number":639,"context_line":""},{"line_number":640,"context_line":"        with mock.patch.object(ssh,"},{"line_number":641,"context_line":"                               \u0027_parse_driver_info\u0027) as parse_drv_info_mock:"},{"line_number":642,"context_line":"            parse_drv_info_mock.return_value \u003d info"},{"line_number":643,"context_line":"            get_mac_addr_mock.return_value \u003d info[\u0027macs\u0027]"},{"line_number":644,"context_line":"            get_conn_mock.return_value \u003d self.sshclient"},{"line_number":645,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"bad4c104_c37cab75","line":642,"in_reply_to":"bad4c104_88bc826e","updated":"2014-04-29 21:16:16.000000000","message":"I agree with you. will do! :)","commit_id":"e40db3d8e6f1d02a1ebaca5b6c84066152af6809"},{"author":{"_account_id":8412,"name":"Mike Durnosvistov","email":"glacierr.dev@gmail.com","username":"mdurnosvistov"},"change_message_id":"cc8547d65f26c31250fc07668a76128ae122710c","unresolved":false,"context_lines":[{"line_number":639,"context_line":""},{"line_number":640,"context_line":"        with mock.patch.object(ssh,"},{"line_number":641,"context_line":"                               \u0027_parse_driver_info\u0027) as parse_drv_info_mock:"},{"line_number":642,"context_line":"            parse_drv_info_mock.return_value \u003d info"},{"line_number":643,"context_line":"            get_mac_addr_mock.return_value \u003d info[\u0027macs\u0027]"},{"line_number":644,"context_line":"            get_conn_mock.return_value \u003d self.sshclient"},{"line_number":645,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"bad4c104_286536e1","line":642,"in_reply_to":"bad4c104_b9f35e72","updated":"2014-04-29 20:45:00.000000000","message":"Only `parse_drv_info_mock.assert_called_once_with` must be located in the block `with` because it mocked via context manager. The remaining mocks at level test-case can be outside the block `with`.","commit_id":"e40db3d8e6f1d02a1ebaca5b6c84066152af6809"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"50db6784bf0c6423e6ee0eeb5194167bf6cfc3b2","unresolved":false,"context_lines":[{"line_number":620,"context_line":"                task.resources[0].driver.power.reboot(task, self.node)"},{"line_number":621,"context_line":""},{"line_number":622,"context_line":"            parse_drv_info_mock.assert_called_once_with(self.node)"},{"line_number":623,"context_line":"        get_mac_addr_mock.assert_called_once_with(mock.ANY, self.node)"},{"line_number":624,"context_line":"        get_conn_mock.assert_called_once_with(self.node)"},{"line_number":625,"context_line":"        get_power_stat_mock.assert_called_once_with(self.sshclient, info)"},{"line_number":626,"context_line":"        power_off_mock.assert_called_once_with(self.sshclient, info)"}],"source_content_type":"text/x-python","patch_set":9,"id":"9ad9bd40_0bbf09ab","line":623,"updated":"2014-05-06 14:41:26.000000000","message":"I don\u0027t see that you addressed my comments from the previous patch?","commit_id":"b58db1348e00b2d8e4834643e3738a5513c3d0a9"},{"author":{"_account_id":8412,"name":"Mike Durnosvistov","email":"glacierr.dev@gmail.com","username":"mdurnosvistov"},"change_message_id":"85d89a568261c291673c644c65dab089467a9413","unresolved":false,"context_lines":[{"line_number":620,"context_line":"                task.resources[0].driver.power.reboot(task, self.node)"},{"line_number":621,"context_line":""},{"line_number":622,"context_line":"            parse_drv_info_mock.assert_called_once_with(self.node)"},{"line_number":623,"context_line":"        get_mac_addr_mock.assert_called_once_with(mock.ANY, self.node)"},{"line_number":624,"context_line":"        get_conn_mock.assert_called_once_with(self.node)"},{"line_number":625,"context_line":"        get_power_stat_mock.assert_called_once_with(self.sshclient, info)"},{"line_number":626,"context_line":"        power_off_mock.assert_called_once_with(self.sshclient, info)"}],"source_content_type":"text/x-python","patch_set":9,"id":"9ad9bd40_7fa92b8f","line":623,"in_reply_to":"9ad9bd40_0bbf09ab","updated":"2014-05-06 16:46:43.000000000","message":"Oh sorry! :) I forgot about it...","commit_id":"b58db1348e00b2d8e4834643e3738a5513c3d0a9"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1966f10447f9720ff442d1569074cf880c42d3af","unresolved":false,"context_lines":[{"line_number":617,"context_line":"                task.resources[0].driver.power.reboot(task, self.node)"},{"line_number":618,"context_line":""},{"line_number":619,"context_line":"            parse_drv_info_mock.assert_called_once_with(self.node)"},{"line_number":620,"context_line":"        get_mac_addr_mock.assert_called_once_with(mock.ANY, self.node)"},{"line_number":621,"context_line":"        get_conn_mock.assert_called_once_with(self.node)"},{"line_number":622,"context_line":"        get_power_stat_mock.assert_called_once_with(self.sshclient, info)"},{"line_number":623,"context_line":"        power_off_mock.assert_called_once_with(self.sshclient, info)"}],"source_content_type":"text/x-python","patch_set":10,"id":"7adec928_4ba3519e","line":620,"updated":"2014-05-08 14:20:02.000000000","message":"Hmm. ditto comment from the previous patch and the previous one to that.","commit_id":"e6c1b48cbb7ce44062a29aae84ff69a9f6c3a946"},{"author":{"_account_id":8412,"name":"Mike Durnosvistov","email":"glacierr.dev@gmail.com","username":"mdurnosvistov"},"change_message_id":"3f2125abf47ccac8281883af81c66def865c64a6","unresolved":false,"context_lines":[{"line_number":617,"context_line":"                task.resources[0].driver.power.reboot(task, self.node)"},{"line_number":618,"context_line":""},{"line_number":619,"context_line":"            parse_drv_info_mock.assert_called_once_with(self.node)"},{"line_number":620,"context_line":"        get_mac_addr_mock.assert_called_once_with(mock.ANY, self.node)"},{"line_number":621,"context_line":"        get_conn_mock.assert_called_once_with(self.node)"},{"line_number":622,"context_line":"        get_power_stat_mock.assert_called_once_with(self.sshclient, info)"},{"line_number":623,"context_line":"        power_off_mock.assert_called_once_with(self.sshclient, info)"}],"source_content_type":"text/x-python","patch_set":10,"id":"7adec928_56413838","line":620,"in_reply_to":"7adec928_4ba3519e","updated":"2014-05-08 14:35:51.000000000","message":"hmm, I probably misunderstood your comment... :\\","commit_id":"e6c1b48cbb7ce44062a29aae84ff69a9f6c3a946"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"7f497b20c972597c3a04f2e388221f12b338c1fd","unresolved":false,"context_lines":[{"line_number":617,"context_line":"                task.resources[0].driver.power.reboot(task, self.node)"},{"line_number":618,"context_line":""},{"line_number":619,"context_line":"            parse_drv_info_mock.assert_called_once_with(self.node)"},{"line_number":620,"context_line":"        get_mac_addr_mock.assert_called_once_with(mock.ANY, self.node)"},{"line_number":621,"context_line":"        get_conn_mock.assert_called_once_with(self.node)"},{"line_number":622,"context_line":"        get_power_stat_mock.assert_called_once_with(self.sshclient, info)"},{"line_number":623,"context_line":"        power_off_mock.assert_called_once_with(self.sshclient, info)"}],"source_content_type":"text/x-python","patch_set":10,"id":"7adec928_ccc134e6","line":620,"in_reply_to":"7adec928_56413838","updated":"2014-05-08 18:29:09.000000000","message":"Argh. Sorry, I put the comment in the wrong place. This test is fine. The alignment/indentation is still a bit off in all the tests following this one.","commit_id":"e6c1b48cbb7ce44062a29aae84ff69a9f6c3a946"},{"author":{"_account_id":8412,"name":"Mike Durnosvistov","email":"glacierr.dev@gmail.com","username":"mdurnosvistov"},"change_message_id":"eeb43983efb33b295cf96335987ce280c3bfb2ca","unresolved":false,"context_lines":[{"line_number":617,"context_line":"                task.resources[0].driver.power.reboot(task, self.node)"},{"line_number":618,"context_line":""},{"line_number":619,"context_line":"            parse_drv_info_mock.assert_called_once_with(self.node)"},{"line_number":620,"context_line":"        get_mac_addr_mock.assert_called_once_with(mock.ANY, self.node)"},{"line_number":621,"context_line":"        get_conn_mock.assert_called_once_with(self.node)"},{"line_number":622,"context_line":"        get_power_stat_mock.assert_called_once_with(self.sshclient, info)"},{"line_number":623,"context_line":"        power_off_mock.assert_called_once_with(self.sshclient, info)"}],"source_content_type":"text/x-python","patch_set":10,"id":"7adec928_423ecbb9","line":620,"in_reply_to":"7adec928_ccc134e6","updated":"2014-05-08 19:17:16.000000000","message":"Will do! :)","commit_id":"e6c1b48cbb7ce44062a29aae84ff69a9f6c3a946"}]}
