)]}'
{"ironic/drivers/modules/ilo/common.py":[{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"160c5f354770ec7db92de493ce43e7dce085d0a6","unresolved":false,"context_lines":[{"line_number":515,"context_line":"        c_boot_mode \u003d ilo_object.get_current_boot_mode()"},{"line_number":516,"context_line":"        return BOOT_MODE_ILO_TO_GENERIC[c_boot_mode.lower()]"},{"line_number":517,"context_line":"    except ilo_error.IloCommandNotSupportedError:"},{"line_number":518,"context_line":"        return BOOT_MODE_ILO_TO_GENERIC[DEFAULT_BOOT_MODE.lower()]"},{"line_number":519,"context_line":""},{"line_number":520,"context_line":"    except ilo_error.IloError as ilo_exception:"},{"line_number":521,"context_line":"        raise exception.IloOperationError(operation\u003doperation,"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_39be59ff","line":518,"range":{"start_line":518,"start_character":40,"end_line":518,"end_character":56},"updated":"2020-07-01 05:49:35.000000000","message":"How can we assume \"legacy\" as default for a \"uefi only\" systems. Should we throw exception instead like the case below? Alternatively get the supported boot modes and return one instead. Just a thought.","commit_id":"e227d99bc857200d9f931f18282717f54cacbed8"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"4138346b92b46385ff2b0790620c2b9960d6501e","unresolved":false,"context_lines":[{"line_number":515,"context_line":"        c_boot_mode \u003d ilo_object.get_current_boot_mode()"},{"line_number":516,"context_line":"        return BOOT_MODE_ILO_TO_GENERIC[c_boot_mode.lower()]"},{"line_number":517,"context_line":"    except ilo_error.IloCommandNotSupportedError:"},{"line_number":518,"context_line":"        return BOOT_MODE_ILO_TO_GENERIC[DEFAULT_BOOT_MODE.lower()]"},{"line_number":519,"context_line":""},{"line_number":520,"context_line":"    except ilo_error.IloError as ilo_exception:"},{"line_number":521,"context_line":"        raise exception.IloOperationError(operation\u003doperation,"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_794a9183","line":518,"range":{"start_line":518,"start_character":40,"end_line":518,"end_character":56},"in_reply_to":"bf51134e_39be59ff","updated":"2020-07-01 07:21:54.000000000","message":"It will never raise this exception, can be removed.","commit_id":"e227d99bc857200d9f931f18282717f54cacbed8"}],"ironic/drivers/modules/ilo/management.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"3a09b554ba91189ab94f03dd259868bad61f789f","unresolved":false,"context_lines":[{"line_number":694,"context_line":"        \"\"\""},{"line_number":695,"context_line":"        ilo_object \u003d ilo_common.get_ilo_object(task.node)"},{"line_number":696,"context_line":"        try:"},{"line_number":697,"context_line":"            ilo_object.get_pending_boot_mode()"},{"line_number":698,"context_line":"        except ilo_error.IloCommandNotSupportedError:"},{"line_number":699,"context_line":"            return [boot_modes.LEGACY_BIOS]"},{"line_number":700,"context_line":"        return [boot_modes.UEFI, boot_modes.LEGACY_BIOS]"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_50c9b456","line":697,"updated":"2020-06-24 17:15:54.000000000","message":"Interesting! I guess the ilo client raises an exception which does help convey if there is no ability to change it.","commit_id":"e5fa100e463451b814d11396d5b4bf8814498024"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"2355d3da533e5c2692de1a8a2c739ec5353bd4ee","unresolved":false,"context_lines":[{"line_number":694,"context_line":"        \"\"\""},{"line_number":695,"context_line":"        ilo_object \u003d ilo_common.get_ilo_object(task.node)"},{"line_number":696,"context_line":"        try:"},{"line_number":697,"context_line":"            ilo_object.get_pending_boot_mode()"},{"line_number":698,"context_line":"        except ilo_error.IloCommandNotSupportedError:"},{"line_number":699,"context_line":"            return [boot_modes.LEGACY_BIOS]"},{"line_number":700,"context_line":"        return [boot_modes.UEFI, boot_modes.LEGACY_BIOS]"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_f7eef71f","line":697,"in_reply_to":"bf51134e_50c9b456","updated":"2020-06-25 05:53:50.000000000","message":"Yes, if only one boot mode is supported, one cannot change the boot mode and there is no concept of current and pending boot modes on such platforms. Ex: Gen8.","commit_id":"e5fa100e463451b814d11396d5b4bf8814498024"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"3a09b554ba91189ab94f03dd259868bad61f789f","unresolved":false,"context_lines":[{"line_number":697,"context_line":"            ilo_object.get_pending_boot_mode()"},{"line_number":698,"context_line":"        except ilo_error.IloCommandNotSupportedError:"},{"line_number":699,"context_line":"            return [boot_modes.LEGACY_BIOS]"},{"line_number":700,"context_line":"        return [boot_modes.UEFI, boot_modes.LEGACY_BIOS]"},{"line_number":701,"context_line":""},{"line_number":702,"context_line":"    @task_manager.require_exclusive_lock"},{"line_number":703,"context_line":"    def set_boot_mode(self, task, mode):"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_f0df280a","line":700,"updated":"2020-06-24 17:15:54.000000000","message":"This is worrisome, because I know, at least from some experience that some hardware was shipped, at least for a time that only supported UEFI boot mode. Has this changed?","commit_id":"e5fa100e463451b814d11396d5b4bf8814498024"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"e6e7023ef1b77f77cda2b0016100b3aea3829c9f","unresolved":false,"context_lines":[{"line_number":697,"context_line":"            ilo_object.get_pending_boot_mode()"},{"line_number":698,"context_line":"        except ilo_error.IloCommandNotSupportedError:"},{"line_number":699,"context_line":"            return [boot_modes.LEGACY_BIOS]"},{"line_number":700,"context_line":"        return [boot_modes.UEFI, boot_modes.LEGACY_BIOS]"},{"line_number":701,"context_line":""},{"line_number":702,"context_line":"    @task_manager.require_exclusive_lock"},{"line_number":703,"context_line":"    def set_boot_mode(self, task, mode):"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_97896c76","line":700,"in_reply_to":"bf51134e_77714776","updated":"2020-06-25 20:24:33.000000000","message":"I could have sworn there were some BL series gear that only did UEFI, but I\u0027m not going to find it with the spare time I have right now.","commit_id":"e5fa100e463451b814d11396d5b4bf8814498024"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"2355d3da533e5c2692de1a8a2c739ec5353bd4ee","unresolved":false,"context_lines":[{"line_number":697,"context_line":"            ilo_object.get_pending_boot_mode()"},{"line_number":698,"context_line":"        except ilo_error.IloCommandNotSupportedError:"},{"line_number":699,"context_line":"            return [boot_modes.LEGACY_BIOS]"},{"line_number":700,"context_line":"        return [boot_modes.UEFI, boot_modes.LEGACY_BIOS]"},{"line_number":701,"context_line":""},{"line_number":702,"context_line":"    @task_manager.require_exclusive_lock"},{"line_number":703,"context_line":"    def set_boot_mode(self, task, mode):"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_77714776","line":700,"in_reply_to":"bf51134e_f0df280a","updated":"2020-06-25 05:53:50.000000000","message":"There is no UEFI only Proliant server. The UEFI only servers are HPE Superdome Flex [1]. They use RMC and not iLO. The ilo drivers cannot be used with those servers.\n\nThe latest ProLiant server is \u0027Gen 10 plus\u0027 and it do support \u0027legacy BIOS\u0027 mode [2].\n \n[1] https://h20195.www2.hpe.com/v2/getdocument.aspx?docname\u003da00026242enw#\n[2] https://h20195.www2.hpe.com/v2/getdocument.aspx?docname\u003da00073554enw\u0026#","commit_id":"e5fa100e463451b814d11396d5b4bf8814498024"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"21f42be31abd70ba2e178c5c8698c9f749dfb6bd","unresolved":false,"context_lines":[{"line_number":706,"context_line":"        if ilo_common.get_current_boot_mode(node) \u003d\u003d boot_modes.LEGACY_BIOS:"},{"line_number":707,"context_line":"            return [boot_modes.UEFI, boot_modes.LEGACY_BIOS]"},{"line_number":708,"context_line":"        try:"},{"line_number":709,"context_line":"            ilo_common.set_boot_mode(node, boot_modes.LEGACY_BIOS)"},{"line_number":710,"context_line":"        except exception.IloOperationError:"},{"line_number":711,"context_line":"            return [boot_modes.UEFI]"},{"line_number":712,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_e740dea7","line":709,"updated":"2020-06-29 08:46:59.000000000","message":"Ugh, I don\u0027t think we should modify anything in this call, even temporary..","commit_id":"92b954917dc8d636171ccb6ffa5727273d74229d"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"3fe5966f5c7930bc070f75ce83ca0a8dea4a3d7d","unresolved":false,"context_lines":[{"line_number":706,"context_line":"        if ilo_common.get_current_boot_mode(node) \u003d\u003d boot_modes.LEGACY_BIOS:"},{"line_number":707,"context_line":"            return [boot_modes.UEFI, boot_modes.LEGACY_BIOS]"},{"line_number":708,"context_line":"        try:"},{"line_number":709,"context_line":"            ilo_common.set_boot_mode(node, boot_modes.LEGACY_BIOS)"},{"line_number":710,"context_line":"        except exception.IloOperationError:"},{"line_number":711,"context_line":"            return [boot_modes.UEFI]"},{"line_number":712,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_92e83e7c","line":709,"in_reply_to":"bf51134e_e740dea7","updated":"2020-06-29 11:11:44.000000000","message":"Found better way of doing it.","commit_id":"92b954917dc8d636171ccb6ffa5727273d74229d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"21f42be31abd70ba2e178c5c8698c9f749dfb6bd","unresolved":false,"context_lines":[{"line_number":708,"context_line":"        try:"},{"line_number":709,"context_line":"            ilo_common.set_boot_mode(node, boot_modes.LEGACY_BIOS)"},{"line_number":710,"context_line":"        except exception.IloOperationError:"},{"line_number":711,"context_line":"            return [boot_modes.UEFI]"},{"line_number":712,"context_line":""},{"line_number":713,"context_line":"        # Revert the boot mode change"},{"line_number":714,"context_line":"        ilo_common.set_boot_mode(node, boot_modes.UEFI)"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_c73b1a35","line":711,"updated":"2020-06-29 08:46:59.000000000","message":"maybe catch generic exceptions so that we don\u0027t end up with get_supported_boot_modes raising something about setting boot mode?","commit_id":"92b954917dc8d636171ccb6ffa5727273d74229d"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"3fe5966f5c7930bc070f75ce83ca0a8dea4a3d7d","unresolved":false,"context_lines":[{"line_number":708,"context_line":"        try:"},{"line_number":709,"context_line":"            ilo_common.set_boot_mode(node, boot_modes.LEGACY_BIOS)"},{"line_number":710,"context_line":"        except exception.IloOperationError:"},{"line_number":711,"context_line":"            return [boot_modes.UEFI]"},{"line_number":712,"context_line":""},{"line_number":713,"context_line":"        # Revert the boot mode change"},{"line_number":714,"context_line":"        ilo_common.set_boot_mode(node, boot_modes.UEFI)"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_d2dc76e5","line":711,"in_reply_to":"bf51134e_c73b1a35","updated":"2020-06-29 11:11:44.000000000","message":"No more required.","commit_id":"92b954917dc8d636171ccb6ffa5727273d74229d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"21f42be31abd70ba2e178c5c8698c9f749dfb6bd","unresolved":false,"context_lines":[{"line_number":711,"context_line":"            return [boot_modes.UEFI]"},{"line_number":712,"context_line":""},{"line_number":713,"context_line":"        # Revert the boot mode change"},{"line_number":714,"context_line":"        ilo_common.set_boot_mode(node, boot_modes.UEFI)"},{"line_number":715,"context_line":"        return [boot_modes.UEFI, boot_modes.LEGACY_BIOS]"},{"line_number":716,"context_line":""},{"line_number":717,"context_line":"    @task_manager.require_exclusive_lock"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_274776be","line":714,"updated":"2020-06-29 08:46:59.000000000","message":"ditto?","commit_id":"92b954917dc8d636171ccb6ffa5727273d74229d"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"3fe5966f5c7930bc070f75ce83ca0a8dea4a3d7d","unresolved":false,"context_lines":[{"line_number":711,"context_line":"            return [boot_modes.UEFI]"},{"line_number":712,"context_line":""},{"line_number":713,"context_line":"        # Revert the boot mode change"},{"line_number":714,"context_line":"        ilo_common.set_boot_mode(node, boot_modes.UEFI)"},{"line_number":715,"context_line":"        return [boot_modes.UEFI, boot_modes.LEGACY_BIOS]"},{"line_number":716,"context_line":""},{"line_number":717,"context_line":"    @task_manager.require_exclusive_lock"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_92cf9e27","line":714,"in_reply_to":"bf51134e_274776be","updated":"2020-06-29 11:11:44.000000000","message":"No more required.","commit_id":"92b954917dc8d636171ccb6ffa5727273d74229d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"21f42be31abd70ba2e178c5c8698c9f749dfb6bd","unresolved":false,"context_lines":[{"line_number":727,"context_line":"                 specified."},{"line_number":728,"context_line":"        :raises: IloOperationError if setting boot mode failed."},{"line_number":729,"context_line":"        \"\"\""},{"line_number":730,"context_line":"        if mode not in self.get_supported_boot_modes(task):"},{"line_number":731,"context_line":"            raise exception.InvalidParameterValue(_("},{"line_number":732,"context_line":"                \"The given boot mode \u0027%s\u0027 is not supported.\") % mode)"},{"line_number":733,"context_line":"        ilo_common.set_boot_mode(task.node, mode)"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_074232ab","line":730,"updated":"2020-06-29 08:46:59.000000000","message":"doing this may end up with set_boot_mode called 3 times. maybe split a helper out of get_supported_boot_modes that does not do set_boot_mode itself...","commit_id":"92b954917dc8d636171ccb6ffa5727273d74229d"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"3fe5966f5c7930bc070f75ce83ca0a8dea4a3d7d","unresolved":false,"context_lines":[{"line_number":727,"context_line":"                 specified."},{"line_number":728,"context_line":"        :raises: IloOperationError if setting boot mode failed."},{"line_number":729,"context_line":"        \"\"\""},{"line_number":730,"context_line":"        if mode not in self.get_supported_boot_modes(task):"},{"line_number":731,"context_line":"            raise exception.InvalidParameterValue(_("},{"line_number":732,"context_line":"                \"The given boot mode \u0027%s\u0027 is not supported.\") % mode)"},{"line_number":733,"context_line":"        ilo_common.set_boot_mode(task.node, mode)"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_0de373a5","line":730,"in_reply_to":"bf51134e_074232ab","updated":"2020-06-29 11:11:44.000000000","message":"With changed logic, no set_boot_mode() is called in get_supported_boot_modes()","commit_id":"92b954917dc8d636171ccb6ffa5727273d74229d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"21f42be31abd70ba2e178c5c8698c9f749dfb6bd","unresolved":false,"context_lines":[{"line_number":730,"context_line":"        if mode not in self.get_supported_boot_modes(task):"},{"line_number":731,"context_line":"            raise exception.InvalidParameterValue(_("},{"line_number":732,"context_line":"                \"The given boot mode \u0027%s\u0027 is not supported.\") % mode)"},{"line_number":733,"context_line":"        ilo_common.set_boot_mode(task.node, mode)"},{"line_number":734,"context_line":""},{"line_number":735,"context_line":"    def get_boot_mode(self, task):"},{"line_number":736,"context_line":"        \"\"\"Get the current boot mode for a node."}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_67168eaa","line":733,"updated":"2020-06-29 08:46:59.000000000","message":"... and here you can catch IloOPerationError and translate it to InvalidParameterValue?","commit_id":"92b954917dc8d636171ccb6ffa5727273d74229d"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"3fe5966f5c7930bc070f75ce83ca0a8dea4a3d7d","unresolved":false,"context_lines":[{"line_number":730,"context_line":"        if mode not in self.get_supported_boot_modes(task):"},{"line_number":731,"context_line":"            raise exception.InvalidParameterValue(_("},{"line_number":732,"context_line":"                \"The given boot mode \u0027%s\u0027 is not supported.\") % mode)"},{"line_number":733,"context_line":"        ilo_common.set_boot_mode(task.node, mode)"},{"line_number":734,"context_line":""},{"line_number":735,"context_line":"    def get_boot_mode(self, task):"},{"line_number":736,"context_line":"        \"\"\"Get the current boot mode for a node."}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_6deb0f77","line":733,"in_reply_to":"bf51134e_67168eaa","updated":"2020-06-29 11:11:44.000000000","message":"No need to translate it to change it to InvalidParamaterValue as this would be runtime error from iLO.","commit_id":"92b954917dc8d636171ccb6ffa5727273d74229d"}],"releasenotes/notes/ilo-support-boot-mode-management-apis-8173002daf79894c.yaml":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"3a09b554ba91189ab94f03dd259868bad61f789f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds ``get_boot_mode``, ``set_boot_mode`` and"},{"line_number":5,"context_line":"    ``get_supported_boot_modes`` methods to management interface of ``ilo``"},{"line_number":6,"context_line":"    and ``ilo5`` hardware types."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bf51134e_90ed0cb9","line":5,"range":{"start_line":4,"start_character":9,"end_line":5,"end_character":32},"updated":"2020-06-24 17:15:54.000000000","message":"Users/Operators don\u0027t necessarily know what the internal method names represent, so it might be  good to state what is changing at a higher level. \"Adds for boot mode retrieval and setting with the ``ilo`` and ``ilo5`` hardware types.\"","commit_id":"e5fa100e463451b814d11396d5b4bf8814498024"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"2355d3da533e5c2692de1a8a2c739ec5353bd4ee","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds ``get_boot_mode``, ``set_boot_mode`` and"},{"line_number":5,"context_line":"    ``get_supported_boot_modes`` methods to management interface of ``ilo``"},{"line_number":6,"context_line":"    and ``ilo5`` hardware types."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bf51134e_b798ff74","line":5,"range":{"start_line":4,"start_character":9,"end_line":5,"end_character":32},"in_reply_to":"bf51134e_90ed0cb9","updated":"2020-06-25 05:53:50.000000000","message":"Done","commit_id":"e5fa100e463451b814d11396d5b4bf8814498024"}]}