)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"6736fb113099097721cfecbc9bc8ceea9e787b05","unresolved":false,"context_lines":[{"line_number":11,"context_line":"performed. The value of the variable \u0027enabled\u0027, instead of"},{"line_number":12,"context_line":"\u0027desired_enabled\u0027, should be used."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I26bf32c7f824e8e5ca7018d491e0bc9dc96a8671"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bf51134e_25115c05","line":14,"updated":"2020-06-25 02:13:17.000000000","message":"This change makes a small correction to the change which resolved https://storyboard.openstack.org/#!/story/2007733.\n\nI am wondering if this change should be associated with that story. If so, should a new task be added to it to account for this? I am thinking of adding something like the following to this commit message.\n\nStory: 2007733\nTask: NNNNN\n\nThoughts?","commit_id":"28083055a25d09745c8fddecd0536beab338e471"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"01694a2609303728a50f573e2c9037c9c8894f7f","unresolved":false,"context_lines":[{"line_number":11,"context_line":"performed. The value of the variable \u0027enabled\u0027, instead of"},{"line_number":12,"context_line":"\u0027desired_enabled\u0027, should be used."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I26bf32c7f824e8e5ca7018d491e0bc9dc96a8671"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bf51134e_d01b8b70","line":14,"in_reply_to":"bf51134e_25115c05","updated":"2020-07-03 04:41:58.000000000","message":"Julia Kreger suggested, \"adding a task is likely the best thing to do since it is a follow-up of sorts.\" [1]\n\nDone\n\n[1] http://eavesdrop.openstack.org/irclogs/%23openstack-ironic/%23openstack-ironic.2020-07-02.log.html#t2020-07-02T21:30:13","commit_id":"28083055a25d09745c8fddecd0536beab338e471"}],"ironic/drivers/modules/redfish/management.py":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"9535b21c52e475eef4fa0c999a5a17f529426368","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    try:"},{"line_number":91,"context_line":"        system.set_system_boot_options(device, enabled\u003denabled)"},{"line_number":92,"context_line":"    except sushy.exceptions.SushyError as e:"},{"line_number":93,"context_line":"        if enabled \u003d\u003d sushy.BOOT_SOURCE_ENABLED_CONTINUOUS:"},{"line_number":94,"context_line":"            # NOTE(dtantsur): continuous boot device settings have been"},{"line_number":95,"context_line":"            # removed from Redfish, and some vendors stopped supporting"},{"line_number":96,"context_line":"            # it before an alternative was provided. As a work around,"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_7d16c8a9","line":93,"range":{"start_line":93,"start_character":8,"end_line":93,"end_character":59},"updated":"2020-07-06 07:12:39.000000000","message":"We need to add testcase for this path when set_system_boot_options() is successful.","commit_id":"91b0f738347cdbcb87c320e80023657b1824b6a5"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"79a9e2a26fc18bc4bf77e34d5f252c87e710a4cf","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    try:"},{"line_number":91,"context_line":"        system.set_system_boot_options(device, enabled\u003denabled)"},{"line_number":92,"context_line":"    except sushy.exceptions.SushyError as e:"},{"line_number":93,"context_line":"        if enabled \u003d\u003d sushy.BOOT_SOURCE_ENABLED_CONTINUOUS:"},{"line_number":94,"context_line":"            # NOTE(dtantsur): continuous boot device settings have been"},{"line_number":95,"context_line":"            # removed from Redfish, and some vendors stopped supporting"},{"line_number":96,"context_line":"            # it before an alternative was provided. As a work around,"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_2560a0a5","line":93,"range":{"start_line":93,"start_character":8,"end_line":93,"end_character":59},"in_reply_to":"bf51134e_194a32ab","updated":"2020-07-07 10:47:59.000000000","message":"I was requesting for a testcase wherein there is an exception for set_system_boot_options() at L91 and a success for the call at L103. Does such test case exists?","commit_id":"91b0f738347cdbcb87c320e80023657b1824b6a5"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"dbd0f74c9be6b1168ce815d9f840abdf56ec15c6","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    try:"},{"line_number":91,"context_line":"        system.set_system_boot_options(device, enabled\u003denabled)"},{"line_number":92,"context_line":"    except sushy.exceptions.SushyError as e:"},{"line_number":93,"context_line":"        if enabled \u003d\u003d sushy.BOOT_SOURCE_ENABLED_CONTINUOUS:"},{"line_number":94,"context_line":"            # NOTE(dtantsur): continuous boot device settings have been"},{"line_number":95,"context_line":"            # removed from Redfish, and some vendors stopped supporting"},{"line_number":96,"context_line":"            # it before an alternative was provided. As a work around,"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_e8df9409","line":93,"range":{"start_line":93,"start_character":8,"end_line":93,"end_character":59},"in_reply_to":"bf51134e_2560a0a5","updated":"2020-07-07 21:42:19.000000000","message":"Thank you so much for clarifying, Shiv. Yes, test_set_boot_device_persistence_fallback() does exactly that.","commit_id":"91b0f738347cdbcb87c320e80023657b1824b6a5"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"587247c90184f60acdd7a00f6057fab6fcc03bba","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    try:"},{"line_number":91,"context_line":"        system.set_system_boot_options(device, enabled\u003denabled)"},{"line_number":92,"context_line":"    except sushy.exceptions.SushyError as e:"},{"line_number":93,"context_line":"        if enabled \u003d\u003d sushy.BOOT_SOURCE_ENABLED_CONTINUOUS:"},{"line_number":94,"context_line":"            # NOTE(dtantsur): continuous boot device settings have been"},{"line_number":95,"context_line":"            # removed from Redfish, and some vendors stopped supporting"},{"line_number":96,"context_line":"            # it before an alternative was provided. As a work around,"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_194a32ab","line":93,"range":{"start_line":93,"start_character":8,"end_line":93,"end_character":59},"in_reply_to":"bf51134e_7d16c8a9","updated":"2020-07-06 19:22:21.000000000","message":"I am a bit unclear on the ask. This if statement is executed when set_system_boot_options() fails and raises an exception. Regardless, I will try my best to address what is being asking for.\n\nPerhaps the comment is referring to the happy path. For that, there already exists the test case test_set_boot_device(): https://opendev.org/openstack/ironic/src/commit/3c47122f363756911f066f8cf8ecb0b1cac1335b/ironic/tests/unit/drivers/modules/redfish/test_management.py#L84-L108.\n\nThis if statement has two (2) branches based on the value of \u0027enabled\u0027. The new test case this change already adds covers when it is not equal to sushy.BOOT_SOURCE_ENABLED_CONTINUOUS, specifically when it is None. An preexisting test case, test_set_boot_device_persistence_fallback() -- https://opendev.org/openstack/ironic/src/commit/3c47122f363756911f066f8cf8ecb0b1cac1335b/ironic/tests/unit/drivers/modules/redfish/test_management.py#L180-L205 -- covers when it is equal to sushy.BOOT_SOURCE_ENABLED_CONTINUOUS.\n\nFinally, the cover job reports all of the code in this method, RedfishManagement.set_boot_device(), and RedfishManagement.restore_boot_device() is covered by the existing unit tests. See https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_b54/737892/5/check/openstack-tox-cover/b541297/cover/ironic_drivers_modules_redfish_management_py.html.\n\nPlease clarify.","commit_id":"91b0f738347cdbcb87c320e80023657b1824b6a5"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"98386aeb20f51a89619c98f9e84ebc72b66b04dd","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    try:"},{"line_number":91,"context_line":"        system.set_system_boot_options(device, enabled\u003denabled)"},{"line_number":92,"context_line":"    except sushy.exceptions.SushyError as e:"},{"line_number":93,"context_line":"        if enabled \u003d\u003d sushy.BOOT_SOURCE_ENABLED_CONTINUOUS:"},{"line_number":94,"context_line":"            # NOTE(dtantsur): continuous boot device settings have been"},{"line_number":95,"context_line":"            # removed from Redfish, and some vendors stopped supporting"},{"line_number":96,"context_line":"            # it before an alternative was provided. As a work around,"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_3d39c53e","line":93,"range":{"start_line":93,"start_character":8,"end_line":93,"end_character":59},"in_reply_to":"bf51134e_e8df9409","updated":"2020-07-08 08:09:02.000000000","message":"Thank you. This testcase covers it.","commit_id":"91b0f738347cdbcb87c320e80023657b1824b6a5"}]}