)]}'
{"ironic/tests/unit/conductor/test_manager.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a51eb33b4772d84ae7e3dc2388af3566d04b3d65","unresolved":false,"context_lines":[{"line_number":2088,"context_line":"        self.assertIsNone(node.driver_internal_info[\u0027deploy_steps\u0027])"},{"line_number":2089,"context_line":"        self.assertNotIn(\u0027root_uuid_or_disk_id\u0027, node.driver_internal_info)"},{"line_number":2090,"context_line":"        self.assertNotIn(\u0027is_whole_disk_image\u0027, node.driver_internal_info)"},{"line_number":2091,"context_line":"        mock_tear_down.assert_called_once_with(mock.ANY, task)"},{"line_number":2092,"context_line":"        mock_clean.assert_called_once_with(task)"},{"line_number":2093,"context_line":"        self.assertEqual({}, port.internal_info)"},{"line_number":2094,"context_line":"        mock_unbind.assert_called_once_with(\u0027foo\u0027, context\u003dmock.ANY)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_140eb0e4","line":2091,"updated":"2020-07-01 16:50:19.000000000","message":"nit: probably task.driver.deploy","commit_id":"c1e9e4be288f612657c6b216a941d22660fb11e4"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"aaad8449e40a9447d1b1d6a23a7f39690af2f51c","unresolved":false,"context_lines":[{"line_number":2088,"context_line":"        self.assertIsNone(node.driver_internal_info[\u0027deploy_steps\u0027])"},{"line_number":2089,"context_line":"        self.assertNotIn(\u0027root_uuid_or_disk_id\u0027, node.driver_internal_info)"},{"line_number":2090,"context_line":"        self.assertNotIn(\u0027is_whole_disk_image\u0027, node.driver_internal_info)"},{"line_number":2091,"context_line":"        mock_tear_down.assert_called_once_with(mock.ANY, task)"},{"line_number":2092,"context_line":"        mock_clean.assert_called_once_with(task)"},{"line_number":2093,"context_line":"        self.assertEqual({}, port.internal_info)"},{"line_number":2094,"context_line":"        mock_unbind.assert_called_once_with(\u0027foo\u0027, context\u003dmock.ANY)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_d49398ff","line":2091,"in_reply_to":"bf51134e_140eb0e4","updated":"2020-07-01 17:20:36.000000000","message":"ah geez I thought I changed those! :/\ntoo much stuff in here, I will do a follow up","commit_id":"c1e9e4be288f612657c6b216a941d22660fb11e4"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a51eb33b4772d84ae7e3dc2388af3566d04b3d65","unresolved":false,"context_lines":[{"line_number":2093,"context_line":"        self.assertEqual({}, port.internal_info)"},{"line_number":2094,"context_line":"        mock_unbind.assert_called_once_with(\u0027foo\u0027, context\u003dmock.ANY)"},{"line_number":2095,"context_line":"        if enabled_console:"},{"line_number":2096,"context_line":"            mock_console.assert_called_once_with(mock.ANY, task)"},{"line_number":2097,"context_line":"        else:"},{"line_number":2098,"context_line":"            self.assertFalse(mock_console.called)"},{"line_number":2099,"context_line":"        if with_allocation:"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_f4121c09","line":2096,"updated":"2020-07-01 16:50:19.000000000","message":"nit: probably task.driver.console","commit_id":"c1e9e4be288f612657c6b216a941d22660fb11e4"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a51eb33b4772d84ae7e3dc2388af3566d04b3d65","unresolved":false,"context_lines":[{"line_number":2134,"context_line":"        self.assertEqual(states.AVAILABLE, node.target_provision_state)"},{"line_number":2135,"context_line":"        self.assertIsNone(node.last_error)"},{"line_number":2136,"context_line":"        self.assertEqual({}, node.instance_info)"},{"line_number":2137,"context_line":"        mock_tear_down.assert_called_once_with(mock.ANY, mock.ANY)"},{"line_number":2138,"context_line":"        mock_clean.assert_called_once_with(mock.ANY)"},{"line_number":2139,"context_line":"        if is_rescue_state:"},{"line_number":2140,"context_line":"            mock_rescue_clean.assert_called_once_with(mock.ANY, mock.ANY)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_54f788d5","line":2137,"updated":"2020-07-01 16:50:19.000000000","message":"ditto","commit_id":"c1e9e4be288f612657c6b216a941d22660fb11e4"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a51eb33b4772d84ae7e3dc2388af3566d04b3d65","unresolved":false,"context_lines":[{"line_number":4010,"context_line":"        self.service._shutdown \u003d True"},{"line_number":4011,"context_line":"        CONF.set_override(\u0027send_sensor_data\u0027, True, group\u003d\u0027conductor\u0027)"},{"line_number":4012,"context_line":"        self.service._sensors_nodes_task(self.context, nodes)"},{"line_number":4013,"context_line":"        acquire_mock.return_value.__enter__.assert_not_called()"},{"line_number":4014,"context_line":""},{"line_number":4015,"context_line":"    @mock.patch.object(task_manager, \u0027acquire\u0027, autospec\u003dTrue)"},{"line_number":4016,"context_line":"    def test_send_sensor_task_no_management(self, acquire_mock):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_34f494cf","line":4013,"updated":"2020-07-01 16:50:19.000000000","message":"nice!","commit_id":"c1e9e4be288f612657c6b216a941d22660fb11e4"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a51eb33b4772d84ae7e3dc2388af3566d04b3d65","unresolved":false,"context_lines":[{"line_number":4313,"context_line":"        mock_valid.assert_called_once_with(mock.ANY, mock.ANY)"},{"line_number":4314,"context_line":"        mock_attach.assert_called_once_with(mock.ANY, mock.ANY, self.vif)"},{"line_number":4315,"context_line":""},{"line_number":4316,"context_line":"    @mock.patch.object(n_flat.FlatNetwork, \u0027vif_attach\u0027, autospec\u003dTrue)"},{"line_number":4317,"context_line":"    def test_vif_attach_raises_portgroup_physnet_inconsistent("},{"line_number":4318,"context_line":"            self, mock_attach, mock_valid):"},{"line_number":4319,"context_line":"        mock_valid.side_effect \u003d exception.PortgroupPhysnetInconsistent("}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_940120b3","line":4316,"updated":"2020-07-01 16:50:19.000000000","message":"SIGH :)","commit_id":"c1e9e4be288f612657c6b216a941d22660fb11e4"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"aaad8449e40a9447d1b1d6a23a7f39690af2f51c","unresolved":false,"context_lines":[{"line_number":4313,"context_line":"        mock_valid.assert_called_once_with(mock.ANY, mock.ANY)"},{"line_number":4314,"context_line":"        mock_attach.assert_called_once_with(mock.ANY, mock.ANY, self.vif)"},{"line_number":4315,"context_line":""},{"line_number":4316,"context_line":"    @mock.patch.object(n_flat.FlatNetwork, \u0027vif_attach\u0027, autospec\u003dTrue)"},{"line_number":4317,"context_line":"    def test_vif_attach_raises_portgroup_physnet_inconsistent("},{"line_number":4318,"context_line":"            self, mock_attach, mock_valid):"},{"line_number":4319,"context_line":"        mock_valid.side_effect \u003d exception.PortgroupPhysnetInconsistent("}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_548788b7","line":4316,"in_reply_to":"bf51134e_940120b3","updated":"2020-07-01 17:20:36.000000000","message":"ehm... :D","commit_id":"c1e9e4be288f612657c6b216a941d22660fb11e4"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a51eb33b4772d84ae7e3dc2388af3566d04b3d65","unresolved":false,"context_lines":[{"line_number":6012,"context_line":"        self.assertEqual(states.MANAGEABLE, node.provision_state)"},{"line_number":6013,"context_line":"        self.assertEqual(states.NOSTATE, node.target_provision_state)"},{"line_number":6014,"context_line":"        self.assertIsNone(node.last_error)"},{"line_number":6015,"context_line":"        mock_inspect.assert_called_once_with(mock.ANY, task)"},{"line_number":6016,"context_line":"        task.node.refresh()"},{"line_number":6017,"context_line":"        self.assertNotIn(\u0027agent_url\u0027, task.node.driver_internal_info)"},{"line_number":6018,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_74fe0caf","line":6015,"updated":"2020-07-01 16:50:19.000000000","message":"nit: task.driver.inspect","commit_id":"c1e9e4be288f612657c6b216a941d22660fb11e4"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"aaad8449e40a9447d1b1d6a23a7f39690af2f51c","unresolved":false,"context_lines":[{"line_number":6012,"context_line":"        self.assertEqual(states.MANAGEABLE, node.provision_state)"},{"line_number":6013,"context_line":"        self.assertEqual(states.NOSTATE, node.target_provision_state)"},{"line_number":6014,"context_line":"        self.assertIsNone(node.last_error)"},{"line_number":6015,"context_line":"        mock_inspect.assert_called_once_with(mock.ANY, task)"},{"line_number":6016,"context_line":"        task.node.refresh()"},{"line_number":6017,"context_line":"        self.assertNotIn(\u0027agent_url\u0027, task.node.driver_internal_info)"},{"line_number":6018,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_b4c1c4e7","line":6015,"in_reply_to":"bf51134e_74fe0caf","updated":"2020-07-01 17:20:36.000000000","message":"yeah, I will do one or more follow ups to review the remaining mock.ANYs","commit_id":"c1e9e4be288f612657c6b216a941d22660fb11e4"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a51eb33b4772d84ae7e3dc2388af3566d04b3d65","unresolved":false,"context_lines":[{"line_number":6031,"context_line":"        self.assertIn(\u0027driver returned unexpected state\u0027, node.last_error)"},{"line_number":6032,"context_line":"        self.assertEqual(states.INSPECTFAIL, node.provision_state)"},{"line_number":6033,"context_line":"        self.assertEqual(states.MANAGEABLE, node.target_provision_state)"},{"line_number":6034,"context_line":"        mock_inspect.assert_called_once_with(mock.ANY, task)"},{"line_number":6035,"context_line":""},{"line_number":6036,"context_line":"    @mock.patch(\u0027ironic.drivers.modules.fake.FakeInspect.inspect_hardware\u0027,"},{"line_number":6037,"context_line":"                autospec\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_d42c384c","line":6034,"updated":"2020-07-01 16:50:19.000000000","message":"ditto (and below)","commit_id":"c1e9e4be288f612657c6b216a941d22660fb11e4"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a51eb33b4772d84ae7e3dc2388af3566d04b3d65","unresolved":false,"context_lines":[{"line_number":6828,"context_line":"        node.refresh()"},{"line_number":6829,"context_line":"        self.assertIsNone(node.last_error)"},{"line_number":6830,"context_line":"        self.assertFalse(node.console_enabled)"},{"line_number":6831,"context_line":"        mock_prepare.assert_called_once_with(mock.ANY, task)"},{"line_number":6832,"context_line":"        mock_take_over.assert_called_once_with(mock.ANY, task)"},{"line_number":6833,"context_line":"        self.assertFalse(mock_start_console.called)"},{"line_number":6834,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_b431c4a5","line":6831,"updated":"2020-07-01 16:50:19.000000000","message":"nit: task.driver.deploy I suppose","commit_id":"c1e9e4be288f612657c6b216a941d22660fb11e4"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a51eb33b4772d84ae7e3dc2388af3566d04b3d65","unresolved":false,"context_lines":[{"line_number":6829,"context_line":"        self.assertIsNone(node.last_error)"},{"line_number":6830,"context_line":"        self.assertFalse(node.console_enabled)"},{"line_number":6831,"context_line":"        mock_prepare.assert_called_once_with(mock.ANY, task)"},{"line_number":6832,"context_line":"        mock_take_over.assert_called_once_with(mock.ANY, task)"},{"line_number":6833,"context_line":"        self.assertFalse(mock_start_console.called)"},{"line_number":6834,"context_line":""},{"line_number":6835,"context_line":"    @mock.patch.object(notification_utils, \u0027emit_console_notification\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_1427d066","line":6832,"updated":"2020-07-01 16:50:19.000000000","message":"similarly everywhere","commit_id":"c1e9e4be288f612657c6b216a941d22660fb11e4"}]}