)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"98529a64f21497218d86310b2d35fc55b6c6e6d7","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Richard Pioso \u003crichard.pioso@dell.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-07-02 12:34:29 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"WIP: Fix idrac HW type DevStack plug-in support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I2a69eefd51179332ec4487cf022a8254ff13b644"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bf51134e_c92a88e5","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":5},"updated":"2020-07-08 13:57:00.000000000","message":"This looks like it is in good shape, so the WIP label doesn\u0027t seem to be needed.","commit_id":"acaedf4bd02e15214712bf3f287a23877382928d"}],"devstack/lib/ironic":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"d5e4db8824fe269acf3b339af3b8ea8c468a1c16","unresolved":false,"context_lines":[{"line_number":1034,"context_line":"        git_clone_by_name \"python-dracclient\""},{"line_number":1035,"context_line":"        setup_dev_lib \"python-dracclient\""},{"line_number":1036,"context_line":"    else"},{"line_number":1037,"context_line":"    \tpip_install \"python-dracclient\""},{"line_number":1038,"context_line":"    fi"},{"line_number":1039,"context_line":"}"},{"line_number":1040,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"bf51134e_00b5bfee","line":1037,"updated":"2020-07-02 14:36:33.000000000","message":"pep8: E002 Tab indents","commit_id":"5151210dccafed7b68b1b9a88e163c2d27a38b8b"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"d5e4db8824fe269acf3b339af3b8ea8c468a1c16","unresolved":false,"context_lines":[{"line_number":1034,"context_line":"        git_clone_by_name \"python-dracclient\""},{"line_number":1035,"context_line":"        setup_dev_lib \"python-dracclient\""},{"line_number":1036,"context_line":"    else"},{"line_number":1037,"context_line":"    \tpip_install \"python-dracclient\""},{"line_number":1038,"context_line":"    fi"},{"line_number":1039,"context_line":"}"},{"line_number":1040,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"bf51134e_e0b9abe9","line":1037,"updated":"2020-07-02 14:36:33.000000000","message":"pep8: E003 Indent not multiple of 4","commit_id":"5151210dccafed7b68b1b9a88e163c2d27a38b8b"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"d5e4db8824fe269acf3b339af3b8ea8c468a1c16","unresolved":false,"context_lines":[{"line_number":1043,"context_line":"        git_clone_by_name \"sushy-oem-idrac\""},{"line_number":1044,"context_line":"        setup_dev_lib \"sushy-oem-idrac\""},{"line_number":1045,"context_line":"    else"},{"line_number":1046,"context_line":"    \tpip_install \"sushy-oem-idrac\""},{"line_number":1047,"context_line":"    fi"},{"line_number":1048,"context_line":"}"},{"line_number":1049,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"bf51134e_40ce9783","line":1046,"updated":"2020-07-02 14:36:33.000000000","message":"pep8: E002 Tab indents","commit_id":"5151210dccafed7b68b1b9a88e163c2d27a38b8b"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"d5e4db8824fe269acf3b339af3b8ea8c468a1c16","unresolved":false,"context_lines":[{"line_number":1043,"context_line":"        git_clone_by_name \"sushy-oem-idrac\""},{"line_number":1044,"context_line":"        setup_dev_lib \"sushy-oem-idrac\""},{"line_number":1045,"context_line":"    else"},{"line_number":1046,"context_line":"    \tpip_install \"sushy-oem-idrac\""},{"line_number":1047,"context_line":"    fi"},{"line_number":1048,"context_line":"}"},{"line_number":1049,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"bf51134e_20cba372","line":1046,"updated":"2020-07-02 14:36:33.000000000","message":"pep8: E003 Indent not multiple of 4","commit_id":"5151210dccafed7b68b1b9a88e163c2d27a38b8b"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"98529a64f21497218d86310b2d35fc55b6c6e6d7","unresolved":false,"context_lines":[{"line_number":1620,"context_line":"    fi"},{"line_number":1621,"context_line":""},{"line_number":1622,"context_line":"    if is_deployed_by_drac; then"},{"line_number":1623,"context_line":"        # TODO(lucasagomes): We need to make it easier to configure"},{"line_number":1624,"context_line":"        # specific driver interfaces in DevStack"},{"line_number":1625,"context_line":"        iniset $IRONIC_CONF_FILE DEFAULT enabled_bios_interfaces \"idrac-wsman,no-bios\""},{"line_number":1626,"context_line":"        iniset $IRONIC_CONF_FILE DEFAULT enabled_boot_interfaces \"ipxe,pxe,idrac-redfish-virtual-media\""}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"bf51134e_e9b4acd3","line":1623,"range":{"start_line":1623,"start_character":9,"end_line":1623,"end_character":27},"updated":"2020-07-08 13:57:00.000000000","message":"This was copied from somewhere? or is it someone elses\u0027s comment?\n\nGiven Lucas is not involved, seems a little weird for it to appear.","commit_id":"acaedf4bd02e15214712bf3f287a23877382928d"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"1bf7ec90518e2461b1beeee82d9f52f42ebc2483","unresolved":false,"context_lines":[{"line_number":1620,"context_line":"    fi"},{"line_number":1621,"context_line":""},{"line_number":1622,"context_line":"    if is_deployed_by_drac; then"},{"line_number":1623,"context_line":"        # TODO(lucasagomes): We need to make it easier to configure"},{"line_number":1624,"context_line":"        # specific driver interfaces in DevStack"},{"line_number":1625,"context_line":"        iniset $IRONIC_CONF_FILE DEFAULT enabled_bios_interfaces \"idrac-wsman,no-bios\""},{"line_number":1626,"context_line":"        iniset $IRONIC_CONF_FILE DEFAULT enabled_boot_interfaces \"ipxe,pxe,idrac-redfish-virtual-media\""}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"bf51134e_c4d1cd59","line":1623,"range":{"start_line":1623,"start_character":9,"end_line":1623,"end_character":27},"in_reply_to":"bf51134e_e9b4acd3","updated":"2020-07-08 14:26:17.000000000","message":"Yes, it was copied from the lines above, e.g., lines 1608 and 1615. I figured I would propagate that pattern, because it would be easier to find them all when we make the change the comment suggests.\n\nAnd, I fondly consider Lucas to be involved, even if he is sadly not active in ironic :)","commit_id":"acaedf4bd02e15214712bf3f287a23877382928d"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"05ba146a8401e2062762a2962d8422faf215a720","unresolved":false,"context_lines":[{"line_number":1626,"context_line":"        iniset $IRONIC_CONF_FILE DEFAULT enabled_boot_interfaces \"ipxe,pxe,idrac-redfish-virtual-media\""},{"line_number":1627,"context_line":"        iniset $IRONIC_CONF_FILE DEFAULT enabled_console_interfaces \"no-console\""},{"line_number":1628,"context_line":"        iniset $IRONIC_CONF_FILE DEFAULT enabled_deploy_interfaces \"ansible,direct,iscsi,ramdisk\""},{"line_number":1629,"context_line":"        iniset $IRONIC_CONF_FILE DEFAULT enabled_inspect_interfaces \"drac,idrac-redfish,idrac-wsman,inspector,no-inspect\""},{"line_number":1630,"context_line":"        iniset $IRONIC_CONF_FILE DEFAULT enabled_management_interfaces \"drac,idrac-redfish,idrac-wsman\""},{"line_number":1631,"context_line":"        iniset $IRONIC_CONF_FILE DEFAULT enabled_network_interfaces \"flat,neutron,noop\""},{"line_number":1632,"context_line":"        iniset $IRONIC_CONF_FILE DEFAULT enabled_power_interfaces \"drac,idrac-redfish,idrac-wsman\""}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"bf51134e_62b86010","line":1629,"range":{"start_line":1629,"start_character":69,"end_line":1629,"end_character":73},"updated":"2020-07-14 15:58:04.000000000","message":"here and below - why `drac` and not `idrac`? There is no `drac`","commit_id":"acaedf4bd02e15214712bf3f287a23877382928d"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"b21ab0de5af333b0c13c1d30fdb43b7b79451b59","unresolved":false,"context_lines":[{"line_number":1626,"context_line":"        iniset $IRONIC_CONF_FILE DEFAULT enabled_boot_interfaces \"ipxe,pxe,idrac-redfish-virtual-media\""},{"line_number":1627,"context_line":"        iniset $IRONIC_CONF_FILE DEFAULT enabled_console_interfaces \"no-console\""},{"line_number":1628,"context_line":"        iniset $IRONIC_CONF_FILE DEFAULT enabled_deploy_interfaces \"ansible,direct,iscsi,ramdisk\""},{"line_number":1629,"context_line":"        iniset $IRONIC_CONF_FILE DEFAULT enabled_inspect_interfaces \"drac,idrac-redfish,idrac-wsman,inspector,no-inspect\""},{"line_number":1630,"context_line":"        iniset $IRONIC_CONF_FILE DEFAULT enabled_management_interfaces \"drac,idrac-redfish,idrac-wsman\""},{"line_number":1631,"context_line":"        iniset $IRONIC_CONF_FILE DEFAULT enabled_network_interfaces \"flat,neutron,noop\""},{"line_number":1632,"context_line":"        iniset $IRONIC_CONF_FILE DEFAULT enabled_power_interfaces \"drac,idrac-redfish,idrac-wsman\""}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"bf51134e_25e31207","line":1629,"range":{"start_line":1629,"start_character":69,"end_line":1629,"end_character":73},"in_reply_to":"bf51134e_62b86010","updated":"2020-07-14 16:03:55.000000000","message":"Good catch! Fixed.","commit_id":"acaedf4bd02e15214712bf3f287a23877382928d"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"05ba146a8401e2062762a2962d8422faf215a720","unresolved":false,"context_lines":[{"line_number":1628,"context_line":"        iniset $IRONIC_CONF_FILE DEFAULT enabled_deploy_interfaces \"ansible,direct,iscsi,ramdisk\""},{"line_number":1629,"context_line":"        iniset $IRONIC_CONF_FILE DEFAULT enabled_inspect_interfaces \"drac,idrac-redfish,idrac-wsman,inspector,no-inspect\""},{"line_number":1630,"context_line":"        iniset $IRONIC_CONF_FILE DEFAULT enabled_management_interfaces \"drac,idrac-redfish,idrac-wsman\""},{"line_number":1631,"context_line":"        iniset $IRONIC_CONF_FILE DEFAULT enabled_network_interfaces \"flat,neutron,noop\""},{"line_number":1632,"context_line":"        iniset $IRONIC_CONF_FILE DEFAULT enabled_power_interfaces \"drac,idrac-redfish,idrac-wsman\""},{"line_number":1633,"context_line":"        iniset $IRONIC_CONF_FILE DEFAULT enabled_raid_interfaces \"drac,idrac-wsman,no-raid\""},{"line_number":1634,"context_line":"        iniset $IRONIC_CONF_FILE DEFAULT enabled_rescue_interfaces \"agent,no-rescue\""}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"bf51134e_c2384ca1","line":1631,"range":{"start_line":1631,"start_character":74,"end_line":1631,"end_character":81},"updated":"2020-07-14 15:58:04.000000000","message":"Do we need this for devstack? Currently this is failing with \n\n ironic.common.exception.DriverLoadError: Driver, hardware type or interface NeutronNetwork could not be loaded. Reason: The following [neutron] group configuration options are missing: provisioning_network","commit_id":"acaedf4bd02e15214712bf3f287a23877382928d"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"b21ab0de5af333b0c13c1d30fdb43b7b79451b59","unresolved":false,"context_lines":[{"line_number":1628,"context_line":"        iniset $IRONIC_CONF_FILE DEFAULT enabled_deploy_interfaces \"ansible,direct,iscsi,ramdisk\""},{"line_number":1629,"context_line":"        iniset $IRONIC_CONF_FILE DEFAULT enabled_inspect_interfaces \"drac,idrac-redfish,idrac-wsman,inspector,no-inspect\""},{"line_number":1630,"context_line":"        iniset $IRONIC_CONF_FILE DEFAULT enabled_management_interfaces \"drac,idrac-redfish,idrac-wsman\""},{"line_number":1631,"context_line":"        iniset $IRONIC_CONF_FILE DEFAULT enabled_network_interfaces \"flat,neutron,noop\""},{"line_number":1632,"context_line":"        iniset $IRONIC_CONF_FILE DEFAULT enabled_power_interfaces \"drac,idrac-redfish,idrac-wsman\""},{"line_number":1633,"context_line":"        iniset $IRONIC_CONF_FILE DEFAULT enabled_raid_interfaces \"drac,idrac-wsman,no-raid\""},{"line_number":1634,"context_line":"        iniset $IRONIC_CONF_FILE DEFAULT enabled_rescue_interfaces \"agent,no-rescue\""}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"bf51134e_c5bdf6d8","line":1631,"range":{"start_line":1631,"start_character":74,"end_line":1631,"end_character":81},"in_reply_to":"bf51134e_c2384ca1","updated":"2020-07-14 16:03:55.000000000","message":"For now, I suggest we leave this out. Including it would require further configuration.","commit_id":"acaedf4bd02e15214712bf3f287a23877382928d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"768b58d25d3e28d438d23c4faefb1ab13c2ab4c8","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"GITREPO[\"sushy-oem-idrac\"]\u003d${SUSHY_OEM_IDRAC_REPO:-${GIT_BASE}/x/sushy-oem-idrac.git}"},{"line_number":65,"context_line":"GITBRANCH[\"sushy-oem-idrac\"]\u003d${SUSHY_OEM_IDRAC_BRANCH:-master}"},{"line_number":66,"context_line":"GITDIR[\"sushy-oem-idrac\"]\u003d$DEST/sushy-oem-idrac"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"IRONIC_DIR\u003d$DEST/ironic"},{"line_number":69,"context_line":"IRONIC_DEVSTACK_DIR\u003d$IRONIC_DIR/devstack"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"bf51134e_6597ca46","line":66,"updated":"2020-07-14 16:08:14.000000000","message":"No objections, but I\u0027m curious why you need source installation","commit_id":"748f1f7323cef03350e30e440fbd76a4a90932ae"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"3bd92f7586e847cec3d3b4e58f010732e8227298","unresolved":false,"context_lines":[{"line_number":1622,"context_line":"    if is_deployed_by_drac; then"},{"line_number":1623,"context_line":"        # TODO(lucasagomes): We need to make it easier to configure"},{"line_number":1624,"context_line":"        # specific driver interfaces in DevStack"},{"line_number":1625,"context_line":"        iniset $IRONIC_CONF_FILE DEFAULT enabled_bios_interfaces \"idrac-wsman,no-bios\""},{"line_number":1626,"context_line":"        iniset $IRONIC_CONF_FILE DEFAULT enabled_boot_interfaces \"ipxe,pxe,idrac-redfish-virtual-media\""},{"line_number":1627,"context_line":"        iniset $IRONIC_CONF_FILE DEFAULT enabled_console_interfaces \"no-console\""},{"line_number":1628,"context_line":"        iniset $IRONIC_CONF_FILE DEFAULT enabled_deploy_interfaces \"ansible,direct,iscsi,ramdisk\""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"9f560f44_0ebfad60","line":1625,"range":{"start_line":1625,"start_character":65,"end_line":1625,"end_character":86},"updated":"2020-10-01 08:27:23.000000000","message":"now that there is `idrac-redfish` for BIOS, can add it here too","commit_id":"748f1f7323cef03350e30e440fbd76a4a90932ae"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"768b58d25d3e28d438d23c4faefb1ab13c2ab4c8","unresolved":false,"context_lines":[{"line_number":1625,"context_line":"        iniset $IRONIC_CONF_FILE DEFAULT enabled_bios_interfaces \"idrac-wsman,no-bios\""},{"line_number":1626,"context_line":"        iniset $IRONIC_CONF_FILE DEFAULT enabled_boot_interfaces \"ipxe,pxe,idrac-redfish-virtual-media\""},{"line_number":1627,"context_line":"        iniset $IRONIC_CONF_FILE DEFAULT enabled_console_interfaces \"no-console\""},{"line_number":1628,"context_line":"        iniset $IRONIC_CONF_FILE DEFAULT enabled_deploy_interfaces \"ansible,direct,iscsi,ramdisk\""},{"line_number":1629,"context_line":"        iniset $IRONIC_CONF_FILE DEFAULT enabled_inspect_interfaces \"idrac,idrac-redfish,idrac-wsman,inspector,no-inspect\""},{"line_number":1630,"context_line":"        iniset $IRONIC_CONF_FILE DEFAULT enabled_management_interfaces \"idrac,idrac-redfish,idrac-wsman\""},{"line_number":1631,"context_line":"        iniset $IRONIC_CONF_FILE DEFAULT enabled_network_interfaces \"flat,noop\""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"bf51134e_c58b361c","line":1628,"updated":"2020-07-14 16:08:14.000000000","message":"These two should not be needed, nor a few other that are not idrac-specific","commit_id":"748f1f7323cef03350e30e440fbd76a4a90932ae"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"deb8908d2e3cbd6cba93362ecf49eeedff31b3ce","unresolved":true,"context_lines":[{"line_number":1625,"context_line":"        iniset $IRONIC_CONF_FILE DEFAULT enabled_bios_interfaces \"idrac-wsman,no-bios\""},{"line_number":1626,"context_line":"        iniset $IRONIC_CONF_FILE DEFAULT enabled_boot_interfaces \"ipxe,pxe,idrac-redfish-virtual-media\""},{"line_number":1627,"context_line":"        iniset $IRONIC_CONF_FILE DEFAULT enabled_console_interfaces \"no-console\""},{"line_number":1628,"context_line":"        iniset $IRONIC_CONF_FILE DEFAULT enabled_deploy_interfaces \"ansible,direct,iscsi,ramdisk\""},{"line_number":1629,"context_line":"        iniset $IRONIC_CONF_FILE DEFAULT enabled_inspect_interfaces \"idrac,idrac-redfish,idrac-wsman,inspector,no-inspect\""},{"line_number":1630,"context_line":"        iniset $IRONIC_CONF_FILE DEFAULT enabled_management_interfaces \"idrac,idrac-redfish,idrac-wsman\""},{"line_number":1631,"context_line":"        iniset $IRONIC_CONF_FILE DEFAULT enabled_network_interfaces \"flat,noop\""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"279ff033_1263193e","line":1628,"range":{"start_line":1628,"start_character":68,"end_line":1628,"end_character":96},"updated":"2021-05-24 13:45:28.000000000","message":"at this stage iscsi is gone, and there is new deploy interface. Maybe don\u0027t need to specify these as they are not idrac hw type specific to avoid keeping this in sync?","commit_id":"748f1f7323cef03350e30e440fbd76a4a90932ae"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"400052d4aced65180708cc26019219157fa81b8a","unresolved":true,"context_lines":[{"line_number":1630,"context_line":"        iniset $IRONIC_CONF_FILE DEFAULT enabled_management_interfaces \"idrac,idrac-redfish,idrac-wsman\""},{"line_number":1631,"context_line":"        iniset $IRONIC_CONF_FILE DEFAULT enabled_network_interfaces \"flat,noop\""},{"line_number":1632,"context_line":"        iniset $IRONIC_CONF_FILE DEFAULT enabled_power_interfaces \"idrac,idrac-redfish,idrac-wsman\""},{"line_number":1633,"context_line":"        iniset $IRONIC_CONF_FILE DEFAULT enabled_raid_interfaces \"idrac,idrac-wsman,no-raid\""},{"line_number":1634,"context_line":"        iniset $IRONIC_CONF_FILE DEFAULT enabled_rescue_interfaces \"agent,no-rescue\""},{"line_number":1635,"context_line":"        iniset $IRONIC_CONF_FILE DEFAULT enabled_storage_interfaces \"cinder,external,noop\""},{"line_number":1636,"context_line":"        iniset $IRONIC_CONF_FILE DEFAULT enabled_vendor_interfaces \"idrac,idrac-wsman,no-vendor\""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"3475993d_adc59c4e","line":1633,"range":{"start_line":1633,"start_character":66,"end_line":1633,"end_character":91},"updated":"2021-03-24 11:18:02.000000000","message":"can now add idrac-redfish to RAID too","commit_id":"748f1f7323cef03350e30e440fbd76a4a90932ae"}]}