)]}'
{"ironic/drivers/modules/image_utils.py":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"9518df999b0c4d8d17fc03e90edba3c32fe33422","unresolved":false,"context_lines":[{"line_number":394,"context_line":"    :param task: a TaskManager instance containing the node to act on."},{"line_number":395,"context_line":"    :param params: a dictionary containing \u0027parameter name\u0027-\u003e\u0027value\u0027"},{"line_number":396,"context_line":"        mapping to be passed to kernel command line."},{"line_number":397,"context_line":"    :param mode: either \u0027deploy\u0027 or \u0027rescue\u0027."},{"line_number":398,"context_line":"    :returns: bootable ISO HTTP URL."},{"line_number":399,"context_line":"    :raises: MissingParameterValue, if any of the required parameters are"},{"line_number":400,"context_line":"        missing."}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_664e69c2","line":397,"range":{"start_line":397,"start_character":4,"end_line":397,"end_character":45},"updated":"2020-08-13 06:39:34.000000000","message":"Add d_info into param list here.","commit_id":"50ff7ccc322315a276b4f5fe1dff3c772368e875"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"2b7ff11f1b94e52382052fe92a97758aaace43fb","unresolved":false,"context_lines":[{"line_number":394,"context_line":"    :param task: a TaskManager instance containing the node to act on."},{"line_number":395,"context_line":"    :param params: a dictionary containing \u0027parameter name\u0027-\u003e\u0027value\u0027"},{"line_number":396,"context_line":"        mapping to be passed to kernel command line."},{"line_number":397,"context_line":"    :param mode: either \u0027deploy\u0027 or \u0027rescue\u0027."},{"line_number":398,"context_line":"    :returns: bootable ISO HTTP URL."},{"line_number":399,"context_line":"    :raises: MissingParameterValue, if any of the required parameters are"},{"line_number":400,"context_line":"        missing."}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_8405dec4","line":397,"range":{"start_line":397,"start_character":4,"end_line":397,"end_character":45},"in_reply_to":"9f560f44_664e69c2","updated":"2020-08-24 10:21:35.000000000","message":"Done","commit_id":"50ff7ccc322315a276b4f5fe1dff3c772368e875"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"9518df999b0c4d8d17fc03e90edba3c32fe33422","unresolved":false,"context_lines":[{"line_number":455,"context_line":"    Push produced ISO image up to Glance and return temporary Swift"},{"line_number":456,"context_line":"    URL to the image."},{"line_number":457,"context_line":""},{"line_number":458,"context_line":"    :param task: a TaskManager instance containing the node to act on."},{"line_number":459,"context_line":"    :returns: bootable ISO HTTP URL."},{"line_number":460,"context_line":"    :raises: MissingParameterValue, if any of the required parameters are"},{"line_number":461,"context_line":"        missing."}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_a6c5210d","line":458,"range":{"start_line":458,"start_character":4,"end_line":458,"end_character":17},"updated":"2020-08-13 06:39:34.000000000","message":"Add d_info and root_uuid params here.","commit_id":"50ff7ccc322315a276b4f5fe1dff3c772368e875"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"2b7ff11f1b94e52382052fe92a97758aaace43fb","unresolved":false,"context_lines":[{"line_number":455,"context_line":"    Push produced ISO image up to Glance and return temporary Swift"},{"line_number":456,"context_line":"    URL to the image."},{"line_number":457,"context_line":""},{"line_number":458,"context_line":"    :param task: a TaskManager instance containing the node to act on."},{"line_number":459,"context_line":"    :returns: bootable ISO HTTP URL."},{"line_number":460,"context_line":"    :raises: MissingParameterValue, if any of the required parameters are"},{"line_number":461,"context_line":"        missing."}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_2467b2b9","line":458,"range":{"start_line":458,"start_character":4,"end_line":458,"end_character":17},"in_reply_to":"9f560f44_a6c5210d","updated":"2020-08-24 10:21:35.000000000","message":"Done","commit_id":"50ff7ccc322315a276b4f5fe1dff3c772368e875"}],"ironic/tests/unit/drivers/modules/test_image_utils.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"1b3a26d616278cacd23169a04cb36869a1a73d46","unresolved":false,"context_lines":[{"line_number":365,"context_line":"    @mock.patch.object(image_utils, \u0027_prepare_iso_image\u0027, autospec\u003dTrue)"},{"line_number":366,"context_line":"    @mock.patch.object(images, \u0027create_boot_iso\u0027, autospec\u003dTrue)"},{"line_number":367,"context_line":"    def test_prepare_boot_iso(self, mock_create_boot_iso,"},{"line_number":368,"context_line":"                               mock__prepare_iso_image):"},{"line_number":369,"context_line":"        with task_manager.acquire(self.context, self.node.uuid,"},{"line_number":370,"context_line":"                                  shared\u003dTrue) as task:"},{"line_number":371,"context_line":"            d_info \u003d {"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_0e5be686","line":368,"updated":"2020-07-24 09:33:40.000000000","message":"pep8: E127 continuation line over-indented for visual indent","commit_id":"e88fa3b11ccdb180846de3d3a494d7c2f916c8e2"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"1b3a26d616278cacd23169a04cb36869a1a73d46","unresolved":false,"context_lines":[{"line_number":386,"context_line":""},{"line_number":387,"context_line":"            mock__prepare_iso_image.assert_called_once_with("},{"line_number":388,"context_line":"                mock.ANY, \u0027http://kernel/img\u0027, \u0027http://ramdisk/img\u0027,"},{"line_number":389,"context_line":"                \u0027bootloader\u0027, root_uuid\u003dtask.node.uuid, base_iso\u003d\u0027/path/to/baseiso\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_ee5dd279","line":389,"updated":"2020-07-24 09:33:40.000000000","message":"pep8: E501 line too long (84 \u003e 79 characters)","commit_id":"e88fa3b11ccdb180846de3d3a494d7c2f916c8e2"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"9518df999b0c4d8d17fc03e90edba3c32fe33422","unresolved":false,"context_lines":[{"line_number":364,"context_line":""},{"line_number":365,"context_line":"    @mock.patch.object(image_utils, \u0027_prepare_iso_image\u0027, autospec\u003dTrue)"},{"line_number":366,"context_line":"    @mock.patch.object(images, \u0027create_boot_iso\u0027, autospec\u003dTrue)"},{"line_number":367,"context_line":"    def test_prepare_boot_iso(self, mock_create_boot_iso,"},{"line_number":368,"context_line":"                              mock__prepare_iso_image):"},{"line_number":369,"context_line":"        with task_manager.acquire(self.context, self.node.uuid,"},{"line_number":370,"context_line":"                                  shared\u003dTrue) as task:"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_4117cfee","line":367,"range":{"start_line":367,"start_character":8,"end_line":367,"end_character":29},"updated":"2020-08-13 06:39:34.000000000","message":"There is an additional testcase test__prepare_boot_iso_user_supplied() in https://review.opendev.org/#/c/739174/7/ironic/tests/unit/drivers/modules/redfish/test_boot.py that needs to be copied here,","commit_id":"50ff7ccc322315a276b4f5fe1dff3c772368e875"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"2b7ff11f1b94e52382052fe92a97758aaace43fb","unresolved":false,"context_lines":[{"line_number":364,"context_line":""},{"line_number":365,"context_line":"    @mock.patch.object(image_utils, \u0027_prepare_iso_image\u0027, autospec\u003dTrue)"},{"line_number":366,"context_line":"    @mock.patch.object(images, \u0027create_boot_iso\u0027, autospec\u003dTrue)"},{"line_number":367,"context_line":"    def test_prepare_boot_iso(self, mock_create_boot_iso,"},{"line_number":368,"context_line":"                              mock__prepare_iso_image):"},{"line_number":369,"context_line":"        with task_manager.acquire(self.context, self.node.uuid,"},{"line_number":370,"context_line":"                                  shared\u003dTrue) as task:"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_04f9cec6","line":367,"range":{"start_line":367,"start_character":8,"end_line":367,"end_character":29},"in_reply_to":"9f560f44_4117cfee","updated":"2020-08-24 10:21:35.000000000","message":"Done","commit_id":"50ff7ccc322315a276b4f5fe1dff3c772368e875"}],"releasenotes/notes/refactor_iso_creation-8a20caf848346f66.yaml":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"9518df999b0c4d8d17fc03e90edba3c32fe33422","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Currently the ISO creation logic is embedded in the redfish boot interface"},{"line_number":5,"context_line":"    implementation. This needs to be moved to a common place so that the code"},{"line_number":6,"context_line":"    can be levereged when needed by other drivers."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9f560f44_e1db834c","line":6,"range":{"start_line":1,"start_character":1,"end_line":6,"end_character":50},"updated":"2020-08-13 06:39:34.000000000","message":"I dont think release notes are required for this change. This is more of internal restructuring and users need not be aware of it.","commit_id":"50ff7ccc322315a276b4f5fe1dff3c772368e875"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"2b7ff11f1b94e52382052fe92a97758aaace43fb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Currently the ISO creation logic is embedded in the redfish boot interface"},{"line_number":5,"context_line":"    implementation. This needs to be moved to a common place so that the code"},{"line_number":6,"context_line":"    can be levereged when needed by other drivers."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9f560f44_64d88a52","line":6,"range":{"start_line":1,"start_character":1,"end_line":6,"end_character":50},"in_reply_to":"9f560f44_44af6f29","updated":"2020-08-24 10:21:35.000000000","message":"Thanks Shiv and Julia. I am going to remove this.","commit_id":"50ff7ccc322315a276b4f5fe1dff3c772368e875"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"b1467dc54d2a9980fd0b38e9b91f2ddf84717885","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Currently the ISO creation logic is embedded in the redfish boot interface"},{"line_number":5,"context_line":"    implementation. This needs to be moved to a common place so that the code"},{"line_number":6,"context_line":"    can be levereged when needed by other drivers."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9f560f44_44af6f29","line":6,"range":{"start_line":1,"start_character":1,"end_line":6,"end_character":50},"in_reply_to":"9f560f44_e1db834c","updated":"2020-08-20 19:55:22.000000000","message":"I concur, if anything is mentioned for this in a release note, it should likely be the other seciton to indicate that it has been changed to make it easier to re-use.","commit_id":"50ff7ccc322315a276b4f5fe1dff3c772368e875"}]}