)]}'
{"ironic/drivers/modules/ilo/management.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"81685e9aaa93a1255f8e6dae74cc607694c1efa3","unresolved":false,"context_lines":[{"line_number":535,"context_line":""},{"line_number":536,"context_line":"    @METRICS.timer(\u0027IloManagement.update_firmware_sum\u0027)"},{"line_number":537,"context_line":"    @base.deploy_step(priority\u003d0, argsinfo\u003d_FIRMWARE_UPDATE_SUM_ARGSINFO)"},{"line_number":538,"context_line":"    def flash_firmware_sum(self, task, **kwargs):"},{"line_number":539,"context_line":"        \"\"\"Deploy step to Update the firmware using Smart Update Manager (SUM)."},{"line_number":540,"context_line":""},{"line_number":541,"context_line":"        :param task: a TaskManager object."}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_59fc246f","line":538,"updated":"2020-08-07 13:56:04.000000000","message":"Why not use the same function with the same name is a deploy step?","commit_id":"1e89ee5739ec7e783182af9e54280c10ab7a8338"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"0a5d5f8c1184b5fa0cc781e1981450dcd25c50bc","unresolved":false,"context_lines":[{"line_number":535,"context_line":""},{"line_number":536,"context_line":"    @METRICS.timer(\u0027IloManagement.update_firmware_sum\u0027)"},{"line_number":537,"context_line":"    @base.deploy_step(priority\u003d0, argsinfo\u003d_FIRMWARE_UPDATE_SUM_ARGSINFO)"},{"line_number":538,"context_line":"    def flash_firmware_sum(self, task, **kwargs):"},{"line_number":539,"context_line":"        \"\"\"Deploy step to Update the firmware using Smart Update Manager (SUM)."},{"line_number":540,"context_line":""},{"line_number":541,"context_line":"        :param task: a TaskManager object."}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_54c341ed","line":538,"in_reply_to":"9f560f44_59fc246f","updated":"2020-08-08 08:54:35.000000000","message":"It was more to do with the arguments being passed. For clean step we do not pass anything to the agent. It reads data from \u0027clean_step\u0027 of node object. This was done inline with apply_configuration() step added to RAID interface instead of leveraging create_configuration().","commit_id":"1e89ee5739ec7e783182af9e54280c10ab7a8338"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"81685e9aaa93a1255f8e6dae74cc607694c1efa3","unresolved":false,"context_lines":[{"line_number":559,"context_line":"        \"\"\""},{"line_number":560,"context_line":"        node \u003d task.node"},{"line_number":561,"context_line":"        step \u003d (task.node.clean_step if step_type \u003d\u003d \u0027clean\u0027 else"},{"line_number":562,"context_line":"                task.node.deploy_step)"},{"line_number":563,"context_line":""},{"line_number":564,"context_line":"        # The arguments are validated and sent to the ProliantHardwareManager"},{"line_number":565,"context_line":"        # to perform SUM based firmware update clean step."}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_39f7b08d","line":562,"updated":"2020-08-07 13:56:04.000000000","message":"You could detect this from task.node.provision_state instead","commit_id":"1e89ee5739ec7e783182af9e54280c10ab7a8338"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"0a5d5f8c1184b5fa0cc781e1981450dcd25c50bc","unresolved":false,"context_lines":[{"line_number":559,"context_line":"        \"\"\""},{"line_number":560,"context_line":"        node \u003d task.node"},{"line_number":561,"context_line":"        step \u003d (task.node.clean_step if step_type \u003d\u003d \u0027clean\u0027 else"},{"line_number":562,"context_line":"                task.node.deploy_step)"},{"line_number":563,"context_line":""},{"line_number":564,"context_line":"        # The arguments are validated and sent to the ProliantHardwareManager"},{"line_number":565,"context_line":"        # to perform SUM based firmware update clean step."}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_b4445d75","line":562,"in_reply_to":"9f560f44_39f7b08d","updated":"2020-08-08 08:54:35.000000000","message":"Done","commit_id":"1e89ee5739ec7e783182af9e54280c10ab7a8338"}]}