)]}'
{"ironic/drivers/modules/agent.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"19dee181182d094367cef1a1f0e784c61ddfbe98","unresolved":false,"context_lines":[{"line_number":633,"context_line":"        :returns: A list of deploy step dictionaries"},{"line_number":634,"context_line":"        \"\"\""},{"line_number":635,"context_line":"        return agent_base.get_steps(task, \u0027deploy\u0027, interface\u003d\u0027raid\u0027)"},{"line_number":636,"context_line":""},{"line_number":637,"context_line":"    def apply_configuration(self, task, raid_config, create_root_volume\u003dTrue,"},{"line_number":638,"context_line":"                            create_nonroot_volumes\u003dTrue,"},{"line_number":639,"context_line":"                            delete_existing\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_2da2744c","line":636,"updated":"2020-07-21 15:13:25.000000000","message":"Did you want to add a deploy step decorator?","commit_id":"c54c70c28400c68d70aba72154606e9b36350db7"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"cad26bb57b7f54a9a13ca29c7343ddfb10b4660e","unresolved":false,"context_lines":[{"line_number":633,"context_line":"        :returns: A list of deploy step dictionaries"},{"line_number":634,"context_line":"        \"\"\""},{"line_number":635,"context_line":"        return agent_base.get_steps(task, \u0027deploy\u0027, interface\u003d\u0027raid\u0027)"},{"line_number":636,"context_line":""},{"line_number":637,"context_line":"    def apply_configuration(self, task, raid_config, create_root_volume\u003dTrue,"},{"line_number":638,"context_line":"                            create_nonroot_volumes\u003dTrue,"},{"line_number":639,"context_line":"                            delete_existing\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_b0fd37b3","line":636,"in_reply_to":"bf51134e_2da2744c","updated":"2020-07-21 15:35:57.000000000","message":"Oops..","commit_id":"c54c70c28400c68d70aba72154606e9b36350db7"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"19dee181182d094367cef1a1f0e784c61ddfbe98","unresolved":false,"context_lines":[{"line_number":634,"context_line":"        \"\"\""},{"line_number":635,"context_line":"        return agent_base.get_steps(task, \u0027deploy\u0027, interface\u003d\u0027raid\u0027)"},{"line_number":636,"context_line":""},{"line_number":637,"context_line":"    def apply_configuration(self, task, raid_config, create_root_volume\u003dTrue,"},{"line_number":638,"context_line":"                            create_nonroot_volumes\u003dTrue,"},{"line_number":639,"context_line":"                            delete_existing\u003dTrue):"},{"line_number":640,"context_line":"        \"\"\"Applies RAID configuration on the given node."},{"line_number":641,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_cdfbf844","line":638,"range":{"start_line":637,"start_character":53,"end_line":638,"end_character":56},"updated":"2020-07-21 15:13:25.000000000","message":"create_root_volume and create_nonroot_volume do not exist for software RAID","commit_id":"c54c70c28400c68d70aba72154606e9b36350db7"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"cad26bb57b7f54a9a13ca29c7343ddfb10b4660e","unresolved":false,"context_lines":[{"line_number":634,"context_line":"        \"\"\""},{"line_number":635,"context_line":"        return agent_base.get_steps(task, \u0027deploy\u0027, interface\u003d\u0027raid\u0027)"},{"line_number":636,"context_line":""},{"line_number":637,"context_line":"    def apply_configuration(self, task, raid_config, create_root_volume\u003dTrue,"},{"line_number":638,"context_line":"                            create_nonroot_volumes\u003dTrue,"},{"line_number":639,"context_line":"                            delete_existing\u003dTrue):"},{"line_number":640,"context_line":"        \"\"\"Applies RAID configuration on the given node."},{"line_number":641,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_f0be8fd2","line":638,"range":{"start_line":637,"start_character":53,"end_line":638,"end_character":56},"in_reply_to":"bf51134e_cdfbf844","updated":"2020-07-21 15:35:57.000000000","message":"These are optional params as in create_configuration().","commit_id":"c54c70c28400c68d70aba72154606e9b36350db7"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3a08f9d189a9ab88acd302ca8f5423c88bf44495","unresolved":false,"context_lines":[{"line_number":634,"context_line":"        \"\"\""},{"line_number":635,"context_line":"        return agent_base.get_steps(task, \u0027deploy\u0027, interface\u003d\u0027raid\u0027)"},{"line_number":636,"context_line":""},{"line_number":637,"context_line":"    def apply_configuration(self, task, raid_config, create_root_volume\u003dTrue,"},{"line_number":638,"context_line":"                            create_nonroot_volumes\u003dTrue,"},{"line_number":639,"context_line":"                            delete_existing\u003dTrue):"},{"line_number":640,"context_line":"        \"\"\"Applies RAID configuration on the given node."},{"line_number":641,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_b04377af","line":638,"range":{"start_line":637,"start_character":53,"end_line":638,"end_character":56},"in_reply_to":"bf51134e_f0be8fd2","updated":"2020-07-21 15:40:01.000000000","message":"Right, but they shouldn\u0027t be present here if we don\u0027t support them.","commit_id":"c54c70c28400c68d70aba72154606e9b36350db7"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"44d09cff181ff034976cd3b5cb479bc0fc7cf8f8","unresolved":false,"context_lines":[{"line_number":635,"context_line":"        return agent_base.get_steps(task, \u0027deploy\u0027, interface\u003d\u0027raid\u0027)"},{"line_number":636,"context_line":""},{"line_number":637,"context_line":"    @METRICS.timer(\u0027AgentRAID.apply_configuration\u0027)"},{"line_number":638,"context_line":"    @base.deploy_step(priority\u003d0)"},{"line_number":639,"context_line":"    def apply_configuration(self, task, raid_config, create_root_volume\u003dTrue,"},{"line_number":640,"context_line":"                            create_nonroot_volumes\u003dTrue,"},{"line_number":641,"context_line":"                            delete_existing\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_d01f0bb5","line":638,"updated":"2020-07-21 15:41:00.000000000","message":"I don\u0027t remember for sure, but I think you need to declare arguments here.","commit_id":"17efc55a97cd8282150abb9075500d63e742c780"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"48aba2d72ddfa1df982ab27ef436f37d949deb40","unresolved":false,"context_lines":[{"line_number":635,"context_line":"        return agent_base.get_steps(task, \u0027deploy\u0027, interface\u003d\u0027raid\u0027)"},{"line_number":636,"context_line":""},{"line_number":637,"context_line":"    @METRICS.timer(\u0027AgentRAID.apply_configuration\u0027)"},{"line_number":638,"context_line":"    @base.deploy_step(priority\u003d0)"},{"line_number":639,"context_line":"    def apply_configuration(self, task, raid_config, create_root_volume\u003dTrue,"},{"line_number":640,"context_line":"                            create_nonroot_volumes\u003dTrue,"},{"line_number":641,"context_line":"                            delete_existing\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_23ae0398","line":638,"in_reply_to":"bf51134e_d01f0bb5","updated":"2020-07-21 16:19:38.000000000","message":"Done","commit_id":"17efc55a97cd8282150abb9075500d63e742c780"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"44d09cff181ff034976cd3b5cb479bc0fc7cf8f8","unresolved":false,"context_lines":[{"line_number":643,"context_line":""},{"line_number":644,"context_line":"        :param task: A TaskManager instance."},{"line_number":645,"context_line":"        :param raid_config: The RAID configuration to apply."},{"line_number":646,"context_line":"        :param create_root_volume: Setting this to False indicates"},{"line_number":647,"context_line":"            not to create root volume that is specified in raid_config."},{"line_number":648,"context_line":"            Default value is True."},{"line_number":649,"context_line":"        :param create_nonroot_volumes: Setting this to False indicates"},{"line_number":650,"context_line":"            not to create non-root volumes (all except the root volume) in"},{"line_number":651,"context_line":"            raid_config.  Default value is True."},{"line_number":652,"context_line":"        :param delete_existing: Setting this to True indicates to delete RAID"},{"line_number":653,"context_line":"            configuration prior to creating the new configuration."},{"line_number":654,"context_line":"        :raises: InvalidParameterValue, if the RAID configuration is invalid."}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_b01c17c2","line":651,"range":{"start_line":646,"start_character":0,"end_line":651,"end_character":48},"updated":"2020-07-21 15:41:00.000000000","message":"These arguments do nothing for software RAID, let\u0027s remove them","commit_id":"17efc55a97cd8282150abb9075500d63e742c780"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"48aba2d72ddfa1df982ab27ef436f37d949deb40","unresolved":false,"context_lines":[{"line_number":643,"context_line":""},{"line_number":644,"context_line":"        :param task: A TaskManager instance."},{"line_number":645,"context_line":"        :param raid_config: The RAID configuration to apply."},{"line_number":646,"context_line":"        :param create_root_volume: Setting this to False indicates"},{"line_number":647,"context_line":"            not to create root volume that is specified in raid_config."},{"line_number":648,"context_line":"            Default value is True."},{"line_number":649,"context_line":"        :param create_nonroot_volumes: Setting this to False indicates"},{"line_number":650,"context_line":"            not to create non-root volumes (all except the root volume) in"},{"line_number":651,"context_line":"            raid_config.  Default value is True."},{"line_number":652,"context_line":"        :param delete_existing: Setting this to True indicates to delete RAID"},{"line_number":653,"context_line":"            configuration prior to creating the new configuration."},{"line_number":654,"context_line":"        :raises: InvalidParameterValue, if the RAID configuration is invalid."}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_83926f57","line":651,"range":{"start_line":646,"start_character":0,"end_line":651,"end_character":48},"in_reply_to":"bf51134e_b01c17c2","updated":"2020-07-21 16:19:38.000000000","message":"Done","commit_id":"17efc55a97cd8282150abb9075500d63e742c780"}]}