)]}'
{"ironic/conductor/manager.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5c0205dfc956a3e1cf722cf3953233fd80bdf998","unresolved":false,"context_lines":[{"line_number":1481,"context_line":"                    #             at the same time."},{"line_number":1482,"context_line":"                    # NOTE(dtantsur): it\u0027s also pointless (and dangerous) to"},{"line_number":1483,"context_line":"                    # sync power state when a power action is in progress"},{"line_number":1484,"context_line":"                    print(task.node.provision_state)"},{"line_number":1485,"context_line":"                    if (task.node.provision_state in SYNC_EXCLUDED_STATES"},{"line_number":1486,"context_line":"                            or task.node.maintenance"},{"line_number":1487,"context_line":"                            or task.node.target_power_state"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_051c8c10","line":1484,"updated":"2020-07-30 09:24:37.000000000","message":"Should be removed","commit_id":"2c0ed8232b6916fce66765326945a4ab5254bc05"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"d75693992119da40e562c97e527607bce0936600","unresolved":false,"context_lines":[{"line_number":1766,"context_line":"                     \u0027%(err)s.\u0027) % {\u0027node\u0027: node.uuid, \u0027err\u0027: err})"},{"line_number":1767,"context_line":"            LOG.error(msg)"},{"line_number":1768,"context_line":"            # Wipe power state from being preserved as it is likely invalid."},{"line_number":1769,"context_line":"            node.power_state \u003d states.NOSTATE"},{"line_number":1770,"context_line":"            node.last_error \u003d msg"},{"line_number":1771,"context_line":"            task.process_event(\u0027fail\u0027)"},{"line_number":1772,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_716793ea","line":1769,"range":{"start_line":1769,"start_character":12,"end_line":1769,"end_character":45},"updated":"2020-08-06 16:21:43.000000000","message":"One thing I am not clear is that we will clear power state when adopt failed, so _in theory_ there should be no actual power actions following?","commit_id":"01345082661b4f34275bdd6feeea6d73972c50be"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"29ee657a60cc31d2023074b85d26f9db7eac59d1","unresolved":false,"context_lines":[{"line_number":1766,"context_line":"                     \u0027%(err)s.\u0027) % {\u0027node\u0027: node.uuid, \u0027err\u0027: err})"},{"line_number":1767,"context_line":"            LOG.error(msg)"},{"line_number":1768,"context_line":"            # Wipe power state from being preserved as it is likely invalid."},{"line_number":1769,"context_line":"            node.power_state \u003d states.NOSTATE"},{"line_number":1770,"context_line":"            node.last_error \u003d msg"},{"line_number":1771,"context_line":"            task.process_event(\u0027fail\u0027)"},{"line_number":1772,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_92501b0d","line":1769,"range":{"start_line":1769,"start_character":12,"end_line":1769,"end_character":45},"in_reply_to":"9f560f44_716793ea","updated":"2020-08-12 19:55:14.000000000","message":"This just completely excludes the nodes from being in the loop to be considered or it\u0027s present state recorded. Realistically, that is what we\u0027re trying to avoid.","commit_id":"01345082661b4f34275bdd6feeea6d73972c50be"}],"ironic/tests/unit/conductor/test_manager.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5c0205dfc956a3e1cf722cf3953233fd80bdf998","unresolved":false,"context_lines":[{"line_number":5261,"context_line":"        # 6th node: Disappears after getting nodeinfo list"},{"line_number":5262,"context_line":"        # 7th node: Should acquire and try to sync"},{"line_number":5263,"context_line":"        # 8th node: do_sync_power_state raises NodeLocked"},{"line_number":5264,"context_line":"        # 9th node: In ADOPTFAIL provision_state"},{"line_number":5265,"context_line":"        nodes \u003d []"},{"line_number":5266,"context_line":"        node_attrs \u003d {}"},{"line_number":5267,"context_line":"        mapped_map \u003d {}"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_e516b8f1","line":5264,"updated":"2020-07-30 09:24:37.000000000","message":"I think you forgot to create the 9th node","commit_id":"2c0ed8232b6916fce66765326945a4ab5254bc05"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"2bbeb35265bd4c6ef94bf34305e1d58391d8c311","unresolved":false,"context_lines":[{"line_number":5261,"context_line":"        # 6th node: Disappears after getting nodeinfo list"},{"line_number":5262,"context_line":"        # 7th node: Should acquire and try to sync"},{"line_number":5263,"context_line":"        # 8th node: do_sync_power_state raises NodeLocked"},{"line_number":5264,"context_line":"        # 9th node: In ADOPTFAIL provision_state"},{"line_number":5265,"context_line":"        nodes \u003d []"},{"line_number":5266,"context_line":"        node_attrs \u003d {}"},{"line_number":5267,"context_line":"        mapped_map \u003d {}"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_220ce639","line":5264,"in_reply_to":"9f560f44_e516b8f1","updated":"2020-08-03 20:58:55.000000000","message":"Oh, doh! I headed down this path then I remembered how many braincells ran away when I last touched this job and backed away.","commit_id":"2c0ed8232b6916fce66765326945a4ab5254bc05"}]}