)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"7bd52b8d3988018cce1c91fbe7168f28ded2cf68","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Enhance certificate verification for ilo harware type"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch enhance certificate verification for hardware"},{"line_number":10,"context_line":"type ilo by adding attribute ilo_verify_ca which can take"},{"line_number":11,"context_line":"directory and bolean values apart from file."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ic48bf53097635498a8461be049ee5d2a50c6fe2a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9f560f44_17f162ce","line":10,"range":{"start_line":10,"start_character":5,"end_line":10,"end_character":8},"updated":"2020-07-30 06:26:17.000000000","message":"its applicable to \u0027ilo5\u0027 hardware type as well.","commit_id":"c27357af9d0626fb855d0222a25b87853a3f4ea4"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"31610146d5b3645fe323dc273ccb491bb17e151a","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Enhance certificate verification for ilo harware type"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch enhance certificate verification for hardware"},{"line_number":10,"context_line":"type ilo by adding attribute ilo_verify_ca which can take"},{"line_number":11,"context_line":"directory and bolean values apart from file."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ic48bf53097635498a8461be049ee5d2a50c6fe2a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9f560f44_86198f23","line":10,"range":{"start_line":10,"start_character":5,"end_line":10,"end_character":8},"in_reply_to":"9f560f44_17f162ce","updated":"2020-08-03 11:51:58.000000000","message":"Done","commit_id":"c27357af9d0626fb855d0222a25b87853a3f4ea4"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"8c3d08ff34d9bea11203070a03bb4b752d2e7888","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Enhance certificate verification for ilo harware type"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch enhance certificate verification for hardware"},{"line_number":10,"context_line":"type ilo and ilo5 by adding attribute ilo_verify_ca which can take"},{"line_number":11,"context_line":"directory and bolean values apart from file."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ic48bf53097635498a8461be049ee5d2a50c6fe2a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9f560f44_4066d652","line":10,"range":{"start_line":10,"start_character":38,"end_line":10,"end_character":51},"updated":"2020-08-27 07:31:04.000000000","message":"s/ ilo_verify_ca / verify_ca /","commit_id":"78f5629ca65a4f44d80b174ca252613262c8706f"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"8956bc1e0f099b32c35c71054ec06b6c13cc1aac","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Enhance certificate verification for ilo harware type"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch enhance certificate verification for hardware"},{"line_number":10,"context_line":"type ilo and ilo5 by adding attribute ilo_verify_ca which can take"},{"line_number":11,"context_line":"directory and bolean values apart from file."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ic48bf53097635498a8461be049ee5d2a50c6fe2a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9f560f44_9c52e5dd","line":10,"range":{"start_line":10,"start_character":38,"end_line":10,"end_character":51},"in_reply_to":"9f560f44_4066d652","updated":"2020-08-31 09:16:42.000000000","message":"Done","commit_id":"78f5629ca65a4f44d80b174ca252613262c8706f"}],"ironic/conf/ilo.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7dda6bdce7e79efe0569bbbdbf6704dc7416d568","unresolved":false,"context_lines":[{"line_number":78,"context_line":"                      \u0027approx. 30 seconds to complete sanitize disk erase.\u0027)),"},{"line_number":79,"context_line":"    cfg.StrOpt(\u0027ca_file\u0027,"},{"line_number":80,"context_line":"               help\u003d_(\u0027CA certificate file to validate iLO.\u0027)),"},{"line_number":81,"context_line":"    cfg.StrOpt(\u0027ilo_verify_ca\u0027,"},{"line_number":82,"context_line":"               default\u003dTrue,"},{"line_number":83,"context_line":"               help\u003d_(\u0027CA certificate to validate iLO. This can be either \u0027"},{"line_number":84,"context_line":"                      \u0027a Boolean value, a path to a CA_BUNDLE file or \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_4d22ebba","line":81,"range":{"start_line":81,"start_character":16,"end_line":81,"end_character":20},"updated":"2020-08-21 07:55:12.000000000","message":"Please remove ilo_, you\u0027re already in the \"ilo\" section.","commit_id":"9a946168ee830f077333980b4f11cb2a404648c6"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"1e84899f065aa3e6958fb5ca74a8970eb1fe3d9a","unresolved":false,"context_lines":[{"line_number":78,"context_line":"                      \u0027approx. 30 seconds to complete sanitize disk erase.\u0027)),"},{"line_number":79,"context_line":"    cfg.StrOpt(\u0027ca_file\u0027,"},{"line_number":80,"context_line":"               help\u003d_(\u0027CA certificate file to validate iLO.\u0027)),"},{"line_number":81,"context_line":"    cfg.StrOpt(\u0027ilo_verify_ca\u0027,"},{"line_number":82,"context_line":"               default\u003dTrue,"},{"line_number":83,"context_line":"               help\u003d_(\u0027CA certificate to validate iLO. This can be either \u0027"},{"line_number":84,"context_line":"                      \u0027a Boolean value, a path to a CA_BUNDLE file or \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_fb68d0f5","line":81,"range":{"start_line":81,"start_character":16,"end_line":81,"end_character":20},"in_reply_to":"9f560f44_4d22ebba","updated":"2020-08-24 15:40:15.000000000","message":"Done","commit_id":"9a946168ee830f077333980b4f11cb2a404648c6"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7dda6bdce7e79efe0569bbbdbf6704dc7416d568","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    cfg.StrOpt(\u0027ca_file\u0027,"},{"line_number":80,"context_line":"               help\u003d_(\u0027CA certificate file to validate iLO.\u0027)),"},{"line_number":81,"context_line":"    cfg.StrOpt(\u0027ilo_verify_ca\u0027,"},{"line_number":82,"context_line":"               default\u003dTrue,"},{"line_number":83,"context_line":"               help\u003d_(\u0027CA certificate to validate iLO. This can be either \u0027"},{"line_number":84,"context_line":"                      \u0027a Boolean value, a path to a CA_BUNDLE file or \u0027"},{"line_number":85,"context_line":"                      \u0027directory with certificates of trusted CAs. If set \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_0d3d93dc","line":82,"updated":"2020-08-21 07:55:12.000000000","message":"It\u0027s a bit weird to use a boolean as a default for a string property.","commit_id":"9a946168ee830f077333980b4f11cb2a404648c6"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"b1a04625acbd112a1f6bd16ff669a55addf5b314","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    cfg.StrOpt(\u0027ca_file\u0027,"},{"line_number":80,"context_line":"               help\u003d_(\u0027CA certificate file to validate iLO.\u0027)),"},{"line_number":81,"context_line":"    cfg.StrOpt(\u0027ilo_verify_ca\u0027,"},{"line_number":82,"context_line":"               default\u003dTrue,"},{"line_number":83,"context_line":"               help\u003d_(\u0027CA certificate to validate iLO. This can be either \u0027"},{"line_number":84,"context_line":"                      \u0027a Boolean value, a path to a CA_BUNDLE file or \u0027"},{"line_number":85,"context_line":"                      \u0027directory with certificates of trusted CAs. If set \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_4984915e","line":82,"in_reply_to":"9f560f44_0d3d93dc","updated":"2020-08-21 20:55:17.000000000","message":"++ I\u0027d set it to be a string that gets converted.\n\nFWIW, I\u0027m a little worried about enforcing a default of true as every operator will realistically turn around and disable this function to initially talk to the nodes....","commit_id":"9a946168ee830f077333980b4f11cb2a404648c6"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"256cf75559912e4e48b0897103dd1f396b7d6586","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    cfg.StrOpt(\u0027ca_file\u0027,"},{"line_number":80,"context_line":"               help\u003d_(\u0027CA certificate file to validate iLO.\u0027)),"},{"line_number":81,"context_line":"    cfg.StrOpt(\u0027ilo_verify_ca\u0027,"},{"line_number":82,"context_line":"               default\u003dTrue,"},{"line_number":83,"context_line":"               help\u003d_(\u0027CA certificate to validate iLO. This can be either \u0027"},{"line_number":84,"context_line":"                      \u0027a Boolean value, a path to a CA_BUNDLE file or \u0027"},{"line_number":85,"context_line":"                      \u0027directory with certificates of trusted CAs. If set \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_bd000336","line":82,"in_reply_to":"9f560f44_4984915e","updated":"2020-08-22 09:05:10.000000000","message":"Well, true is the default now, and we probably don\u0027t want to be insecure by default even if it\u0027s inconvenient (similarly to how we enable full cleaning by default even if half of operators disable it).","commit_id":"9a946168ee830f077333980b4f11cb2a404648c6"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"db40f7ace8490451aa9ff635e7bfd8e90c60ee45","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    cfg.StrOpt(\u0027ca_file\u0027,"},{"line_number":80,"context_line":"               help\u003d_(\u0027CA certificate file to validate iLO.\u0027)),"},{"line_number":81,"context_line":"    cfg.StrOpt(\u0027ilo_verify_ca\u0027,"},{"line_number":82,"context_line":"               default\u003dTrue,"},{"line_number":83,"context_line":"               help\u003d_(\u0027CA certificate to validate iLO. This can be either \u0027"},{"line_number":84,"context_line":"                      \u0027a Boolean value, a path to a CA_BUNDLE file or \u0027"},{"line_number":85,"context_line":"                      \u0027directory with certificates of trusted CAs. If set \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_e9e3d303","line":82,"in_reply_to":"9f560f44_bd000336","updated":"2020-08-24 09:29:11.000000000","message":"I think single conf parameter with default value as \"true\" is better than the 2 config parameter approach suggested in this other patch [1] related to \"Allow HttpImageService to accept custom certificate\"\n[1] https://review.opendev.org/#/c/742936/5/ironic/conf/default.py","commit_id":"9a946168ee830f077333980b4f11cb2a404648c6"},{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"77f24469f5057682f841b1112007f0d4e4eaaaa9","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    cfg.StrOpt(\u0027ca_file\u0027,"},{"line_number":80,"context_line":"               help\u003d_(\u0027CA certificate file to validate iLO.\u0027)),"},{"line_number":81,"context_line":"    cfg.StrOpt(\u0027verify_ca\u0027,"},{"line_number":82,"context_line":"               default\u003d\u0027True\u0027,"},{"line_number":83,"context_line":"               help\u003d_(\u0027CA certificate to validate iLO. This can be either \u0027"},{"line_number":84,"context_line":"                      \u0027a Boolean value, a path to a CA_BUNDLE file or \u0027"},{"line_number":85,"context_line":"                      \u0027directory with certificates of trusted CAs. If set \u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_33cf6d2a","line":82,"updated":"2020-09-01 17:27:11.000000000","message":"I think you are missing a \"deprecated_for_removal\" and \"deprecated_reason\" here.","commit_id":"bd428b8ef5776d4e1138a8faa23ed662275a7461"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"cf857691f848c63ceeebd5782417a4d47a9e0e27","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    cfg.StrOpt(\u0027ca_file\u0027,"},{"line_number":80,"context_line":"               help\u003d_(\u0027CA certificate file to validate iLO.\u0027)),"},{"line_number":81,"context_line":"    cfg.StrOpt(\u0027verify_ca\u0027,"},{"line_number":82,"context_line":"               default\u003d\u0027True\u0027,"},{"line_number":83,"context_line":"               help\u003d_(\u0027CA certificate to validate iLO. This can be either \u0027"},{"line_number":84,"context_line":"                      \u0027a Boolean value, a path to a CA_BUNDLE file or \u0027"},{"line_number":85,"context_line":"                      \u0027directory with certificates of trusted CAs. If set \u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_e87cda73","line":82,"in_reply_to":"9f560f44_33cf6d2a","updated":"2020-09-02 07:17:14.000000000","message":"Done","commit_id":"bd428b8ef5776d4e1138a8faa23ed662275a7461"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"6481f9c8245663146bafb4f4dcd8062e9e46b554","unresolved":false,"context_lines":[{"line_number":80,"context_line":"               help\u003d_(\u0027CA certificate file to validate iLO. This \u0027"},{"line_number":81,"context_line":"                      \u0027attibute is deprecated and will be removed \u0027"},{"line_number":82,"context_line":"                      \u0027in future release. Its being replaced by new \u0027"},{"line_number":83,"context_line":"                      \u0027new configuration parameter \"verify_ca\".\u0027)),"},{"line_number":84,"context_line":"    cfg.StrOpt(\u0027verify_ca\u0027,"},{"line_number":85,"context_line":"               default\u003d\u0027True\u0027,"},{"line_number":86,"context_line":"               help\u003d_(\u0027CA certificate to validate iLO. This can be either \u0027"}],"source_content_type":"text/x-python","patch_set":9,"id":"9f560f44_cb3c70e3","line":83,"updated":"2020-09-02 08:47:15.000000000","message":"I think a good point was raised on the previouis patchset: we tend to use special parameters deprecated_for_removal\u003dTrue, deprecated_reason\u003d\"...\" instead of mentioning deprecation in the help string.","commit_id":"90be2abcd875a7b0bdd29ffd33d23fbec6bfd2c8"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"6fe7ede2fa7005b5bacb9e10c286bcad16cb5c17","unresolved":false,"context_lines":[{"line_number":80,"context_line":"               help\u003d_(\u0027CA certificate file to validate iLO. This \u0027"},{"line_number":81,"context_line":"                      \u0027attibute is deprecated and will be removed \u0027"},{"line_number":82,"context_line":"                      \u0027in future release. Its being replaced by new \u0027"},{"line_number":83,"context_line":"                      \u0027new configuration parameter \"verify_ca\".\u0027)),"},{"line_number":84,"context_line":"    cfg.StrOpt(\u0027verify_ca\u0027,"},{"line_number":85,"context_line":"               default\u003d\u0027True\u0027,"},{"line_number":86,"context_line":"               help\u003d_(\u0027CA certificate to validate iLO. This can be either \u0027"}],"source_content_type":"text/x-python","patch_set":9,"id":"9f560f44_f2a96190","line":83,"in_reply_to":"9f560f44_cb3c70e3","updated":"2020-09-02 13:15:24.000000000","message":"Done","commit_id":"90be2abcd875a7b0bdd29ffd33d23fbec6bfd2c8"}],"ironic/drivers/modules/ilo/common.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"ebbf032caf3ce57420f1b7d50c45a6210f86a398","unresolved":false,"context_lines":[{"line_number":237,"context_line":"                               if associated_with else \"\"), \u0027err\u0027: e})"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"def parse_driver_info(node):"},{"line_number":241,"context_line":"    \"\"\"Gets the driver specific Node info."},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"    This method validates whether the \u0027driver_info\u0027 property of the"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_92cbe91c","line":240,"updated":"2020-07-28 10:54:56.000000000","message":"pep8: C901 \u0027parse_driver_info\u0027 is too complex (23)","commit_id":"69cf6aa85d1457d2ae1a3ba529b916a9b5dbbc12"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"ebbf032caf3ce57420f1b7d50c45a6210f86a398","unresolved":false,"context_lines":[{"line_number":320,"context_line":"                _(\u0027Invalid value type set in driver_info/ilo_verify_ca on \u0027"},{"line_number":321,"context_line":"                  \u0027node %(node)s. The value should be a Boolean or the path \u0027"},{"line_number":322,"context_line":"                  \u0027to a file/directory, not \"%(value)s\"\u0027) %"},{"line_number":323,"context_line":"                  {\u0027value\u0027: verify_ca, \u0027node\u0027: node.uuid})"},{"line_number":324,"context_line":"        d_info[\u0027verify_ca\u0027] \u003d verify_ca"},{"line_number":325,"context_line":""},{"line_number":326,"context_line":"    snmp_info \u003d _parse_snmp_driver_info(info)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_f2d065cc","line":323,"updated":"2020-07-28 10:54:56.000000000","message":"pep8: E131 continuation line unaligned for hanging indent","commit_id":"69cf6aa85d1457d2ae1a3ba529b916a9b5dbbc12"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"7bd52b8d3988018cce1c91fbe7168f28ded2cf68","unresolved":false,"context_lines":[{"line_number":57,"context_line":"OPTIONAL_PROPERTIES \u003d {"},{"line_number":58,"context_line":"    \u0027client_port\u0027: _(\"port to be used for iLO operations. Optional.\"),"},{"line_number":59,"context_line":"    \u0027client_timeout\u0027: _(\"timeout (in seconds) for iLO operations. Optional.\"),"},{"line_number":60,"context_line":"    \u0027ca_file\u0027: _(\"CA certificate file to validate iLO. Optional\"),"},{"line_number":61,"context_line":"    \u0027ilo_verify_ca\u0027: _(\"Either a Boolean value, a path to a CA_BUNDLE \""},{"line_number":62,"context_line":"                       \"file or directory with certificates of trusted \""},{"line_number":63,"context_line":"                       \"CAs. If set to True the driver will verify the \""}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_b7f356e7","line":60,"range":{"start_line":60,"start_character":5,"end_line":60,"end_character":12},"updated":"2020-07-30 06:26:17.000000000","message":"Add a warning for this attribute that it would be obsoleted in future release.","commit_id":"c27357af9d0626fb855d0222a25b87853a3f4ea4"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"31610146d5b3645fe323dc273ccb491bb17e151a","unresolved":false,"context_lines":[{"line_number":57,"context_line":"OPTIONAL_PROPERTIES \u003d {"},{"line_number":58,"context_line":"    \u0027client_port\u0027: _(\"port to be used for iLO operations. Optional.\"),"},{"line_number":59,"context_line":"    \u0027client_timeout\u0027: _(\"timeout (in seconds) for iLO operations. Optional.\"),"},{"line_number":60,"context_line":"    \u0027ca_file\u0027: _(\"CA certificate file to validate iLO. Optional\"),"},{"line_number":61,"context_line":"    \u0027ilo_verify_ca\u0027: _(\"Either a Boolean value, a path to a CA_BUNDLE \""},{"line_number":62,"context_line":"                       \"file or directory with certificates of trusted \""},{"line_number":63,"context_line":"                       \"CAs. If set to True the driver will verify the \""}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_26f7e3d5","line":60,"range":{"start_line":60,"start_character":5,"end_line":60,"end_character":12},"in_reply_to":"9f560f44_b7f356e7","updated":"2020-08-03 11:51:58.000000000","message":"where should i add the comment?","commit_id":"c27357af9d0626fb855d0222a25b87853a3f4ea4"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"7bd52b8d3988018cce1c91fbe7168f28ded2cf68","unresolved":false,"context_lines":[{"line_number":328,"context_line":"def _parse_optional_driver_info(node):"},{"line_number":329,"context_line":"    \"\"\"Parses the optional driver_info parameters."},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"    :param info: driver_info dictionary."},{"line_number":332,"context_line":"    :returns: a dictionary containing information of optional properties."},{"line_number":333,"context_line":"    :raises: InvalidParameterValue if any parameters are incorrect"},{"line_number":334,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_572e3a43","line":331,"updated":"2020-07-30 06:26:17.000000000","message":"Its node object being passed","commit_id":"c27357af9d0626fb855d0222a25b87853a3f4ea4"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"31610146d5b3645fe323dc273ccb491bb17e151a","unresolved":false,"context_lines":[{"line_number":328,"context_line":"def _parse_optional_driver_info(node):"},{"line_number":329,"context_line":"    \"\"\"Parses the optional driver_info parameters."},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"    :param info: driver_info dictionary."},{"line_number":332,"context_line":"    :returns: a dictionary containing information of optional properties."},{"line_number":333,"context_line":"    :raises: InvalidParameterValue if any parameters are incorrect"},{"line_number":334,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_3a79eb92","line":331,"in_reply_to":"9f560f44_572e3a43","updated":"2020-08-03 11:51:58.000000000","message":"Done","commit_id":"c27357af9d0626fb855d0222a25b87853a3f4ea4"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"7bd52b8d3988018cce1c91fbe7168f28ded2cf68","unresolved":false,"context_lines":[{"line_number":353,"context_line":"    if ca_file_value and not info.get(\u0027ilo_verify_ca\u0027):"},{"line_number":354,"context_line":"        LOG.warning(\"The `driver_info/ca_file` parameter is deprecated \""},{"line_number":355,"context_line":"                    \"in favor of `driver_info/ilo_verify_ca` parameter. \""},{"line_number":356,"context_line":"                    \"Please remove the `driver_info/ca_file` parameter from \""},{"line_number":357,"context_line":"                    \"node %(node)s configuration.\", {\u0027node\u0027: node.uuid})"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"        if not os.path.isfile(ca_file_value):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_171cc210","line":356,"range":{"start_line":356,"start_character":28,"end_line":356,"end_character":34},"updated":"2020-07-30 06:26:17.000000000","message":"Its not required to be removed as its supported for this release. You can insist on using \u0027ilo_verify_ca\u0027 instead.","commit_id":"c27357af9d0626fb855d0222a25b87853a3f4ea4"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"31610146d5b3645fe323dc273ccb491bb17e151a","unresolved":false,"context_lines":[{"line_number":353,"context_line":"    if ca_file_value and not info.get(\u0027ilo_verify_ca\u0027):"},{"line_number":354,"context_line":"        LOG.warning(\"The `driver_info/ca_file` parameter is deprecated \""},{"line_number":355,"context_line":"                    \"in favor of `driver_info/ilo_verify_ca` parameter. \""},{"line_number":356,"context_line":"                    \"Please remove the `driver_info/ca_file` parameter from \""},{"line_number":357,"context_line":"                    \"node %(node)s configuration.\", {\u0027node\u0027: node.uuid})"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"        if not os.path.isfile(ca_file_value):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_3aec4b28","line":356,"range":{"start_line":356,"start_character":28,"end_line":356,"end_character":34},"in_reply_to":"9f560f44_171cc210","updated":"2020-08-03 11:51:58.000000000","message":"Done","commit_id":"c27357af9d0626fb855d0222a25b87853a3f4ea4"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"7bd52b8d3988018cce1c91fbe7168f28ded2cf68","unresolved":false,"context_lines":[{"line_number":360,"context_line":"            raise exception.InvalidParameterValue(_("},{"line_number":361,"context_line":"                \u0027ca_file \"%(value)s\" is not found.\u0027) %"},{"line_number":362,"context_line":"                {\u0027value\u0027: ca_file_value})"},{"line_number":363,"context_line":"        optional_info[\u0027verify_ca\u0027] \u003d ca_file_value"},{"line_number":364,"context_line":"    else:"},{"line_number":365,"context_line":"        LOG.warning(\"The `driver_info/ca_file` parameter is ignored in favor \""},{"line_number":366,"context_line":"                    \"of `driver_info/ilo_verify_ca` parameter in node \""}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_37d62629","line":363,"range":{"start_line":363,"start_character":23,"end_line":363,"end_character":32},"updated":"2020-07-30 06:26:17.000000000","message":"should it be \u0027ca_file\u0027?","commit_id":"c27357af9d0626fb855d0222a25b87853a3f4ea4"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"31610146d5b3645fe323dc273ccb491bb17e151a","unresolved":false,"context_lines":[{"line_number":360,"context_line":"            raise exception.InvalidParameterValue(_("},{"line_number":361,"context_line":"                \u0027ca_file \"%(value)s\" is not found.\u0027) %"},{"line_number":362,"context_line":"                {\u0027value\u0027: ca_file_value})"},{"line_number":363,"context_line":"        optional_info[\u0027verify_ca\u0027] \u003d ca_file_value"},{"line_number":364,"context_line":"    else:"},{"line_number":365,"context_line":"        LOG.warning(\"The `driver_info/ca_file` parameter is ignored in favor \""},{"line_number":366,"context_line":"                    \"of `driver_info/ilo_verify_ca` parameter in node \""}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_4675b763","line":363,"range":{"start_line":363,"start_character":23,"end_line":363,"end_character":32},"in_reply_to":"9f560f44_37d62629","updated":"2020-08-03 11:51:58.000000000","message":"Its been used in line no. 439","commit_id":"c27357af9d0626fb855d0222a25b87853a3f4ea4"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"d9b6453299437903c3d1361a2441d1b7102a4fe6","unresolved":false,"context_lines":[{"line_number":57,"context_line":"OPTIONAL_PROPERTIES \u003d {"},{"line_number":58,"context_line":"    \u0027client_port\u0027: _(\"port to be used for iLO operations. Optional.\"),"},{"line_number":59,"context_line":"    \u0027client_timeout\u0027: _(\"timeout (in seconds) for iLO operations. Optional.\"),"},{"line_number":60,"context_line":"    \u0027ca_file\u0027: _(\"CA certificate file to validate iLO. Optional\"),"},{"line_number":61,"context_line":"    \u0027ilo_verify_ca\u0027: _(\"Either a Boolean value, a path to a CA_BUNDLE \""},{"line_number":62,"context_line":"                       \"file or directory with certificates of trusted \""},{"line_number":63,"context_line":"                       \"CAs. If set to True the driver will verify the \""}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_b967404d","line":60,"updated":"2020-08-07 14:00:15.000000000","message":"Let\u0027s mark it as deprecated here","commit_id":"debb910966ed4a7a1770dba98964659383713e27"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"d039bf09e383f01aed82d4bbb3d0d15f1d17d952","unresolved":false,"context_lines":[{"line_number":57,"context_line":"OPTIONAL_PROPERTIES \u003d {"},{"line_number":58,"context_line":"    \u0027client_port\u0027: _(\"port to be used for iLO operations. Optional.\"),"},{"line_number":59,"context_line":"    \u0027client_timeout\u0027: _(\"timeout (in seconds) for iLO operations. Optional.\"),"},{"line_number":60,"context_line":"    \u0027ca_file\u0027: _(\"CA certificate file to validate iLO. Optional\"),"},{"line_number":61,"context_line":"    \u0027ilo_verify_ca\u0027: _(\"Either a Boolean value, a path to a CA_BUNDLE \""},{"line_number":62,"context_line":"                       \"file or directory with certificates of trusted \""},{"line_number":63,"context_line":"                       \"CAs. If set to True the driver will verify the \""}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_3e34a4dd","line":60,"in_reply_to":"9f560f44_b967404d","updated":"2020-08-10 14:43:21.000000000","message":"Done","commit_id":"debb910966ed4a7a1770dba98964659383713e27"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"d9b6453299437903c3d1361a2441d1b7102a4fe6","unresolved":false,"context_lines":[{"line_number":338,"context_line":""},{"line_number":339,"context_line":"    for param in OPTIONAL_PROPERTIES:"},{"line_number":340,"context_line":"        if param !\u003d \u0027ilo_verify_ca\u0027:"},{"line_number":341,"context_line":"            value \u003d info.get(param, CONF.ilo.get(param))"},{"line_number":342,"context_line":""},{"line_number":343,"context_line":"        if param \u003d\u003d \"client_port\":"},{"line_number":344,"context_line":"            optional_info[param] \u003d utils.validate_network_port(value, param)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_195bcc86","line":341,"updated":"2020-08-07 14:00:15.000000000","message":"You\u0027re losing the ability to provide the default in [ilo]ca_file, is it intended?","commit_id":"debb910966ed4a7a1770dba98964659383713e27"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"d039bf09e383f01aed82d4bbb3d0d15f1d17d952","unresolved":false,"context_lines":[{"line_number":338,"context_line":""},{"line_number":339,"context_line":"    for param in OPTIONAL_PROPERTIES:"},{"line_number":340,"context_line":"        if param !\u003d \u0027ilo_verify_ca\u0027:"},{"line_number":341,"context_line":"            value \u003d info.get(param, CONF.ilo.get(param))"},{"line_number":342,"context_line":""},{"line_number":343,"context_line":"        if param \u003d\u003d \"client_port\":"},{"line_number":344,"context_line":"            optional_info[param] \u003d utils.validate_network_port(value, param)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_5ee238d6","line":341,"in_reply_to":"9f560f44_195bcc86","updated":"2020-08-10 14:43:21.000000000","message":"Done","commit_id":"debb910966ed4a7a1770dba98964659383713e27"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"d9b6453299437903c3d1361a2441d1b7102a4fe6","unresolved":false,"context_lines":[{"line_number":348,"context_line":"            except ValueError:"},{"line_number":349,"context_line":"                not_integers.append(param)"},{"line_number":350,"context_line":""},{"line_number":351,"context_line":"    ca_file_value \u003d info.get(\u0027ca_file\u0027, CONF.ilo.get(\u0027ca_file\u0027))"},{"line_number":352,"context_line":""},{"line_number":353,"context_line":"    if ca_file_value and not info.get(\u0027ilo_verify_ca\u0027):"},{"line_number":354,"context_line":"        LOG.warning(\"The `driver_info/ca_file` parameter is deprecated \""}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_f95d3879","line":351,"updated":"2020-08-07 14:00:15.000000000","message":"Here you still handle [ilo]ca_file ...","commit_id":"debb910966ed4a7a1770dba98964659383713e27"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"d039bf09e383f01aed82d4bbb3d0d15f1d17d952","unresolved":false,"context_lines":[{"line_number":348,"context_line":"            except ValueError:"},{"line_number":349,"context_line":"                not_integers.append(param)"},{"line_number":350,"context_line":""},{"line_number":351,"context_line":"    ca_file_value \u003d info.get(\u0027ca_file\u0027, CONF.ilo.get(\u0027ca_file\u0027))"},{"line_number":352,"context_line":""},{"line_number":353,"context_line":"    if ca_file_value and not info.get(\u0027ilo_verify_ca\u0027):"},{"line_number":354,"context_line":"        LOG.warning(\"The `driver_info/ca_file` parameter is deprecated \""}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_5e7b588a","line":351,"in_reply_to":"9f560f44_f95d3879","updated":"2020-08-10 14:43:21.000000000","message":"[ilo]ca_file still in use thats why here is the check. Once we remove the ca_file attribute. This will be removed.","commit_id":"debb910966ed4a7a1770dba98964659383713e27"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"d9b6453299437903c3d1361a2441d1b7102a4fe6","unresolved":false,"context_lines":[{"line_number":355,"context_line":"                    \"in favor of `driver_info/ilo_verify_ca` parameter. \""},{"line_number":356,"context_line":"                    \"Please use `driver_info/ilo_verify_ca` instead of \""},{"line_number":357,"context_line":"                    \"`driver_info/ca_file` in node %(node)s \""},{"line_number":358,"context_line":"                    \"configuration.\", {\u0027node\u0027: node.uuid})"},{"line_number":359,"context_line":""},{"line_number":360,"context_line":"        if not os.path.isfile(ca_file_value):"},{"line_number":361,"context_line":"            raise exception.InvalidParameterValue(_("}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_5958a486","line":358,"updated":"2020-08-07 14:00:15.000000000","message":"... and it will cause this warning if set.","commit_id":"debb910966ed4a7a1770dba98964659383713e27"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"d039bf09e383f01aed82d4bbb3d0d15f1d17d952","unresolved":false,"context_lines":[{"line_number":355,"context_line":"                    \"in favor of `driver_info/ilo_verify_ca` parameter. \""},{"line_number":356,"context_line":"                    \"Please use `driver_info/ilo_verify_ca` instead of \""},{"line_number":357,"context_line":"                    \"`driver_info/ca_file` in node %(node)s \""},{"line_number":358,"context_line":"                    \"configuration.\", {\u0027node\u0027: node.uuid})"},{"line_number":359,"context_line":""},{"line_number":360,"context_line":"        if not os.path.isfile(ca_file_value):"},{"line_number":361,"context_line":"            raise exception.InvalidParameterValue(_("}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_fe6b4cb3","line":358,"in_reply_to":"9f560f44_5958a486","updated":"2020-08-10 14:43:21.000000000","message":"Yeah, that\u0027s the intention if ca_file is being used in either way(conf file or driver_info). It will throw the warning to use ilo_verify_ca instead.","commit_id":"debb910966ed4a7a1770dba98964659383713e27"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"d9b6453299437903c3d1361a2441d1b7102a4fe6","unresolved":false,"context_lines":[{"line_number":371,"context_line":"        # in the file-system"},{"line_number":372,"context_line":"        verify_ca \u003d info.get(\u0027ilo_verify_ca\u0027, True)"},{"line_number":373,"context_line":"        if isinstance(verify_ca, str):"},{"line_number":374,"context_line":"            if os.path.isdir(verify_ca) or os.path.isfile(verify_ca):"},{"line_number":375,"context_line":"                pass"},{"line_number":376,"context_line":"            else:"},{"line_number":377,"context_line":"                try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_3953306d","line":374,"updated":"2020-08-07 14:00:15.000000000","message":"if not ... and not ...\n\nto avoid the unnecessary \u0027pass\u0027","commit_id":"debb910966ed4a7a1770dba98964659383713e27"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"d039bf09e383f01aed82d4bbb3d0d15f1d17d952","unresolved":false,"context_lines":[{"line_number":371,"context_line":"        # in the file-system"},{"line_number":372,"context_line":"        verify_ca \u003d info.get(\u0027ilo_verify_ca\u0027, True)"},{"line_number":373,"context_line":"        if isinstance(verify_ca, str):"},{"line_number":374,"context_line":"            if os.path.isdir(verify_ca) or os.path.isfile(verify_ca):"},{"line_number":375,"context_line":"                pass"},{"line_number":376,"context_line":"            else:"},{"line_number":377,"context_line":"                try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_7e9d7cba","line":374,"in_reply_to":"9f560f44_3953306d","updated":"2020-08-10 14:43:21.000000000","message":"Done","commit_id":"debb910966ed4a7a1770dba98964659383713e27"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"d9b6453299437903c3d1361a2441d1b7102a4fe6","unresolved":false,"context_lines":[{"line_number":387,"context_line":"        elif isinstance(verify_ca, bool):"},{"line_number":388,"context_line":"            # If it\u0027s boolean it\u0027s grand, we don\u0027t need to do anything"},{"line_number":389,"context_line":"            pass"},{"line_number":390,"context_line":"        else:"},{"line_number":391,"context_line":"            raise exception.InvalidParameterValue("},{"line_number":392,"context_line":"                _(\u0027Invalid value type set in driver_info/ilo_verify_ca \u0027"},{"line_number":393,"context_line":"                  \u0027on node %(node)s. The value should be a Boolean \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_994ebcbe","line":390,"updated":"2020-08-07 14:00:15.000000000","message":"elif not isinstance(verify_ca, bool):","commit_id":"debb910966ed4a7a1770dba98964659383713e27"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"d039bf09e383f01aed82d4bbb3d0d15f1d17d952","unresolved":false,"context_lines":[{"line_number":387,"context_line":"        elif isinstance(verify_ca, bool):"},{"line_number":388,"context_line":"            # If it\u0027s boolean it\u0027s grand, we don\u0027t need to do anything"},{"line_number":389,"context_line":"            pass"},{"line_number":390,"context_line":"        else:"},{"line_number":391,"context_line":"            raise exception.InvalidParameterValue("},{"line_number":392,"context_line":"                _(\u0027Invalid value type set in driver_info/ilo_verify_ca \u0027"},{"line_number":393,"context_line":"                  \u0027on node %(node)s. The value should be a Boolean \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_feb06c45","line":390,"in_reply_to":"9f560f44_994ebcbe","updated":"2020-08-10 14:43:21.000000000","message":"Done","commit_id":"debb910966ed4a7a1770dba98964659383713e27"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"d9b6453299437903c3d1361a2441d1b7102a4fe6","unresolved":false,"context_lines":[{"line_number":395,"context_line":"                  ) % {\u0027value\u0027: verify_ca, \u0027node\u0027: node.uuid})"},{"line_number":396,"context_line":"        optional_info[\u0027verify_ca\u0027] \u003d verify_ca"},{"line_number":397,"context_line":""},{"line_number":398,"context_line":"    if not_integers:"},{"line_number":399,"context_line":"        raise exception.InvalidParameterValue(_("},{"line_number":400,"context_line":"            \"The following iLO parameters from the node\u0027s driver_info \""},{"line_number":401,"context_line":"            \"should be integers: %s\") % not_integers)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_794928b5","line":398,"updated":"2020-08-07 14:00:15.000000000","message":"maybe move this block to where not_integers is set?","commit_id":"debb910966ed4a7a1770dba98964659383713e27"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"d039bf09e383f01aed82d4bbb3d0d15f1d17d952","unresolved":false,"context_lines":[{"line_number":395,"context_line":"                  ) % {\u0027value\u0027: verify_ca, \u0027node\u0027: node.uuid})"},{"line_number":396,"context_line":"        optional_info[\u0027verify_ca\u0027] \u003d verify_ca"},{"line_number":397,"context_line":""},{"line_number":398,"context_line":"    if not_integers:"},{"line_number":399,"context_line":"        raise exception.InvalidParameterValue(_("},{"line_number":400,"context_line":"            \"The following iLO parameters from the node\u0027s driver_info \""},{"line_number":401,"context_line":"            \"should be integers: %s\") % not_integers)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_deabe8d2","line":398,"in_reply_to":"9f560f44_794928b5","updated":"2020-08-10 14:43:21.000000000","message":"Done","commit_id":"debb910966ed4a7a1770dba98964659383713e27"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7dda6bdce7e79efe0569bbbdbf6704dc7416d568","unresolved":false,"context_lines":[{"line_number":370,"context_line":"                {\u0027value\u0027: ca_file_value})"},{"line_number":371,"context_line":"        optional_info[\u0027verify_ca\u0027] \u003d ca_file_value"},{"line_number":372,"context_line":"    else:"},{"line_number":373,"context_line":"        LOG.warning(\"The `driver_info/ca_file` parameter is ignored in favor \""},{"line_number":374,"context_line":"                    \"of `driver_info/ilo_verify_ca` parameter in node \""},{"line_number":375,"context_line":"                    \"%(node)s configuration.\", {\u0027node\u0027: node.uuid})"},{"line_number":376,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_ed1adf7a","line":373,"updated":"2020-08-21 07:55:12.000000000","message":"This warning seems misplaced, it will appear when the old variable is NOT set. I think it can be removed, you already have a warning on line 361","commit_id":"9a946168ee830f077333980b4f11cb2a404648c6"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"1e84899f065aa3e6958fb5ca74a8970eb1fe3d9a","unresolved":false,"context_lines":[{"line_number":370,"context_line":"                {\u0027value\u0027: ca_file_value})"},{"line_number":371,"context_line":"        optional_info[\u0027verify_ca\u0027] \u003d ca_file_value"},{"line_number":372,"context_line":"    else:"},{"line_number":373,"context_line":"        LOG.warning(\"The `driver_info/ca_file` parameter is ignored in favor \""},{"line_number":374,"context_line":"                    \"of `driver_info/ilo_verify_ca` parameter in node \""},{"line_number":375,"context_line":"                    \"%(node)s configuration.\", {\u0027node\u0027: node.uuid})"},{"line_number":376,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_78bdcfb5","line":373,"in_reply_to":"9f560f44_ed1adf7a","updated":"2020-08-24 15:40:15.000000000","message":"Done","commit_id":"9a946168ee830f077333980b4f11cb2a404648c6"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7dda6bdce7e79efe0569bbbdbf6704dc7416d568","unresolved":false,"context_lines":[{"line_number":388,"context_line":"                          \u0027The value should be a Boolean or the path \u0027"},{"line_number":389,"context_line":"                          \u0027to a file/directory, not \"%(value)s\"\u0027"},{"line_number":390,"context_line":"                          ) % {\u0027value\u0027: verify_ca, \u0027node\u0027: node.uuid})"},{"line_number":391,"context_line":"        elif isinstance(verify_ca, bool):"},{"line_number":392,"context_line":"            # If it\u0027s boolean it\u0027s grand, we don\u0027t need to do anything"},{"line_number":393,"context_line":"            pass"},{"line_number":394,"context_line":"        elif not isinstance(verify_ca, bool):"},{"line_number":395,"context_line":"            raise exception.InvalidParameterValue("},{"line_number":396,"context_line":"                _(\u0027Invalid value type set in driver_info/ilo_verify_ca \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_2d11775e","line":393,"range":{"start_line":391,"start_character":0,"end_line":393,"end_character":16},"updated":"2020-08-21 07:55:12.000000000","message":"Please remove, redundant because of the next condition","commit_id":"9a946168ee830f077333980b4f11cb2a404648c6"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"1e84899f065aa3e6958fb5ca74a8970eb1fe3d9a","unresolved":false,"context_lines":[{"line_number":388,"context_line":"                          \u0027The value should be a Boolean or the path \u0027"},{"line_number":389,"context_line":"                          \u0027to a file/directory, not \"%(value)s\"\u0027"},{"line_number":390,"context_line":"                          ) % {\u0027value\u0027: verify_ca, \u0027node\u0027: node.uuid})"},{"line_number":391,"context_line":"        elif isinstance(verify_ca, bool):"},{"line_number":392,"context_line":"            # If it\u0027s boolean it\u0027s grand, we don\u0027t need to do anything"},{"line_number":393,"context_line":"            pass"},{"line_number":394,"context_line":"        elif not isinstance(verify_ca, bool):"},{"line_number":395,"context_line":"            raise exception.InvalidParameterValue("},{"line_number":396,"context_line":"                _(\u0027Invalid value type set in driver_info/ilo_verify_ca \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_18d133fc","line":393,"range":{"start_line":391,"start_character":0,"end_line":393,"end_character":16},"in_reply_to":"9f560f44_2d11775e","updated":"2020-08-24 15:40:15.000000000","message":"Done","commit_id":"9a946168ee830f077333980b4f11cb2a404648c6"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"b1a04625acbd112a1f6bd16ff669a55addf5b314","unresolved":false,"context_lines":[{"line_number":391,"context_line":"        elif isinstance(verify_ca, bool):"},{"line_number":392,"context_line":"            # If it\u0027s boolean it\u0027s grand, we don\u0027t need to do anything"},{"line_number":393,"context_line":"            pass"},{"line_number":394,"context_line":"        elif not isinstance(verify_ca, bool):"},{"line_number":395,"context_line":"            raise exception.InvalidParameterValue("},{"line_number":396,"context_line":"                _(\u0027Invalid value type set in driver_info/ilo_verify_ca \u0027"},{"line_number":397,"context_line":"                  \u0027on node %(node)s. The value should be a Boolean \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_e98ac561","line":394,"range":{"start_line":394,"start_character":0,"end_line":394,"end_character":45},"updated":"2020-08-21 20:55:17.000000000","message":"I\u0027ve not looked at the testing, but do we know for sure that the string True being put into the string config parameter input magically becomes a bool, or is it a string of True.... Or potentially false.","commit_id":"9a946168ee830f077333980b4f11cb2a404648c6"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"8c3d08ff34d9bea11203070a03bb4b752d2e7888","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    \u0027client_timeout\u0027: _(\"timeout (in seconds) for iLO operations. Optional.\"),"},{"line_number":60,"context_line":"    \u0027ca_file\u0027: _(\"CA certificate file to validate iLO. This \""},{"line_number":61,"context_line":"                 \"attibute is deprecated and will be removed in \""},{"line_number":62,"context_line":"                 \"future releases. Optional\"),"},{"line_number":63,"context_line":"    \u0027verify_ca\u0027: _(\"Either a Boolean value, a path to a CA_BUNDLE file or \""},{"line_number":64,"context_line":"                   \"directory with certificates of trusted CAs. If set to \""},{"line_number":65,"context_line":"                   \"True the driver will verify the host certificates; if \""}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_a06d32cd","line":62,"range":{"start_line":62,"start_character":25,"end_line":62,"end_character":33},"updated":"2020-08-27 07:31:04.000000000","message":"s/ releases / release /","commit_id":"78f5629ca65a4f44d80b174ca252613262c8706f"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"8956bc1e0f099b32c35c71054ec06b6c13cc1aac","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    \u0027client_timeout\u0027: _(\"timeout (in seconds) for iLO operations. Optional.\"),"},{"line_number":60,"context_line":"    \u0027ca_file\u0027: _(\"CA certificate file to validate iLO. This \""},{"line_number":61,"context_line":"                 \"attibute is deprecated and will be removed in \""},{"line_number":62,"context_line":"                 \"future releases. Optional\"),"},{"line_number":63,"context_line":"    \u0027verify_ca\u0027: _(\"Either a Boolean value, a path to a CA_BUNDLE file or \""},{"line_number":64,"context_line":"                   \"directory with certificates of trusted CAs. If set to \""},{"line_number":65,"context_line":"                   \"True the driver will verify the host certificates; if \""}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_961f66b6","line":62,"range":{"start_line":62,"start_character":25,"end_line":62,"end_character":33},"in_reply_to":"9f560f44_a06d32cd","updated":"2020-08-31 09:16:42.000000000","message":"Done","commit_id":"78f5629ca65a4f44d80b174ca252613262c8706f"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"8c3d08ff34d9bea11203070a03bb4b752d2e7888","unresolved":false,"context_lines":[{"line_number":354,"context_line":"            \"should be integers: %s\") % not_integers)"},{"line_number":355,"context_line":""},{"line_number":356,"context_line":"    ca_file_value \u003d info.get(\u0027ca_file\u0027, CONF.ilo.get(\u0027ca_file\u0027))"},{"line_number":357,"context_line":"    verify_ca \u003d info.get(\u0027ilo_verify_ca\u0027, CONF.ilo.get(\u0027verify_ca\u0027))"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"    if ca_file_value:"},{"line_number":360,"context_line":"        LOG.warning(\"The `driver_info/ca_file` parameter is deprecated \""}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_60615aa9","line":357,"range":{"start_line":357,"start_character":26,"end_line":357,"end_character":39},"updated":"2020-08-27 07:31:04.000000000","message":"s/ ilo_verify_ca / verify_ca /","commit_id":"78f5629ca65a4f44d80b174ca252613262c8706f"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"8956bc1e0f099b32c35c71054ec06b6c13cc1aac","unresolved":false,"context_lines":[{"line_number":354,"context_line":"            \"should be integers: %s\") % not_integers)"},{"line_number":355,"context_line":""},{"line_number":356,"context_line":"    ca_file_value \u003d info.get(\u0027ca_file\u0027, CONF.ilo.get(\u0027ca_file\u0027))"},{"line_number":357,"context_line":"    verify_ca \u003d info.get(\u0027ilo_verify_ca\u0027, CONF.ilo.get(\u0027verify_ca\u0027))"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"    if ca_file_value:"},{"line_number":360,"context_line":"        LOG.warning(\"The `driver_info/ca_file` parameter is deprecated \""}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_d6bb9e72","line":357,"range":{"start_line":357,"start_character":26,"end_line":357,"end_character":39},"in_reply_to":"9f560f44_60615aa9","updated":"2020-08-31 09:16:42.000000000","message":"Done","commit_id":"78f5629ca65a4f44d80b174ca252613262c8706f"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"8c3d08ff34d9bea11203070a03bb4b752d2e7888","unresolved":false,"context_lines":[{"line_number":356,"context_line":"    ca_file_value \u003d info.get(\u0027ca_file\u0027, CONF.ilo.get(\u0027ca_file\u0027))"},{"line_number":357,"context_line":"    verify_ca \u003d info.get(\u0027ilo_verify_ca\u0027, CONF.ilo.get(\u0027verify_ca\u0027))"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"    if ca_file_value:"},{"line_number":360,"context_line":"        LOG.warning(\"The `driver_info/ca_file` parameter is deprecated \""},{"line_number":361,"context_line":"                    \"in favor of `driver_info/ilo_verify_ca` parameter. \""},{"line_number":362,"context_line":"                    \"Please use `driver_info/ilo_verify_ca` instead of \""}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_e0744a6a","line":359,"range":{"start_line":359,"start_character":4,"end_line":359,"end_character":20},"updated":"2020-08-27 07:31:04.000000000","message":"I think this order should be reversed. driver_info[\u0027verify_ca\u0027] should be preferred over driver_info[\u0027ca_file\u0027]","commit_id":"78f5629ca65a4f44d80b174ca252613262c8706f"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"8956bc1e0f099b32c35c71054ec06b6c13cc1aac","unresolved":false,"context_lines":[{"line_number":356,"context_line":"    ca_file_value \u003d info.get(\u0027ca_file\u0027, CONF.ilo.get(\u0027ca_file\u0027))"},{"line_number":357,"context_line":"    verify_ca \u003d info.get(\u0027ilo_verify_ca\u0027, CONF.ilo.get(\u0027verify_ca\u0027))"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"    if ca_file_value:"},{"line_number":360,"context_line":"        LOG.warning(\"The `driver_info/ca_file` parameter is deprecated \""},{"line_number":361,"context_line":"                    \"in favor of `driver_info/ilo_verify_ca` parameter. \""},{"line_number":362,"context_line":"                    \"Please use `driver_info/ilo_verify_ca` instead of \""}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_56d82eef","line":359,"range":{"start_line":359,"start_character":4,"end_line":359,"end_character":20},"in_reply_to":"9f560f44_e0744a6a","updated":"2020-08-31 09:16:42.000000000","message":"In any case driver_info[\u0027verify_ca\u0027] will have a value assigned to it(either user provided or default). It will be difficult to verify, so i am checking ca_file_value first.","commit_id":"78f5629ca65a4f44d80b174ca252613262c8706f"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"8c3d08ff34d9bea11203070a03bb4b752d2e7888","unresolved":false,"context_lines":[{"line_number":358,"context_line":""},{"line_number":359,"context_line":"    if ca_file_value:"},{"line_number":360,"context_line":"        LOG.warning(\"The `driver_info/ca_file` parameter is deprecated \""},{"line_number":361,"context_line":"                    \"in favor of `driver_info/ilo_verify_ca` parameter. \""},{"line_number":362,"context_line":"                    \"Please use `driver_info/ilo_verify_ca` instead of \""},{"line_number":363,"context_line":"                    \"`driver_info/ca_file` in node %(node)s \""},{"line_number":364,"context_line":"                    \"configuration.\", {\u0027node\u0027: node.uuid})"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_406416b9","line":361,"range":{"start_line":361,"start_character":46,"end_line":361,"end_character":59},"updated":"2020-08-27 07:31:04.000000000","message":"ditto","commit_id":"78f5629ca65a4f44d80b174ca252613262c8706f"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"8956bc1e0f099b32c35c71054ec06b6c13cc1aac","unresolved":false,"context_lines":[{"line_number":358,"context_line":""},{"line_number":359,"context_line":"    if ca_file_value:"},{"line_number":360,"context_line":"        LOG.warning(\"The `driver_info/ca_file` parameter is deprecated \""},{"line_number":361,"context_line":"                    \"in favor of `driver_info/ilo_verify_ca` parameter. \""},{"line_number":362,"context_line":"                    \"Please use `driver_info/ilo_verify_ca` instead of \""},{"line_number":363,"context_line":"                    \"`driver_info/ca_file` in node %(node)s \""},{"line_number":364,"context_line":"                    \"configuration.\", {\u0027node\u0027: node.uuid})"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_36d5bab8","line":361,"range":{"start_line":361,"start_character":46,"end_line":361,"end_character":59},"in_reply_to":"9f560f44_406416b9","updated":"2020-08-31 09:16:42.000000000","message":"Done","commit_id":"78f5629ca65a4f44d80b174ca252613262c8706f"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"8c3d08ff34d9bea11203070a03bb4b752d2e7888","unresolved":false,"context_lines":[{"line_number":359,"context_line":"    if ca_file_value:"},{"line_number":360,"context_line":"        LOG.warning(\"The `driver_info/ca_file` parameter is deprecated \""},{"line_number":361,"context_line":"                    \"in favor of `driver_info/ilo_verify_ca` parameter. \""},{"line_number":362,"context_line":"                    \"Please use `driver_info/ilo_verify_ca` instead of \""},{"line_number":363,"context_line":"                    \"`driver_info/ca_file` in node %(node)s \""},{"line_number":364,"context_line":"                    \"configuration.\", {\u0027node\u0027: node.uuid})"},{"line_number":365,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_a057f2c9","line":362,"range":{"start_line":362,"start_character":45,"end_line":362,"end_character":58},"updated":"2020-08-27 07:31:04.000000000","message":"ditto","commit_id":"78f5629ca65a4f44d80b174ca252613262c8706f"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"8956bc1e0f099b32c35c71054ec06b6c13cc1aac","unresolved":false,"context_lines":[{"line_number":359,"context_line":"    if ca_file_value:"},{"line_number":360,"context_line":"        LOG.warning(\"The `driver_info/ca_file` parameter is deprecated \""},{"line_number":361,"context_line":"                    \"in favor of `driver_info/ilo_verify_ca` parameter. \""},{"line_number":362,"context_line":"                    \"Please use `driver_info/ilo_verify_ca` instead of \""},{"line_number":363,"context_line":"                    \"`driver_info/ca_file` in node %(node)s \""},{"line_number":364,"context_line":"                    \"configuration.\", {\u0027node\u0027: node.uuid})"},{"line_number":365,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_96e2c69f","line":362,"range":{"start_line":362,"start_character":45,"end_line":362,"end_character":58},"in_reply_to":"9f560f44_a057f2c9","updated":"2020-08-31 09:16:42.000000000","message":"Done","commit_id":"78f5629ca65a4f44d80b174ca252613262c8706f"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"63d9121ad39e71392c209fa6b68a6056eb3e8fe9","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    \u0027ca_file\u0027: _(\"CA certificate file to validate iLO. This \""},{"line_number":61,"context_line":"                 \"attibute is deprecated and will be removed in \""},{"line_number":62,"context_line":"                 \"future release. Optional\"),"},{"line_number":63,"context_line":"    \u0027verify_ca\u0027: _(\"Either a Boolean value, a path to a CA_BUNDLE file or \""},{"line_number":64,"context_line":"                   \"directory with certificates of trusted CAs. If set to \""},{"line_number":65,"context_line":"                   \"True the driver will verify the host certificates; if \""},{"line_number":66,"context_line":"                   \"False the driver will ignore verifying the SSL \""}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_3c50f95e","line":63,"updated":"2020-08-31 09:48:18.000000000","message":"I guess I wasn\u0027t specific enough, sorry. The driver_info properties have to be prefixed, so this should be ilo_verify_ca. The configuration options are already prefix, they\u0027re in the [ilo] section, so there is no need for additional ilo_. So\n\n node.driver_info[\"ilo_verify_ca\"]\n\nbut\n\n CONF.ilo.verify_ca\n\nI hope it makes sense now.","commit_id":"cafd5d59271d9eb84829f9e5f4b60e30a92af3df"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"e4f1f30250603574dba17b83ac6f673702c7bfc0","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    \u0027ca_file\u0027: _(\"CA certificate file to validate iLO. This \""},{"line_number":61,"context_line":"                 \"attibute is deprecated and will be removed in \""},{"line_number":62,"context_line":"                 \"future release. Optional\"),"},{"line_number":63,"context_line":"    \u0027verify_ca\u0027: _(\"Either a Boolean value, a path to a CA_BUNDLE file or \""},{"line_number":64,"context_line":"                   \"directory with certificates of trusted CAs. If set to \""},{"line_number":65,"context_line":"                   \"True the driver will verify the host certificates; if \""},{"line_number":66,"context_line":"                   \"False the driver will ignore verifying the SSL \""}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_8dfd91b3","line":63,"in_reply_to":"9f560f44_3c50f95e","updated":"2020-08-31 12:21:37.000000000","message":"Done","commit_id":"cafd5d59271d9eb84829f9e5f4b60e30a92af3df"},{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"77f24469f5057682f841b1112007f0d4e4eaaaa9","unresolved":false,"context_lines":[{"line_number":57,"context_line":"OPTIONAL_PROPERTIES \u003d {"},{"line_number":58,"context_line":"    \u0027client_port\u0027: _(\"port to be used for iLO operations. Optional.\"),"},{"line_number":59,"context_line":"    \u0027client_timeout\u0027: _(\"timeout (in seconds) for iLO operations. Optional.\"),"},{"line_number":60,"context_line":"    \u0027ca_file\u0027: _(\"CA certificate file to validate iLO. This \""},{"line_number":61,"context_line":"                 \"attibute is deprecated and will be removed in \""},{"line_number":62,"context_line":"                 \"future release. Optional\"),"},{"line_number":63,"context_line":"    \u0027ilo_verify_ca\u0027: _(\"Either a Boolean value, a path to a CA_BUNDLE \""}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_335acd82","line":60,"updated":"2020-09-01 17:27:11.000000000","message":"In ironic/drivers/modules/snmp.py#172 folks have broken this into a DEPRECATED_PROPERTIES dict. I don\u0027t know if this is a good practice and we should enforce it, or not. Just keep this in mind.","commit_id":"bd428b8ef5776d4e1138a8faa23ed662275a7461"}],"ironic/tests/unit/drivers/modules/ilo/test_common.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"ebbf032caf3ce57420f1b7d50c45a6210f86a398","unresolved":false,"context_lines":[{"line_number":153,"context_line":"        self.assertEqual(\u00271234\u0027, info[\u0027snmp_auth_prot_password\u0027])"},{"line_number":154,"context_line":"        self.assertEqual(\u00274321\u0027, info[\u0027snmp_auth_priv_password\u0027])"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    def test_parse_driver_info_invalid_value_verify_ca(self):"},{"line_number":157,"context_line":"        # Integers are not supported"},{"line_number":158,"context_line":"        self.node.driver_info[\u0027ilo_verify_ca\u0027] \u003d 123456"},{"line_number":159,"context_line":"        self.assertRaisesRegex(exception.InvalidParameterValue,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_d2d561bb","line":156,"updated":"2020-07-28 10:54:56.000000000","message":"pep8: F811 redefinition of unused \u0027test_parse_driver_info_invalid_value_verify_ca\u0027 from line 130","commit_id":"69cf6aa85d1457d2ae1a3ba529b916a9b5dbbc12"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"b1a04625acbd112a1f6bd16ff669a55addf5b314","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        self.assertRaisesRegex(exception.InvalidParameterValue,"},{"line_number":134,"context_line":"                               \u0027Invalid value type\u0027,"},{"line_number":135,"context_line":"                               ilo_common._parse_optional_driver_info,"},{"line_number":136,"context_line":"                               self.node)"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    @mock.patch.object(os.path, \u0027isfile\u0027, return_value\u003dTrue, autospec\u003dTrue)"},{"line_number":139,"context_line":"    def test_parse_driver_info_snmp_true_no_auth_priv_protocols(self,"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_c9dc2176","line":136,"updated":"2020-08-21 20:55:17.000000000","message":"Given it is a string input and with the existing code, I\u0027d feel much more comfortable if there was unit testing explicitly covering the default \"True\" boolean value of the setting, the string \"True\" being supplied, as well as same for False. I guess I\u0027m worried about the same with the node level parameter where above only a file path is being tested but we runt he risk of an API consumer providing a dictionary with a boolean False or string False.\n\n\u003e\u003e\u003e if \"False\":\n...     print(\"True\")\n... \nTrue\n\u003e\u003e\u003e","commit_id":"9a946168ee830f077333980b4f11cb2a404648c6"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"1e84899f065aa3e6958fb5ca74a8970eb1fe3d9a","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        self.assertRaisesRegex(exception.InvalidParameterValue,"},{"line_number":134,"context_line":"                               \u0027Invalid value type\u0027,"},{"line_number":135,"context_line":"                               ilo_common._parse_optional_driver_info,"},{"line_number":136,"context_line":"                               self.node)"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    @mock.patch.object(os.path, \u0027isfile\u0027, return_value\u003dTrue, autospec\u003dTrue)"},{"line_number":139,"context_line":"    def test_parse_driver_info_snmp_true_no_auth_priv_protocols(self,"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_940a271d","line":136,"in_reply_to":"9f560f44_c9dc2176","updated":"2020-08-24 15:40:15.000000000","message":"Done","commit_id":"9a946168ee830f077333980b4f11cb2a404648c6"}],"releasenotes/notes/ilo-certificate-verification-enhancement-8eefd541cfc2a9da.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7dda6bdce7e79efe0569bbbdbf6704dc7416d568","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds ilo_verify_ca to enhance certificate verification for"},{"line_number":5,"context_line":"    hardware type ilo and ilo5 which can take directory and"},{"line_number":6,"context_line":"    bolean values apart from file."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9f560f44_4810194f","line":4,"updated":"2020-08-21 07:55:12.000000000","message":"\"Adds a new configuration option ``[ilo]verify_ca`` and a new ``driver_info`` parameter ``ilo_verify_ca``\"","commit_id":"9a946168ee830f077333980b4f11cb2a404648c6"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"1e84899f065aa3e6958fb5ca74a8970eb1fe3d9a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds ilo_verify_ca to enhance certificate verification for"},{"line_number":5,"context_line":"    hardware type ilo and ilo5 which can take directory and"},{"line_number":6,"context_line":"    bolean values apart from file."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9f560f44_18dbf3ec","line":4,"in_reply_to":"9f560f44_4810194f","updated":"2020-08-24 15:40:15.000000000","message":"Done","commit_id":"9a946168ee830f077333980b4f11cb2a404648c6"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7dda6bdce7e79efe0569bbbdbf6704dc7416d568","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9f560f44_ad046719","line":7,"updated":"2020-08-21 07:55:12.000000000","message":"Please add something in the \"deprecations\" section about the deprecation of driver_info[ca_file]","commit_id":"9a946168ee830f077333980b4f11cb2a404648c6"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"1e84899f065aa3e6958fb5ca74a8970eb1fe3d9a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9f560f44_58e1eb9a","line":7,"in_reply_to":"9f560f44_ad046719","updated":"2020-08-24 15:40:15.000000000","message":"Done","commit_id":"9a946168ee830f077333980b4f11cb2a404648c6"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"8c3d08ff34d9bea11203070a03bb4b752d2e7888","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds a new configuration option ``[ilo]verify_ca`` and a new"},{"line_number":5,"context_line":"    ``driver_info`` parameter ``ilo_verify_ca`` to enhance certificate"},{"line_number":6,"context_line":"    verification for hardware type ilo and ilo5 which can take"},{"line_number":7,"context_line":"    directory and bolean values apart from file."},{"line_number":8,"context_line":"deprecations:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9f560f44_60631a43","line":5,"range":{"start_line":5,"start_character":32,"end_line":5,"end_character":45},"updated":"2020-08-27 07:31:04.000000000","message":"s/ ilo_verify_ca / verify_ca /","commit_id":"78f5629ca65a4f44d80b174ca252613262c8706f"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"8956bc1e0f099b32c35c71054ec06b6c13cc1aac","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds a new configuration option ``[ilo]verify_ca`` and a new"},{"line_number":5,"context_line":"    ``driver_info`` parameter ``ilo_verify_ca`` to enhance certificate"},{"line_number":6,"context_line":"    verification for hardware type ilo and ilo5 which can take"},{"line_number":7,"context_line":"    directory and bolean values apart from file."},{"line_number":8,"context_line":"deprecations:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9f560f44_36fe5a38","line":5,"range":{"start_line":5,"start_character":32,"end_line":5,"end_character":45},"in_reply_to":"9f560f44_60631a43","updated":"2020-08-31 09:16:42.000000000","message":"Done","commit_id":"78f5629ca65a4f44d80b174ca252613262c8706f"},{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"77f24469f5057682f841b1112007f0d4e4eaaaa9","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    verification for hardware type ilo and ilo5 which can take"},{"line_number":7,"context_line":"    directory and bolean values apart from file."},{"line_number":8,"context_line":"deprecations:"},{"line_number":9,"context_line":"   - The ``[ilo]ca_file`` configuration option is deprecated for"},{"line_number":10,"context_line":"     removal, please use ``[ilo]verify_ca`` instead which can take"},{"line_number":11,"context_line":"     directory and bolean values apart from file for certificate"},{"line_number":12,"context_line":"     verification."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9f560f44_d3ba71be","line":9,"range":{"start_line":9,"start_character":16,"end_line":9,"end_character":23},"updated":"2020-09-01 17:27:11.000000000","message":"I don\u0027t see a deprecation message on the ca_file config option on conf/ilo.py.","commit_id":"bd428b8ef5776d4e1138a8faa23ed662275a7461"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"cf857691f848c63ceeebd5782417a4d47a9e0e27","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    verification for hardware type ilo and ilo5 which can take"},{"line_number":7,"context_line":"    directory and bolean values apart from file."},{"line_number":8,"context_line":"deprecations:"},{"line_number":9,"context_line":"   - The ``[ilo]ca_file`` configuration option is deprecated for"},{"line_number":10,"context_line":"     removal, please use ``[ilo]verify_ca`` instead which can take"},{"line_number":11,"context_line":"     directory and bolean values apart from file for certificate"},{"line_number":12,"context_line":"     verification."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9f560f44_2896d295","line":9,"range":{"start_line":9,"start_character":16,"end_line":9,"end_character":23},"in_reply_to":"9f560f44_d3ba71be","updated":"2020-09-02 07:17:14.000000000","message":"Done","commit_id":"bd428b8ef5776d4e1138a8faa23ed662275a7461"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"e2730efcde887cdda297a406f9fdc26e74f4bcd1","unresolved":false,"context_lines":[{"line_number":8,"context_line":"deprecations:"},{"line_number":9,"context_line":"   - The ``[ilo]ca_file`` configuration option is deprecated for"},{"line_number":10,"context_line":"     removal, please use ``[ilo]verify_ca`` instead which can take"},{"line_number":11,"context_line":"     directory and bolean values apart from file for certificate"},{"line_number":12,"context_line":"     verification."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9f560f44_46996ace","line":11,"range":{"start_line":11,"start_character":18,"end_line":11,"end_character":26},"updated":"2020-09-02 21:13:08.000000000","message":"nit: boolean :)","commit_id":"3162e1303e70c3105b0b6da4ae717f5f02b839f9"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"d88b1be52dbd5430f15b950967a028a93f15a14b","unresolved":false,"context_lines":[{"line_number":8,"context_line":"deprecations:"},{"line_number":9,"context_line":"   - The ``[ilo]ca_file`` configuration option is deprecated for"},{"line_number":10,"context_line":"     removal, please use ``[ilo]verify_ca`` instead which can take"},{"line_number":11,"context_line":"     directory and bolean values apart from file for certificate"},{"line_number":12,"context_line":"     verification."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9f560f44_0e15c4e5","line":11,"range":{"start_line":11,"start_character":18,"end_line":11,"end_character":26},"in_reply_to":"9f560f44_46996ace","updated":"2020-09-03 06:52:58.000000000","message":"Done","commit_id":"3162e1303e70c3105b0b6da4ae717f5f02b839f9"}]}