)]}'
{"ironic/api/controllers/v1/allocation.py":[{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"2b890c08cded22a6d472fd73f839c010387034ed","unresolved":false,"context_lines":[{"line_number":318,"context_line":""},{"line_number":319,"context_line":"        if allocation.get(\u0027traits\u0027):"},{"line_number":320,"context_line":"            for trait in allocation[\u0027traits\u0027]:"},{"line_number":321,"context_line":"                api_utils.validate_trait(trait)"},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"        node \u003d None"},{"line_number":324,"context_line":"        if allocation.get(\u0027node\u0027):"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_f0752b33","line":321,"updated":"2020-08-11 21:45:06.000000000","message":"This can be done in the jsonschema, and the validate_trait function eventually deleted","commit_id":"325d207d4198dd4339556f3043de58b02ebc02f6"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c334c6a8a594bba5047e091a163fb065705ffb89","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        rpc_allocation,"},{"line_number":75,"context_line":"        link_resource\u003d\u0027allocations\u0027,"},{"line_number":76,"context_line":"        fields\u003d(\u0027extra\u0027, \u0027name\u0027, \u0027state\u0027, \u0027last_error\u0027, \u0027resource_class\u0027,"},{"line_number":77,"context_line":"                \u0027owner\u0027),"},{"line_number":78,"context_line":"        list_fields\u003d(\u0027candidate_nodes\u0027, \u0027traits\u0027)"},{"line_number":79,"context_line":"    )"},{"line_number":80,"context_line":"    api_utils.populate_node_uuid(rpc_allocation, allocation,"}],"source_content_type":"text/x-python","patch_set":27,"id":"1f621f24_2f7bbef4","line":77,"updated":"2020-11-17 20:07:48.000000000","message":"nit: ideally, this should be\n\n fields\u003dlist(ALLOCATION_SCHEMA[\u0027properties\u0027])\n\n(modulo uuid?)","commit_id":"7b5c26c4b25d18787dedd099131e5dc7b1d080d6"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"d8770a3730fea5fe203d780b0bd1c14dfdbad7be","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        rpc_allocation,"},{"line_number":75,"context_line":"        link_resource\u003d\u0027allocations\u0027,"},{"line_number":76,"context_line":"        fields\u003d(\u0027extra\u0027, \u0027name\u0027, \u0027state\u0027, \u0027last_error\u0027, \u0027resource_class\u0027,"},{"line_number":77,"context_line":"                \u0027owner\u0027),"},{"line_number":78,"context_line":"        list_fields\u003d(\u0027candidate_nodes\u0027, \u0027traits\u0027)"},{"line_number":79,"context_line":"    )"},{"line_number":80,"context_line":"    api_utils.populate_node_uuid(rpc_allocation, allocation,"}],"source_content_type":"text/x-python","patch_set":27,"id":"1f621f24_5ce071fb","line":77,"in_reply_to":"1f621f24_2f7bbef4","updated":"2020-11-20 04:00:08.000000000","message":"Not every output object has a create schema, so I think the more general approach is to just list the fields here","commit_id":"7b5c26c4b25d18787dedd099131e5dc7b1d080d6"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c334c6a8a594bba5047e091a163fb065705ffb89","unresolved":false,"context_lines":[{"line_number":81,"context_line":"                                 raise_notfound\u003dFalse)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    if fields is not None:"},{"line_number":84,"context_line":"        api_utils.check_for_invalid_fields(fields, allocation.keys())"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    if sanitize:"},{"line_number":87,"context_line":"        allocation_sanitize(allocation, fields)"}],"source_content_type":"text/x-python","patch_set":27,"id":"1f621f24_0f7ec2e2","line":84,"updated":"2020-11-17 20:07:48.000000000","message":"nit: .keys() returns a view, if you need something real, use set(allocation) or list(allocation)","commit_id":"7b5c26c4b25d18787dedd099131e5dc7b1d080d6"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"d8770a3730fea5fe203d780b0bd1c14dfdbad7be","unresolved":false,"context_lines":[{"line_number":81,"context_line":"                                 raise_notfound\u003dFalse)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    if fields is not None:"},{"line_number":84,"context_line":"        api_utils.check_for_invalid_fields(fields, allocation.keys())"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    if sanitize:"},{"line_number":87,"context_line":"        allocation_sanitize(allocation, fields)"}],"source_content_type":"text/x-python","patch_set":27,"id":"1f621f24_fcee9deb","line":84,"in_reply_to":"1f621f24_0f7ec2e2","updated":"2020-11-20 04:00:08.000000000","message":"Done","commit_id":"7b5c26c4b25d18787dedd099131e5dc7b1d080d6"}]}