)]}'
{"ironic/common/json_rpc/client.py":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"8ab27a7e4df15e846bdea3d49a5899a21d03e56a","unresolved":false,"context_lines":[{"line_number":168,"context_line":""},{"line_number":169,"context_line":"        LOG.debug(\"RPC %s with %s\", method, strutils.mask_dict_password(body))"},{"line_number":170,"context_line":"        if CONF.json_rpc.use_ssl:"},{"line_number":171,"context_line":"            url \u003d \u0027https://%s:%d\u0027 % (self.host, CONF.json_rpc.port)"},{"line_number":172,"context_line":"        else:"},{"line_number":173,"context_line":"            url \u003d \u0027http://%s:%d\u0027 % (self.host, CONF.json_rpc.port)"},{"line_number":174,"context_line":"        result \u003d _get_session().post(url, json\u003dbody)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_eb54c723","line":171,"updated":"2020-07-30 12:31:59.000000000","message":"this is fine, maybe you could build the url in a different way and just change the protocol instead","commit_id":"8697f3e1e1746ab89f17fbbeeb4450372bccce85"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"07d5501461202918632d62b14e2e2d730801890d","unresolved":false,"context_lines":[{"line_number":170,"context_line":"        if CONF.json_rpc.use_ssl:"},{"line_number":171,"context_line":"            scheme \u003d \u0027https\u0027"},{"line_number":172,"context_line":"        else:"},{"line_number":173,"context_line":"            scheme \u003d \u0027http\u0027"},{"line_number":174,"context_line":"        url \u003d \u0027%s://%s:%d\u0027 % (scheme, self.host, CONF.json_rpc.port)"},{"line_number":175,"context_line":"        result \u003d _get_session().post(url, json\u003dbody)"},{"line_number":176,"context_line":"        LOG.debug(\u0027RPC %s returned %s\u0027, method,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_7ae99e18","line":173,"updated":"2020-07-30 13:29:46.000000000","message":"nit: you could avoid the else defining \u0027scheme\u0027 before the if","commit_id":"bf28e7acc601b2ed550d881961d1e7e4890fd799"}]}
