)]}'
{"doc/source/admin/drivers/ilo.rst":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"2457c8e0e7e988303ae3fcdc0f35e9af72260692","unresolved":false,"context_lines":[{"line_number":309,"context_line":"  ``driver_info`` if ``ilo-uefi-https`` boot interface is used for ``ilo5``"},{"line_number":310,"context_line":"  hardware type:"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"  - ``deploy_kernel``: The glance UUID or a HTTPS URL of the deployment kernel."},{"line_number":313,"context_line":"  - ``deploy_ramdisk``: The glance UUID or a HTTPS URL of the deployment ramdisk."},{"line_number":314,"context_line":"  - ``bootloader``: The glance UUID or a HTTPS URL of the bootloader."},{"line_number":315,"context_line":"  - ``rescue_kernel``: The glance UUID or a HTTPS URL of the rescue kernel."}],"source_content_type":"text/x-rst","patch_set":15,"id":"9f560f44_1ec37759","line":312,"range":{"start_line":312,"start_character":27,"end_line":312,"end_character":33},"updated":"2020-09-15 07:05:43.000000000","message":"s/ glance / Glance","commit_id":"0a094a37cbd990039b1f583f5bae76475efbb844"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"08db06de21103c166faf1297c8a5ad544fb0977a","unresolved":false,"context_lines":[{"line_number":309,"context_line":"  ``driver_info`` if ``ilo-uefi-https`` boot interface is used for ``ilo5``"},{"line_number":310,"context_line":"  hardware type:"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"  - ``deploy_kernel``: The glance UUID or a HTTPS URL of the deployment kernel."},{"line_number":313,"context_line":"  - ``deploy_ramdisk``: The glance UUID or a HTTPS URL of the deployment ramdisk."},{"line_number":314,"context_line":"  - ``bootloader``: The glance UUID or a HTTPS URL of the bootloader."},{"line_number":315,"context_line":"  - ``rescue_kernel``: The glance UUID or a HTTPS URL of the rescue kernel."}],"source_content_type":"text/x-rst","patch_set":15,"id":"9f560f44_8b38e69f","line":312,"range":{"start_line":312,"start_character":27,"end_line":312,"end_character":33},"in_reply_to":"9f560f44_1ec37759","updated":"2020-09-15 11:49:54.000000000","message":"It\u0027s a copy/paste from existing text. WIll look odd if i change here but not else where.","commit_id":"0a094a37cbd990039b1f583f5bae76475efbb844"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"2457c8e0e7e988303ae3fcdc0f35e9af72260692","unresolved":false,"context_lines":[{"line_number":320,"context_line":"    ``agent``."},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"    .. note::"},{"line_number":323,"context_line":"       ``ilo-uefi-https`` boot interface is supported by only ``ilo5`` hardware"},{"line_number":324,"context_line":"       type. If the images are not hosted in glance, the references"},{"line_number":325,"context_line":"       must be HTTPS URLs hosted by secure webserver. This boot interface can"},{"line_number":326,"context_line":"       be used only when the current boot mode is ``UEFI``."},{"line_number":327,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"9f560f44_3eb59b33","line":324,"range":{"start_line":323,"start_character":6,"end_line":324,"end_character":12},"updated":"2020-09-15 07:05:43.000000000","message":"This looks redundant as this detail is mentioned at the beginning of this section L309-310.","commit_id":"0a094a37cbd990039b1f583f5bae76475efbb844"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"08db06de21103c166faf1297c8a5ad544fb0977a","unresolved":false,"context_lines":[{"line_number":320,"context_line":"    ``agent``."},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"    .. note::"},{"line_number":323,"context_line":"       ``ilo-uefi-https`` boot interface is supported by only ``ilo5`` hardware"},{"line_number":324,"context_line":"       type. If the images are not hosted in glance, the references"},{"line_number":325,"context_line":"       must be HTTPS URLs hosted by secure webserver. This boot interface can"},{"line_number":326,"context_line":"       be used only when the current boot mode is ``UEFI``."},{"line_number":327,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"9f560f44_ab016ab8","line":324,"range":{"start_line":323,"start_character":6,"end_line":324,"end_character":12},"in_reply_to":"9f560f44_3eb59b33","updated":"2020-09-15 11:49:54.000000000","message":"This calls out the limitation explicitly where as the reference pointed out explains how a node can be created if the user chooses to use \u0027ilo-uefi-https\u0027 boot interface.","commit_id":"0a094a37cbd990039b1f583f5bae76475efbb844"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"ec87bea2e9ce6c7f7a3eddd2af2efc948dfdeccf","unresolved":false,"context_lines":[{"line_number":474,"context_line":".. note::"},{"line_number":475,"context_line":"   HTTPS is strongly recommended over HTTP web server configuration for security"},{"line_number":476,"context_line":"   enhancement. The ``ilo-virtual-media`` boot interface will send the instance\u0027s"},{"line_number":477,"context_line":"   configdrive over an encrypted channel if web server is HTTPS enabled. However"},{"line_number":478,"context_line":"   for ``ilo-uefi-https`` boot interface HTTPS webserver is mandatory as this"},{"line_number":479,"context_line":"   interface only supports HTTPS URLs for deploy/instance images as well as for"},{"line_number":480,"context_line":"   temporary (ISO/floppy) images generated as part of the deploy/rescue operation."},{"line_number":481,"context_line":""},{"line_number":482,"context_line":"Enable driver"},{"line_number":483,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":15,"id":"9f560f44_524cc8c7","line":480,"range":{"start_line":477,"start_character":73,"end_line":480,"end_character":82},"updated":"2020-09-14 22:36:08.000000000","message":"This is a little confusing. It seems like the mention of the floppy images can be dropped since it is unrelated in my mind as configuration is embedded into the iso.\n\nOr maybe stop the sentence after \"HTTPS URLs\".","commit_id":"0a094a37cbd990039b1f583f5bae76475efbb844"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"2457c8e0e7e988303ae3fcdc0f35e9af72260692","unresolved":false,"context_lines":[{"line_number":474,"context_line":".. note::"},{"line_number":475,"context_line":"   HTTPS is strongly recommended over HTTP web server configuration for security"},{"line_number":476,"context_line":"   enhancement. The ``ilo-virtual-media`` boot interface will send the instance\u0027s"},{"line_number":477,"context_line":"   configdrive over an encrypted channel if web server is HTTPS enabled. However"},{"line_number":478,"context_line":"   for ``ilo-uefi-https`` boot interface HTTPS webserver is mandatory as this"},{"line_number":479,"context_line":"   interface only supports HTTPS URLs for deploy/instance images as well as for"},{"line_number":480,"context_line":"   temporary (ISO/floppy) images generated as part of the deploy/rescue operation."},{"line_number":481,"context_line":""},{"line_number":482,"context_line":"Enable driver"},{"line_number":483,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":15,"id":"9f560f44_9e7f8765","line":480,"range":{"start_line":477,"start_character":73,"end_line":480,"end_character":82},"in_reply_to":"9f560f44_524cc8c7","updated":"2020-09-15 07:05:43.000000000","message":"+1","commit_id":"0a094a37cbd990039b1f583f5bae76475efbb844"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"08db06de21103c166faf1297c8a5ad544fb0977a","unresolved":false,"context_lines":[{"line_number":474,"context_line":".. note::"},{"line_number":475,"context_line":"   HTTPS is strongly recommended over HTTP web server configuration for security"},{"line_number":476,"context_line":"   enhancement. The ``ilo-virtual-media`` boot interface will send the instance\u0027s"},{"line_number":477,"context_line":"   configdrive over an encrypted channel if web server is HTTPS enabled. However"},{"line_number":478,"context_line":"   for ``ilo-uefi-https`` boot interface HTTPS webserver is mandatory as this"},{"line_number":479,"context_line":"   interface only supports HTTPS URLs for deploy/instance images as well as for"},{"line_number":480,"context_line":"   temporary (ISO/floppy) images generated as part of the deploy/rescue operation."},{"line_number":481,"context_line":""},{"line_number":482,"context_line":"Enable driver"},{"line_number":483,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":15,"id":"9f560f44_0b1b361c","line":480,"range":{"start_line":477,"start_character":73,"end_line":480,"end_character":82},"in_reply_to":"9f560f44_524cc8c7","updated":"2020-09-15 11:49:54.000000000","message":"Agree. You are right. This doesn\u0027t use floppy media at all and the configuration is embedded into the ISO. will remove the text after HTTPS URLs as that adds confusion.","commit_id":"0a094a37cbd990039b1f583f5bae76475efbb844"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"08db06de21103c166faf1297c8a5ad544fb0977a","unresolved":false,"context_lines":[{"line_number":474,"context_line":".. note::"},{"line_number":475,"context_line":"   HTTPS is strongly recommended over HTTP web server configuration for security"},{"line_number":476,"context_line":"   enhancement. The ``ilo-virtual-media`` boot interface will send the instance\u0027s"},{"line_number":477,"context_line":"   configdrive over an encrypted channel if web server is HTTPS enabled. However"},{"line_number":478,"context_line":"   for ``ilo-uefi-https`` boot interface HTTPS webserver is mandatory as this"},{"line_number":479,"context_line":"   interface only supports HTTPS URLs for deploy/instance images as well as for"},{"line_number":480,"context_line":"   temporary (ISO/floppy) images generated as part of the deploy/rescue operation."},{"line_number":481,"context_line":""},{"line_number":482,"context_line":"Enable driver"},{"line_number":483,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":15,"id":"9f560f44_8b8bc61c","line":480,"range":{"start_line":477,"start_character":73,"end_line":480,"end_character":82},"in_reply_to":"9f560f44_9e7f8765","updated":"2020-09-15 11:49:54.000000000","message":"Done","commit_id":"0a094a37cbd990039b1f583f5bae76475efbb844"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"ec87bea2e9ce6c7f7a3eddd2af2efc948dfdeccf","unresolved":false,"context_lines":[{"line_number":2120,"context_line":".. note::"},{"line_number":2121,"context_line":"   Do not perform any iLO 5 configuration changes until this process is completed."},{"line_number":2122,"context_line":""},{"line_number":2123,"context_line":"UEFI-HTTPS Boot support"},{"line_number":2124,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":2125,"context_line":"The UEFI firmware on Gen10 HPE Proliant servers supports booting from secured URLs."},{"line_number":2126,"context_line":"With this capability ``ilo5`` hardware with ``ilo-uefi-https`` boot interface supports"}],"source_content_type":"text/x-rst","patch_set":15,"id":"9f560f44_72c8ec20","line":2123,"updated":"2020-09-14 22:36:08.000000000","message":"Serious ask for after this change. Start breaking up this entire driver doc into multiple files. This is a good place to start.","commit_id":"0a094a37cbd990039b1f583f5bae76475efbb844"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"08db06de21103c166faf1297c8a5ad544fb0977a","unresolved":false,"context_lines":[{"line_number":2120,"context_line":".. note::"},{"line_number":2121,"context_line":"   Do not perform any iLO 5 configuration changes until this process is completed."},{"line_number":2122,"context_line":""},{"line_number":2123,"context_line":"UEFI-HTTPS Boot support"},{"line_number":2124,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":2125,"context_line":"The UEFI firmware on Gen10 HPE Proliant servers supports booting from secured URLs."},{"line_number":2126,"context_line":"With this capability ``ilo5`` hardware with ``ilo-uefi-https`` boot interface supports"}],"source_content_type":"text/x-rst","patch_set":15,"id":"9f560f44_ab868a15","line":2123,"in_reply_to":"9f560f44_72c8ec20","updated":"2020-09-15 11:49:54.000000000","message":"Agree. But would you mind if this can be worked out in a separate patch as there are other things that also needs to be moved out.","commit_id":"0a094a37cbd990039b1f583f5bae76475efbb844"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"cb13c0a25eab12ae4184977a0f266d4f2369e00d","unresolved":false,"context_lines":[{"line_number":2120,"context_line":".. note::"},{"line_number":2121,"context_line":"   Do not perform any iLO 5 configuration changes until this process is completed."},{"line_number":2122,"context_line":""},{"line_number":2123,"context_line":"UEFI-HTTPS Boot support"},{"line_number":2124,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":2125,"context_line":"The UEFI firmware on Gen10 HPE Proliant servers supports booting from secured URLs."},{"line_number":2126,"context_line":"With this capability ``ilo5`` hardware with ``ilo-uefi-https`` boot interface supports"}],"source_content_type":"text/x-rst","patch_set":15,"id":"9f560f44_7cdef610","line":2123,"in_reply_to":"9f560f44_ab868a15","updated":"2020-09-15 13:26:13.000000000","message":"Absolutely okay to do as a separate change!","commit_id":"0a094a37cbd990039b1f583f5bae76475efbb844"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"cea8ffc6975af87a1967a5ce834597beeb5ed74e","unresolved":false,"context_lines":[{"line_number":2134,"context_line":""},{"line_number":2135,"context_line":"If the images are hosted on a HTTPS webserver or swift configured with HTTPS with"},{"line_number":2136,"context_line":"custom certificates, the user is required to export SSL certificates into iLO."},{"line_number":2137,"context_line":"Refer to `HPE Integrated Lights-Out Security Technology Brief \u003chttp://h20564.www2.hpe.com/hpsc/doc/public/display?docId\u003dc04530504\u003e`_"},{"line_number":2138,"context_line":"for more information."},{"line_number":2139,"context_line":""},{"line_number":2140,"context_line":"The following command can be used to enroll a ProLiant node with ``ilo5`` hardware type"}],"source_content_type":"text/x-rst","patch_set":18,"id":"9f560f44_05df900c","line":2137,"range":{"start_line":2137,"start_character":61,"end_line":2137,"end_character":132},"updated":"2020-09-16 11:08:01.000000000","message":"nit: All the links are at end of the page in this doc.\n`HPE Integrated Lights-Out Security Technology Brief`_\n\n.. _`HPE Integrated Lights-Out Security Technology Brief`: http://h20564.www2.hpe.com/hpsc/doc/public/display?docId\u003dc04530504","commit_id":"cd9a092f2404b465f17d12a00e078a755dd9ce23"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"dab4906182b5900abf87275d9fc7331befc50a9d","unresolved":false,"context_lines":[{"line_number":2134,"context_line":""},{"line_number":2135,"context_line":"If the images are hosted on a HTTPS webserver or swift configured with HTTPS with"},{"line_number":2136,"context_line":"custom certificates, the user is required to export SSL certificates into iLO."},{"line_number":2137,"context_line":"Refer to `HPE Integrated Lights-Out Security Technology Brief \u003chttp://h20564.www2.hpe.com/hpsc/doc/public/display?docId\u003dc04530504\u003e`_"},{"line_number":2138,"context_line":"for more information."},{"line_number":2139,"context_line":""},{"line_number":2140,"context_line":"The following command can be used to enroll a ProLiant node with ``ilo5`` hardware type"}],"source_content_type":"text/x-rst","patch_set":18,"id":"9f560f44_4bd357d6","line":2137,"range":{"start_line":2137,"start_character":61,"end_line":2137,"end_character":132},"in_reply_to":"9f560f44_05df900c","updated":"2020-09-16 12:22:47.000000000","message":"Done","commit_id":"cd9a092f2404b465f17d12a00e078a755dd9ce23"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"590c21051707b68198b1f4e2ec093a1ac531cd95","unresolved":false,"context_lines":[{"line_number":2155,"context_line":"        --driver-info ilo_bootloader\u003d\u003cglance-uuid-of-bootloader\u003e"},{"line_number":2156,"context_line":""},{"line_number":2157,"context_line":".. note::"},{"line_number":2158,"context_line":"   Currently secure boot is not supported with ``ilo-uefi-https`` boot interface."},{"line_number":2159,"context_line":""},{"line_number":2160,"context_line":""},{"line_number":2161,"context_line":".. _`ssacli documentation`: https://support.hpe.com/hpsc/doc/public/display?docId\u003dc03909334"}],"source_content_type":"text/x-rst","patch_set":19,"id":"9f560f44_93811451","line":2158,"range":{"start_line":2158,"start_character":3,"end_line":2158,"end_character":12},"updated":"2020-09-17 05:54:07.000000000","message":"s/ Currently //","commit_id":"e3de1772a098132ebcde2e52e8c8bc8f45c74c07"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"590c21051707b68198b1f4e2ec093a1ac531cd95","unresolved":false,"context_lines":[{"line_number":2155,"context_line":"        --driver-info ilo_bootloader\u003d\u003cglance-uuid-of-bootloader\u003e"},{"line_number":2156,"context_line":""},{"line_number":2157,"context_line":".. note::"},{"line_number":2158,"context_line":"   Currently secure boot is not supported with ``ilo-uefi-https`` boot interface."},{"line_number":2159,"context_line":""},{"line_number":2160,"context_line":""},{"line_number":2161,"context_line":".. _`ssacli documentation`: https://support.hpe.com/hpsc/doc/public/display?docId\u003dc03909334"}],"source_content_type":"text/x-rst","patch_set":19,"id":"9f560f44_33b12846","line":2158,"range":{"start_line":2158,"start_character":13,"end_line":2158,"end_character":24},"updated":"2020-09-17 05:54:07.000000000","message":"s/ secure boot / UEFI secure boot /","commit_id":"e3de1772a098132ebcde2e52e8c8bc8f45c74c07"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"9c92427a89ff70b270346b585fb39051284f0ee8","unresolved":false,"context_lines":[{"line_number":2155,"context_line":"        --driver-info ilo_bootloader\u003d\u003cglance-uuid-of-bootloader\u003e"},{"line_number":2156,"context_line":""},{"line_number":2157,"context_line":".. note::"},{"line_number":2158,"context_line":"   Currently secure boot is not supported with ``ilo-uefi-https`` boot interface."},{"line_number":2159,"context_line":""},{"line_number":2160,"context_line":""},{"line_number":2161,"context_line":".. _`ssacli documentation`: https://support.hpe.com/hpsc/doc/public/display?docId\u003dc03909334"}],"source_content_type":"text/x-rst","patch_set":19,"id":"9f560f44_cdd120cf","line":2158,"range":{"start_line":2158,"start_character":13,"end_line":2158,"end_character":24},"in_reply_to":"9f560f44_33b12846","updated":"2020-09-17 13:33:04.000000000","message":"Done","commit_id":"e3de1772a098132ebcde2e52e8c8bc8f45c74c07"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"9c92427a89ff70b270346b585fb39051284f0ee8","unresolved":false,"context_lines":[{"line_number":2155,"context_line":"        --driver-info ilo_bootloader\u003d\u003cglance-uuid-of-bootloader\u003e"},{"line_number":2156,"context_line":""},{"line_number":2157,"context_line":".. note::"},{"line_number":2158,"context_line":"   Currently secure boot is not supported with ``ilo-uefi-https`` boot interface."},{"line_number":2159,"context_line":""},{"line_number":2160,"context_line":""},{"line_number":2161,"context_line":".. _`ssacli documentation`: https://support.hpe.com/hpsc/doc/public/display?docId\u003dc03909334"}],"source_content_type":"text/x-rst","patch_set":19,"id":"9f560f44_2dd89cee","line":2158,"range":{"start_line":2158,"start_character":3,"end_line":2158,"end_character":12},"in_reply_to":"9f560f44_93811451","updated":"2020-09-17 13:33:04.000000000","message":"Done","commit_id":"e3de1772a098132ebcde2e52e8c8bc8f45c74c07"}],"ironic/drivers/ilo.py":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"81014694ac64f98beea4f84cf59c7b74afa1b746","unresolved":false,"context_lines":[{"line_number":80,"context_line":"    @property"},{"line_number":81,"context_line":"    def supported_boot_interfaces(self):"},{"line_number":82,"context_line":"        \"\"\"List of supported boot interfaces.\"\"\""},{"line_number":83,"context_line":"        return [boot.IloUefiHttpsBoot] + super("},{"line_number":84,"context_line":"            Ilo5Hardware, self).supported_boot_interfaces"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    @property"},{"line_number":87,"context_line":"    def supported_raid_interfaces(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_d152a468","line":84,"range":{"start_line":83,"start_character":8,"end_line":84,"end_character":57},"updated":"2020-08-28 10:27:17.000000000","message":"I think better not to make it default boot interface. Keep at the end.","commit_id":"cfd8684b17f0c4930fcfacde973f5bcf8c78aecc"}],"ironic/drivers/modules/ilo/boot.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"09ebd7a5ce0cef45dcb918593f0cb059bce39b06","unresolved":false,"context_lines":[{"line_number":39,"context_line":"from ironic.drivers.modules import deploy_utils"},{"line_number":40,"context_line":"from ironic.drivers.modules.ilo import common as ilo_common"},{"line_number":41,"context_line":"from ironic.drivers.modules import ipxe"},{"line_number":42,"context_line":"from ironic.drivers.modules import image_utils"},{"line_number":43,"context_line":"from ironic.drivers.modules import pxe"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_60395aa2","line":42,"updated":"2020-08-10 10:51:16.000000000","message":"pep8: H306: imports not in alphabetical order (ironic.drivers.modules.ipxe, ironic.drivers.modules.image_utils)","commit_id":"626c099d98d12aa9f87b578003d4b11681abe551"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"09ebd7a5ce0cef45dcb918593f0cb059bce39b06","unresolved":false,"context_lines":[{"line_number":930,"context_line":"        This method validates whether the \u0027driver_info\u0027 property of the"},{"line_number":931,"context_line":"        supplied node contains the required information for this driver to"},{"line_number":932,"context_line":"        deploy images to the node."},{"line_number":933,"context_line":"    "},{"line_number":934,"context_line":"        :param node: a single Node."},{"line_number":935,"context_line":"        :param mode: Label indicating a deploy or rescue operation being"},{"line_number":936,"context_line":"                     carried out on the node. Supported values are"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_403c1692","line":933,"updated":"2020-08-10 10:51:16.000000000","message":"pep8: W293 blank line contains whitespace","commit_id":"626c099d98d12aa9f87b578003d4b11681abe551"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"09ebd7a5ce0cef45dcb918593f0cb059bce39b06","unresolved":false,"context_lines":[{"line_number":942,"context_line":"        \"\"\""},{"line_number":943,"context_line":""},{"line_number":944,"context_line":"        d_info \u003d node.driver_info"},{"line_number":945,"context_line":"    "},{"line_number":946,"context_line":"        deploy_info \u003d {option: d_info.get(option)"},{"line_number":947,"context_line":"                       for option in REQUIRED_PROPERTIES_UEFI_HTTPS_BOOT}"},{"line_number":948,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_a03ff284","line":945,"updated":"2020-08-10 10:51:16.000000000","message":"pep8: W293 blank line contains whitespace","commit_id":"626c099d98d12aa9f87b578003d4b11681abe551"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"09ebd7a5ce0cef45dcb918593f0cb059bce39b06","unresolved":false,"context_lines":[{"line_number":948,"context_line":""},{"line_number":949,"context_line":"        error_msg \u003d _(\"Error validating iLO UEFI HTTPS boot interface. Some \""},{"line_number":950,"context_line":"                      \"parameters were missing in node\u0027s driver_info\")"},{"line_number":951,"context_line":"    "},{"line_number":952,"context_line":"        deploy_utils.check_for_missing_params(deploy_info, error_msg)"},{"line_number":953,"context_line":""},{"line_number":954,"context_line":"        deploy_info.update(ilo_common.parse_driver_info(node))"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_8042ae0d","line":951,"updated":"2020-08-10 10:51:16.000000000","message":"pep8: W293 blank line contains whitespace","commit_id":"626c099d98d12aa9f87b578003d4b11681abe551"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"09ebd7a5ce0cef45dcb918593f0cb059bce39b06","unresolved":false,"context_lines":[{"line_number":952,"context_line":"        deploy_utils.check_for_missing_params(deploy_info, error_msg)"},{"line_number":953,"context_line":""},{"line_number":954,"context_line":"        deploy_info.update(ilo_common.parse_driver_info(node))"},{"line_number":955,"context_line":"    "},{"line_number":956,"context_line":"        return deploy_info"},{"line_number":957,"context_line":""},{"line_number":958,"context_line":"    def _validate_driver_info(self, task):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_e04c4a43","line":955,"updated":"2020-08-10 10:51:16.000000000","message":"pep8: W293 blank line contains whitespace","commit_id":"626c099d98d12aa9f87b578003d4b11681abe551"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"09ebd7a5ce0cef45dcb918593f0cb059bce39b06","unresolved":false,"context_lines":[{"line_number":972,"context_line":""},{"line_number":973,"context_line":"    def _validate_instance_image_info(self, task):"},{"line_number":974,"context_line":"        \"\"\"Validate instance image information for the task\u0027s node."},{"line_number":975,"context_line":"    "},{"line_number":976,"context_line":"        :param task: a TaskManager instance containing the node to act on."},{"line_number":977,"context_line":"        :raises: InvalidParameterValue, if some information is invalid."},{"line_number":978,"context_line":"        :raises: MissingParameterValue if \u0027kernel_id\u0027 and \u0027ramdisk_id\u0027 are"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_c047861c","line":975,"updated":"2020-08-10 10:51:16.000000000","message":"pep8: W293 blank line contains whitespace","commit_id":"626c099d98d12aa9f87b578003d4b11681abe551"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"09ebd7a5ce0cef45dcb918593f0cb059bce39b06","unresolved":false,"context_lines":[{"line_number":1131,"context_line":"        \"\"\""},{"line_number":1132,"context_line":""},{"line_number":1133,"context_line":"        boot_mode \u003d boot_mode_utils.get_boot_mode(task.node)"},{"line_number":1134,"context_line":"        boot_option \u003d deploy_utils.get_boot_option(task.node)"},{"line_number":1135,"context_line":""},{"line_number":1136,"context_line":"        if deploy_utils.is_iscsi_boot(task):"},{"line_number":1137,"context_line":"            # It will set iSCSI info onto iLO"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_2053e2e3","line":1134,"updated":"2020-08-10 10:51:16.000000000","message":"pep8: F841 local variable \u0027boot_option\u0027 is assigned to but never used","commit_id":"626c099d98d12aa9f87b578003d4b11681abe551"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"d0a8f2ad998cb53c35be7045054cac11adc56dc6","unresolved":false,"context_lines":[{"line_number":39,"context_line":"from ironic.drivers.modules import deploy_utils"},{"line_number":40,"context_line":"from ironic.drivers.modules.ilo import common as ilo_common"},{"line_number":41,"context_line":"from ironic.drivers.modules import ipxe"},{"line_number":42,"context_line":"from ironic.drivers.modules import image_utils"},{"line_number":43,"context_line":"from ironic.drivers.modules import pxe"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_69518336","line":42,"updated":"2020-08-24 09:56:54.000000000","message":"pep8: H306: imports not in alphabetical order (ironic.drivers.modules.ipxe, ironic.drivers.modules.image_utils)","commit_id":"3641eaece282539dabd87f74a2b20ff351d41762"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"d0a8f2ad998cb53c35be7045054cac11adc56dc6","unresolved":false,"context_lines":[{"line_number":886,"context_line":""},{"line_number":887,"context_line":""},{"line_number":888,"context_line":"class IloUefiHttpsBoot(base.BootInterface):"},{"line_number":889,"context_line":" "},{"line_number":890,"context_line":"    capabilities \u003d [\u0027iscsi_volume_boot\u0027, \u0027ramdisk_boot\u0027]"},{"line_number":891,"context_line":""},{"line_number":892,"context_line":"    def get_properties(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_c9424f68","line":889,"updated":"2020-08-24 09:56:54.000000000","message":"pep8: W293 blank line contains whitespace","commit_id":"3641eaece282539dabd87f74a2b20ff351d41762"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"d0a8f2ad998cb53c35be7045054cac11adc56dc6","unresolved":false,"context_lines":[{"line_number":902,"context_line":"        This method validates whether the \u0027driver_info\u0027 property of the"},{"line_number":903,"context_line":"        supplied node contains the required information for this driver to"},{"line_number":904,"context_line":"        deploy images to the node."},{"line_number":905,"context_line":"    "},{"line_number":906,"context_line":"        :param node: a single Node."},{"line_number":907,"context_line":"        :param mode: Label indicating a deploy or rescue operation being"},{"line_number":908,"context_line":"                     carried out on the node. Supported values are"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_a9471b77","line":905,"updated":"2020-08-24 09:56:54.000000000","message":"pep8: W293 blank line contains whitespace","commit_id":"3641eaece282539dabd87f74a2b20ff351d41762"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"d0a8f2ad998cb53c35be7045054cac11adc56dc6","unresolved":false,"context_lines":[{"line_number":914,"context_line":"        \"\"\""},{"line_number":915,"context_line":""},{"line_number":916,"context_line":"        d_info \u003d node.driver_info"},{"line_number":917,"context_line":"    "},{"line_number":918,"context_line":"        deploy_info \u003d {option: d_info.get(option)"},{"line_number":919,"context_line":"                       for option in REQUIRED_PROPERTIES_UEFI_HTTPS_BOOT}"},{"line_number":920,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_0960c700","line":917,"updated":"2020-08-24 09:56:54.000000000","message":"pep8: W293 blank line contains whitespace","commit_id":"3641eaece282539dabd87f74a2b20ff351d41762"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"d0a8f2ad998cb53c35be7045054cac11adc56dc6","unresolved":false,"context_lines":[{"line_number":920,"context_line":""},{"line_number":921,"context_line":"        error_msg \u003d _(\"Error validating iLO UEFI HTTPS boot interface. Some \""},{"line_number":922,"context_line":"                      \"parameters were missing in node\u0027s driver_info\")"},{"line_number":923,"context_line":"    "},{"line_number":924,"context_line":"        deploy_utils.check_for_missing_params(deploy_info, error_msg)"},{"line_number":925,"context_line":""},{"line_number":926,"context_line":"        deploy_info.update(ilo_common.parse_driver_info(node))"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_e95c734c","line":923,"updated":"2020-08-24 09:56:54.000000000","message":"pep8: W293 blank line contains whitespace","commit_id":"3641eaece282539dabd87f74a2b20ff351d41762"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"d0a8f2ad998cb53c35be7045054cac11adc56dc6","unresolved":false,"context_lines":[{"line_number":924,"context_line":"        deploy_utils.check_for_missing_params(deploy_info, error_msg)"},{"line_number":925,"context_line":""},{"line_number":926,"context_line":"        deploy_info.update(ilo_common.parse_driver_info(node))"},{"line_number":927,"context_line":"    "},{"line_number":928,"context_line":"        return deploy_info"},{"line_number":929,"context_line":""},{"line_number":930,"context_line":"    def _validate_driver_info(self, task):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_49563f2c","line":927,"updated":"2020-08-24 09:56:54.000000000","message":"pep8: W293 blank line contains whitespace","commit_id":"3641eaece282539dabd87f74a2b20ff351d41762"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"d0a8f2ad998cb53c35be7045054cac11adc56dc6","unresolved":false,"context_lines":[{"line_number":944,"context_line":""},{"line_number":945,"context_line":"    def _validate_instance_image_info(self, task):"},{"line_number":946,"context_line":"        \"\"\"Validate instance image information for the task\u0027s node."},{"line_number":947,"context_line":"    "},{"line_number":948,"context_line":"        :param task: a TaskManager instance containing the node to act on."},{"line_number":949,"context_line":"        :raises: InvalidParameterValue, if some information is invalid."},{"line_number":950,"context_line":"        :raises: MissingParameterValue if \u0027kernel_id\u0027 and \u0027ramdisk_id\u0027 are"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_29530b3b","line":947,"updated":"2020-08-24 09:56:54.000000000","message":"pep8: W293 blank line contains whitespace","commit_id":"3641eaece282539dabd87f74a2b20ff351d41762"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"d0a8f2ad998cb53c35be7045054cac11adc56dc6","unresolved":false,"context_lines":[{"line_number":974,"context_line":"        :raises: InvalidParameterValue on malformed parameter(s)"},{"line_number":975,"context_line":"        :raises: MissingParameterValue on missing parameter(s)"},{"line_number":976,"context_line":"        \"\"\""},{"line_number":977,"context_line":"        boot_option \u003d deploy_utils.get_boot_option(node)"},{"line_number":978,"context_line":"        boot_iso \u003d node.instance_info.get(\u0027ilo_boot_iso\u0027)"},{"line_number":979,"context_line":"        if (boot_option \u003d\u003d \"ramdisk\" and boot_iso):"},{"line_number":980,"context_line":"            if not service_utils.is_glance_image(boot_iso):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_8931770e","line":977,"updated":"2020-08-24 09:56:54.000000000","message":"pep8: F821 undefined name \u0027node\u0027","commit_id":"3641eaece282539dabd87f74a2b20ff351d41762"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"d0a8f2ad998cb53c35be7045054cac11adc56dc6","unresolved":false,"context_lines":[{"line_number":975,"context_line":"        :raises: MissingParameterValue on missing parameter(s)"},{"line_number":976,"context_line":"        \"\"\""},{"line_number":977,"context_line":"        boot_option \u003d deploy_utils.get_boot_option(node)"},{"line_number":978,"context_line":"        boot_iso \u003d node.instance_info.get(\u0027ilo_boot_iso\u0027)"},{"line_number":979,"context_line":"        if (boot_option \u003d\u003d \"ramdisk\" and boot_iso):"},{"line_number":980,"context_line":"            if not service_utils.is_glance_image(boot_iso):"},{"line_number":981,"context_line":"                try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_6936a305","line":978,"updated":"2020-08-24 09:56:54.000000000","message":"pep8: F821 undefined name \u0027node\u0027","commit_id":"3641eaece282539dabd87f74a2b20ff351d41762"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"d0a8f2ad998cb53c35be7045054cac11adc56dc6","unresolved":false,"context_lines":[{"line_number":1119,"context_line":"        \"\"\""},{"line_number":1120,"context_line":""},{"line_number":1121,"context_line":"        boot_mode \u003d boot_mode_utils.get_boot_mode(task.node)"},{"line_number":1122,"context_line":"        boot_option \u003d deploy_utils.get_boot_option(task.node)"},{"line_number":1123,"context_line":""},{"line_number":1124,"context_line":"        if deploy_utils.is_iscsi_boot(task):"},{"line_number":1125,"context_line":"            # It will set iSCSI info onto iLO"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_c937effd","line":1122,"updated":"2020-08-24 09:56:54.000000000","message":"pep8: F841 local variable \u0027boot_option\u0027 is assigned to but never used","commit_id":"3641eaece282539dabd87f74a2b20ff351d41762"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"81014694ac64f98beea4f84cf59c7b74afa1b746","unresolved":false,"context_lines":[{"line_number":62,"context_line":"                       \"Required.\"),"},{"line_number":63,"context_line":"    \u0027deploy_ramdisk\u0027: _(\"URL or Glance UUID of the ramdisk that is \""},{"line_number":64,"context_line":"                        \"mounted at boot time. Required.\"),"},{"line_number":65,"context_line":"    \u0027bootloader\u0027: _(\"URL or Glance UUID  of the EFI system partition \""},{"line_number":66,"context_line":"                    \"image containing EFI boot loader. This image will be \""},{"line_number":67,"context_line":"                    \"used by ironic when building UEFI-bootable ISO \""},{"line_number":68,"context_line":"                    \"out of kernel and ramdisk. Required for UEFI \""}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_0caa4370","line":65,"range":{"start_line":65,"start_character":5,"end_line":65,"end_character":15},"updated":"2020-08-28 10:27:17.000000000","message":"Can we add \u0027verify_ca\u0027 argument here that can take the CA certificate input that can override config param?","commit_id":"cfd8684b17f0c4930fcfacde973f5bcf8c78aecc"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"81014694ac64f98beea4f84cf59c7b74afa1b746","unresolved":false,"context_lines":[{"line_number":925,"context_line":"        deploy_info \u003d {}"},{"line_number":926,"context_line":"        deploy_info.update(deploy_utils.get_image_instance_info(node))"},{"line_number":927,"context_line":"        deploy_info.update(self._parse_driver_info(node))"},{"line_number":928,"context_line":"        deploy_info.update(node.instance_info.copy())"},{"line_number":929,"context_line":""},{"line_number":930,"context_line":"        return deploy_info"},{"line_number":931,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_11909ced","line":928,"range":{"start_line":928,"start_character":8,"end_line":928,"end_character":53},"updated":"2020-08-28 10:27:17.000000000","message":"Do we need this after info collected from L926?","commit_id":"cfd8684b17f0c4930fcfacde973f5bcf8c78aecc"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"ab99a1dcf1b437b1593b5fe64c96bc4d8ffb7e43","unresolved":false,"context_lines":[{"line_number":925,"context_line":"        deploy_info \u003d {}"},{"line_number":926,"context_line":"        deploy_info.update(deploy_utils.get_image_instance_info(node))"},{"line_number":927,"context_line":"        deploy_info.update(self._parse_driver_info(node))"},{"line_number":928,"context_line":"        deploy_info.update(node.instance_info.copy())"},{"line_number":929,"context_line":""},{"line_number":930,"context_line":"        return deploy_info"},{"line_number":931,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_2a5282df","line":928,"range":{"start_line":928,"start_character":8,"end_line":928,"end_character":53},"in_reply_to":"9f560f44_11909ced","updated":"2020-08-28 16:09:52.000000000","message":"Done","commit_id":"cfd8684b17f0c4930fcfacde973f5bcf8c78aecc"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"81014694ac64f98beea4f84cf59c7b74afa1b746","unresolved":false,"context_lines":[{"line_number":930,"context_line":"        return deploy_info"},{"line_number":931,"context_line":""},{"line_number":932,"context_line":"    def _parse_driver_info(self, node, mode\u003d\u0027deploy\u0027):"},{"line_number":933,"context_line":"        \"\"\"Gets the driver specific Node deployment info."},{"line_number":934,"context_line":""},{"line_number":935,"context_line":"        This method validates whether the \u0027driver_info\u0027 property of the"},{"line_number":936,"context_line":"        supplied node contains the required information for this driver to"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_5160540e","line":933,"range":{"start_line":933,"start_character":41,"end_line":933,"end_character":51},"updated":"2020-08-28 10:27:17.000000000","message":"s/ deployment / driver / ?","commit_id":"cfd8684b17f0c4930fcfacde973f5bcf8c78aecc"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"ab99a1dcf1b437b1593b5fe64c96bc4d8ffb7e43","unresolved":false,"context_lines":[{"line_number":930,"context_line":"        return deploy_info"},{"line_number":931,"context_line":""},{"line_number":932,"context_line":"    def _parse_driver_info(self, node, mode\u003d\u0027deploy\u0027):"},{"line_number":933,"context_line":"        \"\"\"Gets the driver specific Node deployment info."},{"line_number":934,"context_line":""},{"line_number":935,"context_line":"        This method validates whether the \u0027driver_info\u0027 property of the"},{"line_number":936,"context_line":"        supplied node contains the required information for this driver to"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_6a5d9aeb","line":933,"range":{"start_line":933,"start_character":41,"end_line":933,"end_character":51},"in_reply_to":"9f560f44_5160540e","updated":"2020-08-28 16:09:52.000000000","message":"Will change the docstring to \n\"Gets the node specific deploy/rescue info.\"","commit_id":"cfd8684b17f0c4930fcfacde973f5bcf8c78aecc"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"81014694ac64f98beea4f84cf59c7b74afa1b746","unresolved":false,"context_lines":[{"line_number":955,"context_line":"        deploy_info \u003d {option: info.get(option)"},{"line_number":956,"context_line":"                       for option in params_to_check}"},{"line_number":957,"context_line":""},{"line_number":958,"context_line":"        error_msg \u003d (_(\"Error validating iLO Uefi Https for %s. Some \""},{"line_number":959,"context_line":"                       \"parameters were missing in node\u0027s driver_info\") % mode)"},{"line_number":960,"context_line":"        deploy_utils.check_for_missing_params(deploy_info, error_msg)"},{"line_number":961,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_716f58fc","line":958,"range":{"start_line":958,"start_character":45,"end_line":958,"end_character":55},"updated":"2020-08-28 10:27:17.000000000","message":"s/ Uefi Https / UEFI HTTPS /","commit_id":"cfd8684b17f0c4930fcfacde973f5bcf8c78aecc"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"ab99a1dcf1b437b1593b5fe64c96bc4d8ffb7e43","unresolved":false,"context_lines":[{"line_number":955,"context_line":"        deploy_info \u003d {option: info.get(option)"},{"line_number":956,"context_line":"                       for option in params_to_check}"},{"line_number":957,"context_line":""},{"line_number":958,"context_line":"        error_msg \u003d (_(\"Error validating iLO Uefi Https for %s. Some \""},{"line_number":959,"context_line":"                       \"parameters were missing in node\u0027s driver_info\") % mode)"},{"line_number":960,"context_line":"        deploy_utils.check_for_missing_params(deploy_info, error_msg)"},{"line_number":961,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_eacc0a8c","line":958,"range":{"start_line":958,"start_character":45,"end_line":958,"end_character":55},"in_reply_to":"9f560f44_716f58fc","updated":"2020-08-28 16:09:52.000000000","message":"Done","commit_id":"cfd8684b17f0c4930fcfacde973f5bcf8c78aecc"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"81014694ac64f98beea4f84cf59c7b74afa1b746","unresolved":false,"context_lines":[{"line_number":1019,"context_line":"                    image_service.HttpImageService().validate_href(boot_iso)"},{"line_number":1020,"context_line":"                except exception.ImageRefValidationFailed:"},{"line_number":1021,"context_line":"                    with excutils.save_and_reraise_exception():"},{"line_number":1022,"context_line":"                        LOG.error(\"Uefi-Https boot with \u0027ramdisk\u0027 \""},{"line_number":1023,"context_line":"                                  \"boot_option accepts only Glance images or \""},{"line_number":1024,"context_line":"                                  \"HTTP(S) URLs as \""},{"line_number":1025,"context_line":"                                  \"instance_info[\u0027ilo_boot_iso\u0027]. Either %s \""}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_cc3debbd","line":1022,"range":{"start_line":1022,"start_character":35,"end_line":1022,"end_character":45},"updated":"2020-08-28 10:27:17.000000000","message":"s/ Uefi-Https / UEFI-HTTPS /","commit_id":"cfd8684b17f0c4930fcfacde973f5bcf8c78aecc"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"ab99a1dcf1b437b1593b5fe64c96bc4d8ffb7e43","unresolved":false,"context_lines":[{"line_number":1019,"context_line":"                    image_service.HttpImageService().validate_href(boot_iso)"},{"line_number":1020,"context_line":"                except exception.ImageRefValidationFailed:"},{"line_number":1021,"context_line":"                    with excutils.save_and_reraise_exception():"},{"line_number":1022,"context_line":"                        LOG.error(\"Uefi-Https boot with \u0027ramdisk\u0027 \""},{"line_number":1023,"context_line":"                                  \"boot_option accepts only Glance images or \""},{"line_number":1024,"context_line":"                                  \"HTTP(S) URLs as \""},{"line_number":1025,"context_line":"                                  \"instance_info[\u0027ilo_boot_iso\u0027]. Either %s \""}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_e5c27d86","line":1022,"range":{"start_line":1022,"start_character":35,"end_line":1022,"end_character":45},"in_reply_to":"9f560f44_cc3debbd","updated":"2020-08-28 16:09:52.000000000","message":"Done","commit_id":"cfd8684b17f0c4930fcfacde973f5bcf8c78aecc"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"81014694ac64f98beea4f84cf59c7b74afa1b746","unresolved":false,"context_lines":[{"line_number":1099,"context_line":"        deploy_nic_mac \u003d deploy_utils.get_single_nic_with_vif_port_id(task)"},{"line_number":1100,"context_line":"        ramdisk_params[\u0027BOOTIF\u0027] \u003d deploy_nic_mac"},{"line_number":1101,"context_line":""},{"line_number":1102,"context_line":"        mode \u003d \u0027deploy\u0027"},{"line_number":1103,"context_line":"        if node.provision_state \u003d\u003d states.RESCUING:"},{"line_number":1104,"context_line":"            mode \u003d \u0027rescue\u0027"},{"line_number":1105,"context_line":""},{"line_number":1106,"context_line":"        d_info \u003d self._parse_driver_info(node, mode)"},{"line_number":1107,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_4c343bad","line":1104,"range":{"start_line":1102,"start_character":8,"end_line":1104,"end_character":27},"updated":"2020-08-28 10:27:17.000000000","message":"Use deploy_utils.rescue_or_deploy_mode(node) instead.","commit_id":"cfd8684b17f0c4930fcfacde973f5bcf8c78aecc"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"ab99a1dcf1b437b1593b5fe64c96bc4d8ffb7e43","unresolved":false,"context_lines":[{"line_number":1099,"context_line":"        deploy_nic_mac \u003d deploy_utils.get_single_nic_with_vif_port_id(task)"},{"line_number":1100,"context_line":"        ramdisk_params[\u0027BOOTIF\u0027] \u003d deploy_nic_mac"},{"line_number":1101,"context_line":""},{"line_number":1102,"context_line":"        mode \u003d \u0027deploy\u0027"},{"line_number":1103,"context_line":"        if node.provision_state \u003d\u003d states.RESCUING:"},{"line_number":1104,"context_line":"            mode \u003d \u0027rescue\u0027"},{"line_number":1105,"context_line":""},{"line_number":1106,"context_line":"        d_info \u003d self._parse_driver_info(node, mode)"},{"line_number":1107,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_8a9bce64","line":1104,"range":{"start_line":1102,"start_character":8,"end_line":1104,"end_character":27},"in_reply_to":"9f560f44_4c343bad","updated":"2020-08-28 16:09:52.000000000","message":"Actually the method suggested checks for all the rescue states i.e \nRESCUE_LIKE_STATES \u003d (states.RESCUING, states.RESCUEWAIT, states.RESCUEFAIL, states.UNRESCUING, states.UNRESCUEFAIL)\nBut from L-1074 the only possible state is states.RESCUING. So instead of calling the function it\u0027d better to just check the condition. WDYT?","commit_id":"cfd8684b17f0c4930fcfacde973f5bcf8c78aecc"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"81014694ac64f98beea4f84cf59c7b74afa1b746","unresolved":false,"context_lines":[{"line_number":1114,"context_line":"        LOG.debug(\"Node %(node)s is set to boot from URL\""},{"line_number":1115,"context_line":"                  \"%(iso_ref)s\", {\u0027node\u0027: node.uuid, \u0027iso_ref\u0027: iso_ref})"},{"line_number":1116,"context_line":""},{"line_number":1117,"context_line":"        ilo_common.setup_uefi_https(task, iso_ref)"},{"line_number":1118,"context_line":""},{"line_number":1119,"context_line":"    @METRICS.timer(\u0027IloUefiHttpsBoot.clean_up_ramdisk\u0027)"},{"line_number":1120,"context_line":"    def clean_up_ramdisk(self, task):"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_4c9efb69","line":1117,"range":{"start_line":1117,"start_character":19,"end_line":1117,"end_character":35},"updated":"2020-08-28 10:27:17.000000000","message":"Is it required that node be already in UEFI boot mode or the pending boot mode of UEFI is fine?","commit_id":"cfd8684b17f0c4930fcfacde973f5bcf8c78aecc"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"ab99a1dcf1b437b1593b5fe64c96bc4d8ffb7e43","unresolved":false,"context_lines":[{"line_number":1114,"context_line":"        LOG.debug(\"Node %(node)s is set to boot from URL\""},{"line_number":1115,"context_line":"                  \"%(iso_ref)s\", {\u0027node\u0027: node.uuid, \u0027iso_ref\u0027: iso_ref})"},{"line_number":1116,"context_line":""},{"line_number":1117,"context_line":"        ilo_common.setup_uefi_https(task, iso_ref)"},{"line_number":1118,"context_line":""},{"line_number":1119,"context_line":"    @METRICS.timer(\u0027IloUefiHttpsBoot.clean_up_ramdisk\u0027)"},{"line_number":1120,"context_line":"    def clean_up_ramdisk(self, task):"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_65814d4e","line":1117,"range":{"start_line":1117,"start_character":19,"end_line":1117,"end_character":35},"in_reply_to":"9f560f44_4c9efb69","updated":"2020-08-28 16:09:52.000000000","message":"Good catch! \nI just tried and realized that the node\u0027s current boot mode should be in UEFI regardless of pending boot mode. So should we call it out in the doc explicitly?","commit_id":"cfd8684b17f0c4930fcfacde973f5bcf8c78aecc"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"49de25fc05ef50780c9a4d134dd9cffeb5058dbc","unresolved":false,"context_lines":[{"line_number":930,"context_line":"        if len(insecure_props) \u003e 0:"},{"line_number":931,"context_line":"            error \u003d (_(\u0027Secured URLs exposed over HTTPS are expected. \u0027"},{"line_number":932,"context_line":"                       \u0027Insecured URLs are provided for %s\u0027) % insecure_props)"},{"line_number":933,"context_line":"            raise exception.MissingParameterValue(error)"},{"line_number":934,"context_line":""},{"line_number":935,"context_line":"    def _parse_deploy_info(self, node):"},{"line_number":936,"context_line":"        \"\"\"Gets the instance and driver specific Node deployment info."}],"source_content_type":"text/x-python","patch_set":11,"id":"9f560f44_619fd7b3","line":933,"range":{"start_line":933,"start_character":28,"end_line":933,"end_character":49},"updated":"2020-09-09 16:16:41.000000000","message":"Should be InvalidParameterValue.","commit_id":"30dae4acb903b051463e045a789b1acc1ee38de4"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"73d63e44e1e61a71f8e4ff1981309ff02694839a","unresolved":false,"context_lines":[{"line_number":930,"context_line":"        if len(insecure_props) \u003e 0:"},{"line_number":931,"context_line":"            error \u003d (_(\u0027Secured URLs exposed over HTTPS are expected. \u0027"},{"line_number":932,"context_line":"                       \u0027Insecured URLs are provided for %s\u0027) % insecure_props)"},{"line_number":933,"context_line":"            raise exception.MissingParameterValue(error)"},{"line_number":934,"context_line":""},{"line_number":935,"context_line":"    def _parse_deploy_info(self, node):"},{"line_number":936,"context_line":"        \"\"\"Gets the instance and driver specific Node deployment info."}],"source_content_type":"text/x-python","patch_set":11,"id":"9f560f44_c4d7c4ed","line":933,"range":{"start_line":933,"start_character":28,"end_line":933,"end_character":49},"in_reply_to":"9f560f44_619fd7b3","updated":"2020-09-10 09:10:10.000000000","message":"Done","commit_id":"30dae4acb903b051463e045a789b1acc1ee38de4"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"49de25fc05ef50780c9a4d134dd9cffeb5058dbc","unresolved":false,"context_lines":[{"line_number":952,"context_line":""},{"line_number":953,"context_line":"        return deploy_info"},{"line_number":954,"context_line":""},{"line_number":955,"context_line":"    def _parse_driver_info(self, node, mode\u003d\u0027deploy\u0027):"},{"line_number":956,"context_line":"        \"\"\"Gets the node specific deploy/rescue info."},{"line_number":957,"context_line":""},{"line_number":958,"context_line":"        This method validates whether the \u0027driver_info\u0027 property of the"}],"source_content_type":"text/x-python","patch_set":11,"id":"9f560f44_01125b58","line":955,"range":{"start_line":955,"start_character":39,"end_line":955,"end_character":52},"updated":"2020-09-09 16:16:41.000000000","message":"This is not required. mode can be obtained as commented on L973 below.","commit_id":"30dae4acb903b051463e045a789b1acc1ee38de4"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"73d63e44e1e61a71f8e4ff1981309ff02694839a","unresolved":false,"context_lines":[{"line_number":952,"context_line":""},{"line_number":953,"context_line":"        return deploy_info"},{"line_number":954,"context_line":""},{"line_number":955,"context_line":"    def _parse_driver_info(self, node, mode\u003d\u0027deploy\u0027):"},{"line_number":956,"context_line":"        \"\"\"Gets the node specific deploy/rescue info."},{"line_number":957,"context_line":""},{"line_number":958,"context_line":"        This method validates whether the \u0027driver_info\u0027 property of the"}],"source_content_type":"text/x-python","patch_set":11,"id":"9f560f44_04909c42","line":955,"range":{"start_line":955,"start_character":39,"end_line":955,"end_character":52},"in_reply_to":"9f560f44_01125b58","updated":"2020-09-10 09:10:10.000000000","message":"Yes, but wherever this function is called the mode is already obtained so why recalculate again?","commit_id":"30dae4acb903b051463e045a789b1acc1ee38de4"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"49de25fc05ef50780c9a4d134dd9cffeb5058dbc","unresolved":false,"context_lines":[{"line_number":970,"context_line":"        \"\"\""},{"line_number":971,"context_line":"        info \u003d node.driver_info"},{"line_number":972,"context_line":""},{"line_number":973,"context_line":"        if mode \u003d\u003d \u0027rescue\u0027:"},{"line_number":974,"context_line":"            params_to_check \u003d RESCUE_PROPERTIES_UEFI_HTTPS_BOOT.keys()"},{"line_number":975,"context_line":"        else:"},{"line_number":976,"context_line":"            params_to_check \u003d REQUIRED_PROPERTIES_UEFI_HTTPS_BOOT.keys()"},{"line_number":977,"context_line":""},{"line_number":978,"context_line":"        deploy_info \u003d {option: info.get(option)"},{"line_number":979,"context_line":"                       for option in params_to_check}"}],"source_content_type":"text/x-python","patch_set":11,"id":"9f560f44_212e7f8b","line":976,"range":{"start_line":973,"start_character":8,"end_line":976,"end_character":72},"updated":"2020-09-09 16:16:41.000000000","message":"mode can be found using deploy_utils.rescue_or_deploy_mode(node)","commit_id":"30dae4acb903b051463e045a789b1acc1ee38de4"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"73d63e44e1e61a71f8e4ff1981309ff02694839a","unresolved":false,"context_lines":[{"line_number":970,"context_line":"        \"\"\""},{"line_number":971,"context_line":"        info \u003d node.driver_info"},{"line_number":972,"context_line":""},{"line_number":973,"context_line":"        if mode \u003d\u003d \u0027rescue\u0027:"},{"line_number":974,"context_line":"            params_to_check \u003d RESCUE_PROPERTIES_UEFI_HTTPS_BOOT.keys()"},{"line_number":975,"context_line":"        else:"},{"line_number":976,"context_line":"            params_to_check \u003d REQUIRED_PROPERTIES_UEFI_HTTPS_BOOT.keys()"},{"line_number":977,"context_line":""},{"line_number":978,"context_line":"        deploy_info \u003d {option: info.get(option)"},{"line_number":979,"context_line":"                       for option in params_to_check}"}],"source_content_type":"text/x-python","patch_set":11,"id":"9f560f44_84ccac6a","line":976,"range":{"start_line":973,"start_character":8,"end_line":976,"end_character":72},"in_reply_to":"9f560f44_212e7f8b","updated":"2020-09-10 09:10:10.000000000","message":"This code is still required regardless how we obtain the mode. The mode is required to be calculated elsewhere before calling this function. So recalculating it adds latency.","commit_id":"30dae4acb903b051463e045a789b1acc1ee38de4"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"49de25fc05ef50780c9a4d134dd9cffeb5058dbc","unresolved":false,"context_lines":[{"line_number":980,"context_line":""},{"line_number":981,"context_line":"        self._validate_hrefs(deploy_info)"},{"line_number":982,"context_line":""},{"line_number":983,"context_line":"        error_msg \u003d (_(\"Error validating iLO UEFIHTTPS for %s. Some \""},{"line_number":984,"context_line":"                       \"parameters were missing in node\u0027s driver_info\") % mode)"},{"line_number":985,"context_line":"        deploy_utils.check_for_missing_params(deploy_info, error_msg)"},{"line_number":986,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"9f560f44_9e3b66e8","line":983,"range":{"start_line":983,"start_character":41,"end_line":983,"end_character":61},"updated":"2020-09-09 16:16:41.000000000","message":"s/ iLO UEFIHTTPS for %s. / %s for iLO UEFI HTTPS boot. /","commit_id":"30dae4acb903b051463e045a789b1acc1ee38de4"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"73d63e44e1e61a71f8e4ff1981309ff02694839a","unresolved":false,"context_lines":[{"line_number":980,"context_line":""},{"line_number":981,"context_line":"        self._validate_hrefs(deploy_info)"},{"line_number":982,"context_line":""},{"line_number":983,"context_line":"        error_msg \u003d (_(\"Error validating iLO UEFIHTTPS for %s. Some \""},{"line_number":984,"context_line":"                       \"parameters were missing in node\u0027s driver_info\") % mode)"},{"line_number":985,"context_line":"        deploy_utils.check_for_missing_params(deploy_info, error_msg)"},{"line_number":986,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"9f560f44_c4f06494","line":983,"range":{"start_line":983,"start_character":41,"end_line":983,"end_character":61},"in_reply_to":"9f560f44_9e3b66e8","updated":"2020-09-10 09:10:10.000000000","message":"Done","commit_id":"30dae4acb903b051463e045a789b1acc1ee38de4"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"49de25fc05ef50780c9a4d134dd9cffeb5058dbc","unresolved":false,"context_lines":[{"line_number":1043,"context_line":"        boot_mode \u003d ilo_common.get_current_boot_mode(task.node)"},{"line_number":1044,"context_line":""},{"line_number":1045,"context_line":"        if boot_mode.lower() !\u003d \u0027uefi\u0027:"},{"line_number":1046,"context_line":"            error \u003d _(\"Validating \u0027ilo-uefi-https\u0027 interface failed.\""},{"line_number":1047,"context_line":"                      \"\u0027ilo-uefi-https\u0027 boot interface can be used only \""},{"line_number":1048,"context_line":"                      \"when the node is in \u0027UEFI\u0027 mode.\")"},{"line_number":1049,"context_line":"            raise exception.InvalidParameterValue(error)"}],"source_content_type":"text/x-python","patch_set":11,"id":"9f560f44_e19e4752","line":1046,"range":{"start_line":1046,"start_character":23,"end_line":1046,"end_character":67},"updated":"2020-09-09 16:16:41.000000000","message":"s/ Validating \u0027ilo-uefi-https\u0027 interface failed / Validation for \u0027ilo-uefi-https\u0027 boot interface failed  /","commit_id":"30dae4acb903b051463e045a789b1acc1ee38de4"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"73d63e44e1e61a71f8e4ff1981309ff02694839a","unresolved":false,"context_lines":[{"line_number":1043,"context_line":"        boot_mode \u003d ilo_common.get_current_boot_mode(task.node)"},{"line_number":1044,"context_line":""},{"line_number":1045,"context_line":"        if boot_mode.lower() !\u003d \u0027uefi\u0027:"},{"line_number":1046,"context_line":"            error \u003d _(\"Validating \u0027ilo-uefi-https\u0027 interface failed.\""},{"line_number":1047,"context_line":"                      \"\u0027ilo-uefi-https\u0027 boot interface can be used only \""},{"line_number":1048,"context_line":"                      \"when the node is in \u0027UEFI\u0027 mode.\")"},{"line_number":1049,"context_line":"            raise exception.InvalidParameterValue(error)"}],"source_content_type":"text/x-python","patch_set":11,"id":"9f560f44_98136c5c","line":1046,"range":{"start_line":1046,"start_character":23,"end_line":1046,"end_character":67},"in_reply_to":"9f560f44_e19e4752","updated":"2020-09-10 09:10:10.000000000","message":"Done","commit_id":"30dae4acb903b051463e045a789b1acc1ee38de4"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"49de25fc05ef50780c9a4d134dd9cffeb5058dbc","unresolved":false,"context_lines":[{"line_number":1044,"context_line":""},{"line_number":1045,"context_line":"        if boot_mode.lower() !\u003d \u0027uefi\u0027:"},{"line_number":1046,"context_line":"            error \u003d _(\"Validating \u0027ilo-uefi-https\u0027 interface failed.\""},{"line_number":1047,"context_line":"                      \"\u0027ilo-uefi-https\u0027 boot interface can be used only \""},{"line_number":1048,"context_line":"                      \"when the node is in \u0027UEFI\u0027 mode.\")"},{"line_number":1049,"context_line":"            raise exception.InvalidParameterValue(error)"},{"line_number":1050,"context_line":""},{"line_number":1051,"context_line":"        boot_iso \u003d node.instance_info.get(\u0027ilo_boot_iso\u0027)"}],"source_content_type":"text/x-python","patch_set":11,"id":"9f560f44_01cb7b52","line":1048,"range":{"start_line":1047,"start_character":24,"end_line":1048,"end_character":55},"updated":"2020-09-09 16:16:41.000000000","message":"s/ ilo-uefi-https\u0027 boot interface can be used only when the node is in \u0027UEFI\u0027 mode. / It needs node to be in \u0027UEFI\u0027 boot mode. /","commit_id":"30dae4acb903b051463e045a789b1acc1ee38de4"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"73d63e44e1e61a71f8e4ff1981309ff02694839a","unresolved":false,"context_lines":[{"line_number":1044,"context_line":""},{"line_number":1045,"context_line":"        if boot_mode.lower() !\u003d \u0027uefi\u0027:"},{"line_number":1046,"context_line":"            error \u003d _(\"Validating \u0027ilo-uefi-https\u0027 interface failed.\""},{"line_number":1047,"context_line":"                      \"\u0027ilo-uefi-https\u0027 boot interface can be used only \""},{"line_number":1048,"context_line":"                      \"when the node is in \u0027UEFI\u0027 mode.\")"},{"line_number":1049,"context_line":"            raise exception.InvalidParameterValue(error)"},{"line_number":1050,"context_line":""},{"line_number":1051,"context_line":"        boot_iso \u003d node.instance_info.get(\u0027ilo_boot_iso\u0027)"}],"source_content_type":"text/x-python","patch_set":11,"id":"9f560f44_64235806","line":1048,"range":{"start_line":1047,"start_character":24,"end_line":1048,"end_character":55},"in_reply_to":"9f560f44_01cb7b52","updated":"2020-09-10 09:10:10.000000000","message":"Changing it to \n\"The node is expected to be in \u0027UEFI\u0027 boot mode.","commit_id":"30dae4acb903b051463e045a789b1acc1ee38de4"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"49de25fc05ef50780c9a4d134dd9cffeb5058dbc","unresolved":false,"context_lines":[{"line_number":1135,"context_line":"        deploy_nic_mac \u003d deploy_utils.get_single_nic_with_vif_port_id(task)"},{"line_number":1136,"context_line":"        ramdisk_params[\u0027BOOTIF\u0027] \u003d deploy_nic_mac"},{"line_number":1137,"context_line":""},{"line_number":1138,"context_line":"        mode \u003d \u0027deploy\u0027"},{"line_number":1139,"context_line":"        if node.provision_state \u003d\u003d states.RESCUING:"},{"line_number":1140,"context_line":"            mode \u003d \u0027rescue\u0027"},{"line_number":1141,"context_line":""},{"line_number":1142,"context_line":"        d_info \u003d self._parse_driver_info(node, mode)"},{"line_number":1143,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"9f560f44_e13ac731","line":1140,"range":{"start_line":1138,"start_character":8,"end_line":1140,"end_character":26},"updated":"2020-09-09 16:16:41.000000000","message":"Use deploy_utils.rescue_or_deploy_mode(node) instead.","commit_id":"30dae4acb903b051463e045a789b1acc1ee38de4"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"73d63e44e1e61a71f8e4ff1981309ff02694839a","unresolved":false,"context_lines":[{"line_number":1135,"context_line":"        deploy_nic_mac \u003d deploy_utils.get_single_nic_with_vif_port_id(task)"},{"line_number":1136,"context_line":"        ramdisk_params[\u0027BOOTIF\u0027] \u003d deploy_nic_mac"},{"line_number":1137,"context_line":""},{"line_number":1138,"context_line":"        mode \u003d \u0027deploy\u0027"},{"line_number":1139,"context_line":"        if node.provision_state \u003d\u003d states.RESCUING:"},{"line_number":1140,"context_line":"            mode \u003d \u0027rescue\u0027"},{"line_number":1141,"context_line":""},{"line_number":1142,"context_line":"        d_info \u003d self._parse_driver_info(node, mode)"},{"line_number":1143,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"9f560f44_248320cd","line":1140,"range":{"start_line":1138,"start_character":8,"end_line":1140,"end_character":26},"in_reply_to":"9f560f44_e13ac731","updated":"2020-09-10 09:10:10.000000000","message":"Actually the method suggested checks for all the rescue states i.e \nRESCUE_LIKE_STATES \u003d (states.RESCUING, states.RESCUEWAIT, states.RESCUEFAIL, states.UNRESCUING, states.UNRESCUEFAIL)\nBut from L-1110 the only possible state is states.RESCUING. So instead of calling the function it\u0027d better to just check the condition. WDYT?","commit_id":"30dae4acb903b051463e045a789b1acc1ee38de4"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"49de25fc05ef50780c9a4d134dd9cffeb5058dbc","unresolved":false,"context_lines":[{"line_number":1144,"context_line":"        iso_ref \u003d image_utils.prepare_deploy_iso(task, ramdisk_params,"},{"line_number":1145,"context_line":"                                                 mode, d_info)"},{"line_number":1146,"context_line":""},{"line_number":1147,"context_line":"        LOG.debug(\"Node %(node)s is set to one time boot from \""},{"line_number":1148,"context_line":"                  \"UEFIHTTP\", {\u0027node\u0027: node.uuid})"},{"line_number":1149,"context_line":""},{"line_number":1150,"context_line":"        LOG.debug(\"Node %(node)s is set to boot from URL\""},{"line_number":1151,"context_line":"                  \"%(iso_ref)s\", {\u0027node\u0027: node.uuid, \u0027iso_ref\u0027: iso_ref})"},{"line_number":1152,"context_line":"        ilo_common.setup_uefi_https(task, iso_ref)"},{"line_number":1153,"context_line":""},{"line_number":1154,"context_line":"    @METRICS.timer(\u0027IloUefiHttpsBoot.clean_up_ramdisk\u0027)"}],"source_content_type":"text/x-python","patch_set":11,"id":"9f560f44_a183afca","line":1151,"range":{"start_line":1147,"start_character":8,"end_line":1151,"end_character":73},"updated":"2020-09-09 16:16:41.000000000","message":"Can this be clubbed as a single debug log?","commit_id":"30dae4acb903b051463e045a789b1acc1ee38de4"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"73d63e44e1e61a71f8e4ff1981309ff02694839a","unresolved":false,"context_lines":[{"line_number":1144,"context_line":"        iso_ref \u003d image_utils.prepare_deploy_iso(task, ramdisk_params,"},{"line_number":1145,"context_line":"                                                 mode, d_info)"},{"line_number":1146,"context_line":""},{"line_number":1147,"context_line":"        LOG.debug(\"Node %(node)s is set to one time boot from \""},{"line_number":1148,"context_line":"                  \"UEFIHTTP\", {\u0027node\u0027: node.uuid})"},{"line_number":1149,"context_line":""},{"line_number":1150,"context_line":"        LOG.debug(\"Node %(node)s is set to boot from URL\""},{"line_number":1151,"context_line":"                  \"%(iso_ref)s\", {\u0027node\u0027: node.uuid, \u0027iso_ref\u0027: iso_ref})"},{"line_number":1152,"context_line":"        ilo_common.setup_uefi_https(task, iso_ref)"},{"line_number":1153,"context_line":""},{"line_number":1154,"context_line":"    @METRICS.timer(\u0027IloUefiHttpsBoot.clean_up_ramdisk\u0027)"}],"source_content_type":"text/x-python","patch_set":11,"id":"9f560f44_846dcc33","line":1151,"range":{"start_line":1147,"start_character":8,"end_line":1151,"end_character":73},"in_reply_to":"9f560f44_a183afca","updated":"2020-09-10 09:10:10.000000000","message":"Done","commit_id":"30dae4acb903b051463e045a789b1acc1ee38de4"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"49de25fc05ef50780c9a4d134dd9cffeb5058dbc","unresolved":false,"context_lines":[{"line_number":1174,"context_line":"        relevant information from the node\u0027s instance_info."},{"line_number":1175,"context_line":"        It does the following depending on boot_option for deploy:"},{"line_number":1176,"context_line":""},{"line_number":1177,"context_line":"        - If the boot mode is \u0027uefi\u0027 and its booting from volume, then it"},{"line_number":1178,"context_line":"          sets the iSCSI target info and node to boot from \u0027UefiTarget\u0027"},{"line_number":1179,"context_line":"          boot device."},{"line_number":1180,"context_line":"        - If not \u0027boot from volume\u0027 and the boot_option requested for"}],"source_content_type":"text/x-python","patch_set":11,"id":"9f560f44_e1512764","line":1177,"range":{"start_line":1177,"start_character":8,"end_line":1177,"end_character":37},"updated":"2020-09-09 16:16:41.000000000","message":"Pre-requisite of this interface is to have node in UEFI boot mode, isnt it?","commit_id":"30dae4acb903b051463e045a789b1acc1ee38de4"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"73d63e44e1e61a71f8e4ff1981309ff02694839a","unresolved":false,"context_lines":[{"line_number":1174,"context_line":"        relevant information from the node\u0027s instance_info."},{"line_number":1175,"context_line":"        It does the following depending on boot_option for deploy:"},{"line_number":1176,"context_line":""},{"line_number":1177,"context_line":"        - If the boot mode is \u0027uefi\u0027 and its booting from volume, then it"},{"line_number":1178,"context_line":"          sets the iSCSI target info and node to boot from \u0027UefiTarget\u0027"},{"line_number":1179,"context_line":"          boot device."},{"line_number":1180,"context_line":"        - If not \u0027boot from volume\u0027 and the boot_option requested for"}],"source_content_type":"text/x-python","patch_set":11,"id":"9f560f44_84b2ec92","line":1177,"range":{"start_line":1177,"start_character":8,"end_line":1177,"end_character":37},"in_reply_to":"9f560f44_e1512764","updated":"2020-09-10 09:10:10.000000000","message":"Thanks. Will rewrite this.","commit_id":"30dae4acb903b051463e045a789b1acc1ee38de4"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"49de25fc05ef50780c9a4d134dd9cffeb5058dbc","unresolved":false,"context_lines":[{"line_number":1175,"context_line":"        It does the following depending on boot_option for deploy:"},{"line_number":1176,"context_line":""},{"line_number":1177,"context_line":"        - If the boot mode is \u0027uefi\u0027 and its booting from volume, then it"},{"line_number":1178,"context_line":"          sets the iSCSI target info and node to boot from \u0027UefiTarget\u0027"},{"line_number":1179,"context_line":"          boot device."},{"line_number":1180,"context_line":"        - If not \u0027boot from volume\u0027 and the boot_option requested for"},{"line_number":1181,"context_line":"          this deploy is \u0027local\u0027 or image is a whole disk image, then"},{"line_number":1182,"context_line":"          it sets the node to boot from disk."}],"source_content_type":"text/x-python","patch_set":11,"id":"9f560f44_f4c44394","line":1179,"range":{"start_line":1178,"start_character":10,"end_line":1179,"end_character":22},"updated":"2020-09-09 16:16:41.000000000","message":"There is no code to support this in this method.","commit_id":"30dae4acb903b051463e045a789b1acc1ee38de4"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"73d63e44e1e61a71f8e4ff1981309ff02694839a","unresolved":false,"context_lines":[{"line_number":1175,"context_line":"        It does the following depending on boot_option for deploy:"},{"line_number":1176,"context_line":""},{"line_number":1177,"context_line":"        - If the boot mode is \u0027uefi\u0027 and its booting from volume, then it"},{"line_number":1178,"context_line":"          sets the iSCSI target info and node to boot from \u0027UefiTarget\u0027"},{"line_number":1179,"context_line":"          boot device."},{"line_number":1180,"context_line":"        - If not \u0027boot from volume\u0027 and the boot_option requested for"},{"line_number":1181,"context_line":"          this deploy is \u0027local\u0027 or image is a whole disk image, then"},{"line_number":1182,"context_line":"          it sets the node to boot from disk."}],"source_content_type":"text/x-python","patch_set":11,"id":"9f560f44_64ad1830","line":1179,"range":{"start_line":1178,"start_character":10,"end_line":1179,"end_character":22},"in_reply_to":"9f560f44_f4c44394","updated":"2020-09-10 09:10:10.000000000","message":"Will rewrite/remove this.","commit_id":"30dae4acb903b051463e045a789b1acc1ee38de4"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"49de25fc05ef50780c9a4d134dd9cffeb5058dbc","unresolved":false,"context_lines":[{"line_number":1191,"context_line":"                 \u0027BIOS\u0027 boot mode."},{"line_number":1192,"context_line":"        \"\"\""},{"line_number":1193,"context_line":"        node \u003d task.node"},{"line_number":1194,"context_line":"        image_utils.cleanup_iso_image(task)"},{"line_number":1195,"context_line":"        boot_option \u003d deploy_utils.get_boot_option(task.node)"},{"line_number":1196,"context_line":""},{"line_number":1197,"context_line":"        # Set boot mode"}],"source_content_type":"text/x-python","patch_set":11,"id":"9f560f44_015ffb40","line":1194,"range":{"start_line":1194,"start_character":8,"end_line":1194,"end_character":43},"updated":"2020-09-09 16:16:41.000000000","message":"Do we need TLS certificate at this point? If not, Can we call clean_up_instance() here?","commit_id":"30dae4acb903b051463e045a789b1acc1ee38de4"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"73d63e44e1e61a71f8e4ff1981309ff02694839a","unresolved":false,"context_lines":[{"line_number":1191,"context_line":"                 \u0027BIOS\u0027 boot mode."},{"line_number":1192,"context_line":"        \"\"\""},{"line_number":1193,"context_line":"        node \u003d task.node"},{"line_number":1194,"context_line":"        image_utils.cleanup_iso_image(task)"},{"line_number":1195,"context_line":"        boot_option \u003d deploy_utils.get_boot_option(task.node)"},{"line_number":1196,"context_line":""},{"line_number":1197,"context_line":"        # Set boot mode"}],"source_content_type":"text/x-python","patch_set":11,"id":"9f560f44_4411f45c","line":1194,"range":{"start_line":1194,"start_character":8,"end_line":1194,"end_character":43},"in_reply_to":"9f560f44_015ffb40","updated":"2020-09-10 09:10:10.000000000","message":"Yes. For partition images we create an ISO and host it in the webserver or swift. When we boot again from UEFIHTTP boot device it needs the certificate to boot from the URL. So we can\u0027t clear the certificate until the whole deployment is done.","commit_id":"30dae4acb903b051463e045a789b1acc1ee38de4"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"49de25fc05ef50780c9a4d134dd9cffeb5058dbc","unresolved":false,"context_lines":[{"line_number":1194,"context_line":"        image_utils.cleanup_iso_image(task)"},{"line_number":1195,"context_line":"        boot_option \u003d deploy_utils.get_boot_option(task.node)"},{"line_number":1196,"context_line":""},{"line_number":1197,"context_line":"        # Set boot mode"},{"line_number":1198,"context_line":"        ilo_common.update_boot_mode(task)"},{"line_number":1199,"context_line":"        # Need to enable secure boot, if being requested"},{"line_number":1200,"context_line":"        ilo_common.update_secure_boot_mode(task, True)"},{"line_number":1201,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"9f560f44_010d3b3d","line":1198,"range":{"start_line":1197,"start_character":8,"end_line":1198,"end_character":41},"updated":"2020-09-09 16:16:41.000000000","message":"Is this required. Boot mdoe in \u0027UEFI\u0027 is a pre-requisite. Or does it support instance boot in \u0027Legacy BIOS\u0027 boot mode?","commit_id":"30dae4acb903b051463e045a789b1acc1ee38de4"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"73d63e44e1e61a71f8e4ff1981309ff02694839a","unresolved":false,"context_lines":[{"line_number":1194,"context_line":"        image_utils.cleanup_iso_image(task)"},{"line_number":1195,"context_line":"        boot_option \u003d deploy_utils.get_boot_option(task.node)"},{"line_number":1196,"context_line":""},{"line_number":1197,"context_line":"        # Set boot mode"},{"line_number":1198,"context_line":"        ilo_common.update_boot_mode(task)"},{"line_number":1199,"context_line":"        # Need to enable secure boot, if being requested"},{"line_number":1200,"context_line":"        ilo_common.update_secure_boot_mode(task, True)"},{"line_number":1201,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"9f560f44_c404e41a","line":1198,"range":{"start_line":1197,"start_character":8,"end_line":1198,"end_character":41},"in_reply_to":"9f560f44_010d3b3d","updated":"2020-09-10 09:10:10.000000000","message":"+1. I will remove this as we are here because we already validated that the current boot mode is UEFI. Even the below line i think is not required.","commit_id":"30dae4acb903b051463e045a789b1acc1ee38de4"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"2457c8e0e7e988303ae3fcdc0f35e9af72260692","unresolved":false,"context_lines":[{"line_number":58,"context_line":"                        \"managing booting the rescue ramdisk.\")"},{"line_number":59,"context_line":"}"},{"line_number":60,"context_line":"REQUIRED_PROPERTIES_UEFI_HTTPS_BOOT \u003d {"},{"line_number":61,"context_line":"    \u0027deploy_kernel\u0027: _(\"URL or Glance UUID of the deployment kernel. \""},{"line_number":62,"context_line":"                       \"Required.\"),"},{"line_number":63,"context_line":"    \u0027deploy_ramdisk\u0027: _(\"URL or Glance UUID of the ramdisk that is \""},{"line_number":64,"context_line":"                        \"mounted at boot time. Required.\"),"}],"source_content_type":"text/x-python","patch_set":15,"id":"9f560f44_fe796330","line":61,"range":{"start_line":61,"start_character":5,"end_line":61,"end_character":18},"updated":"2020-09-15 07:05:43.000000000","message":"Prefix all driver_info params with ilo\ns/ deploy_kernel / ilo_deploy_kernel /","commit_id":"0a094a37cbd990039b1f583f5bae76475efbb844"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"08db06de21103c166faf1297c8a5ad544fb0977a","unresolved":false,"context_lines":[{"line_number":58,"context_line":"                        \"managing booting the rescue ramdisk.\")"},{"line_number":59,"context_line":"}"},{"line_number":60,"context_line":"REQUIRED_PROPERTIES_UEFI_HTTPS_BOOT \u003d {"},{"line_number":61,"context_line":"    \u0027deploy_kernel\u0027: _(\"URL or Glance UUID of the deployment kernel. \""},{"line_number":62,"context_line":"                       \"Required.\"),"},{"line_number":63,"context_line":"    \u0027deploy_ramdisk\u0027: _(\"URL or Glance UUID of the ramdisk that is \""},{"line_number":64,"context_line":"                        \"mounted at boot time. Required.\"),"}],"source_content_type":"text/x-python","patch_set":15,"id":"9f560f44_cb9ade60","line":61,"range":{"start_line":61,"start_character":5,"end_line":61,"end_character":18},"in_reply_to":"9f560f44_fe796330","updated":"2020-09-15 11:49:54.000000000","message":"Done","commit_id":"0a094a37cbd990039b1f583f5bae76475efbb844"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"2457c8e0e7e988303ae3fcdc0f35e9af72260692","unresolved":false,"context_lines":[{"line_number":60,"context_line":"REQUIRED_PROPERTIES_UEFI_HTTPS_BOOT \u003d {"},{"line_number":61,"context_line":"    \u0027deploy_kernel\u0027: _(\"URL or Glance UUID of the deployment kernel. \""},{"line_number":62,"context_line":"                       \"Required.\"),"},{"line_number":63,"context_line":"    \u0027deploy_ramdisk\u0027: _(\"URL or Glance UUID of the ramdisk that is \""},{"line_number":64,"context_line":"                        \"mounted at boot time. Required.\"),"},{"line_number":65,"context_line":"    \u0027bootloader\u0027: _(\"URL or Glance UUID  of the EFI system partition \""},{"line_number":66,"context_line":"                    \"image containing EFI boot loader. This image will be \""}],"source_content_type":"text/x-python","patch_set":15,"id":"9f560f44_1e4257ac","line":63,"range":{"start_line":63,"start_character":5,"end_line":63,"end_character":19},"updated":"2020-09-15 07:05:43.000000000","message":"ditto","commit_id":"0a094a37cbd990039b1f583f5bae76475efbb844"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"08db06de21103c166faf1297c8a5ad544fb0977a","unresolved":false,"context_lines":[{"line_number":60,"context_line":"REQUIRED_PROPERTIES_UEFI_HTTPS_BOOT \u003d {"},{"line_number":61,"context_line":"    \u0027deploy_kernel\u0027: _(\"URL or Glance UUID of the deployment kernel. \""},{"line_number":62,"context_line":"                       \"Required.\"),"},{"line_number":63,"context_line":"    \u0027deploy_ramdisk\u0027: _(\"URL or Glance UUID of the ramdisk that is \""},{"line_number":64,"context_line":"                        \"mounted at boot time. Required.\"),"},{"line_number":65,"context_line":"    \u0027bootloader\u0027: _(\"URL or Glance UUID  of the EFI system partition \""},{"line_number":66,"context_line":"                    \"image containing EFI boot loader. This image will be \""}],"source_content_type":"text/x-python","patch_set":15,"id":"9f560f44_2b9f1a52","line":63,"range":{"start_line":63,"start_character":5,"end_line":63,"end_character":19},"in_reply_to":"9f560f44_1e4257ac","updated":"2020-09-15 11:49:54.000000000","message":"Done","commit_id":"0a094a37cbd990039b1f583f5bae76475efbb844"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"2457c8e0e7e988303ae3fcdc0f35e9af72260692","unresolved":false,"context_lines":[{"line_number":62,"context_line":"                       \"Required.\"),"},{"line_number":63,"context_line":"    \u0027deploy_ramdisk\u0027: _(\"URL or Glance UUID of the ramdisk that is \""},{"line_number":64,"context_line":"                        \"mounted at boot time. Required.\"),"},{"line_number":65,"context_line":"    \u0027bootloader\u0027: _(\"URL or Glance UUID  of the EFI system partition \""},{"line_number":66,"context_line":"                    \"image containing EFI boot loader. This image will be \""},{"line_number":67,"context_line":"                    \"used by ironic when building UEFI-bootable ISO \""},{"line_number":68,"context_line":"                    \"out of kernel and ramdisk. Required for UEFI \""}],"source_content_type":"text/x-python","patch_set":15,"id":"9f560f44_7e10b3ac","line":65,"range":{"start_line":65,"start_character":5,"end_line":65,"end_character":15},"updated":"2020-09-15 07:05:43.000000000","message":"ditto","commit_id":"0a094a37cbd990039b1f583f5bae76475efbb844"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"08db06de21103c166faf1297c8a5ad544fb0977a","unresolved":false,"context_lines":[{"line_number":62,"context_line":"                       \"Required.\"),"},{"line_number":63,"context_line":"    \u0027deploy_ramdisk\u0027: _(\"URL or Glance UUID of the ramdisk that is \""},{"line_number":64,"context_line":"                        \"mounted at boot time. Required.\"),"},{"line_number":65,"context_line":"    \u0027bootloader\u0027: _(\"URL or Glance UUID  of the EFI system partition \""},{"line_number":66,"context_line":"                    \"image containing EFI boot loader. This image will be \""},{"line_number":67,"context_line":"                    \"used by ironic when building UEFI-bootable ISO \""},{"line_number":68,"context_line":"                    \"out of kernel and ramdisk. Required for UEFI \""}],"source_content_type":"text/x-python","patch_set":15,"id":"9f560f44_0b9cd659","line":65,"range":{"start_line":65,"start_character":5,"end_line":65,"end_character":15},"in_reply_to":"9f560f44_7e10b3ac","updated":"2020-09-15 11:49:54.000000000","message":"Done","commit_id":"0a094a37cbd990039b1f583f5bae76475efbb844"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"2457c8e0e7e988303ae3fcdc0f35e9af72260692","unresolved":false,"context_lines":[{"line_number":69,"context_line":"                    \"boot from partition images.\")"},{"line_number":70,"context_line":"}"},{"line_number":71,"context_line":"RESCUE_PROPERTIES_UEFI_HTTPS_BOOT \u003d {"},{"line_number":72,"context_line":"    \u0027rescue_kernel\u0027: _(\u0027URL or Glance UUID of the rescue kernel. This value \u0027"},{"line_number":73,"context_line":"                       \u0027is required for rescue mode.\u0027),"},{"line_number":74,"context_line":"    \u0027rescue_ramdisk\u0027: _(\u0027URL or Glance UUID of the rescue ramdisk with agent \u0027"},{"line_number":75,"context_line":"                        \u0027that is used at node rescue time. This value is \u0027"}],"source_content_type":"text/x-python","patch_set":15,"id":"9f560f44_3e459bb5","line":72,"range":{"start_line":72,"start_character":5,"end_line":72,"end_character":18},"updated":"2020-09-15 07:05:43.000000000","message":"s/ rescue_kernel / ilo_rescue_kernel /","commit_id":"0a094a37cbd990039b1f583f5bae76475efbb844"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"2457c8e0e7e988303ae3fcdc0f35e9af72260692","unresolved":false,"context_lines":[{"line_number":71,"context_line":"RESCUE_PROPERTIES_UEFI_HTTPS_BOOT \u003d {"},{"line_number":72,"context_line":"    \u0027rescue_kernel\u0027: _(\u0027URL or Glance UUID of the rescue kernel. This value \u0027"},{"line_number":73,"context_line":"                       \u0027is required for rescue mode.\u0027),"},{"line_number":74,"context_line":"    \u0027rescue_ramdisk\u0027: _(\u0027URL or Glance UUID of the rescue ramdisk with agent \u0027"},{"line_number":75,"context_line":"                        \u0027that is used at node rescue time. This value is \u0027"},{"line_number":76,"context_line":"                        \u0027required for rescue mode.\u0027),"},{"line_number":77,"context_line":"    \u0027bootloader\u0027: _(\"URL or Glance UUID  of the EFI system partition \""}],"source_content_type":"text/x-python","patch_set":15,"id":"9f560f44_5e15ef9a","line":74,"range":{"start_line":74,"start_character":5,"end_line":74,"end_character":19},"updated":"2020-09-15 07:05:43.000000000","message":"ditto","commit_id":"0a094a37cbd990039b1f583f5bae76475efbb844"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"08db06de21103c166faf1297c8a5ad544fb0977a","unresolved":false,"context_lines":[{"line_number":71,"context_line":"RESCUE_PROPERTIES_UEFI_HTTPS_BOOT \u003d {"},{"line_number":72,"context_line":"    \u0027rescue_kernel\u0027: _(\u0027URL or Glance UUID of the rescue kernel. This value \u0027"},{"line_number":73,"context_line":"                       \u0027is required for rescue mode.\u0027),"},{"line_number":74,"context_line":"    \u0027rescue_ramdisk\u0027: _(\u0027URL or Glance UUID of the rescue ramdisk with agent \u0027"},{"line_number":75,"context_line":"                        \u0027that is used at node rescue time. This value is \u0027"},{"line_number":76,"context_line":"                        \u0027required for rescue mode.\u0027),"},{"line_number":77,"context_line":"    \u0027bootloader\u0027: _(\"URL or Glance UUID  of the EFI system partition \""}],"source_content_type":"text/x-python","patch_set":15,"id":"9f560f44_cb0f7e86","line":74,"range":{"start_line":74,"start_character":5,"end_line":74,"end_character":19},"in_reply_to":"9f560f44_5e15ef9a","updated":"2020-09-15 11:49:54.000000000","message":"Done","commit_id":"0a094a37cbd990039b1f583f5bae76475efbb844"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"2457c8e0e7e988303ae3fcdc0f35e9af72260692","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    \u0027rescue_ramdisk\u0027: _(\u0027URL or Glance UUID of the rescue ramdisk with agent \u0027"},{"line_number":75,"context_line":"                        \u0027that is used at node rescue time. This value is \u0027"},{"line_number":76,"context_line":"                        \u0027required for rescue mode.\u0027),"},{"line_number":77,"context_line":"    \u0027bootloader\u0027: _(\"URL or Glance UUID  of the EFI system partition \""},{"line_number":78,"context_line":"                    \"image containing EFI boot loader. This image will be \""},{"line_number":79,"context_line":"                    \"used by ironic when building UEFI-bootable ISO \""},{"line_number":80,"context_line":"                    \"out of kernel and ramdisk. Required for UEFI \""}],"source_content_type":"text/x-python","patch_set":15,"id":"9f560f44_de20dffb","line":77,"range":{"start_line":77,"start_character":5,"end_line":77,"end_character":15},"updated":"2020-09-15 07:05:43.000000000","message":"Since this is required both in Deploy and Rescue, can be moved to common properties.","commit_id":"0a094a37cbd990039b1f583f5bae76475efbb844"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"e28c428c6a31833c6ccb93aad9dec67ef45b6620","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    \u0027rescue_ramdisk\u0027: _(\u0027URL or Glance UUID of the rescue ramdisk with agent \u0027"},{"line_number":75,"context_line":"                        \u0027that is used at node rescue time. This value is \u0027"},{"line_number":76,"context_line":"                        \u0027required for rescue mode.\u0027),"},{"line_number":77,"context_line":"    \u0027bootloader\u0027: _(\"URL or Glance UUID  of the EFI system partition \""},{"line_number":78,"context_line":"                    \"image containing EFI boot loader. This image will be \""},{"line_number":79,"context_line":"                    \"used by ironic when building UEFI-bootable ISO \""},{"line_number":80,"context_line":"                    \"out of kernel and ramdisk. Required for UEFI \""}],"source_content_type":"text/x-python","patch_set":15,"id":"9f560f44_5da7620a","line":77,"range":{"start_line":77,"start_character":5,"end_line":77,"end_character":15},"in_reply_to":"9f560f44_ab104aad","updated":"2020-09-18 19:40:10.000000000","message":"I suspect just restructuring the constants might be the best way to model and structure it so there is not copy/pastes, at least in the end.","commit_id":"0a094a37cbd990039b1f583f5bae76475efbb844"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"08db06de21103c166faf1297c8a5ad544fb0977a","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    \u0027rescue_ramdisk\u0027: _(\u0027URL or Glance UUID of the rescue ramdisk with agent \u0027"},{"line_number":75,"context_line":"                        \u0027that is used at node rescue time. This value is \u0027"},{"line_number":76,"context_line":"                        \u0027required for rescue mode.\u0027),"},{"line_number":77,"context_line":"    \u0027bootloader\u0027: _(\"URL or Glance UUID  of the EFI system partition \""},{"line_number":78,"context_line":"                    \"image containing EFI boot loader. This image will be \""},{"line_number":79,"context_line":"                    \"used by ironic when building UEFI-bootable ISO \""},{"line_number":80,"context_line":"                    \"out of kernel and ramdisk. Required for UEFI \""}],"source_content_type":"text/x-python","patch_set":15,"id":"9f560f44_ab104aad","line":77,"range":{"start_line":77,"start_character":5,"end_line":77,"end_character":15},"in_reply_to":"9f560f44_de20dffb","updated":"2020-09-15 11:49:54.000000000","message":"Thought about it. But this parameter is used along with others and keeping this parameter out makes the parsing and validation difficult. For instance if i want to validate the parameters i could extract the parameters as \nRESCUE_PROPERTIES_UEFI_HTTPS_BOOT.keys() which otherwise would be \nparams \u003d RESCUE_PROPERTIES_UEFI_HTTPS_BOOT.keys()\nparams.append(COMMON_PROPERTIES_UEFI_HTTPS_BOOT.keys()) and this is the case everywhere. I am open to change this but see no use much.","commit_id":"0a094a37cbd990039b1f583f5bae76475efbb844"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"2457c8e0e7e988303ae3fcdc0f35e9af72260692","unresolved":false,"context_lines":[{"line_number":909,"context_line":"        return REQUIRED_PROPERTIES_UEFI_HTTPS_BOOT"},{"line_number":910,"context_line":""},{"line_number":911,"context_line":"    def _validate_hrefs(self, image_dict):"},{"line_number":912,"context_line":"        \"\"\"Validates if the given URLs are secured URLS."},{"line_number":913,"context_line":""},{"line_number":914,"context_line":"        If the given URLs are not glance images then validates if the URLs"},{"line_number":915,"context_line":"        are secured."}],"source_content_type":"text/x-python","patch_set":15,"id":"9f560f44_fef5e385","line":912,"range":{"start_line":912,"start_character":51,"end_line":912,"end_character":55},"updated":"2020-09-15 07:05:43.000000000","message":"nit: s/ URLS / URLs /","commit_id":"0a094a37cbd990039b1f583f5bae76475efbb844"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"08db06de21103c166faf1297c8a5ad544fb0977a","unresolved":false,"context_lines":[{"line_number":909,"context_line":"        return REQUIRED_PROPERTIES_UEFI_HTTPS_BOOT"},{"line_number":910,"context_line":""},{"line_number":911,"context_line":"    def _validate_hrefs(self, image_dict):"},{"line_number":912,"context_line":"        \"\"\"Validates if the given URLs are secured URLS."},{"line_number":913,"context_line":""},{"line_number":914,"context_line":"        If the given URLs are not glance images then validates if the URLs"},{"line_number":915,"context_line":"        are secured."}],"source_content_type":"text/x-python","patch_set":15,"id":"9f560f44_2b243a0e","line":912,"range":{"start_line":912,"start_character":51,"end_line":912,"end_character":55},"in_reply_to":"9f560f44_fef5e385","updated":"2020-09-15 11:49:54.000000000","message":"Done","commit_id":"0a094a37cbd990039b1f583f5bae76475efbb844"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"2457c8e0e7e988303ae3fcdc0f35e9af72260692","unresolved":false,"context_lines":[{"line_number":916,"context_line":""},{"line_number":917,"context_line":"        :param image_dict: a dictionary containing property/URL pair."},{"line_number":918,"context_line":"        :returns: None"},{"line_number":919,"context_line":"        :raises: MissingParameterValue, if any of URLs provided are insecured."},{"line_number":920,"context_line":"        \"\"\""},{"line_number":921,"context_line":"        insecure_props \u003d []"},{"line_number":922,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"9f560f44_5e07af82","line":919,"range":{"start_line":919,"start_character":17,"end_line":919,"end_character":38},"updated":"2020-09-15 07:05:43.000000000","message":"s/ MissingParameterValue / InvalidParameterValue /","commit_id":"0a094a37cbd990039b1f583f5bae76475efbb844"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"2457c8e0e7e988303ae3fcdc0f35e9af72260692","unresolved":false,"context_lines":[{"line_number":916,"context_line":""},{"line_number":917,"context_line":"        :param image_dict: a dictionary containing property/URL pair."},{"line_number":918,"context_line":"        :returns: None"},{"line_number":919,"context_line":"        :raises: MissingParameterValue, if any of URLs provided are insecured."},{"line_number":920,"context_line":"        \"\"\""},{"line_number":921,"context_line":"        insecure_props \u003d []"},{"line_number":922,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"9f560f44_9e01476e","line":919,"range":{"start_line":919,"start_character":68,"end_line":919,"end_character":77},"updated":"2020-09-15 07:05:43.000000000","message":"s/ insecured / insecure /","commit_id":"0a094a37cbd990039b1f583f5bae76475efbb844"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"08db06de21103c166faf1297c8a5ad544fb0977a","unresolved":false,"context_lines":[{"line_number":916,"context_line":""},{"line_number":917,"context_line":"        :param image_dict: a dictionary containing property/URL pair."},{"line_number":918,"context_line":"        :returns: None"},{"line_number":919,"context_line":"        :raises: MissingParameterValue, if any of URLs provided are insecured."},{"line_number":920,"context_line":"        \"\"\""},{"line_number":921,"context_line":"        insecure_props \u003d []"},{"line_number":922,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"9f560f44_ab5e8a76","line":919,"range":{"start_line":919,"start_character":17,"end_line":919,"end_character":38},"in_reply_to":"9f560f44_5e07af82","updated":"2020-09-15 11:49:54.000000000","message":"Done","commit_id":"0a094a37cbd990039b1f583f5bae76475efbb844"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"08db06de21103c166faf1297c8a5ad544fb0977a","unresolved":false,"context_lines":[{"line_number":916,"context_line":""},{"line_number":917,"context_line":"        :param image_dict: a dictionary containing property/URL pair."},{"line_number":918,"context_line":"        :returns: None"},{"line_number":919,"context_line":"        :raises: MissingParameterValue, if any of URLs provided are insecured."},{"line_number":920,"context_line":"        \"\"\""},{"line_number":921,"context_line":"        insecure_props \u003d []"},{"line_number":922,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"9f560f44_4b708e09","line":919,"range":{"start_line":919,"start_character":68,"end_line":919,"end_character":77},"in_reply_to":"9f560f44_9e01476e","updated":"2020-09-15 11:49:54.000000000","message":"Done","commit_id":"0a094a37cbd990039b1f583f5bae76475efbb844"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"2457c8e0e7e988303ae3fcdc0f35e9af72260692","unresolved":false,"context_lines":[{"line_number":928,"context_line":"                    insecure_props.append(prop)"},{"line_number":929,"context_line":""},{"line_number":930,"context_line":"        if len(insecure_props) \u003e 0:"},{"line_number":931,"context_line":"            error \u003d (_(\u0027Secured URLs exposed over HTTPS are expected. \u0027"},{"line_number":932,"context_line":"                       \u0027Insecured URLs are provided for %s\u0027) % insecure_props)"},{"line_number":933,"context_line":"            raise exception.InvalidParameterValue(error)"},{"line_number":934,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"9f560f44_7eb433d5","line":931,"range":{"start_line":931,"start_character":24,"end_line":931,"end_character":31},"updated":"2020-09-15 07:05:43.000000000","message":"s/ Secured //","commit_id":"0a094a37cbd990039b1f583f5bae76475efbb844"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"08db06de21103c166faf1297c8a5ad544fb0977a","unresolved":false,"context_lines":[{"line_number":928,"context_line":"                    insecure_props.append(prop)"},{"line_number":929,"context_line":""},{"line_number":930,"context_line":"        if len(insecure_props) \u003e 0:"},{"line_number":931,"context_line":"            error \u003d (_(\u0027Secured URLs exposed over HTTPS are expected. \u0027"},{"line_number":932,"context_line":"                       \u0027Insecured URLs are provided for %s\u0027) % insecure_props)"},{"line_number":933,"context_line":"            raise exception.InvalidParameterValue(error)"},{"line_number":934,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"9f560f44_cb5dbe7a","line":931,"range":{"start_line":931,"start_character":24,"end_line":931,"end_character":31},"in_reply_to":"9f560f44_7eb433d5","updated":"2020-09-15 11:49:54.000000000","message":"Will make it Secure. Better to stress that in the error message for clear indication.","commit_id":"0a094a37cbd990039b1f583f5bae76475efbb844"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"2457c8e0e7e988303ae3fcdc0f35e9af72260692","unresolved":false,"context_lines":[{"line_number":929,"context_line":""},{"line_number":930,"context_line":"        if len(insecure_props) \u003e 0:"},{"line_number":931,"context_line":"            error \u003d (_(\u0027Secured URLs exposed over HTTPS are expected. \u0027"},{"line_number":932,"context_line":"                       \u0027Insecured URLs are provided for %s\u0027) % insecure_props)"},{"line_number":933,"context_line":"            raise exception.InvalidParameterValue(error)"},{"line_number":934,"context_line":""},{"line_number":935,"context_line":"    def _parse_deploy_info(self, node):"}],"source_content_type":"text/x-python","patch_set":15,"id":"9f560f44_feccc363","line":932,"range":{"start_line":932,"start_character":24,"end_line":932,"end_character":33},"updated":"2020-09-15 07:05:43.000000000","message":"s/ Insecured / Insecure /","commit_id":"0a094a37cbd990039b1f583f5bae76475efbb844"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"08db06de21103c166faf1297c8a5ad544fb0977a","unresolved":false,"context_lines":[{"line_number":929,"context_line":""},{"line_number":930,"context_line":"        if len(insecure_props) \u003e 0:"},{"line_number":931,"context_line":"            error \u003d (_(\u0027Secured URLs exposed over HTTPS are expected. \u0027"},{"line_number":932,"context_line":"                       \u0027Insecured URLs are provided for %s\u0027) % insecure_props)"},{"line_number":933,"context_line":"            raise exception.InvalidParameterValue(error)"},{"line_number":934,"context_line":""},{"line_number":935,"context_line":"    def _parse_deploy_info(self, node):"}],"source_content_type":"text/x-python","patch_set":15,"id":"9f560f44_2b527a69","line":932,"range":{"start_line":932,"start_character":24,"end_line":932,"end_character":33},"in_reply_to":"9f560f44_feccc363","updated":"2020-09-15 11:49:54.000000000","message":"Done","commit_id":"0a094a37cbd990039b1f583f5bae76475efbb844"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"2457c8e0e7e988303ae3fcdc0f35e9af72260692","unresolved":false,"context_lines":[{"line_number":980,"context_line":""},{"line_number":981,"context_line":"        self._validate_hrefs(deploy_info)"},{"line_number":982,"context_line":""},{"line_number":983,"context_line":"        error_msg \u003d (_(\"Error validating %s for iLO UEFIHTTPS boot. Some \""},{"line_number":984,"context_line":"                       \"parameters were missing in node\u0027s driver_info\") % mode)"},{"line_number":985,"context_line":"        deploy_utils.check_for_missing_params(deploy_info, error_msg)"},{"line_number":986,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"9f560f44_9ee827b4","line":983,"range":{"start_line":983,"start_character":52,"end_line":983,"end_character":61},"updated":"2020-09-15 07:05:43.000000000","message":"s/ UEFIHTTPS / UEFI HTTPS /","commit_id":"0a094a37cbd990039b1f583f5bae76475efbb844"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"08db06de21103c166faf1297c8a5ad544fb0977a","unresolved":false,"context_lines":[{"line_number":980,"context_line":""},{"line_number":981,"context_line":"        self._validate_hrefs(deploy_info)"},{"line_number":982,"context_line":""},{"line_number":983,"context_line":"        error_msg \u003d (_(\"Error validating %s for iLO UEFIHTTPS boot. Some \""},{"line_number":984,"context_line":"                       \"parameters were missing in node\u0027s driver_info\") % mode)"},{"line_number":985,"context_line":"        deploy_utils.check_for_missing_params(deploy_info, error_msg)"},{"line_number":986,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"9f560f44_6b4c72c8","line":983,"range":{"start_line":983,"start_character":52,"end_line":983,"end_character":61},"in_reply_to":"9f560f44_9ee827b4","updated":"2020-09-15 11:49:54.000000000","message":"Done","commit_id":"0a094a37cbd990039b1f583f5bae76475efbb844"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"2457c8e0e7e988303ae3fcdc0f35e9af72260692","unresolved":false,"context_lines":[{"line_number":1040,"context_line":"        \"\"\""},{"line_number":1041,"context_line":"        node \u003d task.node"},{"line_number":1042,"context_line":"        boot_option \u003d deploy_utils.get_boot_option(node)"},{"line_number":1043,"context_line":"        boot_mode \u003d ilo_common.get_current_boot_mode(task.node)"},{"line_number":1044,"context_line":""},{"line_number":1045,"context_line":"        if boot_mode.lower() !\u003d \u0027uefi\u0027:"},{"line_number":1046,"context_line":"            error \u003d _(\"Validation for \u0027ilo-uefi-https\u0027 boot interface failed.\""}],"source_content_type":"text/x-python","patch_set":15,"id":"9f560f44_3ee11b9d","line":1043,"range":{"start_line":1043,"start_character":31,"end_line":1043,"end_character":52},"updated":"2020-09-15 07:05:43.000000000","message":"This can raise IloOperationError. Need to handle/ update doc string?","commit_id":"0a094a37cbd990039b1f583f5bae76475efbb844"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"08db06de21103c166faf1297c8a5ad544fb0977a","unresolved":false,"context_lines":[{"line_number":1040,"context_line":"        \"\"\""},{"line_number":1041,"context_line":"        node \u003d task.node"},{"line_number":1042,"context_line":"        boot_option \u003d deploy_utils.get_boot_option(node)"},{"line_number":1043,"context_line":"        boot_mode \u003d ilo_common.get_current_boot_mode(task.node)"},{"line_number":1044,"context_line":""},{"line_number":1045,"context_line":"        if boot_mode.lower() !\u003d \u0027uefi\u0027:"},{"line_number":1046,"context_line":"            error \u003d _(\"Validation for \u0027ilo-uefi-https\u0027 boot interface failed.\""}],"source_content_type":"text/x-python","patch_set":15,"id":"9f560f44_e6d9d956","line":1043,"range":{"start_line":1043,"start_character":31,"end_line":1043,"end_character":52},"in_reply_to":"9f560f44_3ee11b9d","updated":"2020-09-15 11:49:54.000000000","message":"Done","commit_id":"0a094a37cbd990039b1f583f5bae76475efbb844"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"2457c8e0e7e988303ae3fcdc0f35e9af72260692","unresolved":false,"context_lines":[{"line_number":1043,"context_line":"        boot_mode \u003d ilo_common.get_current_boot_mode(task.node)"},{"line_number":1044,"context_line":""},{"line_number":1045,"context_line":"        if boot_mode.lower() !\u003d \u0027uefi\u0027:"},{"line_number":1046,"context_line":"            error \u003d _(\"Validation for \u0027ilo-uefi-https\u0027 boot interface failed.\""},{"line_number":1047,"context_line":"                      \" The node is expected to be in in \u0027UEFI\u0027 mode.\")"},{"line_number":1048,"context_line":"            raise exception.InvalidParameterValue(error)"},{"line_number":1049,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"9f560f44_becd2b32","line":1046,"range":{"start_line":1046,"start_character":75,"end_line":1046,"end_character":78},"updated":"2020-09-15 07:05:43.000000000","message":"As a convention, we leave a space at the end.","commit_id":"0a094a37cbd990039b1f583f5bae76475efbb844"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"08db06de21103c166faf1297c8a5ad544fb0977a","unresolved":false,"context_lines":[{"line_number":1043,"context_line":"        boot_mode \u003d ilo_common.get_current_boot_mode(task.node)"},{"line_number":1044,"context_line":""},{"line_number":1045,"context_line":"        if boot_mode.lower() !\u003d \u0027uefi\u0027:"},{"line_number":1046,"context_line":"            error \u003d _(\"Validation for \u0027ilo-uefi-https\u0027 boot interface failed.\""},{"line_number":1047,"context_line":"                      \" The node is expected to be in in \u0027UEFI\u0027 mode.\")"},{"line_number":1048,"context_line":"            raise exception.InvalidParameterValue(error)"},{"line_number":1049,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"9f560f44_46a6c5ad","line":1046,"range":{"start_line":1046,"start_character":75,"end_line":1046,"end_character":78},"in_reply_to":"9f560f44_becd2b32","updated":"2020-09-15 11:49:54.000000000","message":"Done","commit_id":"0a094a37cbd990039b1f583f5bae76475efbb844"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"ec87bea2e9ce6c7f7a3eddd2af2efc948dfdeccf","unresolved":false,"context_lines":[{"line_number":1044,"context_line":""},{"line_number":1045,"context_line":"        if boot_mode.lower() !\u003d \u0027uefi\u0027:"},{"line_number":1046,"context_line":"            error \u003d _(\"Validation for \u0027ilo-uefi-https\u0027 boot interface failed.\""},{"line_number":1047,"context_line":"                      \" The node is expected to be in in \u0027UEFI\u0027 mode.\")"},{"line_number":1048,"context_line":"            raise exception.InvalidParameterValue(error)"},{"line_number":1049,"context_line":""},{"line_number":1050,"context_line":"        boot_iso \u003d node.instance_info.get(\u0027ilo_boot_iso\u0027)"}],"source_content_type":"text/x-python","patch_set":15,"id":"9f560f44_52fa0843","line":1047,"updated":"2020-09-14 22:36:08.000000000","message":"Instead of \"expected\", what about explicitly stating that UEFI is required?","commit_id":"0a094a37cbd990039b1f583f5bae76475efbb844"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"2457c8e0e7e988303ae3fcdc0f35e9af72260692","unresolved":false,"context_lines":[{"line_number":1044,"context_line":""},{"line_number":1045,"context_line":"        if boot_mode.lower() !\u003d \u0027uefi\u0027:"},{"line_number":1046,"context_line":"            error \u003d _(\"Validation for \u0027ilo-uefi-https\u0027 boot interface failed.\""},{"line_number":1047,"context_line":"                      \" The node is expected to be in in \u0027UEFI\u0027 mode.\")"},{"line_number":1048,"context_line":"            raise exception.InvalidParameterValue(error)"},{"line_number":1049,"context_line":""},{"line_number":1050,"context_line":"        boot_iso \u003d node.instance_info.get(\u0027ilo_boot_iso\u0027)"}],"source_content_type":"text/x-python","patch_set":15,"id":"9f560f44_fed683c4","line":1047,"range":{"start_line":1047,"start_character":22,"end_line":1047,"end_character":25},"updated":"2020-09-15 07:05:43.000000000","message":"The space at beginning to be moved to end of previous line.","commit_id":"0a094a37cbd990039b1f583f5bae76475efbb844"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"2457c8e0e7e988303ae3fcdc0f35e9af72260692","unresolved":false,"context_lines":[{"line_number":1044,"context_line":""},{"line_number":1045,"context_line":"        if boot_mode.lower() !\u003d \u0027uefi\u0027:"},{"line_number":1046,"context_line":"            error \u003d _(\"Validation for \u0027ilo-uefi-https\u0027 boot interface failed.\""},{"line_number":1047,"context_line":"                      \" The node is expected to be in in \u0027UEFI\u0027 mode.\")"},{"line_number":1048,"context_line":"            raise exception.InvalidParameterValue(error)"},{"line_number":1049,"context_line":""},{"line_number":1050,"context_line":"        boot_iso \u003d node.instance_info.get(\u0027ilo_boot_iso\u0027)"}],"source_content_type":"text/x-python","patch_set":15,"id":"9f560f44_3e4c7bc7","line":1047,"range":{"start_line":1047,"start_character":64,"end_line":1047,"end_character":68},"updated":"2020-09-15 07:05:43.000000000","message":"s/ mode / boot mode /","commit_id":"0a094a37cbd990039b1f583f5bae76475efbb844"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"08db06de21103c166faf1297c8a5ad544fb0977a","unresolved":false,"context_lines":[{"line_number":1044,"context_line":""},{"line_number":1045,"context_line":"        if boot_mode.lower() !\u003d \u0027uefi\u0027:"},{"line_number":1046,"context_line":"            error \u003d _(\"Validation for \u0027ilo-uefi-https\u0027 boot interface failed.\""},{"line_number":1047,"context_line":"                      \" The node is expected to be in in \u0027UEFI\u0027 mode.\")"},{"line_number":1048,"context_line":"            raise exception.InvalidParameterValue(error)"},{"line_number":1049,"context_line":""},{"line_number":1050,"context_line":"        boot_iso \u003d node.instance_info.get(\u0027ilo_boot_iso\u0027)"}],"source_content_type":"text/x-python","patch_set":15,"id":"9f560f44_66a9497b","line":1047,"range":{"start_line":1047,"start_character":64,"end_line":1047,"end_character":68},"in_reply_to":"9f560f44_3e4c7bc7","updated":"2020-09-15 11:49:54.000000000","message":"Done","commit_id":"0a094a37cbd990039b1f583f5bae76475efbb844"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"08db06de21103c166faf1297c8a5ad544fb0977a","unresolved":false,"context_lines":[{"line_number":1044,"context_line":""},{"line_number":1045,"context_line":"        if boot_mode.lower() !\u003d \u0027uefi\u0027:"},{"line_number":1046,"context_line":"            error \u003d _(\"Validation for \u0027ilo-uefi-https\u0027 boot interface failed.\""},{"line_number":1047,"context_line":"                      \" The node is expected to be in in \u0027UEFI\u0027 mode.\")"},{"line_number":1048,"context_line":"            raise exception.InvalidParameterValue(error)"},{"line_number":1049,"context_line":""},{"line_number":1050,"context_line":"        boot_iso \u003d node.instance_info.get(\u0027ilo_boot_iso\u0027)"}],"source_content_type":"text/x-python","patch_set":15,"id":"9f560f44_069ccd59","line":1047,"range":{"start_line":1047,"start_character":22,"end_line":1047,"end_character":25},"in_reply_to":"9f560f44_fed683c4","updated":"2020-09-15 11:49:54.000000000","message":"Done","commit_id":"0a094a37cbd990039b1f583f5bae76475efbb844"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"2457c8e0e7e988303ae3fcdc0f35e9af72260692","unresolved":false,"context_lines":[{"line_number":1048,"context_line":"            raise exception.InvalidParameterValue(error)"},{"line_number":1049,"context_line":""},{"line_number":1050,"context_line":"        boot_iso \u003d node.instance_info.get(\u0027ilo_boot_iso\u0027)"},{"line_number":1051,"context_line":"        if (boot_option \u003d\u003d \"ramdisk\" and boot_iso):"},{"line_number":1052,"context_line":"            if not service_utils.is_glance_image(boot_iso):"},{"line_number":1053,"context_line":"                try:"},{"line_number":1054,"context_line":"                    image_service.HttpImageService().validate_href(boot_iso)"}],"source_content_type":"text/x-python","patch_set":15,"id":"9f560f44_5e968ff1","line":1051,"range":{"start_line":1051,"start_character":7,"end_line":1051,"end_character":51},"updated":"2020-09-15 07:05:43.000000000","message":"boot_iso is used for non-disk boot as well.","commit_id":"0a094a37cbd990039b1f583f5bae76475efbb844"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"08db06de21103c166faf1297c8a5ad544fb0977a","unresolved":false,"context_lines":[{"line_number":1048,"context_line":"            raise exception.InvalidParameterValue(error)"},{"line_number":1049,"context_line":""},{"line_number":1050,"context_line":"        boot_iso \u003d node.instance_info.get(\u0027ilo_boot_iso\u0027)"},{"line_number":1051,"context_line":"        if (boot_option \u003d\u003d \"ramdisk\" and boot_iso):"},{"line_number":1052,"context_line":"            if not service_utils.is_glance_image(boot_iso):"},{"line_number":1053,"context_line":"                try:"},{"line_number":1054,"context_line":"                    image_service.HttpImageService().validate_href(boot_iso)"}],"source_content_type":"text/x-python","patch_set":15,"id":"9f560f44_a6b401d6","line":1051,"range":{"start_line":1051,"start_character":7,"end_line":1051,"end_character":51},"in_reply_to":"9f560f44_5e968ff1","updated":"2020-09-15 11:49:54.000000000","message":"yes. So if the boot_option is not \"ramdisk\" we handle that case as well below.","commit_id":"0a094a37cbd990039b1f583f5bae76475efbb844"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"2457c8e0e7e988303ae3fcdc0f35e9af72260692","unresolved":false,"context_lines":[{"line_number":1051,"context_line":"        if (boot_option \u003d\u003d \"ramdisk\" and boot_iso):"},{"line_number":1052,"context_line":"            if not service_utils.is_glance_image(boot_iso):"},{"line_number":1053,"context_line":"                try:"},{"line_number":1054,"context_line":"                    image_service.HttpImageService().validate_href(boot_iso)"},{"line_number":1055,"context_line":"                except exception.ImageRefValidationFailed:"},{"line_number":1056,"context_line":"                    with excutils.save_and_reraise_exception():"},{"line_number":1057,"context_line":"                        LOG.error(\"UEFI-HTTPS boot with \u0027ramdisk\u0027 \""}],"source_content_type":"text/x-python","patch_set":15,"id":"9f560f44_be69abf9","line":1054,"range":{"start_line":1054,"start_character":53,"end_line":1054,"end_character":66},"updated":"2020-09-15 07:05:43.000000000","message":"This will not validate for HTTPS. Should also call _validate_hrefs ?","commit_id":"0a094a37cbd990039b1f583f5bae76475efbb844"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"08db06de21103c166faf1297c8a5ad544fb0977a","unresolved":false,"context_lines":[{"line_number":1051,"context_line":"        if (boot_option \u003d\u003d \"ramdisk\" and boot_iso):"},{"line_number":1052,"context_line":"            if not service_utils.is_glance_image(boot_iso):"},{"line_number":1053,"context_line":"                try:"},{"line_number":1054,"context_line":"                    image_service.HttpImageService().validate_href(boot_iso)"},{"line_number":1055,"context_line":"                except exception.ImageRefValidationFailed:"},{"line_number":1056,"context_line":"                    with excutils.save_and_reraise_exception():"},{"line_number":1057,"context_line":"                        LOG.error(\"UEFI-HTTPS boot with \u0027ramdisk\u0027 \""}],"source_content_type":"text/x-python","patch_set":15,"id":"9f560f44_26c8f154","line":1054,"range":{"start_line":1054,"start_character":53,"end_line":1054,"end_character":66},"in_reply_to":"9f560f44_be69abf9","updated":"2020-09-15 11:49:54.000000000","message":"This will now be validated if the webserver_verify_ca is set to True or some custom certificate path.","commit_id":"0a094a37cbd990039b1f583f5bae76475efbb844"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"2457c8e0e7e988303ae3fcdc0f35e9af72260692","unresolved":false,"context_lines":[{"line_number":1199,"context_line":""},{"line_number":1200,"context_line":"        params \u003d {}"},{"line_number":1201,"context_line":""},{"line_number":1202,"context_line":"        if boot_option !\u003d \u0027ramdisk\u0027:"},{"line_number":1203,"context_line":"            root_uuid \u003d node.driver_internal_info.get(\u0027root_uuid_or_disk_id\u0027)"},{"line_number":1204,"context_line":"            if not root_uuid and task.driver.storage.should_write_image(task):"},{"line_number":1205,"context_line":"                LOG.warning("}],"source_content_type":"text/x-python","patch_set":15,"id":"9f560f44_f2efd71a","line":1202,"range":{"start_line":1202,"start_character":7,"end_line":1202,"end_character":36},"updated":"2020-09-15 07:05:43.000000000","message":"It can be vmedia boot from ilo_boot_iso as well? See https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/ilo/boot.py#L571-L596\nAlso need to update bare metal for secure boot?","commit_id":"0a094a37cbd990039b1f583f5bae76475efbb844"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"e28c428c6a31833c6ccb93aad9dec67ef45b6620","unresolved":false,"context_lines":[{"line_number":1199,"context_line":""},{"line_number":1200,"context_line":"        params \u003d {}"},{"line_number":1201,"context_line":""},{"line_number":1202,"context_line":"        if boot_option !\u003d \u0027ramdisk\u0027:"},{"line_number":1203,"context_line":"            root_uuid \u003d node.driver_internal_info.get(\u0027root_uuid_or_disk_id\u0027)"},{"line_number":1204,"context_line":"            if not root_uuid and task.driver.storage.should_write_image(task):"},{"line_number":1205,"context_line":"                LOG.warning("}],"source_content_type":"text/x-python","patch_set":15,"id":"9f560f44_bdb67e3d","line":1202,"range":{"start_line":1202,"start_character":7,"end_line":1202,"end_character":36},"in_reply_to":"9f560f44_a6024171","updated":"2020-09-18 19:40:10.000000000","message":"I believe he is referencing the boot from ISO work/functionality which is covered as a ramdisk deploy interface use.\n\nAlso, w/r/t secure boot, please do any of that in a separate patch since if there are specific mechanics or changes, then it would be good to delineate them.","commit_id":"0a094a37cbd990039b1f583f5bae76475efbb844"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"08db06de21103c166faf1297c8a5ad544fb0977a","unresolved":false,"context_lines":[{"line_number":1199,"context_line":""},{"line_number":1200,"context_line":"        params \u003d {}"},{"line_number":1201,"context_line":""},{"line_number":1202,"context_line":"        if boot_option !\u003d \u0027ramdisk\u0027:"},{"line_number":1203,"context_line":"            root_uuid \u003d node.driver_internal_info.get(\u0027root_uuid_or_disk_id\u0027)"},{"line_number":1204,"context_line":"            if not root_uuid and task.driver.storage.should_write_image(task):"},{"line_number":1205,"context_line":"                LOG.warning("}],"source_content_type":"text/x-python","patch_set":15,"id":"9f560f44_a6024171","line":1202,"range":{"start_line":1202,"start_character":7,"end_line":1202,"end_character":36},"in_reply_to":"9f560f44_f2efd71a","updated":"2020-09-15 11:49:54.000000000","message":"I didn\u0027t get this comment. The secure boot part i have removed in my previous patch as those are not supported for now.","commit_id":"0a094a37cbd990039b1f583f5bae76475efbb844"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"2457c8e0e7e988303ae3fcdc0f35e9af72260692","unresolved":false,"context_lines":[{"line_number":1239,"context_line":"                  \"%(node)s\", {\u0027node\u0027: task.node.uuid})"},{"line_number":1240,"context_line":""},{"line_number":1241,"context_line":"        image_utils.cleanup_iso_image(task)"},{"line_number":1242,"context_line":"        ilo_common.clear_certificates(task)"},{"line_number":1243,"context_line":""},{"line_number":1244,"context_line":"    @METRICS.timer(\u0027IloUefiHttpsBoot.validate_rescue\u0027)"},{"line_number":1245,"context_line":"    def validate_rescue(self, task):"}],"source_content_type":"text/x-python","patch_set":15,"id":"9f560f44_12bfebfc","line":1242,"range":{"start_line":1242,"start_character":8,"end_line":1242,"end_character":43},"updated":"2020-09-15 07:05:43.000000000","message":"Is it a good idea to update certificates for/after every deploy time or would it be better to provide it as an option  to user to make a choice to overwrite or use ones already loaded ?","commit_id":"0a094a37cbd990039b1f583f5bae76475efbb844"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"fc2d066a031b7ad9b0da89cbc15930effec16efd","unresolved":false,"context_lines":[{"line_number":1239,"context_line":"                  \"%(node)s\", {\u0027node\u0027: task.node.uuid})"},{"line_number":1240,"context_line":""},{"line_number":1241,"context_line":"        image_utils.cleanup_iso_image(task)"},{"line_number":1242,"context_line":"        ilo_common.clear_certificates(task)"},{"line_number":1243,"context_line":""},{"line_number":1244,"context_line":"    @METRICS.timer(\u0027IloUefiHttpsBoot.validate_rescue\u0027)"},{"line_number":1245,"context_line":"    def validate_rescue(self, task):"}],"source_content_type":"text/x-python","patch_set":15,"id":"9f560f44_577dcdb0","line":1242,"range":{"start_line":1242,"start_character":8,"end_line":1242,"end_character":43},"in_reply_to":"9f560f44_12bfebfc","updated":"2020-09-15 14:31:58.000000000","message":"If i understand it correctly, u\u0027r suggesting that instead of config parameters if we update the certificate info in node properties, the user would have the flexibility to provide/change the certificate. IMO, it\u0027s good enough to keep it as a config parameter as the user may not frequently wants to change the certificate or webservers that host the images, even so we still are giving the flexibility in terms of config parameter.","commit_id":"0a094a37cbd990039b1f583f5bae76475efbb844"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"cea8ffc6975af87a1967a5ce834597beeb5ed74e","unresolved":false,"context_lines":[{"line_number":1239,"context_line":"                  \"%(node)s\", {\u0027node\u0027: task.node.uuid})"},{"line_number":1240,"context_line":""},{"line_number":1241,"context_line":"        image_utils.cleanup_iso_image(task)"},{"line_number":1242,"context_line":"        ilo_common.clear_certificates(task)"},{"line_number":1243,"context_line":""},{"line_number":1244,"context_line":"    @METRICS.timer(\u0027IloUefiHttpsBoot.validate_rescue\u0027)"},{"line_number":1245,"context_line":"    def validate_rescue(self, task):"}],"source_content_type":"text/x-python","patch_set":15,"id":"9f560f44_65800cc1","line":1242,"range":{"start_line":1242,"start_character":8,"end_line":1242,"end_character":43},"in_reply_to":"9f560f44_577dcdb0","updated":"2020-09-16 11:08:01.000000000","message":"No, I meant was to have a separate deploy/clean step to load/unload certificates. User need not do that for every deploy. But it can be a separate patch.","commit_id":"0a094a37cbd990039b1f583f5bae76475efbb844"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"cea8ffc6975af87a1967a5ce834597beeb5ed74e","unresolved":false,"context_lines":[{"line_number":1156,"context_line":"        ilo_common.setup_uefi_https(task, iso_ref)"},{"line_number":1157,"context_line":""},{"line_number":1158,"context_line":"    @METRICS.timer(\u0027IloUefiHttpsBoot.clean_up_ramdisk\u0027)"},{"line_number":1159,"context_line":"    def clean_up_ramdisk(self, task):"},{"line_number":1160,"context_line":"        \"\"\"Cleans up the boot of ironic ramdisk."},{"line_number":1161,"context_line":""},{"line_number":1162,"context_line":"        This method cleans up the environment that was setup for booting the"}],"source_content_type":"text/x-python","patch_set":18,"id":"9f560f44_6b573bcc","line":1159,"range":{"start_line":1159,"start_character":8,"end_line":1159,"end_character":24},"updated":"2020-09-16 11:08:01.000000000","message":"Add a testcase for this method.","commit_id":"cd9a092f2404b465f17d12a00e078a755dd9ce23"}],"ironic/drivers/modules/ilo/common.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"09ebd7a5ce0cef45dcb918593f0cb059bce39b06","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2014 Hewlett-Packard Development Company, L.P."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_80cd8eb8","line":1,"updated":"2020-08-10 10:51:16.000000000","message":"pep8: E902 TokenError: EOF in multi-line statement","commit_id":"626c099d98d12aa9f87b578003d4b11681abe551"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"09ebd7a5ce0cef45dcb918593f0cb059bce39b06","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from base64 import b64decode"},{"line_number":20,"context_line":"import json"},{"line_number":21,"context_line":"from OpenSSL.crypto import (FILETYPE_ASN1, load_certificate)"},{"line_number":22,"context_line":"import os"},{"line_number":23,"context_line":"import re"},{"line_number":24,"context_line":"import shutil"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_e0c72a95","line":21,"updated":"2020-08-10 10:51:16.000000000","message":"pep8: H301: one import per line","commit_id":"626c099d98d12aa9f87b578003d4b11681abe551"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"09ebd7a5ce0cef45dcb918593f0cb059bce39b06","unresolved":false,"context_lines":[{"line_number":129,"context_line":"SUPPORTED_BOOT_MODE_LEGACY_BIOS_AND_UEFI \u003d \u0027legacy bios and uefi\u0027"},{"line_number":130,"context_line":"\"\"\" Node supports both legacy BIOS and UEFI boot mode.\"\"\""},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"_CERTIFICATE_PATTERN \u003d r\u0027-----BEGIN CERTIFICATE-----.*?-----END CERTIFICATE-----\u0027"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"def copy_image_to_web_server(source_file_path, destination):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_c0c2e684","line":132,"updated":"2020-08-10 10:51:16.000000000","message":"pep8: E501 line too long (81 \u003e 79 characters)","commit_id":"626c099d98d12aa9f87b578003d4b11681abe551"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"09ebd7a5ce0cef45dcb918593f0cb059bce39b06","unresolved":false,"context_lines":[{"line_number":868,"context_line":"        raise exception.IloOperationError(operation\u003doperation,"},{"line_number":869,"context_line":"                                          error\u003dilo_exception)"},{"line_number":870,"context_line":""},{"line_number":871,"context_line":"def setup_uefi_https(task, iso):"},{"line_number":872,"context_line":"    node \u003d task.node"},{"line_number":873,"context_line":"    ilo_object \u003d get_ilo_object(node)"},{"line_number":874,"context_line":"    verify_certs \u003d CONF.verify_certs"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_20be42fe","line":871,"updated":"2020-08-10 10:51:16.000000000","message":"pep8: E302 expected 2 blank lines, found 1","commit_id":"626c099d98d12aa9f87b578003d4b11681abe551"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"09ebd7a5ce0cef45dcb918593f0cb059bce39b06","unresolved":false,"context_lines":[{"line_number":905,"context_line":"                fp_list.append(fp)"},{"line_number":906,"context_line":"    ilo_object.remove_tls_certificate(fp_list)"},{"line_number":907,"context_line":"    LOG.info(\"Cleared the certificates from the node successfully.\")"},{"line_number":908,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_00b97e13","line":908,"updated":"2020-08-10 10:51:16.000000000","message":"pep8: W391 blank line at end of file","commit_id":"626c099d98d12aa9f87b578003d4b11681abe551"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"d0a8f2ad998cb53c35be7045054cac11adc56dc6","unresolved":false,"context_lines":[{"line_number":125,"context_line":"SUPPORTED_BOOT_MODE_LEGACY_BIOS_AND_UEFI \u003d \u0027legacy bios and uefi\u0027"},{"line_number":126,"context_line":"\"\"\" Node supports both legacy BIOS and UEFI boot mode.\"\"\""},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"_CERTIFICATE_PATTERN \u003d r\u0027-----BEGIN CERTIFICATE-----.*?-----END CERTIFICATE-----\u0027"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"def copy_image_to_web_server(source_file_path, destination):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_a93c3be1","line":128,"updated":"2020-08-24 09:56:54.000000000","message":"pep8: E501 line too long (81 \u003e 79 characters)","commit_id":"3641eaece282539dabd87f74a2b20ff351d41762"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"d0a8f2ad998cb53c35be7045054cac11adc56dc6","unresolved":false,"context_lines":[{"line_number":864,"context_line":"        raise exception.IloOperationError(operation\u003doperation,"},{"line_number":865,"context_line":"                                          error\u003dilo_exception)"},{"line_number":866,"context_line":""},{"line_number":867,"context_line":"def setup_uefi_https(task, iso):"},{"line_number":868,"context_line":"    node \u003d task.node"},{"line_number":869,"context_line":"    ilo_object \u003d get_ilo_object(node)"},{"line_number":870,"context_line":"    scheme \u003d urlparse.urlparse(iso).scheme.lower()"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_092567c2","line":867,"updated":"2020-08-24 09:56:54.000000000","message":"pep8: E302 expected 2 blank lines, found 1","commit_id":"3641eaece282539dabd87f74a2b20ff351d41762"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"d0a8f2ad998cb53c35be7045054cac11adc56dc6","unresolved":false,"context_lines":[{"line_number":896,"context_line":"        raise exception.IloOperationNotSupported(operation\u003doperation,"},{"line_number":897,"context_line":"                                                 error\u003dmsg)"},{"line_number":898,"context_line":""},{"line_number":899,"context_line":"def clear_certificates(task):"},{"line_number":900,"context_line":"    node \u003d task.node"},{"line_number":901,"context_line":"    verify_certs \u003d CONF.verify_certs"},{"line_number":902,"context_line":"    certs_path \u003d CONF.certs_path"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_e92113b6","line":899,"updated":"2020-08-24 09:56:54.000000000","message":"pep8: E302 expected 2 blank lines, found 1","commit_id":"3641eaece282539dabd87f74a2b20ff351d41762"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"d0a8f2ad998cb53c35be7045054cac11adc56dc6","unresolved":false,"context_lines":[{"line_number":915,"context_line":"                                              error\u003dilo_exception)"},{"line_number":916,"context_line":"        LOG.info(\"Cleared certificates from the node %(node)s successfully.\","},{"line_number":917,"context_line":"                 {\u0027node\u0027: node.uuid})"},{"line_number":918,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_492bdf93","line":918,"updated":"2020-08-24 09:56:54.000000000","message":"pep8: W391 blank line at end of file","commit_id":"3641eaece282539dabd87f74a2b20ff351d41762"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"34863a0b25b3ad4aa95d5e22e543bb33b9995dfc","unresolved":false,"context_lines":[{"line_number":125,"context_line":"SUPPORTED_BOOT_MODE_LEGACY_BIOS_AND_UEFI \u003d \u0027legacy bios and uefi\u0027"},{"line_number":126,"context_line":"\"\"\" Node supports both legacy BIOS and UEFI boot mode.\"\"\""},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"_CERTIFICATE_PATTERN \u003d r\u0027-----BEGIN CERTIFICATE-----.*?-----END CERTIFICATE-----\u0027"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"def copy_image_to_web_server(source_file_path, destination):"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_c72cdc03","line":128,"updated":"2020-08-25 19:52:11.000000000","message":"pep8: E501 line too long (81 \u003e 79 characters)","commit_id":"eb3d0ed8db4954bd6aea1096d40300fd294d5103"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"34863a0b25b3ad4aa95d5e22e543bb33b9995dfc","unresolved":false,"context_lines":[{"line_number":864,"context_line":"        raise exception.IloOperationError(operation\u003doperation,"},{"line_number":865,"context_line":"                                          error\u003dilo_exception)"},{"line_number":866,"context_line":""},{"line_number":867,"context_line":"def setup_uefi_https(task, iso):"},{"line_number":868,"context_line":"    node \u003d task.node"},{"line_number":869,"context_line":"    ilo_object \u003d get_ilo_object(node)"},{"line_number":870,"context_line":"    scheme \u003d urlparse.urlparse(iso).scheme.lower()"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_a72f28f4","line":867,"updated":"2020-08-25 19:52:11.000000000","message":"pep8: E302 expected 2 blank lines, found 1","commit_id":"eb3d0ed8db4954bd6aea1096d40300fd294d5103"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"34863a0b25b3ad4aa95d5e22e543bb33b9995dfc","unresolved":false,"context_lines":[{"line_number":896,"context_line":"        raise exception.IloOperationNotSupported(operation\u003doperation,"},{"line_number":897,"context_line":"                                                 error\u003dmsg)"},{"line_number":898,"context_line":""},{"line_number":899,"context_line":"def clear_certificates(task):"},{"line_number":900,"context_line":"    node \u003d task.node"},{"line_number":901,"context_line":"    verify_certs \u003d CONF.verify_certs"},{"line_number":902,"context_line":"    certs_path \u003d CONF.certs_path"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_07337463","line":899,"updated":"2020-08-25 19:52:11.000000000","message":"pep8: E302 expected 2 blank lines, found 1","commit_id":"eb3d0ed8db4954bd6aea1096d40300fd294d5103"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"34863a0b25b3ad4aa95d5e22e543bb33b9995dfc","unresolved":false,"context_lines":[{"line_number":915,"context_line":"                                              error\u003dilo_exception)"},{"line_number":916,"context_line":"        LOG.info(\"Cleared certificates from the node %(node)s successfully.\","},{"line_number":917,"context_line":"                 {\u0027node\u0027: node.uuid})"},{"line_number":918,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_e735a046","line":918,"updated":"2020-08-25 19:52:11.000000000","message":"pep8: W391 blank line at end of file","commit_id":"eb3d0ed8db4954bd6aea1096d40300fd294d5103"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"81014694ac64f98beea4f84cf59c7b74afa1b746","unresolved":false,"context_lines":[{"line_number":885,"context_line":"                else:"},{"line_number":886,"context_line":"                    ilo_object.update_persistent_boot([\u0027UEFIHTTP\u0027])"},{"line_number":887,"context_line":""},{"line_number":888,"context_line":"            except ilo_error.IloCommandNotSupportedError as ilo_exception:"},{"line_number":889,"context_line":"                raise exception.IloOperationNotSupported(operation\u003doperation,"},{"line_number":890,"context_line":"                                                         error\u003dilo_exception)"},{"line_number":891,"context_line":"            except ilo_error.IloError as ilo_exception:"},{"line_number":892,"context_line":"                raise exception.IloOperationError(operation\u003doperation,"},{"line_number":893,"context_line":"                                                  error\u003dilo_exception)"},{"line_number":894,"context_line":"    else:"},{"line_number":895,"context_line":"        msg \u003d (_(\u0027Error setting up node %(node)s to boot from \u0027"},{"line_number":896,"context_line":"                 \u0027URL %(iso)s.\u0027) %"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_cccdeb5f","line":893,"range":{"start_line":888,"start_character":12,"end_line":893,"end_character":70},"updated":"2020-08-28 10:27:17.000000000","message":"Since both exceptions are handled similarly, may be you can club them together.","commit_id":"cfd8684b17f0c4930fcfacde973f5bcf8c78aecc"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"ab99a1dcf1b437b1593b5fe64c96bc4d8ffb7e43","unresolved":false,"context_lines":[{"line_number":885,"context_line":"                else:"},{"line_number":886,"context_line":"                    ilo_object.update_persistent_boot([\u0027UEFIHTTP\u0027])"},{"line_number":887,"context_line":""},{"line_number":888,"context_line":"            except ilo_error.IloCommandNotSupportedError as ilo_exception:"},{"line_number":889,"context_line":"                raise exception.IloOperationNotSupported(operation\u003doperation,"},{"line_number":890,"context_line":"                                                         error\u003dilo_exception)"},{"line_number":891,"context_line":"            except ilo_error.IloError as ilo_exception:"},{"line_number":892,"context_line":"                raise exception.IloOperationError(operation\u003doperation,"},{"line_number":893,"context_line":"                                                  error\u003dilo_exception)"},{"line_number":894,"context_line":"    else:"},{"line_number":895,"context_line":"        msg \u003d (_(\u0027Error setting up node %(node)s to boot from \u0027"},{"line_number":896,"context_line":"                 \u0027URL %(iso)s.\u0027) %"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_054fb134","line":893,"range":{"start_line":888,"start_character":12,"end_line":893,"end_character":70},"in_reply_to":"9f560f44_cccdeb5f","updated":"2020-08-28 16:09:52.000000000","message":"They are handled differently. One raises \"IloOperationError\" and other \"IloOperationNotSupported\"","commit_id":"cfd8684b17f0c4930fcfacde973f5bcf8c78aecc"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"81014694ac64f98beea4f84cf59c7b74afa1b746","unresolved":false,"context_lines":[{"line_number":893,"context_line":"                                                  error\u003dilo_exception)"},{"line_number":894,"context_line":"    else:"},{"line_number":895,"context_line":"        msg \u003d (_(\u0027Error setting up node %(node)s to boot from \u0027"},{"line_number":896,"context_line":"                 \u0027URL %(iso)s.\u0027) %"},{"line_number":897,"context_line":"               {\u0027node\u0027: node.uuid, \u0027iso\u0027: iso})"},{"line_number":898,"context_line":"        raise exception.IloOperationNotSupported(operation\u003doperation,"},{"line_number":899,"context_line":"                                                 error\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_ecbf0fa8","line":896,"range":{"start_line":896,"start_character":17,"end_line":896,"end_character":30},"updated":"2020-08-28 10:27:17.000000000","message":"It can be added that the ISO needs to be hosted over HTTPS.","commit_id":"cfd8684b17f0c4930fcfacde973f5bcf8c78aecc"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"ab99a1dcf1b437b1593b5fe64c96bc4d8ffb7e43","unresolved":false,"context_lines":[{"line_number":893,"context_line":"                                                  error\u003dilo_exception)"},{"line_number":894,"context_line":"    else:"},{"line_number":895,"context_line":"        msg \u003d (_(\u0027Error setting up node %(node)s to boot from \u0027"},{"line_number":896,"context_line":"                 \u0027URL %(iso)s.\u0027) %"},{"line_number":897,"context_line":"               {\u0027node\u0027: node.uuid, \u0027iso\u0027: iso})"},{"line_number":898,"context_line":"        raise exception.IloOperationNotSupported(operation\u003doperation,"},{"line_number":899,"context_line":"                                                 error\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_655dcdeb","line":896,"range":{"start_line":896,"start_character":17,"end_line":896,"end_character":30},"in_reply_to":"9f560f44_ecbf0fa8","updated":"2020-08-28 16:09:52.000000000","message":"Done","commit_id":"cfd8684b17f0c4930fcfacde973f5bcf8c78aecc"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"81014694ac64f98beea4f84cf59c7b74afa1b746","unresolved":false,"context_lines":[{"line_number":910,"context_line":"        try:"},{"line_number":911,"context_line":"            ilo_object \u003d get_ilo_object(node)"},{"line_number":912,"context_line":"            ilo_object.remove_tls_certificate([certs_path])"},{"line_number":913,"context_line":"        except ilo_error.IloCommandNotSupportedError as ilo_exception:"},{"line_number":914,"context_line":"            raise exception.IloOperationNotSupported(operation\u003doperation,"},{"line_number":915,"context_line":"                                                     error\u003dilo_exception)"},{"line_number":916,"context_line":"        except ilo_error.IloError as ilo_exception:"},{"line_number":917,"context_line":"            raise exception.IloOperationError(operation\u003doperation,"},{"line_number":918,"context_line":"                                              error\u003dilo_exception)"},{"line_number":919,"context_line":"        LOG.info(\"Cleared certificates from the node %(node)s successfully.\","},{"line_number":920,"context_line":"                 {\u0027node\u0027: node.uuid})"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_0cd8831c","line":918,"range":{"start_line":913,"start_character":7,"end_line":918,"end_character":66},"updated":"2020-08-28 10:27:17.000000000","message":"ditto","commit_id":"cfd8684b17f0c4930fcfacde973f5bcf8c78aecc"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"ab99a1dcf1b437b1593b5fe64c96bc4d8ffb7e43","unresolved":false,"context_lines":[{"line_number":910,"context_line":"        try:"},{"line_number":911,"context_line":"            ilo_object \u003d get_ilo_object(node)"},{"line_number":912,"context_line":"            ilo_object.remove_tls_certificate([certs_path])"},{"line_number":913,"context_line":"        except ilo_error.IloCommandNotSupportedError as ilo_exception:"},{"line_number":914,"context_line":"            raise exception.IloOperationNotSupported(operation\u003doperation,"},{"line_number":915,"context_line":"                                                     error\u003dilo_exception)"},{"line_number":916,"context_line":"        except ilo_error.IloError as ilo_exception:"},{"line_number":917,"context_line":"            raise exception.IloOperationError(operation\u003doperation,"},{"line_number":918,"context_line":"                                              error\u003dilo_exception)"},{"line_number":919,"context_line":"        LOG.info(\"Cleared certificates from the node %(node)s successfully.\","},{"line_number":920,"context_line":"                 {\u0027node\u0027: node.uuid})"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_25191522","line":918,"range":{"start_line":913,"start_character":7,"end_line":918,"end_character":66},"in_reply_to":"9f560f44_0cd8831c","updated":"2020-08-28 16:09:52.000000000","message":"See my explanation above.","commit_id":"cfd8684b17f0c4930fcfacde973f5bcf8c78aecc"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"dd0953711898da28758b6b640eacb26958822591","unresolved":false,"context_lines":[{"line_number":957,"context_line":""},{"line_number":958,"context_line":"        try:"},{"line_number":959,"context_line":"            if not isinstance(verify, bool) and os.path.exists(verify):"},{"line_number":960,"context_line":"                ilo_object.add_tls_certificate([verify])"},{"line_number":961,"context_line":""},{"line_number":962,"context_line":"            ilo_object.set_http_boot_url(iso)"},{"line_number":963,"context_line":"            LOG.info(\"Set the node to boot from URL %(iso)s successfully.\","}],"source_content_type":"text/x-python","patch_set":11,"id":"9f560f44_efc75344","line":960,"updated":"2020-09-09 13:54:13.000000000","message":"Interesting! It would be good if you can add note to explain the rational. I suspect it is to make it easier for the operator, but good in case another maintainer is debugging something or trying to understand why because this is not exactly functionality one would expect in a driver.","commit_id":"30dae4acb903b051463e045a789b1acc1ee38de4"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"49de25fc05ef50780c9a4d134dd9cffeb5058dbc","unresolved":false,"context_lines":[{"line_number":957,"context_line":""},{"line_number":958,"context_line":"        try:"},{"line_number":959,"context_line":"            if not isinstance(verify, bool) and os.path.exists(verify):"},{"line_number":960,"context_line":"                ilo_object.add_tls_certificate([verify])"},{"line_number":961,"context_line":""},{"line_number":962,"context_line":"            ilo_object.set_http_boot_url(iso)"},{"line_number":963,"context_line":"            LOG.info(\"Set the node to boot from URL %(iso)s successfully.\","}],"source_content_type":"text/x-python","patch_set":11,"id":"9f560f44_f468c3ba","line":960,"range":{"start_line":960,"start_character":27,"end_line":960,"end_character":46},"updated":"2020-09-09 16:16:41.000000000","message":"Would it be better to have this operation as a separate clean/deploy step? It would give flexibility to user to perform it once or to do it for every provisioning request. WDYT?","commit_id":"30dae4acb903b051463e045a789b1acc1ee38de4"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"a5ef2dcca814b3269cdc0888c7ec55c25fbbbfd1","unresolved":false,"context_lines":[{"line_number":957,"context_line":""},{"line_number":958,"context_line":"        try:"},{"line_number":959,"context_line":"            if not isinstance(verify, bool) and os.path.exists(verify):"},{"line_number":960,"context_line":"                ilo_object.add_tls_certificate([verify])"},{"line_number":961,"context_line":""},{"line_number":962,"context_line":"            ilo_object.set_http_boot_url(iso)"},{"line_number":963,"context_line":"            LOG.info(\"Set the node to boot from URL %(iso)s successfully.\","}],"source_content_type":"text/x-python","patch_set":11,"id":"9f560f44_81ff15aa","line":960,"range":{"start_line":960,"start_character":27,"end_line":960,"end_character":46},"in_reply_to":"9f560f44_0e2f163f","updated":"2020-09-16 08:05:56.000000000","message":"I am going to remove the certificate handling here. The certificate handling will be done through deploy steps.","commit_id":"30dae4acb903b051463e045a789b1acc1ee38de4"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"73d63e44e1e61a71f8e4ff1981309ff02694839a","unresolved":false,"context_lines":[{"line_number":957,"context_line":""},{"line_number":958,"context_line":"        try:"},{"line_number":959,"context_line":"            if not isinstance(verify, bool) and os.path.exists(verify):"},{"line_number":960,"context_line":"                ilo_object.add_tls_certificate([verify])"},{"line_number":961,"context_line":""},{"line_number":962,"context_line":"            ilo_object.set_http_boot_url(iso)"},{"line_number":963,"context_line":"            LOG.info(\"Set the node to boot from URL %(iso)s successfully.\","}],"source_content_type":"text/x-python","patch_set":11,"id":"9f560f44_0e2f163f","line":960,"range":{"start_line":960,"start_character":27,"end_line":960,"end_character":46},"in_reply_to":"9f560f44_f468c3ba","updated":"2020-09-10 09:10:10.000000000","message":"Will raise another patch for the same. For now i will keep a note as suggested by Julia.","commit_id":"30dae4acb903b051463e045a789b1acc1ee38de4"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"dd0953711898da28758b6b640eacb26958822591","unresolved":false,"context_lines":[{"line_number":974,"context_line":"            raise exception.IloOperationError(operation\u003doperation,"},{"line_number":975,"context_line":"                                              error\u003dilo_exception)"},{"line_number":976,"context_line":"    else:"},{"line_number":977,"context_line":"        msg \u003d (_(\u0027Error setting up node %(node)s to boot from \u0027"},{"line_number":978,"context_line":"                 \u0027URL %(iso)s. A secured URL is expected that is exposed \u0027"},{"line_number":979,"context_line":"                 \u0027over HTTPS.\u0027) %"},{"line_number":980,"context_line":"               {\u0027node\u0027: node.uuid, \u0027iso\u0027: iso})"},{"line_number":981,"context_line":"        raise exception.IloOperationNotSupported(operation\u003doperation,"},{"line_number":982,"context_line":"                                                 error\u003dmsg)"},{"line_number":983,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"9f560f44_4f73df4e","line":980,"range":{"start_line":977,"start_character":0,"end_line":980,"end_character":47},"updated":"2020-09-09 13:54:13.000000000","message":"I know the standard calls for HTTPS out of the gate but also offers that HTTP can be enabled? Does the ilo support this? I ask because operators may also not be aware of the key management steps required to make this work, and then try HTTP, and find it frustrating that they are getting an error.","commit_id":"30dae4acb903b051463e045a789b1acc1ee38de4"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"73d63e44e1e61a71f8e4ff1981309ff02694839a","unresolved":false,"context_lines":[{"line_number":974,"context_line":"            raise exception.IloOperationError(operation\u003doperation,"},{"line_number":975,"context_line":"                                              error\u003dilo_exception)"},{"line_number":976,"context_line":"    else:"},{"line_number":977,"context_line":"        msg \u003d (_(\u0027Error setting up node %(node)s to boot from \u0027"},{"line_number":978,"context_line":"                 \u0027URL %(iso)s. A secured URL is expected that is exposed \u0027"},{"line_number":979,"context_line":"                 \u0027over HTTPS.\u0027) %"},{"line_number":980,"context_line":"               {\u0027node\u0027: node.uuid, \u0027iso\u0027: iso})"},{"line_number":981,"context_line":"        raise exception.IloOperationNotSupported(operation\u003doperation,"},{"line_number":982,"context_line":"                                                 error\u003dmsg)"},{"line_number":983,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"9f560f44_cec23e34","line":980,"range":{"start_line":977,"start_character":0,"end_line":980,"end_character":47},"in_reply_to":"9f560f44_4f73df4e","updated":"2020-09-10 09:10:10.000000000","message":"Currently the idea is to only enable HTTPS with this boot method as that\u0027s the value add with this interface. It may be extended for HTTP in future but certainly there are other boot interfaces that solve the problem for HTTP. I will document the required steps that is going to be included in the next patchset.","commit_id":"30dae4acb903b051463e045a789b1acc1ee38de4"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"49de25fc05ef50780c9a4d134dd9cffeb5058dbc","unresolved":false,"context_lines":[{"line_number":982,"context_line":"                                                 error\u003dmsg)"},{"line_number":983,"context_line":""},{"line_number":984,"context_line":""},{"line_number":985,"context_line":"def clear_certificates(task):"},{"line_number":986,"context_line":"    \"\"\"Clears any certificates exported to the node."},{"line_number":987,"context_line":""},{"line_number":988,"context_line":"    Clears the certificates exported to the node as part of any Ironic"}],"source_content_type":"text/x-python","patch_set":11,"id":"9f560f44_d465bfe2","line":985,"range":{"start_line":985,"start_character":4,"end_line":985,"end_character":22},"updated":"2020-09-09 16:16:41.000000000","message":"This too as a separate clean/deploy step?","commit_id":"30dae4acb903b051463e045a789b1acc1ee38de4"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"73d63e44e1e61a71f8e4ff1981309ff02694839a","unresolved":false,"context_lines":[{"line_number":982,"context_line":"                                                 error\u003dmsg)"},{"line_number":983,"context_line":""},{"line_number":984,"context_line":""},{"line_number":985,"context_line":"def clear_certificates(task):"},{"line_number":986,"context_line":"    \"\"\"Clears any certificates exported to the node."},{"line_number":987,"context_line":""},{"line_number":988,"context_line":"    Clears the certificates exported to the node as part of any Ironic"}],"source_content_type":"text/x-python","patch_set":11,"id":"9f560f44_aebd4ab2","line":985,"range":{"start_line":985,"start_character":4,"end_line":985,"end_character":22},"in_reply_to":"9f560f44_d465bfe2","updated":"2020-09-10 09:10:10.000000000","message":"ditto.","commit_id":"30dae4acb903b051463e045a789b1acc1ee38de4"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"2457c8e0e7e988303ae3fcdc0f35e9af72260692","unresolved":false,"context_lines":[{"line_number":935,"context_line":"    :param iso: ISO URL to be set to boot from."},{"line_number":936,"context_line":"    :param persistent: Indicates whether the system should be set to boot"},{"line_number":937,"context_line":"        from the given device one-time or each time."},{"line_number":938,"context_line":"    :returns: POST state of the server. The valida states are:-"},{"line_number":939,"context_line":"        null, Unknown, Reset, PowerOff, InPost, InPostDiscoveryComplete"},{"line_number":940,"context_line":"        and FinishedPost."},{"line_number":941,"context_line":"    :raises: IloOperationError on an error from IloClient library."},{"line_number":942,"context_line":"    :raises: IloOperationNotSupported if retrieving post state is not"},{"line_number":943,"context_line":"        supported on the server."}],"source_content_type":"text/x-python","patch_set":15,"id":"9f560f44_92065bcd","line":940,"range":{"start_line":938,"start_character":3,"end_line":940,"end_character":25},"updated":"2020-09-15 07:05:43.000000000","message":"This looks copy/paste.","commit_id":"0a094a37cbd990039b1f583f5bae76475efbb844"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"08db06de21103c166faf1297c8a5ad544fb0977a","unresolved":false,"context_lines":[{"line_number":935,"context_line":"    :param iso: ISO URL to be set to boot from."},{"line_number":936,"context_line":"    :param persistent: Indicates whether the system should be set to boot"},{"line_number":937,"context_line":"        from the given device one-time or each time."},{"line_number":938,"context_line":"    :returns: POST state of the server. The valida states are:-"},{"line_number":939,"context_line":"        null, Unknown, Reset, PowerOff, InPost, InPostDiscoveryComplete"},{"line_number":940,"context_line":"        and FinishedPost."},{"line_number":941,"context_line":"    :raises: IloOperationError on an error from IloClient library."},{"line_number":942,"context_line":"    :raises: IloOperationNotSupported if retrieving post state is not"},{"line_number":943,"context_line":"        supported on the server."}],"source_content_type":"text/x-python","patch_set":15,"id":"9f560f44_e60a7977","line":940,"range":{"start_line":938,"start_character":3,"end_line":940,"end_character":25},"in_reply_to":"9f560f44_92065bcd","updated":"2020-09-15 11:49:54.000000000","message":"Yes, this part :). Will remove it.","commit_id":"0a094a37cbd990039b1f583f5bae76475efbb844"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"2457c8e0e7e988303ae3fcdc0f35e9af72260692","unresolved":false,"context_lines":[{"line_number":948,"context_line":"    operation \u003d (_(\"Setting up node %(node)s to boot from URL %(iso)s.\") %"},{"line_number":949,"context_line":"                 {\u0027iso\u0027: iso, \u0027node\u0027: node.uuid})"},{"line_number":950,"context_line":""},{"line_number":951,"context_line":"    if scheme \u003d\u003d \u0027https\u0027:"},{"line_number":952,"context_line":"        try:"},{"line_number":953,"context_line":"            verify \u003d strutils.bool_from_string(CONF.webserver_verify_ca,"},{"line_number":954,"context_line":"                                               strict\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":15,"id":"9f560f44_72ff47ab","line":951,"range":{"start_line":951,"start_character":4,"end_line":951,"end_character":25},"updated":"2020-09-15 07:05:43.000000000","message":"Is this check required? Can it be \u0027http\u0027?\nMay be better to move L980-L986 here and remove \u0027else\u0027 path:-\nif scheme !\u003d \u0027https\u0027:\n    msg \u003d (_(\u0027Error setting up node %(node)s to boot from \u0027\n                 \u0027URL %(iso)s. A secured URL is expected that is exposed \u0027\n                 \u0027over HTTPS.\u0027) %\n               {\u0027node\u0027: node.uuid, \u0027iso\u0027: iso})\n        raise exception.IloOperationNotSupported(operation\u003doperation,\n                                                 error\u003dmsg)","commit_id":"0a094a37cbd990039b1f583f5bae76475efbb844"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"08db06de21103c166faf1297c8a5ad544fb0977a","unresolved":false,"context_lines":[{"line_number":948,"context_line":"    operation \u003d (_(\"Setting up node %(node)s to boot from URL %(iso)s.\") %"},{"line_number":949,"context_line":"                 {\u0027iso\u0027: iso, \u0027node\u0027: node.uuid})"},{"line_number":950,"context_line":""},{"line_number":951,"context_line":"    if scheme \u003d\u003d \u0027https\u0027:"},{"line_number":952,"context_line":"        try:"},{"line_number":953,"context_line":"            verify \u003d strutils.bool_from_string(CONF.webserver_verify_ca,"},{"line_number":954,"context_line":"                                               strict\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":15,"id":"9f560f44_661e69bc","line":951,"range":{"start_line":951,"start_character":4,"end_line":951,"end_character":25},"in_reply_to":"9f560f44_72ff47ab","updated":"2020-09-15 11:49:54.000000000","message":"Done","commit_id":"0a094a37cbd990039b1f583f5bae76475efbb844"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"2457c8e0e7e988303ae3fcdc0f35e9af72260692","unresolved":false,"context_lines":[{"line_number":960,"context_line":"            # eventually being used for TLS verification by the node before"},{"line_number":961,"context_line":"            # downloading the deploy/instance images during HTTPS boot from"},{"line_number":962,"context_line":"            # URL."},{"line_number":963,"context_line":"            if not isinstance(verify, bool) and os.path.exists(verify):"},{"line_number":964,"context_line":"                ilo_object.add_tls_certificate([verify])"},{"line_number":965,"context_line":""},{"line_number":966,"context_line":"            ilo_object.set_http_boot_url(iso)"},{"line_number":967,"context_line":"            LOG.info(\"Set the node to boot from URL %(iso)s successfully.\","}],"source_content_type":"text/x-python","patch_set":15,"id":"9f560f44_92d49b21","line":964,"range":{"start_line":963,"start_character":13,"end_line":964,"end_character":56},"updated":"2020-09-15 07:05:43.000000000","message":"What if CONF.webserver_verify_ca is a boolean value?","commit_id":"0a094a37cbd990039b1f583f5bae76475efbb844"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"08db06de21103c166faf1297c8a5ad544fb0977a","unresolved":false,"context_lines":[{"line_number":960,"context_line":"            # eventually being used for TLS verification by the node before"},{"line_number":961,"context_line":"            # downloading the deploy/instance images during HTTPS boot from"},{"line_number":962,"context_line":"            # URL."},{"line_number":963,"context_line":"            if not isinstance(verify, bool) and os.path.exists(verify):"},{"line_number":964,"context_line":"                ilo_object.add_tls_certificate([verify])"},{"line_number":965,"context_line":""},{"line_number":966,"context_line":"            ilo_object.set_http_boot_url(iso)"},{"line_number":967,"context_line":"            LOG.info(\"Set the node to boot from URL %(iso)s successfully.\","}],"source_content_type":"text/x-python","patch_set":15,"id":"9f560f44_26d751c3","line":964,"range":{"start_line":963,"start_character":13,"end_line":964,"end_character":56},"in_reply_to":"9f560f44_92d49b21","updated":"2020-09-15 11:49:54.000000000","message":"Then the user intends the iLO to use standard root CAs for TLS verification when talking to the webservers. So the certificates need not be exported.","commit_id":"0a094a37cbd990039b1f583f5bae76475efbb844"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"2457c8e0e7e988303ae3fcdc0f35e9af72260692","unresolved":false,"context_lines":[{"line_number":964,"context_line":"                ilo_object.add_tls_certificate([verify])"},{"line_number":965,"context_line":""},{"line_number":966,"context_line":"            ilo_object.set_http_boot_url(iso)"},{"line_number":967,"context_line":"            LOG.info(\"Set the node to boot from URL %(iso)s successfully.\","},{"line_number":968,"context_line":"                     {\u0027iso\u0027: iso})"},{"line_number":969,"context_line":"            if not persistent:"},{"line_number":970,"context_line":"                ilo_object.set_one_time_boot(\u0027UEFIHTTP\u0027)"}],"source_content_type":"text/x-python","patch_set":15,"id":"9f560f44_32e30f09","line":967,"range":{"start_line":967,"start_character":30,"end_line":967,"end_character":34},"updated":"2020-09-15 07:05:43.000000000","message":"Add node id to message.","commit_id":"0a094a37cbd990039b1f583f5bae76475efbb844"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"08db06de21103c166faf1297c8a5ad544fb0977a","unresolved":false,"context_lines":[{"line_number":964,"context_line":"                ilo_object.add_tls_certificate([verify])"},{"line_number":965,"context_line":""},{"line_number":966,"context_line":"            ilo_object.set_http_boot_url(iso)"},{"line_number":967,"context_line":"            LOG.info(\"Set the node to boot from URL %(iso)s successfully.\","},{"line_number":968,"context_line":"                     {\u0027iso\u0027: iso})"},{"line_number":969,"context_line":"            if not persistent:"},{"line_number":970,"context_line":"                ilo_object.set_one_time_boot(\u0027UEFIHTTP\u0027)"}],"source_content_type":"text/x-python","patch_set":15,"id":"9f560f44_667dc9b1","line":967,"range":{"start_line":967,"start_character":30,"end_line":967,"end_character":34},"in_reply_to":"9f560f44_32e30f09","updated":"2020-09-15 11:49:54.000000000","message":"Done","commit_id":"0a094a37cbd990039b1f583f5bae76475efbb844"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"2457c8e0e7e988303ae3fcdc0f35e9af72260692","unresolved":false,"context_lines":[{"line_number":971,"context_line":"            else:"},{"line_number":972,"context_line":"                ilo_object.update_persistent_boot([\u0027UEFIHTTP\u0027])"},{"line_number":973,"context_line":""},{"line_number":974,"context_line":"        except ilo_error.IloCommandNotSupportedInBiosError as ilo_exception:"},{"line_number":975,"context_line":"            raise exception.IloOperationNotSupported(operation\u003doperation,"},{"line_number":976,"context_line":"                                                     error\u003dilo_exception)"},{"line_number":977,"context_line":"        except ilo_error.IloError as ilo_exception:"},{"line_number":978,"context_line":"            raise exception.IloOperationError(operation\u003doperation,"},{"line_number":979,"context_line":"                                              error\u003dilo_exception)"},{"line_number":980,"context_line":"    else:"},{"line_number":981,"context_line":"        msg \u003d (_(\u0027Error setting up node %(node)s to boot from \u0027"},{"line_number":982,"context_line":"                 \u0027URL %(iso)s. A secured URL is expected that is exposed \u0027"}],"source_content_type":"text/x-python","patch_set":15,"id":"9f560f44_f2b23706","line":979,"range":{"start_line":974,"start_character":7,"end_line":979,"end_character":66},"updated":"2020-09-15 07:05:43.000000000","message":"IloCommandNotSupportedInBiosError and IloError can be clubbed together.","commit_id":"0a094a37cbd990039b1f583f5bae76475efbb844"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"08db06de21103c166faf1297c8a5ad544fb0977a","unresolved":false,"context_lines":[{"line_number":971,"context_line":"            else:"},{"line_number":972,"context_line":"                ilo_object.update_persistent_boot([\u0027UEFIHTTP\u0027])"},{"line_number":973,"context_line":""},{"line_number":974,"context_line":"        except ilo_error.IloCommandNotSupportedInBiosError as ilo_exception:"},{"line_number":975,"context_line":"            raise exception.IloOperationNotSupported(operation\u003doperation,"},{"line_number":976,"context_line":"                                                     error\u003dilo_exception)"},{"line_number":977,"context_line":"        except ilo_error.IloError as ilo_exception:"},{"line_number":978,"context_line":"            raise exception.IloOperationError(operation\u003doperation,"},{"line_number":979,"context_line":"                                              error\u003dilo_exception)"},{"line_number":980,"context_line":"    else:"},{"line_number":981,"context_line":"        msg \u003d (_(\u0027Error setting up node %(node)s to boot from \u0027"},{"line_number":982,"context_line":"                 \u0027URL %(iso)s. A secured URL is expected that is exposed \u0027"}],"source_content_type":"text/x-python","patch_set":15,"id":"9f560f44_a648818a","line":979,"range":{"start_line":974,"start_character":7,"end_line":979,"end_character":66},"in_reply_to":"9f560f44_f2b23706","updated":"2020-09-15 11:49:54.000000000","message":"They raise different errors.","commit_id":"0a094a37cbd990039b1f583f5bae76475efbb844"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"2457c8e0e7e988303ae3fcdc0f35e9af72260692","unresolved":false,"context_lines":[{"line_number":1018,"context_line":"        except ilo_error.IloError as ilo_exception:"},{"line_number":1019,"context_line":"            raise exception.IloOperationError(operation\u003doperation,"},{"line_number":1020,"context_line":"                                              error\u003dilo_exception)"},{"line_number":1021,"context_line":"        LOG.info(\"Cleared certificates from the node %(node)s successfully.\","},{"line_number":1022,"context_line":"                 {\u0027node\u0027: node.uuid})"}],"source_content_type":"text/x-python","patch_set":15,"id":"9f560f44_12c9ab78","line":1021,"range":{"start_line":1021,"start_character":26,"end_line":1021,"end_character":38},"updated":"2020-09-15 07:05:43.000000000","message":"s/ certificates / TLS certificates /","commit_id":"0a094a37cbd990039b1f583f5bae76475efbb844"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"cea8ffc6975af87a1967a5ce834597beeb5ed74e","unresolved":false,"context_lines":[{"line_number":947,"context_line":""},{"line_number":948,"context_line":"    if scheme !\u003d \u0027https\u0027:"},{"line_number":949,"context_line":"        msg \u003d (_(\u0027Error setting up node %(node)s to boot from \u0027"},{"line_number":950,"context_line":"                 \u0027URL %(iso)s. A secured URL is expected that is exposed \u0027"},{"line_number":951,"context_line":"                 \u0027over HTTPS.\u0027) %"},{"line_number":952,"context_line":"               {\u0027node\u0027: node.uuid, \u0027iso\u0027: iso})"},{"line_number":953,"context_line":"        raise exception.IloOperationNotSupported(operation\u003doperation,"}],"source_content_type":"text/x-python","patch_set":18,"id":"9f560f44_255f3476","line":950,"range":{"start_line":950,"start_character":33,"end_line":950,"end_character":40},"updated":"2020-09-16 11:08:01.000000000","message":"nit: s/ secured / secure /","commit_id":"cd9a092f2404b465f17d12a00e078a755dd9ce23"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"dab4906182b5900abf87275d9fc7331befc50a9d","unresolved":false,"context_lines":[{"line_number":947,"context_line":""},{"line_number":948,"context_line":"    if scheme !\u003d \u0027https\u0027:"},{"line_number":949,"context_line":"        msg \u003d (_(\u0027Error setting up node %(node)s to boot from \u0027"},{"line_number":950,"context_line":"                 \u0027URL %(iso)s. A secured URL is expected that is exposed \u0027"},{"line_number":951,"context_line":"                 \u0027over HTTPS.\u0027) %"},{"line_number":952,"context_line":"               {\u0027node\u0027: node.uuid, \u0027iso\u0027: iso})"},{"line_number":953,"context_line":"        raise exception.IloOperationNotSupported(operation\u003doperation,"}],"source_content_type":"text/x-python","patch_set":18,"id":"9f560f44_4ba19746","line":950,"range":{"start_line":950,"start_character":33,"end_line":950,"end_character":40},"in_reply_to":"9f560f44_255f3476","updated":"2020-09-16 12:22:47.000000000","message":"Done","commit_id":"cd9a092f2404b465f17d12a00e078a755dd9ce23"}],"ironic/drivers/modules/image_utils.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"09ebd7a5ce0cef45dcb918593f0cb059bce39b06","unresolved":false,"context_lines":[{"line_number":49,"context_line":"            \"container\": CONF.ilo.swift_ilo_container,"},{"line_number":50,"context_line":"            \"timeout\": CONF.ilo.swift_object_expiry_timeout,"},{"line_number":51,"context_line":"            \"image_subdir\": \"ilo\""},{"line_number":52,"context_line":"                                                                    },"},{"line_number":53,"context_line":"    }"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    def __init__(self, driver):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_a0ca529d","line":52,"updated":"2020-08-10 10:51:16.000000000","message":"pep8: E126 continuation line over-indented for hanging indent","commit_id":"626c099d98d12aa9f87b578003d4b11681abe551"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"d0a8f2ad998cb53c35be7045054cac11adc56dc6","unresolved":false,"context_lines":[{"line_number":49,"context_line":"            \"container\": CONF.ilo.swift_ilo_container,"},{"line_number":50,"context_line":"            \"timeout\": CONF.ilo.swift_object_expiry_timeout,"},{"line_number":51,"context_line":"            \"image_subdir\": \"ilo\""},{"line_number":52,"context_line":"                                                                    },"},{"line_number":53,"context_line":"    }"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    def __init__(self, driver):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_894cd79e","line":52,"updated":"2020-08-24 09:56:54.000000000","message":"pep8: E126 continuation line over-indented for hanging indent","commit_id":"3641eaece282539dabd87f74a2b20ff351d41762"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"81014694ac64f98beea4f84cf59c7b74afa1b746","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            \"container\": CONF.ilo.swift_ilo_container,"},{"line_number":51,"context_line":"            \"timeout\": CONF.ilo.swift_object_expiry_timeout,"},{"line_number":52,"context_line":"            \"image_subdir\": \"ilo\","},{"line_number":53,"context_line":"            \"file_permission\": CONF.redfish.file_permission"},{"line_number":54,"context_line":"        },"},{"line_number":55,"context_line":"    }"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_6c377f4f","line":53,"range":{"start_line":53,"start_character":31,"end_line":53,"end_character":59},"updated":"2020-08-28 10:27:17.000000000","message":"May be you can add equivalent ilo config","commit_id":"cfd8684b17f0c4930fcfacde973f5bcf8c78aecc"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"ab99a1dcf1b437b1593b5fe64c96bc4d8ffb7e43","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            \"container\": CONF.ilo.swift_ilo_container,"},{"line_number":51,"context_line":"            \"timeout\": CONF.ilo.swift_object_expiry_timeout,"},{"line_number":52,"context_line":"            \"image_subdir\": \"ilo\","},{"line_number":53,"context_line":"            \"file_permission\": CONF.redfish.file_permission"},{"line_number":54,"context_line":"        },"},{"line_number":55,"context_line":"    }"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_c577793b","line":53,"range":{"start_line":53,"start_character":31,"end_line":53,"end_character":59},"in_reply_to":"9f560f44_6c377f4f","updated":"2020-08-28 16:09:52.000000000","message":"Firstly i feel it\u0027s not worth to be a configuration parameter let alone iLO but even for redfish. Would it be good to hardcode it in iLO case then. Just a thought. I am OK to change it though.","commit_id":"cfd8684b17f0c4930fcfacde973f5bcf8c78aecc"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"81014694ac64f98beea4f84cf59c7b74afa1b746","unresolved":false,"context_lines":[{"line_number":180,"context_line":"            image_url \u003d os.path.join("},{"line_number":181,"context_line":"                CONF.deploy.http_url, self._image_subdir, object_name)"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"#         if self._driver !\u003d \"ilo5\":"},{"line_number":184,"context_line":"#             image_url \u003d self._append_filename_param("},{"line_number":185,"context_line":"#                 image_url, os.path.basename(image_file))"},{"line_number":186,"context_line":"        image_url \u003d self._append_filename_param("},{"line_number":187,"context_line":"            image_url, os.path.basename(image_file))"},{"line_number":188,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_4c28bbed","line":185,"range":{"start_line":183,"start_character":0,"end_line":185,"end_character":58},"updated":"2020-08-28 10:27:17.000000000","message":"Remove","commit_id":"cfd8684b17f0c4930fcfacde973f5bcf8c78aecc"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"ab99a1dcf1b437b1593b5fe64c96bc4d8ffb7e43","unresolved":false,"context_lines":[{"line_number":180,"context_line":"            image_url \u003d os.path.join("},{"line_number":181,"context_line":"                CONF.deploy.http_url, self._image_subdir, object_name)"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"#         if self._driver !\u003d \"ilo5\":"},{"line_number":184,"context_line":"#             image_url \u003d self._append_filename_param("},{"line_number":185,"context_line":"#                 image_url, os.path.basename(image_file))"},{"line_number":186,"context_line":"        image_url \u003d self._append_filename_param("},{"line_number":187,"context_line":"            image_url, os.path.basename(image_file))"},{"line_number":188,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_85b461d3","line":185,"range":{"start_line":183,"start_character":0,"end_line":185,"end_character":58},"in_reply_to":"9f560f44_4c28bbed","updated":"2020-08-28 16:09:52.000000000","message":"Done","commit_id":"cfd8684b17f0c4930fcfacde973f5bcf8c78aecc"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"49de25fc05ef50780c9a4d134dd9cffeb5058dbc","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            \"container\": CONF.ilo.swift_ilo_container,"},{"line_number":51,"context_line":"            \"timeout\": CONF.ilo.swift_object_expiry_timeout,"},{"line_number":52,"context_line":"            \"image_subdir\": \"ilo\","},{"line_number":53,"context_line":"            \"file_permission\": CONF.redfish.file_permission"},{"line_number":54,"context_line":"        },"},{"line_number":55,"context_line":"    }"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"9f560f44_94a50706","line":53,"range":{"start_line":53,"start_character":31,"end_line":53,"end_character":59},"updated":"2020-09-09 16:16:41.000000000","message":"This looks odd. Better to have an iLO config param.","commit_id":"30dae4acb903b051463e045a789b1acc1ee38de4"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"73d63e44e1e61a71f8e4ff1981309ff02694839a","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            \"container\": CONF.ilo.swift_ilo_container,"},{"line_number":51,"context_line":"            \"timeout\": CONF.ilo.swift_object_expiry_timeout,"},{"line_number":52,"context_line":"            \"image_subdir\": \"ilo\","},{"line_number":53,"context_line":"            \"file_permission\": CONF.redfish.file_permission"},{"line_number":54,"context_line":"        },"},{"line_number":55,"context_line":"    }"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"9f560f44_0e639643","line":53,"range":{"start_line":53,"start_character":31,"end_line":53,"end_character":59},"in_reply_to":"9f560f44_94a50706","updated":"2020-09-10 09:10:10.000000000","message":"Done","commit_id":"30dae4acb903b051463e045a789b1acc1ee38de4"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"2457c8e0e7e988303ae3fcdc0f35e9af72260692","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            \"container\": CONF.ilo.swift_ilo_container,"},{"line_number":51,"context_line":"            \"timeout\": CONF.ilo.swift_object_expiry_timeout,"},{"line_number":52,"context_line":"            \"image_subdir\": \"ilo\","},{"line_number":53,"context_line":"            \"file_permission\": CONF.ilo.file_permission"},{"line_number":54,"context_line":"        },"},{"line_number":55,"context_line":"    }"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"9f560f44_92a2dbac","line":53,"range":{"start_line":53,"start_character":31,"end_line":53,"end_character":55},"updated":"2020-09-15 07:05:43.000000000","message":"This needs to applied to other \u0027ilo\u0027 drivers as well.","commit_id":"0a094a37cbd990039b1f583f5bae76475efbb844"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"08db06de21103c166faf1297c8a5ad544fb0977a","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            \"container\": CONF.ilo.swift_ilo_container,"},{"line_number":51,"context_line":"            \"timeout\": CONF.ilo.swift_object_expiry_timeout,"},{"line_number":52,"context_line":"            \"image_subdir\": \"ilo\","},{"line_number":53,"context_line":"            \"file_permission\": CONF.ilo.file_permission"},{"line_number":54,"context_line":"        },"},{"line_number":55,"context_line":"    }"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"9f560f44_e63719fe","line":53,"range":{"start_line":53,"start_character":31,"end_line":53,"end_character":55},"in_reply_to":"9f560f44_92a2dbac","updated":"2020-09-15 11:49:54.000000000","message":"Yes, when they start to consume this piece of code they will use it.","commit_id":"0a094a37cbd990039b1f583f5bae76475efbb844"}],"ironic/tests/unit/drivers/modules/ilo/test_boot.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"dd0953711898da28758b6b640eacb26958822591","unresolved":false,"context_lines":[{"line_number":1670,"context_line":"                                   \"[\u0027deploy_kernel\u0027, \u0027bootloader\u0027]\","},{"line_number":1671,"context_line":"                                   task.driver.boot._validate_hrefs, data)"},{"line_number":1672,"context_line":"            is_glance_mock.assert_has_calls(glance_calls)"},{"line_number":1673,"context_line":"#         urlparse_mock.assert_has_calls(glance_calls)"},{"line_number":1674,"context_line":""},{"line_number":1675,"context_line":"    @mock.patch.object(urlparse, \u0027urlparse\u0027, spec_set\u003dTrue,"},{"line_number":1676,"context_line":"                       autospec\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":11,"id":"9f560f44_4f9abf6e","line":1673,"range":{"start_line":1673,"start_character":0,"end_line":1673,"end_character":54},"updated":"2020-09-09 13:54:13.000000000","message":"???","commit_id":"30dae4acb903b051463e045a789b1acc1ee38de4"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"73d63e44e1e61a71f8e4ff1981309ff02694839a","unresolved":false,"context_lines":[{"line_number":1670,"context_line":"                                   \"[\u0027deploy_kernel\u0027, \u0027bootloader\u0027]\","},{"line_number":1671,"context_line":"                                   task.driver.boot._validate_hrefs, data)"},{"line_number":1672,"context_line":"            is_glance_mock.assert_has_calls(glance_calls)"},{"line_number":1673,"context_line":"#         urlparse_mock.assert_has_calls(glance_calls)"},{"line_number":1674,"context_line":""},{"line_number":1675,"context_line":"    @mock.patch.object(urlparse, \u0027urlparse\u0027, spec_set\u003dTrue,"},{"line_number":1676,"context_line":"                       autospec\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":11,"id":"9f560f44_aef54a53","line":1673,"range":{"start_line":1673,"start_character":0,"end_line":1673,"end_character":54},"in_reply_to":"9f560f44_4f9abf6e","updated":"2020-09-10 09:10:10.000000000","message":"Done","commit_id":"30dae4acb903b051463e045a789b1acc1ee38de4"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"cea8ffc6975af87a1967a5ce834597beeb5ed74e","unresolved":false,"context_lines":[{"line_number":1942,"context_line":"        with task_manager.acquire(self.context, self.node.uuid,"},{"line_number":1943,"context_line":"                                  shared\u003dFalse) as task:"},{"line_number":1944,"context_line":""},{"line_number":1945,"context_line":"            task.node.driver_info[\u0027deploy_kernel\u0027] \u003d \u0027deploy-kernel\u0027"},{"line_number":1946,"context_line":"            task.node.driver_info[\u0027deploy_ramdisk\u0027] \u003d \u0027deploy-ramdisk\u0027"},{"line_number":1947,"context_line":"            task.node.driver_info[\u0027bootloader\u0027] \u003d \u0027bootloader\u0027"},{"line_number":1948,"context_line":"            storage_mock.return_value \u003d True"}],"source_content_type":"text/x-python","patch_set":18,"id":"9f560f44_8807351e","line":1945,"range":{"start_line":1945,"start_character":35,"end_line":1945,"end_character":48},"updated":"2020-09-16 11:08:01.000000000","message":"s/ deploy_kernel / ilo_deploy_kernel /","commit_id":"cd9a092f2404b465f17d12a00e078a755dd9ce23"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"dab4906182b5900abf87275d9fc7331befc50a9d","unresolved":false,"context_lines":[{"line_number":1942,"context_line":"        with task_manager.acquire(self.context, self.node.uuid,"},{"line_number":1943,"context_line":"                                  shared\u003dFalse) as task:"},{"line_number":1944,"context_line":""},{"line_number":1945,"context_line":"            task.node.driver_info[\u0027deploy_kernel\u0027] \u003d \u0027deploy-kernel\u0027"},{"line_number":1946,"context_line":"            task.node.driver_info[\u0027deploy_ramdisk\u0027] \u003d \u0027deploy-ramdisk\u0027"},{"line_number":1947,"context_line":"            task.node.driver_info[\u0027bootloader\u0027] \u003d \u0027bootloader\u0027"},{"line_number":1948,"context_line":"            storage_mock.return_value \u003d True"}],"source_content_type":"text/x-python","patch_set":18,"id":"9f560f44_6e1f495b","line":1945,"range":{"start_line":1945,"start_character":35,"end_line":1945,"end_character":48},"in_reply_to":"9f560f44_8807351e","updated":"2020-09-16 12:22:47.000000000","message":"Done","commit_id":"cd9a092f2404b465f17d12a00e078a755dd9ce23"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"cea8ffc6975af87a1967a5ce834597beeb5ed74e","unresolved":false,"context_lines":[{"line_number":1943,"context_line":"                                  shared\u003dFalse) as task:"},{"line_number":1944,"context_line":""},{"line_number":1945,"context_line":"            task.node.driver_info[\u0027deploy_kernel\u0027] \u003d \u0027deploy-kernel\u0027"},{"line_number":1946,"context_line":"            task.node.driver_info[\u0027deploy_ramdisk\u0027] \u003d \u0027deploy-ramdisk\u0027"},{"line_number":1947,"context_line":"            task.node.driver_info[\u0027bootloader\u0027] \u003d \u0027bootloader\u0027"},{"line_number":1948,"context_line":"            storage_mock.return_value \u003d True"},{"line_number":1949,"context_line":"            task.driver.boot.validate(task)"}],"source_content_type":"text/x-python","patch_set":18,"id":"9f560f44_c8012d09","line":1946,"range":{"start_line":1946,"start_character":35,"end_line":1946,"end_character":49},"updated":"2020-09-16 11:08:01.000000000","message":"ditto","commit_id":"cd9a092f2404b465f17d12a00e078a755dd9ce23"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"dab4906182b5900abf87275d9fc7331befc50a9d","unresolved":false,"context_lines":[{"line_number":1943,"context_line":"                                  shared\u003dFalse) as task:"},{"line_number":1944,"context_line":""},{"line_number":1945,"context_line":"            task.node.driver_info[\u0027deploy_kernel\u0027] \u003d \u0027deploy-kernel\u0027"},{"line_number":1946,"context_line":"            task.node.driver_info[\u0027deploy_ramdisk\u0027] \u003d \u0027deploy-ramdisk\u0027"},{"line_number":1947,"context_line":"            task.node.driver_info[\u0027bootloader\u0027] \u003d \u0027bootloader\u0027"},{"line_number":1948,"context_line":"            storage_mock.return_value \u003d True"},{"line_number":1949,"context_line":"            task.driver.boot.validate(task)"}],"source_content_type":"text/x-python","patch_set":18,"id":"9f560f44_4e2405b0","line":1946,"range":{"start_line":1946,"start_character":35,"end_line":1946,"end_character":49},"in_reply_to":"9f560f44_c8012d09","updated":"2020-09-16 12:22:47.000000000","message":"Done","commit_id":"cd9a092f2404b465f17d12a00e078a755dd9ce23"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"cea8ffc6975af87a1967a5ce834597beeb5ed74e","unresolved":false,"context_lines":[{"line_number":1944,"context_line":""},{"line_number":1945,"context_line":"            task.node.driver_info[\u0027deploy_kernel\u0027] \u003d \u0027deploy-kernel\u0027"},{"line_number":1946,"context_line":"            task.node.driver_info[\u0027deploy_ramdisk\u0027] \u003d \u0027deploy-ramdisk\u0027"},{"line_number":1947,"context_line":"            task.node.driver_info[\u0027bootloader\u0027] \u003d \u0027bootloader\u0027"},{"line_number":1948,"context_line":"            storage_mock.return_value \u003d True"},{"line_number":1949,"context_line":"            task.driver.boot.validate(task)"},{"line_number":1950,"context_line":"            mock_val_instance_image_info.assert_called_once_with("}],"source_content_type":"text/x-python","patch_set":18,"id":"9f560f44_0b015f05","line":1947,"range":{"start_line":1947,"start_character":35,"end_line":1947,"end_character":45},"updated":"2020-09-16 11:08:01.000000000","message":"ditto","commit_id":"cd9a092f2404b465f17d12a00e078a755dd9ce23"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"dab4906182b5900abf87275d9fc7331befc50a9d","unresolved":false,"context_lines":[{"line_number":1944,"context_line":""},{"line_number":1945,"context_line":"            task.node.driver_info[\u0027deploy_kernel\u0027] \u003d \u0027deploy-kernel\u0027"},{"line_number":1946,"context_line":"            task.node.driver_info[\u0027deploy_ramdisk\u0027] \u003d \u0027deploy-ramdisk\u0027"},{"line_number":1947,"context_line":"            task.node.driver_info[\u0027bootloader\u0027] \u003d \u0027bootloader\u0027"},{"line_number":1948,"context_line":"            storage_mock.return_value \u003d True"},{"line_number":1949,"context_line":"            task.driver.boot.validate(task)"},{"line_number":1950,"context_line":"            mock_val_instance_image_info.assert_called_once_with("}],"source_content_type":"text/x-python","patch_set":18,"id":"9f560f44_8e357dde","line":1947,"range":{"start_line":1947,"start_character":35,"end_line":1947,"end_character":45},"in_reply_to":"9f560f44_0b015f05","updated":"2020-09-16 12:22:47.000000000","message":"Done","commit_id":"cd9a092f2404b465f17d12a00e078a755dd9ce23"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"cea8ffc6975af87a1967a5ce834597beeb5ed74e","unresolved":false,"context_lines":[{"line_number":2109,"context_line":"        iso \u003d \u0027provisioning-iso\u0027"},{"line_number":2110,"context_line":""},{"line_number":2111,"context_line":"        d_info \u003d {"},{"line_number":2112,"context_line":"            mode + \u0027_kernel\u0027: mode + \u0027-kernel\u0027,"},{"line_number":2113,"context_line":"            mode + \u0027_ramdisk\u0027: mode + \u0027-ramdisk\u0027,"},{"line_number":2114,"context_line":"            \u0027bootloader\u0027: \u0027bootloader\u0027"},{"line_number":2115,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":18,"id":"9f560f44_cb8be765","line":2112,"range":{"start_line":2112,"start_character":12,"end_line":2112,"end_character":16},"updated":"2020-09-16 11:08:01.000000000","message":"Also need to prepend with \u0027ilo_\u0027 for all driver_info params","commit_id":"cd9a092f2404b465f17d12a00e078a755dd9ce23"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"dab4906182b5900abf87275d9fc7331befc50a9d","unresolved":false,"context_lines":[{"line_number":2109,"context_line":"        iso \u003d \u0027provisioning-iso\u0027"},{"line_number":2110,"context_line":""},{"line_number":2111,"context_line":"        d_info \u003d {"},{"line_number":2112,"context_line":"            mode + \u0027_kernel\u0027: mode + \u0027-kernel\u0027,"},{"line_number":2113,"context_line":"            mode + \u0027_ramdisk\u0027: mode + \u0027-ramdisk\u0027,"},{"line_number":2114,"context_line":"            \u0027bootloader\u0027: \u0027bootloader\u0027"},{"line_number":2115,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":18,"id":"9f560f44_6e6d89cb","line":2112,"range":{"start_line":2112,"start_character":12,"end_line":2112,"end_character":16},"in_reply_to":"9f560f44_cb8be765","updated":"2020-09-16 12:22:47.000000000","message":"Done","commit_id":"cd9a092f2404b465f17d12a00e078a755dd9ce23"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"cea8ffc6975af87a1967a5ce834597beeb5ed74e","unresolved":false,"context_lines":[{"line_number":2136,"context_line":"            setup_uefi_https_mock.assert_called_once_with(task,"},{"line_number":2137,"context_line":"                                                          \u0027recreated-iso\u0027)"},{"line_number":2138,"context_line":""},{"line_number":2139,"context_line":"    def test_prepare_ramdisk_rescue_glance_image(self):"},{"line_number":2140,"context_line":"        self.node.provision_state \u003d states.RESCUING"},{"line_number":2141,"context_line":"        self.node.save()"},{"line_number":2142,"context_line":"        self._test_prepare_ramdisk("},{"line_number":2143,"context_line":"            ilo_boot_iso\u003d\u0027swift:abcdef\u0027,"},{"line_number":2144,"context_line":"            image_source\u003d\u00276b2f0c0c-79e8-4db6-842e-43c9764204af\u0027,"},{"line_number":2145,"context_line":"            mode\u003d\u0027rescue\u0027)"},{"line_number":2146,"context_line":"        self.node.refresh()"},{"line_number":2147,"context_line":"        self.assertNotIn(\u0027ilo_boot_iso\u0027, self.node.instance_info)"},{"line_number":2148,"context_line":""},{"line_number":2149,"context_line":"    def test_prepare_ramdisk_rescue_not_a_glance_image(self):"},{"line_number":2150,"context_line":"        self.node.provision_state \u003d states.RESCUING"},{"line_number":2151,"context_line":"        self.node.save()"},{"line_number":2152,"context_line":"        self._test_prepare_ramdisk("},{"line_number":2153,"context_line":"            ilo_boot_iso\u003d\u0027http://mybootiso\u0027,"},{"line_number":2154,"context_line":"            image_source\u003d\u0027http://myimage\u0027,"},{"line_number":2155,"context_line":"            mode\u003d\u0027rescue\u0027)"},{"line_number":2156,"context_line":"        self.node.refresh()"},{"line_number":2157,"context_line":"        self.assertEqual(\u0027http://mybootiso\u0027,"},{"line_number":2158,"context_line":"                         self.node.instance_info[\u0027ilo_boot_iso\u0027])"},{"line_number":2159,"context_line":""},{"line_number":2160,"context_line":"    def test_prepare_ramdisk_glance_image(self):"},{"line_number":2161,"context_line":"        self.node.provision_state \u003d states.DEPLOYING"},{"line_number":2162,"context_line":"        self.node.save()"},{"line_number":2163,"context_line":"        self._test_prepare_ramdisk("},{"line_number":2164,"context_line":"            ilo_boot_iso\u003d\u0027swift:abcdef\u0027,"},{"line_number":2165,"context_line":"            image_source\u003d\u00276b2f0c0c-79e8-4db6-842e-43c9764204af\u0027)"},{"line_number":2166,"context_line":"        self.node.refresh()"},{"line_number":2167,"context_line":"        self.assertNotIn(\u0027ilo_boot_iso\u0027, self.node.instance_info)"},{"line_number":2168,"context_line":""},{"line_number":2169,"context_line":"    def test_prepare_ramdisk_not_a_glance_image(self):"},{"line_number":2170,"context_line":"        self.node.provision_state \u003d states.DEPLOYING"},{"line_number":2171,"context_line":"        self.node.save()"},{"line_number":2172,"context_line":"        self._test_prepare_ramdisk("},{"line_number":2173,"context_line":"            ilo_boot_iso\u003d\u0027http://mybootiso\u0027,"},{"line_number":2174,"context_line":"            image_source\u003d\u0027http://myimage\u0027)"},{"line_number":2175,"context_line":"        self.node.refresh()"},{"line_number":2176,"context_line":"        self.assertEqual(\u0027http://mybootiso\u0027,"},{"line_number":2177,"context_line":"                         self.node.instance_info[\u0027ilo_boot_iso\u0027])"},{"line_number":2178,"context_line":""},{"line_number":2179,"context_line":"    def test_prepare_ramdisk_glance_image_cleaning(self):"},{"line_number":2180,"context_line":"        self.node.provision_state \u003d states.CLEANING"},{"line_number":2181,"context_line":"        self.node.save()"},{"line_number":2182,"context_line":"        self._test_prepare_ramdisk("},{"line_number":2183,"context_line":"            ilo_boot_iso\u003d\u0027swift:abcdef\u0027,"},{"line_number":2184,"context_line":"            image_source\u003d\u00276b2f0c0c-79e8-4db6-842e-43c9764204af\u0027)"},{"line_number":2185,"context_line":"        self.node.refresh()"},{"line_number":2186,"context_line":"        self.assertNotIn(\u0027ilo_boot_iso\u0027, self.node.instance_info)"},{"line_number":2187,"context_line":""},{"line_number":2188,"context_line":"    def test_prepare_ramdisk_not_a_glance_image_cleaning(self):"},{"line_number":2189,"context_line":"        self.node.provision_state \u003d states.CLEANING"},{"line_number":2190,"context_line":"        self.node.save()"},{"line_number":2191,"context_line":"        self._test_prepare_ramdisk("},{"line_number":2192,"context_line":"            ilo_boot_iso\u003d\u0027http://mybootiso\u0027,"},{"line_number":2193,"context_line":"            image_source\u003d\u0027http://myimage\u0027)"},{"line_number":2194,"context_line":"        self.node.refresh()"},{"line_number":2195,"context_line":"        self.assertEqual(\u0027http://mybootiso\u0027,"},{"line_number":2196,"context_line":"                         self.node.instance_info[\u0027ilo_boot_iso\u0027])"},{"line_number":2197,"context_line":""},{"line_number":2198,"context_line":"    @mock.patch.object(image_utils, \u0027cleanup_iso_image\u0027, spec_set\u003dTrue,"},{"line_number":2199,"context_line":"                       autospec\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":18,"id":"9f560f44_4b435714","line":2196,"range":{"start_line":2139,"start_character":0,"end_line":2196,"end_character":65},"updated":"2020-09-16 11:08:01.000000000","message":"May be a wrapper test case can be written instead of duplicating this code for various deploy states.","commit_id":"cd9a092f2404b465f17d12a00e078a755dd9ce23"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"dab4906182b5900abf87275d9fc7331befc50a9d","unresolved":false,"context_lines":[{"line_number":2136,"context_line":"            setup_uefi_https_mock.assert_called_once_with(task,"},{"line_number":2137,"context_line":"                                                          \u0027recreated-iso\u0027)"},{"line_number":2138,"context_line":""},{"line_number":2139,"context_line":"    def test_prepare_ramdisk_rescue_glance_image(self):"},{"line_number":2140,"context_line":"        self.node.provision_state \u003d states.RESCUING"},{"line_number":2141,"context_line":"        self.node.save()"},{"line_number":2142,"context_line":"        self._test_prepare_ramdisk("},{"line_number":2143,"context_line":"            ilo_boot_iso\u003d\u0027swift:abcdef\u0027,"},{"line_number":2144,"context_line":"            image_source\u003d\u00276b2f0c0c-79e8-4db6-842e-43c9764204af\u0027,"},{"line_number":2145,"context_line":"            mode\u003d\u0027rescue\u0027)"},{"line_number":2146,"context_line":"        self.node.refresh()"},{"line_number":2147,"context_line":"        self.assertNotIn(\u0027ilo_boot_iso\u0027, self.node.instance_info)"},{"line_number":2148,"context_line":""},{"line_number":2149,"context_line":"    def test_prepare_ramdisk_rescue_not_a_glance_image(self):"},{"line_number":2150,"context_line":"        self.node.provision_state \u003d states.RESCUING"},{"line_number":2151,"context_line":"        self.node.save()"},{"line_number":2152,"context_line":"        self._test_prepare_ramdisk("},{"line_number":2153,"context_line":"            ilo_boot_iso\u003d\u0027http://mybootiso\u0027,"},{"line_number":2154,"context_line":"            image_source\u003d\u0027http://myimage\u0027,"},{"line_number":2155,"context_line":"            mode\u003d\u0027rescue\u0027)"},{"line_number":2156,"context_line":"        self.node.refresh()"},{"line_number":2157,"context_line":"        self.assertEqual(\u0027http://mybootiso\u0027,"},{"line_number":2158,"context_line":"                         self.node.instance_info[\u0027ilo_boot_iso\u0027])"},{"line_number":2159,"context_line":""},{"line_number":2160,"context_line":"    def test_prepare_ramdisk_glance_image(self):"},{"line_number":2161,"context_line":"        self.node.provision_state \u003d states.DEPLOYING"},{"line_number":2162,"context_line":"        self.node.save()"},{"line_number":2163,"context_line":"        self._test_prepare_ramdisk("},{"line_number":2164,"context_line":"            ilo_boot_iso\u003d\u0027swift:abcdef\u0027,"},{"line_number":2165,"context_line":"            image_source\u003d\u00276b2f0c0c-79e8-4db6-842e-43c9764204af\u0027)"},{"line_number":2166,"context_line":"        self.node.refresh()"},{"line_number":2167,"context_line":"        self.assertNotIn(\u0027ilo_boot_iso\u0027, self.node.instance_info)"},{"line_number":2168,"context_line":""},{"line_number":2169,"context_line":"    def test_prepare_ramdisk_not_a_glance_image(self):"},{"line_number":2170,"context_line":"        self.node.provision_state \u003d states.DEPLOYING"},{"line_number":2171,"context_line":"        self.node.save()"},{"line_number":2172,"context_line":"        self._test_prepare_ramdisk("},{"line_number":2173,"context_line":"            ilo_boot_iso\u003d\u0027http://mybootiso\u0027,"},{"line_number":2174,"context_line":"            image_source\u003d\u0027http://myimage\u0027)"},{"line_number":2175,"context_line":"        self.node.refresh()"},{"line_number":2176,"context_line":"        self.assertEqual(\u0027http://mybootiso\u0027,"},{"line_number":2177,"context_line":"                         self.node.instance_info[\u0027ilo_boot_iso\u0027])"},{"line_number":2178,"context_line":""},{"line_number":2179,"context_line":"    def test_prepare_ramdisk_glance_image_cleaning(self):"},{"line_number":2180,"context_line":"        self.node.provision_state \u003d states.CLEANING"},{"line_number":2181,"context_line":"        self.node.save()"},{"line_number":2182,"context_line":"        self._test_prepare_ramdisk("},{"line_number":2183,"context_line":"            ilo_boot_iso\u003d\u0027swift:abcdef\u0027,"},{"line_number":2184,"context_line":"            image_source\u003d\u00276b2f0c0c-79e8-4db6-842e-43c9764204af\u0027)"},{"line_number":2185,"context_line":"        self.node.refresh()"},{"line_number":2186,"context_line":"        self.assertNotIn(\u0027ilo_boot_iso\u0027, self.node.instance_info)"},{"line_number":2187,"context_line":""},{"line_number":2188,"context_line":"    def test_prepare_ramdisk_not_a_glance_image_cleaning(self):"},{"line_number":2189,"context_line":"        self.node.provision_state \u003d states.CLEANING"},{"line_number":2190,"context_line":"        self.node.save()"},{"line_number":2191,"context_line":"        self._test_prepare_ramdisk("},{"line_number":2192,"context_line":"            ilo_boot_iso\u003d\u0027http://mybootiso\u0027,"},{"line_number":2193,"context_line":"            image_source\u003d\u0027http://myimage\u0027)"},{"line_number":2194,"context_line":"        self.node.refresh()"},{"line_number":2195,"context_line":"        self.assertEqual(\u0027http://mybootiso\u0027,"},{"line_number":2196,"context_line":"                         self.node.instance_info[\u0027ilo_boot_iso\u0027])"},{"line_number":2197,"context_line":""},{"line_number":2198,"context_line":"    @mock.patch.object(image_utils, \u0027cleanup_iso_image\u0027, spec_set\u003dTrue,"},{"line_number":2199,"context_line":"                       autospec\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":18,"id":"9f560f44_ce4e5537","line":2196,"range":{"start_line":2139,"start_character":0,"end_line":2196,"end_character":65},"in_reply_to":"9f560f44_4b435714","updated":"2020-09-16 12:22:47.000000000","message":"There\u0027s already a wrapper with name \u0027_test_prepare_ramdisk\u0027.","commit_id":"cd9a092f2404b465f17d12a00e078a755dd9ce23"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"cea8ffc6975af87a1967a5ce834597beeb5ed74e","unresolved":false,"context_lines":[{"line_number":2209,"context_line":"            self, set_boot_device_mock,"},{"line_number":2210,"context_line":"            parse_deploy_mock, prepare_iso_mock, setup_uefi_https_mock,"},{"line_number":2211,"context_line":"            cleanup_iso_mock):"},{"line_number":2212,"context_line":"        self.node.driver_internal_info \u003d {\u0027is_whole_disk_image\u0027: True}"},{"line_number":2213,"context_line":"        self.node.save()"},{"line_number":2214,"context_line":"        with task_manager.acquire(self.context, self.node.uuid,"},{"line_number":2215,"context_line":"                                  shared\u003dFalse) as task:"}],"source_content_type":"text/x-python","patch_set":18,"id":"9f560f44_2b0263bb","line":2212,"range":{"start_line":2212,"start_character":8,"end_line":2212,"end_character":70},"updated":"2020-09-16 11:08:01.000000000","message":"This needs to be moved into testcase test_prepare_instance_whole_disk_image()","commit_id":"cd9a092f2404b465f17d12a00e078a755dd9ce23"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"dab4906182b5900abf87275d9fc7331befc50a9d","unresolved":false,"context_lines":[{"line_number":2209,"context_line":"            self, set_boot_device_mock,"},{"line_number":2210,"context_line":"            parse_deploy_mock, prepare_iso_mock, setup_uefi_https_mock,"},{"line_number":2211,"context_line":"            cleanup_iso_mock):"},{"line_number":2212,"context_line":"        self.node.driver_internal_info \u003d {\u0027is_whole_disk_image\u0027: True}"},{"line_number":2213,"context_line":"        self.node.save()"},{"line_number":2214,"context_line":"        with task_manager.acquire(self.context, self.node.uuid,"},{"line_number":2215,"context_line":"                                  shared\u003dFalse) as task:"}],"source_content_type":"text/x-python","patch_set":18,"id":"9f560f44_aef5e1ce","line":2212,"range":{"start_line":2212,"start_character":8,"end_line":2212,"end_character":70},"in_reply_to":"9f560f44_2b0263bb","updated":"2020-09-16 12:22:47.000000000","message":"Done","commit_id":"cd9a092f2404b465f17d12a00e078a755dd9ce23"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"cea8ffc6975af87a1967a5ce834597beeb5ed74e","unresolved":false,"context_lines":[{"line_number":2266,"context_line":"            parse_deploy_mock.assert_called_once_with(mock.ANY, task.node)"},{"line_number":2267,"context_line":"            prepare_iso_mock.assert_called_once_with("},{"line_number":2268,"context_line":"                task, d_info, root_uuid\u003d\u002712312642-09d3-467f-8e09-12385826a123\u0027)"},{"line_number":2269,"context_line":"            setup_uefi_https_mock.assert_called_once_with("},{"line_number":2270,"context_line":"                task, \"recreated-iso\", True)"},{"line_number":2271,"context_line":""},{"line_number":2272,"context_line":"    @mock.patch.object(image_utils, \u0027cleanup_iso_image\u0027, spec_set\u003dTrue,"},{"line_number":2273,"context_line":"                       autospec\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":18,"id":"9f560f44_abf5d3ce","line":2270,"range":{"start_line":2269,"start_character":12,"end_line":2270,"end_character":44},"updated":"2020-09-16 11:08:01.000000000","message":"Also validate that \u0027ilo_boot_iso\u0027 is set properly in node.instance_info","commit_id":"cd9a092f2404b465f17d12a00e078a755dd9ce23"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"dab4906182b5900abf87275d9fc7331befc50a9d","unresolved":false,"context_lines":[{"line_number":2266,"context_line":"            parse_deploy_mock.assert_called_once_with(mock.ANY, task.node)"},{"line_number":2267,"context_line":"            prepare_iso_mock.assert_called_once_with("},{"line_number":2268,"context_line":"                task, d_info, root_uuid\u003d\u002712312642-09d3-467f-8e09-12385826a123\u0027)"},{"line_number":2269,"context_line":"            setup_uefi_https_mock.assert_called_once_with("},{"line_number":2270,"context_line":"                task, \"recreated-iso\", True)"},{"line_number":2271,"context_line":""},{"line_number":2272,"context_line":"    @mock.patch.object(image_utils, \u0027cleanup_iso_image\u0027, spec_set\u003dTrue,"},{"line_number":2273,"context_line":"                       autospec\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":18,"id":"9f560f44_8ee0ddfa","line":2270,"range":{"start_line":2269,"start_character":12,"end_line":2270,"end_character":44},"in_reply_to":"9f560f44_abf5d3ce","updated":"2020-09-16 12:22:47.000000000","message":"Done","commit_id":"cd9a092f2404b465f17d12a00e078a755dd9ce23"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"cea8ffc6975af87a1967a5ce834597beeb5ed74e","unresolved":false,"context_lines":[{"line_number":2303,"context_line":"            parse_deploy_mock.assert_called_once_with(mock.ANY, task.node)"},{"line_number":2304,"context_line":"            prepare_iso_mock.assert_called_once_with("},{"line_number":2305,"context_line":"                task, d_info)"},{"line_number":2306,"context_line":"            setup_uefi_https_mock.assert_called_once_with("},{"line_number":2307,"context_line":"                task, \"recreated-iso\", True)"},{"line_number":2308,"context_line":""},{"line_number":2309,"context_line":"    @mock.patch.object(image_utils, \u0027cleanup_iso_image\u0027, spec_set\u003dTrue,"},{"line_number":2310,"context_line":"                       autospec\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":18,"id":"9f560f44_ebffcba8","line":2307,"range":{"start_line":2306,"start_character":12,"end_line":2307,"end_character":44},"updated":"2020-09-16 11:08:01.000000000","message":"Also validate that \u0027ilo_boot_iso\u0027 is not set in node.instance_info","commit_id":"cd9a092f2404b465f17d12a00e078a755dd9ce23"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"dab4906182b5900abf87275d9fc7331befc50a9d","unresolved":false,"context_lines":[{"line_number":2303,"context_line":"            parse_deploy_mock.assert_called_once_with(mock.ANY, task.node)"},{"line_number":2304,"context_line":"            prepare_iso_mock.assert_called_once_with("},{"line_number":2305,"context_line":"                task, d_info)"},{"line_number":2306,"context_line":"            setup_uefi_https_mock.assert_called_once_with("},{"line_number":2307,"context_line":"                task, \"recreated-iso\", True)"},{"line_number":2308,"context_line":""},{"line_number":2309,"context_line":"    @mock.patch.object(image_utils, \u0027cleanup_iso_image\u0027, spec_set\u003dTrue,"},{"line_number":2310,"context_line":"                       autospec\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":18,"id":"9f560f44_8e8e1d30","line":2307,"range":{"start_line":2306,"start_character":12,"end_line":2307,"end_character":44},"in_reply_to":"9f560f44_ebffcba8","updated":"2020-09-16 12:22:47.000000000","message":"Done","commit_id":"cd9a092f2404b465f17d12a00e078a755dd9ce23"}],"ironic/tests/unit/drivers/modules/ilo/test_common.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"dd0953711898da28758b6b640eacb26958822591","unresolved":false,"context_lines":[{"line_number":1277,"context_line":"                                  shared\u003dFalse) as task:"},{"line_number":1278,"context_line":"            ilo_common.setup_uefi_https(task, iso, persistent\u003dFalse)"},{"line_number":1279,"context_line":""},{"line_number":1280,"context_line":"#         path_mock.assert_called_once_with(\u0027/path/to/certs\u0027)"},{"line_number":1281,"context_line":"        ilo_mock_object.add_tls_certificate.assert_not_called()"},{"line_number":1282,"context_line":"        ilo_mock_object.set_http_boot_url.assert_called_once_with(iso)"},{"line_number":1283,"context_line":"        ilo_mock_object.set_one_time_boot.assert_called_once_with(\u0027UEFIHTTP\u0027)"}],"source_content_type":"text/x-python","patch_set":11,"id":"9f560f44_8fa057a7","line":1280,"updated":"2020-09-09 13:54:13.000000000","message":"Intentional? Please comment out with a note as to why or I guess make it work, or remove it.","commit_id":"30dae4acb903b051463e045a789b1acc1ee38de4"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"73d63e44e1e61a71f8e4ff1981309ff02694839a","unresolved":false,"context_lines":[{"line_number":1277,"context_line":"                                  shared\u003dFalse) as task:"},{"line_number":1278,"context_line":"            ilo_common.setup_uefi_https(task, iso, persistent\u003dFalse)"},{"line_number":1279,"context_line":""},{"line_number":1280,"context_line":"#         path_mock.assert_called_once_with(\u0027/path/to/certs\u0027)"},{"line_number":1281,"context_line":"        ilo_mock_object.add_tls_certificate.assert_not_called()"},{"line_number":1282,"context_line":"        ilo_mock_object.set_http_boot_url.assert_called_once_with(iso)"},{"line_number":1283,"context_line":"        ilo_mock_object.set_one_time_boot.assert_called_once_with(\u0027UEFIHTTP\u0027)"}],"source_content_type":"text/x-python","patch_set":11,"id":"9f560f44_8e77a6d4","line":1280,"in_reply_to":"9f560f44_8fa057a7","updated":"2020-09-10 09:10:10.000000000","message":"Done","commit_id":"30dae4acb903b051463e045a789b1acc1ee38de4"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"dd0953711898da28758b6b640eacb26958822591","unresolved":false,"context_lines":[{"line_number":1315,"context_line":"                                  shared\u003dFalse) as task:"},{"line_number":1316,"context_line":"            ilo_common.setup_uefi_https(task, iso, persistent\u003dFalse)"},{"line_number":1317,"context_line":""},{"line_number":1318,"context_line":"#         path_mock.assert_called_once_with(\u0027/path/to/certs\u0027)"},{"line_number":1319,"context_line":"        ilo_mock_object.add_tls_certificate.assert_called_once_with("},{"line_number":1320,"context_line":"            [\u0027/path/to/certs\u0027])"},{"line_number":1321,"context_line":"        ilo_mock_object.set_http_boot_url.assert_called_once_with(iso)"}],"source_content_type":"text/x-python","patch_set":11,"id":"9f560f44_4fc59f5b","line":1318,"updated":"2020-09-09 13:54:13.000000000","message":"intentional?","commit_id":"30dae4acb903b051463e045a789b1acc1ee38de4"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"73d63e44e1e61a71f8e4ff1981309ff02694839a","unresolved":false,"context_lines":[{"line_number":1315,"context_line":"                                  shared\u003dFalse) as task:"},{"line_number":1316,"context_line":"            ilo_common.setup_uefi_https(task, iso, persistent\u003dFalse)"},{"line_number":1317,"context_line":""},{"line_number":1318,"context_line":"#         path_mock.assert_called_once_with(\u0027/path/to/certs\u0027)"},{"line_number":1319,"context_line":"        ilo_mock_object.add_tls_certificate.assert_called_once_with("},{"line_number":1320,"context_line":"            [\u0027/path/to/certs\u0027])"},{"line_number":1321,"context_line":"        ilo_mock_object.set_http_boot_url.assert_called_once_with(iso)"}],"source_content_type":"text/x-python","patch_set":11,"id":"9f560f44_ee4f428f","line":1318,"in_reply_to":"9f560f44_4fc59f5b","updated":"2020-09-10 09:10:10.000000000","message":"Done","commit_id":"30dae4acb903b051463e045a789b1acc1ee38de4"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"cea8ffc6975af87a1967a5ce834597beeb5ed74e","unresolved":false,"context_lines":[{"line_number":1245,"context_line":""},{"line_number":1246,"context_line":"        with task_manager.acquire(self.context, self.node.uuid,"},{"line_number":1247,"context_line":"                                  shared\u003dFalse) as task:"},{"line_number":1248,"context_line":"            ilo_common.setup_uefi_https(task, iso, persistent\u003dFalse)"},{"line_number":1249,"context_line":""},{"line_number":1250,"context_line":"        ilo_mock_object.set_http_boot_url.assert_called_once_with(iso)"},{"line_number":1251,"context_line":"        ilo_mock_object.set_one_time_boot.assert_called_once_with(\u0027UEFIHTTP\u0027)"}],"source_content_type":"text/x-python","patch_set":18,"id":"9f560f44_eb186b1f","line":1248,"range":{"start_line":1248,"start_character":51,"end_line":1248,"end_character":67},"updated":"2020-09-16 11:08:01.000000000","message":"May be you can make a common function and test for persistent\u003d True/False","commit_id":"cd9a092f2404b465f17d12a00e078a755dd9ce23"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"dab4906182b5900abf87275d9fc7331befc50a9d","unresolved":false,"context_lines":[{"line_number":1245,"context_line":""},{"line_number":1246,"context_line":"        with task_manager.acquire(self.context, self.node.uuid,"},{"line_number":1247,"context_line":"                                  shared\u003dFalse) as task:"},{"line_number":1248,"context_line":"            ilo_common.setup_uefi_https(task, iso, persistent\u003dFalse)"},{"line_number":1249,"context_line":""},{"line_number":1250,"context_line":"        ilo_mock_object.set_http_boot_url.assert_called_once_with(iso)"},{"line_number":1251,"context_line":"        ilo_mock_object.set_one_time_boot.assert_called_once_with(\u0027UEFIHTTP\u0027)"}],"source_content_type":"text/x-python","patch_set":18,"id":"9f560f44_8e1e1d72","line":1248,"range":{"start_line":1248,"start_character":51,"end_line":1248,"end_character":67},"in_reply_to":"9f560f44_eb186b1f","updated":"2020-09-16 12:22:47.000000000","message":"Done","commit_id":"cd9a092f2404b465f17d12a00e078a755dd9ce23"}],"releasenotes/notes/add-ilo-uefi-https-boot-interface-f3b163a8a6243283.yaml":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"dd0953711898da28758b6b640eacb26958822591","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds ``ilo-uefi-https`` boot interface to ``ilo5`` hardware type."},{"line_number":5,"context_line":"    This boot interface provides the ability to deploy the nodes securely by"},{"line_number":6,"context_line":"    allowing image URLs hosted over HTTPS webserver."}],"source_content_type":"text/x-yaml","patch_set":11,"id":"9f560f44_efcbd36e","line":6,"range":{"start_line":5,"start_character":4,"end_line":6,"end_character":52},"updated":"2020-09-09 13:54:13.000000000","message":"I\u0027d highly prefer this conveys that this is UEFI firmware booting the machine from a HTTPS URL.  Virtual media also provides a secure interface, so that is not something that _needs_ to be stressed in my opinion.","commit_id":"30dae4acb903b051463e045a789b1acc1ee38de4"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"73d63e44e1e61a71f8e4ff1981309ff02694839a","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds ``ilo-uefi-https`` boot interface to ``ilo5`` hardware type."},{"line_number":5,"context_line":"    This boot interface provides the ability to deploy the nodes securely by"},{"line_number":6,"context_line":"    allowing image URLs hosted over HTTPS webserver."}],"source_content_type":"text/x-yaml","patch_set":11,"id":"9f560f44_4e43ce6c","line":6,"range":{"start_line":5,"start_character":4,"end_line":6,"end_character":52},"in_reply_to":"9f560f44_efcbd36e","updated":"2020-09-10 09:10:10.000000000","message":"Done","commit_id":"30dae4acb903b051463e045a789b1acc1ee38de4"}]}