)]}'
{"ironic/drivers/modules/agent_client.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"02a2dc76abf35e87054166aedf04b926a4184b0f","unresolved":false,"context_lines":[{"line_number":209,"context_line":"                   \u0027code\u0027: response.status_code})"},{"line_number":210,"context_line":"        if response.status_code \u003e\u003d http_client.BAD_REQUEST:"},{"line_number":211,"context_line":"            faultstring \u003d result.get(\u0027faultstring\u0027)"},{"line_number":212,"context_line":"            if \u0027agent_token\u0027 in faultstring and agent_token:"},{"line_number":213,"context_line":"                # NOTE(TheJulia) We have an agent that is out of date."},{"line_number":214,"context_line":"                # which means I guess grenade updates the agent image"},{"line_number":215,"context_line":"                # for upgrades... :("}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_da3098a1","line":212,"updated":"2020-08-19 09:03:11.000000000","message":"I guess it\u0027s Train and older, I don\u0027t think we even validate the URL after migration to Werkzeug?","commit_id":"30d9cb47e62b62d570e1792515e16abf1ac3cd56"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"8536ad1600b3886dfd701d1e26d558d98382a9d1","unresolved":false,"context_lines":[{"line_number":209,"context_line":"                   \u0027code\u0027: response.status_code})"},{"line_number":210,"context_line":"        if response.status_code \u003e\u003d http_client.BAD_REQUEST:"},{"line_number":211,"context_line":"            faultstring \u003d result.get(\u0027faultstring\u0027)"},{"line_number":212,"context_line":"            if \u0027agent_token\u0027 in faultstring and agent_token:"},{"line_number":213,"context_line":"                # NOTE(TheJulia) We have an agent that is out of date."},{"line_number":214,"context_line":"                # which means I guess grenade updates the agent image"},{"line_number":215,"context_line":"                # for upgrades... :("}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_0960d9ce","line":212,"in_reply_to":"9f560f44_da3098a1","updated":"2020-08-21 20:44:17.000000000","message":"If the ramdisk is Train based, then yeah, it will fail saying the supplied argument is invalid. I _think_ ussuri did the same before we added agent token support.","commit_id":"30d9cb47e62b62d570e1792515e16abf1ac3cd56"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"02a2dc76abf35e87054166aedf04b926a4184b0f","unresolved":false,"context_lines":[{"line_number":213,"context_line":"                # NOTE(TheJulia) We have an agent that is out of date."},{"line_number":214,"context_line":"                # which means I guess grenade updates the agent image"},{"line_number":215,"context_line":"                # for upgrades... :("},{"line_number":216,"context_line":"                if not CONF.require_agent_token:"},{"line_number":217,"context_line":"                    LOG.warning(\u0027Agent command %(method)s for node %(node)s \u0027"},{"line_number":218,"context_line":"                                \u0027failed. Expected 2xx HTTP status code, got \u0027"},{"line_number":219,"context_line":"                                \u0027%(code)d. Error suggests an older ramdisk \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_3a28b432","line":216,"updated":"2020-08-19 09:03:11.000000000","message":"I assume you plan to backport this patch because in Victoria we\u0027re planning on making the tokens required?","commit_id":"30d9cb47e62b62d570e1792515e16abf1ac3cd56"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"8536ad1600b3886dfd701d1e26d558d98382a9d1","unresolved":false,"context_lines":[{"line_number":213,"context_line":"                # NOTE(TheJulia) We have an agent that is out of date."},{"line_number":214,"context_line":"                # which means I guess grenade updates the agent image"},{"line_number":215,"context_line":"                # for upgrades... :("},{"line_number":216,"context_line":"                if not CONF.require_agent_token:"},{"line_number":217,"context_line":"                    LOG.warning(\u0027Agent command %(method)s for node %(node)s \u0027"},{"line_number":218,"context_line":"                                \u0027failed. Expected 2xx HTTP status code, got \u0027"},{"line_number":219,"context_line":"                                \u0027%(code)d. Error suggests an older ramdisk \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_69a6b511","line":216,"in_reply_to":"9f560f44_3a28b432","updated":"2020-08-21 20:44:17.000000000","message":"This is the plan!","commit_id":"30d9cb47e62b62d570e1792515e16abf1ac3cd56"}],"ironic/tests/unit/drivers/modules/test_agent_client.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"26692dd63550e99d74e6a1e61759953fb1896ca1","unresolved":false,"context_lines":[{"line_number":651,"context_line":"        image_info \u003d {\u0027image_id\u0027: \u0027test_image\u0027}"},{"line_number":652,"context_line":"        params \u003d {\u0027image_info\u0027: image_info}"},{"line_number":653,"context_line":"        i_info \u003d self.node.driver_internal_info"},{"line_number":654,"context_line":"        i_info[\u0027agent_secret_token\u0027] \u003d \u0027meowmeowmeow\u0027"},{"line_number":655,"context_line":"        self.client.session.post.side_effect \u003d ["},{"line_number":656,"context_line":"            MockFault(error)"},{"line_number":657,"context_line":"        ]"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_eb44d476","line":654,"updated":"2020-09-02 08:44:50.000000000","message":"A Very Important Token!","commit_id":"30d9cb47e62b62d570e1792515e16abf1ac3cd56"},{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"7932c88e28de1c8198eefac059da934af9497909","unresolved":false,"context_lines":[{"line_number":651,"context_line":"        image_info \u003d {\u0027image_id\u0027: \u0027test_image\u0027}"},{"line_number":652,"context_line":"        params \u003d {\u0027image_info\u0027: image_info}"},{"line_number":653,"context_line":"        i_info \u003d self.node.driver_internal_info"},{"line_number":654,"context_line":"        i_info[\u0027agent_secret_token\u0027] \u003d \u0027meowmeowmeow\u0027"},{"line_number":655,"context_line":"        self.client.session.post.side_effect \u003d ["},{"line_number":656,"context_line":"            MockFault(error)"},{"line_number":657,"context_line":"        ]"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_8b1f34b6","line":654,"range":{"start_line":654,"start_character":40,"end_line":654,"end_character":52},"updated":"2020-09-01 15:25:41.000000000","message":"hahahaha","commit_id":"30d9cb47e62b62d570e1792515e16abf1ac3cd56"}]}