)]}'
{"ironic/api/controllers/v1/node.py":[{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"ae619c1528f4fcb6d046f359955c8c4678045e64","unresolved":false,"context_lines":[{"line_number":120,"context_line":""},{"line_number":121,"context_line":"NODE_SCHEMA \u003d {"},{"line_number":122,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":123,"context_line":"    \u0027properties\u0027: {"},{"line_number":124,"context_line":"        \u0027automated_clean\u0027: {\u0027type\u0027: [\u0027boolean\u0027, \u0027null\u0027]},"},{"line_number":125,"context_line":"        \u0027bios_interface\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":126,"context_line":"        \u0027boot_interface\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_2c3a0b97","line":123,"updated":"2020-09-23 02:03:25.000000000","message":"Below are the old Node class readonly\u003dFalse attributes which didn\u0027t make it into this schema because the POST documentation didn\u0027t mention them. However it is likely possible to create a node with all these attributes specified, so they should be added to this schema and handled","commit_id":"d6e900b7fd79e791265cd82193e3de7e3a256937"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"ae619c1528f4fcb6d046f359955c8c4678045e64","unresolved":false,"context_lines":[{"line_number":125,"context_line":"        \u0027bios_interface\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":126,"context_line":"        \u0027boot_interface\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":127,"context_line":"        \u0027chassis_uuid\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":128,"context_line":"        \u0027conductor_group\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":129,"context_line":"        \u0027console_interface\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":130,"context_line":"        \u0027deploy_interface\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":131,"context_line":"        \u0027description\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027],"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_0c5e2712","line":128,"updated":"2020-09-23 02:03:25.000000000","message":"\u0027console_enabled\u0027: {\u0027type\u0027: [\u0027boolean\u0027, \u0027null\u0027]},","commit_id":"d6e900b7fd79e791265cd82193e3de7e3a256937"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"ae619c1528f4fcb6d046f359955c8c4678045e64","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        \u0027driver\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":134,"context_line":"        \u0027driver_info\u0027: {\u0027type\u0027: [\u0027object\u0027, \u0027null\u0027]},"},{"line_number":135,"context_line":"        \u0027extra\u0027: {\u0027type\u0027: [\u0027object\u0027, \u0027null\u0027]},"},{"line_number":136,"context_line":"        \u0027inspect_interface\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":137,"context_line":"        \u0027lessee\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":138,"context_line":"        \u0027management_interface\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":139,"context_line":"        \u0027name\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_ec2c9394","line":136,"updated":"2020-09-23 02:03:25.000000000","message":"\u0027inspection_finished_at\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},\n\u0027inspection_started_at\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},\n\u0027instance_info\u0027: {\u0027type\u0027: [\u0027object\u0027, \u0027null\u0027]},\n\u0027instance_uuid\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},","commit_id":"d6e900b7fd79e791265cd82193e3de7e3a256937"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"ae619c1528f4fcb6d046f359955c8c4678045e64","unresolved":false,"context_lines":[{"line_number":135,"context_line":"        \u0027extra\u0027: {\u0027type\u0027: [\u0027object\u0027, \u0027null\u0027]},"},{"line_number":136,"context_line":"        \u0027inspect_interface\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":137,"context_line":"        \u0027lessee\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":138,"context_line":"        \u0027management_interface\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":139,"context_line":"        \u0027name\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":140,"context_line":"        \u0027network_data\u0027: {\u0027anyOf\u0027: ["},{"line_number":141,"context_line":"            {\u0027type\u0027: \u0027null\u0027},"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_6c6fe3c3","line":138,"updated":"2020-09-23 02:03:25.000000000","message":"\u0027maintenance\u0027: {\u0027type\u0027: [\u0027boolean\u0027, \u0027null\u0027]},","commit_id":"d6e900b7fd79e791265cd82193e3de7e3a256937"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"ae619c1528f4fcb6d046f359955c8c4678045e64","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        ]},"},{"line_number":145,"context_line":"        \u0027network_interface\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":146,"context_line":"        \u0027owner\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":147,"context_line":"        \u0027power_interface\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":148,"context_line":"        \u0027properties\u0027: {\u0027type\u0027: [\u0027object\u0027, \u0027null\u0027]},"},{"line_number":149,"context_line":"        \u0027raid_interface\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":150,"context_line":"        \u0027rescue_interface\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_0c8c677e","line":147,"updated":"2020-09-23 02:03:25.000000000","message":"\u0027protected\u0027: {\u0027type\u0027: [\u0027boolean\u0027, \u0027null\u0027]},\n\u0027protected_reason\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},","commit_id":"d6e900b7fd79e791265cd82193e3de7e3a256937"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"e4725a7478a2fafef393435fbb398a18ef17c51c","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        ]},"},{"line_number":145,"context_line":"        \u0027network_interface\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":146,"context_line":"        \u0027owner\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":147,"context_line":"        \u0027power_interface\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":148,"context_line":"        \u0027properties\u0027: {\u0027type\u0027: [\u0027object\u0027, \u0027null\u0027]},"},{"line_number":149,"context_line":"        \u0027raid_interface\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":150,"context_line":"        \u0027rescue_interface\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_accbbb47","line":147,"in_reply_to":"9f560f44_0c8c677e","updated":"2020-09-23 20:23:30.000000000","message":"This isn\u0027t needed, there is a test to confirm POST with a protected property fails","commit_id":"d6e900b7fd79e791265cd82193e3de7e3a256937"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"ae619c1528f4fcb6d046f359955c8c4678045e64","unresolved":false,"context_lines":[{"line_number":145,"context_line":"        \u0027network_interface\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":146,"context_line":"        \u0027owner\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":147,"context_line":"        \u0027power_interface\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":148,"context_line":"        \u0027properties\u0027: {\u0027type\u0027: [\u0027object\u0027, \u0027null\u0027]},"},{"line_number":149,"context_line":"        \u0027raid_interface\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":150,"context_line":"        \u0027rescue_interface\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":151,"context_line":"        \u0027resource_class\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027], \u0027maxLength\u0027: 80},"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_ec413338","line":148,"updated":"2020-09-23 02:03:25.000000000","message":"\u0027provision_updated_at\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},","commit_id":"d6e900b7fd79e791265cd82193e3de7e3a256937"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"ae619c1528f4fcb6d046f359955c8c4678045e64","unresolved":false,"context_lines":[{"line_number":148,"context_line":"        \u0027properties\u0027: {\u0027type\u0027: [\u0027object\u0027, \u0027null\u0027]},"},{"line_number":149,"context_line":"        \u0027raid_interface\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":150,"context_line":"        \u0027rescue_interface\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":151,"context_line":"        \u0027resource_class\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027], \u0027maxLength\u0027: 80},"},{"line_number":152,"context_line":"        \u0027storage_interface\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":153,"context_line":"        \u0027uuid\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":154,"context_line":"        \u0027vendor_interface\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_acd73b4f","line":151,"updated":"2020-09-23 02:03:25.000000000","message":"\u0027retired\u0027: {\u0027type\u0027: [\u0027boolean\u0027, \u0027null\u0027]},\n\u0027retired_reason\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},","commit_id":"d6e900b7fd79e791265cd82193e3de7e3a256937"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"ae619c1528f4fcb6d046f359955c8c4678045e64","unresolved":false,"context_lines":[{"line_number":150,"context_line":"        \u0027rescue_interface\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":151,"context_line":"        \u0027resource_class\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027], \u0027maxLength\u0027: 80},"},{"line_number":152,"context_line":"        \u0027storage_interface\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":153,"context_line":"        \u0027uuid\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":154,"context_line":"        \u0027vendor_interface\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":155,"context_line":"    },"},{"line_number":156,"context_line":"    \u0027required\u0027: [\u0027driver\u0027],"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_8c78777e","line":153,"updated":"2020-09-23 02:03:25.000000000","message":"\u0027traits\u0027: {\n    \u0027type\u0027: [\u0027array\u0027, \u0027null\u0027],\n    \u0027items\u0027: api_utils.TRAITS_SCHEMA\n},","commit_id":"d6e900b7fd79e791265cd82193e3de7e3a256937"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"e4725a7478a2fafef393435fbb398a18ef17c51c","unresolved":false,"context_lines":[{"line_number":150,"context_line":"        \u0027rescue_interface\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":151,"context_line":"        \u0027resource_class\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027], \u0027maxLength\u0027: 80},"},{"line_number":152,"context_line":"        \u0027storage_interface\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":153,"context_line":"        \u0027uuid\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":154,"context_line":"        \u0027vendor_interface\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":155,"context_line":"    },"},{"line_number":156,"context_line":"    \u0027required\u0027: [\u0027driver\u0027],"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_8ce197d2","line":153,"in_reply_to":"9f560f44_8c78777e","updated":"2020-09-23 20:23:30.000000000","message":"There is a test to confirm that POST with traits fails, so this can be removed","commit_id":"d6e900b7fd79e791265cd82193e3de7e3a256937"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"04172d58a1b2a9459949020c0bd4cb06e1ff732f","unresolved":false,"context_lines":[{"line_number":225,"context_line":"    \u0027retired\u0027,"},{"line_number":226,"context_line":"    \u0027retired_reason\u0027,"},{"line_number":227,"context_line":"    \u0027storage_interface\u0027,"},{"line_number":228,"context_line":"    \u0027traits\u0027,"},{"line_number":229,"context_line":"    \u0027vendor_interface\u0027"},{"line_number":230,"context_line":"]"},{"line_number":231,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"9f560f44_52dce416","line":228,"updated":"2020-09-27 22:28:32.000000000","message":"This shouldn\u0027t be here, trait changes have a dedicated trait controller","commit_id":"9e97b48d3deea9a15a1ca595f361be8f1362cc90"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"ec17cfbd5c4d36b89db0f9f6067ff472357914cd","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        \u0027instance_uuid\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":141,"context_line":"        \u0027lessee\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":142,"context_line":"        \u0027management_interface\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":143,"context_line":"        \u0027maintenance\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027boolean\u0027, \u0027null\u0027]},"},{"line_number":144,"context_line":"        \u0027name\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":145,"context_line":"        \u0027network_data\u0027: {\u0027anyOf\u0027: ["},{"line_number":146,"context_line":"            {\u0027type\u0027: \u0027null\u0027},"}],"source_content_type":"text/x-python","patch_set":18,"id":"9f560f44_9277ee8e","line":143,"updated":"2020-10-12 01:33:12.000000000","message":"Missing maintenance_reason","commit_id":"f5fe809f37bac739ca190afa0e58db9b50d49fab"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"adb0cfd8c75b1d8f03de55e63ff54ab9c7e86cc1","unresolved":false,"context_lines":[{"line_number":243,"context_line":"    args.schema({"},{"line_number":244,"context_line":"        \u0027type\u0027: \u0027object\u0027,"},{"line_number":245,"context_line":"        \u0027properties\u0027: {"},{"line_number":246,"context_line":"            \u0027id\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":247,"context_line":"        },"},{"line_number":248,"context_line":"        \u0027required\u0027: [\u0027id\u0027],"},{"line_number":249,"context_line":"        \u0027additionalProperties\u0027: True,"}],"source_content_type":"text/x-python","patch_set":18,"id":"9f560f44_77b4ccf1","line":246,"updated":"2020-10-09 01:41:18.000000000","message":"Note to self, add port_uuid and portgroup_uuid here since that seems to be the only thing consumed from this freeform dict","commit_id":"f5fe809f37bac739ca190afa0e58db9b50d49fab"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"02ce056d2808665420cb6bcfa539d94a9b1c38a5","unresolved":false,"context_lines":[{"line_number":168,"context_line":"NODE_PATCH_SCHEMA \u003d copy.deepcopy(NODE_SCHEMA)"},{"line_number":169,"context_line":"# add schema for patchable fields"},{"line_number":170,"context_line":"NODE_PATCH_SCHEMA[\u0027properties\u0027][\u0027protected\u0027] \u003d {"},{"line_number":171,"context_line":"    \u0027type\u0027: [\u0027string\u0027, \u0027boolean\u0027, \u0027null\u0027]}"},{"line_number":172,"context_line":"NODE_PATCH_SCHEMA[\u0027properties\u0027][\u0027protected_reason\u0027] \u003d {"},{"line_number":173,"context_line":"    \u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]}"},{"line_number":174,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"1f621f24_ad223100","line":171,"updated":"2020-11-18 08:49:39.000000000","message":"I\u0027ve just learned that we accept strings for booleans, we need to make sure we have unit tests for this behavior","commit_id":"fc4793960b88f1d73ecb299fd511b867e77968f7"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"02ce056d2808665420cb6bcfa539d94a9b1c38a5","unresolved":false,"context_lines":[{"line_number":837,"context_line":"    @METRICS.timer(\u0027NodeStatesController.provision\u0027)"},{"line_number":838,"context_line":"    @method.expose(status_code\u003dhttp_client.ACCEPTED)"},{"line_number":839,"context_line":"    @args.validate(node_ident\u003dargs.uuid_or_name, target\u003dargs.string,"},{"line_number":840,"context_line":"                   configdrive\u003dargs.types(type(None), dict, str),"},{"line_number":841,"context_line":"                   clean_steps\u003dargs.types(type(None), list),"},{"line_number":842,"context_line":"                   rescue_password\u003dargs.string)"},{"line_number":843,"context_line":"    def provision(self, node_ident, target, configdrive\u003dNone,"}],"source_content_type":"text/x-python","patch_set":22,"id":"1f621f24_0d2085f7","line":840,"updated":"2020-11-18 08:49:39.000000000","message":"nit: we should be able to accept just None","commit_id":"fc4793960b88f1d73ecb299fd511b867e77968f7"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"02ce056d2808665420cb6bcfa539d94a9b1c38a5","unresolved":false,"context_lines":[{"line_number":1132,"context_line":"        rpc_node,"},{"line_number":1133,"context_line":"        link_resource\u003d\u0027nodes\u0027,"},{"line_number":1134,"context_line":"        fields\u003d("},{"line_number":1135,"context_line":"            \u0027automated_clean\u0027,"},{"line_number":1136,"context_line":"            \u0027bios_interface\u0027,"},{"line_number":1137,"context_line":"            \u0027boot_interface\u0027,"},{"line_number":1138,"context_line":"            \u0027clean_step\u0027,"}],"source_content_type":"text/x-python","patch_set":22,"id":"1f621f24_ed1c29c3","line":1135,"updated":"2020-11-18 08:49:39.000000000","message":"This is actually a boolean","commit_id":"fc4793960b88f1d73ecb299fd511b867e77968f7"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"34b61e97db70649c2552156616e4593dc0480f0f","unresolved":false,"context_lines":[{"line_number":1132,"context_line":"        rpc_node,"},{"line_number":1133,"context_line":"        link_resource\u003d\u0027nodes\u0027,"},{"line_number":1134,"context_line":"        fields\u003d("},{"line_number":1135,"context_line":"            \u0027automated_clean\u0027,"},{"line_number":1136,"context_line":"            \u0027bios_interface\u0027,"},{"line_number":1137,"context_line":"            \u0027boot_interface\u0027,"},{"line_number":1138,"context_line":"            \u0027clean_step\u0027,"}],"source_content_type":"text/x-python","patch_set":22,"id":"fffc6b78_9a4adf7d","line":1135,"in_reply_to":"1f621f24_ed1c29c3","updated":"2020-11-20 04:03:03.000000000","message":"Oh, the reason this was here is that unlike other booleans, None should remain None, not converted to False. The new object_to_dict behavior handles this anyway.","commit_id":"fc4793960b88f1d73ecb299fd511b867e77968f7"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"02ce056d2808665420cb6bcfa539d94a9b1c38a5","unresolved":false,"context_lines":[{"line_number":1280,"context_line":"        # NOTE(derekh): mask ssh keys for the ssh power driver."},{"line_number":1281,"context_line":"        # As this driver is deprecated masking here (opposed to strutils)"},{"line_number":1282,"context_line":"        # is simpler, and easier to backport. This can be removed along"},{"line_number":1283,"context_line":"        # with support for the ssh power driver."},{"line_number":1284,"context_line":"        if node[\u0027driver_info\u0027].get(\u0027ssh_key_contents\u0027):"},{"line_number":1285,"context_line":"            node[\u0027driver_info\u0027][\u0027ssh_key_contents\u0027] \u003d \"******\""},{"line_number":1286,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"1f621f24_4d771d0a","line":1283,"updated":"2020-11-18 08:49:39.000000000","message":"Wow, this is ancient","commit_id":"fc4793960b88f1d73ecb299fd511b867e77968f7"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"34b61e97db70649c2552156616e4593dc0480f0f","unresolved":false,"context_lines":[{"line_number":1280,"context_line":"        # NOTE(derekh): mask ssh keys for the ssh power driver."},{"line_number":1281,"context_line":"        # As this driver is deprecated masking here (opposed to strutils)"},{"line_number":1282,"context_line":"        # is simpler, and easier to backport. This can be removed along"},{"line_number":1283,"context_line":"        # with support for the ssh power driver."},{"line_number":1284,"context_line":"        if node[\u0027driver_info\u0027].get(\u0027ssh_key_contents\u0027):"},{"line_number":1285,"context_line":"            node[\u0027driver_info\u0027][\u0027ssh_key_contents\u0027] \u003d \"******\""},{"line_number":1286,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"fffc6b78_d518ce76","line":1283,"in_reply_to":"1f621f24_4d771d0a","updated":"2020-11-20 04:03:03.000000000","message":"Done","commit_id":"fc4793960b88f1d73ecb299fd511b867e77968f7"}],"ironic/api/controllers/v1/utils.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"165a8cdb613ce09be860d6c46dc5822777a28638","unresolved":false,"context_lines":[{"line_number":243,"context_line":"        if field not in schema_fields:"},{"line_number":244,"context_line":"            patched_dict.pop(field, None)"},{"line_number":245,"context_line":"    if not validator:"},{"line_number":246,"context_line":"        validator \u003d args.schema(schema)"},{"line_number":247,"context_line":"    validator(\u0027patch\u0027, patched_dict)"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_9d4e83c0","line":246,"updated":"2020-09-14 09:18:10.000000000","message":"pep8: F821 undefined name \u0027args\u0027","commit_id":"719a9bdf812fdbbe22eb48cec996a424f4c86e6f"}]}