)]}'
{"ironic/conf/agent.py":[{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"1a1a73598b84e5d7a0326ba6d203a3ba49f3b5df","unresolved":false,"context_lines":[{"line_number":105,"context_line":"                        (\u0027local\u0027, _(\u0027Same as \"http\", but HTTP images \u0027"},{"line_number":106,"context_line":"                                    \u0027are also cached locally, converted \u0027"},{"line_number":107,"context_line":"                                    \u0027and served from the conductor\u0027))],"},{"line_number":108,"context_line":"               default\u003d\u0027swift\u0027,"},{"line_number":109,"context_line":"               mutable\u003dTrue,"},{"line_number":110,"context_line":"               help\u003d_(\u0027Specifies whether direct deploy interface should try \u0027"},{"line_number":111,"context_line":"                      \u0027to use the image source directly or if ironic should \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_d3aa5518","line":108,"updated":"2020-09-03 05:59:14.000000000","message":"maybe a new option to change whether we cache http images?\npreviously swift and http are mutually exclusive methods, but local is a super set of http, and seems not intuitive for end users.","commit_id":"9ac5c0277022a28f3332a43c9572a56b56a51589"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"435975cfbea293084bab7e31de45864799ef1a15","unresolved":false,"context_lines":[{"line_number":105,"context_line":"                        (\u0027local\u0027, _(\u0027Same as \"http\", but HTTP images \u0027"},{"line_number":106,"context_line":"                                    \u0027are also cached locally, converted \u0027"},{"line_number":107,"context_line":"                                    \u0027and served from the conductor\u0027))],"},{"line_number":108,"context_line":"               default\u003d\u0027swift\u0027,"},{"line_number":109,"context_line":"               mutable\u003dTrue,"},{"line_number":110,"context_line":"               help\u003d_(\u0027Specifies whether direct deploy interface should try \u0027"},{"line_number":111,"context_line":"                      \u0027to use the image source directly or if ironic should \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_df48942f","line":108,"in_reply_to":"9f560f44_297522fb","updated":"2020-09-03 09:33:22.000000000","message":"I\u0027m not sure, having too many options is also confusing. One of my next patches also make image_download_source available on the node level, with your proposal we\u0027ll need to provide two options.","commit_id":"9ac5c0277022a28f3332a43c9572a56b56a51589"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"aa7cbf0393dcd5b20b23ec8a0730ccbe23c41dcd","unresolved":false,"context_lines":[{"line_number":105,"context_line":"                        (\u0027local\u0027, _(\u0027Same as \"http\", but HTTP images \u0027"},{"line_number":106,"context_line":"                                    \u0027are also cached locally, converted \u0027"},{"line_number":107,"context_line":"                                    \u0027and served from the conductor\u0027))],"},{"line_number":108,"context_line":"               default\u003d\u0027swift\u0027,"},{"line_number":109,"context_line":"               mutable\u003dTrue,"},{"line_number":110,"context_line":"               help\u003d_(\u0027Specifies whether direct deploy interface should try \u0027"},{"line_number":111,"context_line":"                      \u0027to use the image source directly or if ironic should \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_297522fb","line":108,"in_reply_to":"9f560f44_d3aa5518","updated":"2020-09-03 08:32:36.000000000","message":"Using image_download_source seems fine to me.","commit_id":"9ac5c0277022a28f3332a43c9572a56b56a51589"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"db3ef68bb81eb251afc1459c0da8f51c34cdc71d","unresolved":false,"context_lines":[{"line_number":105,"context_line":"                        (\u0027local\u0027, _(\u0027Same as \"http\", but HTTP images \u0027"},{"line_number":106,"context_line":"                                    \u0027are also cached locally, converted \u0027"},{"line_number":107,"context_line":"                                    \u0027and served from the conductor\u0027))],"},{"line_number":108,"context_line":"               default\u003d\u0027swift\u0027,"},{"line_number":109,"context_line":"               mutable\u003dTrue,"},{"line_number":110,"context_line":"               help\u003d_(\u0027Specifies whether direct deploy interface should try \u0027"},{"line_number":111,"context_line":"                      \u0027to use the image source directly or if ironic should \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_a1e5c60c","line":108,"in_reply_to":"9f560f44_df48942f","updated":"2020-09-03 11:54:11.000000000","message":"make sense.","commit_id":"9ac5c0277022a28f3332a43c9572a56b56a51589"}]}