)]}'
{"ironic/api/controllers/v1/port.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2e290403696982632d6c418706ecfdf854183ace","unresolved":false,"context_lines":[{"line_number":66,"context_line":"PATCH_ALLOWED_FIELDS \u003d ["},{"line_number":67,"context_line":"    \u0027address\u0027,"},{"line_number":68,"context_line":"    \u0027extra\u0027,"},{"line_number":69,"context_line":"    \u0027internal_info\u0027,"},{"line_number":70,"context_line":"    \u0027is_smartnic\u0027,"},{"line_number":71,"context_line":"    \u0027local_link_connection\u0027,"},{"line_number":72,"context_line":"    \u0027node_uuid\u0027,"}],"source_content_type":"text/x-python","patch_set":20,"id":"1f621f24_edf8a94a","line":69,"updated":"2020-11-18 09:01:06.000000000","message":"Should not be here, we patch internal_info on fly but don\u0027t allow users to patch it. Please follow-up with a fix.","commit_id":"b911acb10899d73dec75f47eb11153f5f677aaed"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"fc5f6e08297277b73967dfdff365edd8f0355a97","unresolved":false,"context_lines":[{"line_number":66,"context_line":"PATCH_ALLOWED_FIELDS \u003d ["},{"line_number":67,"context_line":"    \u0027address\u0027,"},{"line_number":68,"context_line":"    \u0027extra\u0027,"},{"line_number":69,"context_line":"    \u0027internal_info\u0027,"},{"line_number":70,"context_line":"    \u0027is_smartnic\u0027,"},{"line_number":71,"context_line":"    \u0027local_link_connection\u0027,"},{"line_number":72,"context_line":"    \u0027node_uuid\u0027,"}],"source_content_type":"text/x-python","patch_set":20,"id":"fffc6b78_1a56ef2a","line":69,"in_reply_to":"1f621f24_edf8a94a","updated":"2020-11-20 04:03:43.000000000","message":"Done","commit_id":"b911acb10899d73dec75f47eb11153f5f677aaed"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2e290403696982632d6c418706ecfdf854183ace","unresolved":false,"context_lines":[{"line_number":547,"context_line":""},{"line_number":548,"context_line":"        vif \u003d api_utils.handle_post_port_like_extra_vif(port)"},{"line_number":549,"context_line":""},{"line_number":550,"context_line":"        if (portgroup and (port.get(\u0027pxe_enabled\u0027) or vif)):"},{"line_number":551,"context_line":"            if not portgroup.standalone_ports_supported:"},{"line_number":552,"context_line":"                msg \u003d _(\"Port group %s doesn\u0027t support standalone ports. \""},{"line_number":553,"context_line":"                        \"This port cannot be created as a member of that \""}],"source_content_type":"text/x-python","patch_set":20,"id":"1f621f24_4d939d01","line":550,"updated":"2020-11-18 09:01:06.000000000","message":"nit: redundant brackets","commit_id":"b911acb10899d73dec75f47eb11153f5f677aaed"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"fc5f6e08297277b73967dfdff365edd8f0355a97","unresolved":false,"context_lines":[{"line_number":547,"context_line":""},{"line_number":548,"context_line":"        vif \u003d api_utils.handle_post_port_like_extra_vif(port)"},{"line_number":549,"context_line":""},{"line_number":550,"context_line":"        if (portgroup and (port.get(\u0027pxe_enabled\u0027) or vif)):"},{"line_number":551,"context_line":"            if not portgroup.standalone_ports_supported:"},{"line_number":552,"context_line":"                msg \u003d _(\"Port group %s doesn\u0027t support standalone ports. \""},{"line_number":553,"context_line":"                        \"This port cannot be created as a member of that \""}],"source_content_type":"text/x-python","patch_set":20,"id":"fffc6b78_d531eeee","line":550,"in_reply_to":"1f621f24_4d939d01","updated":"2020-11-20 04:03:43.000000000","message":"\u0027or\u0027 has a lower precedence than \u0027and\u0027:\n\n  \u003e\u003e\u003e False and False or True\n  True\n  \u003e\u003e\u003e False and (False or True)\n  False","commit_id":"b911acb10899d73dec75f47eb11153f5f677aaed"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2e290403696982632d6c418706ecfdf854183ace","unresolved":false,"context_lines":[{"line_number":629,"context_line":"        port_dict \u003d api_utils.apply_jsonpatch(port_dict, patch)"},{"line_number":630,"context_line":""},{"line_number":631,"context_line":"        api_utils.handle_patch_port_like_extra_vif("},{"line_number":632,"context_line":"            rpc_port, port_dict[\u0027internal_info\u0027], patch)"},{"line_number":633,"context_line":""},{"line_number":634,"context_line":"        try:"},{"line_number":635,"context_line":"            if api_utils.is_path_updated(patch, \u0027/portgroup_uuid\u0027):"}],"source_content_type":"text/x-python","patch_set":20,"id":"1f621f24_2d98e119","line":632,"updated":"2020-11-18 09:01:06.000000000","message":"note: this is where patching extra/vif_port_id is turned into patching internal_info/tenant_vif_port_id","commit_id":"b911acb10899d73dec75f47eb11153f5f677aaed"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"fc5f6e08297277b73967dfdff365edd8f0355a97","unresolved":false,"context_lines":[{"line_number":629,"context_line":"        port_dict \u003d api_utils.apply_jsonpatch(port_dict, patch)"},{"line_number":630,"context_line":""},{"line_number":631,"context_line":"        api_utils.handle_patch_port_like_extra_vif("},{"line_number":632,"context_line":"            rpc_port, port_dict[\u0027internal_info\u0027], patch)"},{"line_number":633,"context_line":""},{"line_number":634,"context_line":"        try:"},{"line_number":635,"context_line":"            if api_utils.is_path_updated(patch, \u0027/portgroup_uuid\u0027):"}],"source_content_type":"text/x-python","patch_set":20,"id":"fffc6b78_7a30db08","line":632,"in_reply_to":"1f621f24_2d98e119","updated":"2020-11-20 04:03:43.000000000","message":"Done","commit_id":"b911acb10899d73dec75f47eb11153f5f677aaed"}]}