)]}'
{"ironic/tests/unit/conductor/test_deployments.py":[{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"74f9f9bac277a1af24a2a704fb2ad8192bebfef2","unresolved":false,"context_lines":[{"line_number":604,"context_line":"        self.assertEqual({}, node.deploy_step)"},{"line_number":605,"context_line":"        self.assertNotIn(\u0027deploy_step_index\u0027, node.driver_internal_info)"},{"line_number":606,"context_line":"        self.assertIsNone(node.driver_internal_info[\u0027deploy_steps\u0027])"},{"line_number":607,"context_line":"        mock_execute.assert_has_calls([mock.call(self.deploy_steps[0]),"},{"line_number":608,"context_line":"                                       mock.call(self.deploy_steps[1])])"},{"line_number":609,"context_line":"        self.assertNotIn(\u0027agent_url\u0027, node.driver_internal_info)"},{"line_number":610,"context_line":"        self.assertNotIn(\u0027agent_secret_token\u0027, node.driver_internal_info)"},{"line_number":611,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_b0273312","line":608,"range":{"start_line":607,"start_character":0,"end_line":608,"end_character":72},"updated":"2020-09-14 02:28:00.000000000","message":"ft1.6: ironic.tests.unit.conductor.test_deployments.DoNextDeployStepTestCase.test__do_next_deploy_step_alltesttools.testresult.real._StringException: Traceback (most recent call last):\n  File \"/usr/lib/python3.6/unittest/mock.py\", line 1183, in patched\n    return func(*args, **keywargs)\n  File \"/home/zuul/src/opendev.org/openstack/ironic/ironic/tests/unit/conductor/test_deployments.py\", line 608, in test__do_next_deploy_step_all\n    mock.call(self.deploy_steps[1])])\n  File \"/usr/lib/python3.6/unittest/mock.py\", line 205, in assert_has_calls\n    return mock.assert_has_calls(*args, **kwargs)\n  File \"/usr/lib/python3.6/unittest/mock.py\", line 846, in assert_has_calls\n    ) from cause\nAssertionError: Calls not found.\nExpected: [call({\u0027step\u0027: \u0027deploy_start\u0027, \u0027priority\u0027: 50, \u0027interface\u0027: \u0027deploy\u0027}),\n call({\u0027step\u0027: \u0027deploy_end\u0027, \u0027priority\u0027: 20, \u0027interface\u0027: \u0027deploy\u0027})]\nActual: [call(\u003cironic.drivers.modules.fake.FakeDeploy object at 0x7f6838d6c4e0\u003e, \u003cironic.conductor.task_manager.TaskManager object at 0x7f6837febd30\u003e, {\u0027step\u0027: \u0027deploy_end\u0027, \u0027priority\u0027: 20, \u0027interface\u0027: \u0027deploy\u0027})]","commit_id":"53be0a56f4492c8682a56119f0103f1c5eb166e4"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"598c1aea94d443a8da014ac175e725cc17a1fe91","unresolved":false,"context_lines":[{"line_number":604,"context_line":"        self.assertEqual({}, node.deploy_step)"},{"line_number":605,"context_line":"        self.assertNotIn(\u0027deploy_step_index\u0027, node.driver_internal_info)"},{"line_number":606,"context_line":"        self.assertIsNone(node.driver_internal_info[\u0027deploy_steps\u0027])"},{"line_number":607,"context_line":"        mock_execute.assert_has_calls([mock.call(self.deploy_steps[0]),"},{"line_number":608,"context_line":"                                       mock.call(self.deploy_steps[1])])"},{"line_number":609,"context_line":"        self.assertNotIn(\u0027agent_url\u0027, node.driver_internal_info)"},{"line_number":610,"context_line":"        self.assertNotIn(\u0027agent_secret_token\u0027, node.driver_internal_info)"},{"line_number":611,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_91fcac73","line":608,"range":{"start_line":607,"start_character":0,"end_line":608,"end_character":72},"in_reply_to":"9f560f44_b0273312","updated":"2020-09-14 11:42:24.000000000","message":"missing arguments to calls: needs adding task.driver.deploy and task.","commit_id":"53be0a56f4492c8682a56119f0103f1c5eb166e4"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"6617c293ce7673ded4311416d8fc879a57c3dbf3","unresolved":false,"context_lines":[{"line_number":595,"context_line":"        task \u003d task_manager.TaskManager(self.context, node.uuid)"},{"line_number":596,"context_line":"        task.process_event(\u0027deploy\u0027)"},{"line_number":597,"context_line":""},{"line_number":598,"context_line":"        deployments.do_next_deploy_step(task, 1, self.service.conductor.id)"},{"line_number":599,"context_line":""},{"line_number":600,"context_line":"        # Deploying should be complete"},{"line_number":601,"context_line":"        node.refresh()"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_a57a2422","line":598,"updated":"2020-09-16 09:19:14.000000000","message":"I think s/1/0/ better reflects the intention of this test (see line 583)","commit_id":"ae6da039ee7f1f398e9f8ae4eab669aeedb22340"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"ba519fa4fc373e997f91f7c395f59bddc85e46f8","unresolved":false,"context_lines":[{"line_number":604,"context_line":"        self.assertEqual({}, node.deploy_step)"},{"line_number":605,"context_line":"        self.assertNotIn(\u0027deploy_step_index\u0027, node.driver_internal_info)"},{"line_number":606,"context_line":"        self.assertIsNone(node.driver_internal_info[\u0027deploy_steps\u0027])"},{"line_number":607,"context_line":"        mock_execute.assert_has_calls("},{"line_number":608,"context_line":"            [mock.call(task.driver.deploy, task, self.deploy_steps[1])])"},{"line_number":609,"context_line":"        self.assertNotIn(\u0027agent_url\u0027, node.driver_internal_info)"},{"line_number":610,"context_line":"        self.assertNotIn(\u0027agent_secret_token\u0027, node.driver_internal_info)"},{"line_number":611,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_85a8c0d9","line":608,"range":{"start_line":607,"start_character":8,"end_line":608,"end_character":72},"updated":"2020-09-16 09:14:03.000000000","message":"Since this is called once:\nmock_execute.assert_called_once_with(task.driver.deploy, task, self.deploy_steps[1])","commit_id":"ae6da039ee7f1f398e9f8ae4eab669aeedb22340"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"6617c293ce7673ded4311416d8fc879a57c3dbf3","unresolved":false,"context_lines":[{"line_number":605,"context_line":"        self.assertNotIn(\u0027deploy_step_index\u0027, node.driver_internal_info)"},{"line_number":606,"context_line":"        self.assertIsNone(node.driver_internal_info[\u0027deploy_steps\u0027])"},{"line_number":607,"context_line":"        mock_execute.assert_has_calls("},{"line_number":608,"context_line":"            [mock.call(task.driver.deploy, task, self.deploy_steps[1])])"},{"line_number":609,"context_line":"        self.assertNotIn(\u0027agent_url\u0027, node.driver_internal_info)"},{"line_number":610,"context_line":"        self.assertNotIn(\u0027agent_secret_token\u0027, node.driver_internal_info)"},{"line_number":611,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_8577203c","line":608,"updated":"2020-09-16 09:19:14.000000000","message":"There has to be two steps here","commit_id":"ae6da039ee7f1f398e9f8ae4eab669aeedb22340"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"ba519fa4fc373e997f91f7c395f59bddc85e46f8","unresolved":false,"context_lines":[{"line_number":637,"context_line":"        self.assertEqual({}, node.deploy_step)"},{"line_number":638,"context_line":"        self.assertNotIn(\u0027deploy_step_index\u0027, node.driver_internal_info)"},{"line_number":639,"context_line":"        self.assertIsNone(node.driver_internal_info[\u0027deploy_steps\u0027])"},{"line_number":640,"context_line":"        mock_execute.assert_has_calls("},{"line_number":641,"context_line":"            [mock.call(task.driver.deploy, task, self.deploy_steps[1])])"},{"line_number":642,"context_line":"        self.assertEqual(\u0027url\u0027, node.driver_internal_info[\u0027agent_url\u0027])"},{"line_number":643,"context_line":"        self.assertEqual(\u0027token\u0027,"},{"line_number":644,"context_line":"                         node.driver_internal_info[\u0027agent_secret_token\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_e5b53c34","line":641,"range":{"start_line":640,"start_character":8,"end_line":641,"end_character":72},"updated":"2020-09-16 09:14:03.000000000","message":"ditto","commit_id":"ae6da039ee7f1f398e9f8ae4eab669aeedb22340"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"6617c293ce7673ded4311416d8fc879a57c3dbf3","unresolved":false,"context_lines":[{"line_number":638,"context_line":"        self.assertNotIn(\u0027deploy_step_index\u0027, node.driver_internal_info)"},{"line_number":639,"context_line":"        self.assertIsNone(node.driver_internal_info[\u0027deploy_steps\u0027])"},{"line_number":640,"context_line":"        mock_execute.assert_has_calls("},{"line_number":641,"context_line":"            [mock.call(task.driver.deploy, task, self.deploy_steps[1])])"},{"line_number":642,"context_line":"        self.assertEqual(\u0027url\u0027, node.driver_internal_info[\u0027agent_url\u0027])"},{"line_number":643,"context_line":"        self.assertEqual(\u0027token\u0027,"},{"line_number":644,"context_line":"                         node.driver_internal_info[\u0027agent_secret_token\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_e5741c39","line":641,"updated":"2020-09-16 09:19:14.000000000","message":"same","commit_id":"ae6da039ee7f1f398e9f8ae4eab669aeedb22340"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"fcf19c5523b189987707f5a93e3ac458a4d09011","unresolved":false,"context_lines":[{"line_number":629,"context_line":"        task \u003d task_manager.TaskManager(self.context, node.uuid)"},{"line_number":630,"context_line":"        task.process_event(\u0027deploy\u0027)"},{"line_number":631,"context_line":""},{"line_number":632,"context_line":"        deployments.do_next_deploy_step(task, 1, self.service.conductor.id)"},{"line_number":633,"context_line":""},{"line_number":634,"context_line":"        # Deploying should be complete"},{"line_number":635,"context_line":"        node.refresh()"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_ab915356","line":632,"updated":"2020-09-16 11:09:13.000000000","message":"0 here as well","commit_id":"f4134aaf99ad4c987ac3af0539c347ef38f7419c"}]}