)]}'
{"ironic/drivers/modules/inspector.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7738b7a98827a01d51c4a885e6f6cf19bbc5f0a6","unresolved":false,"context_lines":[{"line_number":203,"context_line":"            task.driver.network.add_inspection_network(task)"},{"line_number":204,"context_line":"        task.driver.boot.prepare_ramdisk(task, ramdisk_params\u003dparams)"},{"line_number":205,"context_line":"        client.start_introspection(task.node.uuid, manage_boot\u003dFalse,"},{"line_number":206,"context_line":"                                   lookup\u003dlookup)"},{"line_number":207,"context_line":"        cond_utils.node_power_action(task, states.POWER_ON)"},{"line_number":208,"context_line":"    except Exception as exc:"},{"line_number":209,"context_line":"        LOG.exception(\u0027Unable to start managed inspection for node %(uuid)s: \u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"1f621f24_05bb7ec4","line":206,"updated":"2020-11-12 15:51:27.000000000","message":"You need to update openstacksdk to support the new field, then update requirements.txt with the new version. Unfortunately, it seems that unknown fields are ignored rather than raising an error.","commit_id":"343fe1ef4e3456351a863fcb2ea7605f4f9a59f7"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"e84055256bd4d4a22588b69dfdb7641bf96ca586","unresolved":false,"context_lines":[{"line_number":203,"context_line":"            task.driver.network.add_inspection_network(task)"},{"line_number":204,"context_line":"        task.driver.boot.prepare_ramdisk(task, ramdisk_params\u003dparams)"},{"line_number":205,"context_line":"        client.start_introspection(task.node.uuid, manage_boot\u003dFalse,"},{"line_number":206,"context_line":"                                   lookup\u003dlookup)"},{"line_number":207,"context_line":"        cond_utils.node_power_action(task, states.POWER_ON)"},{"line_number":208,"context_line":"    except Exception as exc:"},{"line_number":209,"context_line":"        LOG.exception(\u0027Unable to start managed inspection for node %(uuid)s: \u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"1f621f24_92f2166f","line":206,"in_reply_to":"1f621f24_05bb7ec4","updated":"2020-11-18 04:39:41.000000000","message":"Done","commit_id":"343fe1ef4e3456351a863fcb2ea7605f4f9a59f7"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7738b7a98827a01d51c4a885e6f6cf19bbc5f0a6","unresolved":false,"context_lines":[{"line_number":246,"context_line":"        \"\"\""},{"line_number":247,"context_line":"        try:"},{"line_number":248,"context_line":"            lookup \u003d task.driver.management.get_mac_addresses(task)"},{"line_number":249,"context_line":"            LOG.debug(\u0027get_mac_addresses is supported on node %s \u0027"},{"line_number":250,"context_line":"                      \u0027lookup\u003d%s\u0027, task.node.uuid, lookup)"},{"line_number":251,"context_line":"        except exception.UnsupportedDriverExtension:"},{"line_number":252,"context_line":"            lookup \u003d None"}],"source_content_type":"text/x-python","patch_set":8,"id":"1f621f24_65ceb25a","line":249,"updated":"2020-11-12 15:51:27.000000000","message":"Should be converted to a more user-friendly message before merging, something like:\n\n \"MAC addresses %(macs)s will be used for lookup for node %(node)s\"","commit_id":"343fe1ef4e3456351a863fcb2ea7605f4f9a59f7"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"e84055256bd4d4a22588b69dfdb7641bf96ca586","unresolved":false,"context_lines":[{"line_number":246,"context_line":"        \"\"\""},{"line_number":247,"context_line":"        try:"},{"line_number":248,"context_line":"            lookup \u003d task.driver.management.get_mac_addresses(task)"},{"line_number":249,"context_line":"            LOG.debug(\u0027get_mac_addresses is supported on node %s \u0027"},{"line_number":250,"context_line":"                      \u0027lookup\u003d%s\u0027, task.node.uuid, lookup)"},{"line_number":251,"context_line":"        except exception.UnsupportedDriverExtension:"},{"line_number":252,"context_line":"            lookup \u003d None"}],"source_content_type":"text/x-python","patch_set":8,"id":"1f621f24_9297b6ec","line":249,"in_reply_to":"1f621f24_65ceb25a","updated":"2020-11-18 04:39:41.000000000","message":"Done","commit_id":"343fe1ef4e3456351a863fcb2ea7605f4f9a59f7"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"605756e657eb668d6823fe117dae32ab604a6a9c","unresolved":true,"context_lines":[{"line_number":249,"context_line":"            if enabled_macs:"},{"line_number":250,"context_line":"                lookup_list \u003d [\"mac:\" + mac.lower() for mac in"},{"line_number":251,"context_line":"                               enabled_macs]"},{"line_number":252,"context_line":"                lookup \u003d \u0027,\u0027.join(lookup_list)"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"            LOG.debug(\u0027MAC addresses %s will be used for lookup for \u0027"},{"line_number":255,"context_line":"                      \u0027node %s\u0027, lookup, task.node.uuid)"}],"source_content_type":"text/x-python","patch_set":16,"id":"4cc5d3bf_d7ed82d5","line":252,"updated":"2020-11-30 22:44:05.000000000","message":"As I said in the openstacksdk change[1], I think lookup should be passed as a list here, so no need to join\n\n[1] https://review.opendev.org/c/openstack/openstacksdk/+/762603/2/openstack/baremetal_introspection/v1/_proxy.py#69","commit_id":"ffbf7f43177dc9637fcd5fc0f9e6e9d1b9aa00b4"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"f9dada0b10711ad5806b355b38fb57385502f790","unresolved":false,"context_lines":[{"line_number":249,"context_line":"            if enabled_macs:"},{"line_number":250,"context_line":"                lookup_list \u003d [\"mac:\" + mac.lower() for mac in"},{"line_number":251,"context_line":"                               enabled_macs]"},{"line_number":252,"context_line":"                lookup \u003d \u0027,\u0027.join(lookup_list)"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"            LOG.debug(\u0027MAC addresses %s will be used for lookup for \u0027"},{"line_number":255,"context_line":"                      \u0027node %s\u0027, lookup, task.node.uuid)"}],"source_content_type":"text/x-python","patch_set":16,"id":"b9d94a47_6e59a21d","line":252,"in_reply_to":"4cc5d3bf_d7ed82d5","updated":"2021-01-07 07:54:58.000000000","message":"Done","commit_id":"ffbf7f43177dc9637fcd5fc0f9e6e9d1b9aa00b4"}],"ironic/drivers/modules/redfish/management.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"87534ac78f6e22926f863da7dea267753422b1fb","unresolved":false,"context_lines":[{"line_number":677,"context_line":"                                \u0027component\u0027: component,"},{"line_number":678,"context_line":"                                \u0027uuid\u0027: task.node.uuid})"},{"line_number":679,"context_line":""},{"line_number":680,"context_line":"\u003c\u003c\u003c\u003c\u003c\u003c\u003c HEAD"},{"line_number":681,"context_line":"    @METRICS.timer(\u0027RedfishManagement.update_firmware\u0027)"},{"line_number":682,"context_line":"    @base.clean_step(priority\u003d0, abortable\u003dFalse, argsinfo\u003d{"},{"line_number":683,"context_line":"        \u0027firmware_images\u0027: {"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_e1c4e861","line":680,"updated":"2020-11-03 15:15:26.000000000","message":"pep8: E225 missing whitespace around operator","commit_id":"91ce2f2c463645e31a492673d758a532f0bc8516"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"87534ac78f6e22926f863da7dea267753422b1fb","unresolved":false,"context_lines":[{"line_number":677,"context_line":"                                \u0027component\u0027: component,"},{"line_number":678,"context_line":"                                \u0027uuid\u0027: task.node.uuid})"},{"line_number":679,"context_line":""},{"line_number":680,"context_line":"\u003c\u003c\u003c\u003c\u003c\u003c\u003c HEAD"},{"line_number":681,"context_line":"    @METRICS.timer(\u0027RedfishManagement.update_firmware\u0027)"},{"line_number":682,"context_line":"    @base.clean_step(priority\u003d0, abortable\u003dFalse, argsinfo\u003d{"},{"line_number":683,"context_line":"        \u0027firmware_images\u0027: {"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_01cac46b","line":680,"updated":"2020-11-03 15:15:26.000000000","message":"pep8: E227 missing whitespace around bitwise or shift operator","commit_id":"91ce2f2c463645e31a492673d758a532f0bc8516"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"87534ac78f6e22926f863da7dea267753422b1fb","unresolved":false,"context_lines":[{"line_number":677,"context_line":"                                \u0027component\u0027: component,"},{"line_number":678,"context_line":"                                \u0027uuid\u0027: task.node.uuid})"},{"line_number":679,"context_line":""},{"line_number":680,"context_line":"\u003c\u003c\u003c\u003c\u003c\u003c\u003c HEAD"},{"line_number":681,"context_line":"    @METRICS.timer(\u0027RedfishManagement.update_firmware\u0027)"},{"line_number":682,"context_line":"    @base.clean_step(priority\u003d0, abortable\u003dFalse, argsinfo\u003d{"},{"line_number":683,"context_line":"        \u0027firmware_images\u0027: {"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_c1cf2c7d","line":680,"updated":"2020-11-03 15:15:26.000000000","message":"pep8: E305 expected 2 blank lines after class or function definition, found 1","commit_id":"91ce2f2c463645e31a492673d758a532f0bc8516"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"87534ac78f6e22926f863da7dea267753422b1fb","unresolved":false,"context_lines":[{"line_number":677,"context_line":"                                \u0027component\u0027: component,"},{"line_number":678,"context_line":"                                \u0027uuid\u0027: task.node.uuid})"},{"line_number":679,"context_line":""},{"line_number":680,"context_line":"\u003c\u003c\u003c\u003c\u003c\u003c\u003c HEAD"},{"line_number":681,"context_line":"    @METRICS.timer(\u0027RedfishManagement.update_firmware\u0027)"},{"line_number":682,"context_line":"    @base.clean_step(priority\u003d0, abortable\u003dFalse, argsinfo\u003d{"},{"line_number":683,"context_line":"        \u0027firmware_images\u0027: {"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_a1caf06a","line":680,"updated":"2020-11-03 15:15:26.000000000","message":"pep8: E999 SyntaxError: invalid syntax","commit_id":"91ce2f2c463645e31a492673d758a532f0bc8516"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"87534ac78f6e22926f863da7dea267753422b1fb","unresolved":false,"context_lines":[{"line_number":678,"context_line":"                                \u0027uuid\u0027: task.node.uuid})"},{"line_number":679,"context_line":""},{"line_number":680,"context_line":"\u003c\u003c\u003c\u003c\u003c\u003c\u003c HEAD"},{"line_number":681,"context_line":"    @METRICS.timer(\u0027RedfishManagement.update_firmware\u0027)"},{"line_number":682,"context_line":"    @base.clean_step(priority\u003d0, abortable\u003dFalse, argsinfo\u003d{"},{"line_number":683,"context_line":"        \u0027firmware_images\u0027: {"},{"line_number":684,"context_line":"            \u0027description\u0027: ("}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_41a15ca9","line":681,"updated":"2020-11-03 15:15:26.000000000","message":"pep8: E113 unexpected indentation","commit_id":"91ce2f2c463645e31a492673d758a532f0bc8516"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7738b7a98827a01d51c4a885e6f6cf19bbc5f0a6","unresolved":false,"context_lines":[{"line_number":1014,"context_line":"        :returns: A list of MAC addresses for the node"},{"line_number":1015,"context_line":""},{"line_number":1016,"context_line":"        \"\"\""},{"line_number":1017,"context_line":"        try:"},{"line_number":1018,"context_line":"            LOG.debug(\"Attempting to fetch MAC address information for \""},{"line_number":1019,"context_line":"                      \"node %(node)s\", {\u0027node\u0027: task.node.uuid})"},{"line_number":1020,"context_line":"            system \u003d redfish_utils.get_system(task.node)"}],"source_content_type":"text/x-python","patch_set":8,"id":"1f621f24_c5d98622","line":1017,"updated":"2020-11-12 15:51:27.000000000","message":"This code nipped it probably duplicated in inspect.py, so maybe move it to redfish_utils?","commit_id":"343fe1ef4e3456351a863fcb2ea7605f4f9a59f7"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"3e9a7d7bbfe754dcfd49f8e2982f0cd0329e825b","unresolved":false,"context_lines":[{"line_number":1014,"context_line":"        :returns: A list of MAC addresses for the node"},{"line_number":1015,"context_line":""},{"line_number":1016,"context_line":"        \"\"\""},{"line_number":1017,"context_line":"        try:"},{"line_number":1018,"context_line":"            LOG.debug(\"Attempting to fetch MAC address information for \""},{"line_number":1019,"context_line":"                      \"node %(node)s\", {\u0027node\u0027: task.node.uuid})"},{"line_number":1020,"context_line":"            system \u003d redfish_utils.get_system(task.node)"}],"source_content_type":"text/x-python","patch_set":8,"id":"c52f0192_40825a2a","line":1017,"in_reply_to":"1f621f24_c5d98622","updated":"2020-11-24 12:01:05.000000000","message":"Done.","commit_id":"343fe1ef4e3456351a863fcb2ea7605f4f9a59f7"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e68c9e6575d534bc550fd6f2f30dbd4393109fbc","unresolved":false,"context_lines":[{"line_number":1019,"context_line":"        if enabled_macs:"},{"line_number":1020,"context_line":"            mac_lookup \u003d [\"mac:\" + mac.lower() for mac in enabled_macs]"},{"line_number":1021,"context_line":"            mac_lookup_string \u003d \u0027,\u0027.join(mac_lookup)"},{"line_number":1022,"context_line":"        return mac_lookup_string"}],"source_content_type":"text/x-python","patch_set":13,"id":"be9004d3_62601ab0","line":1022,"updated":"2020-11-24 14:34:54.000000000","message":"I\u0027d prefer we return a normal list from here to make it usable in the future. Let\u0027s handle the API format in inspector.py","commit_id":"1aec14d156a69f99db1ab4352ba8c9b72808c017"}]}