)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"39762888b7715e7e6bbc2549326bc5a244067cca","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: If713895f05f08a9827c4c085108abb3e388b2a2e"},{"line_number":14,"context_line":"Story: 2008118"},{"line_number":15,"context_line":"Task: 40839"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f560f44_0796d43e","line":15,"updated":"2020-09-10 16:56:00.000000000","message":"Please add that it Depends-On python-dracclient patch","commit_id":"0e94ba2c5d4cf163f540555b99ecc2659ed4bc39"},{"author":{"_account_id":32205,"name":"Mudit","email":"mudit.simlote@dell.com","username":"mudit-simlote"},"change_message_id":"2417a4876692bc2d2b7ab6d21956d41e76330026","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: If713895f05f08a9827c4c085108abb3e388b2a2e"},{"line_number":14,"context_line":"Story: 2008118"},{"line_number":15,"context_line":"Task: 40839"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f560f44_aa0a3675","line":15,"in_reply_to":"9f560f44_0796d43e","updated":"2020-09-11 15:06:35.000000000","message":"Done","commit_id":"0e94ba2c5d4cf163f540555b99ecc2659ed4bc39"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"894881e42bddef01979b4bb0785baaeb84298254","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Mudit \u003cmudit.simlote@dell.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-09-23 10:20:10 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Implement reporting GPU devices in iDRAC driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch implements reporting number of NVIDIA Tesla T4"},{"line_number":10,"context_line":"devices present on a server by discovering such devices"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9f560f44_cc969d94","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":47},"updated":"2020-09-27 08:08:09.000000000","message":"To be clear, it adds it to the \u0027idrac-wsman\u0027 inspect hardware interface implementation. That is an important distinction, because the \u0027idrac-redfish\u0027 inspect hardware interface implementation does not presently offer this support.\n\nA suggestion:\n\n    Add GPU reporting to idrac-wsman inspect interface","commit_id":"38c84a7fd19e1c2e3ebd6be5ae6d6c589273492a"},{"author":{"_account_id":32205,"name":"Mudit","email":"mudit.simlote@dell.com","username":"mudit-simlote"},"change_message_id":"f35ce40324117bd64f9fc7e0c5a6fe09b6f921e4","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Mudit \u003cmudit.simlote@dell.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-09-23 10:20:10 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Implement reporting GPU devices in iDRAC driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch implements reporting number of NVIDIA Tesla T4"},{"line_number":10,"context_line":"devices present on a server by discovering such devices"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9f560f44_89ee521e","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":47},"in_reply_to":"9f560f44_cc969d94","updated":"2020-09-28 13:48:57.000000000","message":"Done","commit_id":"38c84a7fd19e1c2e3ebd6be5ae6d6c589273492a"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"f61e78985f34f1cf84383aaaf7772389f1077405","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add GPU reporting to idrac-wsman inspect interface"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch implements reporting number of NVIDIA Tesla T4"},{"line_number":10,"context_line":"devices present on a server by discovering such devices"},{"line_number":11,"context_line":"and reporting them through capability \u0027pci_gpu_devices\u0027"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: If713895f05f08a9827c4c085108abb3e388b2a2e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9f560f44_0becedf2","line":10,"range":{"start_line":10,"start_character":8,"end_line":10,"end_character":27},"updated":"2020-09-28 16:45:10.000000000","message":"nit: To be consistent with the documnetation,\n\n    connected to a system","commit_id":"72b94adb365baa91120cc40a2cc64c42ccf23476"},{"author":{"_account_id":32205,"name":"Mudit","email":"mudit.simlote@dell.com","username":"mudit-simlote"},"change_message_id":"7644925d05e19cad0d8fc754528e7577462449ca","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch implements reporting number of NVIDIA Tesla T4"},{"line_number":10,"context_line":"devices connected to a system by discovering such devices"},{"line_number":11,"context_line":"and reporting them through capability \u0027pci_gpu_devices\u0027"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: If713895f05f08a9827c4c085108abb3e388b2a2e"},{"line_number":14,"context_line":"Story: 2008118"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9f560f44_c3b3ec99","line":11,"range":{"start_line":11,"start_character":39,"end_line":11,"end_character":54},"updated":"2020-09-29 16:17:49.000000000","message":"Add a period at the end","commit_id":"9c1fc06b437e44e6c6ed6d056991d99666811f36"}],"doc/source/admin/drivers/idrac.rst":[{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"f61e78985f34f1cf84383aaaf7772389f1077405","unresolved":false,"context_lines":[{"line_number":257,"context_line":"Extra capabilities:"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"* ``boot_mode``: UEFI or BIOS boot mode."},{"line_number":260,"context_line":"* ``pci_gpu_devices``: number of gpu devices connected to the bare metal."},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"It also creates baremetal ports for each NIC port detected in the system."},{"line_number":263,"context_line":"The ``idrac-wsman`` inspect interface discovers which NIC ports are"}],"source_content_type":"text/x-rst","patch_set":6,"id":"9f560f44_c01c9416","line":260,"range":{"start_line":260,"start_character":33,"end_line":260,"end_character":36},"updated":"2020-09-28 16:45:10.000000000","message":"nit: GPU, all capitalized","commit_id":"72b94adb365baa91120cc40a2cc64c42ccf23476"}],"ironic/drivers/modules/drac/inspect.py":[{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"39762888b7715e7e6bbc2549326bc5a244067cca","unresolved":false,"context_lines":[{"line_number":196,"context_line":"    def _calculate_gpus(self, gpus):"},{"line_number":197,"context_line":"        \"\"\"Find actual Tesla T4 GPU count."},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"        :param gpus: Pass gpus."},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"        :returns: returns total gpu count."},{"line_number":202,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_27ccb85f","line":199,"range":{"start_line":199,"start_character":21,"end_line":199,"end_character":31},"updated":"2020-09-10 16:56:00.000000000","message":"Comment not clear, suggesting \"List of video controllers\"","commit_id":"0e94ba2c5d4cf163f540555b99ecc2659ed4bc39"},{"author":{"_account_id":32205,"name":"Mudit","email":"mudit.simlote@dell.com","username":"mudit-simlote"},"change_message_id":"2417a4876692bc2d2b7ab6d21956d41e76330026","unresolved":false,"context_lines":[{"line_number":196,"context_line":"    def _calculate_gpus(self, gpus):"},{"line_number":197,"context_line":"        \"\"\"Find actual Tesla T4 GPU count."},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"        :param gpus: Pass gpus."},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"        :returns: returns total gpu count."},{"line_number":202,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_ea270e11","line":199,"range":{"start_line":199,"start_character":21,"end_line":199,"end_character":31},"in_reply_to":"9f560f44_27ccb85f","updated":"2020-09-11 15:06:35.000000000","message":"Done","commit_id":"0e94ba2c5d4cf163f540555b99ecc2659ed4bc39"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"aeb52ad95d22417810a0a8fda499e2b864b189a8","unresolved":false,"context_lines":[{"line_number":196,"context_line":"    def _calculate_gpus(self, gpus):"},{"line_number":197,"context_line":"        \"\"\"Find actual Tesla T4 GPU count."},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"        :param gpus: Pass gpus."},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"        :returns: returns total gpu count."},{"line_number":202,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_a8407e07","line":199,"range":{"start_line":199,"start_character":21,"end_line":199,"end_character":31},"in_reply_to":"9f560f44_ea270e11","updated":"2020-09-11 16:09:54.000000000","message":"now the comment reads like video_controllers are video_controllers. I suggest to still include \"list\" to denote the datatype as it\u0027s not so clear in Python and use human-readable description of parameter (meaning no _). If \"Pass\" means \"pass video_controllers to this method\", then I\u0027d leave it out as that\u0027s implicit that all params are passed.","commit_id":"0e94ba2c5d4cf163f540555b99ecc2659ed4bc39"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"39762888b7715e7e6bbc2549326bc5a244067cca","unresolved":false,"context_lines":[{"line_number":200,"context_line":""},{"line_number":201,"context_line":"        :returns: returns total gpu count."},{"line_number":202,"context_line":"        \"\"\""},{"line_number":203,"context_line":"        gpu_cnt \u003d 0"},{"line_number":204,"context_line":"        for gpu in gpus:"},{"line_number":205,"context_line":"            if gpu.description \u003d\u003d \"TU104GL [Tesla T4]\":"},{"line_number":206,"context_line":"                gpu_cnt +\u003d 1"},{"line_number":207,"context_line":"        return gpu_cnt"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    def _get_pxe_dev_nics(self, client, nics, node):"},{"line_number":210,"context_line":"        \"\"\"Get a list of pxe device interfaces."}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_1546fa21","line":207,"range":{"start_line":203,"start_character":0,"end_line":207,"end_character":22},"updated":"2020-09-10 16:56:00.000000000","message":"maybe this is shorter (and then don\u0027t need a private method?): \n\n  sum(1 for gpu in gpus if gpu.description \u003d\u003d \"TU104GL [Tesla T4]\")","commit_id":"0e94ba2c5d4cf163f540555b99ecc2659ed4bc39"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"aeb52ad95d22417810a0a8fda499e2b864b189a8","unresolved":false,"context_lines":[{"line_number":200,"context_line":""},{"line_number":201,"context_line":"        :returns: returns total gpu count."},{"line_number":202,"context_line":"        \"\"\""},{"line_number":203,"context_line":"        gpu_cnt \u003d 0"},{"line_number":204,"context_line":"        for gpu in gpus:"},{"line_number":205,"context_line":"            if gpu.description \u003d\u003d \"TU104GL [Tesla T4]\":"},{"line_number":206,"context_line":"                gpu_cnt +\u003d 1"},{"line_number":207,"context_line":"        return gpu_cnt"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    def _get_pxe_dev_nics(self, client, nics, node):"},{"line_number":210,"context_line":"        \"\"\"Get a list of pxe device interfaces."}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_88d2da5a","line":207,"range":{"start_line":203,"start_character":0,"end_line":207,"end_character":22},"in_reply_to":"9f560f44_0a6ec22a","updated":"2020-09-11 16:09:54.000000000","message":"not a big deal as it is now, I\u0027d prefer to have what is needed now as in future code will be changed anyway and adjusted as needed then. This is private method so it can be added/updated/removed as necessary as no backward compability needed.","commit_id":"0e94ba2c5d4cf163f540555b99ecc2659ed4bc39"},{"author":{"_account_id":32205,"name":"Mudit","email":"mudit.simlote@dell.com","username":"mudit-simlote"},"change_message_id":"2417a4876692bc2d2b7ab6d21956d41e76330026","unresolved":false,"context_lines":[{"line_number":200,"context_line":""},{"line_number":201,"context_line":"        :returns: returns total gpu count."},{"line_number":202,"context_line":"        \"\"\""},{"line_number":203,"context_line":"        gpu_cnt \u003d 0"},{"line_number":204,"context_line":"        for gpu in gpus:"},{"line_number":205,"context_line":"            if gpu.description \u003d\u003d \"TU104GL [Tesla T4]\":"},{"line_number":206,"context_line":"                gpu_cnt +\u003d 1"},{"line_number":207,"context_line":"        return gpu_cnt"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    def _get_pxe_dev_nics(self, client, nics, node):"},{"line_number":210,"context_line":"        \"\"\"Get a list of pxe device interfaces."}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_0a6ec22a","line":207,"range":{"start_line":203,"start_character":0,"end_line":207,"end_character":22},"in_reply_to":"9f560f44_1546fa21","updated":"2020-09-11 15:06:35.000000000","message":"Had added a private method for this as it may evolve independently and handling internal details like which GPUs to report or not can be hidden in the method. Let me know your thoughts","commit_id":"0e94ba2c5d4cf163f540555b99ecc2659ed4bc39"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"894881e42bddef01979b4bb0785baaeb84298254","unresolved":false,"context_lines":[{"line_number":194,"context_line":"            return cpu.cores"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"    def _calculate_gpus(self, video_controllers):"},{"line_number":197,"context_line":"        \"\"\"Find actual Tesla T4 GPU count."},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"        :param video_controllers: list of video controllers."},{"line_number":200,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_2c4f596a","line":197,"range":{"start_line":197,"start_character":23,"end_line":197,"end_character":31},"updated":"2020-09-27 08:08:09.000000000","message":"nit: Perhaps this could be left out of the summary and added immediately below in the presently empty detailed description of the method. It is a detail that it is presently limited to counting Tesla T4s.","commit_id":"38c84a7fd19e1c2e3ebd6be5ae6d6c589273492a"},{"author":{"_account_id":32205,"name":"Mudit","email":"mudit.simlote@dell.com","username":"mudit-simlote"},"change_message_id":"f35ce40324117bd64f9fc7e0c5a6fe09b6f921e4","unresolved":false,"context_lines":[{"line_number":194,"context_line":"            return cpu.cores"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"    def _calculate_gpus(self, video_controllers):"},{"line_number":197,"context_line":"        \"\"\"Find actual Tesla T4 GPU count."},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"        :param video_controllers: list of video controllers."},{"line_number":200,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_69f13e00","line":197,"range":{"start_line":197,"start_character":23,"end_line":197,"end_character":31},"in_reply_to":"9f560f44_2c4f596a","updated":"2020-09-28 13:48:57.000000000","message":"Done","commit_id":"38c84a7fd19e1c2e3ebd6be5ae6d6c589273492a"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"894881e42bddef01979b4bb0785baaeb84298254","unresolved":false,"context_lines":[{"line_number":202,"context_line":"        \"\"\""},{"line_number":203,"context_line":"        gpu_cnt \u003d 0"},{"line_number":204,"context_line":"        for video_controller in video_controllers:"},{"line_number":205,"context_line":"            if video_controller.description \u003d\u003d \"TU104GL [Tesla T4]\":"},{"line_number":206,"context_line":"                gpu_cnt +\u003d 1"},{"line_number":207,"context_line":"        return gpu_cnt"},{"line_number":208,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_0c31b5ed","line":205,"range":{"start_line":205,"start_character":47,"end_line":205,"end_character":67},"updated":"2020-09-27 08:08:09.000000000","message":"Seems like this should be a constant.","commit_id":"38c84a7fd19e1c2e3ebd6be5ae6d6c589273492a"},{"author":{"_account_id":32205,"name":"Mudit","email":"mudit.simlote@dell.com","username":"mudit-simlote"},"change_message_id":"f35ce40324117bd64f9fc7e0c5a6fe09b6f921e4","unresolved":false,"context_lines":[{"line_number":202,"context_line":"        \"\"\""},{"line_number":203,"context_line":"        gpu_cnt \u003d 0"},{"line_number":204,"context_line":"        for video_controller in video_controllers:"},{"line_number":205,"context_line":"            if video_controller.description \u003d\u003d \"TU104GL [Tesla T4]\":"},{"line_number":206,"context_line":"                gpu_cnt +\u003d 1"},{"line_number":207,"context_line":"        return gpu_cnt"},{"line_number":208,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_c9db2a7a","line":205,"range":{"start_line":205,"start_character":47,"end_line":205,"end_character":67},"in_reply_to":"9f560f44_0c31b5ed","updated":"2020-09-28 13:48:57.000000000","message":"Done","commit_id":"38c84a7fd19e1c2e3ebd6be5ae6d6c589273492a"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"f61e78985f34f1cf84383aaaf7772389f1077405","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"class DracWSManInspect(base.InspectInterface):"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    _GPU_DESCRIPTION \u003d \"TU104GL [Tesla T4]\""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def get_properties(self):"},{"line_number":55,"context_line":"        \"\"\"Return the properties of the interface."}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_1abc39da","line":52,"range":{"start_line":52,"start_character":4,"end_line":52,"end_character":20},"updated":"2020-09-28 16:45:10.000000000","message":"Let us change the name to\n\n    _GPU_DESCRIPTION_NVIDIA_TESLA_T4\n\nOver time, I expect more will be added :)","commit_id":"72b94adb365baa91120cc40a2cc64c42ccf23476"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"f61e78985f34f1cf84383aaaf7772389f1077405","unresolved":false,"context_lines":[{"line_number":208,"context_line":"        gpu_cnt \u003d 0"},{"line_number":209,"context_line":"        for video_controller in video_controllers:"},{"line_number":210,"context_line":"            if video_controller.description \u003d\u003d \\"},{"line_number":211,"context_line":"                    DracWSManInspect._GPU_DESCRIPTION:"},{"line_number":212,"context_line":"                gpu_cnt +\u003d 1"},{"line_number":213,"context_line":"        return gpu_cnt"},{"line_number":214,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_fac4e562","line":211,"range":{"start_line":211,"start_character":20,"end_line":211,"end_character":36},"updated":"2020-09-28 16:45:10.000000000","message":"Please use \u0027self\u0027, instead of the class name, as follows:\n\n    self._GPU_DESCRIPTION_NVIDIA_TESLA_T4","commit_id":"72b94adb365baa91120cc40a2cc64c42ccf23476"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"3cd6139d2ebf9770845b9faeefb79978e1d03b51","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"class DracWSManInspect(base.InspectInterface):"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    _GPU_DESCRIPTION_NVIDIA_TESLA_T4 \u003d \"TU104GL [Tesla T4]\""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def get_properties(self):"},{"line_number":55,"context_line":"        \"\"\"Return the properties of the interface."}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_a6fb7846","line":52,"range":{"start_line":52,"start_character":0,"end_line":52,"end_character":59},"updated":"2020-09-28 18:05:23.000000000","message":"This seems like it is only goign to be good as functionality for the Tesla T4 cards. Any plan to make this easier to extend?","commit_id":"9c1fc06b437e44e6c6ed6d056991d99666811f36"},{"author":{"_account_id":32205,"name":"Mudit","email":"mudit.simlote@dell.com","username":"mudit-simlote"},"change_message_id":"7e890aa9221231c7412b38fbd6d206f56a4d5ebe","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"class DracWSManInspect(base.InspectInterface):"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    _GPU_DESCRIPTION_NVIDIA_TESLA_T4 \u003d \"TU104GL [Tesla T4]\""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def get_properties(self):"},{"line_number":55,"context_line":"        \"\"\"Return the properties of the interface."}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_e8151b4e","line":52,"range":{"start_line":52,"start_character":0,"end_line":52,"end_character":59},"in_reply_to":"9f560f44_a6fb7846","updated":"2020-09-30 13:59:12.000000000","message":"Yes, there is plan to extend to other GPUs. So made it a list for now which will get enhanced with other GPU descriptions as and when supported","commit_id":"9c1fc06b437e44e6c6ed6d056991d99666811f36"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"3cd6139d2ebf9770845b9faeefb79978e1d03b51","unresolved":false,"context_lines":[{"line_number":205,"context_line":""},{"line_number":206,"context_line":"        :returns: returns total gpu count."},{"line_number":207,"context_line":"        \"\"\""},{"line_number":208,"context_line":"        gpu_cnt \u003d 0"},{"line_number":209,"context_line":"        for video_controller in video_controllers:"},{"line_number":210,"context_line":"            if video_controller.description \u003d\u003d \\"},{"line_number":211,"context_line":"                    self._GPU_DESCRIPTION_NVIDIA_TESLA_T4:"},{"line_number":212,"context_line":"                gpu_cnt +\u003d 1"},{"line_number":213,"context_line":"        return gpu_cnt"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"    def _get_pxe_dev_nics(self, client, nics, node):"},{"line_number":216,"context_line":"        \"\"\"Get a list of pxe device interfaces."}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_669fa002","line":213,"range":{"start_line":208,"start_character":0,"end_line":213,"end_character":22},"updated":"2020-09-28 18:05:23.000000000","message":"Would it make sense to try for AttributeError.\n\nIn other words, if client.list_video_controllers does NOT return a list of objects and returns an empty list, or a list of None?","commit_id":"9c1fc06b437e44e6c6ed6d056991d99666811f36"},{"author":{"_account_id":32205,"name":"Mudit","email":"mudit.simlote@dell.com","username":"mudit-simlote"},"change_message_id":"7644925d05e19cad0d8fc754528e7577462449ca","unresolved":false,"context_lines":[{"line_number":205,"context_line":""},{"line_number":206,"context_line":"        :returns: returns total gpu count."},{"line_number":207,"context_line":"        \"\"\""},{"line_number":208,"context_line":"        gpu_cnt \u003d 0"},{"line_number":209,"context_line":"        for video_controller in video_controllers:"},{"line_number":210,"context_line":"            if video_controller.description \u003d\u003d \\"},{"line_number":211,"context_line":"                    self._GPU_DESCRIPTION_NVIDIA_TESLA_T4:"},{"line_number":212,"context_line":"                gpu_cnt +\u003d 1"},{"line_number":213,"context_line":"        return gpu_cnt"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"    def _get_pxe_dev_nics(self, client, nics, node):"},{"line_number":216,"context_line":"        \"\"\"Get a list of pxe device interfaces."}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_7e96f3a2","line":213,"range":{"start_line":208,"start_character":0,"end_line":213,"end_character":22},"in_reply_to":"9f560f44_669fa002","updated":"2020-09-29 16:17:49.000000000","message":"python-dracclient returns an empty list [] for a case with no entries, and also this function was modelled on other similar functions doing similar parsing. Can you let me know, if I am missing something here","commit_id":"9c1fc06b437e44e6c6ed6d056991d99666811f36"}],"ironic/tests/unit/drivers/modules/drac/test_inspect.py":[{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"894881e42bddef01979b4bb0785baaeb84298254","unresolved":false,"context_lines":[{"line_number":271,"context_line":"                                  shared\u003dTrue) as task:"},{"line_number":272,"context_line":"            self.assertRaises(exception.HardwareInspectionFailure,"},{"line_number":273,"context_line":"                              task.driver.inspect.inspect_hardware, task)"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"    @mock.patch.object(drac_common, \u0027get_drac_client\u0027, spec_set\u003dTrue,"},{"line_number":276,"context_line":"                       autospec\u003dTrue)"},{"line_number":277,"context_line":"    @mock.patch.object(objects.Port, \u0027create\u0027, spec_set\u003dTrue, autospec\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_6c6e71c8","line":274,"updated":"2020-09-27 08:08:09.000000000","message":"Is there a test for no GPUs? If not, please add it, since most systems do not have a GPU.","commit_id":"38c84a7fd19e1c2e3ebd6be5ae6d6c589273492a"},{"author":{"_account_id":32205,"name":"Mudit","email":"mudit.simlote@dell.com","username":"mudit-simlote"},"change_message_id":"f35ce40324117bd64f9fc7e0c5a6fe09b6f921e4","unresolved":false,"context_lines":[{"line_number":271,"context_line":"                                  shared\u003dTrue) as task:"},{"line_number":272,"context_line":"            self.assertRaises(exception.HardwareInspectionFailure,"},{"line_number":273,"context_line":"                              task.driver.inspect.inspect_hardware, task)"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"    @mock.patch.object(drac_common, \u0027get_drac_client\u0027, spec_set\u003dTrue,"},{"line_number":276,"context_line":"                       autospec\u003dTrue)"},{"line_number":277,"context_line":"    @mock.patch.object(objects.Port, \u0027create\u0027, spec_set\u003dTrue, autospec\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_09e24230","line":274,"in_reply_to":"9f560f44_6c6e71c8","updated":"2020-09-28 13:48:57.000000000","message":"Done","commit_id":"38c84a7fd19e1c2e3ebd6be5ae6d6c589273492a"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"3cd6139d2ebf9770845b9faeefb79978e1d03b51","unresolved":false,"context_lines":[{"line_number":188,"context_line":"        mock_client.list_virtual_disks.return_value \u003d self.virtual_disks"},{"line_number":189,"context_line":"        mock_client.list_nics.return_value \u003d self.nics"},{"line_number":190,"context_line":"        mock_client.list_bios_settings.return_value \u003d self.uefi_boot_settings"},{"line_number":191,"context_line":"        mock_client.list_video_controllers.return_value \u003d\\"},{"line_number":192,"context_line":"            self.video_controllers"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"        with task_manager.acquire(self.context, self.node.uuid,"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_8668f4f4","line":191,"updated":"2020-09-28 18:05:23.000000000","message":"nit, if you could add a space that would be nice. We\u0027d prefer if there was any way to not wrap the line this way, but you do have some long names your having to emulate with mock :)","commit_id":"9c1fc06b437e44e6c6ed6d056991d99666811f36"}],"releasenotes/notes/idrac-add-gpu-reporting-support-f4d80e2071f85f6a.yaml":[{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"aeb52ad95d22417810a0a8fda499e2b864b189a8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    This patch implements support in iDRAC driver for reporting number of "},{"line_number":5,"context_line":"    GPU devices present on a server. This information is advertised through "},{"line_number":6,"context_line":"    capability \u0027pci_gpu_devices\u0027 which can be used to make scheduling decisions"},{"line_number":7,"context_line":"    for the node. Currently, only NVIDIA Tesla T4 GPU devices are reported and"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9f560f44_c8a7b2bb","line":4,"range":{"start_line":4,"start_character":73,"end_line":4,"end_character":74},"updated":"2020-09-11 16:09:54.000000000","message":"nit: whitespaces at the end of file here and below","commit_id":"d7e16affe9e0bc5b19173c1a5ffa053790806841"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"aeb52ad95d22417810a0a8fda499e2b864b189a8","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    GPU devices present on a server. This information is advertised through "},{"line_number":6,"context_line":"    capability \u0027pci_gpu_devices\u0027 which can be used to make scheduling decisions"},{"line_number":7,"context_line":"    for the node. Currently, only NVIDIA Tesla T4 GPU devices are reported and"},{"line_number":8,"context_line":"    other device type reporting will be supported in the future"},{"line_number":9,"context_line":"issues:"},{"line_number":10,"context_line":"  - |"},{"line_number":11,"context_line":"    The pci_gpu_devices reporting may not work correctly on 13G server and may "}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9f560f44_e8f396e5","line":8,"updated":"2020-09-11 16:09:54.000000000","message":"nit: dot at the end of the sentence.","commit_id":"d7e16affe9e0bc5b19173c1a5ffa053790806841"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"894881e42bddef01979b4bb0785baaeb84298254","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    This patch implements support in iDRAC driver for reporting number of"},{"line_number":5,"context_line":"    GPU devices present on a server. This information is advertised through"},{"line_number":6,"context_line":"    capability \u0027pci_gpu_devices\u0027 which can be used to make scheduling decisions"},{"line_number":7,"context_line":"    for the node. Currently, only NVIDIA Tesla T4 GPU devices are reported and"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f560f44_ccadfdea","line":4,"range":{"start_line":4,"start_character":37,"end_line":4,"end_character":49},"updated":"2020-09-27 08:08:09.000000000","message":"To be clear, it adds it to the ``idrac-wsman`` (note the \nreStructuredText markup backticks) inspect hardware interface implementation. That is an important distinction, because the \u0027idrac-redfish\u0027 inspect hardware interface implementation does not presently offer this support.","commit_id":"38c84a7fd19e1c2e3ebd6be5ae6d6c589273492a"},{"author":{"_account_id":32205,"name":"Mudit","email":"mudit.simlote@dell.com","username":"mudit-simlote"},"change_message_id":"f35ce40324117bd64f9fc7e0c5a6fe09b6f921e4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    This patch implements support in iDRAC driver for reporting number of"},{"line_number":5,"context_line":"    GPU devices present on a server. This information is advertised through"},{"line_number":6,"context_line":"    capability \u0027pci_gpu_devices\u0027 which can be used to make scheduling decisions"},{"line_number":7,"context_line":"    for the node. Currently, only NVIDIA Tesla T4 GPU devices are reported and"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f560f44_e9dc2e72","line":4,"range":{"start_line":4,"start_character":37,"end_line":4,"end_character":49},"in_reply_to":"9f560f44_ccadfdea","updated":"2020-09-28 13:48:57.000000000","message":"Done","commit_id":"38c84a7fd19e1c2e3ebd6be5ae6d6c589273492a"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"894881e42bddef01979b4bb0785baaeb84298254","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    This patch implements support in iDRAC driver for reporting number of"},{"line_number":5,"context_line":"    GPU devices present on a server. This information is advertised through"},{"line_number":6,"context_line":"    capability \u0027pci_gpu_devices\u0027 which can be used to make scheduling decisions"},{"line_number":7,"context_line":"    for the node. Currently, only NVIDIA Tesla T4 GPU devices are reported and"},{"line_number":8,"context_line":"    other device type reporting will be supported in the future."},{"line_number":9,"context_line":"issues:"},{"line_number":10,"context_line":"  - |"},{"line_number":11,"context_line":"    The pci_gpu_devices reporting may not work correctly on 13G server and may"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f560f44_2c9d99ba","line":8,"range":{"start_line":7,"start_character":74,"end_line":8,"end_character":63},"updated":"2020-09-27 08:08:09.000000000","message":"Please remove this. It seems to me commitments should not be made in a release note :)","commit_id":"38c84a7fd19e1c2e3ebd6be5ae6d6c589273492a"},{"author":{"_account_id":32205,"name":"Mudit","email":"mudit.simlote@dell.com","username":"mudit-simlote"},"change_message_id":"f35ce40324117bd64f9fc7e0c5a6fe09b6f921e4","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    This patch implements support in iDRAC driver for reporting number of"},{"line_number":5,"context_line":"    GPU devices present on a server. This information is advertised through"},{"line_number":6,"context_line":"    capability \u0027pci_gpu_devices\u0027 which can be used to make scheduling decisions"},{"line_number":7,"context_line":"    for the node. Currently, only NVIDIA Tesla T4 GPU devices are reported and"},{"line_number":8,"context_line":"    other device type reporting will be supported in the future."},{"line_number":9,"context_line":"issues:"},{"line_number":10,"context_line":"  - |"},{"line_number":11,"context_line":"    The pci_gpu_devices reporting may not work correctly on 13G server and may"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f560f44_49d1da56","line":8,"range":{"start_line":7,"start_character":74,"end_line":8,"end_character":63},"in_reply_to":"9f560f44_2c9d99ba","updated":"2020-09-28 13:48:57.000000000","message":"Done","commit_id":"38c84a7fd19e1c2e3ebd6be5ae6d6c589273492a"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"894881e42bddef01979b4bb0785baaeb84298254","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    other device type reporting will be supported in the future."},{"line_number":9,"context_line":"issues:"},{"line_number":10,"context_line":"  - |"},{"line_number":11,"context_line":"    The pci_gpu_devices reporting may not work correctly on 13G server and may"},{"line_number":12,"context_line":"    produce incorrect results"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f560f44_6ca31100","line":11,"range":{"start_line":11,"start_character":60,"end_line":11,"end_character":70},"updated":"2020-09-27 08:08:09.000000000","message":"I believe they are now referred to as \"Dell EMC 13th Generation systems\". AFAIU, \u002713G\u0027 is no longer in vogue.","commit_id":"38c84a7fd19e1c2e3ebd6be5ae6d6c589273492a"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"894881e42bddef01979b4bb0785baaeb84298254","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    other device type reporting will be supported in the future."},{"line_number":9,"context_line":"issues:"},{"line_number":10,"context_line":"  - |"},{"line_number":11,"context_line":"    The pci_gpu_devices reporting may not work correctly on 13G server and may"},{"line_number":12,"context_line":"    produce incorrect results"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f560f44_8ca025f5","line":11,"range":{"start_line":11,"start_character":8,"end_line":11,"end_character":23},"updated":"2020-09-27 08:08:09.000000000","message":"``pci_gpu_devices``","commit_id":"38c84a7fd19e1c2e3ebd6be5ae6d6c589273492a"},{"author":{"_account_id":32205,"name":"Mudit","email":"mudit.simlote@dell.com","username":"mudit-simlote"},"change_message_id":"f35ce40324117bd64f9fc7e0c5a6fe09b6f921e4","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    other device type reporting will be supported in the future."},{"line_number":9,"context_line":"issues:"},{"line_number":10,"context_line":"  - |"},{"line_number":11,"context_line":"    The pci_gpu_devices reporting may not work correctly on 13G server and may"},{"line_number":12,"context_line":"    produce incorrect results"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f560f44_29d46646","line":11,"range":{"start_line":11,"start_character":8,"end_line":11,"end_character":23},"in_reply_to":"9f560f44_8ca025f5","updated":"2020-09-28 13:48:57.000000000","message":"Done","commit_id":"38c84a7fd19e1c2e3ebd6be5ae6d6c589273492a"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"d13f26d3ff1a80ea17c49accd1cdcd6ce83b5a30","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    This patch implements support in \"idrac-wsman\" inspect hardware interface"},{"line_number":5,"context_line":"    for reporting number of GPU devices present on a server. This information"},{"line_number":6,"context_line":"    is advertised through capability \"pci_gpu_devices\" which can be used to"},{"line_number":7,"context_line":"    make scheduling decisions for the node. Currently, only NVIDIA Tesla T4 GPU"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_104fff69","line":4,"range":{"start_line":4,"start_character":37,"end_line":4,"end_character":50},"updated":"2020-09-28 12:08:09.000000000","message":"here and below, double quotes (\") should be replaced with 2 backticks (``) so it renders monospace in bold.\n\nCheck how this message is rendered at https://api.us-east.open-edge.io:8080/swift/v1/AUTH_e02c11e4e2c24efc98022353c88ab506/zuul_opendev_logs_827/751006/4/check/build-openstack-releasenotes/8272cce/docs/unreleased.html\nand how it compares to other ones.","commit_id":"e3288b2787eca2c0359406888c667de8181df157"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"d13f26d3ff1a80ea17c49accd1cdcd6ce83b5a30","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    This patch implements support in \"idrac-wsman\" inspect hardware interface"},{"line_number":5,"context_line":"    for reporting number of GPU devices present on a server. This information"},{"line_number":6,"context_line":"    is advertised through capability \"pci_gpu_devices\" which can be used to"},{"line_number":7,"context_line":"    make scheduling decisions for the node. Currently, only NVIDIA Tesla T4 GPU"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_d040e734","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":25},"updated":"2020-09-28 12:08:09.000000000","message":"in context or release notes when they are read \"This patch implements\" should be replaced with \"Adds\"","commit_id":"e3288b2787eca2c0359406888c667de8181df157"},{"author":{"_account_id":32205,"name":"Mudit","email":"mudit.simlote@dell.com","username":"mudit-simlote"},"change_message_id":"baebb085cacbc54f5a35a0e9388edd7cf06681bb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    This patch implements support in \"idrac-wsman\" inspect hardware interface"},{"line_number":5,"context_line":"    for reporting number of GPU devices present on a server. This information"},{"line_number":6,"context_line":"    is advertised through capability \"pci_gpu_devices\" which can be used to"},{"line_number":7,"context_line":"    make scheduling decisions for the node. Currently, only NVIDIA Tesla T4 GPU"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_0b1cf274","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":25},"in_reply_to":"9f560f44_d040e734","updated":"2020-09-28 14:47:29.000000000","message":"Done","commit_id":"e3288b2787eca2c0359406888c667de8181df157"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"f61e78985f34f1cf84383aaaf7772389f1077405","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds support in ``idrac-wsman`` inspect hardware interface for reporting"},{"line_number":5,"context_line":"    number of GPU devices present on a server. This information is advertised"},{"line_number":6,"context_line":"    through capability ``pci_gpu_devices`` which can be used to make scheduling"},{"line_number":7,"context_line":"    decisions for the node. Currently, only NVIDIA Tesla T4 GPU devices are"},{"line_number":8,"context_line":"    reported."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9f560f44_9a75e936","line":5,"range":{"start_line":5,"start_character":26,"end_line":5,"end_character":36},"updated":"2020-09-28 16:45:10.000000000","message":"The documentation change describes this as \"connected to\". If that is the way we want to describe it, let us change it here to be consistent with the documentation.\n\n    ... number of GPU devices connected to a system ...","commit_id":"72b94adb365baa91120cc40a2cc64c42ccf23476"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"f61e78985f34f1cf84383aaaf7772389f1077405","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds support in ``idrac-wsman`` inspect hardware interface for reporting"},{"line_number":5,"context_line":"    number of GPU devices present on a server. This information is advertised"},{"line_number":6,"context_line":"    through capability ``pci_gpu_devices`` which can be used to make scheduling"},{"line_number":7,"context_line":"    decisions for the node. Currently, only NVIDIA Tesla T4 GPU devices are"},{"line_number":8,"context_line":"    reported."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9f560f44_4bcee58f","line":5,"range":{"start_line":5,"start_character":39,"end_line":5,"end_character":45},"updated":"2020-09-28 16:45:10.000000000","message":"nit: s/server/system/","commit_id":"72b94adb365baa91120cc40a2cc64c42ccf23476"},{"author":{"_account_id":32205,"name":"Mudit","email":"mudit.simlote@dell.com","username":"mudit-simlote"},"change_message_id":"5b70749ee5a246423507099f444680c264dcea3e","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds support in ``idrac-wsman`` inspect hardware interface for reporting"},{"line_number":5,"context_line":"    number of GPU devices present on a server. This information is advertised"},{"line_number":6,"context_line":"    through capability ``pci_gpu_devices`` which can be used to make scheduling"},{"line_number":7,"context_line":"    decisions for the node. Currently, only NVIDIA Tesla T4 GPU devices are"},{"line_number":8,"context_line":"    reported."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9f560f44_8b411d67","line":5,"range":{"start_line":5,"start_character":26,"end_line":5,"end_character":36},"in_reply_to":"9f560f44_9a75e936","updated":"2020-09-28 17:16:10.000000000","message":"Done","commit_id":"72b94adb365baa91120cc40a2cc64c42ccf23476"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"f61e78985f34f1cf84383aaaf7772389f1077405","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds support in ``idrac-wsman`` inspect hardware interface for reporting"},{"line_number":5,"context_line":"    number of GPU devices present on a server. This information is advertised"},{"line_number":6,"context_line":"    through capability ``pci_gpu_devices`` which can be used to make scheduling"},{"line_number":7,"context_line":"    decisions for the node. Currently, only NVIDIA Tesla T4 GPU devices are"},{"line_number":8,"context_line":"    reported."},{"line_number":9,"context_line":"issues:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9f560f44_80557cc5","line":6,"range":{"start_line":6,"start_character":41,"end_line":6,"end_character":42},"updated":"2020-09-28 16:45:10.000000000","message":"nit: Please add a coma between the closing backtick and \u0027which\u0027.","commit_id":"72b94adb365baa91120cc40a2cc64c42ccf23476"},{"author":{"_account_id":32205,"name":"Mudit","email":"mudit.simlote@dell.com","username":"mudit-simlote"},"change_message_id":"5b70749ee5a246423507099f444680c264dcea3e","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds support in ``idrac-wsman`` inspect hardware interface for reporting"},{"line_number":5,"context_line":"    number of GPU devices present on a server. This information is advertised"},{"line_number":6,"context_line":"    through capability ``pci_gpu_devices`` which can be used to make scheduling"},{"line_number":7,"context_line":"    decisions for the node. Currently, only NVIDIA Tesla T4 GPU devices are"},{"line_number":8,"context_line":"    reported."},{"line_number":9,"context_line":"issues:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9f560f44_6b46497e","line":6,"range":{"start_line":6,"start_character":41,"end_line":6,"end_character":42},"in_reply_to":"9f560f44_80557cc5","updated":"2020-09-28 17:16:10.000000000","message":"Done","commit_id":"72b94adb365baa91120cc40a2cc64c42ccf23476"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"f61e78985f34f1cf84383aaaf7772389f1077405","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Adds support in ``idrac-wsman`` inspect hardware interface for reporting"},{"line_number":5,"context_line":"    number of GPU devices present on a server. This information is advertised"},{"line_number":6,"context_line":"    through capability ``pci_gpu_devices`` which can be used to make scheduling"},{"line_number":7,"context_line":"    decisions for the node. Currently, only NVIDIA Tesla T4 GPU devices are"},{"line_number":8,"context_line":"    reported."},{"line_number":9,"context_line":"issues:"},{"line_number":10,"context_line":"  - |"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9f560f44_1ad39939","line":7,"range":{"start_line":7,"start_character":39,"end_line":7,"end_character":44},"updated":"2020-09-28 16:45:10.000000000","message":"Please remove this word.","commit_id":"72b94adb365baa91120cc40a2cc64c42ccf23476"},{"author":{"_account_id":32205,"name":"Mudit","email":"mudit.simlote@dell.com","username":"mudit-simlote"},"change_message_id":"5b70749ee5a246423507099f444680c264dcea3e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Adds support in ``idrac-wsman`` inspect hardware interface for reporting"},{"line_number":5,"context_line":"    number of GPU devices present on a server. This information is advertised"},{"line_number":6,"context_line":"    through capability ``pci_gpu_devices`` which can be used to make scheduling"},{"line_number":7,"context_line":"    decisions for the node. Currently, only NVIDIA Tesla T4 GPU devices are"},{"line_number":8,"context_line":"    reported."},{"line_number":9,"context_line":"issues:"},{"line_number":10,"context_line":"  - |"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9f560f44_cb5af54f","line":7,"range":{"start_line":7,"start_character":39,"end_line":7,"end_character":44},"in_reply_to":"9f560f44_1ad39939","updated":"2020-09-28 17:16:10.000000000","message":"Done","commit_id":"72b94adb365baa91120cc40a2cc64c42ccf23476"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"3cd6139d2ebf9770845b9faeefb79978e1d03b51","unresolved":false,"context_lines":[{"line_number":9,"context_line":"issues:"},{"line_number":10,"context_line":"  - |"},{"line_number":11,"context_line":"    The ``pci_gpu_devices`` reporting may not work correctly on Dell EMC 13th"},{"line_number":12,"context_line":"    Generation systems and may produce incorrect results."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9f560f44_e678d0c2","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":57},"updated":"2020-09-28 18:05:23.000000000","message":"Wow, can we handle this in code? I\u0027m not exactly a fan of merging this with adding an issue note sayign that incorrect results may be possible on 13th generation hardware.","commit_id":"9c1fc06b437e44e6c6ed6d056991d99666811f36"},{"author":{"_account_id":32205,"name":"Mudit","email":"mudit.simlote@dell.com","username":"mudit-simlote"},"change_message_id":"7644925d05e19cad0d8fc754528e7577462449ca","unresolved":false,"context_lines":[{"line_number":9,"context_line":"issues:"},{"line_number":10,"context_line":"  - |"},{"line_number":11,"context_line":"    The ``pci_gpu_devices`` reporting may not work correctly on Dell EMC 13th"},{"line_number":12,"context_line":"    Generation systems and may produce incorrect results."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9f560f44_fe3683e8","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":57},"in_reply_to":"9f560f44_e678d0c2","updated":"2020-09-29 16:17:49.000000000","message":"The issue right now is on 13G, we are seeing a single physical GPU as 32 different GPUs. This is under investigation, whether it is because of device configuration, or is the Tesla T4 GPU actually not supported on 13G. Idea was to go ahead with the servers that support this GPU for sure, and after investigating the case for 13G, do a bug fix (if needed) in the code and /or documentation. \nPlease suggest if this information can be added to upstream documentation for better clarity\nThis does not break the Hardware inspection, only the value of the capability \"pci_gpu_devices\" may be inaccurate on a 13G server","commit_id":"9c1fc06b437e44e6c6ed6d056991d99666811f36"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"b37f340c115149a84d958ef1288add8b57f1804d","unresolved":false,"context_lines":[{"line_number":9,"context_line":"issues:"},{"line_number":10,"context_line":"  - |"},{"line_number":11,"context_line":"    The ``pci_gpu_devices`` reporting may not work correctly on Dell EMC 13th"},{"line_number":12,"context_line":"    Generation systems and may produce incorrect results."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9f560f44_e5189c77","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":57},"in_reply_to":"9f560f44_fe3683e8","updated":"2020-09-30 22:53:58.000000000","message":"Iury, Julia, and I discussed this on IRC [1]. We agreed to remove the \u0027issues\u0027 subsection, which I have done.\n\nAfter we have finished our investigation and analysis of the 13G observation, we can follow up this change with a bug fix and/or \u0027idrac\u0027 hardware type/driver documentation update. Those can be backported to stable branches.\n\n[1] http://eavesdrop.openstack.org/irclogs/%23openstack-ironic/latest.log.html#t2020-09-30T22:12:43","commit_id":"9c1fc06b437e44e6c6ed6d056991d99666811f36"}]}