)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"4be4132ff77a38c85fa073ed666c27dc12075a9f","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This commit allows virtual media deployment/rescue"},{"line_number":10,"context_line":"using kernel/ramdisk pair by creating iso on the fly"},{"line_number":11,"context_line":"for ilo and ilo5 hardware types."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I08e37a9f5268c15ba954b34ad706b900e5430da6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9f560f44_5cf05292","line":12,"updated":"2020-09-15 13:32:47.000000000","message":"Story/Task please :)","commit_id":"d301f7682220e88af4ba02b90c8101d04f474f80"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"43ccc09be788bf7217fe1ac90ed5cdeef1215760","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This commit allows virtual media deployment/rescue"},{"line_number":10,"context_line":"using kernel/ramdisk pair by creating iso on the fly"},{"line_number":11,"context_line":"for ilo and ilo5 hardware types."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I08e37a9f5268c15ba954b34ad706b900e5430da6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9f560f44_6bda9b4b","line":12,"in_reply_to":"9f560f44_5cf05292","updated":"2020-09-16 12:55:55.000000000","message":"Done","commit_id":"d301f7682220e88af4ba02b90c8101d04f474f80"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"751ab8e8fcb7ce80e068d9fb85b368a5c930e367","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit allows virtual media deployment/rescue"},{"line_number":10,"context_line":"using kernel/ramdisk pair by creating iso on the fly"},{"line_number":11,"context_line":"for ilo and ilo5 hardware types. Also it adds support"},{"line_number":12,"context_line":"of dhcp less deploy to ilo and ilo5 hardware type."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I08e37a9f5268c15ba954b34ad706b900e5430da6"},{"line_number":15,"context_line":"Story: #2006691"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"9f560f44_59af682a","line":12,"range":{"start_line":11,"start_character":33,"end_line":12,"end_character":50},"updated":"2020-09-21 09:13:17.000000000","message":"How this is going to support DHCP less deploy unless we configure the iLO explicitly to boot from a static IP? Better to remove this statement.","commit_id":"afaf061cd9261155079ca939c8025edfeacaafcb"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"997fe7cb8511fd529efd3e0f23d35b30cfcdd6b6","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit allows virtual media deployment/rescue"},{"line_number":10,"context_line":"using kernel/ramdisk pair by creating iso on the fly"},{"line_number":11,"context_line":"for ilo and ilo5 hardware types. Also it adds support"},{"line_number":12,"context_line":"of dhcp less deploy to ilo and ilo5 hardware type."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I08e37a9f5268c15ba954b34ad706b900e5430da6"},{"line_number":15,"context_line":"Story: #2006691"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"9f560f44_9f5eee10","line":12,"range":{"start_line":11,"start_character":33,"end_line":12,"end_character":50},"in_reply_to":"9f560f44_59af682a","updated":"2020-09-22 05:44:48.000000000","message":"See this \nhttps://review.opendev.org/#/c/751139/1/releasenotes/notes/dhcpless-deploy-4b91de74adeff781.yaml","commit_id":"afaf061cd9261155079ca939c8025edfeacaafcb"}],"doc/source/admin/drivers/ilo.rst":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"dd60060f61a7b94b967b9e18f66eb757e6639d54","unresolved":false,"context_lines":[{"line_number":2164,"context_line":""},{"line_number":2165,"context_line":"Layer 3 or DHCP-less ramdisk booting"},{"line_number":2166,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":2167,"context_line":"DHCP-less deploy is supported by iLO and iLO5 hardware types. However"},{"line_number":2168,"context_line":"it would work only with ilo-virtual-media boot interface and not with"},{"line_number":2169,"context_line":"ilo-uefi-https or ilo-pxe or ilo-ipxe interface. See :ref:`redfish`"},{"line_number":2170,"context_line":"for more information."}],"source_content_type":"text/x-rst","patch_set":9,"id":"9f560f44_2dee9720","line":2167,"updated":"2020-09-22 11:22:35.000000000","message":"docs: undefined label: redfish (if the link has no caption the label must precede a section header)","commit_id":"6b9e60cd7521e9d2780cd973361a1fabcdbdb1d8"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"7a3ab5fde98265c5fb07767e95b077736bee2691","unresolved":false,"context_lines":[{"line_number":59,"context_line":"* `Inject NMI support`_"},{"line_number":60,"context_line":"* `Soft power operation support`_"},{"line_number":61,"context_line":"* `BIOS configuration support`_"},{"line_number":62,"context_line":"* `IPv6 support`_"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"Apart from above features hardware type ``ilo5`` also supports following"},{"line_number":65,"context_line":"features:"}],"source_content_type":"text/x-rst","patch_set":10,"id":"9f560f44_33a6f6c1","line":62,"range":{"start_line":62,"start_character":1,"end_line":62,"end_character":17},"updated":"2020-09-23 05:28:02.000000000","message":"Add a link to section \u0027Layer 3 or DHCP-less ramdisk booting\u0027  here as well.","commit_id":"b9d005e4c76be40f45924b9278837791f5b61762"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"7a3ab5fde98265c5fb07767e95b077736bee2691","unresolved":false,"context_lines":[{"line_number":2164,"context_line":""},{"line_number":2165,"context_line":"Layer 3 or DHCP-less ramdisk booting"},{"line_number":2166,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":2167,"context_line":"DHCP-less deploy is supported by iLO and iLO5 hardware types. However"},{"line_number":2168,"context_line":"it would work only with ilo-virtual-media boot interface and not with"},{"line_number":2169,"context_line":"ilo-uefi-https or ilo-pxe or ilo-ipxe interface. See :doc:`redfish`"},{"line_number":2170,"context_line":"for more information."}],"source_content_type":"text/x-rst","patch_set":10,"id":"9f560f44_f3d11e31","line":2167,"range":{"start_line":2167,"start_character":33,"end_line":2167,"end_character":45},"updated":"2020-09-23 05:28:02.000000000","message":"s/ iLO and iLO5 / ``ilo`` and ``ilo5`` /","commit_id":"b9d005e4c76be40f45924b9278837791f5b61762"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"c81f7f3817059df2a6dc7aee4c441a45b889c7d4","unresolved":false,"context_lines":[{"line_number":2164,"context_line":""},{"line_number":2165,"context_line":"Layer 3 or DHCP-less ramdisk booting"},{"line_number":2166,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":2167,"context_line":"DHCP-less deploy is supported by iLO and iLO5 hardware types. However"},{"line_number":2168,"context_line":"it would work only with ilo-virtual-media boot interface and not with"},{"line_number":2169,"context_line":"ilo-uefi-https or ilo-pxe or ilo-ipxe interface. See :doc:`redfish`"},{"line_number":2170,"context_line":"for more information."}],"source_content_type":"text/x-rst","patch_set":10,"id":"9f560f44_6fc6b09e","line":2167,"range":{"start_line":2167,"start_character":33,"end_line":2167,"end_character":45},"in_reply_to":"9f560f44_f3d11e31","updated":"2020-09-23 10:06:27.000000000","message":"Done","commit_id":"b9d005e4c76be40f45924b9278837791f5b61762"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"7a3ab5fde98265c5fb07767e95b077736bee2691","unresolved":false,"context_lines":[{"line_number":2166,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":2167,"context_line":"DHCP-less deploy is supported by iLO and iLO5 hardware types. However"},{"line_number":2168,"context_line":"it would work only with ilo-virtual-media boot interface and not with"},{"line_number":2169,"context_line":"ilo-uefi-https or ilo-pxe or ilo-ipxe interface. See :doc:`redfish`"},{"line_number":2170,"context_line":"for more information."},{"line_number":2171,"context_line":""},{"line_number":2172,"context_line":".. _`ssacli documentation`: https://support.hpe.com/hpsc/doc/public/display?docId\u003dc03909334"}],"source_content_type":"text/x-rst","patch_set":10,"id":"9f560f44_b31686f1","line":2169,"range":{"start_line":2169,"start_character":49,"end_line":2169,"end_character":67},"updated":"2020-09-23 05:28:02.000000000","message":"Instead of pointing to entire redfish doc, point it to that section, by adding a tag to that section. Ex:\nSee :ref:`dhcpless_booting`","commit_id":"b9d005e4c76be40f45924b9278837791f5b61762"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"7a3ab5fde98265c5fb07767e95b077736bee2691","unresolved":false,"context_lines":[{"line_number":2165,"context_line":"Layer 3 or DHCP-less ramdisk booting"},{"line_number":2166,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":2167,"context_line":"DHCP-less deploy is supported by iLO and iLO5 hardware types. However"},{"line_number":2168,"context_line":"it would work only with ilo-virtual-media boot interface and not with"},{"line_number":2169,"context_line":"ilo-uefi-https or ilo-pxe or ilo-ipxe interface. See :doc:`redfish`"},{"line_number":2170,"context_line":"for more information."},{"line_number":2171,"context_line":""},{"line_number":2172,"context_line":".. _`ssacli documentation`: https://support.hpe.com/hpsc/doc/public/display?docId\u003dc03909334"}],"source_content_type":"text/x-rst","patch_set":10,"id":"9f560f44_53e28a02","line":2169,"range":{"start_line":2168,"start_character":56,"end_line":2169,"end_character":47},"updated":"2020-09-23 05:28:02.000000000","message":"s/  and not with ilo-uefi-https or ilo-pxe or ilo-ipxe interface //","commit_id":"b9d005e4c76be40f45924b9278837791f5b61762"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"c81f7f3817059df2a6dc7aee4c441a45b889c7d4","unresolved":false,"context_lines":[{"line_number":2165,"context_line":"Layer 3 or DHCP-less ramdisk booting"},{"line_number":2166,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":2167,"context_line":"DHCP-less deploy is supported by iLO and iLO5 hardware types. However"},{"line_number":2168,"context_line":"it would work only with ilo-virtual-media boot interface and not with"},{"line_number":2169,"context_line":"ilo-uefi-https or ilo-pxe or ilo-ipxe interface. See :doc:`redfish`"},{"line_number":2170,"context_line":"for more information."},{"line_number":2171,"context_line":""},{"line_number":2172,"context_line":".. _`ssacli documentation`: https://support.hpe.com/hpsc/doc/public/display?docId\u003dc03909334"}],"source_content_type":"text/x-rst","patch_set":10,"id":"9f560f44_2f35d8a8","line":2169,"range":{"start_line":2168,"start_character":56,"end_line":2169,"end_character":47},"in_reply_to":"9f560f44_53e28a02","updated":"2020-09-23 10:06:27.000000000","message":"Done","commit_id":"b9d005e4c76be40f45924b9278837791f5b61762"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"c81f7f3817059df2a6dc7aee4c441a45b889c7d4","unresolved":false,"context_lines":[{"line_number":2166,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":2167,"context_line":"DHCP-less deploy is supported by iLO and iLO5 hardware types. However"},{"line_number":2168,"context_line":"it would work only with ilo-virtual-media boot interface and not with"},{"line_number":2169,"context_line":"ilo-uefi-https or ilo-pxe or ilo-ipxe interface. See :doc:`redfish`"},{"line_number":2170,"context_line":"for more information."},{"line_number":2171,"context_line":""},{"line_number":2172,"context_line":".. _`ssacli documentation`: https://support.hpe.com/hpsc/doc/public/display?docId\u003dc03909334"}],"source_content_type":"text/x-rst","patch_set":10,"id":"9f560f44_0f3a9496","line":2169,"range":{"start_line":2169,"start_character":49,"end_line":2169,"end_character":67},"in_reply_to":"9f560f44_b31686f1","updated":"2020-09-23 10:06:27.000000000","message":"Done","commit_id":"b9d005e4c76be40f45924b9278837791f5b61762"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"c06731131a960d8d18f1b6410ccd47fc2d5e70e6","unresolved":false,"context_lines":[{"line_number":59,"context_line":"* `Inject NMI support`_"},{"line_number":60,"context_line":"* `Soft power operation support`_"},{"line_number":61,"context_line":"* `BIOS configuration support`_"},{"line_number":62,"context_line":"* `IPv6 support`_"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"Apart from above features hardware type ``ilo5`` also supports following"},{"line_number":65,"context_line":"features:"}],"source_content_type":"text/x-rst","patch_set":11,"id":"9f560f44_e5714147","line":62,"range":{"start_line":62,"start_character":2,"end_line":62,"end_character":17},"updated":"2020-09-23 15:14:31.000000000","message":"Add a link to section \u0027Layer 3 or DHCP-less ramdisk booting\u0027 below this.","commit_id":"6b3190315dc1d04beac960d68edefc31eb77a908"}],"doc/source/admin/drivers/redfish.rst":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"7a3ab5fde98265c5fb07767e95b077736bee2691","unresolved":false,"context_lines":[{"line_number":207,"context_line":"This initial interface does not support bootloader configuration"},{"line_number":208,"context_line":"parameter injection, as such the ``[instance_info]/kernel_append_params``"},{"line_number":209,"context_line":"setting is ignored."},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"Layer 3 or DHCP-less ramdisk booting"},{"line_number":212,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":213,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"9f560f44_73f7ced5","line":210,"updated":"2020-09-23 05:28:02.000000000","message":"May you can add a tag here which can be used from ilo driver page. Say :\n.. _dhcpless_booting:","commit_id":"b9d005e4c76be40f45924b9278837791f5b61762"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"c81f7f3817059df2a6dc7aee4c441a45b889c7d4","unresolved":false,"context_lines":[{"line_number":207,"context_line":"This initial interface does not support bootloader configuration"},{"line_number":208,"context_line":"parameter injection, as such the ``[instance_info]/kernel_append_params``"},{"line_number":209,"context_line":"setting is ignored."},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"Layer 3 or DHCP-less ramdisk booting"},{"line_number":212,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":213,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"9f560f44_af48c82d","line":210,"in_reply_to":"9f560f44_73f7ced5","updated":"2020-09-23 10:06:27.000000000","message":"Done","commit_id":"b9d005e4c76be40f45924b9278837791f5b61762"}],"ironic/drivers/modules/ilo/boot.py":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"484b0332770fbd37362b2a842a76a634e360ad30","unresolved":false,"context_lines":[{"line_number":152,"context_line":"        HTTP(S) URL."},{"line_number":153,"context_line":"    \"\"\""},{"line_number":154,"context_line":"    LOG.debug(\"Trying to get a boot ISO to boot the baremetal node\")"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    # Option 1 - Check if user has provided ilo_boot_iso in node\u0027s"},{"line_number":157,"context_line":"    # instance_info"},{"line_number":158,"context_line":"    driver_internal_info \u003d task.node.driver_internal_info"},{"line_number":159,"context_line":"    boot_iso_created_in_web_server \u003d ("},{"line_number":160,"context_line":"        driver_internal_info.get(\u0027boot_iso_created_in_web_server\u0027))"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    if (task.node.instance_info.get(\u0027ilo_boot_iso\u0027)"},{"line_number":163,"context_line":"            and not boot_iso_created_in_web_server):"},{"line_number":164,"context_line":"        LOG.debug(\"Using ilo_boot_iso provided in node\u0027s instance_info\")"},{"line_number":165,"context_line":"        boot_iso \u003d task.node.instance_info[\u0027ilo_boot_iso\u0027]"},{"line_number":166,"context_line":"        if not service_utils.is_glance_image(boot_iso):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_41c21d88","side":"PARENT","line":163,"range":{"start_line":155,"start_character":0,"end_line":163,"end_character":52},"updated":"2020-09-16 08:13:27.000000000","message":"Is this still required? Now image hosting is managed through image_utils and boot_iso_created_in_web_server is not updated.","commit_id":"0a094a37cbd990039b1f583f5bae76475efbb844"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"43ccc09be788bf7217fe1ac90ed5cdeef1215760","unresolved":false,"context_lines":[{"line_number":152,"context_line":"        HTTP(S) URL."},{"line_number":153,"context_line":"    \"\"\""},{"line_number":154,"context_line":"    LOG.debug(\"Trying to get a boot ISO to boot the baremetal node\")"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    # Option 1 - Check if user has provided ilo_boot_iso in node\u0027s"},{"line_number":157,"context_line":"    # instance_info"},{"line_number":158,"context_line":"    driver_internal_info \u003d task.node.driver_internal_info"},{"line_number":159,"context_line":"    boot_iso_created_in_web_server \u003d ("},{"line_number":160,"context_line":"        driver_internal_info.get(\u0027boot_iso_created_in_web_server\u0027))"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    if (task.node.instance_info.get(\u0027ilo_boot_iso\u0027)"},{"line_number":163,"context_line":"            and not boot_iso_created_in_web_server):"},{"line_number":164,"context_line":"        LOG.debug(\"Using ilo_boot_iso provided in node\u0027s instance_info\")"},{"line_number":165,"context_line":"        boot_iso \u003d task.node.instance_info[\u0027ilo_boot_iso\u0027]"},{"line_number":166,"context_line":"        if not service_utils.is_glance_image(boot_iso):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_a83839d4","side":"PARENT","line":163,"range":{"start_line":155,"start_character":0,"end_line":163,"end_character":52},"in_reply_to":"9f560f44_41c21d88","updated":"2020-09-16 12:55:55.000000000","message":"Done","commit_id":"0a094a37cbd990039b1f583f5bae76475efbb844"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"484b0332770fbd37362b2a842a76a634e360ad30","unresolved":false,"context_lines":[{"line_number":218,"context_line":"        kernel_params \u003d \"root\u003d/dev/ram0 text \""},{"line_number":219,"context_line":"        kernel_params +\u003d i_info.get(\"ramdisk_kernel_arguments\", \"\")"},{"line_number":220,"context_line":"    else:"},{"line_number":221,"context_line":"        kernel_params \u003d CONF.pxe.pxe_append_params"},{"line_number":222,"context_line":"    with tempfile.NamedTemporaryFile(dir\u003dCONF.tempdir) as fileobj:"},{"line_number":223,"context_line":"        boot_iso_tmp_file \u003d fileobj.name"},{"line_number":224,"context_line":"        images.create_boot_iso(task.context, boot_iso_tmp_file,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_a6322f0e","side":"PARENT","line":221,"range":{"start_line":221,"start_character":8,"end_line":221,"end_character":50},"updated":"2020-09-16 08:13:27.000000000","message":"Earlier we used to pass these kernel params and now it will pass  CONF.redfish.kernel_append_params. Better to capture this in release notes.\nhttps://github.com/openstack/ironic/blob/master/ironic/drivers/modules/image_utils.py#L311-L312","commit_id":"0a094a37cbd990039b1f583f5bae76475efbb844"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"43ccc09be788bf7217fe1ac90ed5cdeef1215760","unresolved":false,"context_lines":[{"line_number":218,"context_line":"        kernel_params \u003d \"root\u003d/dev/ram0 text \""},{"line_number":219,"context_line":"        kernel_params +\u003d i_info.get(\"ramdisk_kernel_arguments\", \"\")"},{"line_number":220,"context_line":"    else:"},{"line_number":221,"context_line":"        kernel_params \u003d CONF.pxe.pxe_append_params"},{"line_number":222,"context_line":"    with tempfile.NamedTemporaryFile(dir\u003dCONF.tempdir) as fileobj:"},{"line_number":223,"context_line":"        boot_iso_tmp_file \u003d fileobj.name"},{"line_number":224,"context_line":"        images.create_boot_iso(task.context, boot_iso_tmp_file,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_686d81cb","side":"PARENT","line":221,"range":{"start_line":221,"start_character":8,"end_line":221,"end_character":50},"in_reply_to":"9f560f44_a6322f0e","updated":"2020-09-16 12:55:55.000000000","message":"Done","commit_id":"0a094a37cbd990039b1f583f5bae76475efbb844"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"484b0332770fbd37362b2a842a76a634e360ad30","unresolved":false,"context_lines":[{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    error_msg \u003d (_(\"Error validating iLO virtual media for %(mode)s. \""},{"line_number":120,"context_line":"                   \"Either \u0027ilo_%(mode)s_iso\u0027 is missing or \""},{"line_number":121,"context_line":"                   \"DEPLOY_RAMDISK_PROPERTIES or RESCUE_RAMDISK_PROPERTIES \""},{"line_number":122,"context_line":"                   \"were missing in node\u0027s driver_info.\") % {\u0027mode\u0027: mode})"},{"line_number":123,"context_line":"    deploy_utils.check_for_missing_params(d_info, error_msg)"},{"line_number":124,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_e69a6760","line":121,"range":{"start_line":121,"start_character":20,"end_line":121,"end_character":45},"updated":"2020-09-16 08:13:27.000000000","message":"This is internal variable name. We do not need it as the exact params would be listed by deploy_utils.check_for_missing_params()","commit_id":"d301f7682220e88af4ba02b90c8101d04f474f80"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"484b0332770fbd37362b2a842a76a634e360ad30","unresolved":false,"context_lines":[{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    error_msg \u003d (_(\"Error validating iLO virtual media for %(mode)s. \""},{"line_number":120,"context_line":"                   \"Either \u0027ilo_%(mode)s_iso\u0027 is missing or \""},{"line_number":121,"context_line":"                   \"DEPLOY_RAMDISK_PROPERTIES or RESCUE_RAMDISK_PROPERTIES \""},{"line_number":122,"context_line":"                   \"were missing in node\u0027s driver_info.\") % {\u0027mode\u0027: mode})"},{"line_number":123,"context_line":"    deploy_utils.check_for_missing_params(d_info, error_msg)"},{"line_number":124,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_a6b98fcc","line":121,"range":{"start_line":121,"start_character":49,"end_line":121,"end_character":74},"updated":"2020-09-16 08:13:27.000000000","message":"ditto","commit_id":"d301f7682220e88af4ba02b90c8101d04f474f80"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"43ccc09be788bf7217fe1ac90ed5cdeef1215760","unresolved":false,"context_lines":[{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    error_msg \u003d (_(\"Error validating iLO virtual media for %(mode)s. \""},{"line_number":120,"context_line":"                   \"Either \u0027ilo_%(mode)s_iso\u0027 is missing or \""},{"line_number":121,"context_line":"                   \"DEPLOY_RAMDISK_PROPERTIES or RESCUE_RAMDISK_PROPERTIES \""},{"line_number":122,"context_line":"                   \"were missing in node\u0027s driver_info.\") % {\u0027mode\u0027: mode})"},{"line_number":123,"context_line":"    deploy_utils.check_for_missing_params(d_info, error_msg)"},{"line_number":124,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_999f8550","line":121,"range":{"start_line":121,"start_character":49,"end_line":121,"end_character":74},"in_reply_to":"9f560f44_a6b98fcc","updated":"2020-09-16 12:55:55.000000000","message":"Done","commit_id":"d301f7682220e88af4ba02b90c8101d04f474f80"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"43ccc09be788bf7217fe1ac90ed5cdeef1215760","unresolved":false,"context_lines":[{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    error_msg \u003d (_(\"Error validating iLO virtual media for %(mode)s. \""},{"line_number":120,"context_line":"                   \"Either \u0027ilo_%(mode)s_iso\u0027 is missing or \""},{"line_number":121,"context_line":"                   \"DEPLOY_RAMDISK_PROPERTIES or RESCUE_RAMDISK_PROPERTIES \""},{"line_number":122,"context_line":"                   \"were missing in node\u0027s driver_info.\") % {\u0027mode\u0027: mode})"},{"line_number":123,"context_line":"    deploy_utils.check_for_missing_params(d_info, error_msg)"},{"line_number":124,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_051cb075","line":121,"range":{"start_line":121,"start_character":20,"end_line":121,"end_character":45},"in_reply_to":"9f560f44_e69a6760","updated":"2020-09-16 12:55:55.000000000","message":"Done","commit_id":"d301f7682220e88af4ba02b90c8101d04f474f80"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"484b0332770fbd37362b2a842a76a634e360ad30","unresolved":false,"context_lines":[{"line_number":139,"context_line":"       refer to the UUID of the boot_iso which exists in Glance."},{"line_number":140,"context_line":"    3. Generates a boot ISO on the fly using kernel and ramdisk mentioned in"},{"line_number":141,"context_line":"       the image deployed. It uploads the generated boot ISO to Swift."},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    :param task: a TaskManager instance containing the node to act on."},{"line_number":144,"context_line":"    :param root_uuid: the uuid of the root partition."},{"line_number":145,"context_line":"    :returns: boot ISO URL. Should be either of below:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_c1974d9c","line":142,"updated":"2020-09-16 08:13:27.000000000","message":"This needs to be updated.","commit_id":"d301f7682220e88af4ba02b90c8101d04f474f80"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"43ccc09be788bf7217fe1ac90ed5cdeef1215760","unresolved":false,"context_lines":[{"line_number":139,"context_line":"       refer to the UUID of the boot_iso which exists in Glance."},{"line_number":140,"context_line":"    3. Generates a boot ISO on the fly using kernel and ramdisk mentioned in"},{"line_number":141,"context_line":"       the image deployed. It uploads the generated boot ISO to Swift."},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    :param task: a TaskManager instance containing the node to act on."},{"line_number":144,"context_line":"    :param root_uuid: the uuid of the root partition."},{"line_number":145,"context_line":"    :returns: boot ISO URL. Should be either of below:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_685741cc","line":142,"in_reply_to":"9f560f44_c1974d9c","updated":"2020-09-16 12:55:55.000000000","message":"Done","commit_id":"d301f7682220e88af4ba02b90c8101d04f474f80"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"484b0332770fbd37362b2a842a76a634e360ad30","unresolved":false,"context_lines":[{"line_number":573,"context_line":"            driver_internal_info.pop(\u0027ilo_uefi_iscsi_boot\u0027, None)"},{"line_number":574,"context_line":"        else:"},{"line_number":575,"context_line":"            image_utils.cleanup_iso_image(task)"},{"line_number":576,"context_line":"            driver_internal_info.pop(\u0027boot_iso_created_in_web_server\u0027, None)"},{"line_number":577,"context_line":"            ilo_common.cleanup_vmedia_boot(task)"},{"line_number":578,"context_line":"        task.node.driver_internal_info \u003d driver_internal_info"},{"line_number":579,"context_line":"        task.node.save()"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_41669df0","line":576,"range":{"start_line":576,"start_character":12,"end_line":576,"end_character":76},"updated":"2020-09-16 08:13:27.000000000","message":"Is this required?","commit_id":"d301f7682220e88af4ba02b90c8101d04f474f80"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"43ccc09be788bf7217fe1ac90ed5cdeef1215760","unresolved":false,"context_lines":[{"line_number":573,"context_line":"            driver_internal_info.pop(\u0027ilo_uefi_iscsi_boot\u0027, None)"},{"line_number":574,"context_line":"        else:"},{"line_number":575,"context_line":"            image_utils.cleanup_iso_image(task)"},{"line_number":576,"context_line":"            driver_internal_info.pop(\u0027boot_iso_created_in_web_server\u0027, None)"},{"line_number":577,"context_line":"            ilo_common.cleanup_vmedia_boot(task)"},{"line_number":578,"context_line":"        task.node.driver_internal_info \u003d driver_internal_info"},{"line_number":579,"context_line":"        task.node.save()"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_a8703975","line":576,"range":{"start_line":576,"start_character":12,"end_line":576,"end_character":76},"in_reply_to":"9f560f44_41669df0","updated":"2020-09-16 12:55:55.000000000","message":"Done","commit_id":"d301f7682220e88af4ba02b90c8101d04f474f80"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"484b0332770fbd37362b2a842a76a634e360ad30","unresolved":false,"context_lines":[{"line_number":914,"context_line":"                       for option in params_to_check}"},{"line_number":915,"context_line":"        deploy_info.update("},{"line_number":916,"context_line":"            {option: info.get(option, getattr(CONF.conductor, option, None))"},{"line_number":917,"context_line":"             for option in OPTIONAL_PROPERTIES})"},{"line_number":918,"context_line":""},{"line_number":919,"context_line":"        self._validate_hrefs(deploy_info)"},{"line_number":920,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_816a757e","line":917,"range":{"start_line":917,"start_character":27,"end_line":917,"end_character":46},"updated":"2020-09-16 08:13:27.000000000","message":"Similarly dont we need to update the required properties from conductor conf as done at L112-L117?","commit_id":"d301f7682220e88af4ba02b90c8101d04f474f80"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"43ccc09be788bf7217fe1ac90ed5cdeef1215760","unresolved":false,"context_lines":[{"line_number":914,"context_line":"                       for option in params_to_check}"},{"line_number":915,"context_line":"        deploy_info.update("},{"line_number":916,"context_line":"            {option: info.get(option, getattr(CONF.conductor, option, None))"},{"line_number":917,"context_line":"             for option in OPTIONAL_PROPERTIES})"},{"line_number":918,"context_line":""},{"line_number":919,"context_line":"        self._validate_hrefs(deploy_info)"},{"line_number":920,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_25173457","line":917,"range":{"start_line":917,"start_character":27,"end_line":917,"end_character":46},"in_reply_to":"9f560f44_816a757e","updated":"2020-09-16 12:55:55.000000000","message":"Done","commit_id":"d301f7682220e88af4ba02b90c8101d04f474f80"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"1bd3db1b6395ee1058ca05d1de6e68d6b272e8f2","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        d_info \u003d {option: info.get(option)"},{"line_number":110,"context_line":"                  for option in params_to_check}"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        if not any(d_info.values()):"},{"line_number":113,"context_line":"            # NOTE(dtantsur): avoid situation when e.g. deploy_kernel comes"},{"line_number":114,"context_line":"            # from driver_info but deploy_ramdisk comes from configuration,"},{"line_number":115,"context_line":"            # since it\u0027s a sign of a potential operator\u0027s mistake."},{"line_number":116,"context_line":"            d_info \u003d {k: getattr(CONF.conductor, k.replace(\u0027ilo_\u0027, \u0027\u0027))"},{"line_number":117,"context_line":"                      for k in params_to_check}"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    error_msg \u003d (_(\"Error validating iLO virtual media for %s. Some \""},{"line_number":120,"context_line":"                   \"parameters were missing in node\u0027s driver_info.\") % mode)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_50c9044f","line":117,"range":{"start_line":112,"start_character":8,"end_line":117,"end_character":47},"updated":"2020-09-19 11:55:24.000000000","message":"Add a testcase for this path.","commit_id":"7530122d9207e6852460a578462f2514b592515d"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"fa24b99463df07c10357873e601bebe715ac494e","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        d_info \u003d {option: info.get(option)"},{"line_number":110,"context_line":"                  for option in params_to_check}"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        if not any(d_info.values()):"},{"line_number":113,"context_line":"            # NOTE(dtantsur): avoid situation when e.g. deploy_kernel comes"},{"line_number":114,"context_line":"            # from driver_info but deploy_ramdisk comes from configuration,"},{"line_number":115,"context_line":"            # since it\u0027s a sign of a potential operator\u0027s mistake."},{"line_number":116,"context_line":"            d_info \u003d {k: getattr(CONF.conductor, k.replace(\u0027ilo_\u0027, \u0027\u0027))"},{"line_number":117,"context_line":"                      for k in params_to_check}"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    error_msg \u003d (_(\"Error validating iLO virtual media for %s. Some \""},{"line_number":120,"context_line":"                   \"parameters were missing in node\u0027s driver_info.\") % mode)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_30129063","line":117,"range":{"start_line":112,"start_character":8,"end_line":117,"end_character":47},"in_reply_to":"9f560f44_50c9044f","updated":"2020-09-19 20:50:59.000000000","message":"Done","commit_id":"7530122d9207e6852460a578462f2514b592515d"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"1bd3db1b6395ee1058ca05d1de6e68d6b272e8f2","unresolved":false,"context_lines":[{"line_number":120,"context_line":"                   \"parameters were missing in node\u0027s driver_info.\") % mode)"},{"line_number":121,"context_line":"    deploy_utils.check_for_missing_params(d_info, error_msg)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    d_info.update("},{"line_number":124,"context_line":"        {option: info.get(option, getattr(CONF.conductor, option, None))"},{"line_number":125,"context_line":"         for option in OPTIONAL_PROPERTIES})"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    return d_info"},{"line_number":128,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_70cec85b","line":125,"range":{"start_line":123,"start_character":4,"end_line":125,"end_character":44},"updated":"2020-09-19 11:55:24.000000000","message":"Add a testcase for this path.","commit_id":"7530122d9207e6852460a578462f2514b592515d"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"1bd3db1b6395ee1058ca05d1de6e68d6b272e8f2","unresolved":false,"context_lines":[{"line_number":121,"context_line":"    deploy_utils.check_for_missing_params(d_info, error_msg)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    d_info.update("},{"line_number":124,"context_line":"        {option: info.get(option, getattr(CONF.conductor, option, None))"},{"line_number":125,"context_line":"         for option in OPTIONAL_PROPERTIES})"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    return d_info"},{"line_number":128,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_f0b938ec","line":125,"range":{"start_line":124,"start_character":33,"end_line":125,"end_character":42},"updated":"2020-09-19 11:55:24.000000000","message":"Does it need to strip \u0027ilo_\u0027 from the \u0027option\u0027 before looking for configuration parameter as config param is \u0027bootloader\u0027 ?","commit_id":"7530122d9207e6852460a578462f2514b592515d"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"fa24b99463df07c10357873e601bebe715ac494e","unresolved":false,"context_lines":[{"line_number":120,"context_line":"                   \"parameters were missing in node\u0027s driver_info.\") % mode)"},{"line_number":121,"context_line":"    deploy_utils.check_for_missing_params(d_info, error_msg)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    d_info.update("},{"line_number":124,"context_line":"        {option: info.get(option, getattr(CONF.conductor, option, None))"},{"line_number":125,"context_line":"         for option in OPTIONAL_PROPERTIES})"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    return d_info"},{"line_number":128,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_1015cc49","line":125,"range":{"start_line":123,"start_character":4,"end_line":125,"end_character":44},"in_reply_to":"9f560f44_70cec85b","updated":"2020-09-19 20:50:59.000000000","message":"Done","commit_id":"7530122d9207e6852460a578462f2514b592515d"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"fa24b99463df07c10357873e601bebe715ac494e","unresolved":false,"context_lines":[{"line_number":121,"context_line":"    deploy_utils.check_for_missing_params(d_info, error_msg)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    d_info.update("},{"line_number":124,"context_line":"        {option: info.get(option, getattr(CONF.conductor, option, None))"},{"line_number":125,"context_line":"         for option in OPTIONAL_PROPERTIES})"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    return d_info"},{"line_number":128,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_700b682a","line":125,"range":{"start_line":124,"start_character":33,"end_line":125,"end_character":42},"in_reply_to":"9f560f44_f0b938ec","updated":"2020-09-19 20:50:59.000000000","message":"Done","commit_id":"7530122d9207e6852460a578462f2514b592515d"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"1bd3db1b6395ee1058ca05d1de6e68d6b272e8f2","unresolved":false,"context_lines":[{"line_number":183,"context_line":"    image_href \u003d deploy_info[\u0027image_source\u0027]"},{"line_number":184,"context_line":"    image_properties \u003d ("},{"line_number":185,"context_line":"        images.get_image_properties("},{"line_number":186,"context_line":"            task.context, image_href, [\u0027boot_iso\u0027, \u0027kernel_id\u0027, \u0027ramdisk_id\u0027]))"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    boot_iso_uuid \u003d image_properties.get(\u0027boot_iso\u0027)"},{"line_number":189,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_70a08892","line":186,"range":{"start_line":186,"start_character":50,"end_line":186,"end_character":76},"updated":"2020-09-19 11:55:24.000000000","message":"I suppose, this is not getting used.","commit_id":"7530122d9207e6852460a578462f2514b592515d"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"fa24b99463df07c10357873e601bebe715ac494e","unresolved":false,"context_lines":[{"line_number":183,"context_line":"    image_href \u003d deploy_info[\u0027image_source\u0027]"},{"line_number":184,"context_line":"    image_properties \u003d ("},{"line_number":185,"context_line":"        images.get_image_properties("},{"line_number":186,"context_line":"            task.context, image_href, [\u0027boot_iso\u0027, \u0027kernel_id\u0027, \u0027ramdisk_id\u0027]))"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    boot_iso_uuid \u003d image_properties.get(\u0027boot_iso\u0027)"},{"line_number":189,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_d3ffdefd","line":186,"range":{"start_line":186,"start_character":50,"end_line":186,"end_character":76},"in_reply_to":"9f560f44_70a08892","updated":"2020-09-19 20:50:59.000000000","message":"Done","commit_id":"7530122d9207e6852460a578462f2514b592515d"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"1bd3db1b6395ee1058ca05d1de6e68d6b272e8f2","unresolved":false,"context_lines":[{"line_number":462,"context_line":"            iso \u003d node.driver_info[\u0027ilo_rescue_iso\u0027]"},{"line_number":463,"context_line":"        elif node.driver_info.get(\u0027ilo_deploy_iso\u0027):"},{"line_number":464,"context_line":"            iso \u003d node.driver_info[\u0027ilo_deploy_iso\u0027]"},{"line_number":465,"context_line":"        else:"},{"line_number":466,"context_line":"            mode \u003d deploy_utils.rescue_or_deploy_mode(node)"},{"line_number":467,"context_line":"            d_info \u003d parse_driver_info(node, mode)"},{"line_number":468,"context_line":"            iso \u003d image_utils.prepare_deploy_iso(task, ramdisk_params,"},{"line_number":469,"context_line":"                                                 mode, d_info)"},{"line_number":470,"context_line":""},{"line_number":471,"context_line":"        ilo_common.setup_vmedia(task, iso, ramdisk_params)"},{"line_number":472,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_d0c7d410","line":469,"range":{"start_line":465,"start_character":8,"end_line":469,"end_character":62},"updated":"2020-09-19 11:55:24.000000000","message":"Is there a testcase for this path?","commit_id":"7530122d9207e6852460a578462f2514b592515d"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"fa24b99463df07c10357873e601bebe715ac494e","unresolved":false,"context_lines":[{"line_number":462,"context_line":"            iso \u003d node.driver_info[\u0027ilo_rescue_iso\u0027]"},{"line_number":463,"context_line":"        elif node.driver_info.get(\u0027ilo_deploy_iso\u0027):"},{"line_number":464,"context_line":"            iso \u003d node.driver_info[\u0027ilo_deploy_iso\u0027]"},{"line_number":465,"context_line":"        else:"},{"line_number":466,"context_line":"            mode \u003d deploy_utils.rescue_or_deploy_mode(node)"},{"line_number":467,"context_line":"            d_info \u003d parse_driver_info(node, mode)"},{"line_number":468,"context_line":"            iso \u003d image_utils.prepare_deploy_iso(task, ramdisk_params,"},{"line_number":469,"context_line":"                                                 mode, d_info)"},{"line_number":470,"context_line":""},{"line_number":471,"context_line":"        ilo_common.setup_vmedia(task, iso, ramdisk_params)"},{"line_number":472,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_561a9c17","line":469,"range":{"start_line":465,"start_character":8,"end_line":469,"end_character":62},"in_reply_to":"9f560f44_d0c7d410","updated":"2020-09-19 20:50:59.000000000","message":"Done","commit_id":"7530122d9207e6852460a578462f2514b592515d"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"1bd3db1b6395ee1058ca05d1de6e68d6b272e8f2","unresolved":false,"context_lines":[{"line_number":556,"context_line":"        LOG.debug(\"Cleaning up the instance.\")"},{"line_number":557,"context_line":"        manager_utils.node_power_action(task, states.POWER_OFF)"},{"line_number":558,"context_line":"        disable_secure_boot_if_supported(task)"},{"line_number":559,"context_line":"        driver_internal_info \u003d task.node.driver_internal_info"},{"line_number":560,"context_line":""},{"line_number":561,"context_line":"        if (deploy_utils.is_iscsi_boot(task)"},{"line_number":562,"context_line":"            and task.node.driver_internal_info.get(\u0027ilo_uefi_iscsi_boot\u0027)):"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_d0b874c8","line":559,"range":{"start_line":559,"start_character":8,"end_line":559,"end_character":60},"updated":"2020-09-19 11:55:24.000000000","message":"This can be moved to L565.","commit_id":"7530122d9207e6852460a578462f2514b592515d"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"fa24b99463df07c10357873e601bebe715ac494e","unresolved":false,"context_lines":[{"line_number":556,"context_line":"        LOG.debug(\"Cleaning up the instance.\")"},{"line_number":557,"context_line":"        manager_utils.node_power_action(task, states.POWER_OFF)"},{"line_number":558,"context_line":"        disable_secure_boot_if_supported(task)"},{"line_number":559,"context_line":"        driver_internal_info \u003d task.node.driver_internal_info"},{"line_number":560,"context_line":""},{"line_number":561,"context_line":"        if (deploy_utils.is_iscsi_boot(task)"},{"line_number":562,"context_line":"            and task.node.driver_internal_info.get(\u0027ilo_uefi_iscsi_boot\u0027)):"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_d6bcecdc","line":559,"range":{"start_line":559,"start_character":8,"end_line":559,"end_character":60},"in_reply_to":"9f560f44_d0b874c8","updated":"2020-09-19 20:50:59.000000000","message":"Done","commit_id":"7530122d9207e6852460a578462f2514b592515d"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"1bd3db1b6395ee1058ca05d1de6e68d6b272e8f2","unresolved":false,"context_lines":[{"line_number":566,"context_line":"        else:"},{"line_number":567,"context_line":"            image_utils.cleanup_iso_image(task)"},{"line_number":568,"context_line":"            ilo_common.cleanup_vmedia_boot(task)"},{"line_number":569,"context_line":"        task.node.driver_internal_info \u003d driver_internal_info"},{"line_number":570,"context_line":"        task.node.save()"},{"line_number":571,"context_line":""},{"line_number":572,"context_line":"    @METRICS.timer(\u0027IloVirtualMediaBoot.clean_up_ramdisk\u0027)"},{"line_number":573,"context_line":"    def clean_up_ramdisk(self, task):"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_30b0d0dd","line":570,"range":{"start_line":569,"start_character":8,"end_line":570,"end_character":24},"updated":"2020-09-19 11:55:24.000000000","message":"This can be moved to L566","commit_id":"7530122d9207e6852460a578462f2514b592515d"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"fa24b99463df07c10357873e601bebe715ac494e","unresolved":false,"context_lines":[{"line_number":566,"context_line":"        else:"},{"line_number":567,"context_line":"            image_utils.cleanup_iso_image(task)"},{"line_number":568,"context_line":"            ilo_common.cleanup_vmedia_boot(task)"},{"line_number":569,"context_line":"        task.node.driver_internal_info \u003d driver_internal_info"},{"line_number":570,"context_line":"        task.node.save()"},{"line_number":571,"context_line":""},{"line_number":572,"context_line":"    @METRICS.timer(\u0027IloVirtualMediaBoot.clean_up_ramdisk\u0027)"},{"line_number":573,"context_line":"    def clean_up_ramdisk(self, task):"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_16b784f7","line":570,"range":{"start_line":569,"start_character":8,"end_line":570,"end_character":24},"in_reply_to":"9f560f44_30b0d0dd","updated":"2020-09-19 20:50:59.000000000","message":"Done","commit_id":"7530122d9207e6852460a578462f2514b592515d"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"1bd3db1b6395ee1058ca05d1de6e68d6b272e8f2","unresolved":false,"context_lines":[{"line_number":912,"context_line":"                           for k in params_to_check}"},{"line_number":913,"context_line":""},{"line_number":914,"context_line":"        deploy_info.update("},{"line_number":915,"context_line":"            {option: info.get(option, getattr(CONF.conductor, option, None))"},{"line_number":916,"context_line":"             for option in OPTIONAL_PROPERTIES})"},{"line_number":917,"context_line":""},{"line_number":918,"context_line":"        self._validate_hrefs(deploy_info)"},{"line_number":919,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_70c9a858","line":916,"range":{"start_line":915,"start_character":38,"end_line":916,"end_character":47},"updated":"2020-09-19 11:55:24.000000000","message":"ditto","commit_id":"7530122d9207e6852460a578462f2514b592515d"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"fa24b99463df07c10357873e601bebe715ac494e","unresolved":false,"context_lines":[{"line_number":912,"context_line":"                           for k in params_to_check}"},{"line_number":913,"context_line":""},{"line_number":914,"context_line":"        deploy_info.update("},{"line_number":915,"context_line":"            {option: info.get(option, getattr(CONF.conductor, option, None))"},{"line_number":916,"context_line":"             for option in OPTIONAL_PROPERTIES})"},{"line_number":917,"context_line":""},{"line_number":918,"context_line":"        self._validate_hrefs(deploy_info)"},{"line_number":919,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_d6b86cc8","line":916,"range":{"start_line":915,"start_character":38,"end_line":916,"end_character":47},"in_reply_to":"9f560f44_70c9a858","updated":"2020-09-19 20:50:59.000000000","message":"Done","commit_id":"7530122d9207e6852460a578462f2514b592515d"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"92b8ae0d5f21755cae1f4c913a94646abf0f620b","unresolved":false,"context_lines":[{"line_number":104,"context_line":"    elif mode \u003d\u003d \u0027deploy\u0027 and info.get(\u0027ilo_deploy_iso\u0027):"},{"line_number":105,"context_line":"        d_info[\u0027ilo_deploy_iso\u0027] \u003d info.get(\u0027ilo_deploy_iso\u0027)"},{"line_number":106,"context_line":"    else:"},{"line_number":107,"context_line":"        params_to_check \u003d KERNEL_RAMDISK_LABELS[mode]"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"        d_info \u003d {option: info.get(option)"},{"line_number":110,"context_line":"                  for option in params_to_check}"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_e234caae","line":107,"range":{"start_line":107,"start_character":8,"end_line":107,"end_character":53},"updated":"2020-09-21 06:37:14.000000000","message":"\"ilo_bootloader\" should be included in this list which is missing.","commit_id":"afaf061cd9261155079ca939c8025edfeacaafcb"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"997fe7cb8511fd529efd3e0f23d35b30cfcdd6b6","unresolved":false,"context_lines":[{"line_number":104,"context_line":"    elif mode \u003d\u003d \u0027deploy\u0027 and info.get(\u0027ilo_deploy_iso\u0027):"},{"line_number":105,"context_line":"        d_info[\u0027ilo_deploy_iso\u0027] \u003d info.get(\u0027ilo_deploy_iso\u0027)"},{"line_number":106,"context_line":"    else:"},{"line_number":107,"context_line":"        params_to_check \u003d KERNEL_RAMDISK_LABELS[mode]"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"        d_info \u003d {option: info.get(option)"},{"line_number":110,"context_line":"                  for option in params_to_check}"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_5fad76e8","line":107,"range":{"start_line":107,"start_character":8,"end_line":107,"end_character":53},"in_reply_to":"9f560f44_e234caae","updated":"2020-09-22 05:44:48.000000000","message":"ilo_bootloader is not mandatory because it is not required in case of BIOS image. So when user is trying to boot in BIOS mode they won\u0027t pass the bootloader.","commit_id":"afaf061cd9261155079ca939c8025edfeacaafcb"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"92b8ae0d5f21755cae1f4c913a94646abf0f620b","unresolved":false,"context_lines":[{"line_number":113,"context_line":"            # NOTE(dtantsur): avoid situation when e.g. deploy_kernel comes"},{"line_number":114,"context_line":"            # from driver_info but deploy_ramdisk comes from configuration,"},{"line_number":115,"context_line":"            # since it\u0027s a sign of a potential operator\u0027s mistake."},{"line_number":116,"context_line":"            d_info \u003d {k: getattr(CONF.conductor, k.replace(\u0027ilo_\u0027, \u0027\u0027))"},{"line_number":117,"context_line":"                      for k in params_to_check}"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    error_msg \u003d (_(\"Error validating iLO virtual media for %s. Some \""}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_824d0e3d","line":116,"range":{"start_line":116,"start_character":49,"end_line":116,"end_character":70},"updated":"2020-09-21 06:37:14.000000000","message":"This is no more required i suppose. We can directly pass ilo_deploy_kernel. ilo_deploy_ramdisk and ilo_bootloader directly.","commit_id":"afaf061cd9261155079ca939c8025edfeacaafcb"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"751ab8e8fcb7ce80e068d9fb85b368a5c930e367","unresolved":false,"context_lines":[{"line_number":113,"context_line":"            # NOTE(dtantsur): avoid situation when e.g. deploy_kernel comes"},{"line_number":114,"context_line":"            # from driver_info but deploy_ramdisk comes from configuration,"},{"line_number":115,"context_line":"            # since it\u0027s a sign of a potential operator\u0027s mistake."},{"line_number":116,"context_line":"            d_info \u003d {k: getattr(CONF.conductor, k.replace(\u0027ilo_\u0027, \u0027\u0027))"},{"line_number":117,"context_line":"                      for k in params_to_check}"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    error_msg \u003d (_(\"Error validating iLO virtual media for %s. Some \""}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_997e20ad","line":116,"range":{"start_line":116,"start_character":49,"end_line":116,"end_character":70},"in_reply_to":"9f560f44_824d0e3d","updated":"2020-09-21 09:13:17.000000000","message":"Ignore this comment as i now understand this is a fallback. But see my other comment on the same code.","commit_id":"afaf061cd9261155079ca939c8025edfeacaafcb"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"751ab8e8fcb7ce80e068d9fb85b368a5c930e367","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        d_info \u003d {option: info.get(option)"},{"line_number":110,"context_line":"                  for option in params_to_check}"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        if not any(d_info.values()):"},{"line_number":113,"context_line":"            # NOTE(dtantsur): avoid situation when e.g. deploy_kernel comes"},{"line_number":114,"context_line":"            # from driver_info but deploy_ramdisk comes from configuration,"},{"line_number":115,"context_line":"            # since it\u0027s a sign of a potential operator\u0027s mistake."},{"line_number":116,"context_line":"            d_info \u003d {k: getattr(CONF.conductor, k.replace(\u0027ilo_\u0027, \u0027\u0027))"},{"line_number":117,"context_line":"                      for k in params_to_check}"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    error_msg \u003d (_(\"Error validating iLO virtual media for %s. Some \""},{"line_number":120,"context_line":"                   \"parameters were missing in node\u0027s driver_info.\") % mode)"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_2c3994ce","line":117,"range":{"start_line":112,"start_character":0,"end_line":117,"end_character":47},"updated":"2020-09-21 09:13:17.000000000","message":"IMO we should not use the values of deploy_kernel in place of ilo_deploy_kernel and similarly for other fields. Rather we should throw MissingParameterValue exception immediately. The other option would be to define the config parameters for ilo_deploy_kernel, ilo_deploy_ramdisk, ilo_bootloader and use them as default.","commit_id":"afaf061cd9261155079ca939c8025edfeacaafcb"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"997fe7cb8511fd529efd3e0f23d35b30cfcdd6b6","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        d_info \u003d {option: info.get(option)"},{"line_number":110,"context_line":"                  for option in params_to_check}"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        if not any(d_info.values()):"},{"line_number":113,"context_line":"            # NOTE(dtantsur): avoid situation when e.g. deploy_kernel comes"},{"line_number":114,"context_line":"            # from driver_info but deploy_ramdisk comes from configuration,"},{"line_number":115,"context_line":"            # since it\u0027s a sign of a potential operator\u0027s mistake."},{"line_number":116,"context_line":"            d_info \u003d {k: getattr(CONF.conductor, k.replace(\u0027ilo_\u0027, \u0027\u0027))"},{"line_number":117,"context_line":"                      for k in params_to_check}"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    error_msg \u003d (_(\"Error validating iLO virtual media for %s. Some \""},{"line_number":120,"context_line":"                   \"parameters were missing in node\u0027s driver_info.\") % mode)"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_5fc45692","line":117,"range":{"start_line":112,"start_character":0,"end_line":117,"end_character":47},"in_reply_to":"9f560f44_2c3994ce","updated":"2020-09-22 05:44:48.000000000","message":"We can use deploy_kernel and deploy_ramdisk because images are independent of hardware types. So isn\u0027t it better to use the existing config params?","commit_id":"afaf061cd9261155079ca939c8025edfeacaafcb"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"92b8ae0d5f21755cae1f4c913a94646abf0f620b","unresolved":false,"context_lines":[{"line_number":121,"context_line":"    deploy_utils.check_for_missing_params(d_info, error_msg)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    d_info.update("},{"line_number":124,"context_line":"        {k: info.get(k, getattr(CONF.conductor, k.replace(\u0027ilo_\u0027, \u0027\u0027), None))"},{"line_number":125,"context_line":"         for k in OPTIONAL_PROPERTIES})"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    return d_info"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_c260a6a7","line":124,"range":{"start_line":124,"start_character":47,"end_line":124,"end_character":69},"updated":"2020-09-21 06:37:14.000000000","message":"ditto","commit_id":"afaf061cd9261155079ca939c8025edfeacaafcb"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"751ab8e8fcb7ce80e068d9fb85b368a5c930e367","unresolved":false,"context_lines":[{"line_number":121,"context_line":"    deploy_utils.check_for_missing_params(d_info, error_msg)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    d_info.update("},{"line_number":124,"context_line":"        {k: info.get(k, getattr(CONF.conductor, k.replace(\u0027ilo_\u0027, \u0027\u0027), None))"},{"line_number":125,"context_line":"         for k in OPTIONAL_PROPERTIES})"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    return d_info"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_cc73b8b3","line":124,"range":{"start_line":124,"start_character":47,"end_line":124,"end_character":69},"in_reply_to":"9f560f44_c260a6a7","updated":"2020-09-21 09:13:17.000000000","message":"Ignore this comment.","commit_id":"afaf061cd9261155079ca939c8025edfeacaafcb"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"92b8ae0d5f21755cae1f4c913a94646abf0f620b","unresolved":false,"context_lines":[{"line_number":465,"context_line":"        else:"},{"line_number":466,"context_line":"            mode \u003d deploy_utils.rescue_or_deploy_mode(node)"},{"line_number":467,"context_line":"            d_info \u003d parse_driver_info(node, mode)"},{"line_number":468,"context_line":"            iso \u003d image_utils.prepare_deploy_iso(task, ramdisk_params,"},{"line_number":469,"context_line":"                                                 mode, d_info)"},{"line_number":470,"context_line":""},{"line_number":471,"context_line":"        ilo_common.setup_vmedia(task, iso, ramdisk_params)"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_02845ed2","line":468,"range":{"start_line":468,"start_character":12,"end_line":468,"end_character":70},"updated":"2020-09-21 06:37:14.000000000","message":"Just mentioning here to keep track of the changes we are required to make in the documentation.Once we start to support building the ISO this way, it also comes with a benefit of supporting netowrk configuration using \"--network-data\" field in ironic and with Glean support. So this should be duly mentioned in the documentation of iLO drivers explicites byt a note.","commit_id":"afaf061cd9261155079ca939c8025edfeacaafcb"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"92b8ae0d5f21755cae1f4c913a94646abf0f620b","unresolved":false,"context_lines":[{"line_number":465,"context_line":"        else:"},{"line_number":466,"context_line":"            mode \u003d deploy_utils.rescue_or_deploy_mode(node)"},{"line_number":467,"context_line":"            d_info \u003d parse_driver_info(node, mode)"},{"line_number":468,"context_line":"            iso \u003d image_utils.prepare_deploy_iso(task, ramdisk_params,"},{"line_number":469,"context_line":"                                                 mode, d_info)"},{"line_number":470,"context_line":""},{"line_number":471,"context_line":"        ilo_common.setup_vmedia(task, iso, ramdisk_params)"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_e2116ab1","line":468,"range":{"start_line":468,"start_character":18,"end_line":468,"end_character":48},"updated":"2020-09-21 06:37:14.000000000","message":"This change should go in tandem with floppyless deploy similar to redfish. In other words, now that we have the ISO that contains the necessary info, preparing the floppy image is redundant. It should be removed as floppy usage is obsolete and if we don\u0027t do it now removing that later will be difficult due to backward compatibility issues.","commit_id":"afaf061cd9261155079ca939c8025edfeacaafcb"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"d9280099e696fe699aafd76e256b63be182e51f8","unresolved":false,"context_lines":[{"line_number":465,"context_line":"        else:"},{"line_number":466,"context_line":"            mode \u003d deploy_utils.rescue_or_deploy_mode(node)"},{"line_number":467,"context_line":"            d_info \u003d parse_driver_info(node, mode)"},{"line_number":468,"context_line":"            iso \u003d image_utils.prepare_deploy_iso(task, ramdisk_params,"},{"line_number":469,"context_line":"                                                 mode, d_info)"},{"line_number":470,"context_line":""},{"line_number":471,"context_line":"        ilo_common.setup_vmedia(task, iso, ramdisk_params)"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_dc086fda","line":468,"range":{"start_line":468,"start_character":12,"end_line":468,"end_character":70},"in_reply_to":"9f560f44_02845ed2","updated":"2020-09-22 09:33:24.000000000","message":"Done","commit_id":"afaf061cd9261155079ca939c8025edfeacaafcb"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"f26dcfc01b42faf104afe6e4cf225c8df9db379b","unresolved":false,"context_lines":[{"line_number":465,"context_line":"        else:"},{"line_number":466,"context_line":"            mode \u003d deploy_utils.rescue_or_deploy_mode(node)"},{"line_number":467,"context_line":"            d_info \u003d parse_driver_info(node, mode)"},{"line_number":468,"context_line":"            iso \u003d image_utils.prepare_deploy_iso(task, ramdisk_params,"},{"line_number":469,"context_line":"                                                 mode, d_info)"},{"line_number":470,"context_line":""},{"line_number":471,"context_line":"        ilo_common.setup_vmedia(task, iso, ramdisk_params)"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_3f2082b0","line":468,"range":{"start_line":468,"start_character":18,"end_line":468,"end_character":48},"in_reply_to":"9f560f44_e2116ab1","updated":"2020-09-22 06:04:07.000000000","message":"This can be done as part of another patch.","commit_id":"afaf061cd9261155079ca939c8025edfeacaafcb"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"92b8ae0d5f21755cae1f4c913a94646abf0f620b","unresolved":false,"context_lines":[{"line_number":908,"context_line":"            # NOTE(dtantsur): avoid situation when e.g. deploy_kernel comes"},{"line_number":909,"context_line":"            # from driver_info but deploy_ramdisk comes from configuration,"},{"line_number":910,"context_line":"            # since it\u0027s a sign of a potential operator\u0027s mistake."},{"line_number":911,"context_line":"            deploy_info \u003d {k: getattr(CONF.conductor, k.replace(\u0027ilo_\u0027, \u0027\u0027))"},{"line_number":912,"context_line":"                           for k in params_to_check}"},{"line_number":913,"context_line":""},{"line_number":914,"context_line":"        deploy_info.update("}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_8266aeba","line":911,"range":{"start_line":911,"start_character":53,"end_line":911,"end_character":71},"updated":"2020-09-21 06:37:14.000000000","message":"no more required i think.","commit_id":"afaf061cd9261155079ca939c8025edfeacaafcb"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"751ab8e8fcb7ce80e068d9fb85b368a5c930e367","unresolved":false,"context_lines":[{"line_number":908,"context_line":"            # NOTE(dtantsur): avoid situation when e.g. deploy_kernel comes"},{"line_number":909,"context_line":"            # from driver_info but deploy_ramdisk comes from configuration,"},{"line_number":910,"context_line":"            # since it\u0027s a sign of a potential operator\u0027s mistake."},{"line_number":911,"context_line":"            deploy_info \u003d {k: getattr(CONF.conductor, k.replace(\u0027ilo_\u0027, \u0027\u0027))"},{"line_number":912,"context_line":"                           for k in params_to_check}"},{"line_number":913,"context_line":""},{"line_number":914,"context_line":"        deploy_info.update("}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_cc98d8cd","line":911,"range":{"start_line":911,"start_character":53,"end_line":911,"end_character":71},"in_reply_to":"9f560f44_8266aeba","updated":"2020-09-21 09:13:17.000000000","message":"Ignore this comment as i see this as a fallback option. But see my other comment in the same context.","commit_id":"afaf061cd9261155079ca939c8025edfeacaafcb"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"92b8ae0d5f21755cae1f4c913a94646abf0f620b","unresolved":false,"context_lines":[{"line_number":913,"context_line":""},{"line_number":914,"context_line":"        deploy_info.update("},{"line_number":915,"context_line":"            {k: info.get(k, getattr(CONF.conductor,"},{"line_number":916,"context_line":"                                    k.replace(\u0027ilo_\u0027, \u0027\u0027), None))"},{"line_number":917,"context_line":"             for k in OPTIONAL_PROPERTIES})"},{"line_number":918,"context_line":""},{"line_number":919,"context_line":"        self._validate_hrefs(deploy_info)"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_220d22e8","line":916,"range":{"start_line":916,"start_character":35,"end_line":916,"end_character":58},"updated":"2020-09-21 06:37:14.000000000","message":"ditto. Everywhere applicable.","commit_id":"afaf061cd9261155079ca939c8025edfeacaafcb"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"751ab8e8fcb7ce80e068d9fb85b368a5c930e367","unresolved":false,"context_lines":[{"line_number":913,"context_line":""},{"line_number":914,"context_line":"        deploy_info.update("},{"line_number":915,"context_line":"            {k: info.get(k, getattr(CONF.conductor,"},{"line_number":916,"context_line":"                                    k.replace(\u0027ilo_\u0027, \u0027\u0027), None))"},{"line_number":917,"context_line":"             for k in OPTIONAL_PROPERTIES})"},{"line_number":918,"context_line":""},{"line_number":919,"context_line":"        self._validate_hrefs(deploy_info)"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_ecf31c08","line":916,"range":{"start_line":916,"start_character":35,"end_line":916,"end_character":58},"in_reply_to":"9f560f44_220d22e8","updated":"2020-09-21 09:13:17.000000000","message":"ignore this comment.","commit_id":"afaf061cd9261155079ca939c8025edfeacaafcb"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"751ab8e8fcb7ce80e068d9fb85b368a5c930e367","unresolved":false,"context_lines":[{"line_number":904,"context_line":"        deploy_info \u003d {option: info.get(option)"},{"line_number":905,"context_line":"                       for option in params_to_check}"},{"line_number":906,"context_line":""},{"line_number":907,"context_line":"        if not any(deploy_info.values()):"},{"line_number":908,"context_line":"            # NOTE(dtantsur): avoid situation when e.g. deploy_kernel comes"},{"line_number":909,"context_line":"            # from driver_info but deploy_ramdisk comes from configuration,"},{"line_number":910,"context_line":"            # since it\u0027s a sign of a potential operator\u0027s mistake."},{"line_number":911,"context_line":"            deploy_info \u003d {k: getattr(CONF.conductor, k.replace(\u0027ilo_\u0027, \u0027\u0027))"},{"line_number":912,"context_line":"                           for k in params_to_check}"},{"line_number":913,"context_line":""},{"line_number":914,"context_line":"        deploy_info.update("},{"line_number":915,"context_line":"            {k: info.get(k, getattr(CONF.conductor,"},{"line_number":916,"context_line":"                                    k.replace(\u0027ilo_\u0027, \u0027\u0027), None))"},{"line_number":917,"context_line":"             for k in OPTIONAL_PROPERTIES})"},{"line_number":918,"context_line":""},{"line_number":919,"context_line":"        self._validate_hrefs(deploy_info)"},{"line_number":920,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_4c95e887","line":917,"range":{"start_line":907,"start_character":1,"end_line":917,"end_character":43},"updated":"2020-09-21 09:13:17.000000000","message":"IMO we should just throw an error and bail out instead of trying to assign deploy_kernel to ilo_deploy_kernel etc.","commit_id":"afaf061cd9261155079ca939c8025edfeacaafcb"}],"releasenotes/notes/add-iso-less-vmedia-ilo-5816922c03d0fd85.yaml":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"484b0332770fbd37362b2a842a76a634e360ad30","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add functionality to perform virtual media boot without"},{"line_number":5,"context_line":"    user-built deploy/rescue/boot ISO images for hardware type "},{"line_number":6,"context_line":"    ilo and ilo5. Instead, ironic will build necessary images "},{"line_number":7,"context_line":"    out of common kernel/ramdisk pair"},{"line_number":8,"context_line":"    (though user needs to provide ESP image)."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9f560f44_018145fc","line":5,"range":{"start_line":4,"start_character":4,"end_line":5,"end_character":63},"updated":"2020-09-16 08:13:27.000000000","message":"Also it will start supporting DHCP less deploy. See [1]\n[1] https://review.opendev.org/#/c/751139/1/releasenotes/notes/dhcpless-deploy-4b91de74adeff781.yaml","commit_id":"d301f7682220e88af4ba02b90c8101d04f474f80"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"4be4132ff77a38c85fa073ed666c27dc12075a9f","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add functionality to perform virtual media boot without"},{"line_number":5,"context_line":"    user-built deploy/rescue/boot ISO images for hardware type "},{"line_number":6,"context_line":"    ilo and ilo5. Instead, ironic will build necessary images "},{"line_number":7,"context_line":"    out of common kernel/ramdisk pair"},{"line_number":8,"context_line":"    (though user needs to provide ESP image)."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9f560f44_dc31025c","line":5,"updated":"2020-09-15 13:32:47.000000000","message":"trailing whitespace","commit_id":"d301f7682220e88af4ba02b90c8101d04f474f80"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"43ccc09be788bf7217fe1ac90ed5cdeef1215760","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add functionality to perform virtual media boot without"},{"line_number":5,"context_line":"    user-built deploy/rescue/boot ISO images for hardware type "},{"line_number":6,"context_line":"    ilo and ilo5. Instead, ironic will build necessary images "},{"line_number":7,"context_line":"    out of common kernel/ramdisk pair"},{"line_number":8,"context_line":"    (though user needs to provide ESP image)."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9f560f44_0bbaffbe","line":5,"range":{"start_line":4,"start_character":4,"end_line":5,"end_character":63},"in_reply_to":"9f560f44_018145fc","updated":"2020-09-16 12:55:55.000000000","message":"Done","commit_id":"d301f7682220e88af4ba02b90c8101d04f474f80"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"43ccc09be788bf7217fe1ac90ed5cdeef1215760","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add functionality to perform virtual media boot without"},{"line_number":5,"context_line":"    user-built deploy/rescue/boot ISO images for hardware type "},{"line_number":6,"context_line":"    ilo and ilo5. Instead, ironic will build necessary images "},{"line_number":7,"context_line":"    out of common kernel/ramdisk pair"},{"line_number":8,"context_line":"    (though user needs to provide ESP image)."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9f560f44_2b76e30d","line":5,"in_reply_to":"9f560f44_dc31025c","updated":"2020-09-16 12:55:55.000000000","message":"Done","commit_id":"d301f7682220e88af4ba02b90c8101d04f474f80"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"4be4132ff77a38c85fa073ed666c27dc12075a9f","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add functionality to perform virtual media boot without"},{"line_number":5,"context_line":"    user-built deploy/rescue/boot ISO images for hardware type "},{"line_number":6,"context_line":"    ilo and ilo5. Instead, ironic will build necessary images "},{"line_number":7,"context_line":"    out of common kernel/ramdisk pair"},{"line_number":8,"context_line":"    (though user needs to provide ESP image)."},{"line_number":9,"context_line":"    User provided deploy/rescue/boot ISO images are"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9f560f44_7c2c3601","line":6,"updated":"2020-09-15 13:32:47.000000000","message":"Trailing whitespace","commit_id":"d301f7682220e88af4ba02b90c8101d04f474f80"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"43ccc09be788bf7217fe1ac90ed5cdeef1215760","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add functionality to perform virtual media boot without"},{"line_number":5,"context_line":"    user-built deploy/rescue/boot ISO images for hardware type "},{"line_number":6,"context_line":"    ilo and ilo5. Instead, ironic will build necessary images "},{"line_number":7,"context_line":"    out of common kernel/ramdisk pair"},{"line_number":8,"context_line":"    (though user needs to provide ESP image)."},{"line_number":9,"context_line":"    User provided deploy/rescue/boot ISO images are"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9f560f44_0b7b1ff4","line":6,"in_reply_to":"9f560f44_7c2c3601","updated":"2020-09-16 12:55:55.000000000","message":"Done","commit_id":"d301f7682220e88af4ba02b90c8101d04f474f80"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"4be4132ff77a38c85fa073ed666c27dc12075a9f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9f560f44_1c241a0e","line":11,"updated":"2020-09-15 13:32:47.000000000","message":"I\u0027m wondering if it makes sense to mention the refactoring to use the common code path that was in the redfish driver but that was moved out?","commit_id":"d301f7682220e88af4ba02b90c8101d04f474f80"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"43ccc09be788bf7217fe1ac90ed5cdeef1215760","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9f560f44_799c315b","line":11,"in_reply_to":"9f560f44_1c241a0e","updated":"2020-09-16 12:55:55.000000000","message":"Done","commit_id":"d301f7682220e88af4ba02b90c8101d04f474f80"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"8b4ecf415c01d788755fd707a087b68d0647461e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add functionality to perform virtual media boot without"},{"line_number":5,"context_line":"    user-built deploy/rescue/boot ISO images for hardware type"},{"line_number":6,"context_line":"    ilo and ilo5. Instead, ironic will build necessary images"},{"line_number":7,"context_line":"    out of common kernel/ramdisk pair"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_dd2ed240","line":4,"range":{"start_line":4,"start_character":1,"end_line":4,"end_character":7},"updated":"2020-09-18 20:30:44.000000000","message":"s/Add/Adds/\n\nAlso maybe say \"Adds functionality to the ilo and ilo5 hardware types enabling $item\" ?","commit_id":"9c295c8f2eb62c3ecff80bb8bfc87fed3016f45e"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"e733a3566176304d9c926e814c1d3007b30bf639","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add functionality to perform virtual media boot without"},{"line_number":5,"context_line":"    user-built deploy/rescue/boot ISO images for hardware type"},{"line_number":6,"context_line":"    ilo and ilo5. Instead, ironic will build necessary images"},{"line_number":7,"context_line":"    out of common kernel/ramdisk pair"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_6daf132b","line":4,"range":{"start_line":4,"start_character":1,"end_line":4,"end_character":7},"in_reply_to":"9f560f44_dd2ed240","updated":"2020-09-19 06:59:31.000000000","message":"Done","commit_id":"9c295c8f2eb62c3ecff80bb8bfc87fed3016f45e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"8b4ecf415c01d788755fd707a087b68d0647461e","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    user-built deploy/rescue/boot ISO images for hardware type"},{"line_number":6,"context_line":"    ilo and ilo5. Instead, ironic will build necessary images"},{"line_number":7,"context_line":"    out of common kernel/ramdisk pair"},{"line_number":8,"context_line":"    (though user needs to provide ESP image) by using the"},{"line_number":9,"context_line":"    common code that was earlier in the redfish driver"},{"line_number":10,"context_line":"    but moved out to `drivers/image_utils` file."},{"line_number":11,"context_line":"    User provided deploy/rescue/boot ISO images are"},{"line_number":12,"context_line":"    also supported."},{"line_number":13,"context_line":"    Also it will start supporting DHCP less deploy."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_bd003ead","line":10,"range":{"start_line":8,"start_character":45,"end_line":10,"end_character":48},"updated":"2020-09-18 20:30:44.000000000","message":"This is a detail that maybe a developer would like to know, but operators don\u0027t need nor really want to understand the locations of the code unless they are hunting down a bug. In other words, the audience of the release note doesn\u0027t need to know this.","commit_id":"9c295c8f2eb62c3ecff80bb8bfc87fed3016f45e"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"e733a3566176304d9c926e814c1d3007b30bf639","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    user-built deploy/rescue/boot ISO images for hardware type"},{"line_number":6,"context_line":"    ilo and ilo5. Instead, ironic will build necessary images"},{"line_number":7,"context_line":"    out of common kernel/ramdisk pair"},{"line_number":8,"context_line":"    (though user needs to provide ESP image) by using the"},{"line_number":9,"context_line":"    common code that was earlier in the redfish driver"},{"line_number":10,"context_line":"    but moved out to `drivers/image_utils` file."},{"line_number":11,"context_line":"    User provided deploy/rescue/boot ISO images are"},{"line_number":12,"context_line":"    also supported."},{"line_number":13,"context_line":"    Also it will start supporting DHCP less deploy."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_4daa0f1a","line":10,"range":{"start_line":8,"start_character":45,"end_line":10,"end_character":48},"in_reply_to":"9f560f44_bd003ead","updated":"2020-09-19 06:59:31.000000000","message":"Done","commit_id":"9c295c8f2eb62c3ecff80bb8bfc87fed3016f45e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"8b4ecf415c01d788755fd707a087b68d0647461e","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    but moved out to `drivers/image_utils` file."},{"line_number":11,"context_line":"    User provided deploy/rescue/boot ISO images are"},{"line_number":12,"context_line":"    also supported."},{"line_number":13,"context_line":"    Also it will start supporting DHCP less deploy."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_5d6c829c","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":51},"updated":"2020-09-18 20:30:44.000000000","message":"Lets add this as a separate feature entry.","commit_id":"9c295c8f2eb62c3ecff80bb8bfc87fed3016f45e"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"e733a3566176304d9c926e814c1d3007b30bf639","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    but moved out to `drivers/image_utils` file."},{"line_number":11,"context_line":"    User provided deploy/rescue/boot ISO images are"},{"line_number":12,"context_line":"    also supported."},{"line_number":13,"context_line":"    Also it will start supporting DHCP less deploy."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_ada92b25","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":51},"in_reply_to":"9f560f44_5d6c829c","updated":"2020-09-19 06:59:31.000000000","message":"Done","commit_id":"9c295c8f2eb62c3ecff80bb8bfc87fed3016f45e"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"c860207b5720cbdf1275d67075b36111e0d6bd38","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    User provided deploy/rescue/boot ISO images are"},{"line_number":10,"context_line":"    also supported."},{"line_number":11,"context_line":"  - |"},{"line_number":12,"context_line":"    Adds support of dhcp less deploy to ilo and ilo5"},{"line_number":13,"context_line":"    hardware types."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9f560f44_908b9cbe","line":12,"range":{"start_line":12,"start_character":20,"end_line":12,"end_character":36},"updated":"2020-09-19 12:00:59.000000000","message":"Better to elaborate on this, like:-\n\"Using the ``network_data`` property on the node field,    operators can now apply network configuration to be embedded    in Redfish based Virtual Media based deployment ramdisks which include networking configuration enabling the deployment to operate without the use of DHCP.\" \n\nAlso update this feature information in ilo documentation (ilo.rst file).","commit_id":"7530122d9207e6852460a578462f2514b592515d"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"fa24b99463df07c10357873e601bebe715ac494e","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    User provided deploy/rescue/boot ISO images are"},{"line_number":10,"context_line":"    also supported."},{"line_number":11,"context_line":"  - |"},{"line_number":12,"context_line":"    Adds support of dhcp less deploy to ilo and ilo5"},{"line_number":13,"context_line":"    hardware types."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9f560f44_76c9a058","line":12,"range":{"start_line":12,"start_character":20,"end_line":12,"end_character":36},"in_reply_to":"9f560f44_908b9cbe","updated":"2020-09-19 20:50:59.000000000","message":"Done","commit_id":"7530122d9207e6852460a578462f2514b592515d"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"f4a1d45e1059634e1f424435ac353ac7f0d9da98","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds functionality to the ilo and ilo5 hardware types"},{"line_number":5,"context_line":"    by enabling virtual media boot without user-built"},{"line_number":6,"context_line":"    deploy/rescue/boot ISO images. Instead, ironic will"},{"line_number":7,"context_line":"    build necessary images out of common kernel/ramdisk"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9f560f44_41765841","line":4,"range":{"start_line":4,"start_character":30,"end_line":4,"end_character":42},"updated":"2020-09-20 11:07:17.000000000","message":"s/ ilo and ilo5 / ``ilo`` and ``ilo5`` /","commit_id":"fa2a89c036ebffd96b71080dbd1f6eeec2cb93f0"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"e9ebfa3598c942c8886de9ba14781e2f6fd43bde","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds functionality to the ilo and ilo5 hardware types"},{"line_number":5,"context_line":"    by enabling virtual media boot without user-built"},{"line_number":6,"context_line":"    deploy/rescue/boot ISO images. Instead, ironic will"},{"line_number":7,"context_line":"    build necessary images out of common kernel/ramdisk"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9f560f44_67744cd1","line":4,"range":{"start_line":4,"start_character":30,"end_line":4,"end_character":42},"in_reply_to":"9f560f44_41765841","updated":"2020-09-21 03:47:34.000000000","message":"Done","commit_id":"fa2a89c036ebffd96b71080dbd1f6eeec2cb93f0"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"f4a1d45e1059634e1f424435ac353ac7f0d9da98","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    User provided deploy/rescue/boot ISO images are"},{"line_number":10,"context_line":"    also supported."},{"line_number":11,"context_line":"  - |"},{"line_number":12,"context_line":"    Adds support of dhcp less deploy to ilo and ilo5"},{"line_number":13,"context_line":"    hardware types by using the ``network_data`` property"},{"line_number":14,"context_line":"    on the node field, operators can now apply network"},{"line_number":15,"context_line":"    configuration to be embedded in Redfish based Virtual"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9f560f44_01858007","line":12,"range":{"start_line":12,"start_character":20,"end_line":12,"end_character":24},"updated":"2020-09-20 11:07:17.000000000","message":"s/ dhcp / DHCP /","commit_id":"fa2a89c036ebffd96b71080dbd1f6eeec2cb93f0"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"f4a1d45e1059634e1f424435ac353ac7f0d9da98","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    User provided deploy/rescue/boot ISO images are"},{"line_number":10,"context_line":"    also supported."},{"line_number":11,"context_line":"  - |"},{"line_number":12,"context_line":"    Adds support of dhcp less deploy to ilo and ilo5"},{"line_number":13,"context_line":"    hardware types by using the ``network_data`` property"},{"line_number":14,"context_line":"    on the node field, operators can now apply network"},{"line_number":15,"context_line":"    configuration to be embedded in Redfish based Virtual"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9f560f44_617b9c28","line":12,"range":{"start_line":12,"start_character":40,"end_line":12,"end_character":52},"updated":"2020-09-20 11:07:17.000000000","message":"s/ ilo and ilo5 / ``ilo`` and ``ilo5`` /","commit_id":"fa2a89c036ebffd96b71080dbd1f6eeec2cb93f0"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"e9ebfa3598c942c8886de9ba14781e2f6fd43bde","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    User provided deploy/rescue/boot ISO images are"},{"line_number":10,"context_line":"    also supported."},{"line_number":11,"context_line":"  - |"},{"line_number":12,"context_line":"    Adds support of dhcp less deploy to ilo and ilo5"},{"line_number":13,"context_line":"    hardware types by using the ``network_data`` property"},{"line_number":14,"context_line":"    on the node field, operators can now apply network"},{"line_number":15,"context_line":"    configuration to be embedded in Redfish based Virtual"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9f560f44_a77e64ac","line":12,"range":{"start_line":12,"start_character":20,"end_line":12,"end_character":24},"in_reply_to":"9f560f44_01858007","updated":"2020-09-21 03:47:34.000000000","message":"Done","commit_id":"fa2a89c036ebffd96b71080dbd1f6eeec2cb93f0"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"e9ebfa3598c942c8886de9ba14781e2f6fd43bde","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    User provided deploy/rescue/boot ISO images are"},{"line_number":10,"context_line":"    also supported."},{"line_number":11,"context_line":"  - |"},{"line_number":12,"context_line":"    Adds support of dhcp less deploy to ilo and ilo5"},{"line_number":13,"context_line":"    hardware types by using the ``network_data`` property"},{"line_number":14,"context_line":"    on the node field, operators can now apply network"},{"line_number":15,"context_line":"    configuration to be embedded in Redfish based Virtual"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9f560f44_8779a0c6","line":12,"range":{"start_line":12,"start_character":40,"end_line":12,"end_character":52},"in_reply_to":"9f560f44_617b9c28","updated":"2020-09-21 03:47:34.000000000","message":"Done","commit_id":"fa2a89c036ebffd96b71080dbd1f6eeec2cb93f0"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"f4a1d45e1059634e1f424435ac353ac7f0d9da98","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    Adds support of dhcp less deploy to ilo and ilo5"},{"line_number":13,"context_line":"    hardware types by using the ``network_data`` property"},{"line_number":14,"context_line":"    on the node field, operators can now apply network"},{"line_number":15,"context_line":"    configuration to be embedded in Redfish based Virtual"},{"line_number":16,"context_line":"    Media based deployment ramdisks which include networking"},{"line_number":17,"context_line":"    configuration enabling the deployment to operate without"},{"line_number":18,"context_line":"    the use of DHCP."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9f560f44_21824401","line":15,"range":{"start_line":15,"start_character":36,"end_line":15,"end_character":49},"updated":"2020-09-20 11:07:17.000000000","message":"s/ Redfish based / iLO based /\nAs this applies to Gen9 servers as well.","commit_id":"fa2a89c036ebffd96b71080dbd1f6eeec2cb93f0"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"e9ebfa3598c942c8886de9ba14781e2f6fd43bde","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    Adds support of dhcp less deploy to ilo and ilo5"},{"line_number":13,"context_line":"    hardware types by using the ``network_data`` property"},{"line_number":14,"context_line":"    on the node field, operators can now apply network"},{"line_number":15,"context_line":"    configuration to be embedded in Redfish based Virtual"},{"line_number":16,"context_line":"    Media based deployment ramdisks which include networking"},{"line_number":17,"context_line":"    configuration enabling the deployment to operate without"},{"line_number":18,"context_line":"    the use of DHCP."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9f560f44_c74c389f","line":15,"range":{"start_line":15,"start_character":36,"end_line":15,"end_character":49},"in_reply_to":"9f560f44_21824401","updated":"2020-09-21 03:47:34.000000000","message":"Done","commit_id":"fa2a89c036ebffd96b71080dbd1f6eeec2cb93f0"}]}