)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a322aa3592737056951020badb9f059b6dac8973","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Handle Redfish error response when turning power off as part of reboot."},{"line_number":10,"context_line":"In some cases a node doesn\u0027t properly report the power state when its"},{"line_number":11,"context_line":"off and as a result returns an error when Ironic powers off the node."},{"line_number":12,"context_line":"Any failure when powering on the node is still treated as an error."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ica910d6dc0b8bc4ee84beca878b0308a0c57d0eb"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9f560f44_3dca6ea0","line":12,"updated":"2020-09-18 19:46:46.000000000","message":"Any story/task with additional information on this? a RHBZ?","commit_id":"e69b8bae4644841a299d95416034f4c00992fd72"}],"ironic/drivers/modules/redfish/power.py":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"f2f7fdc589e3186cce4d422b914350d64301e44b","unresolved":false,"context_lines":[{"line_number":157,"context_line":"            if current_power_state \u003d\u003d states.POWER_ON:"},{"line_number":158,"context_line":"                next_state \u003d states.POWER_OFF"},{"line_number":159,"context_line":"                _set_power_state(task, system, next_state, timeout\u003dtimeout)"},{"line_number":160,"context_line":"        except sushy.exceptions.SushyError as e:"},{"line_number":161,"context_line":"            msg \u003d (_(\u0027Could not set node %(node)s power state to OFF \u0027"},{"line_number":162,"context_line":"                     \u0027Message: %(exc)s\u0027) %"},{"line_number":163,"context_line":"                   {\u0027node\u0027: task.node.uuid, \u0027exc\u0027: e})"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_9e257d0d","line":160,"range":{"start_line":160,"start_character":8,"end_line":160,"end_character":48},"updated":"2020-09-18 11:11:23.000000000","message":"Will it be useful to validate that we are indeed hitting the case wherein node is powered off and just reporting is off track by rechecking the power state of node here?","commit_id":"1aca7dbcd3e9285def5c7142b2ef4a5b3e747b67"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"1073ae6e6e756bdd74e74ebf65f6d29c06a4e493","unresolved":false,"context_lines":[{"line_number":157,"context_line":"            if current_power_state \u003d\u003d states.POWER_ON:"},{"line_number":158,"context_line":"                next_state \u003d states.POWER_OFF"},{"line_number":159,"context_line":"                _set_power_state(task, system, next_state, timeout\u003dtimeout)"},{"line_number":160,"context_line":"        except sushy.exceptions.SushyError as e:"},{"line_number":161,"context_line":"            msg \u003d (_(\u0027Could not set node %(node)s power state to OFF \u0027"},{"line_number":162,"context_line":"                     \u0027Message: %(exc)s\u0027) %"},{"line_number":163,"context_line":"                   {\u0027node\u0027: task.node.uuid, \u0027exc\u0027: e})"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_840b7020","line":160,"range":{"start_line":160,"start_character":8,"end_line":160,"end_character":48},"in_reply_to":"9f560f44_9e257d0d","updated":"2020-09-18 12:29:06.000000000","message":"Thanks Shivinand.  So what we get back from node in this case is \"returned code 409. Base.1.5.GeneralError: Server is already powered OFF\".  We could parse that to determine power is off.","commit_id":"1aca7dbcd3e9285def5c7142b2ef4a5b3e747b67"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"f2f7fdc589e3186cce4d422b914350d64301e44b","unresolved":false,"context_lines":[{"line_number":161,"context_line":"            msg \u003d (_(\u0027Could not set node %(node)s power state to OFF \u0027"},{"line_number":162,"context_line":"                     \u0027Message: %(exc)s\u0027) %"},{"line_number":163,"context_line":"                   {\u0027node\u0027: task.node.uuid, \u0027exc\u0027: e})"},{"line_number":164,"context_line":"            LOG.info(msg)"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"        try:"},{"line_number":167,"context_line":"            if isinstance(task.driver.management,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_de46d5c0","line":164,"range":{"start_line":164,"start_character":12,"end_line":164,"end_character":25},"updated":"2020-09-18 11:11:23.000000000","message":"Should this be LOG.warning?","commit_id":"1aca7dbcd3e9285def5c7142b2ef4a5b3e747b67"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"1073ae6e6e756bdd74e74ebf65f6d29c06a4e493","unresolved":false,"context_lines":[{"line_number":161,"context_line":"            msg \u003d (_(\u0027Could not set node %(node)s power state to OFF \u0027"},{"line_number":162,"context_line":"                     \u0027Message: %(exc)s\u0027) %"},{"line_number":163,"context_line":"                   {\u0027node\u0027: task.node.uuid, \u0027exc\u0027: e})"},{"line_number":164,"context_line":"            LOG.info(msg)"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"        try:"},{"line_number":167,"context_line":"            if isinstance(task.driver.management,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_e41a2c6d","line":164,"range":{"start_line":164,"start_character":12,"end_line":164,"end_character":25},"in_reply_to":"9f560f44_de46d5c0","updated":"2020-09-18 12:29:06.000000000","message":"Sure, will change that.","commit_id":"1aca7dbcd3e9285def5c7142b2ef4a5b3e747b67"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a322aa3592737056951020badb9f059b6dac8973","unresolved":false,"context_lines":[{"line_number":157,"context_line":"            if current_power_state \u003d\u003d states.POWER_ON:"},{"line_number":158,"context_line":"                next_state \u003d states.POWER_OFF"},{"line_number":159,"context_line":"                _set_power_state(task, system, next_state, timeout\u003dtimeout)"},{"line_number":160,"context_line":"        except sushy.exceptions.SushyError as e:"},{"line_number":161,"context_line":"            msg \u003d (_(\u0027Could not set node %(node)s power state to OFF \u0027"},{"line_number":162,"context_line":"                     \u0027Message: %(exc)s\u0027) %"},{"line_number":163,"context_line":"                   {\u0027node\u0027: task.node.uuid, \u0027exc\u0027: e})"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_9d4d7a3d","line":160,"updated":"2020-09-18 19:46:46.000000000","message":"Okay, this worries me a little.\n\nIf the power is on, we attempt to turn the power off. This may raise an exception that doesn\u0027t fail the entire process then except then how do we know the machine was actually powered off? It doesn\u0027t seem like we do?","commit_id":"e69b8bae4644841a299d95416034f4c00992fd72"}]}