)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"4d4071d7f421f4be05514bb55a1ab5607f295db7","unresolved":false,"context_lines":[{"line_number":18,"context_line":"That applies to the Dell EMC integrated Dell Remote Access Controller"},{"line_number":19,"context_line":"(iDRAC)."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"When the annotation is not supported, it is not POST."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"[1] http://redfish.dmtf.org/schemas/DSP0266_1.11.0.html#settings-resource"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f560f44_0f6e42c8","line":21,"range":{"start_line":21,"start_character":38,"end_line":21,"end_character":52},"updated":"2020-09-21 10:16:40.000000000","message":"not clear what is it then. Could be rephrased to not use technical POST.","commit_id":"f92d39908616f870e4e062ef9eba9047f0df650c"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"361c5c52a86d67527abb239fd3608c2827d86258","unresolved":false,"context_lines":[{"line_number":18,"context_line":"That applies to the Dell EMC integrated Dell Remote Access Controller"},{"line_number":19,"context_line":"(iDRAC)."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"When the annotation is not supported, it is not POST."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"[1] http://redfish.dmtf.org/schemas/DSP0266_1.11.0.html#settings-resource"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f560f44_802ce1ac","line":21,"range":{"start_line":21,"start_character":38,"end_line":21,"end_character":52},"in_reply_to":"9f560f44_0f6e42c8","updated":"2020-09-21 13:54:55.000000000","message":"Done","commit_id":"f92d39908616f870e4e062ef9eba9047f0df650c"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"041229dd5bfcff841e2205c02762efb0c90abd68","unresolved":false,"context_lines":[{"line_number":27,"context_line":"Co-Authored-By: Mike Raineri \u003cmraineri@gmail.com\u003e"},{"line_number":28,"context_line":"Story: 2008163"},{"line_number":29,"context_line":"Task: 40913"},{"line_number":30,"context_line":"Depends-On: https://review.opendev.org/#/c/750020/"},{"line_number":31,"context_line":"Change-Id: I28a948f306b40c36b12e6f786e1e43a61e84a0f2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9f560f44_06ee1f20","line":30,"range":{"start_line":30,"start_character":0,"end_line":30,"end_character":50},"updated":"2020-09-21 23:44:42.000000000","message":"Probably no longer need this since sushy has been released with this fix.","commit_id":"62263ea40ef08e66f6af62037b7679c9a593d15a"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"e2fd3cfe15ba820d69c2ca04356863a3f2c0893e","unresolved":false,"context_lines":[{"line_number":27,"context_line":"Co-Authored-By: Mike Raineri \u003cmraineri@gmail.com\u003e"},{"line_number":28,"context_line":"Story: 2008163"},{"line_number":29,"context_line":"Task: 40913"},{"line_number":30,"context_line":"Depends-On: https://review.opendev.org/#/c/750020/"},{"line_number":31,"context_line":"Change-Id: I28a948f306b40c36b12e6f786e1e43a61e84a0f2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9f560f44_86d50fe9","line":30,"range":{"start_line":30,"start_character":0,"end_line":30,"end_character":50},"in_reply_to":"9f560f44_06ee1f20","updated":"2020-09-22 00:31:34.000000000","message":"I hesitated to remove this, because it could provide useful information if this is back ported to stable branches. Thoughts?","commit_id":"62263ea40ef08e66f6af62037b7679c9a593d15a"}],"ironic/drivers/modules/redfish/bios.py":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"31d9ec4d25a1063143d376379fa22c39fb6496ce","unresolved":false,"context_lines":[{"line_number":179,"context_line":"            if (bios.apply_time_settings"},{"line_number":180,"context_line":"                    or sushy.APPLY_TIME_ON_RESET"},{"line_number":181,"context_line":"                    in bios.supported_apply_times):"},{"line_number":182,"context_line":"                apply_time \u003d sushy.APPLY_TIME_ON_RESET"},{"line_number":183,"context_line":"            else:"},{"line_number":184,"context_line":"                apply_time \u003d None"},{"line_number":185,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_e117ac53","line":182,"range":{"start_line":182,"start_character":29,"end_line":182,"end_character":54},"updated":"2020-09-20 14:57:55.000000000","message":"Is it ok to set apply_time to APPLY_TIME_ON_RESET even if its not part of bios.supported_apply_times list? This looks odd.","commit_id":"f92d39908616f870e4e062ef9eba9047f0df650c"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"b8547e9af9f6bd92c7d4735724c90cb506339b5a","unresolved":false,"context_lines":[{"line_number":179,"context_line":"            if (bios.apply_time_settings"},{"line_number":180,"context_line":"                    or sushy.APPLY_TIME_ON_RESET"},{"line_number":181,"context_line":"                    in bios.supported_apply_times):"},{"line_number":182,"context_line":"                apply_time \u003d sushy.APPLY_TIME_ON_RESET"},{"line_number":183,"context_line":"            else:"},{"line_number":184,"context_line":"                apply_time \u003d None"},{"line_number":185,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_276ed4c8","line":182,"range":{"start_line":182,"start_character":29,"end_line":182,"end_character":54},"in_reply_to":"9f560f44_e117ac53","updated":"2020-09-20 21:37:25.000000000","message":"Good catch!\n\nDone","commit_id":"f92d39908616f870e4e062ef9eba9047f0df650c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5833e837b84de8ab8ae6bde03bac0932b56393fe","unresolved":false,"context_lines":[{"line_number":176,"context_line":"                      \u0027%(settings)r\u0027, {\u0027node_uuid\u0027: task.node.uuid,"},{"line_number":177,"context_line":"                                       \u0027settings\u0027: settings})"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"            if (sushy.APPLY_TIME_ON_RESET in bios.supported_apply_times):"},{"line_number":180,"context_line":"                apply_time \u003d sushy.APPLY_TIME_ON_RESET"},{"line_number":181,"context_line":"            else:"},{"line_number":182,"context_line":"                apply_time \u003d None"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_1c35c745","line":179,"updated":"2020-09-22 09:52:20.000000000","message":"Is it possible for supported_apply_times to be None? I guess anything can be None in Redfish, so we have to account for it.\n\nAlso the brackets are redundant.","commit_id":"62263ea40ef08e66f6af62037b7679c9a593d15a"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"0da254dcfbab8cea1706b8607e5a33ae06bd7316","unresolved":false,"context_lines":[{"line_number":176,"context_line":"                      \u0027%(settings)r\u0027, {\u0027node_uuid\u0027: task.node.uuid,"},{"line_number":177,"context_line":"                                       \u0027settings\u0027: settings})"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"            if (sushy.APPLY_TIME_ON_RESET in bios.supported_apply_times):"},{"line_number":180,"context_line":"                apply_time \u003d sushy.APPLY_TIME_ON_RESET"},{"line_number":181,"context_line":"            else:"},{"line_number":182,"context_line":"                apply_time \u003d None"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_986a6db2","line":179,"in_reply_to":"9f560f44_1bbb04e5","updated":"2020-09-23 08:07:08.000000000","message":"looks there is unit test missing for None scenario. There is only for []. Let\u0027s add it? Looking at sushy code it\u0027s possible that it\u0027s None.","commit_id":"62263ea40ef08e66f6af62037b7679c9a593d15a"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"371c326b209a133c172807e5ef3f7b11af10865a","unresolved":false,"context_lines":[{"line_number":176,"context_line":"                      \u0027%(settings)r\u0027, {\u0027node_uuid\u0027: task.node.uuid,"},{"line_number":177,"context_line":"                                       \u0027settings\u0027: settings})"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"            if (sushy.APPLY_TIME_ON_RESET in bios.supported_apply_times):"},{"line_number":180,"context_line":"                apply_time \u003d sushy.APPLY_TIME_ON_RESET"},{"line_number":181,"context_line":"            else:"},{"line_number":182,"context_line":"                apply_time \u003d None"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_1bbb04e5","line":179,"in_reply_to":"9f560f44_1c35c745","updated":"2020-09-22 16:42:41.000000000","message":"Good catch! Now, of course, parentheses are needed.\n\nDone","commit_id":"62263ea40ef08e66f6af62037b7679c9a593d15a"}],"ironic/tests/unit/drivers/modules/redfish/test_bios.py":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"31d9ec4d25a1063143d376379fa22c39fb6496ce","unresolved":false,"context_lines":[{"line_number":403,"context_line":""},{"line_number":404,"context_line":"            bios.set_attributes.assert_called_once_with("},{"line_number":405,"context_line":"                {s[\u0027name\u0027]: s[\u0027value\u0027] for s in settings},"},{"line_number":406,"context_line":"                apply_time\u003dsushy.APPLY_TIME_ON_RESET)"},{"line_number":407,"context_line":""},{"line_number":408,"context_line":"    @mock.patch.object(redfish_boot.RedfishVirtualMediaBoot, \u0027prepare_ramdisk\u0027,"},{"line_number":409,"context_line":"                       spec_set\u003dTrue, autospec\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_a105b416","line":406,"range":{"start_line":406,"start_character":16,"end_line":406,"end_character":52},"updated":"2020-09-20 14:57:55.000000000","message":"This is not part of \u0027supported_apply_times\u0027 at L400.","commit_id":"f92d39908616f870e4e062ef9eba9047f0df650c"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"b8547e9af9f6bd92c7d4735724c90cb506339b5a","unresolved":false,"context_lines":[{"line_number":403,"context_line":""},{"line_number":404,"context_line":"            bios.set_attributes.assert_called_once_with("},{"line_number":405,"context_line":"                {s[\u0027name\u0027]: s[\u0027value\u0027] for s in settings},"},{"line_number":406,"context_line":"                apply_time\u003dsushy.APPLY_TIME_ON_RESET)"},{"line_number":407,"context_line":""},{"line_number":408,"context_line":"    @mock.patch.object(redfish_boot.RedfishVirtualMediaBoot, \u0027prepare_ramdisk\u0027,"},{"line_number":409,"context_line":"                       spec_set\u003dTrue, autospec\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_4762e8da","line":406,"range":{"start_line":406,"start_character":16,"end_line":406,"end_character":52},"in_reply_to":"9f560f44_a105b416","updated":"2020-09-20 21:37:25.000000000","message":"I changed this to align with the change to bios.py which addresses your comment.","commit_id":"f92d39908616f870e4e062ef9eba9047f0df650c"}],"releasenotes/notes/redfish-fix-bios-settings-apply-time-9b50979d2afc0d27.yaml":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"b9c9c240e6da743c3473d0001ecabe571145b458","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes ``redfish`` BIOS interface ``apply_configuration`` cleaning/deploy"},{"line_number":5,"context_line":"    step to interoperate with Redfish Services that enable a client to indicate"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9f560f44_788d1434","line":2,"updated":"2020-09-18 20:56:12.000000000","message":"I believe this is a feature, at least as this is worded.\n\nIf the note says (which I think it likely should say based upon the code) that it fixes support for bios setting application on redfish machines where an apply time MUST be defined, such on on dell iDRACs.\n\nIt appears the library knows when this is the case and raises that to the library user/caller. At which point the caller CAN take the appropriate option. The release note words it as if the client of the system is making a decision of when to set the apply time, and by client in the release note context, I\u0027m meaning the person using/operating ironic.","commit_id":"f92d39908616f870e4e062ef9eba9047f0df650c"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"b8547e9af9f6bd92c7d4735724c90cb506339b5a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes ``redfish`` BIOS interface ``apply_configuration`` cleaning/deploy"},{"line_number":5,"context_line":"    step to interoperate with Redfish Services that enable a client to indicate"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9f560f44_87b1a047","line":2,"in_reply_to":"9f560f44_788d1434","updated":"2020-09-20 21:37:25.000000000","message":"You are correct that this change is a bug fix.\n\nI reworded the note as you suggested.\n\n\u0027client\u0027 was referring to the software client interacting with the Redfish Service, which is the \u0027redfish\u0027 driver and sushy package. Since that word is ambiguous, it is no longer used.","commit_id":"f92d39908616f870e4e062ef9eba9047f0df650c"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"b9c9c240e6da743c3473d0001ecabe571145b458","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes ``redfish`` BIOS interface ``apply_configuration`` cleaning/deploy"},{"line_number":5,"context_line":"    step to interoperate with Redfish Services that enable a client to indicate"},{"line_number":6,"context_line":"    when to apply settings via the Distributed Management Task Force (DMTF)"},{"line_number":7,"context_line":"    Redfish standard ``@Redfish.SettingsApplyTime`` annotation. [1]"},{"line_number":8,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9f560f44_98e46810","line":5,"range":{"start_line":5,"start_character":52,"end_line":5,"end_character":79},"updated":"2020-09-18 20:56:12.000000000","message":"So the client making an active choice of when to make a setting application is a feature unless it is required by the BMC and the BMC informs us as such. The code seems to do that. I really feel like the reno needs to be re-woreded and honestly likely would be edited down prior to release anyway given the target audience is cloud operators/software consumers.","commit_id":"f92d39908616f870e4e062ef9eba9047f0df650c"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"b8547e9af9f6bd92c7d4735724c90cb506339b5a","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes ``redfish`` BIOS interface ``apply_configuration`` cleaning/deploy"},{"line_number":5,"context_line":"    step to interoperate with Redfish Services that enable a client to indicate"},{"line_number":6,"context_line":"    when to apply settings via the Distributed Management Task Force (DMTF)"},{"line_number":7,"context_line":"    Redfish standard ``@Redfish.SettingsApplyTime`` annotation. [1]"},{"line_number":8,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9f560f44_a76144d6","line":5,"range":{"start_line":5,"start_character":52,"end_line":5,"end_character":79},"in_reply_to":"9f560f44_98e46810","updated":"2020-09-20 21:37:25.000000000","message":"I edited it down for the target audience. Please let me know what you think.","commit_id":"f92d39908616f870e4e062ef9eba9047f0df650c"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"b9c9c240e6da743c3473d0001ecabe571145b458","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    when to apply settings via the Distributed Management Task Force (DMTF)"},{"line_number":7,"context_line":"    Redfish standard ``@Redfish.SettingsApplyTime`` annotation. [1]"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    Such services, typically offered by baseboard management controllers (BMC),"},{"line_number":10,"context_line":"    may require ``POST`` of the annotation, along with the future intended"},{"line_number":11,"context_line":"    state of the settings. Otherwise, they may never be applied. That applies"},{"line_number":12,"context_line":"    to the Dell EMC integrated Dell Remote Access Controller (iDRAC)."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"    For more information, see `story 2008163"},{"line_number":15,"context_line":"    \u003chttps://storyboard.openstack.org/#!/story/2008163\u003e`_."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9f560f44_58a9308e","line":12,"range":{"start_line":9,"start_character":0,"end_line":12,"end_character":10},"updated":"2020-09-18 20:56:12.000000000","message":"I\u0027m not sure what is trying to be conveyed regarding the POST annotation note. The key from the paragraph is that this functionality of being able to specify when to apply the configuration is required for compatibility with redfish based bios setting application on iDRACs.","commit_id":"f92d39908616f870e4e062ef9eba9047f0df650c"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"b8547e9af9f6bd92c7d4735724c90cb506339b5a","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    when to apply settings via the Distributed Management Task Force (DMTF)"},{"line_number":7,"context_line":"    Redfish standard ``@Redfish.SettingsApplyTime`` annotation. [1]"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    Such services, typically offered by baseboard management controllers (BMC),"},{"line_number":10,"context_line":"    may require ``POST`` of the annotation, along with the future intended"},{"line_number":11,"context_line":"    state of the settings. Otherwise, they may never be applied. That applies"},{"line_number":12,"context_line":"    to the Dell EMC integrated Dell Remote Access Controller (iDRAC)."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"    For more information, see `story 2008163"},{"line_number":15,"context_line":"    \u003chttps://storyboard.openstack.org/#!/story/2008163\u003e`_."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9f560f44_875c001a","line":12,"range":{"start_line":9,"start_character":0,"end_line":12,"end_character":10},"in_reply_to":"9f560f44_58a9308e","updated":"2020-09-20 21:37:25.000000000","message":"This paragraph has been removed. Identification of the iDRAC has been moved to the first paragraph.","commit_id":"f92d39908616f870e4e062ef9eba9047f0df650c"}]}