)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"e47e779c7b19b3f2a91c1f64eb7e5088dc966cac","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Old value \u0027updated_at\u0027 field returned after update"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fixed \u0027updated_at\u0027 field returned after resource was changed."},{"line_number":10,"context_line":"And updated tests `save` in tests/objects and tests/api/v1."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Id62a98ea627b90f87c6865c5cdc58af049f85879"},{"line_number":13,"context_line":"Closes-Bug: #1281638"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"1ae5cdf2_2a2fffa8","line":10,"updated":"2014-06-16 03:43:13.000000000","message":"This doesn\u0027t match the contents of the commit - I don\u0027t see updated_at being touched here. Also if its returning the old value, why are we doing from_db_object with the old value, not the new one?","commit_id":"70b9393e2de1a96b37102cd9e7370d4858e18b3f"},{"author":{"_account_id":8412,"name":"Mike Durnosvistov","email":"glacierr.dev@gmail.com","username":"mdurnosvistov"},"change_message_id":"702d7607674529153c9d9d7b91cad3c71fc35f61","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Old value \u0027updated_at\u0027 field returned after update"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fixed \u0027updated_at\u0027 field returned after resource was changed."},{"line_number":10,"context_line":"And updated tests `save` in tests/objects and tests/api/v1."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Id62a98ea627b90f87c6865c5cdc58af049f85879"},{"line_number":13,"context_line":"Closes-Bug: #1281638"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"1ae5cdf2_e8495f33","line":10,"in_reply_to":"1ae5cdf2_2a2fffa8","updated":"2014-06-17 12:30:00.000000000","message":"But this line `self._from_db_object(...)` returns in the object the new value... Perhaps this commit message of written not quite right (not clear).","commit_id":"70b9393e2de1a96b37102cd9e7370d4858e18b3f"}],"ironic/objects/node.py":[{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"b24eacea5313ac617fee1d35a200815abf8de86e","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        \"\"\""},{"line_number":93,"context_line":"        updates \u003d self.obj_get_changes()"},{"line_number":94,"context_line":"        updated_node \u003d self.dbapi.update_node(self.uuid, updates)"},{"line_number":95,"context_line":"        Node._from_db_object(self, updated_node)"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    @base.remotable"},{"line_number":98,"context_line":"    def refresh(self, context):"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAXX%2F%2F0dI%3D","line":95,"updated":"2014-04-26 04:59:13.000000000","message":"I\u0027d prefer these to be \u0027self\u0027 instead of explicit class name so that subclassing will work, if needed.","commit_id":"a48e11c8dbce1d72aa10f51edc14c2b9ad32d804"}],"ironic/tests/objects/test_chassis.py":[{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"b24eacea5313ac617fee1d35a200815abf8de86e","unresolved":false,"context_lines":[{"line_number":51,"context_line":"                c.extra \u003d {\"test\": 123}"},{"line_number":52,"context_line":"                c.save()"},{"line_number":53,"context_line":"                mock_get_chassis.assert_called_once_with(uuid)"},{"line_number":54,"context_line":"                mock_update_chassis.assert_called_once_with(uuid, c.as_dict())"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def test_refresh(self):"},{"line_number":57,"context_line":"        uuid \u003d self.fake_chassis.uuid"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAXX%2F%2F0c8%3D","side":"PARENT","line":54,"updated":"2014-04-26 04:59:13.000000000","message":"This should test that the object is updated with the return from \u0027\u0027update_chassis\".  Ie, return a different object on line 50 above and verify that \u0027c\u0027 contains something from that object.","commit_id":"a5f535a1149f266100ae05d999a4839dd3a347c8"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"caf83b873cb220b07fc4bfb920416add593916f9","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"                mock_get_chassis.assert_called_once_with(uuid)"},{"line_number":58,"context_line":"                mock_update_chassis.assert_called_once_with("},{"line_number":59,"context_line":"                        uuid, {\u0027extra\u0027: {\"test\": 123}})"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def test_refresh(self):"},{"line_number":62,"context_line":"        uuid \u003d self.fake_chassis.uuid"}],"source_content_type":"text/x-python","patch_set":7,"id":"9ad9bd40_09207648","side":"PARENT","line":59,"updated":"2014-04-30 18:58:10.000000000","message":"I still don\u0027t see this testing the fix.","commit_id":"2a8aa5e67eb6d52b9df40a966f3e8eb9cdf081f2"},{"author":{"_account_id":8125,"name":"Michael Davies","email":"michael@the-davies.net","username":"mrda"},"change_message_id":"a3bf833805c5f88b88a2e3567391a5d73f33d3e5","unresolved":false,"context_lines":[{"line_number":57,"context_line":"                c.save()"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"                self.assertTrue(uuid, c.uuid)"},{"line_number":60,"context_line":"                self.assertTrue(extra, c.extra)"},{"line_number":61,"context_line":"                mock_get_chassis.assert_called_once_with(uuid)"},{"line_number":62,"context_line":"                mock_update_chassis.assert_called_once_with("},{"line_number":63,"context_line":"                        uuid, {\u0027extra\u0027: {\"test\": 123}})"}],"source_content_type":"text/x-python","patch_set":9,"id":"1ae5cdf2_eb806f8d","line":60,"updated":"2014-06-10 06:27:08.000000000","message":"I\u0027m sorry if I\u0027ve misunderstood, but shouldn\u0027t these two comparisons be self.assertEqual and not self.assertTrue?","commit_id":"53f60beeafd8e322a828dfc5da48b4b2e166f40f"},{"author":{"_account_id":8412,"name":"Mike Durnosvistov","email":"glacierr.dev@gmail.com","username":"mdurnosvistov"},"change_message_id":"4e979ceead7598b3e1347079d0f6c0cc9554ecd7","unresolved":false,"context_lines":[{"line_number":57,"context_line":"                c.save()"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"                self.assertTrue(uuid, c.uuid)"},{"line_number":60,"context_line":"                self.assertTrue(extra, c.extra)"},{"line_number":61,"context_line":"                mock_get_chassis.assert_called_once_with(uuid)"},{"line_number":62,"context_line":"                mock_update_chassis.assert_called_once_with("},{"line_number":63,"context_line":"                        uuid, {\u0027extra\u0027: {\"test\": 123}})"}],"source_content_type":"text/x-python","patch_set":9,"id":"1ae5cdf2_2e74259b","line":60,"in_reply_to":"1ae5cdf2_eb806f8d","updated":"2014-06-10 06:30:13.000000000","message":"Oops :) Will do!","commit_id":"53f60beeafd8e322a828dfc5da48b4b2e166f40f"}],"ironic/tests/objects/test_node.py":[{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"b24eacea5313ac617fee1d35a200815abf8de86e","unresolved":false,"context_lines":[{"line_number":54,"context_line":"                n.save()"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"                mock_get_node.assert_called_once_with(uuid)"},{"line_number":57,"context_line":"                mock_update_node.assert_called_once_with(uuid, n.as_dict())"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def test_refresh(self):"},{"line_number":60,"context_line":"        uuid \u003d self.fake_node.uuid"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAXX%2F%2F0cs%3D","side":"PARENT","line":57,"updated":"2014-04-26 04:59:13.000000000","message":"Ditto (see test_chassis)","commit_id":"a5f535a1149f266100ae05d999a4839dd3a347c8"},{"author":{"_account_id":8125,"name":"Michael Davies","email":"michael@the-davies.net","username":"mrda"},"change_message_id":"a3bf833805c5f88b88a2e3567391a5d73f33d3e5","unresolved":false,"context_lines":[{"line_number":73,"context_line":"                n.save()"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"                self.assertTrue(uuid, n.uuid)"},{"line_number":76,"context_line":"                self.assertTrue(properties, n.properties)"},{"line_number":77,"context_line":"                mock_get_node.assert_called_once_with(uuid)"},{"line_number":78,"context_line":"                mock_update_node.assert_called_once_with("},{"line_number":79,"context_line":"                        uuid, {\u0027properties\u0027: {\"fake\": \"property\"}})"}],"source_content_type":"text/x-python","patch_set":9,"id":"1ae5cdf2_eb05cf14","line":76,"updated":"2014-06-10 06:27:08.000000000","message":"As mentioned previously, shouldn\u0027t both of these be assertEqual not assertTrue?","commit_id":"53f60beeafd8e322a828dfc5da48b4b2e166f40f"},{"author":{"_account_id":8412,"name":"Mike Durnosvistov","email":"glacierr.dev@gmail.com","username":"mdurnosvistov"},"change_message_id":"4e979ceead7598b3e1347079d0f6c0cc9554ecd7","unresolved":false,"context_lines":[{"line_number":73,"context_line":"                n.save()"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"                self.assertTrue(uuid, n.uuid)"},{"line_number":76,"context_line":"                self.assertTrue(properties, n.properties)"},{"line_number":77,"context_line":"                mock_get_node.assert_called_once_with(uuid)"},{"line_number":78,"context_line":"                mock_update_node.assert_called_once_with("},{"line_number":79,"context_line":"                        uuid, {\u0027properties\u0027: {\"fake\": \"property\"}})"}],"source_content_type":"text/x-python","patch_set":9,"id":"1ae5cdf2_4e77b19f","line":76,"in_reply_to":"1ae5cdf2_eb05cf14","updated":"2014-06-10 06:30:13.000000000","message":"Will do! :)","commit_id":"53f60beeafd8e322a828dfc5da48b4b2e166f40f"}],"ironic/tests/objects/test_port.py":[{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"b24eacea5313ac617fee1d35a200815abf8de86e","unresolved":false,"context_lines":[{"line_number":51,"context_line":"                p.save()"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"                mock_get_port.assert_called_once_with(uuid)"},{"line_number":54,"context_line":"                mock_update_port.assert_called_once_with(uuid, p.as_dict())"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def test_refresh(self):"},{"line_number":57,"context_line":"        uuid \u003d self.fake_port.uuid"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAXX%2F%2F0co%3D","side":"PARENT","line":54,"updated":"2014-04-26 04:59:13.000000000","message":"Ditto. See test_chassis.","commit_id":"a5f535a1149f266100ae05d999a4839dd3a347c8"},{"author":{"_account_id":8125,"name":"Michael Davies","email":"michael@the-davies.net","username":"mrda"},"change_message_id":"a3bf833805c5f88b88a2e3567391a5d73f33d3e5","unresolved":false,"context_lines":[{"line_number":54,"context_line":"                p.save()"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"                self.assertTrue(uuid, p.uuid)"},{"line_number":57,"context_line":"                self.assertTrue(address, p.address)"},{"line_number":58,"context_line":"                mock_get_port.assert_called_once_with(uuid)"},{"line_number":59,"context_line":"                mock_update_port.assert_called_once_with("},{"line_number":60,"context_line":"                        uuid, {\u0027address\u0027: \"b2:54:00:cf:2d:40\"})"}],"source_content_type":"text/x-python","patch_set":9,"id":"1ae5cdf2_8e0c593d","line":57,"updated":"2014-06-10 06:27:08.000000000","message":"As mentioned previously, shouldn\u0027t these be assertEqual and not assertTrue?","commit_id":"53f60beeafd8e322a828dfc5da48b4b2e166f40f"},{"author":{"_account_id":8412,"name":"Mike Durnosvistov","email":"glacierr.dev@gmail.com","username":"mdurnosvistov"},"change_message_id":"4e979ceead7598b3e1347079d0f6c0cc9554ecd7","unresolved":false,"context_lines":[{"line_number":54,"context_line":"                p.save()"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"                self.assertTrue(uuid, p.uuid)"},{"line_number":57,"context_line":"                self.assertTrue(address, p.address)"},{"line_number":58,"context_line":"                mock_get_port.assert_called_once_with(uuid)"},{"line_number":59,"context_line":"                mock_update_port.assert_called_once_with("},{"line_number":60,"context_line":"                        uuid, {\u0027address\u0027: \"b2:54:00:cf:2d:40\"})"}],"source_content_type":"text/x-python","patch_set":9,"id":"1ae5cdf2_8e71b9aa","line":57,"in_reply_to":"1ae5cdf2_8e0c593d","updated":"2014-06-10 06:30:13.000000000","message":"Will do! :)","commit_id":"53f60beeafd8e322a828dfc5da48b4b2e166f40f"}]}