)]}'
{"api-ref/source/baremetal-api-v1-portgroups.inc":[{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"2bfedc6de620afa470c5a25b30612e15a364dee0","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    - mode: portgroup_mode"},{"line_number":93,"context_line":"    - standalone_ports_supported: standalone_ports_supported"},{"line_number":94,"context_line":"    - properties: portgroup_properties"},{"line_number":95,"context_line":"    - extra: extra"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"**Example Portgroup creation request:**"},{"line_number":98,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":1,"id":"9f560f44_6607ad18","line":95,"updated":"2020-09-28 01:10:46.000000000","message":"`uuid` is another field which is missing from the docs, but this is an issue for the docs of most POST calls.\n\nThe undocumented fields become quite obvious when you look at the JSON schemas in the JSON conversion series, here is the one for portgroup[1].\n\nIf you wanted to you could go through that series[2] and document the missing POST parameters, otherwise I can do it later.\n\n[1] https://review.opendev.org/#/c/750864/10/ironic/api/controllers/v1/portgroup.py\n[2] https://review.opendev.org/#/c/743679/","commit_id":"f5279bc737974e881461b70dec2cef325d0bac24"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"d58313527581d0eb6945ae01896712b192026eeb","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    - mode: portgroup_mode"},{"line_number":93,"context_line":"    - standalone_ports_supported: standalone_ports_supported"},{"line_number":94,"context_line":"    - properties: portgroup_properties"},{"line_number":95,"context_line":"    - extra: extra"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"**Example Portgroup creation request:**"},{"line_number":98,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":1,"id":"9f560f44_ecbbf3ba","line":95,"in_reply_to":"9f560f44_17bc14da","updated":"2020-10-09 00:03:52.000000000","message":"Another problem with this change is portgroup_mode, standalone_ports_supported and portgroup_properties will all be rendered as mandatory parameters, but they should be optional.\n\nI\u0027m working on a change which fixes this, adds uuid, and adds the missing parameters from other POST calls too.","commit_id":"f5279bc737974e881461b70dec2cef325d0bac24"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"a1b045e73f3137eee679892a85b10fc28c8a0081","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    - mode: portgroup_mode"},{"line_number":93,"context_line":"    - standalone_ports_supported: standalone_ports_supported"},{"line_number":94,"context_line":"    - properties: portgroup_properties"},{"line_number":95,"context_line":"    - extra: extra"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"**Example Portgroup creation request:**"},{"line_number":98,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":1,"id":"9f560f44_17bc14da","line":95,"in_reply_to":"9f560f44_6607ad18","updated":"2020-09-28 14:15:20.000000000","message":"You are right, uuid is an optional argument but I think the fields is not specified explicitly in most cases. Updating this is because one of customers is confused why some fields can\u0027t be specified in the request according to our api reference, so this patch is just addressing this issue.","commit_id":"f5279bc737974e881461b70dec2cef325d0bac24"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"3be08d9a02270d374bce6551b900ab74b980202a","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    - mode: portgroup_mode"},{"line_number":93,"context_line":"    - standalone_ports_supported: standalone_ports_supported"},{"line_number":94,"context_line":"    - properties: portgroup_properties"},{"line_number":95,"context_line":"    - extra: extra"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"**Example Portgroup creation request:**"},{"line_number":98,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":1,"id":"9f560f44_f4d723bf","line":95,"in_reply_to":"9f560f44_ecbbf3ba","updated":"2020-10-10 14:07:07.000000000","message":"yep, this is because we actually don\u0027t split parameters well, some are reused in response and request thus leads to inconsistency. glad to hear your plan of a complete update, that would definitely make our api documentation more accurate, you can add me to the review list :)","commit_id":"f5279bc737974e881461b70dec2cef325d0bac24"}]}