)]}'
{"ironic/drivers/modules/drac/raid.py":[{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"64e4e0a12b21f8cf7d63aaa39b3514755d6abc76","unresolved":false,"context_lines":[{"line_number":1499,"context_line":"                     \"%(error)s\") %"},{"line_number":1500,"context_line":"                   {\u0027node\u0027: task.node.uuid, \u0027error\u0027: error_msg})"},{"line_number":1501,"context_line":"        if task.node.clean_step:"},{"line_number":1502,"context_line":"            LOG.error(log_msg)"},{"line_number":1503,"context_line":"            manager_utils.cleaning_error_handler(task, error_msg)"},{"line_number":1504,"context_line":"        else:"},{"line_number":1505,"context_line":"            manager_utils.deploying_error_handler(task, log_msg, error_msg)"},{"line_number":1506,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_d9ae0b80","line":1503,"range":{"start_line":1502,"start_character":12,"end_line":1503,"end_character":65},"updated":"2020-10-02 09:01:36.000000000","message":"`cleaning_error_handler` behaves differently than `deploying_error_handler` - the error message might not be logged. Maybe update `cleaning_error_handler` to work like `deploying_error_handler` that distinguish between last_error, logged message (with node UUID) and logs the message without conditions?","commit_id":"d5bc062dfe3648f11dd485eb49d6a02379051508"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"5160a2893de080f6781e7ae4c7b9527b7e8cdcc8","unresolved":false,"context_lines":[{"line_number":1499,"context_line":"                     \"%(error)s\") %"},{"line_number":1500,"context_line":"                   {\u0027node\u0027: task.node.uuid, \u0027error\u0027: error_msg})"},{"line_number":1501,"context_line":"        if task.node.clean_step:"},{"line_number":1502,"context_line":"            LOG.error(log_msg)"},{"line_number":1503,"context_line":"            manager_utils.cleaning_error_handler(task, error_msg)"},{"line_number":1504,"context_line":"        else:"},{"line_number":1505,"context_line":"            manager_utils.deploying_error_handler(task, log_msg, error_msg)"},{"line_number":1506,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_90d27cfc","line":1503,"range":{"start_line":1502,"start_character":12,"end_line":1503,"end_character":65},"in_reply_to":"9f560f44_2b94ffe6","updated":"2020-10-06 11:07:53.000000000","message":"proposal: https://review.opendev.org/#/c/756258/\n\nIf the direction is accepted, I\u0027ll rebase affected patches and remove explicit `LOG.error`.","commit_id":"d5bc062dfe3648f11dd485eb49d6a02379051508"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"5978701516c480486ccb2fd944e4c686810d06a2","unresolved":false,"context_lines":[{"line_number":1499,"context_line":"                     \"%(error)s\") %"},{"line_number":1500,"context_line":"                   {\u0027node\u0027: task.node.uuid, \u0027error\u0027: error_msg})"},{"line_number":1501,"context_line":"        if task.node.clean_step:"},{"line_number":1502,"context_line":"            LOG.error(log_msg)"},{"line_number":1503,"context_line":"            manager_utils.cleaning_error_handler(task, error_msg)"},{"line_number":1504,"context_line":"        else:"},{"line_number":1505,"context_line":"            manager_utils.deploying_error_handler(task, log_msg, error_msg)"},{"line_number":1506,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_dc455471","line":1503,"range":{"start_line":1502,"start_character":12,"end_line":1503,"end_character":65},"in_reply_to":"9f560f44_61a9057b","updated":"2020-10-02 15:12:16.000000000","message":"ok, will take a look - have to think about backward compability and/or scope affected.","commit_id":"d5bc062dfe3648f11dd485eb49d6a02379051508"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"6bfaf52e6f14a7a1f1aae836dada83861f395aa2","unresolved":false,"context_lines":[{"line_number":1499,"context_line":"                     \"%(error)s\") %"},{"line_number":1500,"context_line":"                   {\u0027node\u0027: task.node.uuid, \u0027error\u0027: error_msg})"},{"line_number":1501,"context_line":"        if task.node.clean_step:"},{"line_number":1502,"context_line":"            LOG.error(log_msg)"},{"line_number":1503,"context_line":"            manager_utils.cleaning_error_handler(task, error_msg)"},{"line_number":1504,"context_line":"        else:"},{"line_number":1505,"context_line":"            manager_utils.deploying_error_handler(task, log_msg, error_msg)"},{"line_number":1506,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_61a9057b","line":1503,"range":{"start_line":1502,"start_character":12,"end_line":1503,"end_character":65},"in_reply_to":"9f560f44_d9ae0b80","updated":"2020-10-02 14:05:55.000000000","message":"Sounds like a great idea Aija!","commit_id":"d5bc062dfe3648f11dd485eb49d6a02379051508"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"e7950e3c8759d5dd647331797651ed0705cc2132","unresolved":false,"context_lines":[{"line_number":1499,"context_line":"                     \"%(error)s\") %"},{"line_number":1500,"context_line":"                   {\u0027node\u0027: task.node.uuid, \u0027error\u0027: error_msg})"},{"line_number":1501,"context_line":"        if task.node.clean_step:"},{"line_number":1502,"context_line":"            LOG.error(log_msg)"},{"line_number":1503,"context_line":"            manager_utils.cleaning_error_handler(task, error_msg)"},{"line_number":1504,"context_line":"        else:"},{"line_number":1505,"context_line":"            manager_utils.deploying_error_handler(task, log_msg, error_msg)"},{"line_number":1506,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_2b94ffe6","line":1503,"range":{"start_line":1502,"start_character":12,"end_line":1503,"end_character":65},"in_reply_to":"9f560f44_dc455471","updated":"2020-10-04 00:24:21.000000000","message":"+1","commit_id":"d5bc062dfe3648f11dd485eb49d6a02379051508"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"1c5a64e43089b6766ff61f19175d2b9deb930a30","unresolved":false,"context_lines":[{"line_number":1495,"context_line":"                       \"Message: \u0027%(message)s\u0027.\") %"},{"line_number":1496,"context_line":"                     {\u0027config_job_id\u0027: config_job.id,"},{"line_number":1497,"context_line":"                      \u0027message\u0027: config_job.message})"},{"line_number":1498,"context_line":"        log_msg \u003d (_(\"RAID configuration job failed for node %(node)s. \""},{"line_number":1499,"context_line":"                     \"%(error)s\") %"},{"line_number":1500,"context_line":"                   {\u0027node\u0027: task.node.uuid, \u0027error\u0027: error_msg})"},{"line_number":1501,"context_line":"        if task.node.clean_step:"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f621f24_a0ed58b8","line":1498,"range":{"start_line":1498,"start_character":17,"end_line":1498,"end_character":21},"updated":"2020-11-12 16:52:52.000000000","message":"FYI, you don\u0027t need to tag the log messages for i18n, they don\u0027t get translated anyhow.","commit_id":"23951f4b44e64513da047c474f0a49408ddf9208"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"40b4b96df187c4dcf8e6b2f903c4e2b2856cbd85","unresolved":false,"context_lines":[{"line_number":1495,"context_line":"                       \"Message: \u0027%(message)s\u0027.\") %"},{"line_number":1496,"context_line":"                     {\u0027config_job_id\u0027: config_job.id,"},{"line_number":1497,"context_line":"                      \u0027message\u0027: config_job.message})"},{"line_number":1498,"context_line":"        log_msg \u003d (_(\"RAID configuration job failed for node %(node)s. \""},{"line_number":1499,"context_line":"                     \"%(error)s\") %"},{"line_number":1500,"context_line":"                   {\u0027node\u0027: task.node.uuid, \u0027error\u0027: error_msg})"},{"line_number":1501,"context_line":"        if task.node.clean_step:"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f621f24_439a84b8","line":1498,"range":{"start_line":1498,"start_character":17,"end_line":1498,"end_character":21},"in_reply_to":"1f621f24_a0ed58b8","updated":"2020-11-13 10:19:56.000000000","message":"thanks, updated in https://review.opendev.org/#/c/756258","commit_id":"23951f4b44e64513da047c474f0a49408ddf9208"}]}