)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"61fccb3a1911e3182d2f40ae3e44f9e06ff5ac1e","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix redfish BIOS apply config error handling"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Besides adding new unit tests also update related unit tests"},{"line_number":10,"context_line":"to test for success correctly."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: If28ccb252a87610e3fd3dc78e1ed75bb8ca1cdcf"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f560f44_eba2073f","line":9,"range":{"start_line":9,"start_character":28,"end_line":9,"end_character":29},"updated":"2020-10-04 02:03:45.000000000","message":"nit: s/tests/tests,/","commit_id":"2437433ab455b178bd1b0ee47917fe2caf7aa2c1"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"77ac227b747e5464a5bb3a6d5e9b8eabc407eac4","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix redfish BIOS apply config error handling"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Besides adding new unit tests also update related unit tests"},{"line_number":10,"context_line":"to test for success correctly."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: If28ccb252a87610e3fd3dc78e1ed75bb8ca1cdcf"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f560f44_2ea8881e","line":9,"range":{"start_line":9,"start_character":28,"end_line":9,"end_character":29},"in_reply_to":"9f560f44_eba2073f","updated":"2020-10-05 09:19:43.000000000","message":"Done","commit_id":"2437433ab455b178bd1b0ee47917fe2caf7aa2c1"}],"ironic/drivers/modules/redfish/bios.py":[{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"bcf853d395bef09908b9d1c007a57c35a1d182f7","unresolved":false,"context_lines":[{"line_number":333,"context_line":"                        \u0027Attributes %(attrs)s are not updated.\u0027) %"},{"line_number":334,"context_line":"                      {\u0027attrs\u0027: attrs_not_updated})"},{"line_number":335,"context_line":"        if task.node.provision_state in [states.CLEANING, states.CLEANWAIT]:"},{"line_number":336,"context_line":"            LOG.error(error_msg)"},{"line_number":337,"context_line":"            manager_utils.cleaning_error_handler(task, last_error)"},{"line_number":338,"context_line":"        if task.node.provision_state in [states.DEPLOYING, states.DEPLOYWAIT]:"},{"line_number":339,"context_line":"            manager_utils.deploying_error_handler(task, error_msg, last_error)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_2be36c08","line":337,"range":{"start_line":336,"start_character":12,"end_line":337,"end_character":66},"updated":"2020-10-02 12:02:05.000000000","message":"same Q as https://review.opendev.org/#/c/755731/1/ironic/drivers/modules/drac/raid.py@1503","commit_id":"2437433ab455b178bd1b0ee47917fe2caf7aa2c1"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"61fccb3a1911e3182d2f40ae3e44f9e06ff5ac1e","unresolved":false,"context_lines":[{"line_number":333,"context_line":"                        \u0027Attributes %(attrs)s are not updated.\u0027) %"},{"line_number":334,"context_line":"                      {\u0027attrs\u0027: attrs_not_updated})"},{"line_number":335,"context_line":"        if task.node.provision_state in [states.CLEANING, states.CLEANWAIT]:"},{"line_number":336,"context_line":"            LOG.error(error_msg)"},{"line_number":337,"context_line":"            manager_utils.cleaning_error_handler(task, last_error)"},{"line_number":338,"context_line":"        if task.node.provision_state in [states.DEPLOYING, states.DEPLOYWAIT]:"},{"line_number":339,"context_line":"            manager_utils.deploying_error_handler(task, error_msg, last_error)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_cb8463b5","line":337,"range":{"start_line":336,"start_character":12,"end_line":337,"end_character":66},"in_reply_to":"9f560f44_2be36c08","updated":"2020-10-04 02:03:45.000000000","message":"+1","commit_id":"2437433ab455b178bd1b0ee47917fe2caf7aa2c1"},{"author":{"_account_id":28128,"name":"Bill Dodd","email":"billdodd@gmail.com","username":"billdodd"},"change_message_id":"0255ca6654fdfc01eb4382882f8584a910bf0449","unresolved":false,"context_lines":[{"line_number":336,"context_line":"            LOG.error(error_msg)"},{"line_number":337,"context_line":"            manager_utils.cleaning_error_handler(task, last_error)"},{"line_number":338,"context_line":"        if task.node.provision_state in [states.DEPLOYING, states.DEPLOYWAIT]:"},{"line_number":339,"context_line":"            manager_utils.deploying_error_handler(task, error_msg, last_error)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_b55cdc4c","line":339,"updated":"2020-10-05 17:51:28.000000000","message":"This seems logical to me: use the appropriate error handler based on the state.\n\nFor my own education, is there a bug report or other description of the problem caused by the original code?","commit_id":"cf3b3172cba1afc325e5a856343a92f03ea837e2"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"632d5739da034b677222fcde10865e33214c1188","unresolved":false,"context_lines":[{"line_number":336,"context_line":"            LOG.error(error_msg)"},{"line_number":337,"context_line":"            manager_utils.cleaning_error_handler(task, last_error)"},{"line_number":338,"context_line":"        if task.node.provision_state in [states.DEPLOYING, states.DEPLOYWAIT]:"},{"line_number":339,"context_line":"            manager_utils.deploying_error_handler(task, error_msg, last_error)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f6b1bfe_45eff486","line":339,"in_reply_to":"9f560f44_0c643e48","updated":"2020-10-13 16:01:37.000000000","message":"added release note","commit_id":"cf3b3172cba1afc325e5a856343a92f03ea837e2"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"9d106862560f0715ecf0301e3b0c58c81d4165a8","unresolved":false,"context_lines":[{"line_number":336,"context_line":"            LOG.error(error_msg)"},{"line_number":337,"context_line":"            manager_utils.cleaning_error_handler(task, last_error)"},{"line_number":338,"context_line":"        if task.node.provision_state in [states.DEPLOYING, states.DEPLOYWAIT]:"},{"line_number":339,"context_line":"            manager_utils.deploying_error_handler(task, error_msg, last_error)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_0c643e48","line":339,"in_reply_to":"9f560f44_163b04ea","updated":"2020-10-12 14:50:16.000000000","message":"Since this bug exists in several locations across more than one driver and is user visible, it feels like it warrants a bug and release note. Just saying :)","commit_id":"cf3b3172cba1afc325e5a856343a92f03ea837e2"},{"author":{"_account_id":28128,"name":"Bill Dodd","email":"billdodd@gmail.com","username":"billdodd"},"change_message_id":"7927a17927a0050abf24c7050b0049a9db312789","unresolved":false,"context_lines":[{"line_number":336,"context_line":"            LOG.error(error_msg)"},{"line_number":337,"context_line":"            manager_utils.cleaning_error_handler(task, last_error)"},{"line_number":338,"context_line":"        if task.node.provision_state in [states.DEPLOYING, states.DEPLOYWAIT]:"},{"line_number":339,"context_line":"            manager_utils.deploying_error_handler(task, error_msg, last_error)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_4264964d","line":339,"in_reply_to":"9f560f44_163b04ea","updated":"2020-10-06 15:30:36.000000000","message":"Thanks, Aija. That makes sense and answers my question.","commit_id":"cf3b3172cba1afc325e5a856343a92f03ea837e2"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"7a712c4f3e5ff7f99d44a951ba0477b94fbdefe6","unresolved":false,"context_lines":[{"line_number":336,"context_line":"            LOG.error(error_msg)"},{"line_number":337,"context_line":"            manager_utils.cleaning_error_handler(task, last_error)"},{"line_number":338,"context_line":"        if task.node.provision_state in [states.DEPLOYING, states.DEPLOYWAIT]:"},{"line_number":339,"context_line":"            manager_utils.deploying_error_handler(task, error_msg, last_error)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_163b04ea","line":339,"in_reply_to":"9f560f44_b55cdc4c","updated":"2020-10-06 13:14:59.000000000","message":"no bug report as ilo changes got through without it [1] :) But I can create a story and link to it if that\u0027s necessary. For now added more details to the commit message.\n\nThe underlying issue is using process_event(\u0027fail\u0027) instead of error_handlers that do some extra work.\n\nOtherwise in case of failure, the node got stuck and failed because of timeout. Instead of failing earlier due to step failure.\n\nThis was found by Chris and discussed in IRC [2]\n\n[1] https://review.opendev.org/#/c/753595/\n[2] http://eavesdrop.openstack.org/irclogs/%23openstack-ironic/%23openstack-ironic.2020-09-21.log.html#t2020-09-21T15:47:52","commit_id":"cf3b3172cba1afc325e5a856343a92f03ea837e2"}],"ironic/tests/unit/drivers/modules/redfish/test_bios.py":[{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"61fccb3a1911e3182d2f40ae3e44f9e06ff5ac1e","unresolved":false,"context_lines":[{"line_number":301,"context_line":"        driver_internal_info[\u0027requested_bios_attrs\u0027] \u003d requested_attrs"},{"line_number":302,"context_line":"        self.node.driver_internal_info \u003d driver_internal_info"},{"line_number":303,"context_line":"        self.node.save()"},{"line_number":304,"context_line":"        self._test_step_post_reboot()"},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"    @mock.patch.object(manager_utils, \u0027cleaning_error_handler\u0027, autospec\u003dTrue)"},{"line_number":307,"context_line":"    def test_apply_conf_post_reboot_cleaning_failed("}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_0ba81b1e","line":304,"updated":"2020-10-04 02:03:45.000000000","message":"Please consider adding a check that error handling was not called. Prior to this proposed change, it was.","commit_id":"2437433ab455b178bd1b0ee47917fe2caf7aa2c1"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"77ac227b747e5464a5bb3a6d5e9b8eabc407eac4","unresolved":false,"context_lines":[{"line_number":301,"context_line":"        driver_internal_info[\u0027requested_bios_attrs\u0027] \u003d requested_attrs"},{"line_number":302,"context_line":"        self.node.driver_internal_info \u003d driver_internal_info"},{"line_number":303,"context_line":"        self.node.save()"},{"line_number":304,"context_line":"        self._test_step_post_reboot()"},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"    @mock.patch.object(manager_utils, \u0027cleaning_error_handler\u0027, autospec\u003dTrue)"},{"line_number":307,"context_line":"    def test_apply_conf_post_reboot_cleaning_failed("}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_4eefbc85","line":304,"in_reply_to":"9f560f44_0ba81b1e","updated":"2020-10-05 09:19:43.000000000","message":"Done","commit_id":"2437433ab455b178bd1b0ee47917fe2caf7aa2c1"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"61fccb3a1911e3182d2f40ae3e44f9e06ff5ac1e","unresolved":false,"context_lines":[{"line_number":306,"context_line":"    @mock.patch.object(manager_utils, \u0027cleaning_error_handler\u0027, autospec\u003dTrue)"},{"line_number":307,"context_line":"    def test_apply_conf_post_reboot_cleaning_failed("},{"line_number":308,"context_line":"            self, mock_cleaning_error_handler):"},{"line_number":309,"context_line":"        data \u003d [{\u0027name\u0027: \u0027ProcTurboMode\u0027, \u0027value\u0027: \u0027Disabled\u0027}]"},{"line_number":310,"context_line":"        self.node.clean_step \u003d {\u0027priority\u0027: 100, \u0027interface\u0027: \u0027bios\u0027,"},{"line_number":311,"context_line":"                                \u0027step\u0027: \u0027apply_configuration\u0027,"},{"line_number":312,"context_line":"                                \u0027argsinfo\u0027: {\u0027settings\u0027: data}}"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_8bb42b84","line":309,"range":{"start_line":309,"start_character":51,"end_line":309,"end_character":61},"updated":"2020-10-04 02:03:45.000000000","message":"Should this be \u0027Enabled\u0027, instead? It looks like this may be a copy and paste from test_apply_conf_post_reboot_cleaning().","commit_id":"2437433ab455b178bd1b0ee47917fe2caf7aa2c1"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"77ac227b747e5464a5bb3a6d5e9b8eabc407eac4","unresolved":false,"context_lines":[{"line_number":306,"context_line":"    @mock.patch.object(manager_utils, \u0027cleaning_error_handler\u0027, autospec\u003dTrue)"},{"line_number":307,"context_line":"    def test_apply_conf_post_reboot_cleaning_failed("},{"line_number":308,"context_line":"            self, mock_cleaning_error_handler):"},{"line_number":309,"context_line":"        data \u003d [{\u0027name\u0027: \u0027ProcTurboMode\u0027, \u0027value\u0027: \u0027Disabled\u0027}]"},{"line_number":310,"context_line":"        self.node.clean_step \u003d {\u0027priority\u0027: 100, \u0027interface\u0027: \u0027bios\u0027,"},{"line_number":311,"context_line":"                                \u0027step\u0027: \u0027apply_configuration\u0027,"},{"line_number":312,"context_line":"                                \u0027argsinfo\u0027: {\u0027settings\u0027: data}}"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_ae9bf814","line":309,"range":{"start_line":309,"start_character":51,"end_line":309,"end_character":61},"in_reply_to":"9f560f44_8bb42b84","updated":"2020-10-05 09:19:43.000000000","message":"yes, same for test_apply_conf_post_reboot_cleaning (updated there too). This variable does not affect test, it\u0027s for information only/realistic input data. `requested_attrs` is the one that controls test flow.","commit_id":"2437433ab455b178bd1b0ee47917fe2caf7aa2c1"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"61fccb3a1911e3182d2f40ae3e44f9e06ff5ac1e","unresolved":false,"context_lines":[{"line_number":316,"context_line":"        driver_internal_info \u003d node.driver_internal_info"},{"line_number":317,"context_line":"        driver_internal_info[\u0027post_config_reboot_requested\u0027] \u003d True"},{"line_number":318,"context_line":"        driver_internal_info[\u0027requested_bios_attrs\u0027] \u003d requested_attrs"},{"line_number":319,"context_line":"        self.node.driver_internal_info \u003d driver_internal_info"},{"line_number":320,"context_line":"        self.node.provision_state \u003d states.CLEANING"},{"line_number":321,"context_line":"        self.node.save()"},{"line_number":322,"context_line":"        self._test_step_post_reboot("}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_ab7f6fba","line":319,"updated":"2020-10-04 02:03:45.000000000","message":"nit: Is this line necessary?","commit_id":"2437433ab455b178bd1b0ee47917fe2caf7aa2c1"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"7a712c4f3e5ff7f99d44a951ba0477b94fbdefe6","unresolved":false,"context_lines":[{"line_number":316,"context_line":"        driver_internal_info \u003d node.driver_internal_info"},{"line_number":317,"context_line":"        driver_internal_info[\u0027post_config_reboot_requested\u0027] \u003d True"},{"line_number":318,"context_line":"        driver_internal_info[\u0027requested_bios_attrs\u0027] \u003d requested_attrs"},{"line_number":319,"context_line":"        self.node.driver_internal_info \u003d driver_internal_info"},{"line_number":320,"context_line":"        self.node.provision_state \u003d states.CLEANING"},{"line_number":321,"context_line":"        self.node.save()"},{"line_number":322,"context_line":"        self._test_step_post_reboot("}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_b6733816","line":319,"in_reply_to":"9f560f44_7fcb48a3","updated":"2020-10-06 13:14:59.000000000","message":"took a bit closer look, but I stopped at https://opendev.org/openstack/oslo.versionedobjects/src/branch/master/oslo_versionedobjects/base.py#L622 This method does not return `driver_internal_info` as changed field if keeping the same id that ln 319 forces to change.","commit_id":"2437433ab455b178bd1b0ee47917fe2caf7aa2c1"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"63c727bd39adcfd7fbf4ee9fbc06caaf8922ac3d","unresolved":false,"context_lines":[{"line_number":316,"context_line":"        driver_internal_info \u003d node.driver_internal_info"},{"line_number":317,"context_line":"        driver_internal_info[\u0027post_config_reboot_requested\u0027] \u003d True"},{"line_number":318,"context_line":"        driver_internal_info[\u0027requested_bios_attrs\u0027] \u003d requested_attrs"},{"line_number":319,"context_line":"        self.node.driver_internal_info \u003d driver_internal_info"},{"line_number":320,"context_line":"        self.node.provision_state \u003d states.CLEANING"},{"line_number":321,"context_line":"        self.node.save()"},{"line_number":322,"context_line":"        self._test_step_post_reboot("}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_7fcb48a3","line":319,"in_reply_to":"9f560f44_8e9ef403","updated":"2020-10-05 11:46:56.000000000","message":"It is puzzling. In the debugger, self.node.driver_internal_info and driver_internal_info reference the same object, as expected. According to id(), their object identifiers are equal and their values change in parallel while stepping through the code that modifies them.","commit_id":"2437433ab455b178bd1b0ee47917fe2caf7aa2c1"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"77ac227b747e5464a5bb3a6d5e9b8eabc407eac4","unresolved":false,"context_lines":[{"line_number":316,"context_line":"        driver_internal_info \u003d node.driver_internal_info"},{"line_number":317,"context_line":"        driver_internal_info[\u0027post_config_reboot_requested\u0027] \u003d True"},{"line_number":318,"context_line":"        driver_internal_info[\u0027requested_bios_attrs\u0027] \u003d requested_attrs"},{"line_number":319,"context_line":"        self.node.driver_internal_info \u003d driver_internal_info"},{"line_number":320,"context_line":"        self.node.provision_state \u003d states.CLEANING"},{"line_number":321,"context_line":"        self.node.save()"},{"line_number":322,"context_line":"        self._test_step_post_reboot("}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_8e9ef403","line":319,"in_reply_to":"9f560f44_ab7f6fba","updated":"2020-10-05 09:19:43.000000000","message":"yes, it\u0027s not referencing original. Setting directly for some reason does not work. Same pattern used in other tests.","commit_id":"2437433ab455b178bd1b0ee47917fe2caf7aa2c1"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"9d106862560f0715ecf0301e3b0c58c81d4165a8","unresolved":false,"context_lines":[{"line_number":316,"context_line":"        driver_internal_info \u003d node.driver_internal_info"},{"line_number":317,"context_line":"        driver_internal_info[\u0027post_config_reboot_requested\u0027] \u003d True"},{"line_number":318,"context_line":"        driver_internal_info[\u0027requested_bios_attrs\u0027] \u003d requested_attrs"},{"line_number":319,"context_line":"        self.node.driver_internal_info \u003d driver_internal_info"},{"line_number":320,"context_line":"        self.node.provision_state \u003d states.CLEANING"},{"line_number":321,"context_line":"        self.node.save()"},{"line_number":322,"context_line":"        self._test_step_post_reboot("}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_8c668e54","line":319,"in_reply_to":"9f560f44_b6733816","updated":"2020-10-12 14:50:16.000000000","message":"As we discussed, it appears this is because \u0027driver_internal_info\u0027 is not a \u0027VersionedObject\u0027.\n\nI wonder why not. Clearly, this question is beyond the scope of this change. I am hoping someone could shed some light on that.","commit_id":"2437433ab455b178bd1b0ee47917fe2caf7aa2c1"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"61fccb3a1911e3182d2f40ae3e44f9e06ff5ac1e","unresolved":false,"context_lines":[{"line_number":351,"context_line":"        driver_internal_info \u003d node.driver_internal_info"},{"line_number":352,"context_line":"        driver_internal_info[\u0027post_config_reboot_requested\u0027] \u003d True"},{"line_number":353,"context_line":"        driver_internal_info[\u0027requested_bios_attrs\u0027] \u003d requested_attrs"},{"line_number":354,"context_line":"        self.node.driver_internal_info \u003d driver_internal_info"},{"line_number":355,"context_line":"        self.node.provision_state \u003d states.DEPLOYWAIT"},{"line_number":356,"context_line":"        self.node.save()"},{"line_number":357,"context_line":"        self._test_step_post_reboot("}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_0b8f7bcd","line":354,"updated":"2020-10-04 02:03:45.000000000","message":"nit: Is this line necessary?","commit_id":"2437433ab455b178bd1b0ee47917fe2caf7aa2c1"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"77ac227b747e5464a5bb3a6d5e9b8eabc407eac4","unresolved":false,"context_lines":[{"line_number":351,"context_line":"        driver_internal_info \u003d node.driver_internal_info"},{"line_number":352,"context_line":"        driver_internal_info[\u0027post_config_reboot_requested\u0027] \u003d True"},{"line_number":353,"context_line":"        driver_internal_info[\u0027requested_bios_attrs\u0027] \u003d requested_attrs"},{"line_number":354,"context_line":"        self.node.driver_internal_info \u003d driver_internal_info"},{"line_number":355,"context_line":"        self.node.provision_state \u003d states.DEPLOYWAIT"},{"line_number":356,"context_line":"        self.node.save()"},{"line_number":357,"context_line":"        self._test_step_post_reboot("}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_ee84d0b4","line":354,"in_reply_to":"9f560f44_0b8f7bcd","updated":"2020-10-05 09:19:43.000000000","message":"ditto","commit_id":"2437433ab455b178bd1b0ee47917fe2caf7aa2c1"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"63c727bd39adcfd7fbf4ee9fbc06caaf8922ac3d","unresolved":false,"context_lines":[{"line_number":298,"context_line":"        self.node.clean_step \u003d {\u0027priority\u0027: 100, \u0027interface\u0027: \u0027bios\u0027,"},{"line_number":299,"context_line":"                                \u0027step\u0027: \u0027apply_configuration\u0027,"},{"line_number":300,"context_line":"                                \u0027argsinfo\u0027: {\u0027settings\u0027: data}}"},{"line_number":301,"context_line":"        requested_attrs \u003d {\u0027ProcTurboMode\u0027: \u0027Enabled\u0027}"},{"line_number":302,"context_line":"        node \u003d self.node"},{"line_number":303,"context_line":"        driver_internal_info \u003d node.driver_internal_info"},{"line_number":304,"context_line":"        driver_internal_info[\u0027post_config_reboot_requested\u0027] \u003d True"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_1fbccc04","line":301,"updated":"2020-10-05 11:46:56.000000000","message":"For clarity and to simulate realistic input data, it would be helpful if this included NicBoot1.","commit_id":"cf3b3172cba1afc325e5a856343a92f03ea837e2"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"7a712c4f3e5ff7f99d44a951ba0477b94fbdefe6","unresolved":false,"context_lines":[{"line_number":298,"context_line":"        self.node.clean_step \u003d {\u0027priority\u0027: 100, \u0027interface\u0027: \u0027bios\u0027,"},{"line_number":299,"context_line":"                                \u0027step\u0027: \u0027apply_configuration\u0027,"},{"line_number":300,"context_line":"                                \u0027argsinfo\u0027: {\u0027settings\u0027: data}}"},{"line_number":301,"context_line":"        requested_attrs \u003d {\u0027ProcTurboMode\u0027: \u0027Enabled\u0027}"},{"line_number":302,"context_line":"        node \u003d self.node"},{"line_number":303,"context_line":"        driver_internal_info \u003d node.driver_internal_info"},{"line_number":304,"context_line":"        driver_internal_info[\u0027post_config_reboot_requested\u0027] \u003d True"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_36fd686e","line":301,"in_reply_to":"9f560f44_1fbccc04","updated":"2020-10-06 13:14:59.000000000","message":"updated here and elsewhere in the file; and commit message too","commit_id":"cf3b3172cba1afc325e5a856343a92f03ea837e2"}]}