)]}'
{"ironic/drivers/modules/drac/bios.py":[{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"97fe2b92fd0ebf59dedb48ef74010ca7ead73cd5","unresolved":false,"context_lines":[{"line_number":341,"context_line":"                   {\u0027node\u0027: task.node.uuid,"},{"line_number":342,"context_line":"                    \u0027message\u0027: error_message})"},{"line_number":343,"context_line":"        if task.node.clean_step:"},{"line_number":344,"context_line":"            LOG.error(log_msg)"},{"line_number":345,"context_line":"            manager_utils.cleaning_error_handler(task, error_message)"},{"line_number":346,"context_line":"        else:"},{"line_number":347,"context_line":"            manager_utils.deploying_error_handler(task, log_msg, error_message)"},{"line_number":348,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_9c62bc14","line":345,"range":{"start_line":344,"start_character":11,"end_line":345,"end_character":69},"updated":"2020-10-02 15:10:54.000000000","message":"same thing as here https://review.opendev.org/#/c/755731/1/ironic/drivers/modules/drac/raid.py@1503","commit_id":"9adf6ca3623afc87be87afd0601b5bd3adb0dc1b"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"4ba717d3be5e0548868e4cc1b5693a2293035f6c","unresolved":false,"context_lines":[{"line_number":341,"context_line":"                   {\u0027node\u0027: task.node.uuid,"},{"line_number":342,"context_line":"                    \u0027message\u0027: error_message})"},{"line_number":343,"context_line":"        if task.node.clean_step:"},{"line_number":344,"context_line":"            LOG.error(log_msg)"},{"line_number":345,"context_line":"            manager_utils.cleaning_error_handler(task, error_message)"},{"line_number":346,"context_line":"        else:"},{"line_number":347,"context_line":"            manager_utils.deploying_error_handler(task, log_msg, error_message)"},{"line_number":348,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_fdd80881","line":345,"range":{"start_line":344,"start_character":11,"end_line":345,"end_character":69},"in_reply_to":"9f560f44_9c62bc14","updated":"2020-10-04 22:01:55.000000000","message":"+1, again :)","commit_id":"9adf6ca3623afc87be87afd0601b5bd3adb0dc1b"}],"ironic/tests/unit/drivers/modules/drac/test_bios.py":[{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"4ba717d3be5e0548868e4cc1b5693a2293035f6c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# -*- coding: utf-8 -*-"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Copyright (c) 2015-2016 Dell Inc. or its subsidiaries."},{"line_number":4,"context_line":"# All Rights Reserved."},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_4b485389","line":3,"range":{"start_line":3,"start_character":21,"end_line":3,"end_character":25},"updated":"2020-10-04 22:01:55.000000000","message":"nit: 2020","commit_id":"9adf6ca3623afc87be87afd0601b5bd3adb0dc1b"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"06a4413c5ac8dec296a572c9404d9c955ed7ba25","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# -*- coding: utf-8 -*-"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Copyright (c) 2015-2016 Dell Inc. or its subsidiaries."},{"line_number":4,"context_line":"# All Rights Reserved."},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_ce046c1c","line":3,"range":{"start_line":3,"start_character":21,"end_line":3,"end_character":25},"in_reply_to":"9f560f44_4b485389","updated":"2020-10-05 09:29:32.000000000","message":"Done","commit_id":"9adf6ca3623afc87be87afd0601b5bd3adb0dc1b"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"4ba717d3be5e0548868e4cc1b5693a2293035f6c","unresolved":false,"context_lines":[{"line_number":327,"context_line":"                \u0027last_inventory_reboot_time_before_fr\u0027))"},{"line_number":328,"context_line":"            self.assertIsNone("},{"line_number":329,"context_line":"                task.node.driver_internal_info.get(\u0027factory_reset_time\u0027))"},{"line_number":330,"context_line":"            fail \u003d (\"BIOS factory reset was not completed within  600 \""},{"line_number":331,"context_line":"                    \"seconds, unable to cache updated bios setting\")"},{"line_number":332,"context_line":"            mock_deploying_error_handler.assert_called_once_with("},{"line_number":333,"context_line":"                task, mock.ANY, fail)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_9df2ac04","line":330,"range":{"start_line":330,"start_character":64,"end_line":330,"end_character":66},"updated":"2020-10-04 22:01:55.000000000","message":"Two (2) spaces?","commit_id":"9adf6ca3623afc87be87afd0601b5bd3adb0dc1b"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"06a4413c5ac8dec296a572c9404d9c955ed7ba25","unresolved":false,"context_lines":[{"line_number":327,"context_line":"                \u0027last_inventory_reboot_time_before_fr\u0027))"},{"line_number":328,"context_line":"            self.assertIsNone("},{"line_number":329,"context_line":"                task.node.driver_internal_info.get(\u0027factory_reset_time\u0027))"},{"line_number":330,"context_line":"            fail \u003d (\"BIOS factory reset was not completed within  600 \""},{"line_number":331,"context_line":"                    \"seconds, unable to cache updated bios setting\")"},{"line_number":332,"context_line":"            mock_deploying_error_handler.assert_called_once_with("},{"line_number":333,"context_line":"                task, mock.ANY, fail)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_0e514431","line":330,"range":{"start_line":330,"start_character":64,"end_line":330,"end_character":66},"in_reply_to":"9f560f44_9df2ac04","updated":"2020-10-05 09:29:32.000000000","message":"Should be fixed by Yogesh in the parent patch. There is comment about this already, https://review.opendev.org/#/c/748696/16/ironic/drivers/modules/drac/bios.py@242\n\nI\u0027ll rebase after that.","commit_id":"9adf6ca3623afc87be87afd0601b5bd3adb0dc1b"}]}