)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"4ec601fca2633a6c397be47e9afdbd55555cf391","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Steve Baker \u003csbaker@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-10-06 13:39:33 +1300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix impitool timing argument calculation"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Calculating the ipmitool `-N` and `-R` arguments from ironic.conf"},{"line_number":10,"context_line":"[ipmi] `command_retry_timeout` and `min_command_interval` now takes"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f560f44_fd863616","line":7,"range":{"start_line":7,"start_character":4,"end_line":7,"end_character":12},"updated":"2020-10-06 01:28:27.000000000","message":"nit - typo","commit_id":"2e91e0178f3f474f8fa5de72da8f497d1e9a74fc"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"54d8469045355dc243ecd065372774dabad50475","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Steve Baker \u003csbaker@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-10-06 13:39:33 +1300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix impitool timing argument calculation"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Calculating the ipmitool `-N` and `-R` arguments from ironic.conf"},{"line_number":10,"context_line":"[ipmi] `command_retry_timeout` and `min_command_interval` now takes"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f560f44_fd8bd613","line":7,"range":{"start_line":7,"start_character":4,"end_line":7,"end_character":12},"in_reply_to":"9f560f44_fd863616","updated":"2020-10-06 01:35:24.000000000","message":"Done","commit_id":"2e91e0178f3f474f8fa5de72da8f497d1e9a74fc"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"1a3722fd00910dbb5ef01f1871777b6837ccc401","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Calculating the ipmitool `-N` and `-R` arguments from ironic.conf"},{"line_number":10,"context_line":"[ipmi] `command_retry_timeout` and `min_command_interval` now takes"},{"line_number":11,"context_line":"into account the 1 second interval increment that ipmitool adds on"},{"line_number":12,"context_line":"each retry event."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Failure-path ipmitool run duration will now be just less than"},{"line_number":15,"context_line":"`command_retry_timeout` instead of much longer."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9f560f44_bb9f3d63","line":12,"updated":"2020-10-13 06:13:27.000000000","message":"Is this behavior documented somewhere? I am wondering if this depends on the ipmitool version.","commit_id":"807eae214559680896be14ae9a61e75b8b344eb5"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"e440aef0546ba3a21bfe86d8376294238cecb779","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Calculating the ipmitool `-N` and `-R` arguments from ironic.conf"},{"line_number":10,"context_line":"[ipmi] `command_retry_timeout` and `min_command_interval` now takes"},{"line_number":11,"context_line":"into account the 1 second interval increment that ipmitool adds on"},{"line_number":12,"context_line":"each retry event."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Failure-path ipmitool run duration will now be just less than"},{"line_number":15,"context_line":"`command_retry_timeout` instead of much longer."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7f6b1bfe_df345e4d","line":12,"in_reply_to":"9f560f44_bb9f3d63","updated":"2020-10-14 19:34:09.000000000","message":"Its only documented in the code[1] but it has been the behavior for 14 years.\n\n[1] https://github.com/ipmitool/ipmitool/blob/master/src/plugins/lanplus/lanplus.c#L2348-L2360","commit_id":"807eae214559680896be14ae9a61e75b8b344eb5"}],"ironic/drivers/modules/ipmitool.py":[{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"4ec601fca2633a6c397be47e9afdbd55555cf391","unresolved":false,"context_lines":[{"line_number":447,"context_line":"    if not _is_option_supported(\u0027timing\u0027):"},{"line_number":448,"context_line":"        return []"},{"line_number":449,"context_line":""},{"line_number":450,"context_line":"    if not CONF.ipmi.use_ipmitool_retries:"},{"line_number":451,"context_line":"        return [\u0027-R\u0027, \u00270\u0027, \u0027-N\u0027, \u00270\u0027]"},{"line_number":452,"context_line":""},{"line_number":453,"context_line":"    timeout \u003d CONF.ipmi.command_retry_timeout"},{"line_number":454,"context_line":"    interval \u003d CONF.ipmi.min_command_interval"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_3da8ae8a","line":451,"range":{"start_line":450,"start_character":4,"end_line":451,"end_character":37},"updated":"2020-10-06 01:28:27.000000000","message":"Per discussion, should use -R 1 -N ipmi.min_command_interval. See https://review.opendev.org/#/c/740466/.","commit_id":"2e91e0178f3f474f8fa5de72da8f497d1e9a74fc"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"54d8469045355dc243ecd065372774dabad50475","unresolved":false,"context_lines":[{"line_number":447,"context_line":"    if not _is_option_supported(\u0027timing\u0027):"},{"line_number":448,"context_line":"        return []"},{"line_number":449,"context_line":""},{"line_number":450,"context_line":"    if not CONF.ipmi.use_ipmitool_retries:"},{"line_number":451,"context_line":"        return [\u0027-R\u0027, \u00270\u0027, \u0027-N\u0027, \u00270\u0027]"},{"line_number":452,"context_line":""},{"line_number":453,"context_line":"    timeout \u003d CONF.ipmi.command_retry_timeout"},{"line_number":454,"context_line":"    interval \u003d CONF.ipmi.min_command_interval"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_5d75a232","line":451,"range":{"start_line":450,"start_character":4,"end_line":451,"end_character":37},"in_reply_to":"9f560f44_3da8ae8a","updated":"2020-10-06 01:35:24.000000000","message":"Done","commit_id":"2e91e0178f3f474f8fa5de72da8f497d1e9a74fc"}],"releasenotes/notes/ipmi_command_retry_timeout-889a49b402e82b97.yaml":[{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"1a3722fd00910dbb5ef01f1871777b6837ccc401","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Calculating the ipmitool `-N` and `-R` arguments from ironic.conf [ipmi]"},{"line_number":5,"context_line":"    `command_retry_timeout` and `min_command_interval` now takes into account the"},{"line_number":6,"context_line":"    1 second interval increment that ipmitool adds on each retry event."},{"line_number":7,"context_line":"    "},{"line_number":8,"context_line":"    Failure-path ipmitool run duration will now be just less than"},{"line_number":9,"context_line":"    `command_retry_timeout` instead of much longer."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9f560f44_9ba239ac","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":4},"updated":"2020-10-13 06:13:27.000000000","message":"nit: spaces","commit_id":"807eae214559680896be14ae9a61e75b8b344eb5"}]}