)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"2561eac3f9830d2c764fe5d87402606e310ec7ee","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     ANURADHAJHA99 \u003canuradha750871@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-10-08 17:23:27 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adding the catch block for exception IncompatibleInterface in default_interface"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Id47d862950d7bab771901c57b0f33b5d68689566"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f560f44_65b26398","line":7,"updated":"2020-10-08 13:33:18.000000000","message":"please reduce the length of the commit title and provide some more info in the commit message","commit_id":"88eb5c745ebd8e39c987a5a76145c7f0d7d9855e"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"58617fdbadb77ef689f37bf920cdcc18cea72305","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2020-10-08 17:23:27 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adding the catch block for exception IncompatibleInterface in default_interface"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Id47d862950d7bab771901c57b0f33b5d68689566"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f560f44_561c3365","line":8,"updated":"2020-10-08 14:49:35.000000000","message":"Please add the Story and Task information in the commit message, https://docs.openstack.org/contributors/common/git.html#commit-messages explains a bit how it should be \u003d)","commit_id":"88eb5c745ebd8e39c987a5a76145c7f0d7d9855e"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"7118b37c211ec6cf1d577dd2024a2faf8fdd8794","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     ANURADHAJHA99 \u003canuradha750871@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-10-08 20:24:33 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adding requested changes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adding the try exception block in the function default_interface() to catch the exception IncompatibleInterface issued by get_interface(), and raise NoValidDefaultForInterface instead, also removed the variable \"factory\" from the try phrase."},{"line_number":10,"context_line":"closes-bug : #38975"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9f560f44_76f4d787","line":7,"updated":"2020-10-08 15:06:27.000000000","message":"title is a bit too generic","commit_id":"0dcd80939d2dc0e5b3e474edc6af1c1edf147630"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"7118b37c211ec6cf1d577dd2024a2faf8fdd8794","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adding requested changes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adding the try exception block in the function default_interface() to catch the exception IncompatibleInterface issued by get_interface(), and raise NoValidDefaultForInterface instead, also removed the variable \"factory\" from the try phrase."},{"line_number":10,"context_line":"closes-bug : #38975"},{"line_number":11,"context_line":"Change-Id: Id47d862950d7bab771901c57b0f33b5d68689566"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9f560f44_d6ede3b8","line":9,"updated":"2020-10-08 15:06:27.000000000","message":"the length of each line should not pass 80 chars","commit_id":"0dcd80939d2dc0e5b3e474edc6af1c1edf147630"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"7118b37c211ec6cf1d577dd2024a2faf8fdd8794","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Adding requested changes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adding the try exception block in the function default_interface() to catch the exception IncompatibleInterface issued by get_interface(), and raise NoValidDefaultForInterface instead, also removed the variable \"factory\" from the try phrase."},{"line_number":10,"context_line":"closes-bug : #38975"},{"line_number":11,"context_line":"Change-Id: Id47d862950d7bab771901c57b0f33b5d68689566"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9f560f44_16291bf1","line":10,"updated":"2020-10-08 15:06:27.000000000","message":"I believe closes-bug is deprecated, you should use story and task as suggested by Iury","commit_id":"0dcd80939d2dc0e5b3e474edc6af1c1edf147630"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"43c5531e0d393d9c6483bc249422d52aa6d943b4","unresolved":false,"context_lines":[{"line_number":10,"context_line":"to catch the exception IncompatibleInterface issued by get_interface(),"},{"line_number":11,"context_line":"and raise NoValidDefaultForInterface instead,"},{"line_number":12,"context_line":"removed the variable \"factory\" from the try phrase."},{"line_number":13,"context_line":"Story : #2007390"},{"line_number":14,"context_line":"Task : #38975"},{"line_number":15,"context_line":"Change-Id: Id47d862950d7bab771901c57b0f33b5d68689566"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9f560f44_9153756c","line":13,"updated":"2020-10-08 15:56:26.000000000","message":"The format is \"Story: 2007390\" and \"Task: 38975\" and you also need an empty line between the commit message body and these tags.\n\nThe tags are normally linked and used to consolidate/track items. If the format is wrong or the carriage return is missing, they won\u0027t be identified","commit_id":"b69bd4105d078d4d4e21b4b64721b41fe32cc31c"}],"ironic/common/driver_factory.py":[{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"58617fdbadb77ef689f37bf920cdcc18cea72305","unresolved":false,"context_lines":[{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    if impl_name is not None:"},{"line_number":139,"context_line":"        # Check that the default is correct for this type"},{"line_number":140,"context_line":"        get_interface(hw_type, interface_type, impl_name)"},{"line_number":141,"context_line":"    else:"},{"line_number":142,"context_line":"        supported \u003d getattr(hw_type,"},{"line_number":143,"context_line":"                            \u0027supported_%s_interfaces\u0027 % interface_type)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_db286c99","line":140,"range":{"start_line":140,"start_character":8,"end_line":140,"end_character":21},"updated":"2020-10-08 14:49:35.000000000","message":"get_interface will raise IncompatibleInterface so it should have a try / catch here","commit_id":"88eb5c745ebd8e39c987a5a76145c7f0d7d9855e"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"2561eac3f9830d2c764fe5d87402606e310ec7ee","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        if node is not None:"},{"line_number":162,"context_line":"            node_info \u003d _(\u0027 node %s with\u0027) % node"},{"line_number":163,"context_line":"        try:"},{"line_number":164,"context_line":"            factory \u003d _INTERFACE_LOADERS[interface_type]()"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"        except KeyError:"},{"line_number":167,"context_line":"            raise exception.IncompatibleInterface("}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_a5af5b29","line":164,"range":{"start_line":164,"start_character":11,"end_line":164,"end_character":19},"updated":"2020-10-08 13:33:18.000000000","message":"doesn\u0027t seem like the factory variable is used anywhere after this block, maybe this was supposed to be a L133 ?","commit_id":"88eb5c745ebd8e39c987a5a76145c7f0d7d9855e"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"54b6ca135a7cdbcebcf34e73a5581d9767a8b200","unresolved":false,"context_lines":[{"line_number":138,"context_line":"    if impl_name is not None:"},{"line_number":139,"context_line":"        try:"},{"line_number":140,"context_line":"            # Check that the default is correct for this type"},{"line_number":141,"context_line":"            get_interface(hw_type, interface_type, impl_name)"},{"line_number":142,"context_line":"        except KeyError:"},{"line_number":143,"context_line":"            raise exception.IncompatibleInterface("},{"line_number":144,"context_line":"                interface_type\u003dinterface_type,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_432d73fb","line":141,"range":{"start_line":141,"start_character":12,"end_line":141,"end_character":25},"updated":"2020-10-11 21:59:11.000000000","message":"It looks like function get_interface already catches KeyError in one place, and raises IncompatibleInterface in another place. If this function can still raise a KeyError then this try/except should be moved inside get_interface.\n\nAccording to the doc text on get_interface, KeyError should never be raised","commit_id":"b69bd4105d078d4d4e21b4b64721b41fe32cc31c"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"ce56c375c6586cc2244beba8e8d324ec41954713","unresolved":false,"context_lines":[{"line_number":138,"context_line":"    if impl_name is not None:"},{"line_number":139,"context_line":"        try:"},{"line_number":140,"context_line":"            # Check that the default is correct for this type"},{"line_number":141,"context_line":"            get_interface(hw_type, interface_type, impl_name)"},{"line_number":142,"context_line":"        except KeyError:"},{"line_number":143,"context_line":"            raise exception.IncompatibleInterface("},{"line_number":144,"context_line":"                interface_type\u003dinterface_type,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f6b1bfe_35d92383","line":141,"range":{"start_line":141,"start_character":12,"end_line":141,"end_character":25},"in_reply_to":"9f560f44_23e5dadb","updated":"2020-10-15 14:46:47.000000000","message":"\u003e According to the description of the bug we should catch\n \u003e IncompatibleInterface and raise NoValidDefaultForInterface\n \u003e \n \u003e https://storyboard.openstack.org/#!/story/2007390","commit_id":"b69bd4105d078d4d4e21b4b64721b41fe32cc31c"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"072a9683ac230bf90ad6fe8836d0d06361acf970","unresolved":false,"context_lines":[{"line_number":138,"context_line":"    if impl_name is not None:"},{"line_number":139,"context_line":"        try:"},{"line_number":140,"context_line":"            # Check that the default is correct for this type"},{"line_number":141,"context_line":"            get_interface(hw_type, interface_type, impl_name)"},{"line_number":142,"context_line":"        except KeyError:"},{"line_number":143,"context_line":"            raise exception.IncompatibleInterface("},{"line_number":144,"context_line":"                interface_type\u003dinterface_type,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_23e5dadb","line":141,"range":{"start_line":141,"start_character":12,"end_line":141,"end_character":25},"in_reply_to":"9f560f44_432d73fb","updated":"2020-10-12 08:13:20.000000000","message":"According to the description of the bug we should catch IncompatibleInterface and raise NoValidDefaultForInterface \n\nhttps://storyboard.openstack.org/#!/story/2007390","commit_id":"b69bd4105d078d4d4e21b4b64721b41fe32cc31c"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"43c5531e0d393d9c6483bc249422d52aa6d943b4","unresolved":false,"context_lines":[{"line_number":135,"context_line":"    # The fallback default from the configuration"},{"line_number":136,"context_line":"    impl_name \u003d getattr(CONF, \u0027default_%s_interface\u0027 % interface_type)"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    if impl_name is not None:"},{"line_number":139,"context_line":"        try:"},{"line_number":140,"context_line":"            # Check that the default is correct for this type"},{"line_number":141,"context_line":"            get_interface(hw_type, interface_type, impl_name)"},{"line_number":142,"context_line":"        except KeyError:"},{"line_number":143,"context_line":"            raise exception.IncompatibleInterface("},{"line_number":144,"context_line":"                interface_type\u003dinterface_type,"},{"line_number":145,"context_line":"                hardware_type\u003dhw_type.__class__.__name__)"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    else:"},{"line_number":148,"context_line":"        supported \u003d getattr(hw_type,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_11ee458a","line":145,"range":{"start_line":138,"start_character":0,"end_line":145,"end_character":57},"updated":"2020-10-08 15:56:26.000000000","message":"Greetings, could you please add a unit test to test for this case. Thanks!","commit_id":"b69bd4105d078d4d4e21b4b64721b41fe32cc31c"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"ce56c375c6586cc2244beba8e8d324ec41954713","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        try:"},{"line_number":140,"context_line":"            # Check that the default is correct for this type"},{"line_number":141,"context_line":"            get_interface(hw_type, interface_type, impl_name)"},{"line_number":142,"context_line":"        except KeyError:"},{"line_number":143,"context_line":"            raise exception.IncompatibleInterface("},{"line_number":144,"context_line":"                interface_type\u003dinterface_type,"},{"line_number":145,"context_line":"                hardware_type\u003dhw_type.__class__.__name__)"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    else:"},{"line_number":148,"context_line":"        supported \u003d getattr(hw_type,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f6b1bfe_55dc9f73","line":145,"range":{"start_line":142,"start_character":7,"end_line":145,"end_character":57},"updated":"2020-10-15 14:46:47.000000000","message":"I think you forgot to address my comment in the last patchset, \n\"According to the description of the bug we should catch\nIncompatibleInterface and raise NoValidDefaultForInterface\n\nhttps://storyboard.openstack.org/#!/story/2007390\"","commit_id":"20d552080d6a552aa3cd46e48f9aa9ee34d73c5e"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"7a70ef63fb10a68aa7f5d763f5628527c92f2bd7","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        try:"},{"line_number":140,"context_line":"            # Check that the default is correct for this type"},{"line_number":141,"context_line":"            get_interface(hw_type, interface_type, impl_name)"},{"line_number":142,"context_line":"        except KeyError:"},{"line_number":143,"context_line":"            exception.IncompatibleInterface("},{"line_number":144,"context_line":"                interface_type\u003dinterface_type,"},{"line_number":145,"context_line":"                hardware_type\u003dhw_type.__class__.__name__)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f681702_3780228c","line":142,"range":{"start_line":142,"start_character":8,"end_line":142,"end_character":24},"updated":"2020-10-19 09:41:46.000000000","message":"This exception is incorrect, it shouldn\u0027t be KeyError.","commit_id":"4355a7db6190eb1e39bcdc8df466377e2d35f999"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"7a70ef63fb10a68aa7f5d763f5628527c92f2bd7","unresolved":false,"context_lines":[{"line_number":140,"context_line":"            # Check that the default is correct for this type"},{"line_number":141,"context_line":"            get_interface(hw_type, interface_type, impl_name)"},{"line_number":142,"context_line":"        except KeyError:"},{"line_number":143,"context_line":"            exception.IncompatibleInterface("},{"line_number":144,"context_line":"                interface_type\u003dinterface_type,"},{"line_number":145,"context_line":"                hardware_type\u003dhw_type.__class__.__name__)"},{"line_number":146,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5f681702_973f76d5","line":143,"range":{"start_line":143,"start_character":12,"end_line":143,"end_character":43},"updated":"2020-10-19 09:41:46.000000000","message":"You need to raise NoValidDefaultForInterface","commit_id":"4355a7db6190eb1e39bcdc8df466377e2d35f999"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"7a70ef63fb10a68aa7f5d763f5628527c92f2bd7","unresolved":false,"context_lines":[{"line_number":144,"context_line":"                interface_type\u003dinterface_type,"},{"line_number":145,"context_line":"                hardware_type\u003dhw_type.__class__.__name__)"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"        node_info \u003d \"\""},{"line_number":148,"context_line":"        raise exception.NoValidDefaultForInterface("},{"line_number":149,"context_line":"            interface_type\u003dinterface_type, driver\u003ddriver_name,"},{"line_number":150,"context_line":"            node_info\u003dnode_info)"},{"line_number":151,"context_line":"    else:"},{"line_number":152,"context_line":"        supported \u003d getattr(hw_type,"},{"line_number":153,"context_line":"                            \u0027supported_%s_interfaces\u0027 % interface_type)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f681702_d720ceb3","line":150,"range":{"start_line":147,"start_character":0,"end_line":150,"end_character":32},"updated":"2020-10-19 09:41:46.000000000","message":"why this is necessary? .-.","commit_id":"4355a7db6190eb1e39bcdc8df466377e2d35f999"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"a77043c5d05106087cf9ec3f89868eb0a96e4b9a","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        except exception.IncompatibleInterface:"},{"line_number":143,"context_line":"            raise exception.NoValidDefaultForInterface("},{"line_number":144,"context_line":"                interface_type\u003dinterface_type, driver\u003ddriver_name,"},{"line_number":145,"context_line":"                node_info\u003dnode_info)"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    else:"},{"line_number":148,"context_line":"        supported \u003d getattr(hw_type,"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f681702_6f547acb","line":145,"updated":"2020-10-19 13:21:01.000000000","message":"pep8: F821 undefined name \u0027node_info\u0027","commit_id":"40c5dce8a949a103a0095fa38e01a056ec3582c4"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"7bfe5c8bc16ff908380e610c279cb4d5a26898a2","unresolved":false,"context_lines":[{"line_number":128,"context_line":"                 message."},{"line_number":129,"context_line":"    :returns: an entrypoint name of the calculated default implementation."},{"line_number":130,"context_line":"    :raises: InterfaceNotFoundInEntrypoint if the entry point was not found."},{"line_number":131,"context_line":"    :raises: NoValidDefaultForInterface if no default interface can be found."},{"line_number":132,"context_line":"    \"\"\""},{"line_number":133,"context_line":"    factory \u003d _INTERFACE_LOADERS[interface_type]"},{"line_number":134,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"5f681702_bc2c099a","line":131,"updated":"2020-10-19 21:16:07.000000000","message":"This can be removed, this function should no longer raise NoValidDefaultForInterface","commit_id":"ebe4d47df8c3325af71713d894e9b640c8568f2e"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"94763c41a187375cac3c1f3980f83c206c420f60","unresolved":false,"context_lines":[{"line_number":128,"context_line":"                 message."},{"line_number":129,"context_line":"    :returns: an entrypoint name of the calculated default implementation."},{"line_number":130,"context_line":"    :raises: InterfaceNotFoundInEntrypoint if the entry point was not found."},{"line_number":131,"context_line":"    :raises: NoValidDefaultForInterface if no default interface can be found."},{"line_number":132,"context_line":"    \"\"\""},{"line_number":133,"context_line":"    factory \u003d _INTERFACE_LOADERS[interface_type]"},{"line_number":134,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3f65232a_0d1fbb6c","line":131,"in_reply_to":"3f65232a_3222dca5","updated":"2020-10-23 19:40:50.000000000","message":"oh whoops, ignore my comment","commit_id":"ebe4d47df8c3325af71713d894e9b640c8568f2e"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"c7d24fbe0b9d6997778462e2e20844e7073400a6","unresolved":false,"context_lines":[{"line_number":128,"context_line":"                 message."},{"line_number":129,"context_line":"    :returns: an entrypoint name of the calculated default implementation."},{"line_number":130,"context_line":"    :raises: InterfaceNotFoundInEntrypoint if the entry point was not found."},{"line_number":131,"context_line":"    :raises: NoValidDefaultForInterface if no default interface can be found."},{"line_number":132,"context_line":"    \"\"\""},{"line_number":133,"context_line":"    factory \u003d _INTERFACE_LOADERS[interface_type]"},{"line_number":134,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3f65232a_3222dca5","line":131,"in_reply_to":"5f681702_bc2c099a","updated":"2020-10-23 07:54:20.000000000","message":"mmm but it does at L143 and L167","commit_id":"ebe4d47df8c3325af71713d894e9b640c8568f2e"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"c9b1416c0d81dd46b326eceb2835a722d2199d2d","unresolved":false,"context_lines":[{"line_number":128,"context_line":"                 message."},{"line_number":129,"context_line":"    :returns: an entrypoint name of the calculated default implementation."},{"line_number":130,"context_line":"    :raises: InterfaceNotFoundInEntrypoint if the entry point was not found."},{"line_number":131,"context_line":"    :raises: NoValidDefaultForInterface if no default interface can be found"},{"line_number":132,"context_line":"    \"\"\""},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    factory \u003d _INTERFACE_LOADERS[interface_type]"}],"source_content_type":"text/x-python","patch_set":10,"id":"3f65232a_838d4533","line":131,"updated":"2020-10-27 08:52:01.000000000","message":"nit: why removing the dot at the end here?","commit_id":"a724fc43f9d8a23be33fee5e42be7caa9a9425c5"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"1dfa6fd859d5973559b74f9ec2fd81d29df8dd35","unresolved":false,"context_lines":[{"line_number":128,"context_line":"                 message."},{"line_number":129,"context_line":"    :returns: an entrypoint name of the calculated default implementation."},{"line_number":130,"context_line":"    :raises: InterfaceNotFoundInEntrypoint if the entry point was not found."},{"line_number":131,"context_line":"    :raises: NoValidDefaultForInterface if no default interface can be found."},{"line_number":132,"context_line":"    \"\"\""},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    factory \u003d _INTERFACE_LOADERS[interface_type]"}],"source_content_type":"text/x-python","patch_set":11,"id":"3f65232a_31659046","line":131,"updated":"2020-10-27 18:15:49.000000000","message":"diff between the approved and change and the new change is just the period, will approve.","commit_id":"d5d4a9996cd40e48bfe865f8878081ffa36f7b29"}]}