)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"b87aab86ac6fccd190af602fe763fbafee9f4ea4","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2020-10-19 14:51:22 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Rewrite devstack/tools/ironic/scripts/create-node.sh in Python"},{"line_number":8,"context_line":"Adding the changes from the earlier patch by"},{"line_number":9,"context_line":"Alexander Bashmakov which got abandoned"},{"line_number":10,"context_line":"Link to the earlier patch - https://review.opendev.org/#/c/346832/"},{"line_number":11,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f681702_57f4be5b","line":8,"updated":"2020-10-19 09:35:55.000000000","message":"After the title you need an empty line, otherwise it will show  a long message \u003d)","commit_id":"2ad2aff5db7d33e98ccd83e4b5b0504fda27ac12"}],"devstack/tools/ironic/scripts/create-node.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"1107ddf58325c48b5b328540ad72d18edc760664","unresolved":false,"context_lines":[{"line_number":30,"context_line":"def parse_args():"},{"line_number":31,"context_line":"    \"\"\"Parse and return command-line arguments.\"\"\""},{"line_number":32,"context_line":"    parser \u003d argparse.ArgumentParser("},{"line_number":33,"context_line":"        description\u003d\u0027Creates baremetal poseur\u0027 +"},{"line_number":34,"context_line":"                    \u0027nodes for ironic testing purposes.\u0027)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    parser.add_argument(\u0027-n\u0027, required\u003dTrue, metavar\u003d\u0027\u003cname\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f681702_4ca8ac1e","line":33,"updated":"2020-10-19 12:53:17.000000000","message":"pep8: W504 line break after binary operator","commit_id":"2ad2aff5db7d33e98ccd83e4b5b0504fda27ac12"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"1107ddf58325c48b5b328540ad72d18edc760664","unresolved":false,"context_lines":[{"line_number":170,"context_line":"        ovs_index \u003d ip.link_lookup(ifname\u003dovs_name)[0]"},{"line_number":171,"context_line":"    except IndexError:"},{"line_number":172,"context_line":"        sys.exit(\"unable to set link state to UP for %s: %s\" % ovs_name,"},{"line_number":173,"context_line":"                 str(e))"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"    # Up the interface"},{"line_number":176,"context_line":"    ip.link(\"set\", index\u003dovs_index, state\u003d\"up\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f681702_ac622015","line":173,"updated":"2020-10-19 12:53:17.000000000","message":"pep8: F821 undefined name \u0027e\u0027","commit_id":"2ad2aff5db7d33e98ccd83e4b5b0504fda27ac12"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"1107ddf58325c48b5b328540ad72d18edc760664","unresolved":false,"context_lines":[{"line_number":384,"context_line":"        vol_dict \u003d {tar_dir: tar_dir,"},{"line_number":385,"context_line":"                    vol_name: vol_name,"},{"line_number":386,"context_line":"                    disk_size: disk_size,"},{"line_number":387,"context_line":"                    disk_format: args.disk_format,"},{"line_number":388,"context_line":"                    storage_pool: storage_pool,"},{"line_number":389,"context_line":"                    pool_name: pool_name}"},{"line_number":390,"context_line":"        domain_dict \u003d {log_dir: args.log_dir,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f681702_8c676426","line":387,"updated":"2020-10-19 12:53:17.000000000","message":"pep8: F821 undefined name \u0027disk_format\u0027","commit_id":"2ad2aff5db7d33e98ccd83e4b5b0504fda27ac12"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"1107ddf58325c48b5b328540ad72d18edc760664","unresolved":false,"context_lines":[{"line_number":387,"context_line":"                    disk_format: args.disk_format,"},{"line_number":388,"context_line":"                    storage_pool: storage_pool,"},{"line_number":389,"context_line":"                    pool_name: pool_name}"},{"line_number":390,"context_line":"        domain_dict \u003d {log_dir: args.log_dir,"},{"line_number":391,"context_line":"                       dom_name: args.dom_name,"},{"line_number":392,"context_line":"                       vol_path: vol_path,"},{"line_number":393,"context_line":"                       arch: args.arch,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f681702_ec6c180a","line":390,"updated":"2020-10-19 12:53:17.000000000","message":"pep8: F821 undefined name \u0027log_dir\u0027","commit_id":"2ad2aff5db7d33e98ccd83e4b5b0504fda27ac12"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"1107ddf58325c48b5b328540ad72d18edc760664","unresolved":false,"context_lines":[{"line_number":388,"context_line":"                    storage_pool: storage_pool,"},{"line_number":389,"context_line":"                    pool_name: pool_name}"},{"line_number":390,"context_line":"        domain_dict \u003d {log_dir: args.log_dir,"},{"line_number":391,"context_line":"                       dom_name: args.dom_name,"},{"line_number":392,"context_line":"                       vol_path: vol_path,"},{"line_number":393,"context_line":"                       arch: args.arch,"},{"line_number":394,"context_line":"                       cpus: cpus,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f681702_cc715ce3","line":391,"updated":"2020-10-19 12:53:17.000000000","message":"pep8: F821 undefined name \u0027dom_name\u0027","commit_id":"2ad2aff5db7d33e98ccd83e4b5b0504fda27ac12"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"1107ddf58325c48b5b328540ad72d18edc760664","unresolved":false,"context_lines":[{"line_number":389,"context_line":"                    pool_name: pool_name}"},{"line_number":390,"context_line":"        domain_dict \u003d {log_dir: args.log_dir,"},{"line_number":391,"context_line":"                       dom_name: args.dom_name,"},{"line_number":392,"context_line":"                       vol_path: vol_path,"},{"line_number":393,"context_line":"                       arch: args.arch,"},{"line_number":394,"context_line":"                       cpus: cpus,"},{"line_number":395,"context_line":"                       mem: mem_size,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f681702_0c7354e9","line":392,"updated":"2020-10-19 12:53:17.000000000","message":"pep8: F821 undefined name \u0027vol_path\u0027","commit_id":"2ad2aff5db7d33e98ccd83e4b5b0504fda27ac12"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"1107ddf58325c48b5b328540ad72d18edc760664","unresolved":false,"context_lines":[{"line_number":389,"context_line":"                    pool_name: pool_name}"},{"line_number":390,"context_line":"        domain_dict \u003d {log_dir: args.log_dir,"},{"line_number":391,"context_line":"                       dom_name: args.dom_name,"},{"line_number":392,"context_line":"                       vol_path: vol_path,"},{"line_number":393,"context_line":"                       arch: args.arch,"},{"line_number":394,"context_line":"                       cpus: cpus,"},{"line_number":395,"context_line":"                       mem: mem_size,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f681702_2c7610da","line":392,"updated":"2020-10-19 12:53:17.000000000","message":"pep8: F821 undefined name \u0027vol_path\u0027","commit_id":"2ad2aff5db7d33e98ccd83e4b5b0504fda27ac12"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"1107ddf58325c48b5b328540ad72d18edc760664","unresolved":false,"context_lines":[{"line_number":390,"context_line":"        domain_dict \u003d {log_dir: args.log_dir,"},{"line_number":391,"context_line":"                       dom_name: args.dom_name,"},{"line_number":392,"context_line":"                       vol_path: vol_path,"},{"line_number":393,"context_line":"                       arch: args.arch,"},{"line_number":394,"context_line":"                       cpus: cpus,"},{"line_number":395,"context_line":"                       mem: mem_size,"},{"line_number":396,"context_line":"                       emu: args.emu,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f681702_6c80088d","line":393,"updated":"2020-10-19 12:53:17.000000000","message":"pep8: F821 undefined name \u0027arch\u0027","commit_id":"2ad2aff5db7d33e98ccd83e4b5b0504fda27ac12"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"1107ddf58325c48b5b328540ad72d18edc760664","unresolved":false,"context_lines":[{"line_number":392,"context_line":"                       vol_path: vol_path,"},{"line_number":393,"context_line":"                       arch: args.arch,"},{"line_number":394,"context_line":"                       cpus: cpus,"},{"line_number":395,"context_line":"                       mem: mem_size,"},{"line_number":396,"context_line":"                       emu: args.emu,"},{"line_number":397,"context_line":"                       disk_format: args.disk_format,"},{"line_number":398,"context_line":"                       nic_driver: nic_driver,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f681702_4c7d4cb0","line":395,"updated":"2020-10-19 12:53:17.000000000","message":"pep8: F821 undefined name \u0027mem\u0027","commit_id":"2ad2aff5db7d33e98ccd83e4b5b0504fda27ac12"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"1107ddf58325c48b5b328540ad72d18edc760664","unresolved":false,"context_lines":[{"line_number":393,"context_line":"                       arch: args.arch,"},{"line_number":394,"context_line":"                       cpus: cpus,"},{"line_number":395,"context_line":"                       mem: mem_size,"},{"line_number":396,"context_line":"                       emu: args.emu,"},{"line_number":397,"context_line":"                       disk_format: args.disk_format,"},{"line_number":398,"context_line":"                       nic_driver: nic_driver,"},{"line_number":399,"context_line":"                       conn: conn}"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f681702_ac4b4085","line":396,"updated":"2020-10-19 12:53:17.000000000","message":"pep8: F821 undefined name \u0027emu\u0027","commit_id":"2ad2aff5db7d33e98ccd83e4b5b0504fda27ac12"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"1107ddf58325c48b5b328540ad72d18edc760664","unresolved":false,"context_lines":[{"line_number":394,"context_line":"                       cpus: cpus,"},{"line_number":395,"context_line":"                       mem: mem_size,"},{"line_number":396,"context_line":"                       emu: args.emu,"},{"line_number":397,"context_line":"                       disk_format: args.disk_format,"},{"line_number":398,"context_line":"                       nic_driver: nic_driver,"},{"line_number":399,"context_line":"                       conn: conn}"},{"line_number":400,"context_line":"        vol_path \u003d make_storage_vol(**vol_dict)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f681702_8c500435","line":397,"updated":"2020-10-19 12:53:17.000000000","message":"pep8: F821 undefined name \u0027disk_format\u0027","commit_id":"2ad2aff5db7d33e98ccd83e4b5b0504fda27ac12"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"1107ddf58325c48b5b328540ad72d18edc760664","unresolved":false,"context_lines":[{"line_number":397,"context_line":"                       disk_format: args.disk_format,"},{"line_number":398,"context_line":"                       nic_driver: nic_driver,"},{"line_number":399,"context_line":"                       conn: conn}"},{"line_number":400,"context_line":"        vol_path \u003d make_storage_vol(**vol_dict)"},{"line_number":401,"context_line":"        domain \u003d make_domain(**domain_dict)"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"    if domain:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f681702_ec453872","line":400,"updated":"2020-10-19 12:53:17.000000000","message":"pep8: F841 local variable \u0027vol_path\u0027 is assigned to but never used","commit_id":"2ad2aff5db7d33e98ccd83e4b5b0504fda27ac12"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"67aff0c087447045f9d11e20524f400dc5691ab1","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"\"\"\"Create baremetal poseur nodes for ironic testing purposes.\"\"\""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import argparse"},{"line_number":19,"context_line":"import os.path"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f65232a_6fc00352","line":16,"range":{"start_line":16,"start_character":20,"end_line":16,"end_character":26},"updated":"2020-10-22 02:04:30.000000000","message":"I\u0027m not sure what word your meaning here, but you can just shorten the entire statement.\n\nOr also delete the line, it is not required. :)","commit_id":"6ef563505dbe85853967ae14fd56751ee4434c6e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"67aff0c087447045f9d11e20524f400dc5691ab1","unresolved":false,"context_lines":[{"line_number":30,"context_line":"def parse_args():"},{"line_number":31,"context_line":"    \"\"\"Parse and return command-line arguments.\"\"\""},{"line_number":32,"context_line":"    parser \u003d argparse.ArgumentParser("},{"line_number":33,"context_line":"        description\u003d\u0027Creates baremetal poseur\u0027 +"},{"line_number":34,"context_line":"                    \u0027nodes for ironic testing purposes.\u0027)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    parser.add_argument(\u0027-n\u0027, required\u003dTrue, metavar\u003d\u0027\u003cname\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f65232a_0fcfcf7f","line":33,"range":{"start_line":33,"start_character":46,"end_line":33,"end_character":48},"updated":"2020-10-22 02:04:30.000000000","message":"In python, with strings continuing to the next line, you don\u0027t need to tell it to concatenate the string together with a +.\n\nIf you remove the + character and trim the whitespace, it the pep8 failure will go away. :)","commit_id":"6ef563505dbe85853967ae14fd56751ee4434c6e"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"346b2e915f6eb6909515f4a4728eb1ee43ad8077","unresolved":false,"context_lines":[{"line_number":30,"context_line":"def parse_args():"},{"line_number":31,"context_line":"    \"\"\"Parse and return command-line arguments.\"\"\""},{"line_number":32,"context_line":"    parser \u003d argparse.ArgumentParser("},{"line_number":33,"context_line":"        description\u003d\u0027Creates baremetal poseur\u0027 +"},{"line_number":34,"context_line":"                    \u0027nodes for ironic testing purposes.\u0027)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    parser.add_argument(\u0027-n\u0027, required\u003dTrue, metavar\u003d\u0027\u003cname\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f681702_5bf060ca","line":33,"updated":"2020-10-19 16:36:06.000000000","message":"pep8: W504 line break after binary operator","commit_id":"6ef563505dbe85853967ae14fd56751ee4434c6e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"67aff0c087447045f9d11e20524f400dc5691ab1","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    parser.add_argument(\u0027-c\u0027, required\u003dTrue, metavar\u003d\u0027\u003ccpus\u003e\u0027, type\u003dint,"},{"line_number":39,"context_line":"                        help\u003d\u0027number of CPUs\u0027, dest\u003d\u0027cpus\u0027)"},{"line_number":40,"context_line":"    parser.add_argument(\u0027-m\u0027, required\u003dTrue, metavar\u003d\u0027\u003cmem\u003e\u0027, type\u003dint,"},{"line_number":41,"context_line":"                        help\u003d\u0027memory size in kilobytes\u0027, dest\u003d\u0027memory_mb\u0027)"},{"line_number":42,"context_line":"    parser.add_argument(\u0027-d\u0027, required\u003dTrue, metavar\u003d\u0027\u003cdisk\u003e\u0027, type\u003dint,"},{"line_number":43,"context_line":"                        help\u003d\u0027volume disk size in gigabytes\u0027, dest\u003d\u0027disk_gb\u0027)"},{"line_number":44,"context_line":"    parser.add_argument(\u0027-a\u0027, required\u003dTrue, metavar\u003d\u0027\u003carch\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f65232a_af9dfb5a","line":41,"range":{"start_line":41,"start_character":57,"end_line":41,"end_character":74},"updated":"2020-10-22 02:04:30.000000000","message":"Further down towards the bottom, you use mem instead of memory_mb. I think you need to reconcile your argument names versus what is expected when your trying to use the arguments since you have a few different errors there.","commit_id":"6ef563505dbe85853967ae14fd56751ee4434c6e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"67aff0c087447045f9d11e20524f400dc5691ab1","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    parser.add_argument(\u0027-m\u0027, required\u003dTrue, metavar\u003d\u0027\u003cmem\u003e\u0027, type\u003dint,"},{"line_number":41,"context_line":"                        help\u003d\u0027memory size in kilobytes\u0027, dest\u003d\u0027memory_mb\u0027)"},{"line_number":42,"context_line":"    parser.add_argument(\u0027-d\u0027, required\u003dTrue, metavar\u003d\u0027\u003cdisk\u003e\u0027, type\u003dint,"},{"line_number":43,"context_line":"                        help\u003d\u0027volume disk size in gigabytes\u0027, dest\u003d\u0027disk_gb\u0027)"},{"line_number":44,"context_line":"    parser.add_argument(\u0027-a\u0027, required\u003dTrue, metavar\u003d\u0027\u003carch\u003e\u0027,"},{"line_number":45,"context_line":"                        help\u003d\u0027CPU architecture\u0027, dest\u003d\u0027cpu_arch\u0027)"},{"line_number":46,"context_line":"    parser.add_argument(\u0027-b\u0027, required\u003dTrue, metavar\u003d\u0027\u003cbridge\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f65232a_4f77073c","line":43,"updated":"2020-10-22 02:04:30.000000000","message":"Your name\u0027s don\u0027t match here for what you\u0027ve set further down where your invoking size checks. I think the arg_parse results is looking for args.disk_size.","commit_id":"6ef563505dbe85853967ae14fd56751ee4434c6e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"67aff0c087447045f9d11e20524f400dc5691ab1","unresolved":false,"context_lines":[{"line_number":147,"context_line":"    except Exception as e:"},{"line_number":148,"context_line":"        # NOTE (abashmak) This is a hack to overcome limitation of ovs library"},{"line_number":149,"context_line":"        #      not supporting --may-exist option for add-br command. If the"},{"line_number":150,"context_line":"        #      bridge already exists, a generic Exception is thrown."},{"line_number":151,"context_line":"        if \"already exists\" not in str(e):"},{"line_number":152,"context_line":"            sys.exit(\"unable to add openvswitch bridge %s: %s\" % bridge,"},{"line_number":153,"context_line":"                     str(e))"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f65232a_cfaaf783","line":150,"range":{"start_line":150,"start_character":40,"end_line":150,"end_character":68},"updated":"2020-10-22 02:04:30.000000000","message":"Thanks for the note, that makes me really sad, but it is what it is!","commit_id":"6ef563505dbe85853967ae14fd56751ee4434c6e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"67aff0c087447045f9d11e20524f400dc5691ab1","unresolved":false,"context_lines":[{"line_number":150,"context_line":"        #      bridge already exists, a generic Exception is thrown."},{"line_number":151,"context_line":"        if \"already exists\" not in str(e):"},{"line_number":152,"context_line":"            sys.exit(\"unable to add openvswitch bridge %s: %s\" % bridge,"},{"line_number":153,"context_line":"                     str(e))"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"    try:"},{"line_number":156,"context_line":"        # Attempt to add port on OVS interface"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f65232a_afafbb92","line":153,"range":{"start_line":153,"start_character":21,"end_line":153,"end_character":27},"updated":"2020-10-22 02:04:30.000000000","message":"You likely don\u0027t need to cast it here, because it is cast by the %s.","commit_id":"6ef563505dbe85853967ae14fd56751ee4434c6e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"67aff0c087447045f9d11e20524f400dc5691ab1","unresolved":false,"context_lines":[{"line_number":162,"context_line":"        vsctl.run_command(commands\u003d[cmd_add, cmd_set],"},{"line_number":163,"context_line":"                          timeout_sec\u003d1, exception\u003dNone)"},{"line_number":164,"context_line":"    except Exception as e:"},{"line_number":165,"context_line":"        sys.exit(\"unable to add openvswitch port: %s\" % str(e))"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    try:"},{"line_number":168,"context_line":"        # Make sure OVS bridge interface exists"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f65232a_0f94ef43","line":165,"range":{"start_line":165,"start_character":56,"end_line":165,"end_character":62},"updated":"2020-10-22 02:04:30.000000000","message":"Same as line 153","commit_id":"6ef563505dbe85853967ae14fd56751ee4434c6e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"67aff0c087447045f9d11e20524f400dc5691ab1","unresolved":false,"context_lines":[{"line_number":168,"context_line":"        # Make sure OVS bridge interface exists"},{"line_number":169,"context_line":"        ovs_name \u003d \"ovs-{}\".format(dom_name)"},{"line_number":170,"context_line":"        ovs_index \u003d ip.link_lookup(ifname\u003dovs_name)[0]"},{"line_number":171,"context_line":"    except IndexError:"},{"line_number":172,"context_line":"        sys.exit(\"unable to set link state to UP for %s: %s\" % ovs_name,"},{"line_number":173,"context_line":"                 str(e))"},{"line_number":174,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f65232a_ef909351","line":171,"range":{"start_line":171,"start_character":0,"end_line":171,"end_character":22},"updated":"2020-10-22 02:04:30.000000000","message":"Your forgetting the \"as e:\" portion of this exception handling, since e is otherwise unknown when you get to line 173.","commit_id":"6ef563505dbe85853967ae14fd56751ee4434c6e"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"346b2e915f6eb6909515f4a4728eb1ee43ad8077","unresolved":false,"context_lines":[{"line_number":170,"context_line":"        ovs_index \u003d ip.link_lookup(ifname\u003dovs_name)[0]"},{"line_number":171,"context_line":"    except IndexError:"},{"line_number":172,"context_line":"        sys.exit(\"unable to set link state to UP for %s: %s\" % ovs_name,"},{"line_number":173,"context_line":"                 str(e))"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"    # Up the interface"},{"line_number":176,"context_line":"    ip.link(\"set\", index\u003dovs_index, state\u003d\"up\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f681702_3beda4ef","line":173,"updated":"2020-10-19 16:36:06.000000000","message":"pep8: F821 undefined name \u0027e\u0027","commit_id":"6ef563505dbe85853967ae14fd56751ee4434c6e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"67aff0c087447045f9d11e20524f400dc5691ab1","unresolved":false,"context_lines":[{"line_number":170,"context_line":"        ovs_index \u003d ip.link_lookup(ifname\u003dovs_name)[0]"},{"line_number":171,"context_line":"    except IndexError:"},{"line_number":172,"context_line":"        sys.exit(\"unable to set link state to UP for %s: %s\" % ovs_name,"},{"line_number":173,"context_line":"                 str(e))"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"    # Up the interface"},{"line_number":176,"context_line":"    ip.link(\"set\", index\u003dovs_index, state\u003d\"up\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f65232a_4f9ee763","line":173,"range":{"start_line":173,"start_character":17,"end_line":173,"end_character":21},"updated":"2020-10-22 02:04:30.000000000","message":"you don\u0027t need to cast this.","commit_id":"6ef563505dbe85853967ae14fd56751ee4434c6e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"67aff0c087447045f9d11e20524f400dc5691ab1","unresolved":false,"context_lines":[{"line_number":293,"context_line":"    :param dom_name: libvirt domain name"},{"line_number":294,"context_line":"    :param port: port used to monitor domain"},{"line_number":295,"context_line":"    \"\"\""},{"line_number":296,"context_line":"    with open(os.devnull, \"w\") as devnull:"},{"line_number":297,"context_line":"        if subprocess.call([\"which\", \"vbmc\"], stdout\u003ddevnull) \u003d\u003d 0:"},{"line_number":298,"context_line":"            subprocess.call([\"vbmc\", \"add\", dom_name, \"--port\", port])"},{"line_number":299,"context_line":"            subprocess.call([\"vbmc\", \"start\", dom_name])"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"def print_mac(domain, bridge, port, dom_name):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f65232a_2f9bab72","line":299,"range":{"start_line":296,"start_character":0,"end_line":299,"end_character":56},"updated":"2020-10-22 02:04:30.000000000","message":"I guess this would work... we should likely double check.\n\nWith regards to invoking devnull, smart!","commit_id":"6ef563505dbe85853967ae14fd56751ee4434c6e"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"346b2e915f6eb6909515f4a4728eb1ee43ad8077","unresolved":false,"context_lines":[{"line_number":384,"context_line":"        vol_dict \u003d {tar_dir: tar_dir,"},{"line_number":385,"context_line":"                    vol_name: vol_name,"},{"line_number":386,"context_line":"                    disk_size: disk_size,"},{"line_number":387,"context_line":"                    disk_format: args.disk_format,"},{"line_number":388,"context_line":"                    storage_pool: storage_pool,"},{"line_number":389,"context_line":"                    pool_name: pool_name}"},{"line_number":390,"context_line":"        domain_dict \u003d {log_dir: args.log_dir,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f681702_9bbb18e4","line":387,"updated":"2020-10-19 16:36:06.000000000","message":"pep8: F821 undefined name \u0027disk_format\u0027","commit_id":"6ef563505dbe85853967ae14fd56751ee4434c6e"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"346b2e915f6eb6909515f4a4728eb1ee43ad8077","unresolved":false,"context_lines":[{"line_number":387,"context_line":"                    disk_format: args.disk_format,"},{"line_number":388,"context_line":"                    storage_pool: storage_pool,"},{"line_number":389,"context_line":"                    pool_name: pool_name}"},{"line_number":390,"context_line":"        domain_dict \u003d {log_dir: args.log_dir,"},{"line_number":391,"context_line":"                       dom_name: args.dom_name,"},{"line_number":392,"context_line":"                       vol_path: vol_path,"},{"line_number":393,"context_line":"                       arch: args.arch,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f681702_7bc0bc51","line":390,"updated":"2020-10-19 16:36:06.000000000","message":"pep8: F821 undefined name \u0027log_dir\u0027","commit_id":"6ef563505dbe85853967ae14fd56751ee4434c6e"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"346b2e915f6eb6909515f4a4728eb1ee43ad8077","unresolved":false,"context_lines":[{"line_number":388,"context_line":"                    storage_pool: storage_pool,"},{"line_number":389,"context_line":"                    pool_name: pool_name}"},{"line_number":390,"context_line":"        domain_dict \u003d {log_dir: args.log_dir,"},{"line_number":391,"context_line":"                       dom_name: args.dom_name,"},{"line_number":392,"context_line":"                       vol_path: vol_path,"},{"line_number":393,"context_line":"                       arch: args.arch,"},{"line_number":394,"context_line":"                       cpus: cpus,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f681702_dbb590f0","line":391,"updated":"2020-10-19 16:36:06.000000000","message":"pep8: F821 undefined name \u0027dom_name\u0027","commit_id":"6ef563505dbe85853967ae14fd56751ee4434c6e"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"346b2e915f6eb6909515f4a4728eb1ee43ad8077","unresolved":false,"context_lines":[{"line_number":389,"context_line":"                    pool_name: pool_name}"},{"line_number":390,"context_line":"        domain_dict \u003d {log_dir: args.log_dir,"},{"line_number":391,"context_line":"                       dom_name: args.dom_name,"},{"line_number":392,"context_line":"                       vol_path: vol_path,"},{"line_number":393,"context_line":"                       arch: args.arch,"},{"line_number":394,"context_line":"                       cpus: cpus,"},{"line_number":395,"context_line":"                       mem: mem_size,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f681702_1bcf0880","line":392,"updated":"2020-10-19 16:36:06.000000000","message":"pep8: F821 undefined name \u0027vol_path\u0027","commit_id":"6ef563505dbe85853967ae14fd56751ee4434c6e"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"346b2e915f6eb6909515f4a4728eb1ee43ad8077","unresolved":false,"context_lines":[{"line_number":389,"context_line":"                    pool_name: pool_name}"},{"line_number":390,"context_line":"        domain_dict \u003d {log_dir: args.log_dir,"},{"line_number":391,"context_line":"                       dom_name: args.dom_name,"},{"line_number":392,"context_line":"                       vol_path: vol_path,"},{"line_number":393,"context_line":"                       arch: args.arch,"},{"line_number":394,"context_line":"                       cpus: cpus,"},{"line_number":395,"context_line":"                       mem: mem_size,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f681702_bbba54db","line":392,"updated":"2020-10-19 16:36:06.000000000","message":"pep8: F821 undefined name \u0027vol_path\u0027","commit_id":"6ef563505dbe85853967ae14fd56751ee4434c6e"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"346b2e915f6eb6909515f4a4728eb1ee43ad8077","unresolved":false,"context_lines":[{"line_number":390,"context_line":"        domain_dict \u003d {log_dir: args.log_dir,"},{"line_number":391,"context_line":"                       dom_name: args.dom_name,"},{"line_number":392,"context_line":"                       vol_path: vol_path,"},{"line_number":393,"context_line":"                       arch: args.arch,"},{"line_number":394,"context_line":"                       cpus: cpus,"},{"line_number":395,"context_line":"                       mem: mem_size,"},{"line_number":396,"context_line":"                       emu: args.emu,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f681702_fbcb2c6f","line":393,"updated":"2020-10-19 16:36:06.000000000","message":"pep8: F821 undefined name \u0027arch\u0027","commit_id":"6ef563505dbe85853967ae14fd56751ee4434c6e"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"346b2e915f6eb6909515f4a4728eb1ee43ad8077","unresolved":false,"context_lines":[{"line_number":392,"context_line":"                       vol_path: vol_path,"},{"line_number":393,"context_line":"                       arch: args.arch,"},{"line_number":394,"context_line":"                       cpus: cpus,"},{"line_number":395,"context_line":"                       mem: mem_size,"},{"line_number":396,"context_line":"                       emu: args.emu,"},{"line_number":397,"context_line":"                       disk_format: args.disk_format,"},{"line_number":398,"context_line":"                       nic_driver: nic_driver,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f681702_5bc98076","line":395,"updated":"2020-10-19 16:36:06.000000000","message":"pep8: F821 undefined name \u0027mem\u0027","commit_id":"6ef563505dbe85853967ae14fd56751ee4434c6e"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"346b2e915f6eb6909515f4a4728eb1ee43ad8077","unresolved":false,"context_lines":[{"line_number":393,"context_line":"                       arch: args.arch,"},{"line_number":394,"context_line":"                       cpus: cpus,"},{"line_number":395,"context_line":"                       mem: mem_size,"},{"line_number":396,"context_line":"                       emu: args.emu,"},{"line_number":397,"context_line":"                       disk_format: args.disk_format,"},{"line_number":398,"context_line":"                       nic_driver: nic_driver,"},{"line_number":399,"context_line":"                       conn: conn}"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f681702_3bc64469","line":396,"updated":"2020-10-19 16:36:06.000000000","message":"pep8: F821 undefined name \u0027emu\u0027","commit_id":"6ef563505dbe85853967ae14fd56751ee4434c6e"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"346b2e915f6eb6909515f4a4728eb1ee43ad8077","unresolved":false,"context_lines":[{"line_number":394,"context_line":"                       cpus: cpus,"},{"line_number":395,"context_line":"                       mem: mem_size,"},{"line_number":396,"context_line":"                       emu: args.emu,"},{"line_number":397,"context_line":"                       disk_format: args.disk_format,"},{"line_number":398,"context_line":"                       nic_driver: nic_driver,"},{"line_number":399,"context_line":"                       conn: conn}"},{"line_number":400,"context_line":"        vol_path \u003d make_storage_vol(**vol_dict)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f681702_9ba038a8","line":397,"updated":"2020-10-19 16:36:06.000000000","message":"pep8: F821 undefined name \u0027disk_format\u0027","commit_id":"6ef563505dbe85853967ae14fd56751ee4434c6e"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"346b2e915f6eb6909515f4a4728eb1ee43ad8077","unresolved":false,"context_lines":[{"line_number":397,"context_line":"                       disk_format: args.disk_format,"},{"line_number":398,"context_line":"                       nic_driver: nic_driver,"},{"line_number":399,"context_line":"                       conn: conn}"},{"line_number":400,"context_line":"        vol_path \u003d make_storage_vol(**vol_dict)"},{"line_number":401,"context_line":"        domain \u003d make_domain(**domain_dict)"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"    if domain:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f681702_7ba55cb5","line":400,"updated":"2020-10-19 16:36:06.000000000","message":"pep8: F841 local variable \u0027vol_path\u0027 is assigned to but never used","commit_id":"6ef563505dbe85853967ae14fd56751ee4434c6e"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"0a2fed0548ebd12ca1ccf2c3aad571990c9d53d4","unresolved":false,"context_lines":[{"line_number":382,"context_line":"        vol_dict \u003d {tar_dir: tar_dir,"},{"line_number":383,"context_line":"                    vol_name: vol_name,"},{"line_number":384,"context_line":"                    disk_gb: disk_gb,"},{"line_number":385,"context_line":"                    disk_format: args.disk_format,"},{"line_number":386,"context_line":"                    storage_pool: storage_pool,"},{"line_number":387,"context_line":"                    pool_name: pool_name}"},{"line_number":388,"context_line":"        domain_dict \u003d {log_dir: args.log_dir,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f65232a_1bcc23bb","line":385,"updated":"2020-10-22 20:29:12.000000000","message":"pep8: F821 undefined name \u0027disk_format\u0027","commit_id":"afb4da7ce17ae0c4a9a1a55ba97b0941a5b83984"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"0a2fed0548ebd12ca1ccf2c3aad571990c9d53d4","unresolved":false,"context_lines":[{"line_number":385,"context_line":"                    disk_format: args.disk_format,"},{"line_number":386,"context_line":"                    storage_pool: storage_pool,"},{"line_number":387,"context_line":"                    pool_name: pool_name}"},{"line_number":388,"context_line":"        domain_dict \u003d {log_dir: args.log_dir,"},{"line_number":389,"context_line":"                       dom_name: args.dom_name,"},{"line_number":390,"context_line":"                       vol_path: vol_path,"},{"line_number":391,"context_line":"                       cpu_arch: args.cpu_arch,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f65232a_fbd04753","line":388,"updated":"2020-10-22 20:29:12.000000000","message":"pep8: F821 undefined name \u0027log_dir\u0027","commit_id":"afb4da7ce17ae0c4a9a1a55ba97b0941a5b83984"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"0a2fed0548ebd12ca1ccf2c3aad571990c9d53d4","unresolved":false,"context_lines":[{"line_number":386,"context_line":"                    storage_pool: storage_pool,"},{"line_number":387,"context_line":"                    pool_name: pool_name}"},{"line_number":388,"context_line":"        domain_dict \u003d {log_dir: args.log_dir,"},{"line_number":389,"context_line":"                       dom_name: args.dom_name,"},{"line_number":390,"context_line":"                       vol_path: vol_path,"},{"line_number":391,"context_line":"                       cpu_arch: args.cpu_arch,"},{"line_number":392,"context_line":"                       cpus: cpus,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f65232a_5bc5fb8d","line":389,"updated":"2020-10-22 20:29:12.000000000","message":"pep8: F821 undefined name \u0027dom_name\u0027","commit_id":"afb4da7ce17ae0c4a9a1a55ba97b0941a5b83984"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"0a2fed0548ebd12ca1ccf2c3aad571990c9d53d4","unresolved":false,"context_lines":[{"line_number":387,"context_line":"                    pool_name: pool_name}"},{"line_number":388,"context_line":"        domain_dict \u003d {log_dir: args.log_dir,"},{"line_number":389,"context_line":"                       dom_name: args.dom_name,"},{"line_number":390,"context_line":"                       vol_path: vol_path,"},{"line_number":391,"context_line":"                       cpu_arch: args.cpu_arch,"},{"line_number":392,"context_line":"                       cpus: cpus,"},{"line_number":393,"context_line":"                       mem: memory_mb,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f65232a_3bc2bf86","line":390,"updated":"2020-10-22 20:29:12.000000000","message":"pep8: F821 undefined name \u0027vol_path\u0027","commit_id":"afb4da7ce17ae0c4a9a1a55ba97b0941a5b83984"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"0a2fed0548ebd12ca1ccf2c3aad571990c9d53d4","unresolved":false,"context_lines":[{"line_number":387,"context_line":"                    pool_name: pool_name}"},{"line_number":388,"context_line":"        domain_dict \u003d {log_dir: args.log_dir,"},{"line_number":389,"context_line":"                       dom_name: args.dom_name,"},{"line_number":390,"context_line":"                       vol_path: vol_path,"},{"line_number":391,"context_line":"                       cpu_arch: args.cpu_arch,"},{"line_number":392,"context_line":"                       cpus: cpus,"},{"line_number":393,"context_line":"                       mem: memory_mb,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f65232a_9bbf93fa","line":390,"updated":"2020-10-22 20:29:12.000000000","message":"pep8: F821 undefined name \u0027vol_path\u0027","commit_id":"afb4da7ce17ae0c4a9a1a55ba97b0941a5b83984"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"0a2fed0548ebd12ca1ccf2c3aad571990c9d53d4","unresolved":false,"context_lines":[{"line_number":388,"context_line":"        domain_dict \u003d {log_dir: args.log_dir,"},{"line_number":389,"context_line":"                       dom_name: args.dom_name,"},{"line_number":390,"context_line":"                       vol_path: vol_path,"},{"line_number":391,"context_line":"                       cpu_arch: args.cpu_arch,"},{"line_number":392,"context_line":"                       cpus: cpus,"},{"line_number":393,"context_line":"                       mem: memory_mb,"},{"line_number":394,"context_line":"                       emu: args.emu,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f65232a_7bbc3705","line":391,"updated":"2020-10-22 20:29:12.000000000","message":"pep8: F821 undefined name \u0027cpu_arch\u0027","commit_id":"afb4da7ce17ae0c4a9a1a55ba97b0941a5b83984"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"0a2fed0548ebd12ca1ccf2c3aad571990c9d53d4","unresolved":false,"context_lines":[{"line_number":390,"context_line":"                       vol_path: vol_path,"},{"line_number":391,"context_line":"                       cpu_arch: args.cpu_arch,"},{"line_number":392,"context_line":"                       cpus: cpus,"},{"line_number":393,"context_line":"                       mem: memory_mb,"},{"line_number":394,"context_line":"                       emu: args.emu,"},{"line_number":395,"context_line":"                       disk_format: args.disk_format,"},{"line_number":396,"context_line":"                       nic_driver: nic_driver,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f65232a_db362bb5","line":393,"updated":"2020-10-22 20:29:12.000000000","message":"pep8: F821 undefined name \u0027mem\u0027","commit_id":"afb4da7ce17ae0c4a9a1a55ba97b0941a5b83984"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"0a2fed0548ebd12ca1ccf2c3aad571990c9d53d4","unresolved":false,"context_lines":[{"line_number":391,"context_line":"                       cpu_arch: args.cpu_arch,"},{"line_number":392,"context_line":"                       cpus: cpus,"},{"line_number":393,"context_line":"                       mem: memory_mb,"},{"line_number":394,"context_line":"                       emu: args.emu,"},{"line_number":395,"context_line":"                       disk_format: args.disk_format,"},{"line_number":396,"context_line":"                       nic_driver: nic_driver,"},{"line_number":397,"context_line":"                       conn: conn}"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f65232a_bb3b6f9a","line":394,"updated":"2020-10-22 20:29:12.000000000","message":"pep8: F821 undefined name \u0027emu\u0027","commit_id":"afb4da7ce17ae0c4a9a1a55ba97b0941a5b83984"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"0a2fed0548ebd12ca1ccf2c3aad571990c9d53d4","unresolved":false,"context_lines":[{"line_number":392,"context_line":"                       cpus: cpus,"},{"line_number":393,"context_line":"                       mem: memory_mb,"},{"line_number":394,"context_line":"                       emu: args.emu,"},{"line_number":395,"context_line":"                       disk_format: args.disk_format,"},{"line_number":396,"context_line":"                       nic_driver: nic_driver,"},{"line_number":397,"context_line":"                       conn: conn}"},{"line_number":398,"context_line":"        vol_path \u003d make_storage_vol(**vol_dict)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f65232a_1b41c30c","line":395,"updated":"2020-10-22 20:29:12.000000000","message":"pep8: F821 undefined name \u0027disk_format\u0027","commit_id":"afb4da7ce17ae0c4a9a1a55ba97b0941a5b83984"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"0a2fed0548ebd12ca1ccf2c3aad571990c9d53d4","unresolved":false,"context_lines":[{"line_number":395,"context_line":"                       disk_format: args.disk_format,"},{"line_number":396,"context_line":"                       nic_driver: nic_driver,"},{"line_number":397,"context_line":"                       conn: conn}"},{"line_number":398,"context_line":"        vol_path \u003d make_storage_vol(**vol_dict)"},{"line_number":399,"context_line":"        domain \u003d make_domain(**domain_dict)"},{"line_number":400,"context_line":""},{"line_number":401,"context_line":"    if domain:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f65232a_fb45e718","line":398,"updated":"2020-10-22 20:29:12.000000000","message":"pep8: F841 local variable \u0027vol_path\u0027 is assigned to but never used","commit_id":"afb4da7ce17ae0c4a9a1a55ba97b0941a5b83984"},{"author":{"_account_id":11929,"name":"Michael Turek","email":"mjturek@linux.vnet.ibm.com","username":"mjturek"},"change_message_id":"25c1a0bc3371902d1394472c230583b6b729d145","unresolved":false,"context_lines":[{"line_number":51,"context_line":"                        help\u003d\u0027volume disk format\u0027, dest\u003d\u0027disk_format\u0027)"},{"line_number":52,"context_line":"    parser.add_argument(\u0027-l\u0027, required\u003dFalse, metavar\u003d\u0027\u003clogdir\u003e\u0027,"},{"line_number":53,"context_line":"                        help\u003d\u0027logging diretory\u0027, dest\u003d\u0027log_dir\u0027)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    return parser.parse_args()"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3f65232a_2a2b7deb","line":54,"updated":"2020-10-23 17:52:59.000000000","message":"Storage pool argument was added in this commit [0]\n\n[0] https://github.com/openstack/ironic/commit/ce39115fa73e7d4f82b6c47a652c130a83cce3f6#diff-f4e8f68ea6047707b43791ca4545e9303690c1033b0947d257d6c8e62bf1c7e0","commit_id":"49eca452c9cc250af9d37a578cb41e86c5e88f9a"},{"author":{"_account_id":11929,"name":"Michael Turek","email":"mjturek@linux.vnet.ibm.com","username":"mjturek"},"change_message_id":"25c1a0bc3371902d1394472c230583b6b729d145","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        sys.exit(\"Path (%s) exists but is not a directory\" % path)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"def make_storage_pool(conn, pool_name, tar_dir):"},{"line_number":80,"context_line":"    \"\"\"Create new libvirt storage pool."},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    :param conn: libvirt connection object"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f65232a_6a357546","line":79,"updated":"2020-10-23 17:52:59.000000000","message":"Storage pool creation was moved into devstack/lib/ironic in this commit [0]. This whole function could be removed.\n\n[0] https://github.com/openstack/ironic/commit/ce39115fa73e7d4f82b6c47a652c130a83cce3f6#diff-f4e8f68ea6047707b43791ca4545e9303690c1033b0947d257d6c8e62bf1c7e0","commit_id":"49eca452c9cc250af9d37a578cb41e86c5e88f9a"},{"author":{"_account_id":11929,"name":"Michael Turek","email":"mjturek@linux.vnet.ibm.com","username":"mjturek"},"change_message_id":"25c1a0bc3371902d1394472c230583b6b729d145","unresolved":false,"context_lines":[{"line_number":218,"context_line":"        \u003c/permissions\u003e"},{"line_number":219,"context_line":"      \u003c/target\u003e"},{"line_number":220,"context_line":"    \u003c/volume\u003e\"\"\""},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"    vol_path \u003d os.path.join(tar_dir, vol_name)"},{"line_number":223,"context_line":"    stgvol_xml \u003d xmldesc % {\u0027name\u0027: vol_name,"},{"line_number":224,"context_line":"                            \u0027capacity\u0027: disk_gb,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f65232a_6ab295e8","line":221,"updated":"2020-10-23 17:52:59.000000000","message":"argument for allocation was added to the bash script in this commit [0]\n\nYou\u0027ll need to lookup what the allocation argument does for the virsh cli and how you can properly translate it to the python API.\n\n[0] https://github.com/openstack/ironic/commit/ce39115fa73e7d4f82b6c47a652c130a83cce3f6#diff-f4e8f68ea6047707b43791ca4545e9303690c1033b0947d257d6c8e62bf1c7e0","commit_id":"49eca452c9cc250af9d37a578cb41e86c5e88f9a"}],"test-requirements.txt":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"7aa08a55c739f685145d40805024b93a165cde11","unresolved":false,"context_lines":[{"line_number":21,"context_line":"Pygments\u003e\u003d2.2.0 # BSD"},{"line_number":22,"context_line":"bandit!\u003d1.6.0,\u003e\u003d1.1.0,\u003c2.0.0 # Apache-2.0"},{"line_number":23,"context_line":"pyroute2\u003e\u003d0.4.3 # Apache-2.0 (+ dual licensed GPL2)"},{"line_number":24,"context_line":"ryu\u003e\u003d3.30,!\u003d4.1,!\u003d4.2,!\u003d4.2.1,!\u003d4.4 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":2,"id":"3f65232a_4fc5473c","line":24,"updated":"2020-10-22 02:07:13.000000000","message":"You\u0027ll want to consult the \"requirements-check\" ci job. When it fails it is typically formatting, or a invalid/incompatible requirement is being requested.","commit_id":"6ef563505dbe85853967ae14fd56751ee4434c6e"}]}