)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"2824bfa9005e70c770410386dd20eac609a3cef0","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"The dhcp-ops of tenant ports is updated unnecessarily with multi-networks."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Description:"},{"line_number":10,"context_line":"When launching the instance with multi-networks, neutron will create sereval tenant ports and"},{"line_number":11,"context_line":"a provision port. the dhcp-ops of the provision port should be updated for building pxe environment,"},{"line_number":12,"context_line":"the dhcp-ops of the tenant port dhcp-ops will also be updated. actualy, there is no need to update"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f65232a_233a6297","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":12},"updated":"2020-10-28 03:10:56.000000000","message":"this can be deleted","commit_id":"3cf9e8a5a3af731a35bb63bc685737b3a5a75afd"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"2824bfa9005e70c770410386dd20eac609a3cef0","unresolved":false,"context_lines":[{"line_number":11,"context_line":"a provision port. the dhcp-ops of the provision port should be updated for building pxe environment,"},{"line_number":12,"context_line":"the dhcp-ops of the tenant port dhcp-ops will also be updated. actualy, there is no need to update"},{"line_number":13,"context_line":"the dhcp-ops of the tenant port, what we only to is to update the tenant port at the end of the deployment"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Story: #2008282"},{"line_number":16,"context_line":"Task: #41156"},{"line_number":17,"context_line":"Change-Id: I9b28f98e2dbffb3b79c1bedcbc6d9f8e7889186f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f65232a_43379eb1","line":14,"updated":"2020-10-28 03:10:56.000000000","message":"This should be cleaned up to follow [1], specifically \n\n* The first line should be limited to 50 characters and should not end with a period.\n* Subsequent lines should be wrapped at 72 characters. \n\n[1] https://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"3cf9e8a5a3af731a35bb63bc685737b3a5a75afd"}],"ironic/drivers/modules/network/common.py":[{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"2824bfa9005e70c770410386dd20eac609a3cef0","unresolved":false,"context_lines":[{"line_number":410,"context_line":"                    or p_obj.internal_info.get(\u0027provisioning_vif_port_id\u0027)"},{"line_number":411,"context_line":"                    or p_obj.internal_info.get(\u0027rescuing_vif_port_id\u0027)"},{"line_number":412,"context_line":"                    or p_obj.internal_info.get(\u0027inspection_vif_port_id\u0027)"},{"line_number":413,"context_line":"                    or self._get_vif_id_by_port_like_obj(p_obj) or None)"},{"line_number":414,"context_line":""},{"line_number":415,"context_line":"    def get_node_network_data(self, task):"},{"line_number":416,"context_line":"        \"\"\"Get network configuration data for node\u0027s ports/portgroups."}],"source_content_type":"text/x-python","patch_set":2,"id":"3f65232a_e802090b","line":413,"updated":"2020-10-28 03:10:56.000000000","message":"The repetition in these blocks is a bit much, how about something like:\n\n    if task.driver.storage.should_write_image(task):\n        vif_id \u003d None\n    else:\n        self._get_vif_id_by_port_like_obj(p_obj))\n    return (p_obj.internal_info.get(\u0027cleaning_vif_port_id\u0027)\n            or p_obj.internal_info.get(\u0027provisioning_vif_port_id\u0027)\n            or p_obj.internal_info.get(\u0027rescuing_vif_port_id\u0027)\n            or p_obj.internal_info.get(\u0027inspection_vif_port_id\u0027)\n            or vif_id or None)","commit_id":"3cf9e8a5a3af731a35bb63bc685737b3a5a75afd"}]}