)]}'
{"devstack/lib/ironic":[{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"c7a7aa5d082a6bfa9f0149595f66a98b908823e9","unresolved":false,"context_lines":[{"line_number":2860,"context_line":"        # NOTE(dtantsur): this is likely incorrect"},{"line_number":2861,"context_line":"        efi_grub_path\u003dEFI/BOOT/grub.cfg"},{"line_number":2862,"context_line":"    fi"},{"line_number":2863,"context_line":"    iniset $IRONIC_CONF_FILE DEFAULT grub_config_path $efi_grub_path"},{"line_number":2864,"context_line":"}"},{"line_number":2865,"context_line":""},{"line_number":2866,"context_line":"# build deploy kernel+ramdisk, then upload them to glance"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"1f621f24_c1e555aa","line":2863,"updated":"2020-11-05 00:31:40.000000000","message":"Rather than doing a distro detection you could always test for the presence of grub.cfg at a list of known paths, like this https://review.opendev.org/#/c/728330/2/extraconfig/pre_network/boot_param_tasks.yaml\n\nThis assumes that there will be exactly one path with a pre-existing grub.cfg, which I don\u0027t know if that holds in this case","commit_id":"ea33cb3aa383ef351fc444b4edc82a589313868b"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"9df1a7d9b0f69d1667cbab178818fc06fa96e65d","unresolved":false,"context_lines":[{"line_number":2860,"context_line":"        # NOTE(dtantsur): this is likely incorrect"},{"line_number":2861,"context_line":"        efi_grub_path\u003dEFI/BOOT/grub.cfg"},{"line_number":2862,"context_line":"    fi"},{"line_number":2863,"context_line":"    iniset $IRONIC_CONF_FILE DEFAULT grub_config_path $efi_grub_path"},{"line_number":2864,"context_line":"}"},{"line_number":2865,"context_line":""},{"line_number":2866,"context_line":"# build deploy kernel+ramdisk, then upload them to glance"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"1f621f24_b3d14ffe","line":2863,"in_reply_to":"1f621f24_2d04f87a","updated":"2020-11-10 18:17:30.000000000","message":"I really dislike how fragmented grub has become.","commit_id":"ea33cb3aa383ef351fc444b4edc82a589313868b"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a3401fb0bfd7fab75f40f3badd2276e53dc5dbc7","unresolved":false,"context_lines":[{"line_number":2860,"context_line":"        # NOTE(dtantsur): this is likely incorrect"},{"line_number":2861,"context_line":"        efi_grub_path\u003dEFI/BOOT/grub.cfg"},{"line_number":2862,"context_line":"    fi"},{"line_number":2863,"context_line":"    iniset $IRONIC_CONF_FILE DEFAULT grub_config_path $efi_grub_path"},{"line_number":2864,"context_line":"}"},{"line_number":2865,"context_line":""},{"line_number":2866,"context_line":"# build deploy kernel+ramdisk, then upload them to glance"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"1f621f24_2d04f87a","line":2863,"in_reply_to":"1f621f24_c1e555aa","updated":"2020-11-05 09:19:46.000000000","message":"I\u0027m not sure which paths you\u0027re talking about. The devstack machine may not have (correct) grub bits, the target ISO will be empty.","commit_id":"ea33cb3aa383ef351fc444b4edc82a589313868b"}]}