)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7394ebd66cad83358153debd482ee65978662598","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add support to manage certificates in iLO"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add support to manage certificates in iLO."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Idc86d7b78854e0618f62c7e4c1a88670dc4561b0"},{"line_number":12,"context_line":"Story: #2008297"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1f621f24_61bf4ad0","line":9,"updated":"2020-11-02 14:32:57.000000000","message":"Rather then repeating the same line twice, please specify which certificates you\u0027re talking about.\n\nAlso please add a release note.","commit_id":"bca385e57b45f5610a0f9cb27e79b9027998f6c4"}],"ironic/drivers/modules/ilo/boot.py":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"7d10178859882e84cbd67f85c8a3a4518fabba8d","unresolved":false,"context_lines":[{"line_number":53,"context_line":"                        \"required if rescue mode is being used and ironic is \""},{"line_number":54,"context_line":"                        \"managing booting the rescue ramdisk.\")"},{"line_number":55,"context_line":"}"},{"line_number":56,"context_line":"REQUIRED_PROPERTIES_UEFI_HTTPS_BOOT \u003d {"},{"line_number":57,"context_line":"    \u0027ilo_deploy_kernel\u0027: _(\"URL or Glance UUID of the deployment kernel. \""},{"line_number":58,"context_line":"                           \"Required.\"),"},{"line_number":59,"context_line":"    \u0027ilo_deploy_ramdisk\u0027: _(\"URL or Glance UUID of the ramdisk that is \""}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_88f8d0c4","line":56,"range":{"start_line":56,"start_character":0,"end_line":56,"end_character":35},"updated":"2020-11-02 07:08:04.000000000","message":"Need to add \u0027export_certificates\u0027 as optional property.","commit_id":"026b24a75c31a7104576804a2040f3a5b1d2d936"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"aadcb0fa669350227fef90bff06c68d98ca9665a","unresolved":false,"context_lines":[{"line_number":53,"context_line":"                        \"required if rescue mode is being used and ironic is \""},{"line_number":54,"context_line":"                        \"managing booting the rescue ramdisk.\")"},{"line_number":55,"context_line":"}"},{"line_number":56,"context_line":"REQUIRED_PROPERTIES_UEFI_HTTPS_BOOT \u003d {"},{"line_number":57,"context_line":"    \u0027ilo_deploy_kernel\u0027: _(\"URL or Glance UUID of the deployment kernel. \""},{"line_number":58,"context_line":"                           \"Required.\"),"},{"line_number":59,"context_line":"    \u0027ilo_deploy_ramdisk\u0027: _(\"URL or Glance UUID of the ramdisk that is \""}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_72aa4dd2","line":56,"range":{"start_line":56,"start_character":0,"end_line":56,"end_character":35},"in_reply_to":"1f621f24_88f8d0c4","updated":"2020-11-05 08:36:09.000000000","message":"As it\u0027s not being used any where except in \"export_certificates\" method of common.py better to leave it out.","commit_id":"026b24a75c31a7104576804a2040f3a5b1d2d936"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"b37e014a6f5c243a564202244d1e01654abfef79","unresolved":false,"context_lines":[{"line_number":1187,"context_line":"                  \"%(node)s\", {\u0027node\u0027: task.node.uuid})"},{"line_number":1188,"context_line":""},{"line_number":1189,"context_line":"        image_utils.cleanup_iso_image(task)"},{"line_number":1190,"context_line":"        ilo_common.clear_certificates(task)"},{"line_number":1191,"context_line":""},{"line_number":1192,"context_line":"    @METRICS.timer(\u0027IloUefiHttpsBoot.validate_rescue\u0027)"},{"line_number":1193,"context_line":"    def validate_rescue(self, task):"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f621f24_b0cc5889","line":1190,"range":{"start_line":1190,"start_character":8,"end_line":1190,"end_character":37},"updated":"2020-11-17 09:47:02.000000000","message":"Do not clear the certificates. Idea is not to reload the certificates for every deploy. Clearing of certificates can be done using separate clean/deploy step.","commit_id":"3980530109e73bad5d296fcbc47de3a4946665e1"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"d7ec5d6f1cb1c229ff49ffec6b7f14d3a812c405","unresolved":false,"context_lines":[{"line_number":1187,"context_line":"                  \"%(node)s\", {\u0027node\u0027: task.node.uuid})"},{"line_number":1188,"context_line":""},{"line_number":1189,"context_line":"        image_utils.cleanup_iso_image(task)"},{"line_number":1190,"context_line":"        ilo_common.clear_certificates(task)"},{"line_number":1191,"context_line":""},{"line_number":1192,"context_line":"    @METRICS.timer(\u0027IloUefiHttpsBoot.validate_rescue\u0027)"},{"line_number":1193,"context_line":"    def validate_rescue(self, task):"}],"source_content_type":"text/x-python","patch_set":4,"id":"800b6262_1516eccf","line":1190,"range":{"start_line":1190,"start_character":8,"end_line":1190,"end_character":37},"in_reply_to":"1f621f24_b0cc5889","updated":"2020-11-23 15:13:30.000000000","message":"Will remove in my next patch.","commit_id":"3980530109e73bad5d296fcbc47de3a4946665e1"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"2fd669d967871e4d2b4921f987f59bb314f92a26","unresolved":true,"context_lines":[{"line_number":66,"context_line":"                            \u0027agent that is used at node rescue time. \u0027"},{"line_number":67,"context_line":"                            \u0027The value is required for rescue mode.\u0027),"},{"line_number":68,"context_line":"}"},{"line_number":69,"context_line":"OPTIONAL_PROPERTIES \u003d {"},{"line_number":70,"context_line":"    \u0027ilo_bootloader\u0027: _(\"URL or Glance UUID  of the EFI system partition \""},{"line_number":71,"context_line":"                        \"image containing EFI boot loader. This image will \""},{"line_number":72,"context_line":"                        \"be used by ironic when building UEFI-bootable ISO \""}],"source_content_type":"text/x-python","patch_set":10,"id":"bc0a7e7a_80a9ae5b","line":69,"range":{"start_line":69,"start_character":0,"end_line":69,"end_character":19},"updated":"2020-12-15 04:59:39.000000000","message":"New parameter \u0027ilo_add_certificates\u0027 needs to be added here.","commit_id":"92cc97d09fdebaeb47c28b7c32f3f06a45c785de"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"5dae2851c2b635ec9b15cf6960ea0f8d28e48c80","unresolved":true,"context_lines":[{"line_number":66,"context_line":"                            \u0027agent that is used at node rescue time. \u0027"},{"line_number":67,"context_line":"                            \u0027The value is required for rescue mode.\u0027),"},{"line_number":68,"context_line":"}"},{"line_number":69,"context_line":"OPTIONAL_PROPERTIES \u003d {"},{"line_number":70,"context_line":"    \u0027ilo_bootloader\u0027: _(\"URL or Glance UUID  of the EFI system partition \""},{"line_number":71,"context_line":"                        \"image containing EFI boot loader. This image will \""},{"line_number":72,"context_line":"                        \"be used by ironic when building UEFI-bootable ISO \""}],"source_content_type":"text/x-python","patch_set":10,"id":"2aded966_3964ef07","line":69,"range":{"start_line":69,"start_character":0,"end_line":69,"end_character":19},"in_reply_to":"aa41240f_57209707","updated":"2021-01-06 05:26:47.000000000","message":"It is required when user wants to validate that driver_info is set appropriately.\nbaremetal node validate \u003cIRONIC NODE\u003e","commit_id":"92cc97d09fdebaeb47c28b7c32f3f06a45c785de"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"50113cb7334cb79f4b71e61bea77165ed43bbfad","unresolved":true,"context_lines":[{"line_number":66,"context_line":"                            \u0027agent that is used at node rescue time. \u0027"},{"line_number":67,"context_line":"                            \u0027The value is required for rescue mode.\u0027),"},{"line_number":68,"context_line":"}"},{"line_number":69,"context_line":"OPTIONAL_PROPERTIES \u003d {"},{"line_number":70,"context_line":"    \u0027ilo_bootloader\u0027: _(\"URL or Glance UUID  of the EFI system partition \""},{"line_number":71,"context_line":"                        \"image containing EFI boot loader. This image will \""},{"line_number":72,"context_line":"                        \"be used by ironic when building UEFI-bootable ISO \""}],"source_content_type":"text/x-python","patch_set":10,"id":"aa41240f_57209707","line":69,"range":{"start_line":69,"start_character":0,"end_line":69,"end_character":19},"in_reply_to":"bc0a7e7a_80a9ae5b","updated":"2020-12-15 07:19:31.000000000","message":"I have replied to a similar comment in the file common.py(patchset 9) by Julia. Since we don\u0027t use the variable for any other purpose(unlike the other cases where we need validation) listing it here will serve no purpose. WDYT?","commit_id":"92cc97d09fdebaeb47c28b7c32f3f06a45c785de"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"3a10030f207581d25a03bc08e7f008e4aaf9dbba","unresolved":true,"context_lines":[{"line_number":75,"context_line":"                        \"out of kernel and ramdisk. Required for UEFI \""},{"line_number":76,"context_line":"                        \"boot from partition images.\"),"},{"line_number":77,"context_line":"    \u0027ilo_add_certificates\u0027: _(\"Boolean value that indicates whether the \""},{"line_number":78,"context_line":"                              \"certificates require to be added to the \""},{"line_number":79,"context_line":"                              \"iLO.\")"},{"line_number":80,"context_line":"}"},{"line_number":81,"context_line":"COMMON_PROPERTIES \u003d REQUIRED_PROPERTIES"}],"source_content_type":"text/x-python","patch_set":13,"id":"f0f2a972_95ba2d2a","line":78,"range":{"start_line":78,"start_character":31,"end_line":78,"end_character":43},"updated":"2021-02-22 07:36:26.000000000","message":"s/ certificates / SSL certificates /","commit_id":"7d4c1214ffca486aca56aa6602a3bedb41f95baf"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a154612c6ced1e984298ed9c997f028473649333","unresolved":true,"context_lines":[{"line_number":75,"context_line":"                        \"out of kernel and ramdisk. Required for UEFI \""},{"line_number":76,"context_line":"                        \"boot from partition images.\"),"},{"line_number":77,"context_line":"    \u0027ilo_add_certificates\u0027: _(\"Boolean value that indicates whether the \""},{"line_number":78,"context_line":"                              \"certificates require to be added to the \""},{"line_number":79,"context_line":"                              \"iLO.\")"},{"line_number":80,"context_line":"}"},{"line_number":81,"context_line":"COMMON_PROPERTIES \u003d REQUIRED_PROPERTIES"}],"source_content_type":"text/x-python","patch_set":13,"id":"dd1acb20_e42dbd70","line":78,"range":{"start_line":78,"start_character":31,"end_line":78,"end_character":43},"in_reply_to":"f0f2a972_95ba2d2a","updated":"2021-03-01 16:08:32.000000000","message":"I\u0027d almost say x509 since that is what they are supporting SSL and TLS.","commit_id":"7d4c1214ffca486aca56aa6602a3bedb41f95baf"}],"ironic/drivers/modules/ilo/common.py":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"7d10178859882e84cbd67f85c8a3a4518fabba8d","unresolved":false,"context_lines":[{"line_number":939,"context_line":"    d_info \u003d node.driver_info"},{"line_number":940,"context_line":""},{"line_number":941,"context_line":"    export_certs \u003d strutils.bool_from_string("},{"line_number":942,"context_line":"        d_info.get(\u0027export_certificates\u0027, True))"},{"line_number":943,"context_line":""},{"line_number":944,"context_line":"    if not export_certs:"},{"line_number":945,"context_line":"        LOG.warning(\"Not exporting any certificates as the certificates\""}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_a8ff8ca8","line":942,"range":{"start_line":942,"start_character":20,"end_line":942,"end_character":39},"updated":"2020-11-02 07:08:04.000000000","message":"s/ export_certificates / ilo_export_certificates /","commit_id":"026b24a75c31a7104576804a2040f3a5b1d2d936"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"aadcb0fa669350227fef90bff06c68d98ca9665a","unresolved":false,"context_lines":[{"line_number":939,"context_line":"    d_info \u003d node.driver_info"},{"line_number":940,"context_line":""},{"line_number":941,"context_line":"    export_certs \u003d strutils.bool_from_string("},{"line_number":942,"context_line":"        d_info.get(\u0027export_certificates\u0027, True))"},{"line_number":943,"context_line":""},{"line_number":944,"context_line":"    if not export_certs:"},{"line_number":945,"context_line":"        LOG.warning(\"Not exporting any certificates as the certificates\""}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_97d1dbfe","line":942,"range":{"start_line":942,"start_character":20,"end_line":942,"end_character":39},"in_reply_to":"1f621f24_a8ff8ca8","updated":"2020-11-05 08:36:09.000000000","message":"Done","commit_id":"026b24a75c31a7104576804a2040f3a5b1d2d936"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"7d10178859882e84cbd67f85c8a3a4518fabba8d","unresolved":false,"context_lines":[{"line_number":942,"context_line":"        d_info.get(\u0027export_certificates\u0027, True))"},{"line_number":943,"context_line":""},{"line_number":944,"context_line":"    if not export_certs:"},{"line_number":945,"context_line":"        LOG.warning(\"Not exporting any certificates as the certificates\""},{"line_number":946,"context_line":"                    \"are assumed to have been exported.\")"},{"line_number":947,"context_line":"        return"},{"line_number":948,"context_line":""},{"line_number":949,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_084de071","line":946,"range":{"start_line":945,"start_character":7,"end_line":946,"end_character":57},"updated":"2020-11-02 07:08:04.000000000","message":"No need for a warning. Its optional param. You can make it debug.","commit_id":"026b24a75c31a7104576804a2040f3a5b1d2d936"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"aadcb0fa669350227fef90bff06c68d98ca9665a","unresolved":false,"context_lines":[{"line_number":942,"context_line":"        d_info.get(\u0027export_certificates\u0027, True))"},{"line_number":943,"context_line":""},{"line_number":944,"context_line":"    if not export_certs:"},{"line_number":945,"context_line":"        LOG.warning(\"Not exporting any certificates as the certificates\""},{"line_number":946,"context_line":"                    \"are assumed to have been exported.\")"},{"line_number":947,"context_line":"        return"},{"line_number":948,"context_line":""},{"line_number":949,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_d7db5318","line":946,"range":{"start_line":945,"start_character":7,"end_line":946,"end_character":57},"in_reply_to":"1f621f24_084de071","updated":"2020-11-05 08:36:09.000000000","message":"It can cause a potential failure during deployment. Worth to be info if not warning. WDYS?","commit_id":"026b24a75c31a7104576804a2040f3a5b1d2d936"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"7d10178859882e84cbd67f85c8a3a4518fabba8d","unresolved":false,"context_lines":[{"line_number":958,"context_line":"        except ValueError:"},{"line_number":959,"context_line":"            verify \u003d CONF.webserver_verify_ca"},{"line_number":960,"context_line":""},{"line_number":961,"context_line":"        if not isinstance(verify, bool) and os.path.exists(verify):"},{"line_number":962,"context_line":"            operation \u003d (_(\"Export certificates to %(node)s from path \""},{"line_number":963,"context_line":"                           \"%(cpath)s.\") % {\u0027cpath\u0027: verify,"},{"line_number":964,"context_line":"                                            \u0027node\u0027: node.uuid})"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_a8514cdb","line":961,"range":{"start_line":961,"start_character":34,"end_line":961,"end_character":38},"updated":"2020-11-02 07:08:04.000000000","message":"What would be the behavior if webserver_verify_ca is set to a boolean value? May be that it needs to be documented not to set bool value if certificate needs to be exported?","commit_id":"026b24a75c31a7104576804a2040f3a5b1d2d936"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"aadcb0fa669350227fef90bff06c68d98ca9665a","unresolved":false,"context_lines":[{"line_number":958,"context_line":"        except ValueError:"},{"line_number":959,"context_line":"            verify \u003d CONF.webserver_verify_ca"},{"line_number":960,"context_line":""},{"line_number":961,"context_line":"        if not isinstance(verify, bool) and os.path.exists(verify):"},{"line_number":962,"context_line":"            operation \u003d (_(\"Export certificates to %(node)s from path \""},{"line_number":963,"context_line":"                           \"%(cpath)s.\") % {\u0027cpath\u0027: verify,"},{"line_number":964,"context_line":"                                            \u0027node\u0027: node.uuid})"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_d74993d0","line":961,"range":{"start_line":961,"start_character":34,"end_line":961,"end_character":38},"in_reply_to":"1f621f24_a8514cdb","updated":"2020-11-05 08:36:09.000000000","message":"The function signature is changed in my new patchset and there are some changes worth to note. Please have a look and and let me know if u have any comments on that.","commit_id":"026b24a75c31a7104576804a2040f3a5b1d2d936"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"7d10178859882e84cbd67f85c8a3a4518fabba8d","unresolved":false,"context_lines":[{"line_number":976,"context_line":"                                          error\u003dilo_exception)"},{"line_number":977,"context_line":""},{"line_number":978,"context_line":""},{"line_number":979,"context_line":"def clear_certificates(task, cert_file_list\u003dNone):"},{"line_number":980,"context_line":"    \"\"\"Clears any certificates exported to the node."},{"line_number":981,"context_line":""},{"line_number":982,"context_line":"    Clears the certificates exported to the node as part of any Ironic"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_6870d473","line":979,"range":{"start_line":979,"start_character":1,"end_line":979,"end_character":50},"updated":"2020-11-02 07:08:04.000000000","message":"This is not getting used I suppose?","commit_id":"026b24a75c31a7104576804a2040f3a5b1d2d936"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"aadcb0fa669350227fef90bff06c68d98ca9665a","unresolved":false,"context_lines":[{"line_number":976,"context_line":"                                          error\u003dilo_exception)"},{"line_number":977,"context_line":""},{"line_number":978,"context_line":""},{"line_number":979,"context_line":"def clear_certificates(task, cert_file_list\u003dNone):"},{"line_number":980,"context_line":"    \"\"\"Clears any certificates exported to the node."},{"line_number":981,"context_line":""},{"line_number":982,"context_line":"    Clears the certificates exported to the node as part of any Ironic"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_3739e740","line":979,"range":{"start_line":979,"start_character":1,"end_line":979,"end_character":50},"in_reply_to":"1f621f24_6870d473","updated":"2020-11-05 08:36:09.000000000","message":"Yes. But as we start to think more, i feel this is required during cleanup of instance after provision. I am waiting on some clarifications from firmware team and will update based on the outcome.","commit_id":"026b24a75c31a7104576804a2040f3a5b1d2d936"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"b37e014a6f5c243a564202244d1e01654abfef79","unresolved":false,"context_lines":[{"line_number":973,"context_line":"        d_info.get(\u0027ilo_export_certificates\u0027, True))"},{"line_number":974,"context_line":""},{"line_number":975,"context_line":"    if not export_certs:"},{"line_number":976,"context_line":"        LOG.warning(\"Not exporting any certificates as the certificates\""},{"line_number":977,"context_line":"                    \"are assumed to have been exported.\")"},{"line_number":978,"context_line":"        return"},{"line_number":979,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1f621f24_3094c836","line":976,"range":{"start_line":976,"start_character":12,"end_line":976,"end_character":19},"updated":"2020-11-17 09:47:02.000000000","message":"This should be \u0027info\u0027 level as it is an optional driver parameter.","commit_id":"3980530109e73bad5d296fcbc47de3a4946665e1"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"d7ec5d6f1cb1c229ff49ffec6b7f14d3a812c405","unresolved":false,"context_lines":[{"line_number":973,"context_line":"        d_info.get(\u0027ilo_export_certificates\u0027, True))"},{"line_number":974,"context_line":""},{"line_number":975,"context_line":"    if not export_certs:"},{"line_number":976,"context_line":"        LOG.warning(\"Not exporting any certificates as the certificates\""},{"line_number":977,"context_line":"                    \"are assumed to have been exported.\")"},{"line_number":978,"context_line":"        return"},{"line_number":979,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"142ca77f_69873954","line":976,"range":{"start_line":976,"start_character":12,"end_line":976,"end_character":19},"in_reply_to":"1f621f24_3094c836","updated":"2020-11-23 15:13:30.000000000","message":"Will fix it in my next patch.","commit_id":"3980530109e73bad5d296fcbc47de3a4946665e1"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"dca58a0f2846342f9c82e62591af5ce2892f36c6","unresolved":true,"context_lines":[{"line_number":545,"context_line":"    except ilo_error.IloCommandNotSupportedError:"},{"line_number":546,"context_line":"        p_boot_mode \u003d DEFAULT_BOOT_MODE"},{"line_number":547,"context_line":""},{"line_number":548,"context_line":"    if p_boot_mode:"},{"line_number":549,"context_line":"        if BOOT_MODE_ILO_TO_GENERIC[p_boot_mode.lower()] \u003d\u003d boot_mode:"},{"line_number":550,"context_line":"            LOG.info(\"Node %(uuid)s pending boot mode is %(boot_mode)s.\","},{"line_number":551,"context_line":"                     {\u0027uuid\u0027: node.uuid, \u0027boot_mode\u0027: boot_mode})"}],"source_content_type":"text/x-python","patch_set":6,"id":"e749fb68_d4c8cf6e","line":548,"updated":"2020-11-25 20:51:51.000000000","message":"if p_boot_mode is empty should it just be set to DEFAULT_BOOT_MODE?","commit_id":"b5c345269348937f9d27ca54fa9224fd0d911ddb"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"fe6daeb4c25255856d37b612b4b8010479c2e8fc","unresolved":false,"context_lines":[{"line_number":545,"context_line":"    except ilo_error.IloCommandNotSupportedError:"},{"line_number":546,"context_line":"        p_boot_mode \u003d DEFAULT_BOOT_MODE"},{"line_number":547,"context_line":""},{"line_number":548,"context_line":"    if p_boot_mode:"},{"line_number":549,"context_line":"        if BOOT_MODE_ILO_TO_GENERIC[p_boot_mode.lower()] \u003d\u003d boot_mode:"},{"line_number":550,"context_line":"            LOG.info(\"Node %(uuid)s pending boot mode is %(boot_mode)s.\","},{"line_number":551,"context_line":"                     {\u0027uuid\u0027: node.uuid, \u0027boot_mode\u0027: boot_mode})"}],"source_content_type":"text/x-python","patch_set":6,"id":"2af5b37d_9bd75045","line":548,"in_reply_to":"e749fb68_d4c8cf6e","updated":"2020-11-26 13:33:34.000000000","message":"The problem with previous code is when the pending boot mode is None (which is possible in some scenarios) ironic throws an exception here which we want to avoid. If pending boot mode is None we ignore it and try to set the required boot mode as pending boot mode.","commit_id":"b5c345269348937f9d27ca54fa9224fd0d911ddb"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"dca58a0f2846342f9c82e62591af5ce2892f36c6","unresolved":true,"context_lines":[{"line_number":944,"context_line":"        except ValueError:"},{"line_number":945,"context_line":"            verify \u003d CONF.webserver_verify_ca"},{"line_number":946,"context_line":""},{"line_number":947,"context_line":"        if isinstance(verify, bool) or not os.path.exists(verify):"},{"line_number":948,"context_line":"            return []"},{"line_number":949,"context_line":""},{"line_number":950,"context_line":"        cfl \u003d [verify]"}],"source_content_type":"text/x-python","patch_set":6,"id":"3ed97a17_3b0d7ca9","line":947,"range":{"start_line":947,"start_character":43,"end_line":947,"end_character":65},"updated":"2020-11-25 20:51:51.000000000","message":"If the configured file path doesn\u0027t exist this should at least log an error, and maybe even raise an exception","commit_id":"b5c345269348937f9d27ca54fa9224fd0d911ddb"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"fe6daeb4c25255856d37b612b4b8010479c2e8fc","unresolved":false,"context_lines":[{"line_number":944,"context_line":"        except ValueError:"},{"line_number":945,"context_line":"            verify \u003d CONF.webserver_verify_ca"},{"line_number":946,"context_line":""},{"line_number":947,"context_line":"        if isinstance(verify, bool) or not os.path.exists(verify):"},{"line_number":948,"context_line":"            return []"},{"line_number":949,"context_line":""},{"line_number":950,"context_line":"        cfl \u003d [verify]"}],"source_content_type":"text/x-python","patch_set":6,"id":"a6ef0694_fc437512","line":947,"range":{"start_line":947,"start_character":43,"end_line":947,"end_character":65},"in_reply_to":"3ed97a17_3b0d7ca9","updated":"2020-11-26 13:33:34.000000000","message":"This function doesn\u0027t really care abot the file existance. I will log a warning or error message here but still return an empty list. WDYT?","commit_id":"b5c345269348937f9d27ca54fa9224fd0d911ddb"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"dca58a0f2846342f9c82e62591af5ce2892f36c6","unresolved":true,"context_lines":[{"line_number":949,"context_line":""},{"line_number":950,"context_line":"        cfl \u003d [verify]"},{"line_number":951,"context_line":""},{"line_number":952,"context_line":"    if not isinstance(cfl, list):"},{"line_number":953,"context_line":"        return []"},{"line_number":954,"context_line":""},{"line_number":955,"context_line":"    return cfl"},{"line_number":956,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"673f208b_8a2c5fdf","line":953,"range":{"start_line":952,"start_character":0,"end_line":953,"end_character":17},"updated":"2020-11-25 20:51:51.000000000","message":"I don\u0027t think this is needed, you could always raise InvalidParameterValue at the start of this function if cert_file_list is not a list or None","commit_id":"b5c345269348937f9d27ca54fa9224fd0d911ddb"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"fe6daeb4c25255856d37b612b4b8010479c2e8fc","unresolved":false,"context_lines":[{"line_number":949,"context_line":""},{"line_number":950,"context_line":"        cfl \u003d [verify]"},{"line_number":951,"context_line":""},{"line_number":952,"context_line":"    if not isinstance(cfl, list):"},{"line_number":953,"context_line":"        return []"},{"line_number":954,"context_line":""},{"line_number":955,"context_line":"    return cfl"},{"line_number":956,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3a100faa_8cfa17de","line":953,"range":{"start_line":952,"start_character":0,"end_line":953,"end_character":17},"in_reply_to":"673f208b_8a2c5fdf","updated":"2020-11-26 13:33:34.000000000","message":"Agree. I will throw InvalidParameterValue exception.","commit_id":"b5c345269348937f9d27ca54fa9224fd0d911ddb"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"dca58a0f2846342f9c82e62591af5ce2892f36c6","unresolved":true,"context_lines":[{"line_number":955,"context_line":"    return cfl"},{"line_number":956,"context_line":""},{"line_number":957,"context_line":""},{"line_number":958,"context_line":"def export_certificates(task, cert_file_list\u003d[]):"},{"line_number":959,"context_line":"    \"\"\"Exports certificates to the node."},{"line_number":960,"context_line":""},{"line_number":961,"context_line":"    Exports certificates to the node based on the driver info"}],"source_content_type":"text/x-python","patch_set":6,"id":"5026d358_2b486bbf","line":958,"range":{"start_line":958,"start_character":45,"end_line":958,"end_character":47},"updated":"2020-11-25 20:51:51.000000000","message":"function arguments should not be mutable types like lists. Better to make None the default, and if you need to assume a list in the function, initialize cert_file_list with [] below","commit_id":"b5c345269348937f9d27ca54fa9224fd0d911ddb"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"fe6daeb4c25255856d37b612b4b8010479c2e8fc","unresolved":false,"context_lines":[{"line_number":955,"context_line":"    return cfl"},{"line_number":956,"context_line":""},{"line_number":957,"context_line":""},{"line_number":958,"context_line":"def export_certificates(task, cert_file_list\u003d[]):"},{"line_number":959,"context_line":"    \"\"\"Exports certificates to the node."},{"line_number":960,"context_line":""},{"line_number":961,"context_line":"    Exports certificates to the node based on the driver info"}],"source_content_type":"text/x-python","patch_set":6,"id":"e6faab00_6ec194f9","line":958,"range":{"start_line":958,"start_character":45,"end_line":958,"end_character":47},"in_reply_to":"5026d358_2b486bbf","updated":"2020-11-26 13:33:34.000000000","message":"None or Tuple? Will make it None and accordingly change the function.","commit_id":"b5c345269348937f9d27ca54fa9224fd0d911ddb"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"0f95c0f24d1c7c03d9e8868c471211d5fcf1e3e1","unresolved":true,"context_lines":[{"line_number":67,"context_line":"                       \"verifying the SSL certificate. If it\\\u0027s a path the \""},{"line_number":68,"context_line":"                       \"driver will use the specified certificate or one of \""},{"line_number":69,"context_line":"                       \"the certificates in the directory. Defaults to True. \""},{"line_number":70,"context_line":"                       \"Optional\")"},{"line_number":71,"context_line":"}"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"SNMP_PROPERTIES \u003d {"}],"source_content_type":"text/x-python","patch_set":9,"id":"c16b2746_1e3aff87","line":70,"updated":"2020-12-07 14:20:42.000000000","message":"Shouldn\u0027t the value be added to the list here?","commit_id":"4312c5295b1e08d49daf141ef802a36c4f51d2fc"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"ebe51d07acd28fe43f35c25f348f0ed8456606ac","unresolved":true,"context_lines":[{"line_number":67,"context_line":"                       \"verifying the SSL certificate. If it\\\u0027s a path the \""},{"line_number":68,"context_line":"                       \"driver will use the specified certificate or one of \""},{"line_number":69,"context_line":"                       \"the certificates in the directory. Defaults to True. \""},{"line_number":70,"context_line":"                       \"Optional\")"},{"line_number":71,"context_line":"}"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"SNMP_PROPERTIES \u003d {"}],"source_content_type":"text/x-python","patch_set":9,"id":"9e1fe95c_7ab568b0","line":70,"in_reply_to":"c16b2746_1e3aff87","updated":"2020-12-09 10:29:49.000000000","message":"Actually i didn\u0027t find any use of adding it here. For other variables, it was needed as we were doing parameter validation. I\u0027 m fine to add if you think it is required.","commit_id":"4312c5295b1e08d49daf141ef802a36c4f51d2fc"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"2fd669d967871e4d2b4921f987f59bb314f92a26","unresolved":true,"context_lines":[{"line_number":929,"context_line":"    \"\"\"Get the list of certificates to use."},{"line_number":930,"context_line":""},{"line_number":931,"context_line":"    :param cert_file_list: certificates file list."},{"line_number":932,"context_line":"    :returns: cert_file_list if it\u0027s not empty. If empty or None,"},{"line_number":933,"context_line":"        returns the list of path configured for \"webserver_verify_ca\""},{"line_number":934,"context_line":"        configuration option if the path exists. If the path does not"},{"line_number":935,"context_line":"        exist, returns empty list."}],"source_content_type":"text/x-python","patch_set":10,"id":"fa77b90c_2f8eb1a3","line":932,"range":{"start_line":932,"start_character":5,"end_line":932,"end_character":12},"updated":"2020-12-15 04:59:39.000000000","message":"Add \u0027raises\u0027 to docstring. It can raise InvalidParameterValue","commit_id":"92cc97d09fdebaeb47c28b7c32f3f06a45c785de"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"50113cb7334cb79f4b71e61bea77165ed43bbfad","unresolved":false,"context_lines":[{"line_number":929,"context_line":"    \"\"\"Get the list of certificates to use."},{"line_number":930,"context_line":""},{"line_number":931,"context_line":"    :param cert_file_list: certificates file list."},{"line_number":932,"context_line":"    :returns: cert_file_list if it\u0027s not empty. If empty or None,"},{"line_number":933,"context_line":"        returns the list of path configured for \"webserver_verify_ca\""},{"line_number":934,"context_line":"        configuration option if the path exists. If the path does not"},{"line_number":935,"context_line":"        exist, returns empty list."}],"source_content_type":"text/x-python","patch_set":10,"id":"e782427f_d6fe1616","line":932,"range":{"start_line":932,"start_character":5,"end_line":932,"end_character":12},"in_reply_to":"fa77b90c_2f8eb1a3","updated":"2020-12-15 07:19:31.000000000","message":"Done","commit_id":"92cc97d09fdebaeb47c28b7c32f3f06a45c785de"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"2fd669d967871e4d2b4921f987f59bb314f92a26","unresolved":true,"context_lines":[{"line_number":985,"context_line":"        d_info.get(\u0027ilo_add_certificates\u0027, True))"},{"line_number":986,"context_line":""},{"line_number":987,"context_line":"    if not export_certs:"},{"line_number":988,"context_line":"        LOG.info(\"Not exporting any certificates as the certificates\""},{"line_number":989,"context_line":"                 \"are assumed to have been already exported.\")"},{"line_number":990,"context_line":"        return"},{"line_number":991,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"5c928bd1_92604cb5","line":988,"range":{"start_line":988,"start_character":12,"end_line":988,"end_character":16},"updated":"2020-12-15 04:59:39.000000000","message":"Add node uuid to the message. This can be a debug message?","commit_id":"92cc97d09fdebaeb47c28b7c32f3f06a45c785de"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"50113cb7334cb79f4b71e61bea77165ed43bbfad","unresolved":false,"context_lines":[{"line_number":985,"context_line":"        d_info.get(\u0027ilo_add_certificates\u0027, True))"},{"line_number":986,"context_line":""},{"line_number":987,"context_line":"    if not export_certs:"},{"line_number":988,"context_line":"        LOG.info(\"Not exporting any certificates as the certificates\""},{"line_number":989,"context_line":"                 \"are assumed to have been already exported.\")"},{"line_number":990,"context_line":"        return"},{"line_number":991,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"03324a3c_b0b251c4","line":988,"range":{"start_line":988,"start_character":12,"end_line":988,"end_character":16},"in_reply_to":"5c928bd1_92604cb5","updated":"2020-12-15 07:19:31.000000000","message":"Done. I think better to keep info to let the user know in any case.","commit_id":"92cc97d09fdebaeb47c28b7c32f3f06a45c785de"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"2fd669d967871e4d2b4921f987f59bb314f92a26","unresolved":true,"context_lines":[{"line_number":985,"context_line":"        d_info.get(\u0027ilo_add_certificates\u0027, True))"},{"line_number":986,"context_line":""},{"line_number":987,"context_line":"    if not export_certs:"},{"line_number":988,"context_line":"        LOG.info(\"Not exporting any certificates as the certificates\""},{"line_number":989,"context_line":"                 \"are assumed to have been already exported.\")"},{"line_number":990,"context_line":"        return"},{"line_number":991,"context_line":""},{"line_number":992,"context_line":"    cfl \u003d _get_certificate_file_list(cert_file_list)"}],"source_content_type":"text/x-python","patch_set":10,"id":"23dd1fda_91dc0e26","line":989,"range":{"start_line":988,"start_character":49,"end_line":989,"end_character":60},"updated":"2020-12-15 04:59:39.000000000","message":"s/ \"Not exporting any certificates as the certificates are assumed to have been already exported.\" / \"Adding of certificates to ilo is not requested, assuming required certificates are available at ilo.\" /","commit_id":"92cc97d09fdebaeb47c28b7c32f3f06a45c785de"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"50113cb7334cb79f4b71e61bea77165ed43bbfad","unresolved":false,"context_lines":[{"line_number":985,"context_line":"        d_info.get(\u0027ilo_add_certificates\u0027, True))"},{"line_number":986,"context_line":""},{"line_number":987,"context_line":"    if not export_certs:"},{"line_number":988,"context_line":"        LOG.info(\"Not exporting any certificates as the certificates\""},{"line_number":989,"context_line":"                 \"are assumed to have been already exported.\")"},{"line_number":990,"context_line":"        return"},{"line_number":991,"context_line":""},{"line_number":992,"context_line":"    cfl \u003d _get_certificate_file_list(cert_file_list)"}],"source_content_type":"text/x-python","patch_set":10,"id":"65825880_8d35c8c3","line":989,"range":{"start_line":988,"start_character":49,"end_line":989,"end_character":60},"in_reply_to":"23dd1fda_91dc0e26","updated":"2020-12-15 07:19:31.000000000","message":"Will change it with little modification as below.\n\"Adding of certificates to the ilo is not requested. Assuming required certificates are available on the ilo.\"","commit_id":"92cc97d09fdebaeb47c28b7c32f3f06a45c785de"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"2fd669d967871e4d2b4921f987f59bb314f92a26","unresolved":true,"context_lines":[{"line_number":992,"context_line":"    cfl \u003d _get_certificate_file_list(cert_file_list)"},{"line_number":993,"context_line":""},{"line_number":994,"context_line":"    if not cfl:"},{"line_number":995,"context_line":"        LOG.info(\"Not exporting any certificates as no certificates\""},{"line_number":996,"context_line":"                 \"are provided\")"},{"line_number":997,"context_line":"        return"},{"line_number":998,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"59dbf9d4_3d2d3a41","line":995,"range":{"start_line":995,"start_character":12,"end_line":995,"end_character":16},"updated":"2020-12-15 04:59:39.000000000","message":"Add node uuid to the message. This can be a debug message.","commit_id":"92cc97d09fdebaeb47c28b7c32f3f06a45c785de"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"2fd669d967871e4d2b4921f987f59bb314f92a26","unresolved":true,"context_lines":[{"line_number":992,"context_line":"    cfl \u003d _get_certificate_file_list(cert_file_list)"},{"line_number":993,"context_line":""},{"line_number":994,"context_line":"    if not cfl:"},{"line_number":995,"context_line":"        LOG.info(\"Not exporting any certificates as no certificates\""},{"line_number":996,"context_line":"                 \"are provided\")"},{"line_number":997,"context_line":"        return"},{"line_number":998,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"35545ed7_09705a67","line":995,"range":{"start_line":995,"start_character":36,"end_line":995,"end_character":48},"updated":"2020-12-15 04:59:39.000000000","message":"s/ certificates / certificates to ilo /","commit_id":"92cc97d09fdebaeb47c28b7c32f3f06a45c785de"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"2fd669d967871e4d2b4921f987f59bb314f92a26","unresolved":true,"context_lines":[{"line_number":992,"context_line":"    cfl \u003d _get_certificate_file_list(cert_file_list)"},{"line_number":993,"context_line":""},{"line_number":994,"context_line":"    if not cfl:"},{"line_number":995,"context_line":"        LOG.info(\"Not exporting any certificates as no certificates\""},{"line_number":996,"context_line":"                 \"are provided\")"},{"line_number":997,"context_line":"        return"},{"line_number":998,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"0bc2d8d3_725bb197","line":995,"range":{"start_line":995,"start_character":22,"end_line":995,"end_character":31},"updated":"2020-12-15 04:59:39.000000000","message":"s/ exporting / adding /","commit_id":"92cc97d09fdebaeb47c28b7c32f3f06a45c785de"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"50113cb7334cb79f4b71e61bea77165ed43bbfad","unresolved":false,"context_lines":[{"line_number":992,"context_line":"    cfl \u003d _get_certificate_file_list(cert_file_list)"},{"line_number":993,"context_line":""},{"line_number":994,"context_line":"    if not cfl:"},{"line_number":995,"context_line":"        LOG.info(\"Not exporting any certificates as no certificates\""},{"line_number":996,"context_line":"                 \"are provided\")"},{"line_number":997,"context_line":"        return"},{"line_number":998,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"3181ae29_4f32858c","line":995,"range":{"start_line":995,"start_character":22,"end_line":995,"end_character":31},"in_reply_to":"0bc2d8d3_725bb197","updated":"2020-12-15 07:19:31.000000000","message":"Done","commit_id":"92cc97d09fdebaeb47c28b7c32f3f06a45c785de"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"50113cb7334cb79f4b71e61bea77165ed43bbfad","unresolved":false,"context_lines":[{"line_number":992,"context_line":"    cfl \u003d _get_certificate_file_list(cert_file_list)"},{"line_number":993,"context_line":""},{"line_number":994,"context_line":"    if not cfl:"},{"line_number":995,"context_line":"        LOG.info(\"Not exporting any certificates as no certificates\""},{"line_number":996,"context_line":"                 \"are provided\")"},{"line_number":997,"context_line":"        return"},{"line_number":998,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"4a4308ce_bd059d26","line":995,"range":{"start_line":995,"start_character":36,"end_line":995,"end_character":48},"in_reply_to":"35545ed7_09705a67","updated":"2020-12-15 07:19:31.000000000","message":"Done","commit_id":"92cc97d09fdebaeb47c28b7c32f3f06a45c785de"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"50113cb7334cb79f4b71e61bea77165ed43bbfad","unresolved":false,"context_lines":[{"line_number":992,"context_line":"    cfl \u003d _get_certificate_file_list(cert_file_list)"},{"line_number":993,"context_line":""},{"line_number":994,"context_line":"    if not cfl:"},{"line_number":995,"context_line":"        LOG.info(\"Not exporting any certificates as no certificates\""},{"line_number":996,"context_line":"                 \"are provided\")"},{"line_number":997,"context_line":"        return"},{"line_number":998,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"4a70eff7_aa90c5be","line":995,"range":{"start_line":995,"start_character":12,"end_line":995,"end_character":16},"in_reply_to":"59dbf9d4_3d2d3a41","updated":"2020-12-15 07:19:31.000000000","message":"Done","commit_id":"92cc97d09fdebaeb47c28b7c32f3f06a45c785de"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"2fd669d967871e4d2b4921f987f59bb314f92a26","unresolved":true,"context_lines":[{"line_number":1001,"context_line":"        # eventually being used for TLS verification by the node before"},{"line_number":1002,"context_line":"        # downloading the deploy/instance images during HTTPS boot from"},{"line_number":1003,"context_line":"        # URL."},{"line_number":1004,"context_line":"        operation \u003d (_(\"Export certificates to %(node)s from paths \""},{"line_number":1005,"context_line":"                       \"%(cpath)s.\") % {\u0027cpath\u0027: cfl, \u0027node\u0027: node.uuid})"},{"line_number":1006,"context_line":""},{"line_number":1007,"context_line":"        ilo_object.add_tls_certificate(cfl)"}],"source_content_type":"text/x-python","patch_set":10,"id":"4b0e7672_443ddac0","line":1004,"range":{"start_line":1004,"start_character":24,"end_line":1004,"end_character":30},"updated":"2020-12-15 04:59:39.000000000","message":"s/ Export / Add /","commit_id":"92cc97d09fdebaeb47c28b7c32f3f06a45c785de"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"50113cb7334cb79f4b71e61bea77165ed43bbfad","unresolved":false,"context_lines":[{"line_number":1001,"context_line":"        # eventually being used for TLS verification by the node before"},{"line_number":1002,"context_line":"        # downloading the deploy/instance images during HTTPS boot from"},{"line_number":1003,"context_line":"        # URL."},{"line_number":1004,"context_line":"        operation \u003d (_(\"Export certificates to %(node)s from paths \""},{"line_number":1005,"context_line":"                       \"%(cpath)s.\") % {\u0027cpath\u0027: cfl, \u0027node\u0027: node.uuid})"},{"line_number":1006,"context_line":""},{"line_number":1007,"context_line":"        ilo_object.add_tls_certificate(cfl)"}],"source_content_type":"text/x-python","patch_set":10,"id":"ac0de4de_d5b6b327","line":1004,"range":{"start_line":1004,"start_character":24,"end_line":1004,"end_character":30},"in_reply_to":"4b0e7672_443ddac0","updated":"2020-12-15 07:19:31.000000000","message":"Done","commit_id":"92cc97d09fdebaeb47c28b7c32f3f06a45c785de"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"2fd669d967871e4d2b4921f987f59bb314f92a26","unresolved":true,"context_lines":[{"line_number":1006,"context_line":""},{"line_number":1007,"context_line":"        ilo_object.add_tls_certificate(cfl)"},{"line_number":1008,"context_line":""},{"line_number":1009,"context_line":"        LOG.info(\"Successfully exported certificates to %(node)s from \""},{"line_number":1010,"context_line":"                 \"paths %(cpath)s.\", {\u0027cpath\u0027: cfl, \u0027node\u0027: node.uuid})"},{"line_number":1011,"context_line":"    except ilo_error.IloCommandNotSupportedInBiosError as ilo_exception:"},{"line_number":1012,"context_line":"        raise exception.IloOperationNotSupported(operation\u003doperation,"}],"source_content_type":"text/x-python","patch_set":10,"id":"55328aff_5f59c56f","line":1009,"range":{"start_line":1009,"start_character":31,"end_line":1009,"end_character":39},"updated":"2020-12-15 04:59:39.000000000","message":"s/ exported / added /","commit_id":"92cc97d09fdebaeb47c28b7c32f3f06a45c785de"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"50113cb7334cb79f4b71e61bea77165ed43bbfad","unresolved":false,"context_lines":[{"line_number":1006,"context_line":""},{"line_number":1007,"context_line":"        ilo_object.add_tls_certificate(cfl)"},{"line_number":1008,"context_line":""},{"line_number":1009,"context_line":"        LOG.info(\"Successfully exported certificates to %(node)s from \""},{"line_number":1010,"context_line":"                 \"paths %(cpath)s.\", {\u0027cpath\u0027: cfl, \u0027node\u0027: node.uuid})"},{"line_number":1011,"context_line":"    except ilo_error.IloCommandNotSupportedInBiosError as ilo_exception:"},{"line_number":1012,"context_line":"        raise exception.IloOperationNotSupported(operation\u003doperation,"}],"source_content_type":"text/x-python","patch_set":10,"id":"5922f317_c05072e4","line":1009,"range":{"start_line":1009,"start_character":31,"end_line":1009,"end_character":39},"in_reply_to":"55328aff_5f59c56f","updated":"2020-12-15 07:19:31.000000000","message":"Done","commit_id":"92cc97d09fdebaeb47c28b7c32f3f06a45c785de"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"2fd669d967871e4d2b4921f987f59bb314f92a26","unresolved":true,"context_lines":[{"line_number":1017,"context_line":""},{"line_number":1018,"context_line":""},{"line_number":1019,"context_line":"def clear_certificates(task, cert_file_list\u003dNone):"},{"line_number":1020,"context_line":"    \"\"\"Clears any certificates exported to the node."},{"line_number":1021,"context_line":""},{"line_number":1022,"context_line":"    Clears the certificates exported to the node as part of any Ironic"},{"line_number":1023,"context_line":"    operation"}],"source_content_type":"text/x-python","patch_set":10,"id":"b00a6738_dd9429dc","line":1020,"range":{"start_line":1020,"start_character":31,"end_line":1020,"end_character":39},"updated":"2020-12-15 04:59:39.000000000","message":"s/ exported / added /","commit_id":"92cc97d09fdebaeb47c28b7c32f3f06a45c785de"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"50113cb7334cb79f4b71e61bea77165ed43bbfad","unresolved":false,"context_lines":[{"line_number":1017,"context_line":""},{"line_number":1018,"context_line":""},{"line_number":1019,"context_line":"def clear_certificates(task, cert_file_list\u003dNone):"},{"line_number":1020,"context_line":"    \"\"\"Clears any certificates exported to the node."},{"line_number":1021,"context_line":""},{"line_number":1022,"context_line":"    Clears the certificates exported to the node as part of any Ironic"},{"line_number":1023,"context_line":"    operation"}],"source_content_type":"text/x-python","patch_set":10,"id":"efd2f0ba_f795f3e5","line":1020,"range":{"start_line":1020,"start_character":31,"end_line":1020,"end_character":39},"in_reply_to":"b00a6738_dd9429dc","updated":"2020-12-15 07:19:31.000000000","message":"Done","commit_id":"92cc97d09fdebaeb47c28b7c32f3f06a45c785de"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"2fd669d967871e4d2b4921f987f59bb314f92a26","unresolved":true,"context_lines":[{"line_number":1019,"context_line":"def clear_certificates(task, cert_file_list\u003dNone):"},{"line_number":1020,"context_line":"    \"\"\"Clears any certificates exported to the node."},{"line_number":1021,"context_line":""},{"line_number":1022,"context_line":"    Clears the certificates exported to the node as part of any Ironic"},{"line_number":1023,"context_line":"    operation"},{"line_number":1024,"context_line":""},{"line_number":1025,"context_line":"    :param task: a TaskManager instance containing the node to act on."}],"source_content_type":"text/x-python","patch_set":10,"id":"09527fe6_d60cbcd2","line":1022,"range":{"start_line":1022,"start_character":28,"end_line":1022,"end_character":36},"updated":"2020-12-15 04:59:39.000000000","message":"ditto","commit_id":"92cc97d09fdebaeb47c28b7c32f3f06a45c785de"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"50113cb7334cb79f4b71e61bea77165ed43bbfad","unresolved":false,"context_lines":[{"line_number":1019,"context_line":"def clear_certificates(task, cert_file_list\u003dNone):"},{"line_number":1020,"context_line":"    \"\"\"Clears any certificates exported to the node."},{"line_number":1021,"context_line":""},{"line_number":1022,"context_line":"    Clears the certificates exported to the node as part of any Ironic"},{"line_number":1023,"context_line":"    operation"},{"line_number":1024,"context_line":""},{"line_number":1025,"context_line":"    :param task: a TaskManager instance containing the node to act on."}],"source_content_type":"text/x-python","patch_set":10,"id":"53b7d466_57511c2e","line":1022,"range":{"start_line":1022,"start_character":28,"end_line":1022,"end_character":36},"in_reply_to":"09527fe6_d60cbcd2","updated":"2020-12-15 07:19:31.000000000","message":"Done","commit_id":"92cc97d09fdebaeb47c28b7c32f3f06a45c785de"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"5dae2851c2b635ec9b15cf6960ea0f8d28e48c80","unresolved":true,"context_lines":[{"line_number":964,"context_line":"    return cfl"},{"line_number":965,"context_line":""},{"line_number":966,"context_line":""},{"line_number":967,"context_line":"def export_certificates(task, cert_file_list\u003dNone):"},{"line_number":968,"context_line":"    \"\"\"Exports certificates to the node."},{"line_number":969,"context_line":""},{"line_number":970,"context_line":"    Exports certificates to the node based on the driver info"}],"source_content_type":"text/x-python","patch_set":11,"id":"6c2251f2_f14c9aee","line":967,"range":{"start_line":967,"start_character":4,"end_line":967,"end_character":11},"updated":"2021-01-06 05:26:47.000000000","message":"s/ export_ / add_ /","commit_id":"903d19d0cd6a32e94320e57d59775bfc7819c1da"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"45e244246cf8305f784c2715550d27b24d0b52d8","unresolved":false,"context_lines":[{"line_number":964,"context_line":"    return cfl"},{"line_number":965,"context_line":""},{"line_number":966,"context_line":""},{"line_number":967,"context_line":"def export_certificates(task, cert_file_list\u003dNone):"},{"line_number":968,"context_line":"    \"\"\"Exports certificates to the node."},{"line_number":969,"context_line":""},{"line_number":970,"context_line":"    Exports certificates to the node based on the driver info"}],"source_content_type":"text/x-python","patch_set":11,"id":"87d9a6d8_9e248183","line":967,"range":{"start_line":967,"start_character":4,"end_line":967,"end_character":11},"in_reply_to":"6c2251f2_f14c9aee","updated":"2021-02-08 11:46:11.000000000","message":"Done","commit_id":"903d19d0cd6a32e94320e57d59775bfc7819c1da"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"5dae2851c2b635ec9b15cf6960ea0f8d28e48c80","unresolved":true,"context_lines":[{"line_number":965,"context_line":""},{"line_number":966,"context_line":""},{"line_number":967,"context_line":"def export_certificates(task, cert_file_list\u003dNone):"},{"line_number":968,"context_line":"    \"\"\"Exports certificates to the node."},{"line_number":969,"context_line":""},{"line_number":970,"context_line":"    Exports certificates to the node based on the driver info"},{"line_number":971,"context_line":"    provided."}],"source_content_type":"text/x-python","patch_set":11,"id":"b3abafe8_6050c750","line":968,"range":{"start_line":968,"start_character":7,"end_line":968,"end_character":14},"updated":"2021-01-06 05:26:47.000000000","message":"s/ Exports / Adds /","commit_id":"903d19d0cd6a32e94320e57d59775bfc7819c1da"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"45e244246cf8305f784c2715550d27b24d0b52d8","unresolved":false,"context_lines":[{"line_number":965,"context_line":""},{"line_number":966,"context_line":""},{"line_number":967,"context_line":"def export_certificates(task, cert_file_list\u003dNone):"},{"line_number":968,"context_line":"    \"\"\"Exports certificates to the node."},{"line_number":969,"context_line":""},{"line_number":970,"context_line":"    Exports certificates to the node based on the driver info"},{"line_number":971,"context_line":"    provided."}],"source_content_type":"text/x-python","patch_set":11,"id":"58ece0da_6436b2f2","line":968,"range":{"start_line":968,"start_character":7,"end_line":968,"end_character":14},"in_reply_to":"b3abafe8_6050c750","updated":"2021-02-08 11:46:11.000000000","message":"Done","commit_id":"903d19d0cd6a32e94320e57d59775bfc7819c1da"}],"releasenotes/notes/add-support-to-manage_certs-b6615e15f697bc26.yaml":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"0f95c0f24d1c7c03d9e8868c471211d5fcf1e3e1","unresolved":true,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds support to manage certificates in the iLO. A new driver info"},{"line_number":5,"context_line":"    parameter `ilo_export_certificates` is introduced which can be used"},{"line_number":6,"context_line":"    by the user to determine whether the certificates are required to be"},{"line_number":7,"context_line":"    exported to the server."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"fefe42ad_b7efbffc","line":5,"range":{"start_line":5,"start_character":15,"end_line":5,"end_character":38},"updated":"2020-12-07 14:20:42.000000000","message":"I\u0027m not sure I really agree with the word export being used. It feels like we\u0027re signaling we will extract the value from the BMC.","commit_id":"4312c5295b1e08d49daf141ef802a36c4f51d2fc"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"275c36a84bbcf133d0be5ee2a4c131025cc45001","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds support to manage certificates in the iLO. A new driver info"},{"line_number":5,"context_line":"    parameter `ilo_export_certificates` is introduced which can be used"},{"line_number":6,"context_line":"    by the user to determine whether the certificates are required to be"},{"line_number":7,"context_line":"    exported to the server."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"7436d88f_f11904cb","line":5,"range":{"start_line":5,"start_character":15,"end_line":5,"end_character":38},"in_reply_to":"6e1f3826_3a4f8644","updated":"2020-12-10 12:03:43.000000000","message":"Done","commit_id":"4312c5295b1e08d49daf141ef802a36c4f51d2fc"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"ebe51d07acd28fe43f35c25f348f0ed8456606ac","unresolved":true,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds support to manage certificates in the iLO. A new driver info"},{"line_number":5,"context_line":"    parameter `ilo_export_certificates` is introduced which can be used"},{"line_number":6,"context_line":"    by the user to determine whether the certificates are required to be"},{"line_number":7,"context_line":"    exported to the server."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"6e1f3826_3a4f8644","line":5,"range":{"start_line":5,"start_character":15,"end_line":5,"end_character":38},"in_reply_to":"fefe42ad_b7efbffc","updated":"2020-12-09 10:29:49.000000000","message":"Ok. Will it be ok if it is changed to \u0027ilo_add_certificates\u0027? If so, i am going to raise another patch with the change.","commit_id":"4312c5295b1e08d49daf141ef802a36c4f51d2fc"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"2fd669d967871e4d2b4921f987f59bb314f92a26","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds support to manage certificates in the iLO. A new driver info"},{"line_number":5,"context_line":"    parameter `ilo_add_certificates` is introduced which can be used"},{"line_number":6,"context_line":"    by the user to determine whether the certificates are required to be"},{"line_number":7,"context_line":"    exported to the server."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"44cc0cfc_ad604714","line":4,"range":{"start_line":4,"start_character":58,"end_line":4,"end_character":69},"updated":"2020-12-15 04:59:39.000000000","message":"s/ driver info / driver_info /","commit_id":"92cc97d09fdebaeb47c28b7c32f3f06a45c785de"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"2fd669d967871e4d2b4921f987f59bb314f92a26","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds support to manage certificates in the iLO. A new driver info"},{"line_number":5,"context_line":"    parameter `ilo_add_certificates` is introduced which can be used"},{"line_number":6,"context_line":"    by the user to determine whether the certificates are required to be"},{"line_number":7,"context_line":"    exported to the server."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"ecb98327_105dbebd","line":4,"range":{"start_line":4,"start_character":54,"end_line":4,"end_character":57},"updated":"2020-12-15 04:59:39.000000000","message":"s/ new / new boolean /","commit_id":"92cc97d09fdebaeb47c28b7c32f3f06a45c785de"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"50113cb7334cb79f4b71e61bea77165ed43bbfad","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds support to manage certificates in the iLO. A new driver info"},{"line_number":5,"context_line":"    parameter `ilo_add_certificates` is introduced which can be used"},{"line_number":6,"context_line":"    by the user to determine whether the certificates are required to be"},{"line_number":7,"context_line":"    exported to the server."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"b7f784a0_8e6d81ad","line":4,"range":{"start_line":4,"start_character":58,"end_line":4,"end_character":69},"in_reply_to":"44cc0cfc_ad604714","updated":"2020-12-15 07:19:31.000000000","message":"Done","commit_id":"92cc97d09fdebaeb47c28b7c32f3f06a45c785de"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"50113cb7334cb79f4b71e61bea77165ed43bbfad","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds support to manage certificates in the iLO. A new driver info"},{"line_number":5,"context_line":"    parameter `ilo_add_certificates` is introduced which can be used"},{"line_number":6,"context_line":"    by the user to determine whether the certificates are required to be"},{"line_number":7,"context_line":"    exported to the server."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"ce30d077_be3b79c7","line":4,"range":{"start_line":4,"start_character":54,"end_line":4,"end_character":57},"in_reply_to":"ecb98327_105dbebd","updated":"2020-12-15 07:19:31.000000000","message":"Done","commit_id":"92cc97d09fdebaeb47c28b7c32f3f06a45c785de"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"2fd669d967871e4d2b4921f987f59bb314f92a26","unresolved":true,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds support to manage certificates in the iLO. A new driver info"},{"line_number":5,"context_line":"    parameter `ilo_add_certificates` is introduced which can be used"},{"line_number":6,"context_line":"    by the user to determine whether the certificates are required to be"},{"line_number":7,"context_line":"    exported to the server."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"20ee1600_26dc86b4","line":5,"range":{"start_line":5,"start_character":14,"end_line":5,"end_character":36},"updated":"2020-12-15 04:59:39.000000000","message":"s/ `ilo_add_certificates` / ``ilo_add_certificates`` /","commit_id":"92cc97d09fdebaeb47c28b7c32f3f06a45c785de"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"50113cb7334cb79f4b71e61bea77165ed43bbfad","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds support to manage certificates in the iLO. A new driver info"},{"line_number":5,"context_line":"    parameter `ilo_add_certificates` is introduced which can be used"},{"line_number":6,"context_line":"    by the user to determine whether the certificates are required to be"},{"line_number":7,"context_line":"    exported to the server."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3de228df_9c623e71","line":5,"range":{"start_line":5,"start_character":14,"end_line":5,"end_character":36},"in_reply_to":"20ee1600_26dc86b4","updated":"2020-12-15 07:19:31.000000000","message":"Done","commit_id":"92cc97d09fdebaeb47c28b7c32f3f06a45c785de"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"2fd669d967871e4d2b4921f987f59bb314f92a26","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":10,"id":"04086885_43a3dfcd","line":8,"range":{"start_line":6,"start_character":19,"end_line":8,"end_character":0},"updated":"2020-12-15 04:59:39.000000000","message":"Is it to determine or to request addition of certificates to ilo?","commit_id":"92cc97d09fdebaeb47c28b7c32f3f06a45c785de"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"50113cb7334cb79f4b71e61bea77165ed43bbfad","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"cd897d86_1717faf7","line":8,"range":{"start_line":6,"start_character":19,"end_line":8,"end_character":0},"in_reply_to":"04086885_43a3dfcd","updated":"2020-12-15 07:19:31.000000000","message":"request. Will change it.","commit_id":"92cc97d09fdebaeb47c28b7c32f3f06a45c785de"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"5dae2851c2b635ec9b15cf6960ea0f8d28e48c80","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds support to manage certificates in the iLO. A new boolean driver_info"},{"line_number":5,"context_line":"    parameter ``ilo_add_certificates`` is introduced which can be used"},{"line_number":6,"context_line":"    by the user to request addition of certificates to the server."}],"source_content_type":"text/x-yaml","patch_set":11,"id":"27ce4a6c_30a68ef4","line":4,"range":{"start_line":4,"start_character":58,"end_line":4,"end_character":65},"updated":"2021-01-06 05:26:47.000000000","message":"s/ boolean / optional boolean /","commit_id":"903d19d0cd6a32e94320e57d59775bfc7819c1da"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"5dae2851c2b635ec9b15cf6960ea0f8d28e48c80","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds support to manage certificates in the iLO. A new boolean driver_info"},{"line_number":5,"context_line":"    parameter ``ilo_add_certificates`` is introduced which can be used"},{"line_number":6,"context_line":"    by the user to request addition of certificates to the server."}],"source_content_type":"text/x-yaml","patch_set":11,"id":"9660466b_7e71557f","line":4,"range":{"start_line":4,"start_character":40,"end_line":4,"end_character":50},"updated":"2021-01-06 05:26:47.000000000","message":"s/ in the iLO / to the ``ilo5`` hardware type /","commit_id":"903d19d0cd6a32e94320e57d59775bfc7819c1da"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"45e244246cf8305f784c2715550d27b24d0b52d8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds support to manage certificates in the iLO. A new boolean driver_info"},{"line_number":5,"context_line":"    parameter ``ilo_add_certificates`` is introduced which can be used"},{"line_number":6,"context_line":"    by the user to request addition of certificates to the server."}],"source_content_type":"text/x-yaml","patch_set":11,"id":"921aa1b2_5ab01b19","line":4,"range":{"start_line":4,"start_character":58,"end_line":4,"end_character":65},"in_reply_to":"27ce4a6c_30a68ef4","updated":"2021-02-08 11:46:11.000000000","message":"Done","commit_id":"903d19d0cd6a32e94320e57d59775bfc7819c1da"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"45e244246cf8305f784c2715550d27b24d0b52d8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds support to manage certificates in the iLO. A new boolean driver_info"},{"line_number":5,"context_line":"    parameter ``ilo_add_certificates`` is introduced which can be used"},{"line_number":6,"context_line":"    by the user to request addition of certificates to the server."}],"source_content_type":"text/x-yaml","patch_set":11,"id":"54731807_3c108163","line":4,"range":{"start_line":4,"start_character":40,"end_line":4,"end_character":50},"in_reply_to":"9660466b_7e71557f","updated":"2021-02-08 11:46:11.000000000","message":"Done","commit_id":"903d19d0cd6a32e94320e57d59775bfc7819c1da"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"5dae2851c2b635ec9b15cf6960ea0f8d28e48c80","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds support to manage certificates in the iLO. A new boolean driver_info"},{"line_number":5,"context_line":"    parameter ``ilo_add_certificates`` is introduced which can be used"},{"line_number":6,"context_line":"    by the user to request addition of certificates to the server."}],"source_content_type":"text/x-yaml","patch_set":11,"id":"192f74fd_309acf3a","line":6,"range":{"start_line":6,"start_character":59,"end_line":6,"end_character":65},"updated":"2021-01-06 05:26:47.000000000","message":"s/ server / iLO  with ``ilo-uefi-https`` boot interface. /","commit_id":"903d19d0cd6a32e94320e57d59775bfc7819c1da"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"45e244246cf8305f784c2715550d27b24d0b52d8","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds support to manage certificates in the iLO. A new boolean driver_info"},{"line_number":5,"context_line":"    parameter ``ilo_add_certificates`` is introduced which can be used"},{"line_number":6,"context_line":"    by the user to request addition of certificates to the server."}],"source_content_type":"text/x-yaml","patch_set":11,"id":"246d52c8_cfc75670","line":6,"range":{"start_line":6,"start_character":59,"end_line":6,"end_character":65},"in_reply_to":"192f74fd_309acf3a","updated":"2021-02-08 11:46:11.000000000","message":"Done","commit_id":"903d19d0cd6a32e94320e57d59775bfc7819c1da"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"3a10030f207581d25a03bc08e7f008e4aaf9dbba","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    Adds support to manage certificates to the ``ilo5`` hardware type. A new"},{"line_number":5,"context_line":"    optional boolean driver_info parameter ``ilo_add_certificates`` is"},{"line_number":6,"context_line":"    introduced which can be used by the user to request addition of"},{"line_number":7,"context_line":"    certificates to the iLO with ``ilo-uefi-https`` boot interface."}],"source_content_type":"text/x-yaml","patch_set":13,"id":"8b24f1dd_c1681a43","line":7,"range":{"start_line":7,"start_character":4,"end_line":7,"end_character":16},"updated":"2021-02-22 07:36:26.000000000","message":"s/ certificates / SSL certificates /","commit_id":"7d4c1214ffca486aca56aa6602a3bedb41f95baf"}]}