)]}'
{"ironic/conductor/cleaning.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"122ec1f899cab79e4f5b375d0ad23d2407a48da4","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        msg \u003d (_(\u0027Caching of bios settings failed on node %(node)s. \u0027"},{"line_number":90,"context_line":"                 \u0027Continuing with node cleaning.\u0027)"},{"line_number":91,"context_line":"               % {\u0027node\u0027: node.uuid})"},{"line_number":92,"context_line":"        LOG.exception(msg)"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    # Allow the deploy driver to set up the ramdisk again (necessary for"},{"line_number":95,"context_line":"    # IPA cleaning)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_6de99db5","side":"PARENT","line":92,"updated":"2020-11-10 11:03:57.000000000","message":"I\u0027d prefer to keep this functionality here, since it allows refreshing the information (at least until we get a periodic task). Removing it is also a behavior change that I\u0027d prefer to avoid.","commit_id":"08bf8dee65acead2b08ca4563a273cd9bb60c5b4"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"a6f51ab57a282c4d2ba34909dd0c19ae5640e32f","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        msg \u003d (_(\u0027Caching of bios settings failed on node %(node)s. \u0027"},{"line_number":90,"context_line":"                 \u0027Continuing with node cleaning.\u0027)"},{"line_number":91,"context_line":"               % {\u0027node\u0027: node.uuid})"},{"line_number":92,"context_line":"        LOG.exception(msg)"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    # Allow the deploy driver to set up the ramdisk again (necessary for"},{"line_number":95,"context_line":"    # IPA cleaning)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_10959933","side":"PARENT","line":92,"in_reply_to":"1f621f24_6de99db5","updated":"2020-11-10 16:43:40.000000000","message":"Done","commit_id":"08bf8dee65acead2b08ca4563a273cd9bb60c5b4"}],"ironic/conductor/manager.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"122ec1f899cab79e4f5b375d0ad23d2407a48da4","unresolved":false,"context_lines":[{"line_number":1700,"context_line":"            self._do_takeover(task)"},{"line_number":1701,"context_line":""},{"line_number":1702,"context_line":"            # Retrieve BIOS config settings for this node"},{"line_number":1703,"context_line":"            utils.node_cache_bios_settings(task, node)"},{"line_number":1704,"context_line":""},{"line_number":1705,"context_line":"            LOG.info(\"Successfully adopted node %(node)s\","},{"line_number":1706,"context_line":"                     {\u0027node\u0027: node.uuid})"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_cdd1d1fd","line":1703,"updated":"2020-11-10 11:03:57.000000000","message":"Adoption happens after manage so this is not strictly necessary.","commit_id":"4c6e66c02fd111e8c69e9122fa03667c11cf1d12"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"a6f51ab57a282c4d2ba34909dd0c19ae5640e32f","unresolved":false,"context_lines":[{"line_number":1700,"context_line":"            self._do_takeover(task)"},{"line_number":1701,"context_line":""},{"line_number":1702,"context_line":"            # Retrieve BIOS config settings for this node"},{"line_number":1703,"context_line":"            utils.node_cache_bios_settings(task, node)"},{"line_number":1704,"context_line":""},{"line_number":1705,"context_line":"            LOG.info(\"Successfully adopted node %(node)s\","},{"line_number":1706,"context_line":"                     {\u0027node\u0027: node.uuid})"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_f0a9fd7b","line":1703,"in_reply_to":"1f621f24_cdd1d1fd","updated":"2020-11-10 16:43:40.000000000","message":"Done","commit_id":"4c6e66c02fd111e8c69e9122fa03667c11cf1d12"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"93a0e54f806fa1562526003eb8ee4acd2316c525","unresolved":false,"context_lines":[{"line_number":1179,"context_line":"                task.process_event(\u0027done\u0027)"},{"line_number":1180,"context_line":""},{"line_number":1181,"context_line":"            # Retrieve BIOS config settings for this node"},{"line_number":1182,"context_line":"            utils.node_cache_bios_settings(task, node)"},{"line_number":1183,"context_line":""},{"line_number":1184,"context_line":"        else:"},{"line_number":1185,"context_line":"            node.last_error \u003d error"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_93d893ef","line":1182,"updated":"2020-11-10 18:31:14.000000000","message":"sorry, missed one more thing. this should happen before we call process_event(done), so right after line 1171. otherwise we may end up holding lock for a long time after moving the node to \u0027manageable\u0027.","commit_id":"1d5cecce220bc03780e3be447aafa9f67f68ed10"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"75edd8ea6ba1e46d2c6cfcc0a30a7682537572f3","unresolved":false,"context_lines":[{"line_number":1179,"context_line":"                task.process_event(\u0027done\u0027)"},{"line_number":1180,"context_line":""},{"line_number":1181,"context_line":"            # Retrieve BIOS config settings for this node"},{"line_number":1182,"context_line":"            utils.node_cache_bios_settings(task, node)"},{"line_number":1183,"context_line":""},{"line_number":1184,"context_line":"        else:"},{"line_number":1185,"context_line":"            node.last_error \u003d error"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_463d9bdb","line":1182,"in_reply_to":"1f621f24_93d893ef","updated":"2020-11-10 20:01:02.000000000","message":"Done","commit_id":"1d5cecce220bc03780e3be447aafa9f67f68ed10"}],"releasenotes/notes/bios-config-manage-adopt-ccefd24054cc73ee.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"122ec1f899cab79e4f5b375d0ad23d2407a48da4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Retrieve BIOS configuration settings when moving a node to ``manageable``"},{"line_number":5,"context_line":"    or ``adopting``.  In the case of ``manageable``, this allows the settings"},{"line_number":6,"context_line":"    to be used when choosing which node to deploy.  The settings are no longer"},{"line_number":7,"context_line":"    retrieved when moving the node to ``cleaning``.  For more details, see"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1f621f24_adce1557","line":4,"updated":"2020-11-10 11:03:57.000000000","message":"nit: Retrieves","commit_id":"4c6e66c02fd111e8c69e9122fa03667c11cf1d12"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"a6f51ab57a282c4d2ba34909dd0c19ae5640e32f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Retrieve BIOS configuration settings when moving a node to ``manageable``"},{"line_number":5,"context_line":"    or ``adopting``.  In the case of ``manageable``, this allows the settings"},{"line_number":6,"context_line":"    to be used when choosing which node to deploy.  The settings are no longer"},{"line_number":7,"context_line":"    retrieved when moving the node to ``cleaning``.  For more details, see"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1f621f24_10be39b3","line":4,"in_reply_to":"1f621f24_adce1557","updated":"2020-11-10 16:43:40.000000000","message":"Done","commit_id":"4c6e66c02fd111e8c69e9122fa03667c11cf1d12"}]}