)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e7f9241989bda2f73baa6e7292087c648d80c095","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This change allows users disabling automated cleaning on"},{"line_number":10,"context_line":"Node level."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Story: https://storyboard.openstack.org/#!/story/2008113"},{"line_number":13,"context_line":"Change-Id: If583bae4108b9bfa99cc460509af84696c7003c5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1f621f24_d4be55fd","line":12,"updated":"2020-11-12 17:33:28.000000000","message":"The syntax is:\n\n Story: #\u003cnumber\u003e\n Task: #\u003cnumber\u003e","commit_id":"700608a77080aae8671533f2ea7173099e288662"},{"author":{"_account_id":30955,"name":"Feruzjon Muyassarov","email":"feruzjon.muyassarov@est.tech","username":"fmuyassarov"},"change_message_id":"b431c892fd1825571fc9e9e5f55d24d8ebf1744e","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This change allows users disabling automated cleaning on"},{"line_number":10,"context_line":"Node level."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Story: https://storyboard.openstack.org/#!/story/2008113"},{"line_number":13,"context_line":"Change-Id: If583bae4108b9bfa99cc460509af84696c7003c5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1f621f24_86c4aa41","line":12,"in_reply_to":"1f621f24_d4be55fd","updated":"2020-11-13 12:27:36.000000000","message":"Thanks. Fixed.","commit_id":"700608a77080aae8671533f2ea7173099e288662"}],"ironic/api/controllers/v1/node.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e7f9241989bda2f73baa6e7292087c648d80c095","unresolved":false,"context_lines":[{"line_number":2351,"context_line":"                policy_checks.append(\u0027baremetal:node:update_instance_info\u0027)"},{"line_number":2352,"context_line":"            elif p[\u0027path\u0027].startswith(\u0027/extra\u0027):"},{"line_number":2353,"context_line":"                policy_checks.append(\u0027baremetal:node:update_extra\u0027)"},{"line_number":2354,"context_line":"            elif p[\u0027path\u0027].startswith(\u0027/disable_cleaning\u0027):"},{"line_number":2355,"context_line":"                policy_checks.append(\u0027baremetal:node:disable_cleaning\u0027)"},{"line_number":2356,"context_line":"            else:"},{"line_number":2357,"context_line":"                generic_update \u003d True"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f621f24_b4b91916","line":2354,"updated":"2020-11-12 17:33:28.000000000","message":"The path is automated_clean (it corresponds to the field we\u0027re changing), and you need to check that p[\u0027value\u0027] is False (not None or True)","commit_id":"700608a77080aae8671533f2ea7173099e288662"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"21cac475831c7c6760600f4338c7ff5f6ca4b41a","unresolved":false,"context_lines":[{"line_number":2351,"context_line":"                policy_checks.append(\u0027baremetal:node:update_instance_info\u0027)"},{"line_number":2352,"context_line":"            elif p[\u0027path\u0027].startswith(\u0027/extra\u0027):"},{"line_number":2353,"context_line":"                policy_checks.append(\u0027baremetal:node:update_extra\u0027)"},{"line_number":2354,"context_line":"            elif p[\u0027path\u0027].startswith(\u0027/disable_cleaning\u0027):"},{"line_number":2355,"context_line":"                policy_checks.append(\u0027baremetal:node:disable_cleaning\u0027)"},{"line_number":2356,"context_line":"            else:"},{"line_number":2357,"context_line":"                generic_update \u003d True"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f621f24_6f94b537","line":2354,"updated":"2020-11-16 00:02:48.000000000","message":"Rather than creating a new patch path /disable_cleaning, this patch call should be path /automated_clean with values False/None/True","commit_id":"7608eb554c2530836a0093a9335ed6a3eb25b200"},{"author":{"_account_id":30955,"name":"Feruzjon Muyassarov","email":"feruzjon.muyassarov@est.tech","username":"fmuyassarov"},"change_message_id":"db7e16df83d99879a06b83207b551a389611f206","unresolved":false,"context_lines":[{"line_number":2351,"context_line":"                policy_checks.append(\u0027baremetal:node:update_instance_info\u0027)"},{"line_number":2352,"context_line":"            elif p[\u0027path\u0027].startswith(\u0027/extra\u0027):"},{"line_number":2353,"context_line":"                policy_checks.append(\u0027baremetal:node:update_extra\u0027)"},{"line_number":2354,"context_line":"            elif p[\u0027path\u0027].startswith(\u0027/disable_cleaning\u0027):"},{"line_number":2355,"context_line":"                policy_checks.append(\u0027baremetal:node:disable_cleaning\u0027)"},{"line_number":2356,"context_line":"            else:"},{"line_number":2357,"context_line":"                generic_update \u003d True"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f621f24_e9a39dfe","line":2354,"in_reply_to":"1f621f24_6f94b537","updated":"2020-11-16 12:26:41.000000000","message":"Done","commit_id":"7608eb554c2530836a0093a9335ed6a3eb25b200"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e809997e7c94dd1830c607bb703f5fe37f78d07d","unresolved":true,"context_lines":[{"line_number":2351,"context_line":"                policy_checks.append(\u0027baremetal:node:update_instance_info\u0027)"},{"line_number":2352,"context_line":"            elif p[\u0027path\u0027].startswith(\u0027/extra\u0027):"},{"line_number":2353,"context_line":"                policy_checks.append(\u0027baremetal:node:update_extra\u0027)"},{"line_number":2354,"context_line":"            elif (p[\u0027path\u0027].startswith(\u0027/automated_clean\u0027) and p[\u0027value\u0027]"},{"line_number":2355,"context_line":"                    \u003d\u003d \u0027False\u0027):"},{"line_number":2356,"context_line":"                policy_checks.append(\u0027baremetal:node:disable_cleaning\u0027)"},{"line_number":2357,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":10,"id":"71259db2_60bee336","line":2354,"updated":"2020-11-24 09:35:06.000000000","message":"Could you add a unit test for this change? You can base on https://opendev.org/openstack/ironic/src/branch/master/ironic/tests/unit/api/controllers/v1/test_node.py#L3337 and use something like https://opendev.org/openstack/ironic/src/branch/master/ironic/tests/unit/api/controllers/v1/test_node.py#L3422-L3428 to stub out policy checks.","commit_id":"bddb5645ed87997135471e2d2c3247e93bf17c29"},{"author":{"_account_id":30955,"name":"Feruzjon Muyassarov","email":"feruzjon.muyassarov@est.tech","username":"fmuyassarov"},"change_message_id":"c84368edb012fb89c0def4d4343f70eb1651fb69","unresolved":false,"context_lines":[{"line_number":2351,"context_line":"                policy_checks.append(\u0027baremetal:node:update_instance_info\u0027)"},{"line_number":2352,"context_line":"            elif p[\u0027path\u0027].startswith(\u0027/extra\u0027):"},{"line_number":2353,"context_line":"                policy_checks.append(\u0027baremetal:node:update_extra\u0027)"},{"line_number":2354,"context_line":"            elif (p[\u0027path\u0027].startswith(\u0027/automated_clean\u0027) and p[\u0027value\u0027]"},{"line_number":2355,"context_line":"                    \u003d\u003d \u0027False\u0027):"},{"line_number":2356,"context_line":"                policy_checks.append(\u0027baremetal:node:disable_cleaning\u0027)"},{"line_number":2357,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":10,"id":"80d9a69b_e0209c20","line":2354,"in_reply_to":"71259db2_60bee336","updated":"2020-11-24 17:27:41.000000000","message":"Done","commit_id":"bddb5645ed87997135471e2d2c3247e93bf17c29"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e809997e7c94dd1830c607bb703f5fe37f78d07d","unresolved":true,"context_lines":[{"line_number":2352,"context_line":"            elif p[\u0027path\u0027].startswith(\u0027/extra\u0027):"},{"line_number":2353,"context_line":"                policy_checks.append(\u0027baremetal:node:update_extra\u0027)"},{"line_number":2354,"context_line":"            elif (p[\u0027path\u0027].startswith(\u0027/automated_clean\u0027) and p[\u0027value\u0027]"},{"line_number":2355,"context_line":"                    \u003d\u003d \u0027False\u0027):"},{"line_number":2356,"context_line":"                policy_checks.append(\u0027baremetal:node:disable_cleaning\u0027)"},{"line_number":2357,"context_line":"            else:"},{"line_number":2358,"context_line":"                generic_update \u003d True"}],"source_content_type":"text/x-python","patch_set":10,"id":"330f91d3_f0606088","line":2355,"updated":"2020-11-24 09:35:06.000000000","message":"I think it\u0027s a boolean, not a string, so likely\n\n and p[\u0027value\u0027] is False\n\nTo be sure you can use\n\n and strutils.bool_from_string(p[\u0027value\u0027], default\u003dNone) is False\n\nThis will handle both booleans and strings","commit_id":"bddb5645ed87997135471e2d2c3247e93bf17c29"},{"author":{"_account_id":30955,"name":"Feruzjon Muyassarov","email":"feruzjon.muyassarov@est.tech","username":"fmuyassarov"},"change_message_id":"c84368edb012fb89c0def4d4343f70eb1651fb69","unresolved":false,"context_lines":[{"line_number":2352,"context_line":"            elif p[\u0027path\u0027].startswith(\u0027/extra\u0027):"},{"line_number":2353,"context_line":"                policy_checks.append(\u0027baremetal:node:update_extra\u0027)"},{"line_number":2354,"context_line":"            elif (p[\u0027path\u0027].startswith(\u0027/automated_clean\u0027) and p[\u0027value\u0027]"},{"line_number":2355,"context_line":"                    \u003d\u003d \u0027False\u0027):"},{"line_number":2356,"context_line":"                policy_checks.append(\u0027baremetal:node:disable_cleaning\u0027)"},{"line_number":2357,"context_line":"            else:"},{"line_number":2358,"context_line":"                generic_update \u003d True"}],"source_content_type":"text/x-python","patch_set":10,"id":"f049d690_05f09528","line":2355,"in_reply_to":"330f91d3_f0606088","updated":"2020-11-24 17:27:41.000000000","message":"Done","commit_id":"bddb5645ed87997135471e2d2c3247e93bf17c29"}],"ironic/common/policy.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e7f9241989bda2f73baa6e7292087c648d80c095","unresolved":false,"context_lines":[{"line_number":262,"context_line":"        \u0027baremetal:node:disable_cleaning\u0027,"},{"line_number":263,"context_line":"        \u0027rule:baremetal:node:update\u0027,"},{"line_number":264,"context_line":"        \u0027Disable Node disk cleaning\u0027,"},{"line_number":265,"context_line":"        [{\u0027path\u0027: \u0027/nodes/{node_ident}\u0027, \u0027method\u0027: \u0027PATCH\u0027}])"},{"line_number":266,"context_line":"]"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"port_policies \u003d ["}],"source_content_type":"text/x-python","patch_set":4,"id":"1f621f24_143a8d97","line":265,"updated":"2020-11-12 17:33:28.000000000","message":"nit: add a trailing comma","commit_id":"700608a77080aae8671533f2ea7173099e288662"},{"author":{"_account_id":30955,"name":"Feruzjon Muyassarov","email":"feruzjon.muyassarov@est.tech","username":"fmuyassarov"},"change_message_id":"b431c892fd1825571fc9e9e5f55d24d8ebf1744e","unresolved":false,"context_lines":[{"line_number":262,"context_line":"        \u0027baremetal:node:disable_cleaning\u0027,"},{"line_number":263,"context_line":"        \u0027rule:baremetal:node:update\u0027,"},{"line_number":264,"context_line":"        \u0027Disable Node disk cleaning\u0027,"},{"line_number":265,"context_line":"        [{\u0027path\u0027: \u0027/nodes/{node_ident}\u0027, \u0027method\u0027: \u0027PATCH\u0027}])"},{"line_number":266,"context_line":"]"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"port_policies \u003d ["}],"source_content_type":"text/x-python","patch_set":4,"id":"1f621f24_e6b3dee7","line":265,"in_reply_to":"1f621f24_143a8d97","updated":"2020-11-13 12:27:36.000000000","message":"Done","commit_id":"700608a77080aae8671533f2ea7173099e288662"}],"ironic/conductor/utils.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e7f9241989bda2f73baa6e7292087c648d80c095","unresolved":false,"context_lines":[{"line_number":862,"context_line":"    :param node: the node to consider"},{"line_number":863,"context_line":"    \"\"\""},{"line_number":864,"context_line":"    if node.automated_clean:"},{"line_number":865,"context_line":"        return not CONF.conductor.automated_clean and node.automated_clean"},{"line_number":866,"context_line":"    else:"},{"line_number":867,"context_line":"        LOG.info(\u0027Automated cleaning is disabled for node %s.\u0027, node.uuid)"},{"line_number":868,"context_line":"        return not CONF.conductor.automated_clean and not node.automated_clean"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f621f24_f43c3194","line":865,"updated":"2020-11-12 17:33:28.000000000","message":"the 2nd part is redundant, we already know it\u0027s true","commit_id":"700608a77080aae8671533f2ea7173099e288662"},{"author":{"_account_id":30955,"name":"Feruzjon Muyassarov","email":"feruzjon.muyassarov@est.tech","username":"fmuyassarov"},"change_message_id":"b431c892fd1825571fc9e9e5f55d24d8ebf1744e","unresolved":false,"context_lines":[{"line_number":862,"context_line":"    :param node: the node to consider"},{"line_number":863,"context_line":"    \"\"\""},{"line_number":864,"context_line":"    if node.automated_clean:"},{"line_number":865,"context_line":"        return not CONF.conductor.automated_clean and node.automated_clean"},{"line_number":866,"context_line":"    else:"},{"line_number":867,"context_line":"        LOG.info(\u0027Automated cleaning is disabled for node %s.\u0027, node.uuid)"},{"line_number":868,"context_line":"        return not CONF.conductor.automated_clean and not node.automated_clean"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f621f24_06b1bae1","line":865,"in_reply_to":"1f621f24_f43c3194","updated":"2020-11-13 12:27:36.000000000","message":"Ah, right","commit_id":"700608a77080aae8671533f2ea7173099e288662"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e7f9241989bda2f73baa6e7292087c648d80c095","unresolved":false,"context_lines":[{"line_number":863,"context_line":"    \"\"\""},{"line_number":864,"context_line":"    if node.automated_clean:"},{"line_number":865,"context_line":"        return not CONF.conductor.automated_clean and node.automated_clean"},{"line_number":866,"context_line":"    else:"},{"line_number":867,"context_line":"        LOG.info(\u0027Automated cleaning is disabled for node %s.\u0027, node.uuid)"},{"line_number":868,"context_line":"        return not CONF.conductor.automated_clean and not node.automated_clean"},{"line_number":869,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1f621f24_54408507","line":866,"updated":"2020-11-12 17:33:28.000000000","message":"we need to explicitly handle the case of None (meaning \"use the default\"). I think the right logic is:\n\n if node.automated_clean:\n     return True\n elif node.automated_clean is None:\n     return CONF.conductor_automated_clean\n else:\n     LOG...\n     return False","commit_id":"700608a77080aae8671533f2ea7173099e288662"},{"author":{"_account_id":30955,"name":"Feruzjon Muyassarov","email":"feruzjon.muyassarov@est.tech","username":"fmuyassarov"},"change_message_id":"db7e16df83d99879a06b83207b551a389611f206","unresolved":false,"context_lines":[{"line_number":863,"context_line":"    \"\"\""},{"line_number":864,"context_line":"    if node.automated_clean:"},{"line_number":865,"context_line":"        return not CONF.conductor.automated_clean and node.automated_clean"},{"line_number":866,"context_line":"    else:"},{"line_number":867,"context_line":"        LOG.info(\u0027Automated cleaning is disabled for node %s.\u0027, node.uuid)"},{"line_number":868,"context_line":"        return not CONF.conductor.automated_clean and not node.automated_clean"},{"line_number":869,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1f621f24_89a029f6","line":866,"in_reply_to":"1f621f24_54408507","updated":"2020-11-16 12:26:41.000000000","message":"Maybe vice versa of the return values?\n\n    if node.automated_clean:\n        return False\n    elif node.automated_clean is None:\n        return not CONF.conductor.automated_clean\n    else:\n        log....\n        return True","commit_id":"700608a77080aae8671533f2ea7173099e288662"},{"author":{"_account_id":30955,"name":"Feruzjon Muyassarov","email":"feruzjon.muyassarov@est.tech","username":"fmuyassarov"},"change_message_id":"b431c892fd1825571fc9e9e5f55d24d8ebf1744e","unresolved":false,"context_lines":[{"line_number":863,"context_line":"    \"\"\""},{"line_number":864,"context_line":"    if node.automated_clean:"},{"line_number":865,"context_line":"        return not CONF.conductor.automated_clean and node.automated_clean"},{"line_number":866,"context_line":"    else:"},{"line_number":867,"context_line":"        LOG.info(\u0027Automated cleaning is disabled for node %s.\u0027, node.uuid)"},{"line_number":868,"context_line":"        return not CONF.conductor.automated_clean and not node.automated_clean"},{"line_number":869,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1f621f24_a6bd66b8","line":866,"in_reply_to":"1f621f24_54408507","updated":"2020-11-13 12:27:36.000000000","message":"Yeah, this looks better to me too:). Thanks","commit_id":"700608a77080aae8671533f2ea7173099e288662"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e7f9241989bda2f73baa6e7292087c648d80c095","unresolved":false,"context_lines":[{"line_number":864,"context_line":"    if node.automated_clean:"},{"line_number":865,"context_line":"        return not CONF.conductor.automated_clean and node.automated_clean"},{"line_number":866,"context_line":"    else:"},{"line_number":867,"context_line":"        LOG.info(\u0027Automated cleaning is disabled for node %s.\u0027, node.uuid)"},{"line_number":868,"context_line":"        return not CONF.conductor.automated_clean and not node.automated_clean"},{"line_number":869,"context_line":""},{"line_number":870,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1f621f24_34434915","line":867,"updated":"2020-11-12 17:33:28.000000000","message":"\".. via the API\" or something like that","commit_id":"700608a77080aae8671533f2ea7173099e288662"},{"author":{"_account_id":30955,"name":"Feruzjon Muyassarov","email":"feruzjon.muyassarov@est.tech","username":"fmuyassarov"},"change_message_id":"b431c892fd1825571fc9e9e5f55d24d8ebf1744e","unresolved":false,"context_lines":[{"line_number":864,"context_line":"    if node.automated_clean:"},{"line_number":865,"context_line":"        return not CONF.conductor.automated_clean and node.automated_clean"},{"line_number":866,"context_line":"    else:"},{"line_number":867,"context_line":"        LOG.info(\u0027Automated cleaning is disabled for node %s.\u0027, node.uuid)"},{"line_number":868,"context_line":"        return not CONF.conductor.automated_clean and not node.automated_clean"},{"line_number":869,"context_line":""},{"line_number":870,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1f621f24_66a6aead","line":867,"in_reply_to":"1f621f24_34434915","updated":"2020-11-13 12:27:36.000000000","message":"Done","commit_id":"700608a77080aae8671533f2ea7173099e288662"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e809997e7c94dd1830c607bb703f5fe37f78d07d","unresolved":true,"context_lines":[{"line_number":866,"context_line":"    elif node.automated_clean is None:"},{"line_number":867,"context_line":"        return not CONF.conductor.automated_clean"},{"line_number":868,"context_line":"    else:"},{"line_number":869,"context_line":"        LOG.info(\u0027Automated cleaning is disabled via the API for \\"},{"line_number":870,"context_line":"            node %s.\u0027, node.uuid)"},{"line_number":871,"context_line":"        return True"},{"line_number":872,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"da0541f0_3ef4f718","line":869,"updated":"2020-11-24 09:35:06.000000000","message":"nit: we tend not to break strings using \\","commit_id":"bddb5645ed87997135471e2d2c3247e93bf17c29"},{"author":{"_account_id":30955,"name":"Feruzjon Muyassarov","email":"feruzjon.muyassarov@est.tech","username":"fmuyassarov"},"change_message_id":"c84368edb012fb89c0def4d4343f70eb1651fb69","unresolved":false,"context_lines":[{"line_number":866,"context_line":"    elif node.automated_clean is None:"},{"line_number":867,"context_line":"        return not CONF.conductor.automated_clean"},{"line_number":868,"context_line":"    else:"},{"line_number":869,"context_line":"        LOG.info(\u0027Automated cleaning is disabled via the API for \\"},{"line_number":870,"context_line":"            node %s.\u0027, node.uuid)"},{"line_number":871,"context_line":"        return True"},{"line_number":872,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"2f8db2c0_c6c70eae","line":869,"in_reply_to":"da0541f0_3ef4f718","updated":"2020-11-24 17:27:41.000000000","message":"Done","commit_id":"bddb5645ed87997135471e2d2c3247e93bf17c29"}],"releasenotes/notes/allow_to_disable_automated_clean-a3ccb1e19940a7a4.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e7f9241989bda2f73baa6e7292087c648d80c095","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Allows disabling automated cleaning per node if it is enabled globally."},{"line_number":5,"context_line":"    An existing ``automated_clean`` field will allow disabling of automated"},{"line_number":6,"context_line":"    cleaning on the node object. Automated clean can be disabled on node level"},{"line_number":7,"context_line":"    for a specific nodes, while it is enabled globally."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1f621f24_944dfd3f","line":7,"updated":"2020-11-12 17:33:28.000000000","message":"nit: I think the last sentence is redundant","commit_id":"700608a77080aae8671533f2ea7173099e288662"},{"author":{"_account_id":30955,"name":"Feruzjon Muyassarov","email":"feruzjon.muyassarov@est.tech","username":"fmuyassarov"},"change_message_id":"b431c892fd1825571fc9e9e5f55d24d8ebf1744e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Allows disabling automated cleaning per node if it is enabled globally."},{"line_number":5,"context_line":"    An existing ``automated_clean`` field will allow disabling of automated"},{"line_number":6,"context_line":"    cleaning on the node object. Automated clean can be disabled on node level"},{"line_number":7,"context_line":"    for a specific nodes, while it is enabled globally."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1f621f24_e69abe5f","line":7,"in_reply_to":"1f621f24_944dfd3f","updated":"2020-11-13 12:27:36.000000000","message":"Agree, removed.","commit_id":"700608a77080aae8671533f2ea7173099e288662"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e809997e7c94dd1830c607bb703f5fe37f78d07d","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Allows disabling automated cleaning per node if it is enabled globally."},{"line_number":5,"context_line":"    An existing ``automated_clean`` field will allow disabling of automated"},{"line_number":6,"context_line":"    cleaning on the node object."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"e82fa952_46344d7d","line":6,"updated":"2020-11-24 09:35:06.000000000","message":"Let\u0027s mention the new policy?","commit_id":"bddb5645ed87997135471e2d2c3247e93bf17c29"},{"author":{"_account_id":30955,"name":"Feruzjon Muyassarov","email":"feruzjon.muyassarov@est.tech","username":"fmuyassarov"},"change_message_id":"c84368edb012fb89c0def4d4343f70eb1651fb69","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Allows disabling automated cleaning per node if it is enabled globally."},{"line_number":5,"context_line":"    An existing ``automated_clean`` field will allow disabling of automated"},{"line_number":6,"context_line":"    cleaning on the node object."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"75331c2d_c0d2272b","line":6,"in_reply_to":"e82fa952_46344d7d","updated":"2020-11-24 17:27:41.000000000","message":"Done","commit_id":"bddb5645ed87997135471e2d2c3247e93bf17c29"}]}