)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"edc3d1ee0643f45ee395e9f60096c0eabfdd0862","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Implement clean_dhcp_opts in neuton DHCP provider"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Afther a node has been provisioned the DHCP options"},{"line_number":10,"context_line":"on the neutron port must be cleaned up when the"},{"line_number":11,"context_line":"\u0027flat\u0027 network interface is used."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"If the options are not removed a baremtal node, which"},{"line_number":14,"context_line":"is statically configured to network boot (first) and"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"d9a87f25_dfb0c9ec","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":33},"updated":"2020-12-03 17:26:00.000000000","message":"Without running into patch details, this actually happens for \"neutron\" network interface too, it could be a security issue by leaking those option values in the tenant ports for an instance that expected to be local boot.","commit_id":"2477342c42c99f9723502d5774b0f033c7ec7fb5"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"56df144aeda81a65a699e974e6a328835698d79d","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Implement clean_dhcp_opts in neuton DHCP provider"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Afther a node has been provisioned the DHCP options"},{"line_number":10,"context_line":"on the neutron port must be cleaned up when the"},{"line_number":11,"context_line":"\u0027flat\u0027 network interface is used."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"If the options are not removed a baremtal node, which"},{"line_number":14,"context_line":"is statically configured to network boot (first) and"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"c1d1ff1a_e18bd104","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":33},"in_reply_to":"0ab63eb7_87a978d8","updated":"2020-12-04 11:32:24.000000000","message":"I stand corrected. Thanks Kaifeng, I tend to agree with you that this is a potential security concern.","commit_id":"2477342c42c99f9723502d5774b0f033c7ec7fb5"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"c46f72686c667cb632ac58f2073656713e82cb24","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Implement clean_dhcp_opts in neuton DHCP provider"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Afther a node has been provisioned the DHCP options"},{"line_number":10,"context_line":"on the neutron port must be cleaned up when the"},{"line_number":11,"context_line":"\u0027flat\u0027 network interface is used."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"If the options are not removed a baremtal node, which"},{"line_number":14,"context_line":"is statically configured to network boot (first) and"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"0ab63eb7_87a978d8","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":33},"in_reply_to":"89703049_75832060","updated":"2020-12-04 06:29:59.000000000","message":"It is, but ironic also configures tenant ports after provisioning, as I see it in the deployment of stable/train, the extra_dhcp_opts has configurations at provisioning network plane. I am not aware of changes on this so assume it\u0027s still there.\n\nA fresh example: http://paste.openstack.org/show/800722/","commit_id":"2477342c42c99f9723502d5774b0f033c7ec7fb5"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"31dded73c7b996913303d8ee665e5f345eb51fb1","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Implement clean_dhcp_opts in neuton DHCP provider"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Afther a node has been provisioned the DHCP options"},{"line_number":10,"context_line":"on the neutron port must be cleaned up when the"},{"line_number":11,"context_line":"\u0027flat\u0027 network interface is used."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"If the options are not removed a baremtal node, which"},{"line_number":14,"context_line":"is statically configured to network boot (first) and"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"89703049_75832060","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":33},"in_reply_to":"d9a87f25_dfb0c9ec","updated":"2020-12-03 18:08:20.000000000","message":"With neutron interface Ironic always(?) creates a dedicated port for provisioning, then deatached and deletes it before attaching the tenant port. The tenant port never get the extra_dhcp_opts in that case.","commit_id":"2477342c42c99f9723502d5774b0f033c7ec7fb5"}]}